@percy/core 1.29.1-beta.1 → 1.29.2-beta.0

package/dist/network.js

@@ -1,7 +1,7 @@
 import { request as makeRequest } from '@percy/client/utils';
 import logger from '@percy/logger';
 import mime from 'mime-types';
-import { DefaultMap, createResource, decodeAndEncodeURLWithLogging, hostnameMatches, normalizeURL, waitFor } from './utils.js';
+import { DefaultMap, createResource, hostnameMatches, normalizeURL, waitFor } from './utils.js';
 const MAX_RESOURCE_SIZE = 25 * 1024 ** 2; // 25MB
 const ALLOWED_STATUSES = [200, 201, 301, 302, 304, 307, 308];
 const ALLOWED_RESOURCES = ['Document', 'Stylesheet', 'Image', 'Media', 'Font', 'Other'];
@@ -213,17 +213,6 @@ export class Network {
 
     // do not handle data urls
     if (request.url.startsWith('data:')) return;
-
-    // Browsers handle URL encoding leniently, but invalid characters can break tools like Jackproxy.
-    // This code checks for issues such as `%` and leading spaces and warns the user accordingly.
-    decodeAndEncodeURLWithLogging(request.url, this.log, {
-      meta: {
-        ...this.meta,
-        url: request.url
-      },
-      shouldLogWarning: true,
-      warningMessage: `An invalid URL was detected for url: ${request.url} - the snapshot may fail on Percy. Please verify that your asset URL is valid.`
-    });
     if (this.intercept) {
       this.#pending.set(requestId, event);
       if (this.captureMockedServiceWorker) {

package/dist/percy.js

@@ -146,7 +146,7 @@ export class Percy {
 
     // validate provided config options
     let errors = PercyConfig.validate(config);
-    if (errors) {
+    if ((errors === null || errors === void 0 ? void 0 : errors.length) > 0) {
       this.log.warn('Invalid config:');
       for (let e of errors) this.log.warn(`- ${e.path}: ${e.message}`);
     }
@@ -177,7 +177,7 @@ export class Percy {
     this.readyState = 0;
     try {
       if (process.env.PERCY_CLIENT_ERROR_LOGS !== 'false') {
-        this.log.warn('Notice: Percy collects CI logs for service improvement, stored for 30 days. Opt-out anytime with export PERCY_CLIENT_ERROR_LOGS=false');
+        this.log.warn('Notice: Percy collects CI logs to improve service and enhance your experience. These logs help us debug issues and provide insights on your dashboards, making it easier to optimize the product experience. Logs are stored securely for 30 days. You can opt out anytime with export PERCY_CLIENT_ERROR_LOGS=false, but keeping this enabled helps us offer the best support and features.');
       }
       // Not awaiting proxy check as this can be asyncronous when not enabled
       const detectProxy = detectSystemProxyAndLog(this.config.percy.useSystemProxy);
@@ -417,7 +417,7 @@ export class Percy {
         ...comparison
       } = options;
       let errors = PercyConfig.validate(comparison, '/comparison');
-      if (errors) {
+      if ((errors === null || errors === void 0 ? void 0 : errors.length) > 0) {
         this.log.warn('Invalid upload options:');
         for (let e of errors) this.log.warn(`- ${e.path}: ${e.message}`);
       }

package/dist/snapshot.js

@@ -3,7 +3,7 @@ import PercyConfig from '@percy/config';
 import micromatch from 'micromatch';
 import { configSchema } from './config.js';
 import Queue from './queue.js';
-import { request, hostnameMatches, yieldTo, snapshotLogName, decodeAndEncodeURLWithLogging } from './utils.js';
+import { request, hostnameMatches, yieldTo, snapshotLogName } from './utils.js';
 import { JobData } from './wait-for-job.js';
 
 // Throw a better error message for missing or invalid urls
@@ -17,23 +17,6 @@ function validURL(url, base) {
     throw new Error(`Invalid snapshot URL: ${e.input}`);
   }
 }
-function validateAndFixSnapshotUrl(snapshot) {
-  let log = logger('core:snapshot');
-  // encoding snapshot url, if contians invalid URI characters/syntax
-  let modifiedURL = decodeAndEncodeURLWithLogging(snapshot.url, log, {
-    meta: {
-      snapshot: {
-        name: snapshot.name || snapshot.url
-      }
-    },
-    shouldLogWarning: true,
-    warningMessage: `Invalid URL detected for url: ${snapshot.url} - the snapshot may fail on Percy. Please confirm that your website URL is valid.`
-  });
-  if (modifiedURL !== snapshot.url) {
-    log.debug(`Snapshot URL modified to: ${modifiedURL}`);
-    snapshot.url = modifiedURL;
-  }
-}
 
 // used to deserialize regular expression strings
 const RE_REGEXP = /^\/(.+)\/(\w+)?$/;
@@ -103,9 +86,9 @@ function mapSnapshotOptions(snapshots, context) {
     if (typeof snapshot === 'string') snapshot = {
       url: snapshot
     };
-    validateAndFixSnapshotUrl(snapshot);
-    let url = validURL(snapshot.url, context === null || context === void 0 ? void 0 : context.baseUrl);
+
     // normalize the snapshot url and use it for the default name
+    let url = validURL(snapshot.url, context === null || context === void 0 ? void 0 : context.baseUrl);
     (_snapshot = snapshot).name || (_snapshot.name = `${url.pathname}${url.search}${url.hash}`);
     snapshot.url = url.href;
 
@@ -226,7 +209,7 @@ export function validateSnapshotOptions(options) {
 
   // warn on validation errors
   let errors = PercyConfig.validate(migrated, schema);
-  if (errors) {
+  if ((errors === null || errors === void 0 ? void 0 : errors.length) > 0) {
     log.warn('Invalid snapshot options:');
     for (let e of errors) log.warn(`- ${e.path}: ${e.message}`);
   }

package/dist/utils.js

@@ -379,35 +379,6 @@ export function redactSecrets(data) {
 export function base64encode(content) {
   return Buffer.from(content).toString('base64');
 }
-
-// This function replaces invalid character that are not the
-// part of valid URI syntax with there correct encoded value.
-// Also, if a character is a part of valid URI syntax, those characters
-// are not encoded
-// Eg: [abc] -> gets encoded to %5Babc%5D
-// ab c -> ab%20c
-export function decodeAndEncodeURLWithLogging(url, logger, options = {}) {
-  // In case the url is partially encoded, then directly using encodeURI()
-  // will encode those characters again. Therefore decodeURI once helps is decoding
-  // partially encoded URL and then after encoding it again, full URL get encoded
-  // correctly.
-  const {
-    meta,
-    shouldLogWarning,
-    warningMessage
-  } = options;
-  try {
-    let decodedURL = decodeURI(url); // This can throw error, so handle it will trycatch
-    let encodedURL = encodeURI(decodedURL);
-    return encodedURL;
-  } catch (error) {
-    logger.debug(error, meta);
-    if (error.name === 'URIError' && shouldLogWarning) {
-      logger.warn(warningMessage);
-    }
-    return url;
-  }
-}
 export function snapshotLogName(name, meta) {
   var _meta$snapshot;
   if (meta !== null && meta !== void 0 && (_meta$snapshot = meta.snapshot) !== null && _meta$snapshot !== void 0 && _meta$snapshot.testCase) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/core",
-  "version": "1.29.1-beta.1",
+  "version": "1.29.2-beta.0",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -43,11 +43,11 @@
     "test:types": "tsd"
   },
   "dependencies": {
-    "@percy/client": "1.29.1-beta.1",
-    "@percy/config": "1.29.1-beta.1",
-    "@percy/dom": "1.29.1-beta.1",
-    "@percy/logger": "1.29.1-beta.1",
-    "@percy/webdriver-utils": "1.29.1-beta.1",
+    "@percy/client": "1.29.2-beta.0",
+    "@percy/config": "1.29.2-beta.0",
+    "@percy/dom": "1.29.2-beta.0",
+    "@percy/logger": "1.29.2-beta.0",
+    "@percy/webdriver-utils": "1.29.2-beta.0",
     "content-disposition": "^0.5.4",
     "cross-spawn": "^7.0.3",
     "extract-zip": "^2.0.1",
@@ -60,5 +60,5 @@
     "ws": "^8.17.1",
     "yaml": "^2.4.1"
   },
-  "gitHead": "2f7608ef82f7d8b3da06f0dbcaba57567230c0ed"
+  "gitHead": "5e1526d9d9b3e08f3f667de97f340c3ac8c3809c"
 }