@percy/core 1.11.0 → 1.12.0

package/dist/network.js

@@ -72,19 +72,22 @@ export class Network {
       timeout: Network.TIMEOUT,
       idle: timeout
     }).catch(error => {
-      // throw a better timeout error
       if (error.message.startsWith('Timeout')) {
-        let msg = 'Timed out waiting for network requests to idle.';
-
-        if (this.log.shouldLog('debug')) {
-          msg += `\n\n  ${['Active requests:', ...requests.map(r => r.url)].join('\n  - ')}\n`;
-        }
-
-        throw new Error(msg);
+        this._throwTimeoutError('Timed out waiting for network requests to idle.', filter);
       } else {
         throw error;
       }
     });
+  } // Throw a better network timeout error
+
+
+  _throwTimeoutError(msg, filter = () => true) {
+    if (this.log.shouldLog('debug')) {
+      let reqs = Array.from(this.#requests.values()).filter(filter).map(r => r.url);
+      msg += `\n\n  ${['Active requests:', ...reqs].join('\n  - ')}\n`;
+    }
+
+    throw new Error(msg);
   } // Called when a request should be removed from various trackers
 
 
@@ -307,6 +310,8 @@ async function sendResponseResource(network, request, session) {
       });
     }
   } catch (error) {
+    /* istanbul ignore next: too hard to test (create race condition) */
+    if (session.closing && error.message.includes('close')) return;
     log.debug(`Encountered an error handling request: ${url}`, meta);
     log.debug(error);
     /* istanbul ignore next: catch race condition */

package/dist/page.js

@@ -86,12 +86,18 @@ export class Page {
         return handlers.every(handler => handler.finished);
       }, Page.TIMEOUT)]);
     } catch (error) {
-      // remove handlers and modify the error message
-      for (let handler of handlers) handler.off();
+      // remove any unused handlers
+      for (let handler of handlers) handler.off(); // assign context to unknown errors
 
-      throw Object.assign(error, {
-        message: `Navigation failed: ${error.message}`
-      });
+
+      if (!error.message.startsWith('Timeout')) {
+        throw Object.assign(error, {
+          message: `Navigation failed: ${error.message}`
+        });
+      } // throw a network error to show active requests
+
+
+      this.network._throwTimeoutError(`Navigation failed: Timed out waiting for the page ${waitUntil} event`);
     }
 
     this.log.debug('Page navigated', this.meta);

package/dist/session.js

@@ -23,7 +23,8 @@ export class Session extends EventEmitter {
   }
 
   async close() {
-    if (!this.browser) return;
+    if (!this.browser || this.closing) return;
+    this.closing = true;
     await this.browser.send('Target.closeTarget', {
       targetId: this.targetId
     }).catch(this._handleClosedError);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/core",
-  "version": "1.11.0",
+  "version": "1.12.0",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -39,10 +39,10 @@
     "test:types": "tsd"
   },
   "dependencies": {
-    "@percy/client": "1.11.0",
-    "@percy/config": "1.11.0",
-    "@percy/dom": "1.11.0",
-    "@percy/logger": "1.11.0",
+    "@percy/client": "1.12.0",
+    "@percy/config": "1.12.0",
+    "@percy/dom": "1.12.0",
+    "@percy/logger": "1.12.0",
     "content-disposition": "^0.5.4",
     "cross-spawn": "^7.0.3",
     "extract-zip": "^2.0.1",
@@ -53,5 +53,5 @@
     "rimraf": "^3.0.2",
     "ws": "^8.0.0"
   },
-  "gitHead": "0a5043cd677266390889063924f342af9b347055"
+  "gitHead": "4303b74df91f60e36065141289d2ef2277d1d6fc"
 }