@peopl-health/nexus 5.67.0-dev.11930 → 5.67.0

package/lib/clinical/services/nutritionPlanService.js

@@ -1,14 +1,18 @@
+const { Config_ID } = require('../../config/airtableConfig');
+const { fieldEquals } = require('../../helpers/airtableFormulaHelper');
+const { getRecordByFilter } = require('../../services/airtableService');
 const { safeParse, isPlainObject } = require('../../utils/jsonUtils');
 const { logger } = require('../../utils/logger');
 const { sanitizeInlineText } = require('../../utils/sanitizerUtils');
 const { withTimeout } = require('../../utils/timeoutUtils');
-const { composePrompt } = require('./promptComposerService');
 
 const NUTRITION_GUIDE_PROMPT_ID = 'nutrition_plan_guide';
 const PLAN_MAX_CHARS = 1500;
 const GUIDE_MAX_CHARS = 2000;
 const ISO_DATE_RX = /^\d{4}-\d{2}-\d{2}$/;
 const GUIDE_TIMEOUT_MS = 3000;
+const GUIDE_REFRESH_MS = 5 * 60 * 1000;
+const GUIDE_RETRY_MS = 30 * 1000;
 
 // Each line of a plan or guide is one kind of indication, so the breaks survive and only each line is flattened.
 function keepLines(text, maxChars) {
@@ -32,43 +36,42 @@ function readPlanSection(section) {
   return { text: typeof text === 'string' ? text : '', reviewBy };
 }
 
-let lastGuide = '';
+// The guide is served from memory and refreshed in the background: only the very first read can hold a
+// turn (up to GUIDE_TIMEOUT_MS), and there is never more than one Airtable read in flight.
+let guide = { text: '', freshUntil: 0 };
 let guideRead = null;
-let readSeq = 0;
-let appliedSeq = 0;
 
-function readGuide() {
+function refreshGuide() {
   if (guideRead) return guideRead;
-  const seq = ++readSeq;
-  const read = composePrompt({ promptId: NUTRITION_GUIDE_PROMPT_ID })
-    .then(({ resolvedPrompt }) => {
-      // A read that hung past a newer one must not overwrite what the newer one found.
-      if (seq > appliedSeq) {
-        appliedSeq = seq;
-        lastGuide = keepLines(resolvedPrompt || '', GUIDE_MAX_CHARS);
-      }
-      return lastGuide;
+  // Read straight from Airtable: the in-memory copy is this guide's only cache.
+  guideRead = getRecordByFilter(Config_ID, 'responses', fieldEquals('prompt_id', NUTRITION_GUIDE_PROMPT_ID))
+    .then((records) => {
+      const text = keepLines(records?.[0]?.content || '', GUIDE_MAX_CHARS);
+      // A missing row reads as empty: keep the last guide and look again soon rather than in five minutes.
+      guide = text
+        ? { text, freshUntil: Date.now() + GUIDE_REFRESH_MS }
+        : { ...guide, freshUntil: Date.now() + GUIDE_RETRY_MS };
     })
     .catch((error) => {
-      logger.warn('[nutritionPlanService] nutrition guide unreadable; using the last one read', { error: error.message });
-      return lastGuide;
+      logger.warn('[nutritionPlanService] nutrition guide unreadable; keeping the last one read', { error: error.message });
+      guide = { ...guide, freshUntil: Date.now() + GUIDE_RETRY_MS };
     })
-    .finally(() => { if (guideRead === read) guideRead = null; });
-  guideRead = read;
-  return read;
+    .finally(() => { guideRead = null; });
+  return guideRead;
 }
 
-// The guide only adds to the plan, so a slow read must not hold the patient's turn,
-// and a read that never settles must not hold every later turn either.
 async function loadNutritionGuide() {
-  const read = readGuide();
+  if (guide.freshUntil) {
+    if (Date.now() >= guide.freshUntil) refreshGuide();
+    return guide.text;
+  }
   try {
-    return await withTimeout(read, GUIDE_TIMEOUT_MS, 'nutrition guide read');
+    await withTimeout(refreshGuide(), GUIDE_TIMEOUT_MS, 'nutrition guide read');
   } catch {
-    if (guideRead === read) guideRead = null;
-    logger.warn('[nutritionPlanService] nutrition guide read timed out; using the last one read', { timeoutMs: GUIDE_TIMEOUT_MS });
-    return lastGuide;
+    logger.warn('[nutritionPlanService] first nutrition guide read timed out; plan sent without it for now', { timeoutMs: GUIDE_TIMEOUT_MS });
+    if (!guide.freshUntil) guide = { ...guide, freshUntil: Date.now() + GUIDE_RETRY_MS };
   }
+  return guide.text;
 }
 
 async function resolveNutritionPlan(section, { now = new Date() } = {}) {
@@ -87,6 +90,8 @@ async function resolveNutritionPlan(section, { now = new Date() } = {}) {
 module.exports = {
   NUTRITION_GUIDE_PROMPT_ID,
   GUIDE_TIMEOUT_MS,
+  GUIDE_REFRESH_MS,
+  GUIDE_RETRY_MS,
   resolveNutritionPlan,
-  _test: { reset: () => { lastGuide = ''; guideRead = null; readSeq = 0; appliedSeq = 0; } },
+  _test: { reset: () => { guide = { text: '', freshUntil: 0 }; guideRead = null; } },
 };

package/lib/clinical/services/promptComposerService.js

@@ -14,8 +14,6 @@ const promptCache = new MapCache({ maxSize: 50, ttl: CACHE_TTL });
 const snippetCache = new MapCache({ maxSize: 200, ttl: CACHE_TTL });
 const toolCache = new MapCache({ maxSize: 50, ttl: CACHE_TTL });
 const presetCache = new MapCache({ maxSize: 50, ttl: CACHE_TTL });
-let promptReadClock = 0;
-let promptCacheEpoch = 0;
 
 async function fetchConfigRecords(table, filter) {
   const records = await getRecordByFilter(Config_ID, table, filter);
@@ -49,17 +47,11 @@ async function fetchPreset(presetId, version = null) {
 async function fetchBasePrompt(promptId) {
   const cacheKey = `prompt:${promptId}`;
   const cached = promptCache.get(cacheKey);
-  if (cached) return cached.record;
+  if (cached) return cached;
 
-  // A result may fill the cache unless a read started later already did, or the cache was cleared meanwhile.
-  const startedAt = ++promptReadClock;
-  const epoch = promptCacheEpoch;
   const records = await getRecordByFilter(Config_ID, 'responses', `{prompt_id} = "${promptId}"`);
   const record = records?.[0] || null;
-  const current = promptCache.get(cacheKey);
-  if (record && epoch === promptCacheEpoch && !(current && current.startedAt > startedAt)) {
-    promptCache.set(cacheKey, { record, startedAt });
-  }
+  if (record) promptCache.set(cacheKey, record);
   return record;
 }
 
@@ -265,7 +257,6 @@ async function resolveTools({ promptId, assistant, presetToolIds = null, status
 
 function clearCache() {
   promptCache.clear();
-  promptCacheEpoch += 1;
   snippetCache.clear();
   toolCache.clear();
   presetCache.clear();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@peopl-health/nexus",
-  "version": "5.67.0-dev.11930",
+  "version": "5.67.0",
   "description": "Core messaging and assistant library for WhatsApp communication platforms",
   "keywords": [
     "whatsapp",