@peopl-health/nexus 4.7.0-dev.449 → 4.7.0-dev.451

package/lib/clinical/helpers/assistantHelper.js

@@ -5,7 +5,6 @@ const { withTracing } = require('../../utils/tracingDecorator');
 const { logger } = require('../../utils/logger');
 
 const { getRecordByFilter } = require('../../services/airtableService.js');
-const { withThreadRecovery } = require('./threadRecoveryHelper');
 
 function getCurRow(baseID, code) {
   if (code.endsWith('@g.us')) {
@@ -29,11 +28,7 @@ const runAssistantAndWait = async ({ thread, assistant, message = null, runConfi
   const { polling, tools: configTools, ...config } = runConfig;
   const tools = assistant.getToolSchemas?.() || configTools || [];
 
-  return withThreadRecovery(
-    (currentThread = thread) => provider.executeRun({ thread: currentThread, message, assistant, tools, config, polling }),
-    thread,
-    variant
-  );
+  return provider.executeRun({ thread, message, assistant, tools, config, polling });
 };
 
 const runAssistantWithRetries = async (thread, assistant, runConfig, patientReply = null) => {

package/lib/clinical/index.js

@@ -15,7 +15,6 @@ const { BaseAssistant } = require('./assistants/BaseAssistant');
 const { AssistantProcessor } = require('./AssistantProcessor');
 
 const { getCurRow, runAssistantAndWait, runAssistantWithRetries } = require('./helpers/assistantHelper');
-const { withThreadRecovery } = require('./helpers/threadRecoveryHelper');
 const { analyzeImage, buildPrompt } = require('./helpers/llmsHelper');
 
 const { getProviderVariant, getAnthropicClient, setOpenAIProvider, getOpenAIProvider, requireOpenAIProvider, configureOpenAIProvider } = require('./config/llmConfig');
@@ -47,7 +46,6 @@ module.exports = {
   getCurRow,
   runAssistantAndWait,
   runAssistantWithRetries,
-  withThreadRecovery,
   analyzeImage,
   buildPrompt,
   getProviderVariant,

package/lib/clinical/providers/BaseLLMProvider.js

@@ -160,14 +160,6 @@ class BaseLLMProvider {
     throw new Error(`${this.constructor.name} must implement _invokeModel()`);
   }
 
-  async createConversation() {
-    throw new Error(`createConversation is not supported by ${this.constructor.name}`);
-  }
-
-  async listMessages() {
-    throw new Error(`listMessages is not supported by ${this.constructor.name}`);
-  }
-
   async transcribeAudio() {
     throw new Error(`transcribeAudio is not supported by ${this.constructor.name}`);
   }
@@ -420,13 +412,6 @@ class BaseLLMProvider {
     if (segments.length > 1) logger.debug(`[${this.constructor.name}] Concatenated transcript detected, using last segment`, { segmentCount: segments.length });
     return segments[segments.length - 1].trim();
   }
-
-  _ensureId(value) {
-    if (!value) throw new Error('Identifier value is required');
-    if (typeof value === 'string') return value;
-    if (value?.id) return value.id;
-    throw new Error('Unable to resolve identifier value');
-  }
 }
 
 module.exports = {

package/lib/clinical/providers/OpenAIResponsesProvider.js

@@ -10,9 +10,6 @@ const { logger } = require('../../utils/logger');
 const { BaseLLMProvider } = require('./BaseLLMProvider');
 const { handleFunctionCalls } = require('./OpenAIResponsesProviderTools');
 
-const CONVERSATION_PREFIX = 'conv_';
-const MAX_ITEMS_ON_CREATE = 20;
-const MAX_ITEMS_PER_BATCH = 20;
 const DEFAULT_MAX_FUNCTION_ROUNDS = 5;
 
 class OpenAIResponsesProvider extends BaseLLMProvider {
@@ -46,76 +43,12 @@ class OpenAIResponsesProvider extends BaseLLMProvider {
     this.supportsPromptRegistry = true;
 
     this.responses = this.client.responses;
-    this.conversations = this.client.conversations;
   }
 
   _operatorInstructionTurn(additionalInstructions) {
     return { role: 'developer', content: `[Instrucción del operador para tu próxima respuesta al paciente]: ${additionalInstructions}` };
   }
 
-  async createConversation({ metadata, messages = [], toolResources } = {}) {
-    const maxHistoricalMessages = this.conversationManager.maxHistoricalMessages;
-    const capped = messages.length > maxHistoricalMessages;
-    const messagesToProcess = capped ? messages.slice(-maxHistoricalMessages) : messages;
-    if (capped) {
-      logger.warn(`[createConversation] Capped ${messages.length} → ${maxHistoricalMessages} messages`);
-    }
-
-    const allItems = this._convertItemsToApiFormat(messagesToProcess);
-    const initialItems = allItems.slice(0, MAX_ITEMS_ON_CREATE);
-    const remainingItems = allItems.slice(MAX_ITEMS_ON_CREATE);
-
-    if (remainingItems.length) {
-      logger.info(`[createConversation] Batching: ${initialItems.length} initial + ${remainingItems.length} remaining`);
-    }
-
-    const conversation = await this._createConversationWithItems(metadata, initialItems, toolResources);
-
-    if (remainingItems.length) {
-      try {
-        await this._addItemsInBatches(conversation.id, remainingItems);
-      } catch (error) {
-        logger.error('[createConversation] Failed to add remaining messages', { error: error.message });
-      }
-    }
-
-    return conversation;
-  }
-
-  async _createConversationWithItems(metadata, items, toolResources) {
-    const payload = { 
-      metadata,
-      items: items.length ? items : undefined,
-      tool_resources: toolResources
-    };
-    const { result } = await retryWithBackoff(
-      () => this.conversations.create(payload),
-      { providerName: this.constructor.name }
-    );
-    return result;
-  }
-
-  async _addItemsInBatches(threadId, items, batchSize = MAX_ITEMS_PER_BATCH) {
-    if (!items?.length) return;
-
-    const id = this._ensurethreadId(threadId);
-    for (let i = 0; i < items.length; i += batchSize) {
-      const batch = this._convertItemsToApiFormat(items.slice(i, i + batchSize));
-      await retryWithBackoff(
-        () => this.conversations.items.create(id, { items: batch }),
-        { providerName: this.constructor.name }
-      );
-    }
-    logger.info(`[_addItemsInBatches] Added ${items.length} messages in ${Math.ceil(items.length / batchSize)} batches`);
-  }
-
-  async listMessages({ threadId, order = 'desc', limit } = {}) {
-    return this.client.conversations.items.list(
-      this._ensurethreadId(threadId), 
-      { order, limit }
-    );
-  }
-
   async _invokeModel({
     instructions, input, toolSchemas = [], toolChoice = 'auto', followUpToolChoice = 'auto',
     modelConfig, metadata = {}, assistant, phiProcessor = null,
@@ -237,15 +170,6 @@ class OpenAIResponsesProvider extends BaseLLMProvider {
       file, language, response_format: responseFormat, temperature, prompt,
     });
   }
-
-  _ensurethreadId(value) {
-    const id = this._ensureId(value);
-    if (!id.startsWith(CONVERSATION_PREFIX)) {
-      throw new Error(`Expected conversation id to start with '${CONVERSATION_PREFIX}'`);
-    }
-    return id;
-  }
-
 }
 
 module.exports = {

package/lib/clinical/providers/OpenRouterProvider.js

@@ -196,14 +196,6 @@ class OpenRouterProvider extends OpenAIResponsesProvider {
       file, language, response_format: responseFormat, temperature, prompt,
     });
   }
-
-  async createConversation() {
-    throw new Error('createConversation is not supported by OpenRouterProvider');
-  }
-
-  async listMessages() {
-    throw new Error('listMessages is not supported by OpenRouterProvider');
-  }
 }
 
 module.exports = {

package/lib/controllers/conversationController.js

@@ -14,7 +14,7 @@ const { fetchConversationData, processConversations, startConversation } = requi
 const { getMessages, countMessages, aggregateMessages } = require('../services/messageService');
 
 const { sendMessage } = require('../core/NexusMessaging');
-const { withThreadRecovery, getProviderVariant, getOpenAIProvider } = require('../clinical');
+const { getProviderVariant } = require('../clinical');
 
 const Message = mongoose.models.Message;
 
@@ -470,65 +470,45 @@ const markMessagesAsReadController = async (req, res) => {
 const getOpenAIThreadMessagesController = async (req, res) => {
   try {
     const { code } = req.params;
-    const { limit = 50, order = 'desc', runId } = req.query;
-    const variant = getProviderVariant();
-    
+    const { order = 'desc' } = req.query;
+
     if (!code) {
       return res.status(400).json({
         success: false,
         error: 'Phone number is required'
       });
     }
-    
-    let thread = await Thread.findOne({ code: code }).sort({ createdAt: -1 });
+
+    const thread = await Thread.findOne({ code: code }).sort({ createdAt: -1 });
     if (!thread) {
       return res.status(404).json({
         success: false,
-        error: 'No active OpenAI thread found for this phone number'
+        error: 'No active thread found for this phone number'
       });
     }
-    
-    const provider = getOpenAIProvider({ instantiate: true, variant });
-    if (!provider) throw new Error('OpenAI provider not initialized');
-    
-    const queryParams = {
-      threadId: thread.conversation_id,
-      order,
-      limit: parseInt(limit),
-      ...(runId && { runId })
-    };
-    let threadRecreated = false;
-    
-    const messages = await withThreadRecovery(
-      async (currentThread = thread) => {
-        if (currentThread !== thread) {
-          thread = currentThread;
-          queryParams.threadId = currentThread.getConversationId();
-          threadRecreated = true;
-        }
-        return await provider.listMessages(queryParams);
-      },
-      thread,
-      variant
+
+    const parsedLimit = Math.min(Math.max(parseInt(req.query.limit) || 50, 1), 100);
+    const messages = await getMessages(
+      { numero: code, group_id: null },
+      { sort: { createdAt: order === 'asc' ? 1 : -1 }, limit: parsedLimit }
     );
-    
+    messages.forEach(msg => { msg.body = msg.plainBody || msg.body; });
+
     res.status(200).json({
       success: true,
-      variant,
+      variant: getProviderVariant(),
       phoneNumber: code,
       code,
       threadId: thread.conversation_id,
       assistantId: thread.assistant_id,
-      messages: messages.data || messages,
-      hasMore: messages.has_more || false,
-      threadRecreated,
-      pagination: { limit: parseInt(limit), order }
+      messages,
+      pagination: { limit: parsedLimit, order }
     });
   } catch (error) {
-    logger.error('Error fetching OpenAI thread messages:', { error: error.message });
-    res.status(500).json({ 
-      success: false, 
-      error: error.message || 'Failed to fetch OpenAI thread messages' 
+    logger.error('Error fetching thread messages:', { error: error.message });
+    res.status(500).json({
+      success: false,
+      error: error.message || 'Failed to fetch thread messages'
     });
   }
 };

package/lib/index.d.ts

@@ -273,8 +273,6 @@ declare module '@peopl-health/nexus' {
     constructor(options?: { apiKey?: string; organization?: string; client?: any; defaultModels?: Record<string, string>; conversationManager?: any });
     getVariant(): string;
     getClient(): any;
-    createConversation(options?: any): Promise<any>;
-    listMessages(options?: any): Promise<any>;
     executeRun(options: { thread: any; assistant: any; message?: string; tools?: any[]; config?: any }): Promise<any>;
     runConversation(config?: any): Promise<any>;
     transcribeAudio(options?: any): Promise<any>;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@peopl-health/nexus",
-  "version": "4.7.0-dev.449",
+  "version": "4.7.0-dev.451",
   "description": "Core messaging and assistant library for WhatsApp communication platforms",
   "keywords": [
     "whatsapp",

package/lib/clinical/helpers/threadRecoveryHelper.js

@@ -1,50 +0,0 @@
-const { createLLMProvider } = require('../providers/createLLMProvider');
-const { logger } = require('../../utils/logger');
-
-const { Thread } = require('../../models/threadModel');
-
-const THREAD_ERROR_CODES = ['thread_not_found', 'invalid_thread_id'];
-const THREAD_ERROR_MESSAGES = ['No thread found', 'thread does not exist', 'Invalid thread'];
-
-const isThreadNotFoundError = (error) => 
-  error?.status === 404 || 
-  THREAD_ERROR_CODES.includes(error?.code) ||
-  THREAD_ERROR_MESSAGES.some(msg => error?.message?.includes(msg));
-
-const recreateThread = async (thread, variant) => {
-  const provider = createLLMProvider({ variant });
-  const newConversation = await provider.createConversation({ 
-    metadata: { code: thread.code }
-  });
-  
-  await Thread.updateOne(
-    { code: thread.code },
-    { $set: { conversation_id: newConversation.id } }
-  );
-  
-  logger.info('[threadRecovery] Recreated', { 
-    oldId: thread.conversation_id, 
-    newId: newConversation.id,
-    code: thread.code 
-  });
-  return Thread.findOne({ code: thread.code });
-};
-
-const withThreadRecovery = async (operation, thread, variant) => {
-  try {
-    return await operation();
-  } catch (error) {
-    if (isThreadNotFoundError(error) && thread) {
-      logger.warn('[threadRecovery] Thread not found, recreating', { code: thread.code });
-      const recoveredThread = await recreateThread(thread, variant);
-      return operation(recoveredThread);
-    }
-    throw error;
-  }
-};
-
-module.exports = {
-  isThreadNotFoundError,
-  recreateThread,
-  withThreadRecovery
-};