@peopl-health/nexus 3.0.1 → 3.0.2

package/examples/basic-usage.js

@@ -66,13 +66,12 @@ class GeneralAssistant extends BaseAssistant {
 }
 
 async function startServer() {
-  // Initialize Nexus with all services and batching enabled
+  // Initialize Nexus with check-after processing (immediate response, checks for new messages after)
   const nexus = new Nexus({
     messaging: {
       messageBatching: {
-        enabled: true,
-        baseWaitTime: 10000,    // 10 seconds base wait (shorter for testing)
-        randomVariation: 5000   // 0-5 seconds random variation
+        enabled: true,           // Enable check-after processing
+        checkDelayMs: 100        // Delay before checking for new messages (ms)
       }
     }
   });

package/lib/core/NexusMessaging.js

@@ -41,11 +41,11 @@ class NexusMessaging {
       keyword: [],
       flow: []
     };
-    // Message batching
-    this.pendingResponses = new Map();
+    // Message processing with check-after strategy
+    this.processingLocks = new Map(); // Per-chat locks to prevent parallel processing
     this.batchingConfig = {
-      enabled: config.messageBatching?.enabled ?? false,
-      baseWaitTime: config.messageBatching?.baseWaitTime ?? 10000
+      enabled: config.messageBatching?.enabled ?? true, // Enabled by default with check-after
+      checkDelayMs: config.messageBatching?.checkDelayMs ?? 100 // Delay before checking for new messages
     };
   }
 
@@ -393,10 +393,9 @@ class NexusMessaging {
     } else if (messageData.flow) {
       return await this.handleFlow(messageData);
     } else {
-      // For regular messages and media, use batching if enabled
-      logger.info('Batching config:', this.batchingConfig);
+      // For regular messages and media, use check-after processing
       if (this.batchingConfig.enabled && chatId) {
-        return await this._handleWithBatching(messageData, chatId);
+        return await this._handleWithCheckAfter(chatId);
       } else {
         if (messageData.media) {
           return await this.handleMedia(messageData);
@@ -649,77 +648,52 @@ class NexusMessaging {
   }
 
   /**
-   * Handle message with batching - waits for additional messages before processing
+   * Handle message with check-after strategy - process immediately, check for new messages after
    */
-  async _handleWithBatching(messageData, chatId) {
-    const existing = this.pendingResponses.get(chatId);
-    if (existing) {
-      clearTimeout(existing.timeoutId);
-      if (existing.typingInterval) {
-        clearInterval(existing.typingInterval);
-      }
-      logger.info(`Received additional message from ${chatId}, resetting wait timer`);
-    }
-
-    // Start typing indicator refresh for batching period
-    const typingInterval = await this._startTypingRefresh(chatId);
-
-    const waitTime = this.batchingConfig.baseWaitTime;
-    const timeoutId = setTimeout(async () => {
-      try {
-        if (typingInterval) {
-          clearInterval(typingInterval);
-        }
-        this.pendingResponses.delete(chatId);
-        await this._handleBatchedMessages(chatId);
-      } catch (error) {
-        logger.error(`Error handling batched messages for ${chatId}:`, error);
-      }
-    }, waitTime);
-    
-    this.pendingResponses.set(chatId, { timeoutId, typingInterval });
-    logger.info(`Waiting ${Math.round(waitTime/1000)} seconds for more messages from ${chatId}`);
-  }
-
-  /**
-   * Start typing indicator refresh interval
-   */
-  async _startTypingRefresh(chatId) {
-    if (!this.provider || typeof this.provider.sendTypingIndicator !== 'function') {
-      return null;
+  async _handleWithCheckAfter(chatId) {
+    // If already processing this chat, just return (message is saved, will be picked up)
+    if (this.processingLocks.has(chatId)) {
+      logger.info(`[CheckAfter] Already processing ${chatId}, new message will be included`);
+      return;
     }
 
-    const lastMessage = await Message.findOne({ 
-      numero: chatId, 
-      from_me: false,
-      message_id: { $exists: true, $ne: null }
-    }).sort({ createdAt: -1 });
-    
-    if (!lastMessage?.message_id) return null;
-    
-    return setInterval(() => 
-      this.provider.sendTypingIndicator(lastMessage.message_id).catch(err => 
-        logger.debug('[_startTypingRefresh] Failed', { error: err.message })
-      ), 5000
-    );
+    await this._processWithLock(chatId);
   }
 
   /**
-   * Process all batched messages for a chat
+   * Process messages with per-chat lock and check-after logic
    */
-  async _handleBatchedMessages(chatId) {
+  async _processWithLock(chatId) {
+    this.processingLocks.set(chatId, true);
     let typingInterval = null;
-    
+
     try {
-      logger.info(`Processing batched messages from ${chatId} (including media if any)`);
-      
       typingInterval = await this._startTypingRefresh(chatId);
-      
-      // Get assistant response
+      logger.info(`[CheckAfter] Processing messages for ${chatId}`);
+
+      // Process with assistant
       const result = await replyAssistant(chatId);
       const botResponse = typeof result === 'string' ? result : result?.output;
       const tools_executed = typeof result === 'object' ? result?.tools_executed : undefined;
-      
+
+      // Small delay to catch very recent DB writes
+      await new Promise(resolve => setTimeout(resolve, this.batchingConfig.checkDelayMs));
+
+      // Check for new unprocessed messages
+      const hasNewMessages = await Message.exists({
+        numero: chatId,
+        processed: false,
+        from_me: false
+      });
+
+      if (hasNewMessages) {
+        logger.info(`[CheckAfter] New messages detected for ${chatId}, discarding response and reprocessing`);
+        if (typingInterval) clearInterval(typingInterval);
+        // Recursively process with new messages
+        return await this._processWithLock(chatId);
+      }
+
+      // No new messages - send response and mark processed
       if (botResponse) {
         await this.sendMessage({
           code: chatId,
@@ -729,40 +703,45 @@ class NexusMessaging {
           tools_executed
         });
       }
-      
-      // Emit event for batched processing
-      this.events.emit('messages:batched', { chatId, response: botResponse });
-      
+
+      this.events.emit('messages:processed', { chatId, response: botResponse });
+
     } catch (error) {
-      logger.error('Error in batched message handling:', { error: error.message });
+      logger.error('[CheckAfter] Error processing messages:', { chatId, error: error.message });
     } finally {
-      if (typingInterval) {
-        clearInterval(typingInterval);
-      }
+      if (typingInterval) clearInterval(typingInterval);
+      this.processingLocks.delete(chatId);
     }
   }
 
   /**
-   * Clear pending response for a chat (useful for cleanup)
+   * Start typing indicator refresh interval
    */
-  clearPendingResponse(chatId) {
-    const pending = this.pendingResponses.get(chatId);
-    if (pending) {
-      if (pending.timeoutId) {
-        clearTimeout(pending.timeoutId);
-      }
-      if (pending.typingInterval) {
-        clearInterval(pending.typingInterval);
-      }
-      this.pendingResponses.delete(chatId);
+  async _startTypingRefresh(chatId) {
+    if (!this.provider || typeof this.provider.sendTypingIndicator !== 'function') {
+      return null;
     }
+
+    const lastMessage = await Message.findOne({ 
+      numero: chatId, 
+      from_me: false,
+      message_id: { $exists: true, $ne: null }
+    }).sort({ createdAt: -1 });
+    
+    if (!lastMessage?.message_id) return null;
+    
+    return setInterval(() => 
+      this.provider.sendTypingIndicator(lastMessage.message_id).catch(err => 
+        logger.debug('[_startTypingRefresh] Failed', { error: err.message })
+      ), 5000
+    );
   }
 
   /**
-   * Get batching status for a chat
+   * Check if chat is currently being processed
    */
-  hasPendingResponse(chatId) {
-    return this.pendingResponses.has(chatId);
+  isProcessing(chatId) {
+    return this.processingLocks.has(chatId);
   }
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@peopl-health/nexus",
-  "version": "3.0.1",
+  "version": "3.0.2",
   "description": "Core messaging and assistant library for WhatsApp communication platforms",
   "keywords": [
     "whatsapp",