@pennyfarthing/core 9.2.0 → 9.3.0

package/pennyfarthing-dist/scripts/lib/logging.sh

@@ -1,186 +0,0 @@
-#!/usr/bin/env zsh
-# Structured JSON logging utilities for agent workflows
-# Dev: Fanny Price - "Let other pens dwell on guilt and misery."
-
-# Source file locking utilities
-SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
-# shellcheck source=file-lock.sh
-source "${SCRIPT_DIR}/file-lock.sh" 2>/dev/null || true
-
-# Log file location (evaluated dynamically)
-_get_log_file() {
-    echo "${PROJECT_ROOT:-.}/.session/agent-logs.jsonl"
-}
-
-# _log LEVEL MESSAGE [EXTRA_FIELDS]
-# Internal function to write structured log entry
-#
-# Arguments:
-#   LEVEL        - Log level (INFO, WARN, ERROR)
-#   MESSAGE      - Log message
-#   EXTRA_FIELDS - Optional extra JSON fields (must be valid JSON object contents)
-#
-_log() {
-    local level="$1"
-    local message="$2"
-    local extra="${3:-}"
-    local timestamp
-    local agent
-    local session
-    local log_file
-
-    timestamp=$(date -u +"%Y-%m-%dT%H:%M:%SZ")
-    agent="${AGENT_NAME:-unknown}"
-    session="${SESSION_ID:-}"
-    log_file=$(_get_log_file)
-
-    # Ensure directory exists
-    mkdir -p "$(dirname "$log_file")"
-
-    # Escape message for JSON (handle quotes and newlines)
-    message=$(printf '%s' "$message" | sed 's/\\/\\\\/g; s/"/\\"/g; s/\t/\\t/g' | tr '\n' ' ')
-
-    # Build JSON object
-    local json="{\"timestamp\":\"${timestamp}\",\"level\":\"${level}\",\"agent\":\"${agent}\",\"message\":\"${message}\""
-
-    # Add session_id if present
-    if [[ -n "$session" ]]; then
-        json="${json},\"session_id\":\"${session}\""
-    fi
-
-    # Add extra fields if provided
-    if [[ -n "$extra" ]]; then
-        json="${json},${extra}"
-    fi
-
-    json="${json}}"
-
-    # Acquire lock, write to log file, release lock
-    if lock_acquire "$log_file" "exclusive" 5 2>/dev/null; then
-        echo "$json" >> "$log_file"
-        lock_release "$log_file"
-    else
-        # Fallback: write without lock (better than failing)
-        echo "$json" >> "$log_file"
-    fi
-
-    # Also output to stderr for visibility (with color)
-    case "$level" in
-        INFO)  echo -e "\033[32m[INFO]\033[0m $message" >&2 ;;
-        WARN)  echo -e "\033[33m[WARN]\033[0m $message" >&2 ;;
-        ERROR) echo -e "\033[31m[ERROR]\033[0m $message" >&2 ;;
-    esac
-}
-
-# log_info MESSAGE [EXTRA_FIELDS]
-# Log an informational message
-#
-# Arguments:
-#   MESSAGE      - Log message
-#   EXTRA_FIELDS - Optional extra JSON fields
-#
-# Example:
-#   log_info "Starting workflow"
-#   log_info "File processed" '"file":"src/main.go","lines":42'
-#
-log_info() {
-    _log "INFO" "$1" "${2:-}"
-}
-
-# log_warn MESSAGE [EXTRA_FIELDS]
-# Log a warning message
-#
-# Arguments:
-#   MESSAGE      - Log message
-#   EXTRA_FIELDS - Optional extra JSON fields
-#
-# Example:
-#   log_warn "Context usage high"
-#   log_warn "Retry needed" '"attempt":2,"max":3'
-#
-log_warn() {
-    _log "WARN" "$1" "${2:-}"
-}
-
-# log_error MESSAGE [EXTRA_FIELDS]
-# Log an error message
-#
-# Arguments:
-#   MESSAGE      - Log message
-#   EXTRA_FIELDS - Optional extra JSON fields
-#
-# Example:
-#   log_error "Command failed"
-#   log_error "Test failure" '"test":"test_auth","exit_code":1'
-#
-log_error() {
-    _log "ERROR" "$1" "${2:-}"
-}
-
-# log_list [N]
-# List recent log entries
-#
-# Arguments:
-#   N - Number of entries to show (default: 20)
-#
-# Example:
-#   log_list
-#   log_list 50
-#
-log_list() {
-    local count=${1:-20}
-    local log_file
-    log_file=$(_get_log_file)
-
-    if [[ -f "$log_file" ]]; then
-        tail -n "$count" "$log_file"
-    fi
-}
-
-# log_clear
-# Remove all log entries
-#
-# Example:
-#   log_clear
-#
-log_clear() {
-    local log_file
-    log_file=$(_get_log_file)
-    rm -f "$log_file"
-}
-
-# log_rotate [MAX_LINES]
-# Rotate log file to prevent unbounded growth
-#
-# Arguments:
-#   MAX_LINES - Maximum lines to keep (default: 1000)
-#
-# Example:
-#   log_rotate
-#   log_rotate 500
-#
-log_rotate() {
-    local max_lines=${1:-1000}
-    local log_file
-    log_file=$(_get_log_file)
-
-    if [[ ! -f "$log_file" ]]; then
-        return 0
-    fi
-
-    # Acquire exclusive lock for rotation
-    if lock_acquire "$log_file" "exclusive" 5 2>/dev/null; then
-        local current_lines
-        current_lines=$(wc -l < "$log_file")
-
-        if ((current_lines > max_lines)); then
-            local temp_file
-            temp_file=$(mktemp)
-            tail -n "$max_lines" "$log_file" > "$temp_file"
-            mv "$temp_file" "$log_file"
-        fi
-        lock_release "$log_file"
-    fi
-}
-
-# Functions available when sourced

package/pennyfarthing-dist/scripts/lib/retry.sh

@@ -1,76 +0,0 @@
-#!/usr/bin/env zsh
-# Retry utilities with exponential backoff
-# Dev: Fanny Price - "We have all a better guide in ourselves, if we would attend to it."
-
-# retry_with_backoff MAX_ATTEMPTS INITIAL_DELAY MAX_DELAY COMMAND...
-# Retry a command with exponential backoff
-#
-# Arguments:
-#   MAX_ATTEMPTS   - Maximum number of attempts (default: 3)
-#   INITIAL_DELAY  - Initial delay in seconds (default: 1)
-#   MAX_DELAY      - Maximum delay cap in seconds (default: 30)
-#   COMMAND...     - Command to execute
-#
-# Returns:
-#   0 if command succeeds within attempts
-#   1 if all attempts exhausted
-#
-# Example:
-#   retry_with_backoff 3 1 10 curl -s https://api.example.com/health
-#
-retry_with_backoff() {
-    local max_attempts=${1:-3}
-    local delay=${2:-1}
-    local max_delay=${3:-30}
-    shift 3
-
-    local attempt=1
-    while true; do
-        # Try the command
-        if "$@"; then
-            return 0
-        fi
-
-        # Check if we've exhausted attempts
-        if ((attempt >= max_attempts)); then
-            return 1
-        fi
-
-        # Wait before retry
-        sleep "$delay"
-
-        # Exponential backoff with cap
-        delay=$((delay * 2))
-        if ((delay > max_delay)); then
-            delay=$max_delay
-        fi
-
-        attempt=$((attempt + 1))
-    done
-}
-
-# command_with_fallback PRIMARY_CMD FALLBACK_CMD
-# Execute primary command, fall back to alternative if it fails
-#
-# Arguments:
-#   PRIMARY_CMD   - Primary command to try (as string)
-#   FALLBACK_CMD  - Fallback command if primary fails (as string)
-#
-# Returns:
-#   Exit code of whichever command succeeds (or fallback's exit code)
-#
-# Example:
-#   command_with_fallback "git pull --ff-only" "git pull --no-rebase"
-#
-command_with_fallback() {
-    local primary_cmd="$1"
-    local fallback_cmd="$2"
-
-    if eval "$primary_cmd"; then
-        return 0
-    else
-        eval "$fallback_cmd"
-    fi
-}
-
-# Functions available when sourced - no export needed in zsh

package/pennyfarthing-dist/scripts/maintenance/migrate-theme-schema.mjs

@@ -1,102 +0,0 @@
-#!/usr/bin/env node
-/**
- * Migration Script: Consolidate quote into catchphrases (MSSCI-12478)
- * 
- * For each theme YAML:
- * 1. For each agent: if quote exists and isn't in catchphrases, add it
- * 2. Remove the quote field from all agents
- */
-
-import { readFileSync, writeFileSync, readdirSync } from 'node:fs';
-import { join, dirname } from 'node:path';
-import { fileURLToPath } from 'node:url';
-
-const __filename = fileURLToPath(import.meta.url);
-const __dirname = dirname(__filename);
-
-const THEMES_DIR = join(__dirname, '..', '..', 'personas', 'themes');
-
-function migrateThemeFile(filePath) {
-  let content = readFileSync(filePath, 'utf-8');
-  const lines = content.split('\n');
-  const result = [];
-  
-  let i = 0;
-  while (i < lines.length) {
-    const line = lines[i];
-    const trimmed = line.trimEnd();
-    
-    // Check for quote: at 4-space indent (agent level)
-    if (/^    quote:/.test(trimmed)) {
-      // Extract the quote value
-      const quoteMatch = trimmed.match(/^    quote:\s*["']?(.+?)["']?$/);
-      if (quoteMatch) {
-        const quoteValue = quoteMatch[1];
-        
-        // Look ahead for catchphrases section
-        let catchphrasesIndex = -1;
-        let catchphrases = [];
-        
-        for (let j = i + 1; j < lines.length; j++) {
-          const checkLine = lines[j];
-          // Stop if we hit the next agent (2-space indent with colon) or end of agents
-          if (/^  \w+:/.test(checkLine) && !/^    /.test(checkLine)) break;
-          if (/^agents:/.test(checkLine) || /^theme:/.test(checkLine)) break;
-          
-          if (/^    catchphrases:/.test(checkLine)) {
-            catchphrasesIndex = j;
-            // Collect existing catchphrases
-            for (let k = j + 1; k < lines.length; k++) {
-              const catchLine = lines[k];
-              if (/^      - /.test(catchLine)) {
-                const catchValue = catchLine.replace(/^      - ["']?(.+?)["']?$/, '$1');
-                catchphrases.push(catchValue);
-              } else if (!/^\s*$/.test(catchLine) && !/^      /.test(catchLine)) {
-                break;
-              }
-            }
-            break;
-          }
-        }
-        
-        // Check if quote is already in catchphrases
-        const quoteInCatchphrases = catchphrases.some(c => c === quoteValue);
-        
-        if (!quoteInCatchphrases && catchphrasesIndex === -1) {
-          // No catchphrases section - this shouldn't happen based on exploration
-          // but handle it anyway by skipping quote (tests expect catchphrases to exist)
-          console.log(`  Warning: No catchphrases found for agent with quote in ${filePath}`);
-        }
-        
-        // Skip the quote line (don't add to result)
-        i++;
-        continue;
-      }
-    }
-    
-    result.push(line);
-    i++;
-  }
-  
-  const newContent = result.join('\n');
-  if (newContent !== content) {
-    writeFileSync(filePath, newContent);
-    return true;
-  }
-  return false;
-}
-
-// Main
-const files = readdirSync(THEMES_DIR).filter(f => f.endsWith('.yaml'));
-console.log(`Migrating ${files.length} theme files...`);
-
-let modified = 0;
-for (const file of files) {
-  const filePath = join(THEMES_DIR, file);
-  if (migrateThemeFile(filePath)) {
-    modified++;
-    console.log(`  Migrated: ${file}`);
-  }
-}
-
-console.log(`\nDone. Modified ${modified}/${files.length} files.`);

package/pennyfarthing-dist/scripts/maintenance/sidecar-health.sh

@@ -1,91 +0,0 @@
-#!/bin/bash
-# sidecar-health.sh - Check sidecar files for bloat and staleness
-#
-# Usage: sidecar-health.sh [--fix]
-#   --fix    Offer to archive bloated files
-#
-# Thresholds:
-#   gotchas.md: 50 lines max
-#   patterns.md: 50 lines max
-#   decisions.md: 40 lines max
-
-set -euo pipefail
-
-# Find project root
-source "$(dirname "${BASH_SOURCE[0]}")/../lib/find-root.sh"
-
-SIDECAR_DIR="$PROJECT_ROOT/.pennyfarthing/sidecars"
-FIX_MODE="${1:-}"
-
-# Thresholds
-GOTCHAS_MAX=50
-PATTERNS_MAX=50
-DECISIONS_MAX=40
-
-# Colors
-RED='\033[0;31m'
-YELLOW='\033[1;33m'
-GREEN='\033[0;32m'
-NC='\033[0m' # No Color
-
-echo "Sidecar Health Check"
-echo "===================="
-echo ""
-
-issues_found=0
-
-check_file() {
-  local file="$1"
-  local max_lines="$2"
-  local agent=$(basename "$(dirname "$file")")
-  local filename=$(basename "$file")
-
-  if [[ ! -f "$file" ]]; then
-    return
-  fi
-
-  local lines=$(wc -l < "$file" | tr -d ' ')
-
-  if [[ $lines -gt $max_lines ]]; then
-    echo -e "${RED}BLOATED${NC}: $agent/$filename ($lines lines, max $max_lines)"
-    issues_found=$((issues_found + 1))
-
-    if [[ "$FIX_MODE" == "--fix" ]]; then
-      local archive_dir="$PROJECT_ROOT/.pennyfarthing/sidecars/.archive"
-      local timestamp=$(date +%Y%m%d)
-      mkdir -p "$archive_dir"
-
-      echo "  → Archiving to .archive/${agent}-${filename%.md}-${timestamp}.md"
-      cp "$file" "$archive_dir/${agent}-${filename%.md}-${timestamp}.md"
-      echo "  → Original preserved. Manually prune $file to <$max_lines lines."
-    fi
-  elif [[ $lines -gt $((max_lines * 80 / 100)) ]]; then
-    echo -e "${YELLOW}WARNING${NC}: $agent/$filename ($lines lines, approaching $max_lines limit)"
-  else
-    echo -e "${GREEN}OK${NC}: $agent/$filename ($lines lines)"
-  fi
-}
-
-# Check all agent sidecars
-for agent_dir in "$SIDECAR_DIR"/*/; do
-  if [[ -d "$agent_dir" ]]; then
-    agent=$(basename "$agent_dir")
-    [[ "$agent" == ".archive" ]] && continue
-
-    check_file "$agent_dir/gotchas.md" $GOTCHAS_MAX
-    check_file "$agent_dir/patterns.md" $PATTERNS_MAX
-    check_file "$agent_dir/decisions.md" $DECISIONS_MAX
-  fi
-done
-
-echo ""
-if [[ $issues_found -gt 0 ]]; then
-  echo "Found $issues_found bloated file(s)."
-  if [[ "$FIX_MODE" != "--fix" ]]; then
-    echo "Run with --fix to archive and prepare for pruning."
-  fi
-  exit 1
-else
-  echo "All sidecar files within limits."
-  exit 0
-fi

package/pennyfarthing-dist/scripts/misc/README.md

@@ -1,44 +0,0 @@
-# Miscellaneous Scripts
-
-Uncategorized utilities and one-off scripts.
-
-## Scripts
-
-| Script | Purpose |
-|--------|---------|
-| `deploy.sh` | Deployment script |
-| `doctor-dogfood.sh` | Health check for dogfooding setup |
-| `run-ci.sh` | Run CI locally |
-| `statusline.sh` | Status line configuration |
-| `uninstall.sh` | Uninstall Pennyfarthing from project |
-| `backlog.sh` | Backlog operations |
-| `repo-utils.sh` | Multi-repo utilities |
-| `repo-scan.sh` | Repository scanner |
-| `add-short-names.mjs` | Add short names to themes |
-| `migrate-bmad-workflow.mjs` | BMAD workflow migration |
-| `migrate-bmad-workflow.sh` | BMAD migration wrapper |
-| `find-related-work.sh` | Find related work items |
-| `check-status.sh` | Status checking utilities |
-| `session-cleanup.sh` | Clean up old sessions |
-| `generate-skill-docs.sh` | Generate skill documentation |
-| `log-skill-usage.sh` | Log skill invocations |
-| `skill-usage-report.sh` | Generate skill usage reports |
-| `run-timestamp.sh` | Timestamp utility |
-| `validate-subagent-frontmatter.sh` | Validate subagent YAML frontmatter |
-
-## Usage
-
-```bash
-.pennyfarthing/scripts/misc/doctor-dogfood.sh
-.pennyfarthing/scripts/misc/run-ci.sh
-```
-
-## Ownership
-
-- **Primary users:** Various
-- **Maintained by:** Core Pennyfarthing team
-
-## Note
-
-Scripts here may be candidates for moving to more specific categories
-as the codebase evolves.

package/pennyfarthing-dist/scripts/misc/add-short-names.sh

@@ -1,13 +0,0 @@
-#!/usr/bin/env bash
-# add-short-names.sh - Pre-generate shortName field for theme characters
-#
-# Usage:
-#   add-short-names.sh                    # Dry run - show what would change
-#   add-short-names.sh --write            # Actually write changes
-#   add-short-names.sh --theme discworld  # Only process one theme
-
-set -euo pipefail
-
-SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-
-exec python3 "$SCRIPT_DIR/add_short_names.py" "$@"