@pennyfarthing/core 7.0.2 → 7.4.0

package/dist/workflow/variable-resolver.d.ts

@@ -0,0 +1,67 @@
+/**
+ * Variable Resolver for MSSCI-12081
+ *
+ * Resolves {variable} placeholders in step file content from multiple sources
+ * with priority-based fallback chain.
+ */
+/**
+ * Represents a source of variable values
+ */
+export interface VariableSource {
+    /** Name of this source (e.g., 'workflow', 'session', 'environment') */
+    name: string;
+    /** Priority level (lower number = higher priority) */
+    priority: number;
+    /** Map of variable names to their values */
+    values: Record<string, string>;
+}
+/**
+ * Result of variable resolution
+ */
+export interface ResolveResult {
+    /** Content with variables resolved (unresolved variables left as-is) */
+    content: string;
+    /** List of variables that were successfully resolved */
+    resolved: string[];
+    /** List of variables that could not be resolved */
+    unresolved: string[];
+    /** Map of variable name to source name that provided the value */
+    sources: Record<string, string>;
+}
+/**
+ * Options for the convenience resolveStepVariables function
+ */
+export interface ResolveStepOptions {
+    /** Variables from workflow YAML (highest priority) */
+    workflowVars?: Record<string, unknown>;
+    /** Variables from session file */
+    sessionVars?: Record<string, string>;
+    /** Path to config file */
+    configPath?: string;
+    /** Project root path (for {project_root} variable) */
+    projectRoot?: string;
+}
+/**
+ * Resolve variables in content from prioritized sources
+ *
+ * @param content - The content containing {variable} placeholders
+ * @param sources - Array of variable sources, sorted by priority
+ * @returns ResolveResult with resolved content and metadata
+ */
+export declare function resolveVariables(content: string, sources: VariableSource[]): ResolveResult;
+/**
+ * Convenience function to resolve variables in step file content
+ *
+ * Automatically builds sources from:
+ * 1. Workflow variables (priority 1)
+ * 2. Session variables (priority 2)
+ * 3. Config file values (priority 3)
+ * 4. Environment/system variables (priority 4)
+ * 5. Default values (priority 5)
+ *
+ * @param stepContent - The step file content to process
+ * @param options - Optional configuration for variable sources
+ * @returns ResolveResult with resolved content and metadata
+ */
+export declare function resolveStepVariables(stepContent: string, options?: ResolveStepOptions): ResolveResult;
+//# sourceMappingURL=variable-resolver.d.ts.map

package/dist/workflow/variable-resolver.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"variable-resolver.d.ts","sourceRoot":"","sources":["../../src/workflow/variable-resolver.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAEH;;GAEG;AACH,MAAM,WAAW,cAAc;IAC7B,uEAAuE;IACvE,IAAI,EAAE,MAAM,CAAC;IACb,sDAAsD;IACtD,QAAQ,EAAE,MAAM,CAAC;IACjB,4CAA4C;IAC5C,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;CAChC;AAED;;GAEG;AACH,MAAM,WAAW,aAAa;IAC5B,wEAAwE;IACxE,OAAO,EAAE,MAAM,CAAC;IAChB,wDAAwD;IACxD,QAAQ,EAAE,MAAM,EAAE,CAAC;IACnB,mDAAmD;IACnD,UAAU,EAAE,MAAM,EAAE,CAAC;IACrB,kEAAkE;IAClE,OAAO,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;CACjC;AAED;;GAEG;AACH,MAAM,WAAW,kBAAkB;IACjC,sDAAsD;IACtD,YAAY,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;IACvC,kCAAkC;IAClC,WAAW,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IACrC,0BAA0B;IAC1B,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,sDAAsD;IACtD,WAAW,CAAC,EAAE,MAAM,CAAC;CACtB;AA0CD;;;;;;GAMG;AACH,wBAAgB,gBAAgB,CAC9B,OAAO,EAAE,MAAM,EACf,OAAO,EAAE,cAAc,EAAE,GACxB,aAAa,CAyCf;AAaD;;;;;;;;;;;;;GAaG;AACH,wBAAgB,oBAAoB,CAClC,WAAW,EAAE,MAAM,EACnB,OAAO,CAAC,EAAE,kBAAkB,GAC3B,aAAa,CAmDf"}

package/dist/workflow/variable-resolver.js

@@ -0,0 +1,156 @@
+/**
+ * Variable Resolver for MSSCI-12081
+ *
+ * Resolves {variable} placeholders in step file content from multiple sources
+ * with priority-based fallback chain.
+ */
+// Regex to match valid variable names: {name} where name starts with letter or underscore
+// followed by letters, numbers, or underscores.
+// Uses negative lookbehind to avoid matching inside nested braces like {outer_{inner}}
+const VARIABLE_REGEX = /(?<!\{[^}]*)\{([a-zA-Z_][a-zA-Z0-9_]*)\}/g;
+/**
+ * Convert a value to string, handling various types
+ */
+function valueToString(value) {
+    if (value === null || value === undefined) {
+        return null;
+    }
+    if (typeof value === 'string') {
+        return value;
+    }
+    if (typeof value === 'number' || typeof value === 'boolean') {
+        return String(value);
+    }
+    return null;
+}
+/**
+ * Look up a variable in sources by priority
+ */
+function lookupVariable(varName, sortedSources) {
+    for (const source of sortedSources) {
+        if (varName in source.values) {
+            const rawValue = source.values[varName];
+            const value = valueToString(rawValue);
+            if (value !== null) {
+                return { value, sourceName: source.name };
+            }
+        }
+    }
+    return null;
+}
+/**
+ * Resolve variables in content from prioritized sources
+ *
+ * @param content - The content containing {variable} placeholders
+ * @param sources - Array of variable sources, sorted by priority
+ * @returns ResolveResult with resolved content and metadata
+ */
+export function resolveVariables(content, sources) {
+    const resolved = [];
+    const unresolved = [];
+    const sourceMap = {};
+    // Sort sources by priority (lower number = higher priority)
+    // Stable sort preserves array order for same priority
+    const sortedSources = [...sources].sort((a, b) => a.priority - b.priority);
+    // Find all variable references in content
+    const matches = content.matchAll(VARIABLE_REGEX);
+    const seenVars = new Set();
+    for (const match of matches) {
+        const varName = match[1];
+        if (seenVars.has(varName)) {
+            continue;
+        }
+        seenVars.add(varName);
+        const lookup = lookupVariable(varName, sortedSources);
+        if (lookup) {
+            resolved.push(varName);
+            sourceMap[varName] = lookup.sourceName;
+        }
+        else {
+            unresolved.push(varName);
+        }
+    }
+    // Replace variables in content
+    const resolvedContent = content.replace(VARIABLE_REGEX, (match, varName) => {
+        const lookup = lookupVariable(varName, sortedSources);
+        return lookup ? lookup.value : match;
+    });
+    return {
+        content: resolvedContent,
+        resolved,
+        unresolved,
+        sources: sourceMap,
+    };
+}
+/**
+ * Get current date in YYYY-MM-DD format
+ */
+function getCurrentDate() {
+    const now = new Date();
+    const year = now.getFullYear();
+    const month = String(now.getMonth() + 1).padStart(2, '0');
+    const day = String(now.getDate()).padStart(2, '0');
+    return `${year}-${month}-${day}`;
+}
+/**
+ * Convenience function to resolve variables in step file content
+ *
+ * Automatically builds sources from:
+ * 1. Workflow variables (priority 1)
+ * 2. Session variables (priority 2)
+ * 3. Config file values (priority 3)
+ * 4. Environment/system variables (priority 4)
+ * 5. Default values (priority 5)
+ *
+ * @param stepContent - The step file content to process
+ * @param options - Optional configuration for variable sources
+ * @returns ResolveResult with resolved content and metadata
+ */
+export function resolveStepVariables(stepContent, options) {
+    const sources = [];
+    // Priority 1: Workflow variables
+    if (options?.workflowVars) {
+        const workflowValues = {};
+        for (const [key, value] of Object.entries(options.workflowVars)) {
+            const strValue = valueToString(value);
+            if (strValue !== null) {
+                workflowValues[key] = strValue;
+            }
+        }
+        sources.push({
+            name: 'workflow',
+            priority: 1,
+            values: workflowValues,
+        });
+    }
+    // Priority 2: Session variables
+    if (options?.sessionVars) {
+        sources.push({
+            name: 'session',
+            priority: 2,
+            values: options.sessionVars,
+        });
+    }
+    // Priority 4: Environment/system variables
+    const envValues = {
+        date: getCurrentDate(),
+    };
+    if (options?.projectRoot) {
+        envValues.project_root = options.projectRoot;
+    }
+    sources.push({
+        name: 'environment',
+        priority: 4,
+        values: envValues,
+    });
+    // Priority 5: Default values
+    sources.push({
+        name: 'defaults',
+        priority: 5,
+        values: {
+            planning_artifacts: 'planning-artifacts/',
+        },
+    });
+    return resolveVariables(stepContent, sources);
+}
+//# sourceMappingURL=variable-resolver.js.map

package/dist/workflow/variable-resolver.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"variable-resolver.js","sourceRoot":"","sources":["../../src/workflow/variable-resolver.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AA0CH,0FAA0F;AAC1F,gDAAgD;AAChD,uFAAuF;AACvF,MAAM,cAAc,GAAG,2CAA2C,CAAC;AAEnE;;GAEG;AACH,SAAS,aAAa,CAAC,KAAc;IACnC,IAAI,KAAK,KAAK,IAAI,IAAI,KAAK,KAAK,SAAS,EAAE,CAAC;QAC1C,OAAO,IAAI,CAAC;IACd,CAAC;IACD,IAAI,OAAO,KAAK,KAAK,QAAQ,EAAE,CAAC;QAC9B,OAAO,KAAK,CAAC;IACf,CAAC;IACD,IAAI,OAAO,KAAK,KAAK,QAAQ,IAAI,OAAO,KAAK,KAAK,SAAS,EAAE,CAAC;QAC5D,OAAO,MAAM,CAAC,KAAK,CAAC,CAAC;IACvB,CAAC;IACD,OAAO,IAAI,CAAC;AACd,CAAC;AAED;;GAEG;AACH,SAAS,cAAc,CACrB,OAAe,EACf,aAA+B;IAE/B,KAAK,MAAM,MAAM,IAAI,aAAa,EAAE,CAAC;QACnC,IAAI,OAAO,IAAI,MAAM,CAAC,MAAM,EAAE,CAAC;YAC7B,MAAM,QAAQ,GAAG,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC;YACxC,MAAM,KAAK,GAAG,aAAa,CAAC,QAAQ,CAAC,CAAC;YACtC,IAAI,KAAK,KAAK,IAAI,EAAE,CAAC;gBACnB,OAAO,EAAE,KAAK,EAAE,UAAU,EAAE,MAAM,CAAC,IAAI,EAAE,CAAC;YAC5C,CAAC;QACH,CAAC;IACH,CAAC;IACD,OAAO,IAAI,CAAC;AACd,CAAC;AAED;;;;;;GAMG;AACH,MAAM,UAAU,gBAAgB,CAC9B,OAAe,EACf,OAAyB;IAEzB,MAAM,QAAQ,GAAa,EAAE,CAAC;IAC9B,MAAM,UAAU,GAAa,EAAE,CAAC;IAChC,MAAM,SAAS,GAA2B,EAAE,CAAC;IAE7C,4DAA4D;IAC5D,sDAAsD;IACtD,MAAM,aAAa,GAAG,CAAC,GAAG,OAAO,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,GAAG,CAAC,CAAC,QAAQ,CAAC,CAAC;IAE3E,0CAA0C;IAC1C,MAAM,OAAO,GAAG,OAAO,CAAC,QAAQ,CAAC,cAAc,CAAC,CAAC;IACjD,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAU,CAAC;IAEnC,KAAK,MAAM,KAAK,IAAI,OAAO,EAAE,CAAC;QAC5B,MAAM,OAAO,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;QACzB,IAAI,QAAQ,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,CAAC;YAC1B,SAAS;QACX,CAAC;QACD,QAAQ,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;QAEtB,MAAM,MAAM,GAAG,cAAc,CAAC,OAAO,EAAE,aAAa,CAAC,CAAC;QACtD,IAAI,MAAM,EAAE,CAAC;YACX,QAAQ,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;YACvB,SAAS,CAAC,OAAO,CAAC,GAAG,MAAM,CAAC,UAAU,CAAC;QACzC,CAAC;aAAM,CAAC;YACN,UAAU,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QAC3B,CAAC;IACH,CAAC;IAED,+BAA+B;IAC/B,MAAM,eAAe,GAAG,OAAO,CAAC,OAAO,CAAC,cAAc,EAAE,CAAC,KAAK,EAAE,OAAO,EAAE,EAAE;QACzE,MAAM,MAAM,GAAG,cAAc,CAAC,OAAO,EAAE,aAAa,CAAC,CAAC;QACtD,OAAO,MAAM,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC;IACvC,CAAC,CAAC,CAAC;IAEH,OAAO;QACL,OAAO,EAAE,eAAe;QACxB,QAAQ;QACR,UAAU;QACV,OAAO,EAAE,SAAS;KACnB,CAAC;AACJ,CAAC;AAED;;GAEG;AACH,SAAS,cAAc;IACrB,MAAM,GAAG,GAAG,IAAI,IAAI,EAAE,CAAC;IACvB,MAAM,IAAI,GAAG,GAAG,CAAC,WAAW,EAAE,CAAC;IAC/B,MAAM,KAAK,GAAG,MAAM,CAAC,GAAG,CAAC,QAAQ,EAAE,GAAG,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC;IAC1D,MAAM,GAAG,GAAG,MAAM,CAAC,GAAG,CAAC,OAAO,EAAE,CAAC,CAAC,QAAQ,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC;IACnD,OAAO,GAAG,IAAI,IAAI,KAAK,IAAI,GAAG,EAAE,CAAC;AACnC,CAAC;AAED;;;;;;;;;;;;;GAaG;AACH,MAAM,UAAU,oBAAoB,CAClC,WAAmB,EACnB,OAA4B;IAE5B,MAAM,OAAO,GAAqB,EAAE,CAAC;IAErC,iCAAiC;IACjC,IAAI,OAAO,EAAE,YAAY,EAAE,CAAC;QAC1B,MAAM,cAAc,GAA2B,EAAE,CAAC;QAClD,KAAK,MAAM,CAAC,GAAG,EAAE,KAAK,CAAC,IAAI,MAAM,CAAC,OAAO,CAAC,OAAO,CAAC,YAAY,CAAC,EAAE,CAAC;YAChE,MAAM,QAAQ,GAAG,aAAa,CAAC,KAAK,CAAC,CAAC;YACtC,IAAI,QAAQ,KAAK,IAAI,EAAE,CAAC;gBACtB,cAAc,CAAC,GAAG,CAAC,GAAG,QAAQ,CAAC;YACjC,CAAC;QACH,CAAC;QACD,OAAO,CAAC,IAAI,CAAC;YACX,IAAI,EAAE,UAAU;YAChB,QAAQ,EAAE,CAAC;YACX,MAAM,EAAE,cAAc;SACvB,CAAC,CAAC;IACL,CAAC;IAED,gCAAgC;IAChC,IAAI,OAAO,EAAE,WAAW,EAAE,CAAC;QACzB,OAAO,CAAC,IAAI,CAAC;YACX,IAAI,EAAE,SAAS;YACf,QAAQ,EAAE,CAAC;YACX,MAAM,EAAE,OAAO,CAAC,WAAW;SAC5B,CAAC,CAAC;IACL,CAAC;IAED,2CAA2C;IAC3C,MAAM,SAAS,GAA2B;QACxC,IAAI,EAAE,cAAc,EAAE;KACvB,CAAC;IACF,IAAI,OAAO,EAAE,WAAW,EAAE,CAAC;QACzB,SAAS,CAAC,YAAY,GAAG,OAAO,CAAC,WAAW,CAAC;IAC/C,CAAC;IACD,OAAO,CAAC,IAAI,CAAC;QACX,IAAI,EAAE,aAAa;QACnB,QAAQ,EAAE,CAAC;QACX,MAAM,EAAE,SAAS;KAClB,CAAC,CAAC;IAEH,6BAA6B;IAC7B,OAAO,CAAC,IAAI,CAAC;QACX,IAAI,EAAE,UAAU;QAChB,QAAQ,EAAE,CAAC;QACX,MAAM,EAAE;YACN,kBAAkB,EAAE,qBAAqB;SAC1C;KACF,CAAC,CAAC;IAEH,OAAO,gBAAgB,CAAC,WAAW,EAAE,OAAO,CAAC,CAAC;AAChD,CAAC"}

package/dist/workflow/variable-resolver.test.d.ts

@@ -0,0 +1,14 @@
+/**
+ * Tests for Story MSSCI-12081: Variable resolver with priority chain
+ *
+ * These tests define the contract for resolving {variable} placeholders
+ * in step file content from multiple sources with priority ordering.
+ *
+ * Expected interface:
+ * - resolveVariables(content: string, sources: VariableSource[]): ResolveResult
+ * - resolveStepVariables(stepContent: string, options?): ResolveResult
+ *
+ * Run with: npm test
+ */
+export {};
+//# sourceMappingURL=variable-resolver.test.d.ts.map

package/dist/workflow/variable-resolver.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"variable-resolver.test.d.ts","sourceRoot":"","sources":["../../src/workflow/variable-resolver.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;GAWG"}

package/dist/workflow/variable-resolver.test.js

@@ -0,0 +1,400 @@
+/**
+ * Tests for Story MSSCI-12081: Variable resolver with priority chain
+ *
+ * These tests define the contract for resolving {variable} placeholders
+ * in step file content from multiple sources with priority ordering.
+ *
+ * Expected interface:
+ * - resolveVariables(content: string, sources: VariableSource[]): ResolveResult
+ * - resolveStepVariables(stepContent: string, options?): ResolveResult
+ *
+ * Run with: npm test
+ */
+import { describe, it } from 'node:test';
+import assert from 'node:assert';
+// Import will fail until implementation exists - this confirms RED state
+import { resolveVariables, resolveStepVariables, } from './variable-resolver.js';
+describe('Variable Resolver (MSSCI-12081)', () => {
+    describe('AC1: Resolves variables from workflow YAML', () => {
+        it('should resolve a single variable from source', () => {
+            const content = 'Write output to {output_file}.';
+            const sources = [
+                { name: 'workflow', priority: 1, values: { output_file: 'results.md' } }
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Write output to results.md.');
+            assert.deepStrictEqual(result.resolved, ['output_file']);
+            assert.deepStrictEqual(result.unresolved, []);
+            assert.strictEqual(result.sources['output_file'], 'workflow');
+        });
+        it('should resolve multiple variables in one string', () => {
+            const content = 'Project: {project_name} | Version: {version}';
+            const sources = [
+                { name: 'workflow', priority: 1, values: { project_name: 'pennyfarthing', version: '7.0.2' } }
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Project: pennyfarthing | Version: 7.0.2');
+            assert.ok(result.resolved.includes('project_name'));
+            assert.ok(result.resolved.includes('version'));
+            assert.strictEqual(result.resolved.length, 2);
+        });
+        it('should resolve same variable appearing multiple times', () => {
+            const content = '{name} is here. Hello, {name}!';
+            const sources = [
+                { name: 'workflow', priority: 1, values: { name: 'Sam' } }
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Sam is here. Hello, Sam!');
+            // resolved should list variable once, not twice
+            assert.deepStrictEqual(result.resolved, ['name']);
+        });
+        it('should handle content with no variables', () => {
+            const content = 'This content has no variables at all.';
+            const sources = [
+                { name: 'workflow', priority: 1, values: { unused: 'value' } }
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, content);
+            assert.deepStrictEqual(result.resolved, []);
+            assert.deepStrictEqual(result.unresolved, []);
+        });
+        it('should handle empty sources array', () => {
+            const content = 'Value: {some_var}';
+            const sources = [];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Value: {some_var}');
+            assert.deepStrictEqual(result.resolved, []);
+            assert.deepStrictEqual(result.unresolved, ['some_var']);
+        });
+    });
+    describe('AC2: Falls back through priority chain', () => {
+        it('should resolve from highest priority source first', () => {
+            const content = 'Theme: {theme}';
+            const sources = [
+                { name: 'workflow', priority: 1, values: { theme: 'west-wing' } },
+                { name: 'session', priority: 2, values: { theme: 'star-trek' } },
+                { name: 'config', priority: 3, values: { theme: 'discworld' } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Theme: west-wing');
+            assert.strictEqual(result.sources['theme'], 'workflow');
+        });
+        it('should fall back to lower priority when higher priority lacks variable', () => {
+            const content = 'Project: {project_root}';
+            const sources = [
+                { name: 'workflow', priority: 1, values: {} },
+                { name: 'session', priority: 2, values: {} },
+                { name: 'environment', priority: 4, values: { project_root: '/Users/keithavery/Projects/pennyfarthing' } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Project: /Users/keithavery/Projects/pennyfarthing');
+            assert.strictEqual(result.sources['project_root'], 'environment');
+        });
+        it('should resolve different variables from different sources', () => {
+            const content = '{story_id} in {project_root} with {theme}';
+            const sources = [
+                { name: 'workflow', priority: 1, values: { theme: 'west-wing' } },
+                { name: 'session', priority: 2, values: { story_id: 'MSSCI-12081' } },
+                { name: 'environment', priority: 4, values: { project_root: '/home/user/project' } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'MSSCI-12081 in /home/user/project with west-wing');
+            assert.strictEqual(result.sources['theme'], 'workflow');
+            assert.strictEqual(result.sources['story_id'], 'session');
+            assert.strictEqual(result.sources['project_root'], 'environment');
+        });
+        it('should respect priority ordering regardless of array order', () => {
+            const content = 'Value: {key}';
+            // Sources provided out of priority order
+            const sources = [
+                { name: 'config', priority: 3, values: { key: 'from-config' } },
+                { name: 'workflow', priority: 1, values: { key: 'from-workflow' } },
+                { name: 'defaults', priority: 5, values: { key: 'from-defaults' } },
+                { name: 'session', priority: 2, values: { key: 'from-session' } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Value: from-workflow');
+            assert.strictEqual(result.sources['key'], 'workflow');
+        });
+        it('should handle sources with same priority (first wins)', () => {
+            const content = 'Value: {var}';
+            const sources = [
+                { name: 'source-a', priority: 1, values: { var: 'a-value' } },
+                { name: 'source-b', priority: 1, values: { var: 'b-value' } },
+            ];
+            const result = resolveVariables(content, sources);
+            // First source with matching priority wins
+            assert.strictEqual(result.content, 'Value: a-value');
+            assert.strictEqual(result.sources['var'], 'source-a');
+        });
+    });
+    describe('AC3: Standard variables documented and working', () => {
+        it('should resolve project_root from environment source', () => {
+            const content = 'Root: {project_root}';
+            const sources = [
+                { name: 'environment', priority: 4, values: { project_root: '/abs/path/to/project' } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Root: /abs/path/to/project');
+        });
+        it('should resolve date variable with YYYY-MM-DD format', () => {
+            const content = 'Today: {date}';
+            const sources = [
+                { name: 'system', priority: 4, values: { date: '2026-01-20' } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Today: 2026-01-20');
+            // Verify date format matches pattern
+            assert.match(result.content, /\d{4}-\d{2}-\d{2}/);
+        });
+        it('should resolve story_id from session source', () => {
+            const content = 'Working on {story_id}';
+            const sources = [
+                { name: 'session', priority: 2, values: { story_id: 'MSSCI-12081' } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Working on MSSCI-12081');
+        });
+        it('should resolve output_file from workflow source', () => {
+            const content = 'Write to {output_file}';
+            const sources = [
+                { name: 'workflow', priority: 1, values: { output_file: 'analysis-output.md' } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Write to analysis-output.md');
+        });
+        it('should resolve planning_artifacts from defaults', () => {
+            const content = 'Artifacts in {planning_artifacts}';
+            const sources = [
+                { name: 'defaults', priority: 5, values: { planning_artifacts: 'planning-artifacts/' } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Artifacts in planning-artifacts/');
+        });
+        it('should resolve all standard variables together', () => {
+            const content = `# Analysis for {story_id}
+
+Project: {project_root}
+Date: {date}
+Output: {output_file}
+Artifacts: {planning_artifacts}
+`;
+            const sources = [
+                { name: 'workflow', priority: 1, values: { output_file: 'report.md' } },
+                { name: 'session', priority: 2, values: { story_id: 'MSSCI-12081' } },
+                { name: 'environment', priority: 4, values: {
+                        project_root: '/Users/keithavery/Projects/pennyfarthing',
+                        date: '2026-01-20'
+                    } },
+                { name: 'defaults', priority: 5, values: { planning_artifacts: 'planning-artifacts/' } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.ok(result.content.includes('MSSCI-12081'));
+            assert.ok(result.content.includes('/Users/keithavery/Projects/pennyfarthing'));
+            assert.ok(result.content.includes('2026-01-20'));
+            assert.ok(result.content.includes('report.md'));
+            assert.ok(result.content.includes('planning-artifacts/'));
+            assert.strictEqual(result.resolved.length, 5);
+        });
+    });
+    describe('AC4: Unresolved variables flagged with warning', () => {
+        it('should leave unresolved variable as-is in content', () => {
+            const content = 'Value: {missing_var}';
+            const sources = [
+                { name: 'workflow', priority: 1, values: { other_var: 'something' } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Value: {missing_var}');
+        });
+        it('should track unresolved variables in result', () => {
+            const content = '{found} and {not_found} and {also_missing}';
+            const sources = [
+                { name: 'workflow', priority: 1, values: { found: 'yes' } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'yes and {not_found} and {also_missing}');
+            assert.deepStrictEqual(result.resolved, ['found']);
+            assert.ok(result.unresolved.includes('not_found'));
+            assert.ok(result.unresolved.includes('also_missing'));
+            assert.strictEqual(result.unresolved.length, 2);
+        });
+        it('should not include unresolved variables in sources map', () => {
+            const content = '{resolved_var} {unresolved_var}';
+            const sources = [
+                { name: 'workflow', priority: 1, values: { resolved_var: 'value' } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.ok('resolved_var' in result.sources);
+            assert.ok(!('unresolved_var' in result.sources));
+        });
+        it('should list each unresolved variable only once', () => {
+            const content = '{missing} appears twice: {missing}';
+            const sources = [];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, '{missing} appears twice: {missing}');
+            assert.deepStrictEqual(result.unresolved, ['missing']);
+        });
+    });
+    describe('Edge Cases', () => {
+        it('should match valid variable names only (letters, numbers, underscores)', () => {
+            const content = '{valid_name} {valid123} {_underscore_start}';
+            const sources = [
+                { name: 'test', priority: 1, values: {
+                        valid_name: 'a',
+                        valid123: 'b',
+                        _underscore_start: 'c'
+                    } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'a b c');
+        });
+        it('should not match variables starting with numbers', () => {
+            const content = '{123invalid} {9lives}';
+            const sources = [
+                { name: 'test', priority: 1, values: { '123invalid': 'no', '9lives': 'no' } },
+            ];
+            const result = resolveVariables(content, sources);
+            // Should remain unchanged (invalid variable syntax)
+            assert.strictEqual(result.content, '{123invalid} {9lives}');
+            assert.deepStrictEqual(result.resolved, []);
+            // These aren't variables, so they shouldn't be in unresolved either
+            assert.deepStrictEqual(result.unresolved, []);
+        });
+        it('should not match nested variables', () => {
+            const content = '{outer_{inner}}';
+            const sources = [
+                { name: 'test', priority: 1, values: { outer_inner: 'nested', inner: 'value' } },
+            ];
+            const result = resolveVariables(content, sources);
+            // Nested syntax is not supported - should not parse as a variable
+            assert.strictEqual(result.content, '{outer_{inner}}');
+        });
+        it('should handle empty string value as valid resolution', () => {
+            const content = 'Value: [{empty_value}]';
+            const sources = [
+                { name: 'test', priority: 1, values: { empty_value: '' } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Value: []');
+            assert.deepStrictEqual(result.resolved, ['empty_value']);
+            assert.deepStrictEqual(result.unresolved, []);
+        });
+        it('should treat null value as unresolved', () => {
+            const content = 'Value: {null_value}';
+            const sources = [
+                { name: 'test', priority: 1, values: { null_value: null } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Value: {null_value}');
+            assert.deepStrictEqual(result.unresolved, ['null_value']);
+        });
+        it('should treat undefined value as unresolved', () => {
+            const content = 'Value: {undefined_value}';
+            const sources = [
+                { name: 'test', priority: 1, values: { undefined_value: undefined } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Value: {undefined_value}');
+            assert.deepStrictEqual(result.unresolved, ['undefined_value']);
+        });
+        it('should convert number values to strings', () => {
+            const content = 'Count: {count} | Points: {points}';
+            const sources = [
+                { name: 'test', priority: 1, values: {
+                        count: 42,
+                        points: 3.14
+                    } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Count: 42 | Points: 3.14');
+        });
+        it('should convert boolean values to strings', () => {
+            const content = 'Enabled: {enabled} | Debug: {debug}';
+            const sources = [
+                { name: 'test', priority: 1, values: {
+                        enabled: true,
+                        debug: false
+                    } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Enabled: true | Debug: false');
+        });
+        it('should handle curly braces that are not variables', () => {
+            const content = 'JSON: { "key": "value" } and regex: [a-z]{3}';
+            const sources = [];
+            const result = resolveVariables(content, sources);
+            // These aren't valid variable patterns - should remain unchanged
+            assert.strictEqual(result.content, 'JSON: { "key": "value" } and regex: [a-z]{3}');
+        });
+        it('should handle special characters in variable values', () => {
+            const content = 'Path: {path}';
+            const sources = [
+                { name: 'test', priority: 1, values: { path: '/home/user/Documents & Files/project' } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, 'Path: /home/user/Documents & Files/project');
+        });
+        it('should handle multiline content', () => {
+            const content = `Line 1: {var1}
+Line 2: {var2}
+Line 3: {var3}`;
+            const sources = [
+                { name: 'test', priority: 1, values: { var1: 'a', var2: 'b', var3: 'c' } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, `Line 1: a
+Line 2: b
+Line 3: c`);
+        });
+        it('should handle variable in markdown code block', () => {
+            const content = '```\nconfig: {config_path}\n```';
+            const sources = [
+                { name: 'test', priority: 1, values: { config_path: '/etc/app.yaml' } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, '```\nconfig: /etc/app.yaml\n```');
+        });
+        it('should handle empty content', () => {
+            const content = '';
+            const sources = [
+                { name: 'test', priority: 1, values: { unused: 'value' } },
+            ];
+            const result = resolveVariables(content, sources);
+            assert.strictEqual(result.content, '');
+            assert.deepStrictEqual(result.resolved, []);
+            assert.deepStrictEqual(result.unresolved, []);
+        });
+    });
+    describe('resolveStepVariables convenience function', () => {
+        it('should build sources from workflow, session, and config', () => {
+            const content = '{workflow_var} and {story_id} and {project_root}';
+            const result = resolveStepVariables(content, {
+                workflowVars: { workflow_var: 'from-workflow' },
+                sessionVars: { story_id: 'MSSCI-12081' },
+                projectRoot: '/Users/keithavery/Projects/pennyfarthing',
+            });
+            assert.strictEqual(result.content, 'from-workflow and MSSCI-12081 and /Users/keithavery/Projects/pennyfarthing');
+        });
+        it('should include system defaults (date, planning_artifacts)', () => {
+            const content = 'Date: {date} | Artifacts: {planning_artifacts}';
+            const result = resolveStepVariables(content, {});
+            // Date should be current date in YYYY-MM-DD format
+            assert.match(result.content, /Date: \d{4}-\d{2}-\d{2}/);
+            // planning_artifacts should have default value
+            assert.ok(result.content.includes('planning-artifacts/'));
+        });
+        it('should work with no options provided', () => {
+            const content = 'No variables here.';
+            const result = resolveStepVariables(content);
+            assert.strictEqual(result.content, 'No variables here.');
+        });
+        it('should allow workflow vars to override system defaults', () => {
+            const content = 'Artifacts: {planning_artifacts}';
+            const result = resolveStepVariables(content, {
+                workflowVars: { planning_artifacts: 'custom-artifacts/' },
+            });
+            assert.strictEqual(result.content, 'Artifacts: custom-artifacts/');
+        });
+    });
+});
+//# sourceMappingURL=variable-resolver.test.js.map