@pennyfarthing/core 11.4.0 → 12.0.0

package/packages/core/dist/cli/commands/doctor.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"doctor.d.ts","sourceRoot":"","sources":["../../../src/cli/commands/doctor.ts"],"names":[],"mappings":"AAQA,OAAO,EACL,YAAY,EACb,MAAM,sBAAsB,CAAC;AAc9B,UAAU,aAAa;IACrB,GAAG,CAAC,EAAE,OAAO,CAAC;IACd,IAAI,CAAC,EAAE,OAAO,CAAC;IACf,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,OAAO,CAAC,EAAE,OAAO,CAAC;IAClB,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,cAAc,CAAC,EAAE,OAAO,CAAC;CAC1B;AAED;;;GAGG;AACH,eAAO,MAAM,eAAe,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,EAAE,CAQpD,CAAC;AAEF,MAAM,WAAW,WAAW;IAC1B,IAAI,EAAE,MAAM,CAAC;IACb,MAAM,EAAE,MAAM,GAAG,MAAM,GAAG,MAAM,CAAC;IACjC,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,GAAG,CAAC,EAAE,MAAM,IAAI,CAAC;CAClB;AAED,wBAAsB,aAAa,CAAC,OAAO,EAAE,aAAa,GAAG,OAAO,CAAC,IAAI,CAAC,CAsKzE;AAED,wBAAgB,iBAAiB,CAAC,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,UAAU,CAAC,OAAO,YAAY,CAAC,GAAG,WAAW,EAAE,CAW/G;AAED,wBAAgB,cAAc,CAAC,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,UAAU,CAAC,OAAO,YAAY,CAAC,GAAG,WAAW,EAAE,CAiE5G;AAED;;;GAGG;AACH,wBAAgB,sBAAsB,CAAC,WAAW,EAAE,MAAM,EAAE,gBAAgB,EAAE,MAAM,GAAG,IAAI,GAAG,WAAW,EAAE,CA4I1G;AA0JD;;;;GAIG;AACH,wBAAgB,mBAAmB,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,EAAE,CAsDtE;AAED;;;;;;GAMG;AACH,wBAAgB,kBAAkB,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,EAAE,CA2BrE;AA8tCD,wBAAgB,gBAAgB,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,EAAE,CAkBnE;AAED,wBAAgB,UAAU,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,EAAE,CAuD7D;AASD;;;;;;;;;;;;;;GAcG;AACH,wBAAgB,aAAa,CAAC,WAAW,EAAE,MAAM,EAAE,eAAe,EAAE,MAAM,GAAG,IAAI,GAAG,WAAW,EAAE,CA+NhG;AAED;;;GAGG;AACH,wBAAgB,YAAY,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,EAAE,CA8G/D;AAED;;;GAGG;AACH,wBAAgB,UAAU,CAAC,eAAe,EAAE,MAAM,GAAG,IAAI,GAAG,WAAW,CAoBtE;AAoBD;;;GAGG;AACH,wBAAgB,gBAAgB,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,EAAE,CA+JnE;AAED;;;;;;GAMG;AACH,wBAAgB,yBAAyB,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,CAkF1E;AAED;;;;GAIG;AACH,wBAAgB,uBAAuB,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,CA4ExE;AAED;;;;;;GAMG;AACH,wBAAgB,eAAe,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,EAAE,CAsIlE"}
+{"version":3,"file":"doctor.d.ts","sourceRoot":"","sources":["../../../src/cli/commands/doctor.ts"],"names":[],"mappings":"AAQA,OAAO,EACL,YAAY,EACb,MAAM,sBAAsB,CAAC;AAe9B,UAAU,aAAa;IACrB,GAAG,CAAC,EAAE,OAAO,CAAC;IACd,IAAI,CAAC,EAAE,OAAO,CAAC;IACf,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,OAAO,CAAC,EAAE,OAAO,CAAC;IAClB,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,cAAc,CAAC,EAAE,OAAO,CAAC;CAC1B;AAED;;;GAGG;AACH,eAAO,MAAM,eAAe,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,EAAE,CAQpD,CAAC;AAEF,MAAM,WAAW,WAAW;IAC1B,IAAI,EAAE,MAAM,CAAC;IACb,MAAM,EAAE,MAAM,GAAG,MAAM,GAAG,MAAM,CAAC;IACjC,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,GAAG,CAAC,EAAE,MAAM,IAAI,CAAC;CAClB;AAED,wBAAsB,aAAa,CAAC,OAAO,EAAE,aAAa,GAAG,OAAO,CAAC,IAAI,CAAC,CAsKzE;AAED,wBAAgB,iBAAiB,CAAC,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,UAAU,CAAC,OAAO,YAAY,CAAC,GAAG,WAAW,EAAE,CAW/G;AAED,wBAAgB,cAAc,CAAC,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,UAAU,CAAC,OAAO,YAAY,CAAC,GAAG,WAAW,EAAE,CAiE5G;AAED;;;GAGG;AACH,wBAAgB,sBAAsB,CAAC,WAAW,EAAE,MAAM,EAAE,gBAAgB,EAAE,MAAM,GAAG,IAAI,GAAG,WAAW,EAAE,CA4I1G;AAoLD;;;;GAIG;AACH,wBAAgB,mBAAmB,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,EAAE,CAuDtE;AAED;;;;;;GAMG;AACH,wBAAgB,kBAAkB,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,EAAE,CA4BrE;AAo0CD,wBAAgB,gBAAgB,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,EAAE,CAkBnE;AAED,wBAAgB,UAAU,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,EAAE,CAuD7D;AASD;;;;;;;;;;;;;;GAcG;AACH,wBAAgB,aAAa,CAAC,WAAW,EAAE,MAAM,EAAE,eAAe,EAAE,MAAM,GAAG,IAAI,GAAG,WAAW,EAAE,CAyOhG;AAED;;;GAGG;AACH,wBAAgB,YAAY,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,EAAE,CA8G/D;AAED;;;GAGG;AACH,wBAAgB,UAAU,CAAC,eAAe,EAAE,MAAM,GAAG,IAAI,GAAG,WAAW,CAoBtE;AAoBD;;;GAGG;AACH,wBAAgB,gBAAgB,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,EAAE,CA+JnE;AAED;;;;;;GAMG;AACH,wBAAgB,yBAAyB,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,CAkF1E;AAED;;;;GAIG;AACH,wBAAgB,uBAAuB,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,CA4ExE;AAED;;;;;;GAMG;AACH,wBAAgB,eAAe,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,EAAE,CAsKlE"}

package/packages/core/dist/cli/commands/doctor.js

@@ -8,10 +8,11 @@ import { logger } from '../utils/logger.js';
 import { readManifest } from '../utils/manifest.js';
 import { pathExists, isDirectory, isSymlink, fileMatchesHash, filesMatch } from '../utils/files.js';
 import { getPackageVersion, getAssetsPath } from '../utils/version.js';
-import { findNodeModulesPath } from '../utils/node-modules.js';
+import { findNodeModulesPath, findLocalSymlinkTargets } from '../utils/node-modules.js';
 import { ALL_SYMLINKS, CORE_AGENTS } from '../utils/constants.js';
 import { getPfVersion, installPfCli } from '../utils/python.js';
 import { LEGACY_HOOK_MIGRATIONS, migrateHookPaths } from '../utils/settings.js';
+import { getCurrentTheme } from '../utils/themes.js';
 /**
  * Category-to-check-function mapping for --category filtering.
  * Each category maps to the check functions that produce results in that group.
@@ -195,7 +196,7 @@ export function checkInstallation(projectRoot, manifest) {
     results.push({
         name: 'manifest/exists',
         status: manifest ? 'pass' : 'fail',
-        detail: manifest ? `v${manifest.version}` : 'Run `pennyfarthing init`'
+        detail: manifest ? `v${manifest.version}` : 'Run `pf setup`'
     });
     return results;
 }
@@ -467,23 +468,45 @@ function refreshSkillsCopy(projectRoot, builtInSkillsPath) {
  */
 function checkSymlinks(projectRoot, nodeModulesPath) {
     const results = [];
-    // Check if node_modules is available
-    if (!nodeModulesPath) {
+    const localTargets = findLocalSymlinkTargets(projectRoot);
+    // Check if we have any source available
+    if (!nodeModulesPath && !localTargets) {
         results.push({
             name: 'core/node_modules',
             status: 'fail',
-            detail: 'pennyfarthing not found in node_modules - run npm install'
+            detail: 'pennyfarthing not found in node_modules and no local symlink targets in repos.yaml'
         });
         return results;
     }
-    results.push({
-        name: 'core/node_modules',
-        status: 'pass',
-        detail: relative(projectRoot, nodeModulesPath)
-    });
+    if (localTargets) {
+        results.push({
+            name: 'core/source',
+            status: 'pass',
+            detail: 'repos.yaml local symlink targets'
+        });
+    }
+    if (nodeModulesPath) {
+        results.push({
+            name: 'core/node_modules',
+            status: 'pass',
+            detail: relative(projectRoot, nodeModulesPath)
+        });
+    }
     for (const { name, link } of ALL_SYMLINKS) {
         const linkPath = join(projectRoot, link);
-        const targetPath = join(nodeModulesPath, name);
+        // Determine the correct target: local source preferred, node_modules fallback
+        const localTarget = localTargets?.get(link);
+        const targetPath = localTarget
+            ? localTarget
+            : nodeModulesPath ? join(nodeModulesPath, name) : null;
+        if (!targetPath) {
+            results.push({
+                name: `symlink/${name}`,
+                status: 'warn',
+                detail: 'No source path available'
+            });
+            continue;
+        }
         const expectedRelative = relative(dirname(linkPath), targetPath);
         if (!isSymlink(linkPath)) {
             // Not a symlink
@@ -527,7 +550,7 @@ function checkSymlinks(projectRoot, nodeModulesPath) {
                 results.push({
                     name: `symlink/${name}`,
                     status: 'fail',
-                    detail: 'Broken symlink - run npm install',
+                    detail: `Broken symlink (${resolved}) - run update to fix`,
                     fix: () => {
                         unlinkSync(linkPath);
                         symlinkSync(expectedRelative, linkPath);
@@ -571,12 +594,13 @@ export function checkUserFilesBasic(projectRoot) {
             detail: `${existingSidecars.length} agent sidecars configured`
         });
     }
-    // Check persona config at canonical location
-    const personaConfig = join(projectRoot, '.pennyfarthing/config.local.yaml');
+    // Check persona config — use getCurrentTheme() which checks both
+    // config.local.yaml (priority 1) and persona-config.yaml (priority 2)
+    const detectedTheme = getCurrentTheme(projectRoot);
     results.push({
         name: 'persona-config',
-        status: pathExists(personaConfig) ? 'pass' : 'warn',
-        detail: pathExists(personaConfig) ? undefined : 'No theme configured'
+        status: detectedTheme ? 'pass' : 'warn',
+        detail: detectedTheme ? undefined : 'No theme configured'
     });
     // Check settings.local.json exists (CRITICAL - registers hooks with Claude Code)
     const settingsLocal = join(projectRoot, '.claude/settings.local.json');
@@ -622,6 +646,7 @@ export function checkSettingsHooks(projectRoot) {
     results.push(checkSessionStartHooks(projectRoot, installationType));
     results.push(checkOtelAutoStart(projectRoot, installationType));
     results.push(checkAutoLoadSmHook(projectRoot));
+    results.push(checkCompactPrimeHook(projectRoot));
     results.push(checkStopHook(projectRoot, installationType));
     results.push(checkPostToolUseHook(projectRoot, installationType));
     results.push(checkBenchmarkPermissions(projectRoot));
@@ -652,12 +677,13 @@ function checkUserFiles(projectRoot) {
             detail: `${existingSidecars.length} agent sidecars configured`
         });
     }
-    // Check persona config at canonical location
-    const personaConfig = join(projectRoot, '.pennyfarthing/config.local.yaml');
+    // Check persona config — use getCurrentTheme() which checks both
+    // config.local.yaml (priority 1) and persona-config.yaml (priority 2)
+    const detectedTheme = getCurrentTheme(projectRoot);
     results.push({
         name: 'persona-config',
-        status: pathExists(personaConfig) ? 'pass' : 'warn',
-        detail: pathExists(personaConfig) ? undefined : 'No theme configured'
+        status: detectedTheme ? 'pass' : 'warn',
+        detail: detectedTheme ? undefined : 'No theme configured'
     });
     // Check settings.local.json exists (CRITICAL - registers hooks with Claude Code)
     const settingsLocal = join(projectRoot, '.claude/settings.local.json');
@@ -686,6 +712,9 @@ function checkUserFiles(projectRoot) {
         // Check auto-load-sm hook is configured (auto-invokes /sm on new sessions)
         const autoLoadSmCheck = checkAutoLoadSmHook(projectRoot);
         results.push(autoLoadSmCheck);
+        // Check compact/prime hook is configured (re-primes context after compression)
+        const compactPrimeCheck = checkCompactPrimeHook(projectRoot);
+        results.push(compactPrimeCheck);
         // Check Stop hook is configured (question reflector enforcement)
         const stopHookCheck = checkStopHook(projectRoot, installationType);
         results.push(stopHookCheck);
@@ -1052,6 +1081,90 @@ HOOKEOF
 `, { mode: 0o755 });
     }
 }
+/**
+ * Check that compact/prime hook is configured in SessionStart hooks.
+ * This re-primes agent context after context window compression.
+ */
+function checkCompactPrimeHook(projectRoot) {
+    const settingsPath = join(projectRoot, '.claude/settings.local.json');
+    try {
+        const settings = JSON.parse(readFileSync(settingsPath, 'utf8'));
+        if (!settings.hooks?.SessionStart) {
+            return {
+                name: 'settings/compact-prime',
+                status: 'warn',
+                detail: 'Missing SessionStart hooks - compact/prime not configured',
+                fix: () => {
+                    addCompactPrimeHook(projectRoot);
+                }
+            };
+        }
+        const hasCompactPrime = settings.hooks.SessionStart.some((entry) => {
+            if (typeof entry === 'object' && entry !== null) {
+                const hookEntry = entry;
+                return hookEntry.matcher === 'compact' && hookEntry.hooks?.some(h => h.command?.includes('pf.sh prime'));
+            }
+            return false;
+        });
+        if (!hasCompactPrime) {
+            return {
+                name: 'settings/compact-prime',
+                status: 'warn',
+                detail: 'compact/prime not configured - context will not re-prime after compression',
+                fix: () => {
+                    addCompactPrimeHook(projectRoot);
+                }
+            };
+        }
+        return {
+            name: 'settings/compact-prime',
+            status: 'pass',
+            detail: undefined
+        };
+    }
+    catch {
+        return {
+            name: 'settings/compact-prime',
+            status: 'warn',
+            detail: 'Could not parse settings.local.json'
+        };
+    }
+}
+/**
+ * Fix function: Add compact/prime hook to SessionStart in settings.local.json
+ */
+function addCompactPrimeHook(projectRoot) {
+    const settingsPath = join(projectRoot, '.claude/settings.local.json');
+    const requiredHook = {
+        matcher: 'compact',
+        hooks: [
+            {
+                type: 'command',
+                command: '"$CLAUDE_PROJECT_DIR"/.pennyfarthing/scripts/core/pf.sh prime'
+            }
+        ]
+    };
+    let settings = {};
+    if (pathExists(settingsPath)) {
+        try {
+            settings = JSON.parse(readFileSync(settingsPath, 'utf8'));
+        }
+        catch {
+            // Start fresh if parse fails
+        }
+    }
+    if (!settings.hooks) {
+        settings.hooks = {};
+    }
+    const hooks = settings.hooks;
+    if (!hooks.SessionStart) {
+        hooks.SessionStart = [requiredHook];
+    }
+    else if (Array.isArray(hooks.SessionStart)) {
+        hooks.SessionStart = [...hooks.SessionStart, requiredHook];
+    }
+    writeFileSync(settingsPath, JSON.stringify(settings, null, 2), 'utf8');
+}
 /**
  * Check that Stop hook is properly configured in settings.local.json
  * This is needed for question reflector enforcement in Cyclist
@@ -1834,11 +1947,21 @@ export function checkGitHooks(projectRoot, nodeModulesPath) {
     if (!pathExists(gitHooksDir)) {
         return results;
     }
-    // Detect framework/orchestrator repo (has pennyfarthing-dist/ at project root)
+    // Detect framework repo (has pennyfarthing-dist/ at root)
     const isFrameworkRepo = pathExists(join(projectRoot, 'pennyfarthing-dist'));
-    const frameworkHooksDir = isFrameworkRepo
-        ? join(projectRoot, 'pennyfarthing-dist/scripts/hooks')
-        : null;
+    // Detect orchestrator repo (has pennyfarthing/pennyfarthing-dist/ — inlined framework)
+    const isOrchestratorRepo = !isFrameworkRepo
+        && pathExists(join(projectRoot, 'pennyfarthing/pennyfarthing-dist'));
+    // Either pattern means hooks should be symlinks, not copies
+    const isDevRepo = isFrameworkRepo || isOrchestratorRepo;
+    // Resolve hooks source directory
+    let frameworkHooksDir = null;
+    if (isFrameworkRepo) {
+        frameworkHooksDir = join(projectRoot, 'pennyfarthing-dist/scripts/hooks');
+    }
+    else if (isOrchestratorRepo) {
+        frameworkHooksDir = join(projectRoot, 'pennyfarthing/pennyfarthing-dist/scripts/hooks');
+    }
     // Need either node_modules or framework source to compare against
     if (!nodeModulesPath && !frameworkHooksDir) {
         return results;
@@ -1869,9 +1992,9 @@ export function checkGitHooks(projectRoot, nodeModulesPath) {
                 status: 'warn',
                 detail: 'Not installed',
                 fix: () => {
-                    if (isFrameworkRepo) {
-                        // Framework repos: create symlink (relative from hooks dir to source)
-                        const absSource = join(projectRoot, 'pennyfarthing-dist/scripts/hooks', hook.source);
+                    if (isDevRepo) {
+                        // Dev repos (framework or orchestrator): create symlink from hooks dir to source
+                        const absSource = join(frameworkHooksDir, hook.source);
                         const relTarget = relative(gitHooksDir, absSource);
                         symlinkSync(relTarget, destPath);
                     }
@@ -1886,15 +2009,15 @@ export function checkGitHooks(projectRoot, nodeModulesPath) {
         }
         // Check if hook is a symlink (framework repos should use symlinks)
         const hookIsSymlink = isSymlink(destPath);
-        if (isFrameworkRepo && !hookIsSymlink) {
-            // Framework repo has a copied hook instead of a symlink — it will go stale
+        if (isDevRepo && !hookIsSymlink) {
+            // Dev repo has a copied hook instead of a symlink — it will go stale
             results.push({
                 name: `git-hook/${hook.dest}`,
                 status: 'warn',
                 detail: 'Copy instead of symlink (will go stale)',
                 fix: () => {
                     // Backup existing, replace with symlink
-                    const absSource = join(projectRoot, 'pennyfarthing-dist/scripts/hooks', hook.source);
+                    const absSource = join(frameworkHooksDir, hook.source);
                     const relTarget = relative(gitHooksDir, absSource);
                     renameSync(destPath, `${destPath}.backup`);
                     symlinkSync(relTarget, destPath);
@@ -1921,7 +2044,7 @@ export function checkGitHooks(projectRoot, nodeModulesPath) {
                         detail: `Broken symlink → ${target}`,
                         fix: () => {
                             unlinkSync(destPath);
-                            const absSource = join(projectRoot, 'pennyfarthing-dist/scripts/hooks', hook.source);
+                            const absSource = join(frameworkHooksDir ?? join(nodeModulesPath, 'scripts/hooks'), hook.source);
                             const relTarget = relative(gitHooksDir, absSource);
                             symlinkSync(relTarget, destPath);
                         }
@@ -2506,12 +2629,14 @@ export function checkFileLayout(projectRoot) {
         status: existsSync(manifestPath) ? 'pass' : 'fail',
         detail: existsSync(manifestPath) ? undefined : 'Missing .pennyfarthing/manifest.json'
     });
-    // 2. Config at .pennyfarthing/config.local.yaml
+    // 2. Theme config — use getCurrentTheme() which checks both
+    // config.local.yaml (priority 1) and persona-config.yaml (priority 2)
     const configPath = join(projectRoot, '.pennyfarthing/config.local.yaml');
+    const layoutTheme = getCurrentTheme(projectRoot);
     results.push({
         name: 'layout/config',
-        status: existsSync(configPath) ? 'pass' : 'warn',
-        detail: existsSync(configPath) ? undefined : 'No theme configured at .pennyfarthing/config.local.yaml'
+        status: layoutTheme ? 'pass' : 'warn',
+        detail: layoutTheme ? undefined : 'No theme configured at .pennyfarthing/config.local.yaml'
     });
     // 3. Old config at .claude/persona-config.yaml
     const oldConfigPath = join(projectRoot, '.claude/persona-config.yaml');
@@ -2591,6 +2716,26 @@ export function checkFileLayout(projectRoot) {
             status: 'pass',
             detail: undefined
         });
+        // Check execute permission on each shell script in project hooks
+        try {
+            const hookFiles = readdirSync(projectHooksPath).filter(f => f.endsWith('.sh'));
+            for (const file of hookFiles) {
+                const hookPath = join(projectHooksPath, file);
+                const stats = statSync(hookPath);
+                const isExecutable = (stats.mode & 0o111) !== 0;
+                results.push({
+                    name: `layout/project-hooks/${file}`,
+                    status: isExecutable ? 'pass' : 'warn',
+                    detail: isExecutable ? undefined : 'Not executable — will cause Permission denied on session start',
+                    fix: isExecutable ? undefined : () => {
+                        chmodSync(hookPath, 0o755);
+                    }
+                });
+            }
+        }
+        catch {
+            // Ignore read errors
+        }
     }
     // 8. Old project hooks at .claude/project/hooks/
     const oldProjectHooksPath = join(projectRoot, '.claude/project/hooks');
@@ -2620,6 +2765,17 @@ export function checkFileLayout(projectRoot) {
                     }
                     removeSync(oldProjectHooksPath);
                 }
+                // Ensure migrated shell scripts are executable
+                try {
+                    for (const file of readdirSync(projectHooksPath)) {
+                        if (file.endsWith('.sh')) {
+                            chmodSync(join(projectHooksPath, file), 0o755);
+                        }
+                    }
+                }
+                catch {
+                    // Ignore
+                }
             }
         });
     }