@pennyfarthing/core 11.4.0 → 11.5.0-alpha.0

package/pennyfarthing-dist/pf/bikerack/portrait_resolver.py

@@ -41,6 +41,16 @@ def _extract_agent_slug(theme_yaml: Path, agent: str) -> str | None:
     return None
 
 
+def _is_lfs_pointer(path: Path) -> bool:
+    """Check if a file is a git-lfs pointer instead of actual image data."""
+    try:
+        with open(path, "rb") as f:
+            header = f.read(44)
+        return header.startswith(b"version https://git-lfs")
+    except OSError:
+        return False
+
+
 def _find_portrait(portraits_theme_dir: Path, slug: str) -> Path | None:
     """Find a portrait file matching the slug in a theme's portrait directory."""
     if not portraits_theme_dir.is_dir():
@@ -50,11 +60,13 @@ def _find_portrait(portraits_theme_dir: Path, slug: str) -> Path | None:
         if size_dir.is_dir():
             for f in size_dir.iterdir():
                 if f.name.lower().startswith(slug.lower()) and f.suffix in (".png", ".jpg"):
-                    return f
+                    if not _is_lfs_pointer(f):
+                        return f
     # Fallback to root of theme dir
     for f in portraits_theme_dir.iterdir():
         if f.is_file() and f.name.lower().startswith(slug.lower()) and f.suffix in (".png", ".jpg"):
-            return f
+            if not _is_lfs_pointer(f):
+                return f
     return None
 
 

package/pennyfarthing-dist/pf/bikerack/progress_panel.py

@@ -3,6 +3,8 @@
 Combines story context, workflow phase, acceptance criteria, todos, and
 git status into a single at-a-glance panel. Subscribes to 4 WS channels:
 /ws/story, /ws/todos, /ws/git, /ws/sprint.
+
+Story 120-8: Added Enter keybinding for story detail drill-through.
 """
 
 from __future__ import annotations
@@ -11,6 +13,7 @@ from typing import Any
 
 from rich.console import Group
 from rich.text import Text
+from textual.binding import Binding
 
 from pf.bikerack.base_panel import (
     PANEL_ICONS,
@@ -31,6 +34,10 @@ class ProgressPanel(BasePanel):
     panel_name: str = "Progress"
     icon: str = PANEL_ICONS.get("progress", ("\uf200", "P"))[0]
 
+    BINDINGS = [
+        Binding("enter", "drill_detail", "Story Details", show=False),
+    ]
+
     def __init__(self, client: Any = None, **kwargs: Any) -> None:
         super().__init__(client=client, **kwargs)
         self._story_data: dict[str, Any] | None = None
@@ -79,6 +86,49 @@ class ProgressPanel(BasePanel):
         except Exception:
             pass
 
+    def drill_into_story(self) -> None:
+        """Push StoryDetailScreen for the current story."""
+        story_data = self._build_story_detail_data()
+        if story_data is None:
+            return
+        from pf.bikerack.story_detail_screen import StoryDetailScreen
+
+        try:
+            self.app.push_screen(StoryDetailScreen(story_data=story_data))
+        except Exception:
+            pass
+
+    def action_drill_detail(self) -> None:
+        """Action handler for Enter keybinding — drill into story details."""
+        self.drill_into_story()
+
+    def _build_story_detail_data(self) -> dict[str, Any] | None:
+        """Build story_data dict suitable for StoryDetailScreen."""
+        story = self._story_data or {}
+        sprint = self._sprint_data or {}
+
+        current = sprint.get("sprint", {}).get("currentStory")
+        if isinstance(current, str) and current:
+            story_id = current
+        else:
+            story_id = story.get("id", "")
+
+        if not story_id and not story.get("title"):
+            return None
+
+        return {
+            "id": story_id,
+            "title": story.get("title", ""),
+            "points": story.get("points", ""),
+            "status": story.get("status", ""),
+            "assignee": story.get("assignee", ""),
+            "workflow": story.get("workflow", ""),
+            "workflow_phase": story.get("phase", ""),
+            **{k: v for k, v in story.items() if k not in (
+                "id", "title", "points", "status", "assignee", "workflow", "phase",
+            )},
+        }
+
     def render_panel(self, payload: dict[str, Any]) -> Any:
         """Render unified progress view."""
         parts: list[Any] = []
@@ -116,6 +166,10 @@ class ProgressPanel(BasePanel):
         if git is not None:
             parts.append(git)
 
+        # --- Drill-through hint ---
+        parts.append(Text(""))
+        parts.append(Text("[Enter] Story Details", style="dim"))
+
         return Group(*parts)
 
     def _render_story_header(self) -> Text | None:

package/pennyfarthing-dist/pf/bikerack/sprint_panel.py

@@ -280,6 +280,16 @@ class SprintPanel(Widget):
             f"In Progress: {in_progress} | "
             f"Velocity: {velocity}"
         )
+        registry = payload.get("registry")
+        if registry and not registry.get("isDefault", True):
+            reg_type = registry.get("type", "")
+            reg_name = registry.get("name", "")
+            if reg_type and reg_name:
+                header_text.append(f" [{reg_type}:{reg_name}]")
+            elif reg_name:
+                header_text.append(f" [{reg_name}]")
+            elif reg_type:
+                header_text.append(f" [{reg_type}]")
         try:
             self.query_one("#sprint-header", Static).update(header_text)
         except Exception:
@@ -356,6 +366,54 @@ class SprintPanel(Widget):
             if cursor_node_key == f"epic:{epic_id}":
                 cursor_target = epic_node
 
+        # Completed Epics section (Story 110-6)
+        completed_epics = payload.get("completedEpics", [])
+        if completed_epics:
+            separator_label = Text("── Completed ──", style="bold dim")
+            tree.root.add_leaf(separator_label, data={"type": "separator"})
+
+            for epic in completed_epics:
+                epic_id = epic.get("id", "")
+                epic_title = epic.get("title", "")
+                stories = epic.get("stories", [])
+
+                total_pts = 0
+                done_pts = 0
+                for story in stories:
+                    pts = story.get("points", 0)
+                    if isinstance(pts, (int, float)):
+                        total_pts += pts
+                        if _is_terminal(story.get("status", "")):
+                            done_pts += pts
+
+                label = _build_epic_label(
+                    epic_id, epic_title, done_pts, total_pts,
+                    jira_key=epic.get("jiraKey", ""),
+                )
+                epic_data: dict[str, Any] = {
+                    "type": "epic",
+                    "id": epic_id,
+                    "title": epic_title,
+                }
+                epic_node = tree.root.add(label, data=epic_data)
+
+                for story in stories:
+                    story_label = _build_story_label(story, current_story_id)
+                    story_data: dict[str, Any] = {"type": "story", "story": story}
+                    epic_node.add_leaf(story_label, data=story_data)
+
+                # Completed epics: collapsed by default, respect saved state
+                if epic_id in saved_expanded:
+                    if saved_expanded[epic_id]:
+                        epic_node.expand()
+                    else:
+                        epic_node.collapse()
+                else:
+                    epic_node.collapse()
+
+                if cursor_node_key == f"epic:{epic_id}":
+                    cursor_target = epic_node
+
         # Future Initiatives section (Story 118-1)
         future_epics = payload.get("futureEpics", [])
         if future_epics:

package/pennyfarthing-dist/pf/bikerack/story_detail_screen.py

@@ -1,7 +1,8 @@
 """StoryDetailScreen — Mission dossier detail view for BikeRack TUI.
 
 Story 110-2: Story drill-through with dossier detail screen.
-Pushed via Screen.push() from SprintPanel when user presses Enter on a story.
+Story 120-8: Upgraded to use StoryDetailWidget with native Textual widgets.
+Pushed via Screen.push() from SprintPanel or ProgressPanel.
 """
 
 from __future__ import annotations
@@ -9,17 +10,17 @@ from __future__ import annotations
 import webbrowser
 from typing import Any
 
-from rich.text import Text
 from textual.binding import Binding
+from textual.containers import VerticalScroll
 from textual.screen import Screen
-from textual.widgets import Static
+
+from pf.bikerack.story_detail_widget import StoryDetailWidget
 
 
 class StoryDetailScreen(Screen):
     """Detail screen showing story dossier layout.
 
-    Displays AC checklist, workflow phase dots, git branch, PR link,
-    and session notes in a mission-dossier layout.
+    Delegates rendering to StoryDetailWidget inside a VerticalScroll.
     """
 
     BINDINGS = [
@@ -57,107 +58,11 @@ class StoryDetailScreen(Screen):
         return merged
 
     def compose(self):
-        """Compose the dossier layout with header, ACs, workflow, git info.
-
-        Absent sections are simply omitted (Tufte: absence is information).
-        """
-        data = self._story_data
-
-        # Header section
-        title = data.get("title", "Unknown Story")
-        points = data.get("points", "?")
-        status = data.get("status", "unknown")
-        jira_key = data.get("jiraKey", "")
-        assignee = data.get("assignee", "")
-        priority = data.get("priority", "")
-
-        header_text = Text()
-        if jira_key:
-            header_text.append(f"{jira_key}", style="bold cyan")
-            header_text.append("  ")
-        header_text.append(f"{title}", style="bold")
-        # Metadata line
-        meta_parts = [status]
-        if points and points != "?":
-            meta_parts.append(f"{points} pts")
-        if priority:
-            meta_parts.append(priority)
-        if assignee:
-            from pf.bikerack.sprint_panel import _format_assignee
-
-            name = _format_assignee(assignee)
-            if name:
-                meta_parts.append(name)
-        separator = " \u00b7 "
-        header_text.append(f"\n{separator.join(meta_parts)}", style="dim")
-        yield Static(header_text, id="dossier-header")
-
-        # Context section (only if context files exist)
-        has_epic_ctx = data.get("has_epic_context", False)
-        has_story_ctx = data.get("has_story_context", False)
-        if has_epic_ctx or has_story_ctx:
-            ctx_text = Text()
-            ctx_text.append("Context\n", style="bold underline")
-            if has_epic_ctx:
-                ctx_text.append("  \u2713 Epic context\n", style="green")
-            else:
-                ctx_text.append("  \u25cb Epic context\n", style="dim")
-            if has_story_ctx:
-                ctx_text.append("  \u2713 Story context\n", style="green")
-            else:
-                ctx_text.append("  \u25cb Story context\n", style="dim")
-            yield Static(ctx_text, id="dossier-context")
-
-        # Acceptance Criteria section
-        acs = data.get("acceptance_criteria", [])
-        if acs:
-            ac_text = Text()
-            done_count = sum(1 for ac in acs if ac.get("done"))
-            ac_text.append("Acceptance Criteria", style="bold underline")
-            ac_text.append(f"  {done_count}/{len(acs)}\n", style="dim")
-            for ac in acs:
-                check = "\u2713" if ac.get("done") else "\u25cb"
-                style = "green" if ac.get("done") else ""
-                ac_text.append(f"  {check} {ac.get('text', '')}\n", style=style)
-            yield Static(ac_text, id="dossier-ac")
-
-        # Workflow section
-        workflow = data.get("workflow", "")
-        phase = data.get("workflow_phase", "")
-        if workflow:
-            wf_text = Text()
-            wf_text.append("Workflow\n", style="bold underline")
-            wf_text.append(f"  {workflow}", style="cyan")
-            if phase:
-                wf_text.append(f"  Phase: {phase}", style="yellow")
-            wf_text.append("\n")
-            yield Static(wf_text, id="dossier-workflow")
-
-        # Git info section
-        branch = data.get("git_branch", "")
-        pr_url = data.get("pr_url")
-        if branch or pr_url:
-            git_text = Text()
-            git_text.append("Git\n", style="bold underline")
-            if branch:
-                git_text.append(f"  Branch: {branch}\n")
-            if pr_url:
-                git_text.append(f"  PR: {pr_url}\n", style="cyan")
-            yield Static(git_text, id="dossier-git")
-
-        # Session notes section
-        notes = data.get("session_notes", "")
-        if notes:
-            notes_text = Text()
-            notes_text.append("Session Notes\n", style="bold underline")
-            notes_text.append(f"  {notes}\n")
-            yield Static(notes_text, id="dossier-notes")
-
-        # Keybinding hint
-        hint = Text.from_markup(
-            "\n[dim][Escape] Back  [Enter] Open PR[/dim]"
+        """Compose the dossier layout using StoryDetailWidget."""
+        yield VerticalScroll(
+            StoryDetailWidget(story_data=self._story_data),
+            id="detail-scroll",
         )
-        yield Static(hint, id="dossier-hint")
 
     def action_pop_screen(self) -> None:
         """Pop this screen off the stack."""

package/pennyfarthing-dist/pf/bikerack/story_detail_widget.py

@@ -0,0 +1,167 @@
+"""StoryDetailWidget — Reusable story detail view using native Textual widgets.
+
+Story 120-8: Story details and progress page enrichment with native Textual widgets.
+Renders story data inside Collapsible sections with Rule separators.
+Used by both StoryDetailScreen and ProgressPanel drill-through.
+"""
+
+from __future__ import annotations
+
+from typing import Any
+
+from rich.text import Text
+from textual.widget import Widget
+from textual.widgets import Collapsible, Rule, Static
+
+
+class StoryDetailWidget(Widget):
+    """Reusable story detail view with native Textual widgets.
+
+    Renders story data as Collapsible sections for ACs, Workflow, Git,
+    Context, and Session Notes. Absent sections are omitted (Tufte pattern).
+    """
+
+    def __init__(self, story_data: dict[str, Any] | None = None, **kwargs: Any) -> None:
+        super().__init__(**kwargs)
+        self._story_data: dict[str, Any] = story_data or {}
+
+    def compose(self):
+        """Compose the detail layout with header and collapsible sections."""
+        data = self._story_data
+
+        # Header — always present
+        yield self._build_header(data)
+
+        # Sections — only yielded when data exists
+        sections_yielded = 0
+
+        # Acceptance Criteria
+        acs = data.get("acceptance_criteria", [])
+        if acs:
+            if sections_yielded > 0:
+                yield Rule()
+            done_count = sum(1 for ac in acs if ac.get("done"))
+            yield self._build_ac_section(acs, done_count)
+            sections_yielded += 1
+
+        # Workflow
+        workflow = data.get("workflow", "")
+        if workflow:
+            if sections_yielded > 0:
+                yield Rule()
+            phase = data.get("workflow_phase", "")
+            yield self._build_workflow_section(workflow, phase)
+            sections_yielded += 1
+
+        # Git
+        branch = data.get("git_branch", "")
+        pr_url = data.get("pr_url")
+        if branch or pr_url:
+            if sections_yielded > 0:
+                yield Rule()
+            yield self._build_git_section(branch, pr_url)
+            sections_yielded += 1
+
+        # Context
+        has_epic_ctx = data.get("has_epic_context", False)
+        has_story_ctx = data.get("has_story_context", False)
+        if has_epic_ctx or has_story_ctx:
+            if sections_yielded > 0:
+                yield Rule()
+            yield self._build_context_section(has_epic_ctx, has_story_ctx)
+            sections_yielded += 1
+
+        # Session Notes
+        notes = data.get("session_notes", "")
+        if notes:
+            if sections_yielded > 0:
+                yield Rule()
+            yield self._build_notes_section(notes)
+            sections_yielded += 1
+
+    @staticmethod
+    def _build_header(data: dict[str, Any]) -> Static:
+        """Build the story header with title and metadata."""
+        title = data.get("title", "Unknown Story")
+        points = data.get("points", "?")
+        status = data.get("status", "unknown")
+        jira_key = data.get("jiraKey", "")
+        assignee = data.get("assignee", "")
+        priority = data.get("priority", "")
+
+        header_text = Text()
+        if jira_key:
+            header_text.append(f"{jira_key}", style="bold cyan")
+            header_text.append("  ")
+        header_text.append(f"{title}", style="bold")
+        if points and points != "?":
+            header_text.append(f"  {points}pt", style="dim")
+
+        meta_parts = [status]
+        if priority:
+            meta_parts.append(priority)
+        if assignee:
+            meta_parts.append(assignee)
+        separator = " \u00b7 "
+        header_text.append(f"\n{separator.join(meta_parts)}", style="dim")
+
+        return Static(header_text, id="detail-header")
+
+    @staticmethod
+    def _build_ac_section(
+        acs: list[dict[str, Any]], done_count: int
+    ) -> Collapsible:
+        """Build the Acceptance Criteria collapsible section."""
+        ac_text = Text()
+        for ac in acs:
+            check = "\u2713" if ac.get("done") else "\u25cb"
+            style = "green" if ac.get("done") else ""
+            ac_text.append(f"  {check} {ac.get('text', '')}\n", style=style)
+
+        return Collapsible(
+            Static(ac_text),
+            title=f"Acceptance Criteria  {done_count}/{len(acs)}",
+        )
+
+    @staticmethod
+    def _build_workflow_section(workflow: str, phase: str) -> Collapsible:
+        """Build the Workflow collapsible section."""
+        wf_text = Text()
+        wf_text.append(f"  [{workflow}]", style="cyan")
+        if phase:
+            wf_text.append(f"  Phase: {phase}", style="yellow")
+
+        return Collapsible(Static(wf_text), title="Workflow")
+
+    @staticmethod
+    def _build_git_section(branch: str, pr_url: str | None) -> Collapsible:
+        """Build the Git collapsible section."""
+        git_text = Text()
+        if branch:
+            git_text.append(f"  Branch: {branch}\n")
+        if pr_url:
+            git_text.append(f"  PR: {pr_url}\n", style="cyan")
+
+        return Collapsible(Static(git_text), title="Git")
+
+    @staticmethod
+    def _build_context_section(
+        has_epic: bool, has_story: bool
+    ) -> Collapsible:
+        """Build the Context collapsible section."""
+        ctx_text = Text()
+        if has_epic:
+            ctx_text.append("  \u2713 Epic context\n", style="green")
+        else:
+            ctx_text.append("  \u25cb Epic context\n", style="dim")
+        if has_story:
+            ctx_text.append("  \u2713 Story context\n", style="green")
+        else:
+            ctx_text.append("  \u25cb Story context\n", style="dim")
+
+        return Collapsible(Static(ctx_text), title="Context")
+
+    @staticmethod
+    def _build_notes_section(notes: str) -> Collapsible:
+        """Build the Session Notes collapsible section."""
+        return Collapsible(Static(f"  {notes}"), title="Session Notes")