@pennyfarthing/core 11.3.3 → 11.3.4

package/pennyfarthing_scripts/theme/__main__.py

@@ -1,6 +0,0 @@
-"""Allow running as: python -m pennyfarthing_scripts.theme"""
-
-from pennyfarthing_scripts.theme.cli import theme
-
-if __name__ == "__main__":
-    theme()

package/pennyfarthing_scripts/theme/cli.py

@@ -1,310 +0,0 @@
-"""
-CLI commands for theme management.
-
-Usage:
-    pf theme list
-    pf theme show [NAME] [--full]
-    pf theme set <NAME>
-    pf theme create <NAME> [--base <THEME>] [--user]
-"""
-
-from __future__ import annotations
-
-import re
-
-import click
-
-
-@click.group()
-def theme():
-    """Persona theme management.
-
-    \b
-    Commands:
-      list    - Show all available themes
-      show    - Show theme details
-      set     - Set the active theme
-      create  - Create a new custom theme
-    """
-    pass
-
-
-@theme.command("list")
-def list_cmd():
-    """Show all available themes with current theme highlighted."""
-    from pennyfarthing_scripts.common.themes import format_theme_list
-
-    click.echo(format_theme_list())
-
-
-@theme.command("show")
-@click.argument("name", required=False)
-@click.option("--full", is_flag=True, help="Show full agent details (OCEAN, quirks, catchphrases, etc.)")
-def show(name: str | None, full: bool):
-    """Show theme details including agent character mappings.
-
-    \b
-    Arguments:
-      NAME  - Theme to show (defaults to current theme)
-    """
-    import yaml
-
-    from pennyfarthing_scripts.common.themes import (
-        get_current_theme,
-        list_themes,
-        resolve_theme_path,
-    )
-
-    theme_name = name
-    if not theme_name:
-        theme_name = get_current_theme()
-        if not theme_name:
-            click.echo("No theme currently set.")
-            click.echo("Use 'pf theme set <name>' to select a theme.")
-            return
-
-    theme_path = resolve_theme_path(theme_name)
-    if not theme_path:
-        available = ", ".join(list_themes()[:10])
-        raise click.ClickException(f"Theme '{theme_name}' not found.\nAvailable: {available}...")
-
-    data = yaml.safe_load(theme_path.read_text())
-    if not data:
-        raise click.ClickException(f"Invalid theme file: {theme_path}")
-
-    theme_meta = data.get("theme", {})
-    agents = data.get("agents", {})
-
-    # Header
-    click.echo(f"Theme: {theme_name}")
-    if theme_meta.get("description"):
-        click.echo(f"Description: {theme_meta['description']}")
-    if theme_meta.get("tier"):
-        click.echo(f"Tier: {theme_meta['tier']}")
-    click.echo()
-
-    # Agents
-    click.echo("Agents:")
-    agent_order = [
-        "sm", "tea", "dev", "reviewer", "orchestrator",
-        "pm", "architect", "devops", "tech-writer", "ux-designer",
-    ]
-
-    displayed: set[str] = set()
-    for agent_name in agent_order:
-        agent = agents.get(agent_name)
-        if agent and agent.get("character"):
-            _display_agent(agent_name, agent, full)
-            displayed.add(agent_name)
-
-    for agent_name, agent in agents.items():
-        if agent_name not in displayed and isinstance(agent, dict) and agent.get("character"):
-            _display_agent(agent_name, agent, full)
-
-
-def _display_agent(name: str, agent: dict, full: bool) -> None:
-    """Display a single agent's info."""
-    click.echo(f"  {name}:")
-    click.echo(f"    Character: {agent['character']}")
-    if agent.get("style"):
-        click.echo(f"    Style: {agent['style']}")
-
-    if not full:
-        return
-
-    if agent.get("ocean"):
-        ocean = agent["ocean"]
-        click.echo(
-            f"    OCEAN: O={ocean.get('O', '?')} C={ocean.get('C', '?')} "
-            f"E={ocean.get('E', '?')} A={ocean.get('A', '?')} N={ocean.get('N', '?')}"
-        )
-    if agent.get("trait"):
-        click.echo(f"    Trait: {agent['trait']}")
-    if agent.get("expertise"):
-        click.echo(f"    Expertise: {agent['expertise']}")
-    if agent.get("role"):
-        click.echo(f"    Role: {agent['role']}")
-    if agent.get("quirks"):
-        click.echo("    Quirks:")
-        for q in agent["quirks"]:
-            click.echo(f"      - {q}")
-    if agent.get("catchphrases"):
-        click.echo("    Catchphrases:")
-        for c in agent["catchphrases"]:
-            click.echo(f"      - {c}")
-    if agent.get("emoji"):
-        click.echo(f"    Emoji: {agent['emoji']}")
-    if agent.get("helper"):
-        helper = agent["helper"]
-        hname = helper.get("name", "?")
-        hstyle = helper.get("style", "?")
-        click.echo(f"    Helper: {hname} ({hstyle})")
-
-
-@theme.command("set")
-@click.argument("name")
-@click.option("--dry-run", is_flag=True, help="Show what would be done without making changes")
-def set_theme(name: str, dry_run: bool):
-    """Set the active persona theme.
-
-    \b
-    Arguments:
-      NAME  - Theme name to activate
-    """
-    import yaml
-
-    from pennyfarthing_scripts.common.config import get_project_root
-    from pennyfarthing_scripts.common.themes import (
-        list_themes,
-        resolve_theme_path,
-    )
-
-    theme_path = resolve_theme_path(name)
-    if not theme_path:
-        available = ", ".join(list_themes()[:10])
-        raise click.ClickException(f"Theme '{name}' not found.\nAvailable: {available}...")
-
-    theme_data = yaml.safe_load(theme_path.read_text())
-    theme_meta = theme_data.get("theme", {})
-    agents = theme_data.get("agents", {})
-
-    if dry_run:
-        click.echo(f"[DRY-RUN] Would set theme to '{name}'")
-        samples = []
-        for key in ["sm", "tea", "dev"]:
-            agent = agents.get(key)
-            if agent and agent.get("character"):
-                samples.append(f"{key.upper()}: {agent['character']}")
-        if samples:
-            click.echo(f"  {' | '.join(samples)}")
-        return
-
-    # Build theme_characters map (matches Node.js setTheme behavior)
-    theme_characters: dict[str, str] = {}
-    for agent_id, agent_info in agents.items():
-        if isinstance(agent_info, dict) and agent_info.get("character"):
-            theme_characters[agent_id] = agent_info["character"]
-
-    # Read existing config, preserve other fields
-    root = get_project_root()
-    config_path = root / ".pennyfarthing" / "config.local.yaml"
-
-    config: dict = {}
-    if config_path.exists():
-        try:
-            existing = yaml.safe_load(config_path.read_text())
-            if existing and isinstance(existing, dict):
-                config = existing
-        except Exception:
-            pass
-
-    config["theme"] = name
-    config["theme_characters"] = theme_characters
-
-    config_path.parent.mkdir(parents=True, exist_ok=True)
-    header = (
-        "# Pennyfarthing Local Configuration\n"
-        "# This file is gitignored - your personal preferences\n\n"
-    )
-    config_path.write_text(
-        header + yaml.dump(config, default_flow_style=False, sort_keys=False)
-    )
-
-    click.echo(f"Theme changed to '{name}'.")
-    click.echo()
-    click.echo(f"  {theme_meta.get('name', name)}")
-
-    samples = []
-    for key in ["sm", "tea", "dev"]:
-        agent = agents.get(key)
-        if agent and agent.get("character"):
-            samples.append(f"{key.upper()}: {agent['character']}")
-    if samples:
-        click.echo(f"  {' | '.join(samples)}")
-
-    click.echo()
-    click.echo("Start a new agent session to use the new theme.")
-
-
-@theme.command("create")
-@click.argument("name")
-@click.option("--base", default=None, help="Base theme to copy from (defaults to current theme)")
-@click.option("--user", is_flag=True, help="Create as user-level theme (~/.claude/pennyfarthing/themes/)")
-@click.option("--dry-run", is_flag=True, help="Show what would be done without making changes")
-def create(name: str, base: str | None, user: bool, dry_run: bool):
-    """Create a new custom theme from a base theme.
-
-    \b
-    Arguments:
-      NAME  - Name for the new theme (lowercase, hyphens allowed)
-    """
-    from pathlib import Path
-
-    import yaml
-
-    from pennyfarthing_scripts.common.config import get_project_root
-    from pennyfarthing_scripts.common.themes import (
-        get_current_theme,
-        list_themes,
-        resolve_theme_path,
-    )
-
-    if not base:
-        base = get_current_theme() or "blade-runner"
-
-    if name != name.lower():
-        raise click.ClickException("Theme name must be lowercase")
-    if " " in name:
-        raise click.ClickException("Theme name cannot contain spaces (use hyphens)")
-    if not re.match(r"^[a-z][a-z0-9-]*$", name):
-        raise click.ClickException(
-            "Theme name must start with a letter and contain only lowercase letters, numbers, and hyphens"
-        )
-
-    if name in list_themes():
-        raise click.ClickException(f"Theme '{name}' already exists")
-
-    base_path = resolve_theme_path(base)
-    if not base_path:
-        available = ", ".join(list_themes()[:10])
-        raise click.ClickException(f"Base theme '{base}' not found.\nAvailable: {available}...")
-
-    if dry_run:
-        if user:
-            target = Path.home() / ".claude" / "pennyfarthing" / "themes" / f"{name}.yaml"
-        else:
-            root = get_project_root()
-            target = root / ".claude" / "pennyfarthing" / "themes" / f"{name}.yaml"
-        click.echo(f"[DRY-RUN] Would create theme '{name}' based on '{base}'")
-        click.echo(f"  Target: {target}")
-        return
-
-    if user:
-        target_dir = Path.home() / ".claude" / "pennyfarthing" / "themes"
-    else:
-        root = get_project_root()
-        target_dir = root / ".claude" / "pennyfarthing" / "themes"
-
-    target_dir.mkdir(parents=True, exist_ok=True)
-    target_path = target_dir / f"{name}.yaml"
-
-    base_data = yaml.safe_load(base_path.read_text())
-    base_data["theme"]["name"] = name.replace("-", " ").title()
-    base_data["theme"]["description"] = f"Custom theme based on {base}"
-
-    file_header = (
-        f"# Custom Theme: {name}\n"
-        f"# Based on: {base}\n"
-        "# Edit this file to customize your agent personas\n\n"
-    )
-    target_path.write_text(
-        file_header + yaml.dump(base_data, default_flow_style=False, sort_keys=False)
-    )
-
-    click.echo(f"Created theme '{name}'.")
-    click.echo()
-    click.echo(f"  File: {target_path}")
-    click.echo()
-    click.echo("Next steps:")
-    click.echo("  1. Edit the theme file to customize your agents")
-    click.echo(f"  2. Run 'pf theme set {name}' to activate")

package/pennyfarthing_scripts/validate/adapters/agent.py

@@ -1,239 +0,0 @@
-"""Agent definition structural validator adapter.
-
-Validates agent definition files in pennyfarthing-dist/agents/.
-Checks required sections, model values, and subagent references.
-
-Story: MSSCI-14710 (91-12)
-"""
-
-from __future__ import annotations
-
-import re
-from pathlib import Path
-
-import yaml
-
-from pennyfarthing_scripts.validate import ValidateReport
-
-VALID_MODELS = {"haiku", "sonnet", "opus"}
-BUILTIN_AGENTS = {"Explore", "Plan"}
-
-# Regex to find XML-like tags in markdown: <tagname> or <tag-name>
-_TAG_RE = re.compile(r"<([a-zA-Z][a-zA-Z0-9_-]*)(?:\s[^>]*)?>", re.MULTILINE)
-
-# Regex to extract **Model:** value from helpers section
-_MODEL_RE = re.compile(r"\*\*Model:\*\*\s+(\S+)", re.IGNORECASE)
-
-# Regex to extract subagent names from markdown table rows: | `name` | purpose |
-_HELPER_TABLE_RE = re.compile(r"^\s*\|\s*`?([^`|]+)`?\s*\|", re.MULTILINE)
-
-
-def _has_frontmatter(content: str) -> bool:
-    """Check if content starts with YAML frontmatter (--- delimited)."""
-    return content.startswith("---\n")
-
-
-def _parse_frontmatter(content: str) -> dict:
-    """Extract YAML frontmatter from content."""
-    if not _has_frontmatter(content):
-        return {}
-    end = content.find("\n---", 3)
-    if end == -1:
-        return {}
-    fm_text = content[4:end]
-    try:
-        return yaml.safe_load(fm_text) or {}
-    except yaml.YAMLError:
-        return {}
-
-
-def _find_tags(content: str) -> set[str]:
-    """Find all XML-like tag names in content."""
-    return {m.group(1) for m in _TAG_RE.finditer(content)}
-
-
-def _extract_section(content: str, tag: str) -> str | None:
-    """Extract content between <tag> and </tag>."""
-    pattern = re.compile(rf"<{re.escape(tag)}[^>]*>(.*?)</{re.escape(tag)}>", re.DOTALL)
-    m = pattern.search(content)
-    return m.group(1) if m else None
-
-
-def classify_agent_files(
-    agents_dir: Path,
-) -> tuple[list[Path], list[Path], list[Path]]:
-    """Classify agent files into main agents, subagents, and skipped.
-
-    Returns:
-        (main_agents, subagents, skipped) — three lists of Path objects.
-    """
-    main: list[Path] = []
-    sub: list[Path] = []
-    skipped: list[Path] = []
-
-    for f in sorted(agents_dir.glob("*.md")):
-        if f.name == "README.md":
-            skipped.append(f)
-            continue
-
-        content = f.read_text()
-        if _has_frontmatter(content):
-            sub.append(f)
-        else:
-            main.append(f)
-
-    return main, sub, skipped
-
-
-def validate_main_agent(
-    path: Path, agents_dir: Path
-) -> tuple[list[str], list[str]]:
-    """Validate a main agent definition file.
-
-    Returns:
-        (errors, warnings) — two lists of message strings.
-    """
-    errors: list[str] = []
-    warnings: list[str] = []
-    content = path.read_text()
-    tags = _find_tags(content)
-
-    # Required sections
-    if "role" not in tags:
-        errors.append("Missing required <role> section")
-    if "critical" not in tags:
-        errors.append("Missing required <critical> section")
-    if "helpers" not in tags:
-        errors.append("Missing required <helpers> section")
-    if "skills" not in tags:
-        errors.append("Missing required <skills> section")
-
-    # Model validation (only if helpers exists)
-    if "helpers" in tags:
-        helpers_content = _extract_section(content, "helpers")
-        if helpers_content:
-            model_match = _MODEL_RE.search(helpers_content)
-            if model_match:
-                model_val = model_match.group(1).lower()
-                if model_val not in VALID_MODELS:
-                    errors.append(
-                        f"Invalid model '{model_match.group(1)}' in <helpers> "
-                        f"(must be one of: {', '.join(sorted(VALID_MODELS))})"
-                    )
-
-            # Subagent reference validation
-            existing_files = {f.stem for f in agents_dir.glob("*.md") if f.name != "README.md"}
-            # Parse table rows — skip header/separator rows
-            for line in helpers_content.splitlines():
-                m = _HELPER_TABLE_RE.match(line)
-                if not m:
-                    continue
-                name = m.group(1).strip().strip("`")
-                # Skip table header and separator
-                if name.lower() in ("subagent", "---", "") or name.startswith("-"):
-                    continue
-                if name in BUILTIN_AGENTS:
-                    continue
-                if name not in existing_files:
-                    warnings.append(
-                        f"Helper references '{name}' but no matching agent file not found in agents/"
-                    )
-
-    # Recommended sections (warnings)
-    if "on-activation" not in tags:
-        warnings.append("Missing recommended <on-activation> section")
-    if "exit" not in tags and "exit-sequence" not in tags:
-        warnings.append("Missing recommended <exit> or <exit-sequence> section")
-
-    return errors, warnings
-
-
-def validate_subagent(path: Path) -> tuple[list[str], list[str]]:
-    """Validate a subagent definition file.
-
-    Returns:
-        (errors, warnings) — two lists of message strings.
-    """
-    errors: list[str] = []
-    warnings: list[str] = []
-    content = path.read_text()
-
-    # Frontmatter validation
-    fm = _parse_frontmatter(content)
-    if not fm:
-        errors.append("Missing or invalid YAML frontmatter")
-        return errors, warnings
-
-    for field in ("name", "description", "tools", "model"):
-        if field not in fm:
-            errors.append(f"Missing required frontmatter field: {field}")
-
-    # Model must be haiku for subagents
-    if "model" in fm:
-        model_val = str(fm["model"]).lower()
-        if model_val != "haiku":
-            errors.append(
-                f"Subagent model must be 'haiku', got '{fm['model']}'"
-            )
-
-    # Required tags
-    tags = _find_tags(content)
-    if "output" not in tags:
-        errors.append("Missing required <output> section")
-
-    # Recommended tags
-    if "arguments" not in tags:
-        warnings.append("Missing recommended <arguments> section")
-
-    return errors, warnings
-
-
-def run(root: Path, *, fix: bool = False, strict: bool = False) -> ValidateReport:
-    """Validate all agent definition files."""
-    report = ValidateReport(validator="agent")
-    agents_dir = root / "pennyfarthing-dist" / "agents"
-
-    if not agents_dir.is_dir():
-        report.details.append("[ERROR] agents directory not found")
-        report.errors += 1
-        return report
-
-    main_agents, subagents, _skipped = classify_agent_files(agents_dir)
-
-    for path in main_agents:
-        file_errors, file_warnings = validate_main_agent(path, agents_dir)
-
-        for e in file_errors:
-            report.errors += 1
-            report.details.append(f"[ERROR] {path.name}: {e}")
-
-        for w in file_warnings:
-            if strict:
-                report.errors += 1
-                report.details.append(f"[ERROR] {path.name}: {w}")
-            else:
-                report.warnings += 1
-                report.details.append(f"[WARN] {path.name}: {w}")
-
-        if not file_errors:
-            report.passed += 1
-
-    for path in subagents:
-        file_errors, file_warnings = validate_subagent(path)
-
-        for e in file_errors:
-            report.errors += 1
-            report.details.append(f"[ERROR] {path.name}: {e}")
-
-        for w in file_warnings:
-            if strict:
-                report.errors += 1
-                report.details.append(f"[ERROR] {path.name}: {w}")
-            else:
-                report.warnings += 1
-                report.details.append(f"[WARN] {path.name}: {w}")
-
-        if not file_errors:
-            report.passed += 1
-
-    return report

package/pennyfarthing_scripts/validate/adapters/schema.py

@@ -1,30 +0,0 @@
-"""XML schema validator adapter.
-
-Delegates to migration/validate.validate_all() for session, skill, and workflow step files.
-"""
-
-from __future__ import annotations
-
-from pathlib import Path
-
-from pennyfarthing_scripts.validate import ValidateReport
-
-
-def run(root: Path, *, fix: bool = False, strict: bool = False) -> ValidateReport:
-    """Validate XML schema files (sessions, skills, workflow steps)."""
-    from pennyfarthing_scripts.migration.validate import validate_all
-
-    summary = validate_all(root, file_type="all", strict=strict)
-
-    report = ValidateReport(validator="schema")
-    report.passed = summary.passed
-    report.warnings = summary.warnings
-    report.errors = summary.errors
-
-    for result in summary.results:
-        for e in result.errors:
-            report.details.append(f"[ERROR] {result.file_path.name}: {e}")
-        for w in result.warnings:
-            report.details.append(f"[WARN] {result.file_path.name}: {w}")
-
-    return report