@pennyfarthing/core 11.3.2 → 11.3.4

package/pennyfarthing_scripts/tests/test_108_2_remove_handoff_fallback.py

@@ -1,339 +0,0 @@
-"""Tests for removing handoff subagents and inline fallback — Story 108-2.
-
-Epic: 108 (Full Migration & Cleanup)
-Story: 108-2 — Remove handoff subagents and inline fallback
-
-Tests the removal of deprecated handoff subagents and the gate.type
-fallback code path, leaving only gate.file-based resolution.
-
-Acceptance Criteria:
-- [AC1] pennyfarthing-dist/agents/handoff.md deleted
-- [AC2] pennyfarthing-dist/agents/sm-handoff.md deleted
-- [AC3] gate.type fallback removed from resolve-gate — file-only gates resolved
-- [AC4] checkGate() in Cyclist updated or removed (see TS test)
-- [AC5] No remaining references to handoff/sm-handoff subagents in agent files
-- [AC6] All existing tests pass
-- [AC7] Single code path: all gated phases in phased workflows have gate.file
-"""
-
-from __future__ import annotations
-
-import re
-import textwrap
-from pathlib import Path
-
-import pytest
-import yaml
-
-from pennyfarthing_scripts.handoff.resolve_gate import resolve_gate
-
-# ---------------------------------------------------------------------------
-# Paths
-# ---------------------------------------------------------------------------
-
-DIST_DIR = Path(__file__).resolve().parents[2] / "pennyfarthing-dist"
-AGENTS_DIR = DIST_DIR / "agents"
-WORKFLOWS_DIR = DIST_DIR / "workflows"
-GATES_DIR = DIST_DIR / "gates"
-
-# ---------------------------------------------------------------------------
-# Fixtures
-# ---------------------------------------------------------------------------
-
-SESSION_WITH_ASSESSMENT = textwrap.dedent("""\
-    # Story 108-2: Remove handoff subagents and inline fallback
-
-    **Story ID:** 108-2
-    **Workflow:** tdd
-    **Phase:** green
-    **Phase Started:** 2026-02-15T10:00:00Z
-
-    ## TEA Assessment
-
-    **Tests Written:** 5 tests
-    **Status:** RED confirmed
-""")
-
-SESSION_WITHOUT_ASSESSMENT = textwrap.dedent("""\
-    # Story 108-2: Remove handoff subagents and inline fallback
-
-    **Story ID:** 108-2
-    **Workflow:** tdd
-    **Phase:** green
-    **Phase Started:** 2026-02-15T10:00:00Z
-""")
-
-WORKFLOW_FILE_ONLY_GATE = {
-    "workflow": {
-        "name": "file-only-test",
-        "phases": [
-            {"name": "setup", "agent": "sm"},
-            {
-                "name": "green",
-                "agent": "dev",
-                "gate": {
-                    "file": "gates/tests-pass",
-                    "condition": "All tests passing",
-                },
-            },
-            {"name": "finish", "agent": "sm"},
-        ],
-    }
-}
-
-
-@pytest.fixture
-def project(tmp_path: Path) -> Path:
-    """Create a minimal project with workflow YAMLs and session."""
-    workflows_dir = tmp_path / ".pennyfarthing" / "workflows"
-    workflows_dir.mkdir(parents=True)
-    (tmp_path / ".session").mkdir()
-
-    # Write the file-only-gate workflow
-    (workflows_dir / "file-only-test.yaml").write_text(
-        yaml.dump(WORKFLOW_FILE_ONLY_GATE, default_flow_style=False)
-    )
-
-    # Copy real tdd.yaml for integration tests
-    tdd_src = WORKFLOWS_DIR / "tdd.yaml"
-    if tdd_src.exists():
-        (workflows_dir / "tdd.yaml").write_text(tdd_src.read_text())
-
-    return tmp_path
-
-
-# ===========================================================================
-# AC1: pennyfarthing-dist/agents/handoff.md deleted
-# ===========================================================================
-
-
-class TestHandoffMdDeleted:
-    """AC1: handoff.md must not exist in pennyfarthing-dist/agents/."""
-
-    def test_handoff_md_does_not_exist(self) -> None:
-        """AC1: handoff.md should be deleted from agents directory."""
-        assert not (AGENTS_DIR / "handoff.md").exists(), (
-            "handoff.md still exists — should be deleted in 108-2"
-        )
-
-
-# ===========================================================================
-# AC2: pennyfarthing-dist/agents/sm-handoff.md deleted
-# ===========================================================================
-
-
-class TestSmHandoffMdDeleted:
-    """AC2: sm-handoff.md must not exist in pennyfarthing-dist/agents/."""
-
-    def test_sm_handoff_md_does_not_exist(self) -> None:
-        """AC2: sm-handoff.md should be deleted from agents directory."""
-        assert not (AGENTS_DIR / "sm-handoff.md").exists(), (
-            "sm-handoff.md still exists — should be deleted in 108-2"
-        )
-
-
-# ===========================================================================
-# AC3: gate.type fallback removed — file-only gates resolve properly
-# ===========================================================================
-
-
-class TestGateTypeFallbackRemoved:
-    """AC3: gate with file but no type should resolve via assessment, not skip."""
-
-    def test_no_gate_at_all_still_returns_skip(
-        self, project: Path
-    ) -> None:
-        """AC3: Phase with no gate (setup/finish) should still return 'skip'."""
-        session = project / ".session" / "108-2-session.md"
-        session.write_text(SESSION_WITH_ASSESSMENT)
-
-        result = resolve_gate(
-            "108-2", "tdd", "setup", project_root=project
-        )
-        assert result["status"] == "skip", (
-            f"No-gate phase should skip, got: {result['status']}"
-        )
-
-    def test_gate_file_only_returns_ready_with_assessment(
-        self, project: Path
-    ) -> None:
-        """AC3: gate with file but no type + assessment → 'ready' (not 'skip').
-
-        Before 108-2: gate_type is None → skip (fallback).
-        After 108-2: gate.file present → check assessment → ready.
-        """
-        session = project / ".session" / "108-2-session.md"
-        session.write_text(SESSION_WITH_ASSESSMENT)
-
-        result = resolve_gate(
-            "108-2", "file-only-test", "green", project_root=project
-        )
-        assert result["status"] == "ready", (
-            f"File-only gate with assessment should be 'ready', got: "
-            f"'{result['status']}' — gate.type fallback still active?"
-        )
-
-    def test_gate_file_only_returns_blocked_without_assessment(
-        self, project: Path
-    ) -> None:
-        """AC3: gate with file but no type + NO assessment → 'blocked'.
-
-        Before 108-2: gate_type is None → skip (ignores missing assessment).
-        After 108-2: gate.file present → check assessment → blocked.
-        """
-        session = project / ".session" / "108-2-session.md"
-        session.write_text(SESSION_WITHOUT_ASSESSMENT)
-
-        result = resolve_gate(
-            "108-2", "file-only-test", "green", project_root=project
-        )
-        assert result["status"] == "blocked", (
-            f"File-only gate without assessment should be 'blocked', got: "
-            f"'{result['status']}' — gate.type fallback still active?"
-        )
-
-    def test_gate_file_only_populates_gate_file_field(
-        self, project: Path
-    ) -> None:
-        """AC3: gate_file field should be populated for file-only gates."""
-        session = project / ".session" / "108-2-session.md"
-        session.write_text(SESSION_WITH_ASSESSMENT)
-
-        result = resolve_gate(
-            "108-2", "file-only-test", "green", project_root=project
-        )
-        assert result["gate_file"] == "gates/tests-pass", (
-            f"Expected gate_file='gates/tests-pass', got: {result['gate_file']}"
-        )
-
-    def test_gate_with_both_file_and_type_still_ready(
-        self, project: Path
-    ) -> None:
-        """AC3: gate with both file and type should still return 'ready'."""
-        session = project / ".session" / "108-2-session.md"
-        session.write_text(SESSION_WITH_ASSESSMENT)
-
-        result = resolve_gate(
-            "108-2", "tdd", "green", project_root=project
-        )
-        assert result["status"] == "ready"
-        assert result["gate_file"] == "gates/tests-pass"
-        assert result["gate_type"] == "tests_pass"
-
-
-# ===========================================================================
-# AC5: No remaining references to handoff/sm-handoff subagents
-# ===========================================================================
-
-
-class TestNoSubagentReferences:
-    """AC5: No agent files should reference the deleted subagents."""
-
-    def _scan_agent_files(self, pattern: str) -> list[tuple[str, str]]:
-        """Scan all agent .md files for a regex pattern. Returns (file, line) pairs."""
-        hits = []
-        for md_file in AGENTS_DIR.glob("*.md"):
-            # Skip the files being deleted (they'll be gone)
-            if md_file.name in ("handoff.md", "sm-handoff.md"):
-                continue
-            content = md_file.read_text()
-            for line in content.splitlines():
-                if re.search(pattern, line, re.IGNORECASE):
-                    hits.append((md_file.name, line.strip()))
-        return hits
-
-    def test_no_agent_references_handoff_subagent(self) -> None:
-        """AC5: No agent .md files should spawn or reference 'handoff' subagent.
-
-        Matches patterns like:
-        - subagent_type: handoff
-        - spawn handoff
-        - sm-handoff subagent
-        But NOT: 'pf handoff' (the CLI) or 'handoff.ts' (the module)
-        """
-        # Look for subagent spawn references to the deprecated handoff subagent
-        hits = self._scan_agent_files(
-            r'(?:subagent.*handoff\.md|sm-handoff\.md|"sm-handoff"|"handoff"'
-            r"|handoff subagent|sm-handoff subagent)"
-        )
-        assert len(hits) == 0, (
-            f"Found {len(hits)} references to deprecated handoff subagents:\n"
-            + "\n".join(f"  {f}: {line}" for f, line in hits)
-        )
-
-    def test_agents_readme_no_deprecated_entries(self) -> None:
-        """AC5: README.md should not list handoff.md or sm-handoff.md."""
-        readme = AGENTS_DIR / "README.md"
-        if not readme.exists():
-            pytest.skip("No agents README.md")
-
-        content = readme.read_text()
-        # Should not have the deprecated entries
-        assert "handoff.md" not in content, (
-            "README.md still references handoff.md"
-        )
-        assert "sm-handoff.md" not in content, (
-            "README.md still references sm-handoff.md"
-        )
-
-
-# ===========================================================================
-# AC7: Single code path — all gated phases have gate.file
-# ===========================================================================
-
-# Phased workflows that should have gate.file on every gated phase
-PHASED_WORKFLOWS = ["tdd", "trivial", "bdd", "bdd-tandem", "tdd-tandem",
-                     "2party-tdd", "agent-docs", "patch"]
-
-
-class TestAllGatedPhasesHaveGateFile:
-    """AC7: Every gated phase in phased workflows must have gate.file."""
-
-    def _load_workflow(self, name: str) -> dict | None:
-        """Load a workflow YAML, return None if not found."""
-        path = WORKFLOWS_DIR / f"{name}.yaml"
-        if not path.exists():
-            return None
-        return yaml.safe_load(path.read_text())
-
-    def _gated_phases_missing_file(
-        self, workflow_data: dict
-    ) -> list[tuple[str, str]]:
-        """Find phases that have a gate but no gate.file.
-
-        Returns list of (phase_name, gate_type) tuples.
-        Manual gates are excluded — they skip resolution entirely.
-        """
-        missing = []
-        for phase in workflow_data["workflow"]["phases"]:
-            gate = phase.get("gate")
-            if not gate:
-                continue  # No gate at all — fine (setup, finish)
-            gate_type = gate.get("type")
-            if gate_type == "manual":
-                continue  # Manual gates always skip
-            if not gate.get("file"):
-                missing.append((phase["name"], gate_type or "(no type)"))
-        return missing
-
-    @pytest.mark.parametrize("workflow_name", PHASED_WORKFLOWS)
-    def test_workflow_gated_phases_have_gate_file(
-        self, workflow_name: str
-    ) -> None:
-        """AC7: Every non-manual gated phase must have gate.file defined.
-
-        This ensures the single code path — resolve-gate only needs
-        gate.file, not gate.type, for resolution.
-        """
-        wf = self._load_workflow(workflow_name)
-        if wf is None:
-            pytest.skip(f"Workflow {workflow_name} not found")
-
-        missing = self._gated_phases_missing_file(wf)
-        assert len(missing) == 0, (
-            f"Workflow '{workflow_name}' has gated phases without gate.file:\n"
-            + "\n".join(
-                f"  - {name} (type={gtype})" for name, gtype in missing
-            )
-            + "\nAll gated phases must have gate.file for single code path."
-        )

package/pennyfarthing_scripts/tests/test_archive_epic.py

@@ -1,185 +0,0 @@
-"""Tests for epic archiving — completed stories written to sprint completed file.
-
-Story: 91-29 - Bug: archive_epic does not populate completed_stories
-"""
-
-from pathlib import Path
-from typing import Any
-
-import pytest
-
-from pennyfarthing_scripts.sprint.archive_epic import (
-    _load_archive_file,
-    _write_archive_file,
-    archive_epic,
-    is_epic_complete,
-)
-from pennyfarthing_scripts.sprint.yaml_io import _make_yaml, _write_yaml_file
-
-
-@pytest.fixture
-def sprint_tree(tmp_path: Path) -> Path:
-    """Create a minimal sprint directory structure with one completed epic."""
-    sprint_dir = tmp_path / "sprint"
-    sprint_dir.mkdir()
-    (sprint_dir / "archive").mkdir()
-    (sprint_dir / "context").mkdir()
-
-    # current-sprint.yaml index referencing one epic
-    _make_yaml()
-    index = {
-        "sprint": {
-            "name": "TO Sprint 2699",
-            "number": 2699,
-            "jira_sprint_id": 999,
-            "jira_sprint_name": "TO Sprint 2699",
-            "goal": "Test sprint",
-            "start_date": "2026-02-01",
-            "end_date": "2026-02-15",
-            "status": "active",
-        },
-        "epics": ["MSSCI-99999"],
-        "stories": [],
-    }
-    sprint_path = sprint_dir / "current-sprint.yaml"
-    _write_yaml_file(sprint_path, index)
-
-    # Epic shard with 3 completed stories
-    epic_data: dict[str, Any] = {
-        "id": "epic-50",
-        "type": "epic",
-        "title": "Test Epic",
-        "status": "backlog",
-        "jira": "MSSCI-99999",
-        "stories": [
-            {
-                "id": "50-1",
-                "jira": "MSSCI-99901",
-                "title": "First story",
-                "points": 2,
-                "status": "done",
-                "completed": "2026-02-10",
-            },
-            {
-                "id": "50-2",
-                "jira": "MSSCI-99902",
-                "title": "Second story",
-                "points": 3,
-                "status": "done",
-                "completed": "2026-02-11",
-            },
-            {
-                "id": "50-3",
-                "jira": "MSSCI-99903",
-                "title": "Third story",
-                "points": 1,
-                "status": "done",
-                "completed": "2026-02-12",
-            },
-        ],
-    }
-    _write_yaml_file(sprint_dir / "epic-MSSCI-99999.yaml", epic_data)
-
-    # Pre-create the completed file (ensure_archive_file needs load_sprint
-    # which needs project root detection — easier to pre-create)
-    completed = {
-        "sprint": index["sprint"],
-        "completed_epics": [],
-        "completed_stories": [],
-    }
-    _write_archive_file(sprint_dir / "archive" / "sprint-2699-completed.yaml", completed)
-
-    return tmp_path
-
-
-def test_archive_epic_writes_completed_stories(sprint_tree: Path) -> None:
-    """Archiving an epic should write all its stories to completed_stories."""
-    result = archive_epic("epic-50", project_root=sprint_tree)
-
-    assert result["success"] is True
-    assert result["stories_archived"] == 3
-    assert result["total_points"] == 6
-
-    # Load the completed file and verify stories were written
-    archive_path = sprint_tree / "sprint" / "archive" / "sprint-2699-completed.yaml"
-    archive_data = _load_archive_file(archive_path)
-
-    assert "MSSCI-99999" in archive_data["completed_epics"]
-
-    story_ids = [s["id"] for s in archive_data["completed_stories"]]
-    assert "50-1" in story_ids
-    assert "50-2" in story_ids
-    assert "50-3" in story_ids
-
-    # Verify story fields
-    story_1 = next(s for s in archive_data["completed_stories"] if s["id"] == "50-1")
-    assert story_1["epic"] == "MSSCI-99999"
-    assert story_1["title"] == "First story"
-    assert story_1["points"] == 2
-    assert story_1["completed"] == "2026-02-10"
-
-
-def test_archive_epic_no_duplicate_stories(sprint_tree: Path) -> None:
-    """If stories already exist in completed_stories, don't duplicate them."""
-    # Pre-populate one story
-    archive_path = sprint_tree / "sprint" / "archive" / "sprint-2699-completed.yaml"
-    archive_data = _load_archive_file(archive_path)
-    archive_data["completed_stories"].append({
-        "id": "50-1",
-        "epic": "MSSCI-99999",
-        "title": "First story",
-        "points": 2,
-        "completed": "2026-02-10",
-    })
-    _write_archive_file(archive_path, archive_data)
-
-    # Now archive the epic
-    result = archive_epic("epic-50", project_root=sprint_tree)
-    assert result["success"] is True
-
-    # Reload and check — 50-1 should appear only once
-    archive_data = _load_archive_file(archive_path)
-    story_ids = [s["id"] for s in archive_data["completed_stories"]]
-    assert story_ids.count("50-1") == 1
-    assert len(story_ids) == 3  # 50-1, 50-2, 50-3
-
-
-def test_is_epic_complete_all_done() -> None:
-    """Epic with all stories done should be complete."""
-    epic = {
-        "status": "backlog",
-        "stories": [
-            {"id": "1-1", "status": "done"},
-            {"id": "1-2", "status": "done"},
-        ],
-    }
-    complete, incomplete = is_epic_complete(epic)
-    assert complete is True
-    assert incomplete == []
-
-
-def test_is_epic_complete_with_canceled() -> None:
-    """Canceled stories count as complete."""
-    epic = {
-        "status": "backlog",
-        "stories": [
-            {"id": "1-1", "status": "done"},
-            {"id": "1-2", "status": "canceled"},
-        ],
-    }
-    complete, incomplete = is_epic_complete(epic)
-    assert complete is True
-
-
-def test_is_epic_complete_with_remaining() -> None:
-    """Epic with in_progress stories is not complete."""
-    epic = {
-        "status": "backlog",
-        "stories": [
-            {"id": "1-1", "status": "done"},
-            {"id": "1-2", "status": "in_progress"},
-        ],
-    }
-    complete, incomplete = is_epic_complete(epic)
-    assert complete is False
-    assert "1-2" in incomplete