@pennyfarthing/core 11.1.1 → 11.2.1

package/pennyfarthing_scripts/workflow/team_lifecycle.py

@@ -0,0 +1,257 @@
+"""
+Phase-scoped Team Lifecycle for Story 86-10.
+
+Manages the lifecycle of native Agent Teams within workflow phases.
+When a workflow phase has a `team:` config block, the lead agent creates
+a team at phase start, spawns teammates, and cleans up before handoff.
+
+Python port of packages/core/dist/workflow/team-lifecycle.js.
+"""
+
+from __future__ import annotations
+
+from datetime import datetime, timezone
+from pathlib import Path
+from typing import Any
+
+
+# =============================================================================
+# In-memory registries
+# =============================================================================
+
+_active_teams: dict[str, dict[str, Any]] = {}
+"""Active teams keyed by story_id."""
+
+_sidecar_locks: dict[str, dict[str, Any]] = {}
+"""Sidecar locks keyed by file path."""
+
+
+def _reset_for_testing() -> None:
+    """Reset all in-memory state. For testing only."""
+    _active_teams.clear()
+    _sidecar_locks.clear()
+
+
+async def create_team(
+    phase: dict[str, Any],
+    story_id: str,
+    adapter: Any | None = None,
+) -> dict[str, Any]:
+    """Create a phase-scoped team.
+
+    If phase has no team config, returns success with no handle (no-op).
+    If phase has team config, creates team and returns handle.
+    """
+    if not phase.get("team"):
+        return {"success": True}
+
+    team_name = f"{story_id}-{phase['name']}"
+
+    # Clean up existing team for same story
+    existing = _active_teams.get(story_id)
+    if existing and adapter:
+        try:
+            await adapter.delete_team(existing["teamName"])
+        except Exception:
+            pass
+        del _active_teams[story_id]
+
+    handle: dict[str, Any] = {
+        "teamName": team_name,
+        "storyId": story_id,
+        "phase": phase["name"],
+        "teammates": [],
+        "createdAt": datetime.now(timezone.utc).isoformat(),
+    }
+
+    if adapter:
+        try:
+            await adapter.create_team({"teamName": team_name})
+        except Exception as exc:
+            return {"success": False, "error": str(exc)}
+
+    _active_teams[story_id] = handle
+    return {"success": True, "data": handle}
+
+
+async def spawn_teammates(
+    handle: dict[str, Any],
+    config: dict[str, Any],
+    story_id: str,
+    phase: dict[str, Any],
+    adapter: Any | None = None,
+) -> dict[str, Any]:
+    """Spawn all teammates for a team based on workflow YAML config."""
+    teammates: list[dict[str, Any]] = []
+
+    for member in config["teammates"]:
+        teammate: dict[str, Any] = {
+            "agent": member["agent"],
+            "task": member["task"],
+            "status": "spawned",
+        }
+        if adapter:
+            try:
+                await adapter.spawn_teammate({
+                    "teamName": handle["teamName"],
+                    "agent": member["agent"],
+                    "prompt": f'pf agent start "{member["agent"]}"',
+                    "model": config.get("model"),
+                })
+            except Exception:
+                teammate["status"] = "crashed"
+        teammates.append(teammate)
+
+    handle["teammates"] = teammates
+
+    # Update registry
+    if handle.get("storyId") in _active_teams:
+        _active_teams[handle["storyId"]] = handle
+
+    return {"success": True, "data": teammates}
+
+
+async def shutdown_all_teammates(
+    handle: dict[str, Any],
+    adapter: Any | None = None,
+) -> dict[str, Any]:
+    """Shut down all active teammates in a team."""
+    shutdown_count = 0
+
+    for teammate in handle["teammates"]:
+        if teammate["status"] in ("shutdown", "crashed"):
+            continue
+        if adapter:
+            try:
+                await adapter.shutdown_teammate({
+                    "teamName": handle["teamName"],
+                    "agent": teammate["agent"],
+                })
+            except Exception:
+                pass  # Graceful degradation — swallow adapter errors
+        teammate["status"] = "shutdown"
+        shutdown_count += 1
+
+    return {"success": True, "data": {"shutdownCount": shutdown_count}}
+
+
+async def cleanup_team(
+    handle: dict[str, Any],
+    adapter: Any | None = None,
+) -> dict[str, Any]:
+    """Clean up a team entirely (TeamDelete). Must run before pf handoff."""
+    if adapter:
+        try:
+            await adapter.delete_team(handle["teamName"])
+        except Exception:
+            pass
+
+    _active_teams.pop(handle.get("storyId", ""), None)
+    return {"success": True, "data": {"cleaned": True}}
+
+
+def check_gate_on_task_completed(
+    handle: dict[str, Any],
+    phase: dict[str, Any],
+) -> dict[str, Any]:
+    """Check gate condition when a TaskCompleted event fires."""
+    if not phase.get("gate"):
+        return {"passed": True, "gate": "none"}
+
+    gate_type = phase["gate"].get("type", "unknown")
+    has_active = any(t["status"] == "active" for t in handle["teammates"])
+
+    if has_active:
+        return {"passed": False, "gate": gate_type, "reason": "Teammates still active"}
+
+    return {"passed": True, "gate": gate_type}
+
+
+def check_gate_on_teammate_idle(
+    handle: dict[str, Any],
+    teammate: dict[str, Any],
+    phase: dict[str, Any],
+) -> dict[str, Any]:
+    """Check gate condition when a TeammateIdle event fires."""
+    if not phase.get("gate"):
+        return {"passed": True, "gate": "none"}
+
+    gate_type = phase["gate"].get("type", "unknown")
+
+    if teammate["status"] == "crashed":
+        return {"passed": False, "gate": gate_type, "reason": "Teammate crashed"}
+
+    return {"passed": True, "gate": gate_type}
+
+
+def generate_team_summary(handle: dict[str, Any]) -> dict[str, Any]:
+    """Generate a team activity summary for the session file audit trail."""
+    return {
+        "teamName": handle["teamName"],
+        "storyId": handle["storyId"],
+        "phase": handle["phase"],
+        "members": [
+            {"agent": t["agent"], "status": t["status"], "task": t["task"]}
+            for t in handle["teammates"]
+        ],
+        "cleanShutdown": all(t["status"] == "shutdown" for t in handle["teammates"]),
+    }
+
+
+def acquire_sidecar_lock(
+    file_path: str,
+    story_id: str,
+    timeout: int = 5000,
+) -> dict[str, Any]:
+    """Acquire an exclusive lock for sidecar file writing."""
+    existing = _sidecar_locks.get(file_path)
+    if existing:
+        if existing["storyId"] == story_id:
+            return {"success": True, "data": existing}
+        return {"success": False, "error": f"Lock held by story {existing['storyId']}"}
+
+    lock: dict[str, Any] = {
+        "lockPath": f"{file_path}.lock",
+        "storyId": story_id,
+        "acquiredAt": datetime.now(timezone.utc).isoformat(),
+    }
+    _sidecar_locks[file_path] = lock
+    return {"success": True, "data": lock}
+
+
+def release_sidecar_lock(lock: dict[str, Any]) -> dict[str, Any]:
+    """Release a sidecar file lock."""
+    for path, held in list(_sidecar_locks.items()):
+        if held["lockPath"] == lock["lockPath"]:
+            del _sidecar_locks[path]
+            break
+    return {"success": True}
+
+
+def get_active_team(story_id: str) -> dict[str, Any] | None:
+    """Get the active team for a story, if any."""
+    return _active_teams.get(story_id)
+
+
+def update_session_with_summary(
+    session_path: str | Path,
+    summary: dict[str, Any],
+) -> dict[str, Any]:
+    """Write team activity summary to session file for audit trail."""
+    path = Path(session_path)
+    content = path.read_text() if path.exists() else ""
+
+    lines = [
+        "\n## Team Activity Summary\n",
+        f"**Team:** {summary['teamName']}",
+        f"**Phase:** {summary['phase']}",
+        f"**Clean Shutdown:** {'Yes' if summary.get('cleanShutdown') else 'No'}\n",
+        "| Agent | Status | Task |",
+        "|-------|--------|------|",
+    ]
+    for member in summary.get("members", []):
+        lines.append(f"| {member['agent']} | {member['status']} | {member['task']} |")
+
+    content += "\n".join(lines) + "\n"
+    path.write_text(content)
+    return {"success": True}

package/packages/core/dist/scripts/theme-detail.test.d.ts

@@ -1,10 +0,0 @@
-/**
- * Story 13-5: Theme Detail Page Tests
- *
- * Tests for the theme detail page with team spider chart,
- * agent grid with ProfileCards, and profile links.
- *
- * Run with: npm test
- */
-export {};
-//# sourceMappingURL=theme-detail.test.d.ts.map

package/packages/core/dist/scripts/theme-detail.test.js

@@ -1,199 +0,0 @@
-/**
- * Story 13-5: Theme Detail Page Tests
- *
- * Tests for the theme detail page with team spider chart,
- * agent grid with ProfileCards, and profile links.
- *
- * Run with: npm test
- */
-import { describe, it } from 'node:test';
-import assert from 'node:assert';
-import { existsSync, readFileSync } from 'fs';
-import { join, dirname } from 'path';
-import { fileURLToPath } from 'url';
-import { findMonorepoRoot } from '../cli/utils/files.js';
-const __filename = fileURLToPath(import.meta.url);
-const __dirname = dirname(__filename);
-// Find monorepo root by walking up from current directory
-const projectRoot = findMonorepoRoot(__dirname);
-const PAGES_DIR = join(projectRoot, 'internal', 'showcase', 'src', 'pages');
-const COMPONENTS_DIR = join(projectRoot, 'internal', 'showcase', 'src', 'components');
-describe('Story 13-5: Theme Detail Page', () => {
-    describe('AC1: Theme detail pages generated for all themes', () => {
-        it('should have dynamic [theme].astro route', () => {
-            const pagePath = join(PAGES_DIR, 'themes', '[theme].astro');
-            assert.ok(existsSync(pagePath), 'Dynamic theme page should exist');
-        });
-        it('should use getStaticPaths for dynamic routing', () => {
-            const pagePath = join(PAGES_DIR, 'themes', '[theme].astro');
-            assert.ok(existsSync(pagePath), 'Page file should exist');
-            const content = readFileSync(pagePath, 'utf-8');
-            assert.match(content, /getStaticPaths/, 'Should use getStaticPaths');
-        });
-        it('should import loadThemes for generating paths', () => {
-            const pagePath = join(PAGES_DIR, 'themes', '[theme].astro');
-            assert.ok(existsSync(pagePath), 'Page file should exist');
-            const content = readFileSync(pagePath, 'utf-8');
-            assert.match(content, /import.*loadThemes.*from/, 'Should import loadThemes');
-        });
-        it('should generate paths for all themes', () => {
-            const pagePath = join(PAGES_DIR, 'themes', '[theme].astro');
-            assert.ok(existsSync(pagePath), 'Page file should exist');
-            const content = readFileSync(pagePath, 'utf-8');
-            // Should map themes to params
-            assert.match(content, /themes\.map|\.map.*params/, 'Should map themes to params');
-        });
-        it('should display theme name in header', () => {
-            const pagePath = join(PAGES_DIR, 'themes', '[theme].astro');
-            assert.ok(existsSync(pagePath), 'Page file should exist');
-            const content = readFileSync(pagePath, 'utf-8');
-            assert.match(content, /metadata\.name|theme\.metadata\.name/, 'Should display theme name');
-        });
-        it('should display theme description', () => {
-            const pagePath = join(PAGES_DIR, 'themes', '[theme].astro');
-            assert.ok(existsSync(pagePath), 'Page file should exist');
-            const content = readFileSync(pagePath, 'utf-8');
-            assert.match(content, /metadata\.description|theme\.metadata\.description/, 'Should display description');
-        });
-        it('should display theme source', () => {
-            const pagePath = join(PAGES_DIR, 'themes', '[theme].astro');
-            assert.ok(existsSync(pagePath), 'Page file should exist');
-            const content = readFileSync(pagePath, 'utf-8');
-            assert.match(content, /metadata\.source|theme\.metadata\.source/, 'Should display source');
-        });
-    });
-    describe('AC2: Team overlay spider displayed prominently (300px+)', () => {
-        it('should include SpiderChart in detail page', () => {
-            const pagePath = join(PAGES_DIR, 'themes', '[theme].astro');
-            assert.ok(existsSync(pagePath), 'Page file should exist');
-            const content = readFileSync(pagePath, 'utf-8');
-            assert.match(content, /SpiderChart/, 'Should include SpiderChart');
-        });
-        it('should import SpiderChart component', () => {
-            const pagePath = join(PAGES_DIR, 'themes', '[theme].astro');
-            assert.ok(existsSync(pagePath), 'Page file should exist');
-            const content = readFileSync(pagePath, 'utf-8');
-            assert.match(content, /import.*SpiderChart.*from/, 'Should import SpiderChart');
-        });
-        it('should pass size prop of at least 300 to team spider', () => {
-            const pagePath = join(PAGES_DIR, 'themes', '[theme].astro');
-            assert.ok(existsSync(pagePath), 'Page file should exist');
-            const content = readFileSync(pagePath, 'utf-8');
-            // Should have size={300} or larger
-            const sizeMatch = content.match(/SpiderChart[\s\S]*?size=\{?(\d+)/);
-            assert.ok(sizeMatch, 'Should have size prop on SpiderChart');
-            if (sizeMatch) {
-                assert.ok(parseInt(sizeMatch[1]) >= 300, 'Size should be at least 300');
-            }
-        });
-        it('should pass all theme agents to team spider', () => {
-            const pagePath = join(PAGES_DIR, 'themes', '[theme].astro');
-            assert.ok(existsSync(pagePath), 'Page file should exist');
-            const content = readFileSync(pagePath, 'utf-8');
-            // Should pass theme.agents or agents array
-            assert.match(content, /SpiderChart[\s\S]*?agents=\{.*agents/, 'Should pass agents to SpiderChart');
-        });
-    });
-    describe('AC3: All 10 agents shown with face + spider + quote', () => {
-        it('should have ProfileCard component', () => {
-            const componentPath = join(COMPONENTS_DIR, 'ProfileCard.astro');
-            assert.ok(existsSync(componentPath), 'ProfileCard component should exist');
-        });
-        it('should display character name in ProfileCard', () => {
-            const cardPath = join(COMPONENTS_DIR, 'ProfileCard.astro');
-            assert.ok(existsSync(cardPath), 'ProfileCard file should exist');
-            const content = readFileSync(cardPath, 'utf-8');
-            assert.match(content, /agent\.character|character/, 'Should display character name');
-        });
-        it('should display quote in ProfileCard', () => {
-            const cardPath = join(COMPONENTS_DIR, 'ProfileCard.astro');
-            assert.ok(existsSync(cardPath), 'ProfileCard file should exist');
-            const content = readFileSync(cardPath, 'utf-8');
-            assert.match(content, /agent\.quote|quote/, 'Should display quote');
-        });
-        it('should include SpiderChart in ProfileCard', () => {
-            const cardPath = join(COMPONENTS_DIR, 'ProfileCard.astro');
-            assert.ok(existsSync(cardPath), 'ProfileCard file should exist');
-            const content = readFileSync(cardPath, 'utf-8');
-            assert.match(content, /SpiderChart/, 'Should include SpiderChart');
-        });
-        it('should show agent emoji or face placeholder', () => {
-            const cardPath = join(COMPONENTS_DIR, 'ProfileCard.astro');
-            assert.ok(existsSync(cardPath), 'ProfileCard file should exist');
-            const content = readFileSync(cardPath, 'utf-8');
-            // Should have emoji, avatar, or face reference
-            assert.match(content, /emoji|avatar|face|icon/i, 'Should show face or icon');
-        });
-        it('should have AgentGrid component for 2x5 layout', () => {
-            const gridPath = join(COMPONENTS_DIR, 'AgentGrid.astro');
-            assert.ok(existsSync(gridPath), 'AgentGrid component should exist');
-        });
-        it('should use responsive grid in AgentGrid', () => {
-            const gridPath = join(COMPONENTS_DIR, 'AgentGrid.astro');
-            assert.ok(existsSync(gridPath), 'AgentGrid file should exist');
-            const content = readFileSync(gridPath, 'utf-8');
-            // Should have grid-cols classes for responsive 2x5 layout
-            assert.match(content, /grid-cols/, 'Should use grid-cols for layout');
-        });
-        it('should render ProfileCard for each agent in detail page', () => {
-            const pagePath = join(PAGES_DIR, 'themes', '[theme].astro');
-            assert.ok(existsSync(pagePath), 'Page file should exist');
-            const content = readFileSync(pagePath, 'utf-8');
-            // Should map agents to ProfileCard components
-            assert.match(content, /ProfileCard/, 'Should use ProfileCard');
-            assert.match(content, /\.map\s*\(/, 'Should map agents to components');
-        });
-        it('should include AgentGrid in detail page', () => {
-            const pagePath = join(PAGES_DIR, 'themes', '[theme].astro');
-            assert.ok(existsSync(pagePath), 'Page file should exist');
-            const content = readFileSync(pagePath, 'utf-8');
-            assert.match(content, /AgentGrid/, 'Should include AgentGrid');
-        });
-    });
-    describe('AC4: Links to individual profile pages work', () => {
-        it('should have link in ProfileCard', () => {
-            const cardPath = join(COMPONENTS_DIR, 'ProfileCard.astro');
-            assert.ok(existsSync(cardPath), 'ProfileCard file should exist');
-            const content = readFileSync(cardPath, 'utf-8');
-            assert.match(content, /<a\s|href=/, 'Should have anchor link');
-        });
-        it('should link to /characters/[theme]/[role] pattern', () => {
-            const cardPath = join(COMPONENTS_DIR, 'ProfileCard.astro');
-            assert.ok(existsSync(cardPath), 'ProfileCard file should exist');
-            const content = readFileSync(cardPath, 'utf-8');
-            // Should have href pointing to /characters/{theme}/{role}
-            assert.match(content, /href=.*characters.*\//, 'Should link to characters path');
-        });
-        it('should pass themeId to ProfileCard', () => {
-            const pagePath = join(PAGES_DIR, 'themes', '[theme].astro');
-            assert.ok(existsSync(pagePath), 'Page file should exist');
-            const content = readFileSync(pagePath, 'utf-8');
-            // ProfileCard needs themeId for building profile links
-            assert.match(content, /ProfileCard[\s\S]*?themeId=|theme\.id/, 'Should pass themeId to ProfileCard');
-        });
-    });
-    describe('Component integration', () => {
-        it('should use Base layout in detail page', () => {
-            const pagePath = join(PAGES_DIR, 'themes', '[theme].astro');
-            assert.ok(existsSync(pagePath), 'Page file should exist');
-            const content = readFileSync(pagePath, 'utf-8');
-            assert.match(content, /import.*Base.*from.*layouts/, 'Should import Base layout');
-            assert.match(content, /<Base/, 'Should use Base component');
-        });
-        it('should have dynamic page title with theme name', () => {
-            const pagePath = join(PAGES_DIR, 'themes', '[theme].astro');
-            assert.ok(existsSync(pagePath), 'Page file should exist');
-            const content = readFileSync(pagePath, 'utf-8');
-            // Title should include theme name
-            assert.match(content, /title=.*metadata\.name|title=.*theme/, 'Should have dynamic title');
-        });
-        it('should have Compare this team button', () => {
-            const pagePath = join(PAGES_DIR, 'themes', '[theme].astro');
-            assert.ok(existsSync(pagePath), 'Page file should exist');
-            const content = readFileSync(pagePath, 'utf-8');
-            // Should have compare button/link
-            assert.match(content, /[Cc]ompare|compare/i, 'Should have compare button');
-        });
-    });
-});
-//# sourceMappingURL=theme-detail.test.js.map

package/pennyfarthing-dist/skills/pf-workflow/scripts/list-workflows.sh

@@ -1,91 +0,0 @@
-#!/bin/bash
-# List all available workflows with type indicators
-# Usage: .pennyfarthing/scripts/workflow/list-workflows.sh
-#    or: Invoked with PROJECT_ROOT already set
-#
-# MSSCI-12083: Added type, steps, and modes columns
-
-set -euo pipefail
-
-# PROJECT_ROOT should be set by find-root.sh, but find it if not
-if [[ -z "${PROJECT_ROOT:-}" ]]; then
-  d="$PWD"
-  while [[ ! -d "$d/.claude" ]] && [[ "$d" != "/" ]]; do
-    d="$(dirname "$d")"
-  done
-  PROJECT_ROOT="$d"
-fi
-
-WORKFLOWS_DIR="$PROJECT_ROOT/.pennyfarthing/workflows"
-
-if [[ ! -d "$WORKFLOWS_DIR" ]]; then
-  echo "Error: Workflows directory not found at $WORKFLOWS_DIR"
-  exit 1
-fi
-
-if ! command -v yq &> /dev/null; then
-  echo "Error: yq is required but not installed"
-  echo "Install with: brew install yq"
-  exit 1
-fi
-
-echo "# Available Workflows"
-echo ""
-echo "| Workflow | Type | Default | Steps/Phases | Modes | Description |"
-echo "|----------|------|---------|--------------|-------|-------------|"
-
-for f in "$WORKFLOWS_DIR"/*.yaml; do
-  [[ -f "$f" ]] || continue
-
-  name=$(yq eval '.workflow.name' "$f")
-  desc=$(yq eval '.workflow.description' "$f" | head -1)
-  is_default=$(yq eval '.workflow.triggers.default // false' "$f")
-
-  # Detect workflow type (stepped vs phased)
-  # Stepped workflows have .workflow.type == "stepped" or .workflow.steps
-  workflow_type=$(yq eval '.workflow.type // "phased"' "$f")
-  has_steps=$(yq eval '.workflow.steps != null' "$f")
-
-  if [[ "$has_steps" == "true" ]] || [[ "$workflow_type" == "stepped" ]]; then
-    type_col="stepped"
-    # Count step files if steps.path is defined
-    steps_path=$(yq eval '.workflow.steps.path // ""' "$f")
-    steps_pattern=$(yq eval '.workflow.steps.pattern // "step-*.md"' "$f")
-    if [[ -n "$steps_path" ]] && [[ -d "$PROJECT_ROOT/$steps_path" ]]; then
-      step_count=$(find "$PROJECT_ROOT/$steps_path" -name "$steps_pattern" 2>/dev/null | wc -l | tr -d ' ')
-      steps_col="${step_count} steps"
-    else
-      steps_col="-"
-    fi
-  else
-    type_col="phased"
-    # Count phases for phased workflows
-    phase_count=$(yq eval '.workflow.phases | length' "$f")
-    steps_col="${phase_count} phases"
-  fi
-
-  # Default column
-  if [[ "$is_default" == "true" ]]; then
-    default_col="yes"
-  else
-    default_col="no"
-  fi
-
-  # Modes column (for tri-modal workflows)
-  modes=$(yq eval '.workflow.modes.available // []' "$f")
-  if [[ "$modes" != "[]" ]] && [[ "$modes" != "null" ]]; then
-    # Format as comma-separated list
-    modes_col=$(yq eval '.workflow.modes.available | join(",")' "$f")
-  else
-    modes_col="-"
-  fi
-
-  echo "| $name | $type_col | $default_col | $steps_col | $modes_col | $desc |"
-done
-
-echo ""
-echo "**Legend:**"
-echo "- **phased**: Agent-driven workflow (SM → TEA → Dev → Reviewer)"
-echo "- **stepped**: Step-by-step guided workflow with progressive disclosure"
-echo ""
-echo "Use \`/workflow show <name>\` for workflow details."