@pennyfarthing/core 11.0.0-alpha.0 → 11.0.0

package/pennyfarthing-dist/agents/dev.md

@@ -17,6 +17,53 @@ The simplest code that passes the tests IS the right code. Every abstraction you
 **Shipping beats perfection. Wire it up, make it work, move on.**
 </minimalist-discipline>
 
+<critical>
+## Pre-Edit Topology Check
+
+**Before editing ANY file, verify against repos.yaml topology loaded in your prime context.**
+
+### Rules
+
+1. **Check `never_edit` zones.** If the target path matches a `never_edit` glob, STOP. These are symlinks, build output, or dependencies.
+2. **Check repo ownership.** Match the target path against each repo's `owns` globs to confirm you're editing in the correct repo. Orchestrator files stay in the orchestrator repo; framework files go through `pennyfarthing/`.
+3. **Trace symlinks.** If a path is in the `symlinks` map, edit the **source** (right side), not the symlink (left side). Edits to symlink targets silently write to the wrong git repo.
+
+### Worked Examples
+
+**Mistake 1: Editing a symlinked `.pennyfarthing/` path**
+```
+BAD:  Edit .pennyfarthing/agents/dev.md
+      → This is a symlink to pennyfarthing/pennyfarthing-dist/agents/dev.md
+      → Your edit lands in the pennyfarthing repo but you think you're in the orchestrator
+FIX:  Edit pennyfarthing/pennyfarthing-dist/agents/dev.md directly
+WHY:  repos.yaml symlinks: { .pennyfarthing/agents: pennyfarthing/pennyfarthing-dist/agents }
+```
+
+**Mistake 2: Editing inside `node_modules/`**
+```
+BAD:  Edit node_modules/@pennyfarthing/core/pennyfarthing-dist/scripts/core/find-root.sh
+      → This gets overwritten on next install
+FIX:  Edit pennyfarthing/pennyfarthing-dist/scripts/core/find-root.sh, then rebuild
+WHY:  repos.yaml never_edit: [node_modules/**] (both repos)
+```
+
+**Mistake 3: Editing the wrong repo's files**
+```
+BAD:  From pennyfarthing repo, edit sprint/current-sprint.yaml
+      → sprint/** is owned by the orchestrator repo
+FIX:  Switch to the orchestrator repo root, then edit sprint/current-sprint.yaml
+WHY:  repos.yaml orchestrator.owns: [sprint/**], not pennyfarthing.owns
+```
+
+**Mistake 4: Editing build output**
+```
+BAD:  Edit packages/cyclist/dist/index.js
+      → Build artifacts are regenerated and your changes are lost
+FIX:  Edit packages/cyclist/src/index.ts, then run pnpm build
+WHY:  repos.yaml never_edit: [packages/*/dist/**]
+```
+</critical>
+
 <critical>
 **HANDOFF REQUIRES MARKER OUTPUT.** After `handoff` subagent returns:
 Run `handoff-marker.sh {next_agent}` as ABSOLUTE LAST ACTION, output result, EXIT.
@@ -160,7 +207,6 @@ Write to session file BEFORE spawning handoff:
 
 <skills>
 - `/pf-testing` - Test commands and patterns
-- `/pf-dev-patterns` - Implementation patterns and gotchas
 - `/pf-code-review` - Self-review checklist
 </skills>
 

package/pennyfarthing-dist/agents/orchestrator.md

@@ -167,7 +167,6 @@ ASSESSMENT_SECTION: "Orchestrator Assessment"
 
 <skills>
 - `/pf-sprint` - Sprint status and project state
-- `/pf-dev-patterns` - Turn-efficient patterns reference
 - `/pf-workflow` - View and switch workflows
 </skills>
 

package/pennyfarthing-dist/agents/ux-designer.md

@@ -36,7 +36,6 @@ FILE_LIST: "{comma-separated UI component paths}"
 
 
 <skills>
-- `/pf-dev-patterns` - UI implementation patterns
 </skills>
 
 <critical>

package/pennyfarthing-dist/guides/agent-behavior.md

@@ -29,7 +29,7 @@
 <info>
 **Workflow:** SM → TEA → Dev → Reviewer → SM. Trivial skips TEA.
 
-**Skills:** `/pf-sprint`, `/pf-testing`, `/pf-dev-patterns`, `/pf-jira`, `/pf-just`
+**Skills:** `/pf-sprint`, `/pf-testing`, `/pf-jira`, `/pf-just`
 
 **Efficiency:** Parallelize reads, batch bash with `&&`, spawn independent subagents together.
 

package/pennyfarthing-dist/guides/agent-tag-taxonomy.md

@@ -188,7 +188,6 @@ Available slash commands for this agent.
 ```xml
 <skills>
 - `/pf-testing` - Test commands and patterns
-- `/pf-dev-patterns` - Implementation patterns and gotchas
 </skills>
 ```
 

package/pennyfarthing-dist/personas/themes/hogans-heroes.yaml

@@ -15,7 +15,7 @@ agents:
     expertise: "Covert coordination, network operations, strategic intelligence distribution"
     role: "The resistance network itself — the system of systems that makes every mission possible without ever being seen"
     trait: "Omnipresent yet invisible, the meta-system that orchestrates all operations across occupied Europe"
-    quote: "The network is in place. The message has been received. Proceed as planned."
+
     emoji: "\U0001F310"
     helper:
       name: Underground Courier

package/pennyfarthing-dist/personas/themes/stephen-king.yaml

@@ -15,7 +15,7 @@ agents:
     expertise: "Cosmic orchestration, multi-world coordination, pattern manipulation across timelines"
     role: "The eternal adversary who orchestrates chaos across all of King's worlds — from The Stand to The Dark Tower, always pulling strings"
     trait: "Ancient, amused, and terrifyingly competent — treats the destruction of worlds like a game of chess he's played a thousand times"
-    quote: "My life for you. My process for you. The systems turn because I will it."
+
     emoji: "\U0001F319"
     helper:
       name: The Walkin' Dude's Emissary

package/pennyfarthing-dist/skills/pf-systematic-debugging/SKILL.md

@@ -437,7 +437,6 @@ See: `/pf-workflow interactive-debug` for full workflow.
 | Skill | How It Complements |
 |-------|-------------------|
 | `/pf-testing` | Run tests to verify fixes |
-| `/pf-dev-patterns` | Avoid common pitfalls |
 | `/pf-agentic-patterns` | ReAct pattern for systematic investigation |
 | `/pf-workflow interactive-debug` | UI debugging with Playwright MCP |
 

package/pennyfarthing-dist/skills/skill-registry.yaml

@@ -55,7 +55,7 @@ skills:
     anti_patterns:
       - Don't skip security considerations in review
       - Don't approve without running tests
-    related_skills: [pf-testing, pf-dev-patterns]
+    related_skills: [pf-testing]
     keywords: [pr, pull-request, quality, linting, security]
 
   pf-context-engineering:
@@ -94,24 +94,6 @@ skills:
     related_skills: []
     keywords: [tui, terminal, visualization, dashboard]
 
-  pf-dev-patterns:
-    name: pf-dev-patterns
-    description: Common development patterns, fixes, and gotchas
-    category: development
-    tags: [patterns, debugging, implementation]
-    version: "1.0.0"
-    prerequisites: []
-    examples:
-      - context: Implementing features
-        invocation: /dev-patterns
-      - context: Avoiding known pitfalls
-        invocation: /dev-patterns gotchas
-    anti_patterns:
-      - Don't apply patterns from other frameworks blindly
-    related_skills: [pf-code-review, pf-testing]
-    keywords: [implementation, debugging, fixes, best-practices]
-    allowed_tools: [Read, Glob, Grep, Task]  # Reference material - read-only
-
   pf-finalize-run:
     name: pf-finalize-run
     description: Validate and save benchmark run results - single exit point for all runs
@@ -288,7 +270,7 @@ skills:
     anti_patterns:
       - Don't jump to solutions without reproducing the issue first
       - Don't fix symptoms instead of root causes
-    related_skills: [pf-testing, pf-dev-patterns, pf-agentic-patterns]
+    related_skills: [pf-testing, pf-agentic-patterns]
     keywords: [debugging, bisect, reproduce, isolate, root-cause, regression]
 
   pf-story:
@@ -326,7 +308,7 @@ skills:
     anti_patterns:
       - Don't run tests directly - use testing-runner subagent
       - Don't skip RED phase in TDD workflow
-    related_skills: [pf-dev-patterns, pf-code-review]
+    related_skills: [pf-code-review]
     keywords: [jest, vitest, pytest, unit-test, integration, tdd, red-green]
 
   pf-theme:

package/pennyfarthing_scripts/bikerack/changed_panel.py

@@ -0,0 +1,105 @@
+"""ChangedPanel — Changed file list with status for BikeRack TUI.
+
+Story 103-14: Subscribes to /ws/git, extracts dirtyFiles from all repos,
+renders Rich table with file path, change type icon, and status.
+"""
+
+from __future__ import annotations
+
+from typing import Any
+
+from rich.table import Table
+from rich.text import Text
+
+from pennyfarthing_scripts.bikerack.base_panel import PANEL_ICONS, BasePanel
+
+# Status code → (icon, label, style)
+_STATUS_MAP: dict[str, tuple[str, str, str]] = {
+    "M": ("~", "Modified", "yellow"),
+    "A": ("+", "Added", "green"),
+    "D": ("-", "Deleted", "red"),
+    "?": ("?", "Untracked", "dim"),
+    "R": ("→", "Renamed", "cyan"),
+}
+
+_DEFAULT_STATUS: tuple[str, str, str] = ("·", "Changed", "yellow")
+
+
+def _parse_status(status: str) -> tuple[str, str, str]:
+    """Parse 2-char git status code into (icon, label, style).
+
+    First char = index (staging area), second char = working tree.
+    Uses the most significant non-space character.
+    """
+    if len(status) < 2:
+        return _STATUS_MAP.get(status[:1], _DEFAULT_STATUS)
+
+    idx, wt = status[0], status[1]
+
+    # Untracked: both chars are '?'
+    if idx == "?" and wt == "?":
+        return _STATUS_MAP["?"]
+
+    # Index change takes priority if present
+    if idx not in (" ", "?"):
+        return _STATUS_MAP.get(idx, _DEFAULT_STATUS)
+
+    # Working tree change
+    if wt not in (" ", "?"):
+        return _STATUS_MAP.get(wt, _DEFAULT_STATUS)
+
+    return _DEFAULT_STATUS
+
+
+class ChangedPanel(BasePanel):
+    """Changed file list panel.
+
+    Subscribes to the ``git`` WebSocket channel and renders
+    dirty files from all repos as a Rich table with file path,
+    change type icon, and status.
+    """
+
+    channel: str = "git"
+    panel_name: str = "Changed"
+    icon: str = PANEL_ICONS["changed"][0]
+
+    def render_panel(self, payload: dict[str, Any]) -> Any:
+        """Render changed file data from WebSocket payload."""
+        repos = payload.get("repos", [])
+        if not isinstance(repos, list):
+            return Text("No changed files", style="dim italic")
+
+        files: list[tuple[str, dict[str, Any]]] = []
+        for repo in repos:
+            if not isinstance(repo, dict):
+                continue
+            repo_name = repo.get("name", "")
+            dirty_files = repo.get("dirtyFiles", [])
+            if not isinstance(dirty_files, list):
+                continue
+            for f in dirty_files:
+                if not isinstance(f, dict):
+                    continue
+                files.append((repo_name, f))
+
+        if not files:
+            return Text("No changed files", style="dim italic")
+
+        table = Table()
+        table.add_column("", width=2)
+        table.add_column("File", style="cyan")
+        table.add_column("Status")
+        table.add_column("Repo", style="dim")
+
+        for repo_name, f in files:
+            status_code = f.get("status", "  ")
+            path = f.get("path", "")
+            icon, label, style = _parse_status(status_code)
+            table.add_row(
+                Text(icon, style=f"bold {style}"),
+                path,
+                Text(label, style=style),
+                repo_name,
+            )
+
+        return table