@pennyfarthing/core 10.3.0 → 10.4.0

package/pennyfarthing_scripts/sprint/archive_epic.py

@@ -65,7 +65,11 @@ def ensure_archive_file(project_root: Path | None = None) -> Path:
 
     sprint_name = sprint_info.get("jira_sprint_name", "Unknown Sprint")
     sprint_id = sprint_info.get("jira_sprint_id", "")
+    sprint_number = sprint_info.get("number", "")
     goal = sprint_info.get("goal", "")
+    start_date = sprint_info.get("start_date", "")
+    end_date = sprint_info.get("end_date", "")
+    status = sprint_info.get("status", "active")
 
     template = f"""# Sprint {sprint_name} - Completed Work
 # Jira Sprint ID: {sprint_id}
@@ -73,9 +77,13 @@ def ensure_archive_file(project_root: Path | None = None) -> Path:
 
 sprint:
   name: "{sprint_name}"
+  number: {sprint_number}
   jira_sprint_id: {sprint_id}
   jira_sprint_name: "{sprint_name}"
   goal: {goal}
+  start_date: {start_date}
+  end_date: {end_date}
+  status: {status}
 
 completed_epics:
   # Epic shard files live in sprint/archive/epic-{{ref}}.yaml
@@ -183,7 +191,7 @@ def is_epic_complete(epic: dict[str, Any]) -> tuple[bool, list[str]]:
     incomplete = []
     for story in stories:
         story_status = story.get("status", "backlog")
-        if story_status not in ("done", "completed", "cancelled"):
+        if story_status not in ("done", "completed", "canceled", "cancelled"):
             incomplete.append(story.get("id", "unknown"))
 
     return len(incomplete) == 0, incomplete

package/pennyfarthing_scripts/tests/test_version_sentinel.py

@@ -0,0 +1,126 @@
+"""Tests for MSSCI-14698: Version sentinel detection in prime.
+
+Story 98-1: pf agent start (prime) compares .pennyfarthing/.installed-version
+sentinel against package version. On mismatch, triggers auto-update.
+
+Acceptance Criteria tested here:
+- AC3: pf agent start (prime) compares sentinel version against package version
+- AC4: On version mismatch, auto-runs pennyfarthing update --auto
+- AC6: Missing sentinel file treated as version mismatch (triggers update)
+
+(AC1, AC2, AC5 tested in TypeScript: packages/core/src/cli/commands/version-sentinel.test.ts)
+"""
+
+from pathlib import Path
+from unittest.mock import patch, MagicMock
+
+import pytest
+
+# Module to be implemented
+from pennyfarthing_scripts.prime.version_sentinel import (
+    read_sentinel_version,
+    get_package_version,
+    check_version_mismatch,
+)
+
+
+class TestReadSentinelVersion:
+    """Tests for reading the sentinel file."""
+
+    def test_reads_version_from_sentinel_file(self, tmp_path: Path) -> None:
+        """AC3: Should read version from .pennyfarthing/.installed-version."""
+        pf_dir = tmp_path / ".pennyfarthing"
+        pf_dir.mkdir()
+        sentinel = pf_dir / ".installed-version"
+        sentinel.write_text("10.3.1\n")
+
+        version = read_sentinel_version(tmp_path)
+        assert version == "10.3.1"
+
+    def test_returns_none_when_sentinel_missing(self, tmp_path: Path) -> None:
+        """AC6: Missing sentinel file should return None."""
+        pf_dir = tmp_path / ".pennyfarthing"
+        pf_dir.mkdir()
+        # No .installed-version file
+
+        version = read_sentinel_version(tmp_path)
+        assert version is None
+
+    def test_returns_none_when_pennyfarthing_dir_missing(self, tmp_path: Path) -> None:
+        """AC6: Missing .pennyfarthing/ directory should return None."""
+        version = read_sentinel_version(tmp_path)
+        assert version is None
+
+    def test_trims_whitespace(self, tmp_path: Path) -> None:
+        """Should handle extra whitespace in sentinel file."""
+        pf_dir = tmp_path / ".pennyfarthing"
+        pf_dir.mkdir()
+        sentinel = pf_dir / ".installed-version"
+        sentinel.write_text("  10.3.1  \n")
+
+        version = read_sentinel_version(tmp_path)
+        assert version == "10.3.1"
+
+    def test_returns_none_for_empty_file(self, tmp_path: Path) -> None:
+        """Should return None for empty sentinel file."""
+        pf_dir = tmp_path / ".pennyfarthing"
+        pf_dir.mkdir()
+        sentinel = pf_dir / ".installed-version"
+        sentinel.write_text("")
+
+        version = read_sentinel_version(tmp_path)
+        assert version is None
+
+
+class TestCheckVersionMismatch:
+    """Tests for version comparison and auto-update triggering."""
+
+    def test_no_mismatch_when_versions_match(self, tmp_path: Path) -> None:
+        """AC3: No mismatch when sentinel matches package version."""
+        pf_dir = tmp_path / ".pennyfarthing"
+        pf_dir.mkdir()
+        sentinel = pf_dir / ".installed-version"
+        sentinel.write_text("10.3.1\n")
+
+        result = check_version_mismatch(tmp_path, package_version="10.3.1")
+        assert result.needs_update is False
+
+    def test_mismatch_when_versions_differ(self, tmp_path: Path) -> None:
+        """AC3/AC4: Mismatch when sentinel differs from package version."""
+        pf_dir = tmp_path / ".pennyfarthing"
+        pf_dir.mkdir()
+        sentinel = pf_dir / ".installed-version"
+        sentinel.write_text("10.2.0\n")
+
+        result = check_version_mismatch(tmp_path, package_version="10.3.1")
+        assert result.needs_update is True
+        assert result.installed_version == "10.2.0"
+        assert result.package_version == "10.3.1"
+
+    def test_mismatch_when_sentinel_missing(self, tmp_path: Path) -> None:
+        """AC6: Missing sentinel file treated as version mismatch."""
+        pf_dir = tmp_path / ".pennyfarthing"
+        pf_dir.mkdir()
+        # No sentinel file
+
+        result = check_version_mismatch(tmp_path, package_version="10.3.1")
+        assert result.needs_update is True
+        assert result.installed_version is None
+
+    def test_mismatch_when_pennyfarthing_dir_missing(self, tmp_path: Path) -> None:
+        """AC6: Missing .pennyfarthing/ directory treated as mismatch."""
+        result = check_version_mismatch(tmp_path, package_version="10.3.1")
+        assert result.needs_update is True
+        assert result.installed_version is None
+
+    def test_result_includes_both_versions(self, tmp_path: Path) -> None:
+        """Result should include both installed and package version for reporting."""
+        pf_dir = tmp_path / ".pennyfarthing"
+        pf_dir.mkdir()
+        sentinel = pf_dir / ".installed-version"
+        sentinel.write_text("10.2.0\n")
+
+        result = check_version_mismatch(tmp_path, package_version="10.3.1")
+        assert result.installed_version == "10.2.0"
+        assert result.package_version == "10.3.1"
+        assert result.needs_update is True

package/scripts/README.md

@@ -1,41 +0,0 @@
-# Meta Scripts
-
-**These scripts are NOT distributed to users.** They are for Pennyfarthing framework development only.
-
-## Contents
-
-| Script | Purpose |
-|--------|---------|
-| `deploy.sh` | Release Pennyfarthing (version bump, tag, push, GitHub release) |
-| `cyclist-debug.mjs` | Debug Cyclist connection |
-| `handoff-cli.{sh,js}` | Test handoff flow |
-| `verify-visual-mapping.js` | Verify theme visual mappings |
-| `migrate-assets-to-slug.sh` | One-time migration script |
-| `resize-portraits.sh` | Resize portrait images |
-| `resolve-portrait.mjs` | Portrait resolution logic |
-| `validate-refs.js` | Validate internal references |
-
-> Benchmark scripts have been moved to `packages/benchmark/`.
-
-## Usage
-
-Run from pennyfarthing repo root:
-
-```bash
-# Release a new version
-./scripts/deploy.sh --dry-run patch
-./scripts/deploy.sh patch
-```
-
-## Where Should My Script Go?
-
-**Put it here if:**
-- It's for framework development/CI only
-- Users should NOT have access to it
-- It uses GPU/heavy dependencies (keep in meta, not distributed)
-
-**Put it in `pennyfarthing-dist/scripts/` if:**
-- Users need it for their workflows
-- It's part of the sprint/story/jira tooling
-
-See `CLAUDE.md` for the full decision tree.