@pennyfarthing/core 10.1.0 → 10.3.0

package/pennyfarthing_scripts/tests/test_brownfield.py

@@ -12,37 +12,34 @@ Tests verify:
 7. CLI integration
 """
 
-import asyncio
 import subprocess
 import sys
 import tempfile
+from collections.abc import Generator
 from pathlib import Path
-from typing import Generator
-from unittest.mock import MagicMock, patch
 
 import pytest
 
 from pennyfarthing_scripts.brownfield import (
     DepthLevel,
-    ProjectType,
     DiscoveryResult,
+    ProjectType,
+    detect_architecture_patterns,
     detect_project_type,
     detect_tech_stack,
-    scan_directory_structure,
-    detect_architecture_patterns,
+    discover,
+    generate_ai_guidance_doc,
     generate_project_overview,
-    generate_tech_stack_doc,
     generate_source_tree_doc,
-    generate_ai_guidance_doc,
-    discover,
+    generate_tech_stack_doc,
+    scan_directory_structure,
 )
 from pennyfarthing_scripts.brownfield.discover import (
-    TechStackItem,
-    DirectoryNode,
     ArchitecturePattern,
+    DirectoryNode,
+    TechStackItem,
 )
 
-
 # =============================================================================
 # FIXTURES
 # =============================================================================
@@ -623,7 +620,7 @@ class TestDiscover:
         output_dir = temp_project_dir / "output"
         output_dir.mkdir()
 
-        result = await discover(node_project, output_dir=output_dir, depth=DepthLevel.DEEP)
+        await discover(node_project, output_dir=output_dir, depth=DepthLevel.DEEP)
 
         expected_files = [
             "project-overview.md",

package/pennyfarthing_scripts/tests/test_cli_modules.py

@@ -8,10 +8,6 @@ properly delegate to library modules.
 
 import subprocess
 import sys
-from typing import Any
-from unittest.mock import MagicMock, patch
-
-import pytest
 
 
 class TestJiraCLIModule:

package/pennyfarthing_scripts/tests/test_codemarkers.py

@@ -9,16 +9,13 @@ Tests cover: models, analyze engine, CLI, formatters.
 
 from __future__ import annotations
 
-import asyncio
 import json
 from dataclasses import asdict
 from pathlib import Path
-from typing import Any
-from unittest.mock import AsyncMock, MagicMock, patch
+from unittest.mock import AsyncMock, patch
 
 import pytest
 
-
 # ---------------------------------------------------------------------------
 # Models
 # ---------------------------------------------------------------------------
@@ -123,7 +120,9 @@ class TestCodeMarkersResultModel:
     def test_json_serializable(self) -> None:
         """Full result serializes to JSON via asdict."""
         from pennyfarthing_scripts.codemarkers.models import (
-            CodeMarker, CodeMarkersResult, MarkerSummary,
+            CodeMarker,
+            CodeMarkersResult,
+            MarkerSummary,
         )
 
         r = CodeMarkersResult(
@@ -534,7 +533,7 @@ class TestTableFormatter:
         ]
         out = format_marker_table(markers, top_n=5)
         # Header + separator + 5 data rows = 7 lines
-        lines = [l for l in out.strip().split("\n") if l.strip()]
+        lines = [line for line in out.strip().split("\n") if line.strip()]
         assert len(lines) <= 7
 
 
@@ -544,7 +543,9 @@ class TestJsonExport:
     def test_valid_json(self) -> None:
         from pennyfarthing_scripts.codemarkers.formatters import export_json
         from pennyfarthing_scripts.codemarkers.models import (
-            CodeMarker, CodeMarkersResult, MarkerSummary,
+            CodeMarker,
+            CodeMarkersResult,
+            MarkerSummary,
         )
 
         r = CodeMarkersResult(
@@ -587,6 +588,7 @@ class TestCLI:
     def test_cli_help(self) -> None:
         """codemarkers group shows help."""
         from click.testing import CliRunner
+
         from pennyfarthing_scripts.codemarkers.cli import codemarkers
 
         runner = CliRunner()
@@ -597,6 +599,7 @@ class TestCLI:
     def test_analyze_command_exists(self) -> None:
         """analyze subcommand is registered."""
         from click.testing import CliRunner
+
         from pennyfarthing_scripts.codemarkers.cli import codemarkers
 
         runner = CliRunner()
@@ -608,6 +611,7 @@ class TestCLI:
     def test_stale_command_exists(self) -> None:
         """stale subcommand is registered."""
         from click.testing import CliRunner
+
         from pennyfarthing_scripts.codemarkers.cli import codemarkers
 
         runner = CliRunner()
@@ -617,6 +621,7 @@ class TestCLI:
     def test_summary_command_exists(self) -> None:
         """summary subcommand is registered."""
         from click.testing import CliRunner
+
         from pennyfarthing_scripts.codemarkers.cli import codemarkers
 
         runner = CliRunner()
@@ -626,6 +631,7 @@ class TestCLI:
     def test_json_format_option(self) -> None:
         """--format json produces JSON output."""
         from click.testing import CliRunner
+
         from pennyfarthing_scripts.codemarkers.cli import codemarkers
 
         runner = CliRunner()
@@ -672,7 +678,6 @@ class TestModuleExports:
         from pennyfarthing_scripts.codemarkers import (
             CodeMarker,
             CodeMarkersResult,
-            MarkerSummary,
         )
         assert CodeMarker is not None
         assert CodeMarkersResult is not None

package/pennyfarthing_scripts/tests/test_common.py

@@ -10,7 +10,6 @@ import io
 import os
 import sys
 from pathlib import Path
-from typing import Generator
 from unittest.mock import patch
 
 import pytest
@@ -120,9 +119,15 @@ class TestConfigModule:
         """get_project_root() should raise if no .pennyfarthing found."""
         from pennyfarthing_scripts.common import config
 
-        # Start from root filesystem where there's no .pennyfarthing
-        with pytest.raises(FileNotFoundError):
-            config.get_project_root(start_dir=Path("/"))
+        # Clear env vars that bypass the directory walk
+        env_overrides = {"PROJECT_ROOT": "", "CLAUDE_PROJECT_DIR": ""}
+        with patch.dict(os.environ, env_overrides, clear=False):
+            # Remove keys entirely if they were set
+            os.environ.pop("PROJECT_ROOT", None)
+            os.environ.pop("CLAUDE_PROJECT_DIR", None)
+            # Start from root filesystem where there's no .pennyfarthing
+            with pytest.raises(FileNotFoundError):
+                config.get_project_root(start_dir=Path("/"))
 
     def test_load_yaml_config_returns_dict(self) -> None:
         """load_yaml_config() should return parsed YAML as dict."""