@pennyfarthing/core 10.0.5 → 10.2.0

package/pennyfarthing_scripts/tests/test_prime.py

@@ -3,21 +3,22 @@
 Tests context loading for prime command.
 """
 
-import pytest
 from pathlib import Path
-from unittest.mock import patch, MagicMock
+from unittest.mock import patch
+
+import pytest
 
+from pennyfarthing_scripts.prime.cli import main, prime
 from pennyfarthing_scripts.prime.loader import (
+    _extract_session_parts,
+    _find_session_file,
     load_agent_definition,
     load_behavior_guide,
-    load_sprint_context,
+    load_domain_docs,
     load_session_context,
     load_sidecars,
-    load_domain_docs,
-    _extract_session_parts,
-    _find_session_file,
+    load_sprint_context,
 )
-from pennyfarthing_scripts.prime.cli import prime, main
 
 
 class TestLoadAgentDefinition:
@@ -407,8 +408,8 @@ class TestWorkflowStateDetection:
 
     def test_detect_finish_state(self, tmp_path: Path) -> None:
         """Test detecting FINISH_STATE when phase is approved."""
-        from pennyfarthing_scripts.prime.workflow import detect_workflow_state
         from pennyfarthing_scripts.prime.models import WorkflowState
+        from pennyfarthing_scripts.prime.workflow import detect_workflow_state
 
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
@@ -436,10 +437,11 @@ class TestWorkflowStateDetection:
 
     def test_detect_in_progress_state(self, tmp_path: Path) -> None:
         """Test detecting IN_PROGRESS_STATE with active phase."""
-        from pennyfarthing_scripts.prime.workflow import detect_workflow_state
-        from pennyfarthing_scripts.prime.models import WorkflowState
         import yaml
 
+        from pennyfarthing_scripts.prime.models import WorkflowState
+        from pennyfarthing_scripts.prime.workflow import detect_workflow_state
+
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
@@ -483,10 +485,11 @@ class TestWorkflowStateDetection:
 
     def test_detect_new_work_state(self, tmp_path: Path) -> None:
         """Test detecting NEW_WORK_STATE with backlog stories."""
-        from pennyfarthing_scripts.prime.workflow import detect_workflow_state
-        from pennyfarthing_scripts.prime.models import WorkflowState
         import yaml
 
+        from pennyfarthing_scripts.prime.models import WorkflowState
+        from pennyfarthing_scripts.prime.workflow import detect_workflow_state
+
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
@@ -514,10 +517,11 @@ class TestWorkflowStateDetection:
 
     def test_detect_empty_backlog_state(self, tmp_path: Path) -> None:
         """Test detecting EMPTY_BACKLOG_STATE with no backlog."""
-        from pennyfarthing_scripts.prime.workflow import detect_workflow_state
-        from pennyfarthing_scripts.prime.models import WorkflowState
         import yaml
 
+        from pennyfarthing_scripts.prime.models import WorkflowState
+        from pennyfarthing_scripts.prime.workflow import detect_workflow_state
+
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
@@ -587,8 +591,8 @@ class TestCheckRedirect:
 
     def test_redirect_when_wrong_agent(self) -> None:
         """Test redirect is detected when wrong agent is activated."""
-        from pennyfarthing_scripts.prime.workflow import check_redirect
         from pennyfarthing_scripts.prime.models import WorkflowState, WorkflowStatus
+        from pennyfarthing_scripts.prime.workflow import check_redirect
 
         status = WorkflowStatus(
             state=WorkflowState.IN_PROGRESS_STATE,
@@ -606,8 +610,8 @@ class TestCheckRedirect:
 
     def test_no_redirect_when_correct_agent(self) -> None:
         """Test no redirect when correct agent is activated."""
-        from pennyfarthing_scripts.prime.workflow import check_redirect
         from pennyfarthing_scripts.prime.models import WorkflowState, WorkflowStatus
+        from pennyfarthing_scripts.prime.workflow import check_redirect
 
         status = WorkflowStatus(
             state=WorkflowState.IN_PROGRESS_STATE,
@@ -621,8 +625,8 @@ class TestCheckRedirect:
 
     def test_no_redirect_for_new_work(self) -> None:
         """Test no redirect for NEW_WORK_STATE."""
-        from pennyfarthing_scripts.prime.workflow import check_redirect
         from pennyfarthing_scripts.prime.models import WorkflowState, WorkflowStatus
+        from pennyfarthing_scripts.prime.workflow import check_redirect
 
         status = WorkflowStatus(
             state=WorkflowState.NEW_WORK_STATE,
@@ -644,9 +648,10 @@ class TestPersonaLoading:
 
     def test_load_persona_from_theme(self, tmp_path: Path) -> None:
         """Test loading persona from theme YAML."""
-        from pennyfarthing_scripts.prime.persona import load_persona
         import yaml
 
+        from pennyfarthing_scripts.prime.persona import load_persona
+
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
@@ -697,9 +702,10 @@ class TestPersonaLoading:
 
     def test_get_crew_manifest(self, tmp_path: Path) -> None:
         """Test getting crew manifest for handoff reference."""
-        from pennyfarthing_scripts.prime.persona import get_crew_manifest
         import yaml
 
+        from pennyfarthing_scripts.prime.persona import get_crew_manifest
+
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
@@ -730,8 +736,8 @@ class TestPersonaLoading:
 
     def test_format_persona_output(self) -> None:
         """Test formatting persona as XML."""
+        from pennyfarthing_scripts.prime.models import CrewMember, Persona
         from pennyfarthing_scripts.prime.persona import format_persona_output
-        from pennyfarthing_scripts.prime.models import Persona, CrewMember
 
         persona = Persona(
             character="Naomi Nagata",
@@ -798,9 +804,10 @@ class TestSessionRegistration:
 
     def test_cleanup_old_sessions(self, tmp_path: Path) -> None:
         """Test cleanup of old session files."""
-        from pennyfarthing_scripts.prime.session import cleanup_old_sessions
         import time
 
+        from pennyfarthing_scripts.prime.session import cleanup_old_sessions
+
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
@@ -886,11 +893,15 @@ class TestJSONOutput:
     def test_json_output_with_workflow(self, tmp_path: Path, capsys) -> None:
         """Test JSON output includes workflow status."""
         import json
+
         import yaml
 
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
+        agents_dir = pf_dir / "agents"
+        agents_dir.mkdir()
+        (agents_dir / "sm.md").write_text("# SM Agent\nScrum Master")
         sprint_dir = tmp_path / "sprint"
         sprint_dir.mkdir()
         (sprint_dir / "current-sprint.yaml").write_text(yaml.dump({
@@ -925,11 +936,15 @@ class TestJSONOutput:
     def test_json_output_with_redirect(self, tmp_path: Path, capsys) -> None:
         """Test JSON output includes redirect info."""
         import json
+
         import yaml
 
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
+        agents_dir = pf_dir / "agents"
+        agents_dir.mkdir()
+        (agents_dir / "tea.md").write_text("# TEA Agent\nTest Engineer")
 
         # Create workflow YAML
         workflows_dir = tmp_path / "pennyfarthing-dist" / "workflows"
@@ -1039,6 +1054,9 @@ class TestCLIFlagsV2:
 
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
+        agents_dir = pf_dir / "agents"
+        agents_dir.mkdir()
+        (agents_dir / "sm.md").write_text("# SM Agent\nScrum Master")
 
         with patch("pennyfarthing_scripts.prime.cli.get_project_root", return_value=tmp_path):
             result = main(["--agent", "sm", "--session-id", "explicit-123", "--no-workflow"])

package/pennyfarthing_scripts/tests/test_sprint_package.py

@@ -7,10 +7,7 @@ after reorganization from flat modules.
 """
 
 from pathlib import Path
-from typing import Any
-from unittest.mock import MagicMock, patch
-
-import pytest
+from unittest.mock import patch
 
 
 class TestSprintLoader:
@@ -28,8 +25,8 @@ class TestSprintLoader:
 
     def test_load_sprint_with_custom_root(self) -> None:
         """load_sprint should accept custom project root."""
-        from pennyfarthing_scripts.sprint.loader import load_sprint
         from pennyfarthing_scripts.common.config import get_project_root
+        from pennyfarthing_scripts.sprint.loader import load_sprint
 
         root = get_project_root()
         result = load_sprint(project_root=root)
@@ -341,8 +338,7 @@ epics:
 
     def test_get_all_stories_with_shards(self, tmp_path: Path) -> None:
         """get_all_stories should return stories from merged shards."""
-        from pennyfarthing_scripts.sprint.loader import get_all_stories, load_sprint
-        from unittest.mock import patch
+        from pennyfarthing_scripts.sprint.loader import get_all_stories
 
         root = self._create_sharded_sprint(tmp_path)
 
@@ -379,7 +375,6 @@ epics:
     def test_backlog_count_defensive_on_strings(self) -> None:
         """get_backlog_count should not crash on string epics."""
         from pennyfarthing_scripts.prime.workflow import get_backlog_count
-        from unittest.mock import patch
 
         fake_data = {"epics": ["MSSCI-14298", "MSSCI-14317"]}
         with patch("pennyfarthing_scripts.sprint.loader.load_sprint", return_value=fake_data):

package/pennyfarthing_scripts/tests/test_sprint_validator.py

@@ -19,19 +19,18 @@ from typing import Any
 import pytest
 
 from pennyfarthing_scripts.sprint.validator import (
-    ValidationError,
     ValidationResult,
     ValidationSeverity,
     format_validation_errors,
     validate_archived_sprint,
     validate_epic,
+    validate_epic_shard,
     validate_full_sprint,
     validate_sprint,
     validate_sprint_file,
     validate_story,
 )
 
-
 # =============================================================================
 # Test Fixtures - Valid Data
 # =============================================================================
@@ -239,7 +238,7 @@ class TestStoryValidation:
 
     def test_all_valid_story_statuses_pass(self) -> None:
         """All valid status values should pass."""
-        valid_statuses = ["backlog", "in_progress", "done", "cancelled"]
+        valid_statuses = ["backlog", "ready", "in_progress", "done", "canceled", "planning"]
 
         for status in valid_statuses:
             story = {"id": "63-1", "title": "Test", "status": status, "points": 3}
@@ -364,6 +363,55 @@ class TestEpicValidation:
         assert result.valid is False
         assert any("duplicate" in e.message.lower() for e in result.errors)
 
+    def test_integer_epic_id_fails(self) -> None:
+        """Epic with integer id (YAML bare number) should fail.
+
+        YAML parses `id: 87` as int. Cyclist's sprint-data.ts calls
+        epicId.match() which crashes on non-strings, blanking the panel.
+        """
+        epic = {
+            "id": 87,  # Bare integer — not quoted in YAML
+            "title": "Test Epic",
+            "stories": [
+                {"id": "87-1", "title": "Story 1", "status": "backlog", "points": 2},
+            ],
+        }
+
+        result = validate_epic(epic, set())
+
+        assert result.valid is False
+        assert any("must be a string" in e.message.lower() for e in result.errors)
+
+    def test_integer_epic_id_fails_in_shard(self) -> None:
+        """Epic shard with integer id should fail validation."""
+        epic = {
+            "id": 87,
+            "title": "Test Epic",
+            "status": "planning",
+            "stories": [
+                {"id": "87-1", "title": "Story 1", "status": "backlog", "points": 2},
+            ],
+        }
+
+        result = validate_epic_shard(epic)
+
+        assert result.valid is False
+        assert any("must be a string" in e.message.lower() for e in result.errors)
+
+    def test_string_epic_id_passes(self) -> None:
+        """Epic with properly quoted string id should pass."""
+        epic = {
+            "id": "87",  # Quoted in YAML — parsed as string
+            "title": "Test Epic",
+            "stories": [
+                {"id": "87-1", "title": "Story 1", "status": "backlog", "points": 2},
+            ],
+        }
+
+        result = validate_epic(epic, set())
+
+        assert result.valid is True
+
 
 # =============================================================================
 # AC4: Clear error messages for validation failures
@@ -470,7 +518,7 @@ class TestArchivedSprintValidation:
         assert result.valid is True
 
     def test_archived_sprint_allows_all_done_stories(self) -> None:
-        """Archived sprints should allow all stories to be done/cancelled."""
+        """Archived sprints should allow all stories to be done/canceled."""
         data = {
             "sprint": {
                 "number": 11,
@@ -486,7 +534,7 @@ class TestArchivedSprintValidation:
                     "title": "Old Epic",
                     "stories": [
                         {"id": "50-1", "title": "Done Story", "status": "done", "points": 3},
-                        {"id": "50-2", "title": "Cancelled Story", "status": "cancelled", "points": 2},
+                        {"id": "50-2", "title": "Canceled Story", "status": "canceled", "points": 2},
                     ],
                 }
             ],

package/pennyfarthing_scripts/tests/test_story_add.py

@@ -15,11 +15,10 @@ Acceptance Criteria:
 """
 
 from pathlib import Path
-from typing import Any
 
 import pytest
 from click.testing import CliRunner
-from ruamel.yaml.comments import CommentedMap, CommentedSeq
+from ruamel.yaml.comments import CommentedMap
 
 from pennyfarthing_scripts.sprint.story_add import (
     add_story,
@@ -28,10 +27,8 @@ from pennyfarthing_scripts.sprint.story_add import (
 from pennyfarthing_scripts.sprint.yaml_io import (
     STORY_KEY_ORDER,
     read_sprint,
-    write_sprint,
 )
 
-
 # =============================================================================
 # Test Fixtures
 # =============================================================================
@@ -676,7 +673,6 @@ epics:
 """
         p = tmp_path / "current-sprint.yaml"
         p.write_text(yaml_content)
-        original_content = p.read_text()
 
         # Normal add should work fine
         result = add_story(
@@ -699,10 +695,10 @@ class TestCLIIntegration:
 
     def test_story_add_command_exists(self) -> None:
         """story_add_command should be importable and be a Click command."""
-        from pennyfarthing_scripts.sprint.story_add import story_add_command
-
         import click
 
+        from pennyfarthing_scripts.sprint.story_add import story_add_command
+
         assert isinstance(story_add_command, click.BaseCommand)
 
     def test_basic_add_via_cli(self, runner: CliRunner, sprint_file: Path) -> None:

package/pennyfarthing_scripts/tests/test_story_package.py

@@ -5,10 +5,7 @@ Story 63-9: Reorganize pennyfarthing_scripts into fan-out CLI pattern.
 These tests verify the story/ package modules work correctly.
 """
 
-from typing import Any
-from unittest.mock import patch
 
-import pytest
 
 
 class TestStorySizeModule:

package/pennyfarthing_scripts/tests/test_story_update.py

@@ -14,12 +14,10 @@ Acceptance Criteria:
 """
 
 from pathlib import Path
-from typing import Any
 from unittest.mock import patch
 
 import pytest
 from click.testing import CliRunner
-from ruamel.yaml.comments import CommentedMap
 
 from pennyfarthing_scripts.sprint.story_update import (
     update_story,
@@ -28,7 +26,6 @@ from pennyfarthing_scripts.sprint.yaml_io import (
     read_sprint,
 )
 
-
 # =============================================================================
 # Test Fixtures
 # =============================================================================
@@ -275,8 +272,6 @@ class TestUpdateStoryFields:
 
     def test_no_updates_provided(self, sprint_file: Path) -> None:
         """Calling with no field updates should succeed as a noop."""
-        original_content = sprint_file.read_text()
-
         result = update_story(
             sprint_path=sprint_file,
             story_id="76-3",
@@ -378,8 +373,8 @@ class TestFindStoryAcrossEpics:
 class TestAutoCleanup:
     """Auto-cleanup rules for status transitions."""
 
-    def test_done_removes_assigned_to(self, assigned_story_file: Path) -> None:
-        """Setting status=done should remove assigned_to."""
+    def test_done_preserves_assigned_to(self, assigned_story_file: Path) -> None:
+        """Setting status=done should preserve assigned_to (no auto-removal)."""
         result = update_story(
             sprint_path=assigned_story_file,
             story_id="76-1",
@@ -390,7 +385,7 @@ class TestAutoCleanup:
 
         data = read_sprint(assigned_story_file)
         story = data["epics"][0]["stories"][0]
-        assert "assigned_to" not in story
+        assert story["assigned_to"] == "kavery"
 
     def test_done_auto_sets_completed(self, assigned_story_file: Path) -> None:
         """Setting status=done should auto-set completed to today."""
@@ -611,10 +606,10 @@ class TestCLIIntegration:
 
     def test_update_command_exists(self) -> None:
         """story_update_command should be importable and be a Click command."""
-        from pennyfarthing_scripts.sprint.story_update import story_update_command
-
         import click
 
+        from pennyfarthing_scripts.sprint.story_update import story_update_command
+
         assert isinstance(story_update_command, click.BaseCommand)
 
     def test_basic_update_via_cli(self, runner: CliRunner, sprint_file: Path) -> None:

package/pennyfarthing_scripts/tests/test_tiers.py

@@ -12,11 +12,11 @@ Acceptance Criteria:
 - AC6: Token reduction verified: REFRESH ~600, HANDOFF ~700, MINIMAL ~200
 """
 
-import pytest
 from pathlib import Path
-from unittest.mock import patch, MagicMock
-import yaml
+from unittest.mock import patch
 
+import pytest
+import yaml
 
 # =============================================================================
 # AC1: --tier CLI Argument Tests
@@ -314,10 +314,9 @@ class TestCompressedPersonaFormat:
 
     def test_compressed_persona_has_xml_structure(self, tmp_path: Path) -> None:
         """Test compressed persona uses XML format."""
-        from pennyfarthing_scripts.prime.persona import format_persona_compressed
-
         # Import will fail until function is implemented
         from pennyfarthing_scripts.prime.models import Persona
+        from pennyfarthing_scripts.prime.persona import format_persona_compressed
 
         persona = Persona(
             character="Rosie the Riveter",
@@ -334,8 +333,8 @@ class TestCompressedPersonaFormat:
 
     def test_compressed_persona_includes_voice(self, tmp_path: Path) -> None:
         """Test compressed persona includes voice element."""
-        from pennyfarthing_scripts.prime.persona import format_persona_compressed
         from pennyfarthing_scripts.prime.models import Persona
+        from pennyfarthing_scripts.prime.persona import format_persona_compressed
 
         persona = Persona(
             character="Rosie the Riveter",
@@ -350,8 +349,8 @@ class TestCompressedPersonaFormat:
 
     def test_compressed_persona_includes_style(self, tmp_path: Path) -> None:
         """Test compressed persona includes style element."""
-        from pennyfarthing_scripts.prime.persona import format_persona_compressed
         from pennyfarthing_scripts.prime.models import Persona
+        from pennyfarthing_scripts.prime.persona import format_persona_compressed
 
         persona = Persona(
             character="Rosie the Riveter",
@@ -365,8 +364,8 @@ class TestCompressedPersonaFormat:
 
     def test_compressed_persona_includes_catchphrase_if_present(self, tmp_path: Path) -> None:
         """Test compressed persona includes catchphrase from quote."""
-        from pennyfarthing_scripts.prime.persona import format_persona_compressed
         from pennyfarthing_scripts.prime.models import Persona
+        from pennyfarthing_scripts.prime.persona import format_persona_compressed
 
         persona = Persona(
             character="Rosie the Riveter",
@@ -382,8 +381,8 @@ class TestCompressedPersonaFormat:
 
     def test_compressed_persona_token_count(self, tmp_path: Path) -> None:
         """Test compressed persona is approximately 100 tokens (~400 chars)."""
-        from pennyfarthing_scripts.prime.persona import format_persona_compressed
         from pennyfarthing_scripts.prime.models import Persona
+        from pennyfarthing_scripts.prime.persona import format_persona_compressed
 
         persona = Persona(
             character="Rosie the Riveter",
@@ -402,8 +401,8 @@ class TestCompressedPersonaFormat:
 
     def test_full_persona_token_count(self, tmp_path: Path) -> None:
         """Test full persona is approximately 300 tokens (~1200 chars)."""
+        from pennyfarthing_scripts.prime.models import CrewMember, Persona
         from pennyfarthing_scripts.prime.persona import format_persona_output
-        from pennyfarthing_scripts.prime.models import Persona, CrewMember
 
         persona = Persona(
             character="Rosie the Riveter",
@@ -509,9 +508,10 @@ class TestDefaultBehavior:
 
     def test_existing_flags_still_work_with_tier(self, tmp_path: Path, capsys) -> None:
         """Test existing flags (--quiet, --json, etc.) work with --tier."""
-        from pennyfarthing_scripts.prime.cli import prime
         import json
 
+        from pennyfarthing_scripts.prime.cli import prime
+
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
@@ -548,7 +548,7 @@ class TestTierLoadingPaths:
 
     def test_full_tier_with_all_options(self, tmp_path: Path) -> None:
         """Test FULL tier with all context sources available."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier
+        from pennyfarthing_scripts.prime.tiers import ContextTier, load_tier_components
 
         # Setup complete project
         self._setup_complete_project(tmp_path)
@@ -569,7 +569,7 @@ class TestTierLoadingPaths:
 
     def test_full_tier_with_missing_optional(self, tmp_path: Path) -> None:
         """Test FULL tier gracefully handles missing optional components."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier
+        from pennyfarthing_scripts.prime.tiers import ContextTier, load_tier_components
 
         # Minimal setup - only agent definition
         pf_dir = tmp_path / ".pennyfarthing"
@@ -590,7 +590,7 @@ class TestTierLoadingPaths:
 
     def test_refresh_tier_components(self, tmp_path: Path) -> None:
         """Test REFRESH tier returns correct component set."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier
+        from pennyfarthing_scripts.prime.tiers import ContextTier, load_tier_components
 
         self._setup_complete_project(tmp_path)
 
@@ -612,7 +612,7 @@ class TestTierLoadingPaths:
 
     def test_handoff_tier_components(self, tmp_path: Path) -> None:
         """Test HANDOFF tier returns correct component set."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier
+        from pennyfarthing_scripts.prime.tiers import ContextTier, load_tier_components
 
         self._setup_complete_project(tmp_path)
 
@@ -633,7 +633,7 @@ class TestTierLoadingPaths:
 
     def test_minimal_tier_components(self, tmp_path: Path) -> None:
         """Test MINIMAL tier returns minimal component set."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier
+        from pennyfarthing_scripts.prime.tiers import ContextTier, load_tier_components
 
         self._setup_complete_project(tmp_path)
 
@@ -990,9 +990,10 @@ class TestTierIntegration:
 
     def test_json_output_includes_tier(self, tmp_path: Path, capsys) -> None:
         """Test JSON output includes current tier."""
-        from pennyfarthing_scripts.prime.cli import prime
         import json
 
+        from pennyfarthing_scripts.prime.cli import prime
+
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
         agents_dir = pf_dir / "agents"