@pennyfarthing/core 10.0.5 → 10.1.0

package/README.md

@@ -1,6 +1,6 @@
 # Pennyfarthing
 
-**v10.0.5** | *The outer loop goes once, the inner loop goes many times.*
+**v10.1.0** | *The outer loop goes once, the inner loop goes many times.*
 
 <img src="pennyfarthing.png" alt="Pennyfarthing Logo" width="75" style="float:left; margin:10px">
 
@@ -15,8 +15,8 @@ A Claude Code agent orchestration framework built around three pillars: a flexib
 A multi-agent system with customizable BikeLane workflows for structured software development:
 
 - **10 Coordinated Agents** - SM, TEA, Dev, Reviewer, Architect, PM, Tech Writer, UX Designer, DevOps, Orchestrator
-- **8 BikeLane Workflows** - Phased (TDD, BDD, Trivial), Stepped (Architecture, Release, Git Cleanup)
-- **49 Slash Commands** - Entry points for agent activation and workflows
+- **9 BikeLane Workflows** - Phased (TDD, BDD, Trivial, 2pTDD), Stepped (Architecture, Release, Git Cleanup)
+- **50 Slash Commands** - Entry points for agent activation and workflows
 - **22 Skills** - Reusable knowledge domains (testing, code-review, jira, mermaid, etc.)
 - **Prime Context System** - Tiered context injection assembles agent definition, persona, session state, and sidecar memory
 - **Automatic Handoffs** - Context-aware agent transitions via subagent delegation
@@ -266,14 +266,16 @@ your-project/
     └── {story-id}-session.md # Active work session
 ```
 
-## What's New in v10.0.0
+## What's New in v10.1.0
 
-- **Clean Install Consolidation** - All managed files under `.pennyfarthing/` instead of scattered across `.claude/`, `.git/hooks/`, `.session/`. Legacy installs migrated automatically via `pennyfarthing update`
-- **Tool Use Approval System** - Hook-based permission flow with severity classification, grant persistence, agent-level scoping, and workflow presets. Replaces legacy IPC approval
-- **Smooth Plan Mode Exit** - Tirepump choice UI for transitioning out of plan mode
+- **Codebase Health Dashboard** — Health score gauge, dead code analysis, code markers, complexity metrics, and dependency tracking — all with Cyclist dialogs
+- **Tool Dialog System** — Shared ToolDialog component with standardized dialogs across all diagnostic tools
+- **2party-TDD Workflow** — New workflow for pair-programming TDD with review rejection loops
+- **Cross-File Reference Validator** — Detects broken references across agent definitions, workflows, skills, and guides
 
 ### Previous Highlights
 
+- **v10.0** - Clean install consolidation, tool use approval system, plan mode exit UI
 - **v9.3** - Theme packages (97 themes across 7 packs), release workflow, shadcn/ui migration
 - **v9.0** - Dockview panel system, React 19 rewrite, tool visualization, prime context, bell/relay modes
 - **v8.x** - BikeLane workflows, scientific benchmarking, JobFair, agent sidecars

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pennyfarthing/core",
-  "version": "10.0.5",
+  "version": "10.1.0",
   "description": "Claude Code agent framework with TDD workflow and persona system",
   "type": "module",
   "bin": {
@@ -30,6 +30,18 @@
   "bugs": {
     "url": "https://github.com/1898andCo/pennyfarthing/issues"
   },
+  "scripts": {
+    "prepublishOnly": "find pennyfarthing-dist/scripts -name '*.sh' ! -name 'find-root.sh' -exec chmod +x {} +",
+    "postinstall": "node scripts/postinstall.cjs",
+    "build": "pnpm --filter @pennyfarthing/shared build && pnpm --filter @pennyfarthing/core build && pnpm --filter @pennyfarthing/cyclist build && ./scripts/generate-skill-docs.sh",
+    "docs": "./scripts/generate-skill-docs.sh",
+    "dev": "pnpm -r --parallel dev",
+    "test": "pnpm -r test",
+    "lint": "eslint 'packages/*/src/**/*.ts' --max-warnings 0",
+    "validate:refs": "node scripts/validate-refs.js",
+    "test:validate-refs": "node --test scripts/validate-refs.test.js",
+    "clean": "pnpm -r clean"
+  },
   "dependencies": {
     "@pennyfarthing/shared": "^10.0.3",
     "chalk": "^5.3.0",
@@ -49,13 +61,5 @@
   "engines": {
     "node": ">=18.0.0"
   },
-  "scripts": {
-    "postinstall": "node scripts/postinstall.cjs",
-    "build": "pnpm --filter @pennyfarthing/shared build && pnpm --filter @pennyfarthing/core build && pnpm --filter @pennyfarthing/cyclist build && ./scripts/generate-skill-docs.sh",
-    "docs": "./scripts/generate-skill-docs.sh",
-    "dev": "pnpm -r --parallel dev",
-    "test": "pnpm -r test",
-    "lint": "eslint 'packages/*/src/**/*.ts' --max-warnings 0",
-    "clean": "pnpm -r clean"
-  }
-}
+  "packageManager": "pnpm@9.0.0"
+}

package/packages/core/dist/cli/commands/doctor.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"doctor.d.ts","sourceRoot":"","sources":["../../../src/cli/commands/doctor.ts"],"names":[],"mappings":"AAqBA,UAAU,aAAa;IACrB,GAAG,CAAC,EAAE,OAAO,CAAC;IACd,IAAI,CAAC,EAAE,OAAO,CAAC;IACf,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,OAAO,CAAC,EAAE,OAAO,CAAC;CACnB;AAED,MAAM,WAAW,WAAW;IAC1B,IAAI,EAAE,MAAM,CAAC;IACb,MAAM,EAAE,MAAM,GAAG,MAAM,GAAG,MAAM,CAAC;IACjC,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,GAAG,CAAC,EAAE,MAAM,IAAI,CAAC;CAClB;AAED,wBAAsB,aAAa,CAAC,OAAO,EAAE,aAAa,GAAG,OAAO,CAAC,IAAI,CAAC,CAoHzE;AAmyCD;;;GAGG;AACH,wBAAgB,gBAAgB,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,EAAE,CAgKnE;AAED;;;;;;GAMG;AACH,wBAAgB,yBAAyB,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,CAkF1E;AAED;;;;;;GAMG;AACH,wBAAgB,eAAe,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,EAAE,CAsIlE"}
+{"version":3,"file":"doctor.d.ts","sourceRoot":"","sources":["../../../src/cli/commands/doctor.ts"],"names":[],"mappings":"AAsBA,UAAU,aAAa;IACrB,GAAG,CAAC,EAAE,OAAO,CAAC;IACd,IAAI,CAAC,EAAE,OAAO,CAAC;IACf,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,OAAO,CAAC,EAAE,OAAO,CAAC;CACnB;AAED,MAAM,WAAW,WAAW;IAC1B,IAAI,EAAE,MAAM,CAAC;IACb,MAAM,EAAE,MAAM,GAAG,MAAM,GAAG,MAAM,CAAC;IACjC,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,GAAG,CAAC,EAAE,MAAM,IAAI,CAAC;CAClB;AAED,wBAAsB,aAAa,CAAC,OAAO,EAAE,aAAa,GAAG,OAAO,CAAC,IAAI,CAAC,CA2HzE;AA+iDD;;;GAGG;AACH,wBAAgB,gBAAgB,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,EAAE,CAgKnE;AAED;;;;;;GAMG;AACH,wBAAgB,yBAAyB,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,CAkF1E;AAED;;;;;;GAMG;AACH,wBAAgB,eAAe,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,EAAE,CAsIlE"}

package/packages/core/dist/cli/commands/doctor.js

@@ -10,14 +10,15 @@ import { pathExists, isDirectory, isSymlink, fileMatchesHash } from '../utils/fi
 import { getPackageVersion } from '../utils/version.js';
 import { findNodeModulesPath } from '../utils/node-modules.js';
 import { ALL_SYMLINKS, CORE_AGENTS } from '../utils/constants.js';
+import { getPfVersion, installPfCli } from '../utils/python.js';
 export async function doctorCommand(options) {
     const projectRoot = process.cwd();
-    // Handle dogfooding mode - run the dogfood script instead
+    // Handle dogfood mode - run checks for framework/orchestrator development
     if (options.dogfood) {
         const dogfoodScript = join(projectRoot, 'pennyfarthing-dist/scripts/misc/doctor-dogfood.sh');
         if (!existsSync(dogfoodScript)) {
-            logger.error('Dogfood mode requires the pennyfarthing repo (pennyfarthing-dist/ not found)');
-            logger.info('This flag is for developers working on pennyfarthing itself.');
+            logger.error('Dogfood mode requires pennyfarthing-dist/ (framework repo or orchestrator with inlined pennyfarthing/)');
+            logger.info('This flag is for framework development and orchestrator repos.');
             process.exit(1);
         }
         const args = options.fix ? ['--fix'] : [];
@@ -41,16 +42,20 @@ export async function doctorCommand(options) {
     logger.info(`Version: ${installedVersion} (installed) / ${packageVersion} (package)`);
     logger.info(`Mode: ${installationType}${installationType === 'symlink' ? ' (node_modules)' : ' (file copies)'}`);
     logger.newline();
+    // Resolve node_modules path for checks that need it
+    const nodeModulesPath = findNodeModulesPath(projectRoot);
     // Run checks
     results.push(...checkInstallation(projectRoot, manifest));
     results.push(...checkCoreFiles(projectRoot, manifest));
     results.push(...checkUserFiles(projectRoot));
     results.push(...checkDirectories(projectRoot));
     results.push(...checkHooks(projectRoot));
+    results.push(...checkGitHooks(projectRoot, nodeModulesPath));
     results.push(...checkFileLayout(projectRoot));
     results.push(...checkLegacyFiles(projectRoot));
     results.push(checkLegacyStatuslinePath(projectRoot));
     results.push(...checkCyclist(projectRoot));
+    results.push(checkPfCli(nodeModulesPath));
     // Output results
     if (options.json) {
         console.log(JSON.stringify(results, null, 2));
@@ -63,9 +68,11 @@ export async function doctorCommand(options) {
         { name: 'User Files', filter: (r) => r.name.startsWith('project/') || r.name.startsWith('persona') || r.name.startsWith('settings') },
         { name: 'Directories', filter: (r) => r.name.startsWith('dir/') },
         { name: 'Hooks', filter: (r) => r.name.startsWith('hook/') },
+        { name: 'Git Hooks', filter: (r) => r.name.startsWith('git-hook/') },
         { name: 'File Layout', filter: (r) => r.name.startsWith('layout/') },
         { name: 'Legacy Files', filter: (r) => r.name.startsWith('legacy/') },
-        { name: 'Cyclist', filter: (r) => r.name.startsWith('cyclist/') }
+        { name: 'Cyclist', filter: (r) => r.name.startsWith('cyclist/') },
+        { name: 'Tools', filter: (r) => r.name.startsWith('tools/') }
     ];
     for (const category of categories) {
         const categoryResults = results.filter(category.filter);
@@ -314,6 +321,9 @@ function checkUserFiles(projectRoot) {
         // Check SessionStart hooks are configured (critical for PROJECT_ROOT)
         const hookCheck = checkSessionStartHooks(projectRoot, installationType);
         results.push(hookCheck);
+        // Check auto-load-sm hook is configured (auto-invokes /sm on new sessions)
+        const autoLoadSmCheck = checkAutoLoadSmHook(projectRoot);
+        results.push(autoLoadSmCheck);
         // Check Stop hook is configured (question reflector enforcement)
         const stopHookCheck = checkStopHook(projectRoot, installationType);
         results.push(stopHookCheck);
@@ -462,6 +472,133 @@ function checkSessionStartHooks(projectRoot, installationType) {
         };
     }
 }
+/**
+ * Check that auto-load-sm hook is configured in SessionStart
+ * This auto-invokes /sm agent on new session start
+ */
+function checkAutoLoadSmHook(projectRoot) {
+    const settingsPath = join(projectRoot, '.claude/settings.local.json');
+    try {
+        const settings = JSON.parse(readFileSync(settingsPath, 'utf8'));
+        if (!settings.hooks?.SessionStart) {
+            return {
+                name: 'settings/auto-load-sm',
+                status: 'warn',
+                detail: 'Missing SessionStart hooks - auto-load-sm not configured',
+                fix: () => {
+                    addAutoLoadSmHook(projectRoot);
+                }
+            };
+        }
+        const hasAutoLoadSm = settings.hooks.SessionStart.some((entry) => {
+            if (typeof entry === 'object' && entry !== null) {
+                const hookEntry = entry;
+                return hookEntry.hooks?.some(h => h.command?.includes('auto-load-sm'));
+            }
+            return false;
+        });
+        if (!hasAutoLoadSm) {
+            return {
+                name: 'settings/auto-load-sm',
+                status: 'warn',
+                detail: 'auto-load-sm not configured - /sm will not auto-invoke on startup',
+                fix: () => {
+                    addAutoLoadSmHook(projectRoot);
+                }
+            };
+        }
+        // Also check that the hook script file exists
+        const hookScript = join(projectRoot, '.pennyfarthing/project/hooks/auto-load-sm.sh');
+        if (!pathExists(hookScript)) {
+            return {
+                name: 'settings/auto-load-sm',
+                status: 'warn',
+                detail: 'Hook registered but script missing at .pennyfarthing/project/hooks/auto-load-sm.sh',
+                fix: () => {
+                    ensureDirSync(dirname(hookScript));
+                    writeFileSync(hookScript, `#!/usr/bin/env bash
+# Auto-load /sm agent on new session start
+set -euo pipefail
+
+cat <<'HOOKEOF'
+{
+  "hookSpecificOutput": {
+    "hookEventName": "SessionStart",
+    "additionalContext": "IMPORTANT: Auto-invoke the /sm agent immediately. Run the Skill tool with skill: \\"sm\\" as your first action. Do not greet the user or do anything else first."
+  }
+}
+HOOKEOF
+`, { mode: 0o755 });
+                }
+            };
+        }
+        return {
+            name: 'settings/auto-load-sm',
+            status: 'pass',
+            detail: undefined
+        };
+    }
+    catch {
+        return {
+            name: 'settings/auto-load-sm',
+            status: 'warn',
+            detail: 'Could not parse settings.local.json'
+        };
+    }
+}
+/**
+ * Fix function: Add auto-load-sm hook to SessionStart in settings.local.json
+ */
+function addAutoLoadSmHook(projectRoot) {
+    const settingsPath = join(projectRoot, '.claude/settings.local.json');
+    const requiredHook = {
+        matcher: 'startup',
+        hooks: [
+            {
+                type: 'command',
+                command: '"$CLAUDE_PROJECT_DIR"/.pennyfarthing/project/hooks/auto-load-sm.sh'
+            }
+        ]
+    };
+    let settings = {};
+    if (pathExists(settingsPath)) {
+        try {
+            settings = JSON.parse(readFileSync(settingsPath, 'utf8'));
+        }
+        catch {
+            // Start fresh if parse fails
+        }
+    }
+    if (!settings.hooks) {
+        settings.hooks = {};
+    }
+    const hooks = settings.hooks;
+    if (!hooks.SessionStart) {
+        hooks.SessionStart = [requiredHook];
+    }
+    else if (Array.isArray(hooks.SessionStart)) {
+        hooks.SessionStart = [...hooks.SessionStart, requiredHook];
+    }
+    writeFileSync(settingsPath, JSON.stringify(settings, null, 2), 'utf8');
+    // Also ensure the hook script exists
+    const hookScript = join(projectRoot, '.pennyfarthing/project/hooks/auto-load-sm.sh');
+    if (!pathExists(hookScript)) {
+        ensureDirSync(dirname(hookScript));
+        writeFileSync(hookScript, `#!/usr/bin/env bash
+# Auto-load /sm agent on new session start
+set -euo pipefail
+
+cat <<'HOOKEOF'
+{
+  "hookSpecificOutput": {
+    "hookEventName": "SessionStart",
+    "additionalContext": "IMPORTANT: Auto-invoke the /sm agent immediately. Run the Skill tool with skill: \\"sm\\" as your first action. Do not greet the user or do anything else first."
+  }
+}
+HOOKEOF
+`, { mode: 0o755 });
+    }
+}
 /**
  * Check that Stop hook is properly configured in settings.local.json
  * This is needed for question reflector enforcement in Cyclist
@@ -936,6 +1073,15 @@ function addSessionStartHooks(projectRoot, installationType) {
                     command: '"$CLAUDE_PROJECT_DIR"/.pennyfarthing/project/hooks/setup-env.sh'
                 }
             ]
+        },
+        {
+            matcher: 'startup',
+            hooks: [
+                {
+                    type: 'command',
+                    command: '"$CLAUDE_PROJECT_DIR"/.pennyfarthing/project/hooks/auto-load-sm.sh'
+                }
+            ]
         }
     ];
     let settings = {};
@@ -1021,6 +1167,15 @@ function createSettingsLocalJson(projectRoot, installationType) {
                             command: '"$CLAUDE_PROJECT_DIR"/.pennyfarthing/project/hooks/setup-env.sh'
                         }
                     ]
+                },
+                {
+                    matcher: 'startup',
+                    hooks: [
+                        {
+                            type: 'command',
+                            command: '"$CLAUDE_PROJECT_DIR"/.pennyfarthing/project/hooks/auto-load-sm.sh'
+                        }
+                    ]
                 }
             ],
             PostToolUse: [
@@ -1158,6 +1313,74 @@ function checkHooks(projectRoot) {
     }
     return results;
 }
+/**
+ * Check git hooks in .git/hooks/ are up-to-date with package source.
+ * Detects stale copies that were installed by `pennyfarthing init` but never refreshed.
+ * Provides --fix to overwrite stale hooks with current package content.
+ */
+function checkGitHooks(projectRoot, nodeModulesPath) {
+    const results = [];
+    const gitHooksDir = join(projectRoot, '.git/hooks');
+    if (!pathExists(gitHooksDir)) {
+        return results;
+    }
+    if (!nodeModulesPath) {
+        return results;
+    }
+    const hooks = [
+        { source: 'pre-commit.sh', dest: 'pre-commit', marker: 'pennyfarthing' },
+        { source: 'pre-push.sh', dest: 'pre-push', marker: 'pennyfarthing' },
+        { source: 'post-merge.sh', dest: 'post-merge', marker: 'pennyfarthing' },
+    ];
+    for (const hook of hooks) {
+        const sourcePath = join(nodeModulesPath, 'scripts/hooks', hook.source);
+        const destPath = join(gitHooksDir, hook.dest);
+        if (!pathExists(sourcePath)) {
+            continue;
+        }
+        if (!pathExists(destPath)) {
+            results.push({
+                name: `git-hook/${hook.dest}`,
+                status: 'warn',
+                detail: 'Not installed',
+                fix: () => {
+                    const content = readFileSync(sourcePath, 'utf8');
+                    writeFileSync(destPath, content, { mode: 0o755 });
+                }
+            });
+            continue;
+        }
+        const existingContent = readFileSync(destPath, 'utf8');
+        // Only check hooks that are ours (contain the marker)
+        if (!existingContent.includes(hook.marker)) {
+            results.push({
+                name: `git-hook/${hook.dest}`,
+                status: 'pass',
+                detail: 'Custom (non-pennyfarthing)'
+            });
+            continue;
+        }
+        const sourceContent = readFileSync(sourcePath, 'utf8');
+        if (existingContent === sourceContent) {
+            results.push({
+                name: `git-hook/${hook.dest}`,
+                status: 'pass',
+                detail: undefined
+            });
+        }
+        else {
+            results.push({
+                name: `git-hook/${hook.dest}`,
+                status: 'warn',
+                detail: 'Stale — content differs from package',
+                fix: () => {
+                    writeFileSync(destPath, sourceContent, { mode: 0o755 });
+                }
+            });
+        }
+    }
+    return results;
+}
 /**
  * Check Cyclist installation health (if installed as a workspace package)
  * Detects node-pty spawn-helper permission issues that cause posix_spawnp failures
@@ -1260,6 +1483,30 @@ function checkCyclist(projectRoot) {
     }
     return results;
 }
+/**
+ * Check if the pf CLI is installed and working.
+ * The pf CLI is required for agent commands (e.g., `pf agent start "dev"`).
+ */
+function checkPfCli(nodeModulesPath) {
+    const version = getPfVersion();
+    if (version) {
+        return {
+            name: 'tools/pf-cli',
+            status: 'pass',
+            detail: version
+        };
+    }
+    return {
+        name: 'tools/pf-cli',
+        status: 'warn',
+        detail: 'pf CLI not found — agent commands will not work',
+        fix: () => {
+            if (!installPfCli(nodeModulesPath)) {
+                throw new Error('Neither uv nor pipx available. Install manually: uv tool install pennyfarthing-scripts');
+            }
+        }
+    };
+}
 /**
  * Known legacy statusline paths from various Pennyfarthing versions.
  * These should be detected and cleaned up when proper statusline exists.