@penkov/swagger-code-gen 1.11.1 → 1.12.0

package/AGENTS.md

@@ -0,0 +1,34 @@
+# Repository Guidelines
+
+## Project Structure & Module Organization
+- Core TypeScript sources live in `src/` (CLI in `src/cli.mjs`, generators in `src/openapi.ts`, `src/renderer.ts`, helpers in `src/name.utils.ts`, etc.).
+- Handlebars/EJS-style templates for emitted clients are under `src/templates/`; they are copied to `dist/templates/` during build.
+- Built artifacts output to `dist/` (ESM). Keep `dist/` out of PR diffs unless you're publishing.
+- Temporary outputs from local runs can go in `tmp/`; avoid committing generated clients.
+
+## Build, Test, and Development Commands
+- `npm run lint` — ESLint over `src/**/*.ts`; fixes simple style issues.
+- `npm run build` — Type-checks with `tsc`, lints, cleans `dist/`, copies templates, and makes the CLI executable.
+- `npm run test:petstore` — Integration sanity check that generates a client from the public Petstore spec into `tmp/petstore.ts`.
+- Local usage example while developing: `node --loader ts-node/esm ./src/cli.mjs --url <openapi.json> --targetNode tmp/client.ts`.
+
+## Coding Style & Naming Conventions
+- TypeScript, ESM (`"type": "module"`). Prefer `export`/`import` syntax and avoid CommonJS.
+- Indentation: 2 spaces; keep lines concise and avoid trailing whitespace.
+- Naming: PascalCase for types/interfaces/classes; camelCase for functions/variables; kebab-case for filenames (`method.ts`, `components-parse.ts`).
+- Keep pure generation logic inside `src/` modules; CLI wiring belongs in `src/cli.mjs`.
+- Run `npm run lint` before pushing; configure editors to respect the repo’s ESLint/TypeScript settings (`tsconfig.json`, `tsconfig-eslint.json`).
+
+## Testing Guidelines
+- Primary check is code generation parity; use `npm run test:petstore` after generator changes to ensure emitted code compiles and fetch imports are wired when `--targetNode` is used.
+- When adding new parsing/rendering logic, add a minimal fixture OpenAPI snippet under `tmp/` (ignored) and exercise `src/cli.mjs` with `ts-node` to confirm types render as expected.
+- Prefer assertions in future tests under `test/` with `ts-node` if you add unit coverage; mirror file names of the modules under test.
+
+## Commit & Pull Request Guidelines
+- Follow existing history: `release: x.y.z` for version bumps; otherwise use `type: short-description` (e.g., `fix: handle nullable refs`, `feat: add tag filter`).
+- Keep PRs small and scoped (parser vs renderer vs CLI). Describe the OpenAPI inputs you validated against and attach generated output snippets when relevant.
+- Link issues when applicable; include reproduction steps for bugs and the exact CLI command used.
+
+## Security & Configuration Tips
+- Treat remote specs as untrusted; prefer HTTPS URLs and avoid embedding secrets in command examples.
+- Generated clients may import `node-fetch` when `--targetNode` is passed; ensure the consumer installs it if targeting Node.

package/dist/components-parse.js

@@ -91,12 +91,8 @@ export function resolvePaths(json, schemasTypes, options, pool) {
 export function generateInPlace(paths, schemasTypes, options, pool) {
     const collectInplaceFromProperty = (p) => {
         if (p.inPlace.isDefined) {
-            if (p.type === 'array') {
-                return Collection.of(SchemaObject.fromDefinition(p.items, p.inPlace.get, schemasTypes, options, pool));
-            }
-            else {
-                return Collection.of(SchemaObject.fromDefinition(p.type, p.inPlace.get, schemasTypes, options, pool));
-            }
+            const targetType = p.isArray ? p.items : p.type;
+            return Collection.of(SchemaObject.fromDefinition(targetType, p.inPlace.get, schemasTypes, options, pool));
         }
         else {
             return Nil;
@@ -120,7 +116,8 @@ export function generateInPlace(paths, schemasTypes, options, pool) {
     let pending = res.toCollection.flatMap(s => s.properties).filter(p => p.inPlace.isDefined);
     while (pending.nonEmpty) {
         const pass2 = pending.map(p => {
-            return SchemaObject.fromDefinition(p.type, p.inPlace.get, schemasTypes, options, pool);
+            const targetType = p.isArray ? p.items : p.type;
+            return SchemaObject.fromDefinition(targetType, p.inPlace.get, schemasTypes, options, pool);
         });
         res.appendAll(pass2);
         pending = pass2.flatMap(s => s.properties).filter(p => p.inPlace.isDefined);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@penkov/swagger-code-gen",
-  "version": "1.11.1",
+  "version": "1.12.0",
   "type": "module",
   "bin": {
     "generate-client": "./dist/cli.mjs"