@pendle/core-v2 2.8.0-mainnet → 2.8.2-mainnet

package/contracts/core/StandardizedYield/implementations/BalancerStable/base/PendleAuraBalancerStableLPSYV2.sol

@@ -21,6 +21,7 @@ abstract contract PendleAuraBalancerStableLPSYV2 is SYBaseWithRewards {
     address internal constant AURA_TOKEN = 0xC0c293ce456fF0ED870ADd98a0828Dd4d2903DBF;
     address internal constant AURA_BOOSTER = 0xA57b8d98dAE62B26Ec3bcC4a365338157060B234;
     address internal constant BALANCER_VAULT = 0xBA12222222228d8Ba445958a75a0704d566BF2C8;
+    uint256 internal constant DEFAULT_GAS_REENTRANCY_CHECK = 7000;
 
     address public immutable balLp;
     bytes32 public immutable balPoolId;
@@ -30,6 +31,7 @@ abstract contract PendleAuraBalancerStableLPSYV2 is SYBaseWithRewards {
 
     IBalancerStablePreview public immutable previewHelper;
 
+    uint256 public gasForReentrancyCheck;
     address[] public extraRewards;
 
     constructor(
@@ -53,6 +55,7 @@ abstract contract PendleAuraBalancerStableLPSYV2 is SYBaseWithRewards {
         }
 
         previewHelper = _previewHelper;
+        gasForReentrancyCheck = DEFAULT_GAS_REENTRANCY_CHECK;
     }
 
     function _getPoolInfo(uint256 _auraPid)
@@ -108,19 +111,32 @@ abstract contract PendleAuraBalancerStableLPSYV2 is SYBaseWithRewards {
         return IRateProvider(balLp).getRate();
     }
 
-    /// @dev The `manageUserBalance` function is a non-view function that includes a reentrancy guard.
-    /// When it is called by `staticcall`, one of two cases can occur:
-    /// 1. The function passes the reentrancy guard. In this scenario, the `status` variable is set to 2,
-    /// causing the EVM to panic (since the sub-call is a `staticcall`), resulting in a revert with
-    /// no response (i.e., `response.length == 0`).
-    /// 2. The function does not pass the reentrancy guard. In this situation, it reverts due to
-    /// error `BAL#400`, which means that `response.length = 100.`
-    /// To prevent read-only reentrancy, we simply need to verify that the revert corresponds to case 1,
-    /// rather than case 2. checking `response.length == 0` is sufficient.
+    /*
+    * The `manageUserBalance` function is a non-view function that includes a reentrancy guard
+        in the form of `_require(_status != _ENTERED, Errors.REENTRANCY);`. To prevent
+        read-only reentrancy, it's important to ensure that our `manageUserBalance` has enough gas
+        to reach this check, so that it can fail if necessary.
+
+    * On the way to the check, there's at most one `COLD_SLOAD` plus miscellaneous decoding &
+        require, which we've found through testing to cost no more than 3200 gas. Therefore,
+        attaching 7000 gas should guarantee that it's always possible to reach the check.
+
+    * Once we've reached the check, one of two scenarios can occur:
+    1. The call doesn't pass the check, and reverts with error `BAL#400` ⇒ `response.length = 100`.
+    2. The call passes the check. Then, the call can either:
+        a. continue on to set the `status` variable to 2, causing the EVM to revert (since
+        the sub-call is a `staticcall`), and `response.length == 0`
+        b. run out of gas, which will also lead to a revert with `response.length == 0`
+    In both cases, to differentiate between 1 and 2, we check `response.length != 0`. If it's
+    true, then it's a read-only reentrancy. Otherwise, we're good (and we can ignore
+    differentiating between 2a and 2b).
+    */
     function _checkBalancerReadOnlyReentrancy() internal view {
         IVault.UserBalanceOp[] memory noop = new IVault.UserBalanceOp[](0);
 
-        (bool isSuccess, bytes memory response) = BALANCER_VAULT.staticcall(
+        (bool isSuccess, bytes memory response) = BALANCER_VAULT.staticcall{
+            gas: gasForReentrancyCheck
+        }(
             abi.encodeWithSignature(
                 "manageUserBalance((uint8,address,uint256,address,address)[])",
                 noop
@@ -131,6 +147,11 @@ abstract contract PendleAuraBalancerStableLPSYV2 is SYBaseWithRewards {
         if (response.length != 0) revert Errors.SYBalancerReentrancy();
     }
 
+    function setGasForReentrancyCheck(uint256 newGas) external onlyOwner {
+        require(newGas >= DEFAULT_GAS_REENTRANCY_CHECK, "lower than default");
+        gasForReentrancyCheck = newGas;
+    }
+
     /*///////////////////////////////////////////////////////////////
                     BALANCER-RELATED FUNCTIONS
     //////////////////////////////////////////////////////////////*/

package/contracts/offchain-helpers/PendleMulticallV1.sol

@@ -0,0 +1,61 @@
+// SPDX-License-Identifier: MIT
+pragma solidity 0.8.17;
+
+contract PendleMulticallV1 {
+    struct Call {
+        address target;
+        bytes callData;
+    }
+
+    struct Result {
+        bool success;
+        bytes returnData;
+    }
+
+    function aggregate(Call[] calldata calls) public payable virtual {
+        uint256 length = calls.length;
+        Call calldata call;
+        for (uint256 i = 0; i < length; ) {
+            call = calls[i];
+
+            (bool success, bytes memory resp) = call.target.call(call.callData);
+            if (!success) {
+                assembly {
+                    revert(add(32, resp), mload(resp))
+                }
+            }
+
+            unchecked {
+                ++i;
+            }
+        }
+    }
+
+    function tryAggregate(
+        bool requireSuccess,
+        uint256 gasLimit,
+        Call[] calldata calls
+    ) public payable returns (Result[] memory returnData) {
+        uint256 length = calls.length;
+        returnData = new Result[](length);
+        Call calldata call;
+        for (uint256 i = 0; i < length; ) {
+            call = calls[i];
+
+            (bool success, bytes memory resp) = call.target.call{ gas: gasLimit }(
+                calls[i].callData
+            );
+            if (!success && requireSuccess) {
+                assembly {
+                    revert(add(32, resp), mload(resp))
+                }
+            }
+
+            returnData[i] = Result(success, resp);
+
+            unchecked {
+                ++i;
+            }
+        }
+    }
+}

package/deployments/1-markets/BALANCER-LP-AURA-STAFI-RETH-WETH-JUNE-27-2024.json

@@ -1,11 +1,11 @@
 {
     "name": "SY Stafi rETH-WETH_BalancerLP Aura",
-    "SY": "0x35BE86140EEC53Da42C265ae764E547df13891c3",
-    "YT": "0xa57FEEDBd31F4ebD7761d5c3aeED7DeCCb8F95eE",
-    "PT": "0x1abfE281466Dc43Ba5e2A7282661735c00BF82DE",
-    "market": "0xB15a55519dBc3D770ddED079ebcDeEea69A49AdE",
+    "SY": "0x677885afde857b70f40741ff8B60F9aFbA95Dd49",
+    "YT": "0xCfD3A9e44957D5996663b58B69A79978CcFa778f",
+    "PT": "0xF77205F5A1eEab54555B13B231fa5e4e0Cf2fC1c",
+    "market": "0xd1434df1E2Ad0Cb7B3701a751D01981c7Cf2Dd62",
     "expiry": 1719446400,
-    "bulkSeller": "0x6C4aC4B209Cc57B019b83F6771794D3C73BC47Af",
+    "bulkSeller": "0xD7c9e1B4f21cA8e192d831496f09938b4eda7790",
     "scalarRoot": "25304300000000000000",
     "initAnchor": "1139984000000000000"
 }

package/deployments/1-offchain-helper.json

@@ -1,4 +1,4 @@
 {
-    "multicall": "0x0E7cacc6C2A22Aa2D97a42a8C82edaF9F9eac259",
+    "multicall": "0xfd6Df9EFACfEfdF4E610d687A9c9b941D1b1Bf75",
     "implicitSwapfeeContract": "0x43D03031FAb845065e9CEfE89Dd122d63F72011F"
 }

package/deployments/42161-core.json

@@ -19,9 +19,9 @@
     "marketFactory": "0xf5a7De2D276dbda3EEf1b62A9E718EFf4d29dDC8",
     "router": "0x0000000001e4ef00d069e71d6ba041b0a16f7ea0",
     "routerStatic": "0xAdB09F65bd90d19e3148D9ccb693F3161C6DB3E8",
-    "pendleSwap": "0xDa78D46C4133EA548386e64eaca26FC456F71D2d",
+    "pendleSwap": "0xF0bF560F01d4196773a5c58A09d6D34b6bba4503",
+    "routerHelper": "0x462206b11d185ef6F64B41D344325401C37EC335",
     "receiverEndpoint": "0xC9215ae9EC67385F38C755D862C8eE3702B5793A",
     "vePendle": "0x3209E9412cca80B18338f2a56ADA59c484c39644",
-    "gaugeController": "0x1e56299ebc8a1010cec26005d12e3e5c5cc2db00",
-    "routerHelper": "0x462206b11d185ef6F64B41D344325401C37EC335"
+    "gaugeController": "0x1e56299ebc8a1010cec26005d12e3e5c5cc2db00"
 }

package/deployments/42161-offchain-helper.json

@@ -1,4 +1,4 @@
 {
-    "multicall": "0x05d0Ea1dBFA239f9fBC47E306e850Ce971Fe632d",
+    "multicall": "0xfd6Df9EFACfEfdF4E610d687A9c9b941D1b1Bf75",
     "implicitSwapfeeContract": "0x704478Dd72FD7F9B83d1F1e0fc18C14B54F034d0"
 }

package/package.json

@@ -2,7 +2,7 @@
   "name": "@pendle/core-v2",
   "description": "Core smart contracts of Pendle Protocol.",
   "license": "BUSL-1.1",
-  "version": "2.8.0-mainnet",
+  "version": "2.8.2-mainnet",
   "homepage": "https://pendle.finance",
   "keywords": [
     "pendle",