@pendle/core-v2 2.7.0-mainnet → 2.8.0-mainnet

package/contracts/core/StandardizedYield/implementations/BalancerStable/base/{PendleAuraBalancerStableLPSY.sol → PendleAuraBalancerStableLPSYV2.sol}

@@ -14,13 +14,13 @@ import "./StablePoolUserData.sol";
 import "../../../../libraries/ArrayLib.sol";
 import "../../../SYBaseWithRewards.sol";
 
-abstract contract PendleAuraBalancerStableLPSY is SYBaseWithRewards {
+abstract contract PendleAuraBalancerStableLPSYV2 is SYBaseWithRewards {
     using ArrayLib for address[];
 
-    address public constant BAL_TOKEN = 0xba100000625a3754423978a60c9317c58a424e3D;
-    address public constant AURA_TOKEN = 0xC0c293ce456fF0ED870ADd98a0828Dd4d2903DBF;
-    address public constant AURA_BOOSTER = 0xA57b8d98dAE62B26Ec3bcC4a365338157060B234;
-    address public constant BALANCER_VAULT = 0xBA12222222228d8Ba445958a75a0704d566BF2C8;
+    address internal constant BAL_TOKEN = 0xba100000625a3754423978a60c9317c58a424e3D;
+    address internal constant AURA_TOKEN = 0xC0c293ce456fF0ED870ADd98a0828Dd4d2903DBF;
+    address internal constant AURA_BOOSTER = 0xA57b8d98dAE62B26Ec3bcC4a365338157060B234;
+    address internal constant BALANCER_VAULT = 0xBA12222222228d8Ba445958a75a0704d566BF2C8;
 
     address public immutable balLp;
     bytes32 public immutable balPoolId;
@@ -55,9 +55,11 @@ abstract contract PendleAuraBalancerStableLPSY is SYBaseWithRewards {
         previewHelper = _previewHelper;
     }
 
-    function _getPoolInfo(
-        uint256 _auraPid
-    ) internal view returns (address _auraLp, address _auraRewardManager) {
+    function _getPoolInfo(uint256 _auraPid)
+        internal
+        view
+        returns (address _auraLp, address _auraRewardManager)
+    {
         if (_auraPid > IBooster(AURA_BOOSTER).poolLength()) revert Errors.SYBalancerInvalidPid();
         (_auraLp, , , _auraRewardManager, , ) = IBooster(AURA_BOOSTER).poolInfo(_auraPid);
     }
@@ -69,10 +71,12 @@ abstract contract PendleAuraBalancerStableLPSY is SYBaseWithRewards {
     /**
      * @notice Either wraps LP, or also joins pool using exact tokenIn
      */
-    function _deposit(
-        address tokenIn,
-        uint256 amount
-    ) internal virtual override returns (uint256 amountSharesOut) {
+    function _deposit(address tokenIn, uint256 amount)
+        internal
+        virtual
+        override
+        returns (uint256 amountSharesOut)
+    {
         if (tokenIn == balLp) {
             amountSharesOut = amount;
         } else {
@@ -100,17 +104,42 @@ abstract contract PendleAuraBalancerStableLPSY is SYBaseWithRewards {
     }
 
     function exchangeRate() external view override returns (uint256) {
+        _checkBalancerReadOnlyReentrancy();
         return IRateProvider(balLp).getRate();
     }
 
+    /// @dev The `manageUserBalance` function is a non-view function that includes a reentrancy guard.
+    /// When it is called by `staticcall`, one of two cases can occur:
+    /// 1. The function passes the reentrancy guard. In this scenario, the `status` variable is set to 2,
+    /// causing the EVM to panic (since the sub-call is a `staticcall`), resulting in a revert with
+    /// no response (i.e., `response.length == 0`).
+    /// 2. The function does not pass the reentrancy guard. In this situation, it reverts due to
+    /// error `BAL#400`, which means that `response.length = 100.`
+    /// To prevent read-only reentrancy, we simply need to verify that the revert corresponds to case 1,
+    /// rather than case 2. checking `response.length == 0` is sufficient.
+    function _checkBalancerReadOnlyReentrancy() internal view {
+        IVault.UserBalanceOp[] memory noop = new IVault.UserBalanceOp[](0);
+
+        (bool isSuccess, bytes memory response) = BALANCER_VAULT.staticcall(
+            abi.encodeWithSignature(
+                "manageUserBalance((uint8,address,uint256,address,address)[])",
+                noop
+            )
+        );
+
+        assert(!isSuccess);
+        if (response.length != 0) revert Errors.SYBalancerReentrancy();
+    }
+
     /*///////////////////////////////////////////////////////////////
                     BALANCER-RELATED FUNCTIONS
     //////////////////////////////////////////////////////////////*/
 
-    function _depositToBalancer(
-        address tokenIn,
-        uint256 amountTokenToDeposit
-    ) internal virtual returns (uint256) {
+    function _depositToBalancer(address tokenIn, uint256 amountTokenToDeposit)
+        internal
+        virtual
+        returns (uint256)
+    {
         IVault.JoinPoolRequest memory request = _assembleJoinRequest(
             tokenIn,
             amountTokenToDeposit
@@ -121,10 +150,12 @@ abstract contract PendleAuraBalancerStableLPSY is SYBaseWithRewards {
         return _selfBalance(balLp);
     }
 
-    function _assembleJoinRequest(
-        address tokenIn,
-        uint256 amountTokenToDeposit
-    ) internal view virtual returns (IVault.JoinPoolRequest memory request) {
+    function _assembleJoinRequest(address tokenIn, uint256 amountTokenToDeposit)
+        internal
+        view
+        virtual
+        returns (IVault.JoinPoolRequest memory request)
+    {
         // max amounts in
         address[] memory assets = _getPoolTokenAddresses();
 
@@ -166,10 +197,12 @@ abstract contract PendleAuraBalancerStableLPSY is SYBaseWithRewards {
         return balanceAfter - balanceBefore;
     }
 
-    function _assembleExitRequest(
-        address tokenOut,
-        uint256 amountLpToRedeem
-    ) internal view virtual returns (IVault.ExitPoolRequest memory request) {
+    function _assembleExitRequest(address tokenOut, uint256 amountLpToRedeem)
+        internal
+        view
+        virtual
+        returns (IVault.ExitPoolRequest memory request)
+    {
         address[] memory assets = _getPoolTokenAddresses();
         uint256[] memory minAmountsOut = new uint256[](assets.length);
 
@@ -201,10 +234,13 @@ abstract contract PendleAuraBalancerStableLPSY is SYBaseWithRewards {
                    PREVIEW FUNCTIONS
     //////////////////////////////////////////////////////////////*/
 
-    function _previewDeposit(
-        address tokenIn,
-        uint256 amountTokenToDeposit
-    ) internal view virtual override returns (uint256 amountSharesOut) {
+    function _previewDeposit(address tokenIn, uint256 amountTokenToDeposit)
+        internal
+        view
+        virtual
+        override
+        returns (uint256 amountSharesOut)
+    {
         if (tokenIn == balLp) {
             amountSharesOut = amountTokenToDeposit;
         } else {
@@ -222,10 +258,13 @@ abstract contract PendleAuraBalancerStableLPSY is SYBaseWithRewards {
         }
     }
 
-    function _previewRedeem(
-        address tokenOut,
-        uint256 amountSharesToRedeem
-    ) internal view virtual override returns (uint256 amountTokenOut) {
+    function _previewRedeem(address tokenOut, uint256 amountSharesToRedeem)
+        internal
+        view
+        virtual
+        override
+        returns (uint256 amountTokenOut)
+    {
         if (tokenOut == balLp) {
             amountTokenOut = amountSharesToRedeem;
         } else {
@@ -303,7 +342,11 @@ abstract contract PendleAuraBalancerStableLPSY is SYBaseWithRewards {
     function assetInfo()
         external
         view
-        returns (AssetType assetType, address assetAddress, uint8 assetDecimals)
+        returns (
+            AssetType assetType,
+            address assetAddress,
+            uint8 assetDecimals
+        )
     {
         return (AssetType.LIQUIDITY, balLp, IERC20Metadata(balLp).decimals());
     }

package/contracts/core/libraries/Errors.sol

@@ -116,6 +116,8 @@ library Errors {
 
     error SYStargateRedeemCapExceeded(uint256 amountLpDesired, uint256 amountLpRedeemable);
 
+    error SYBalancerReentrancy();
+
     // Liquidity Mining
     error VCInactivePool(address pool);
     error VCPoolAlreadyActive(address pool);

package/contracts/interfaces/Balancer/IVault.sol

@@ -5,6 +5,21 @@ import "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import "./IAsset.sol";
 
 interface IVault {
+    enum UserBalanceOpKind {
+        DEPOSIT_INTERNAL,
+        WITHDRAW_INTERNAL,
+        TRANSFER_INTERNAL,
+        TRANSFER_EXTERNAL
+    }
+
+    struct UserBalanceOp {
+        UserBalanceOpKind kind;
+        IAsset asset;
+        uint256 amount;
+        address sender;
+        address payable recipient;
+    }
+
     struct JoinPoolRequest {
         address[] assets;
         uint256[] maxAmountsIn;
@@ -61,12 +76,14 @@ interface IVault {
         uint256 deadline
     ) external payable returns (uint256);
 
-    function getPoolTokens(
-        bytes32 poolId
-    )
+    function getPoolTokens(bytes32 poolId)
         external
         view
-        returns (IERC20[] memory tokens, uint256[] memory balances, uint256 lastChangeBlock);
+        returns (
+            IERC20[] memory tokens,
+            uint256[] memory balances,
+            uint256 lastChangeBlock
+        );
 
     function WETH() external view returns (IERC20);
 

package/deployments/1-markets/BALANCER-LP-AURA-ANKRETH-WETH-SEP-26-2024.json

@@ -0,0 +1,11 @@
+{
+    "name": "SY ankrETH-WETH_BalancerLP Aura",
+    "SY": "0x2C662f901546a503C90d8dE0DB8BfF1d32FF4A39",
+    "YT": "0x210e6E4addd3fE31240a02DaD104B83634eA0426",
+    "PT": "0x5E9Aaf3b0b09C78C8651968dd1A4d0Ed0D0B55e9",
+    "market": "0xe84b47e626c8dcc021a585a059819cC54946f95A",
+    "expiry": 1727308800,
+    "bulkSeller": "0x2CFf4F4578CFE2220E34C75169CE7C49F3cc56fa",
+    "scalarRoot": "24629050000000000000",
+    "initAnchor": "1172739000000000000"
+}

package/deployments/1-markets/BALANCER-LP-AURA-RETH-WETH-DEC-26-2024.json

@@ -0,0 +1,11 @@
+{
+    "name": "SY rETH-WETH_BalancerLP Aura",
+    "SY": "0x9Bdb1dfD15D9051D127c3cD6882e194cA1c89e56",
+    "YT": "0xE1578305ACC1BA40a331fd8cC9c8aEA1C2F21c9c",
+    "PT": "0x73AA4ce1d62E30AA0207eaF25De6aC3bEba9E7fd",
+    "market": "0x7E9Ad57D949b7aE03588a5bCBa85016F76B462f7",
+    "expiry": 1735171200,
+    "bulkSeller": "0xFa6c7Eb155ad7A9f9Ad5f6C5178eb7e929BF8C09",
+    "scalarRoot": "52750270000000000000",
+    "initAnchor": "1104792000000000000"
+}

package/deployments/1-markets/BALANCER-LP-AURA-STAFI-RETH-WETH-JUNE-27-2024.json

@@ -0,0 +1,11 @@
+{
+    "name": "SY Stafi rETH-WETH_BalancerLP Aura",
+    "SY": "0x35BE86140EEC53Da42C265ae764E547df13891c3",
+    "YT": "0xa57FEEDBd31F4ebD7761d5c3aeED7DeCCb8F95eE",
+    "PT": "0x1abfE281466Dc43Ba5e2A7282661735c00BF82DE",
+    "market": "0xB15a55519dBc3D770ddED079ebcDeEea69A49AdE",
+    "expiry": 1719446400,
+    "bulkSeller": "0x6C4aC4B209Cc57B019b83F6771794D3C73BC47Af",
+    "scalarRoot": "25304300000000000000",
+    "initAnchor": "1139984000000000000"
+}

package/package.json

@@ -2,7 +2,7 @@
   "name": "@pendle/core-v2",
   "description": "Core smart contracts of Pendle Protocol.",
   "license": "BUSL-1.1",
-  "version": "2.7.0-mainnet",
+  "version": "2.8.0-mainnet",
   "homepage": "https://pendle.finance",
   "keywords": [
     "pendle",
@@ -25,9 +25,9 @@
   "devDependencies": {
     "@typechain/ethers-v5": "^9.0.0",
     "@typechain/hardhat": "^4.0.0",
-    "hardhat": "^2.13.0",
+    "hardhat": "^2.13.1",
     "hardhat-contract-sizer": "^2.8.0",
-    "prettier": "^2.8.5",
+    "prettier": "^2.8.7",
     "prettier-plugin-solidity": "^1.1.3",
     "solc": "^0.8.19",
     "solhint": "^3.4.1",