@pendle/core-v2 0.15.2-mainnet → 0.16.0-testnet

package/contracts/router/base/ActionBaseMintRedeem.sol

@@ -5,16 +5,20 @@ import "../kyberswap/KyberSwapHelper.sol";
 import "../../core/libraries/TokenHelper.sol";
 import "../../interfaces/IStandardizedYield.sol";
 import "../../interfaces/IPYieldToken.sol";
-import "../../interfaces/IPBulkSeller.sol";
 import "../../core/libraries/Errors.sol";
 
 // solhint-disable no-empty-blocks
 abstract contract ActionBaseMintRedeem is TokenHelper, KyberSwapHelper {
+    using SafeERC20 for IERC20;
+
     bytes internal constant EMPTY_BYTES = abi.encode();
 
     /// @dev since this contract will be proxied, it must not contains non-immutable variables
-    constructor(address _kyberScalingLib) KyberSwapHelper(_kyberScalingLib) {}
+    constructor(address _kyberSwapRouter) KyberSwapHelper(_kyberSwapRouter) {}
 
+    /**
+     * @notice swap token to baseToken through Uniswap's forks & use it to mint SY
+     */
     function _mintSyFromToken(
         address receiver,
         address SY,
@@ -22,89 +26,104 @@ abstract contract ActionBaseMintRedeem is TokenHelper, KyberSwapHelper {
         TokenInput calldata input
     ) internal returns (uint256 netSyOut) {
         _transferIn(input.tokenIn, msg.sender, input.netTokenIn);
-
-        bool requireSwap = input.tokenIn != input.tokenMintSy;
-
-        uint256 netTokenMintSy;
-
-        if (requireSwap) {
-            _kyberswap(input.tokenIn, input.netTokenIn, input.kyberRouter, input.kybercall);
-            netTokenMintSy = _selfBalance(input.tokenMintSy);
-        } else {
-            netTokenMintSy = input.netTokenIn;
+        if (input.tokenIn != input.tokenMintSy) {
+            _kyberswap(input.tokenIn, input.netTokenIn, input.kybercall);
         }
 
-        if (input.bulk != address(0)) {
-            _transferOut(input.tokenMintSy, input.bulk, netTokenMintSy);
-
-            netSyOut = IPBulkSeller(input.bulk).swapExactTokenForSy(
-                receiver,
-                netTokenMintSy,
-                minSyOut
-            );
-        } else {
-            uint256 netNative = input.tokenMintSy == NATIVE ? netTokenMintSy : 0;
+        _safeApproveInf(input.tokenMintSy, SY);
 
-            _safeApproveInf(input.tokenMintSy, SY);
+        uint256 tokenMintSyBal = _selfBalance(input.tokenMintSy);
+        uint256 nativeAmountToAttach = input.tokenMintSy == NATIVE ? tokenMintSyBal : 0;
 
-            netSyOut = IStandardizedYield(SY).deposit{ value: netNative }(
-                receiver,
-                input.tokenMintSy,
-                netTokenMintSy,
-                minSyOut
-            );
-        }
+        netSyOut = IStandardizedYield(SY).deposit{ value: nativeAmountToAttach }(
+            receiver,
+            input.tokenMintSy,
+            tokenMintSyBal,
+            minSyOut
+        );
     }
 
+    /**
+     * @notice redeem SY to baseToken -> swap baseToken to token through Uniswap's forks
+     */
     function _redeemSyToToken(
         address receiver,
         address SY,
         uint256 netSyIn,
-        TokenOutput memory output,
+        TokenOutput calldata output,
         bool doPull
     ) internal returns (uint256 netTokenOut) {
         if (doPull) {
-            _transferFrom(IERC20(SY), msg.sender, _syOrBulk(SY, output), netSyIn);
+            IERC20(SY).safeTransferFrom(msg.sender, SY, netSyIn);
         }
 
-        bool requireSwap = output.tokenRedeemSy != output.tokenOut;
-        address receiverRedeemSy = requireSwap ? address(this) : receiver;
-        uint256 netTokenRedeemed;
-
-        if (output.bulk != address(0)) {
-            netTokenRedeemed = IPBulkSeller(output.bulk).swapExactSyForToken(
-                receiverRedeemSy,
+        if (output.tokenRedeemSy == output.tokenOut) {
+            netTokenOut = IStandardizedYield(SY).redeem(
+                receiver,
                 netSyIn,
-                0
+                output.tokenRedeemSy,
+                output.minTokenOut,
+                true
             );
         } else {
-            netTokenRedeemed = IStandardizedYield(SY).redeem(
-                receiverRedeemSy,
+            uint256 netTokenRedeemed = IStandardizedYield(SY).redeem(
+                address(this),
                 netSyIn,
                 output.tokenRedeemSy,
-                0,
+                1,
                 true
             );
-        }
-
-        if (requireSwap) {
-            _kyberswap(
-                output.tokenRedeemSy,
-                netTokenRedeemed,
-                output.kyberRouter,
-                output.kybercall
-            );
+            _kyberswap(output.tokenRedeemSy, netTokenRedeemed, output.kybercall);
 
             netTokenOut = _selfBalance(output.tokenOut);
 
+            if (netTokenOut < output.minTokenOut)
+                revert Errors.RouterInsufficientTokenOut(netTokenOut, output.minTokenOut);
+
             _transferOut(output.tokenOut, receiver, netTokenOut);
-        } else {
-            netTokenOut = netTokenRedeemed;
         }
+    }
 
-        if (netTokenOut < output.minTokenOut) {
-            revert Errors.RouterInsufficientTokenOut(netTokenOut, output.minTokenOut);
+    /**
+     * @notice swap token to baseToken through Uniswap's forks -> convert to SY -> convert to PT + YT
+     */
+    function _mintPyFromToken(
+        address receiver,
+        address YT,
+        uint256 minPyOut,
+        TokenInput calldata input
+    ) internal returns (uint256 netPyOut) {
+        address SY = IPYieldToken(YT).SY();
+
+        _mintSyFromToken(YT, SY, 1, input);
+
+        netPyOut = IPYieldToken(YT).mintPY(receiver, receiver);
+        if (netPyOut < minPyOut) revert Errors.RouterInsufficientPYOut(netPyOut, minPyOut);
+    }
+
+    /**
+     * @notice redeem PT + YT to SY -> redeem SY to baseToken -> swap baseToken to token through Uniswap's forks.
+        If the YT hasn't expired, both PT & YT will be needed to redeem. Else, only PT is needed
+     */
+    function _redeemPyToToken(
+        address receiver,
+        address YT,
+        uint256 netPyIn,
+        TokenOutput calldata output,
+        bool doPull
+    ) internal returns (uint256 netTokenOut) {
+        address PT = IPYieldToken(YT).PT();
+        address SY = IPYieldToken(YT).SY();
+
+        if (doPull) {
+            bool needToBurnYt = (!IPYieldToken(YT).isExpired());
+            IERC20(PT).safeTransferFrom(msg.sender, YT, netPyIn);
+            if (needToBurnYt) IERC20(YT).safeTransferFrom(msg.sender, YT, netPyIn);
         }
+
+        uint256 amountSyOut = IPYieldToken(YT).redeemPY(SY); // ignore return
+
+        netTokenOut = _redeemSyToToken(receiver, SY, amountSyOut, output, false);
     }
 
     function _mintPyFromSy(
@@ -117,7 +136,7 @@ abstract contract ActionBaseMintRedeem is TokenHelper, KyberSwapHelper {
         address SY = IPYieldToken(YT).SY();
 
         if (doPull) {
-            _transferFrom(IERC20(SY), msg.sender, YT, netSyIn);
+            IERC20(SY).safeTransferFrom(msg.sender, YT, netSyIn);
         }
 
         netPyOut = IPYieldToken(YT).mintPY(receiver, receiver);
@@ -128,32 +147,18 @@ abstract contract ActionBaseMintRedeem is TokenHelper, KyberSwapHelper {
         address receiver,
         address YT,
         uint256 netPyIn,
-        uint256 minSyOut
+        uint256 minSyOut,
+        bool doPull
     ) internal returns (uint256 netSyOut) {
         address PT = IPYieldToken(YT).PT();
 
-        _transferFrom(IERC20(PT), msg.sender, YT, netPyIn);
-
-        bool needToBurnYt = (!IPYieldToken(YT).isExpired());
-        if (needToBurnYt) _transferFrom(IERC20(YT), msg.sender, YT, netPyIn);
+        if (doPull) {
+            bool needToBurnYt = (!IPYieldToken(YT).isExpired());
+            IERC20(PT).safeTransferFrom(msg.sender, YT, netPyIn);
+            if (needToBurnYt) IERC20(YT).safeTransferFrom(msg.sender, YT, netPyIn);
+        }
 
         netSyOut = IPYieldToken(YT).redeemPY(receiver);
         if (netSyOut < minSyOut) revert Errors.RouterInsufficientSyOut(netSyOut, minSyOut);
     }
-
-    function _syOrBulk(address SY, TokenOutput memory output)
-        internal
-        pure
-        returns (address addr)
-    {
-        return output.bulk != address(0) ? output.bulk : SY;
-    }
-
-    function _wrapTokenOutput(
-        address tokenOut,
-        uint256 minTokenOut,
-        address bulk
-    ) internal pure returns (TokenOutput memory) {
-        return TokenOutput(tokenOut, minTokenOut, tokenOut, bulk, address(0), EMPTY_BYTES);
-    }
 }

package/contracts/router/base/MarketApproxLib.sol

@@ -575,7 +575,7 @@ library MarketApproxPtOutLib {
             {
                 uint256 netSyRemaining = a.totalSyIn - netSyIn;
                 uint256 newTotalPt = a.market.totalPt.Uint() - guess;
-                uint256 netTotalSy = a.market.totalSy.Uint() + netSyIn - netSyFee;
+                uint256 netTotalSy = comp.totalAsset.Uint() + netSyIn - netSyFee;
 
                 // it is desired that
                 // netPtFromSwap / newTotalPt = netSyRemaining / netTotalSy

package/contracts/router/kyberswap/AggregationRouterHelper.sol

@@ -3,16 +3,8 @@
 pragma solidity 0.8.17;
 import "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import "./IMultihopRouter.sol";
-import "./IAggregatorRouterHelper.sol";
-import "@openzeppelin/contracts/proxy/utils/UUPSUpgradeable.sol";
-import "../../core/libraries/BoringOwnableUpgradeable.sol";
 
-contract AggregationRouterHelper is
-    IAggregationRouterHelper,
-    Initializable,
-    UUPSUpgradeable,
-    BoringOwnableUpgradeable
-{
+library AggregationRouterHelper {
     uint256 private constant _PARTIAL_FILL = 0x01;
     uint256 private constant _REQUIRES_EXTRA_ETH = 0x02;
     uint256 private constant _SHOULD_CLAIM = 0x04;
@@ -22,14 +14,6 @@ contract AggregationRouterHelper is
 
     uint256 private constant SLIPPAGE_RANGE = 10; // over 100
 
-    constructor() initializer {}
-
-    function initialize() external initializer {
-        __BoringOwnable_init();
-    }
-
-    function _authorizeUpgrade(address newImplementation) internal override onlyOwner {}
-
     enum DexType {
         UNI,
         STABLESWAP,

package/contracts/router/kyberswap/KyberSwapHelper.sol

@@ -25,55 +25,42 @@ pragma solidity 0.8.17;
 
 import "@openzeppelin/contracts/utils/Address.sol";
 import "../../core/libraries/TokenHelper.sol";
-import "./IAggregatorRouterHelper.sol";
-import "../../core/libraries/Errors.sol";
+import "./AggregationRouterHelper.sol";
 
 struct TokenInput {
-    // Token/Sy data
     address tokenIn;
     uint256 netTokenIn;
     address tokenMintSy;
-    address bulk;
-    // Kyber data
-    address kyberRouter;
     bytes kybercall;
 }
 
 struct TokenOutput {
-    // Token/Sy data
     address tokenOut;
     uint256 minTokenOut;
     address tokenRedeemSy;
-    address bulk;
-    // Kyber data
-    address kyberRouter;
     bytes kybercall;
 }
 
 abstract contract KyberSwapHelper is TokenHelper {
     using Address for address;
+    address public immutable kyberSwapRouter;
 
-    address public immutable kyberScalingLib;
-
-    constructor(address _kyberScalingLib) {
-        kyberScalingLib = _kyberScalingLib;
+    /// @dev since this contract will be proxied, it must not contains non-immutable variables
+    constructor(address _kyberSwapRouter) {
+        kyberSwapRouter = _kyberSwapRouter;
     }
 
     function _kyberswap(
         address tokenIn,
         uint256 amountIn,
-        address kyberRouter,
         bytes memory rawKybercall
     ) internal {
-        if (kyberRouter == address(0) || rawKybercall.length == 0)
-            revert Errors.RouterKyberSwapDataZero();
-
-        _safeApproveInf(tokenIn, kyberRouter);
+        _safeApproveInf(tokenIn, kyberSwapRouter);
 
-        bytes memory kybercall = IAggregationRouterHelper(kyberScalingLib).getScaledInputData(
+        bytes memory kybercall = AggregationRouterHelper.getScaledInputData(
             rawKybercall,
             amountIn
         );
-        kyberRouter.functionCallWithValue(kybercall, tokenIn == NATIVE ? amountIn : 0);
+        kyberSwapRouter.functionCallWithValue(kybercall, tokenIn == NATIVE ? amountIn : 0);
     }
 }

package/deployments/43113-core.json

@@ -0,0 +1,16 @@
+{
+    "deployer": "0x1FcCC097db89A86Bfc474A1028F93958295b1Fb7",
+    "network": 43113,
+    "splitter": "0x81357A3D4F023745a518E4F07b8714e141f84E0a",
+    "lzEndpoint": "0x93f54D755A063cE7bB9e6Ac47Eccc8e33411d706",
+    "treasury": "0x243b7CFD29AcAF9cDe98C1958902FAA3B1F095D5",
+    "PENDLE": "0xB7609dec1C926204c3B67345cbCd54bc4aa7a940",
+    "yieldContractFactory": "0xC39Efc7bb273B75B75471167Cb0EB4D3D41398a8",
+    "marketFactory": "0xa28B2445C8e1751733e75e6794971AEEA4806F45",
+    "router": "0x37e0018919832abC3EDfbfE700df5bb15ed0682D",
+    "routerStatic": "0xFE1129fFa39A2660f5A99eF96343F06D472f781B",
+    "vePendle": "0x74E578b27aD53f23387b9Dcb7902F7Def6D4dB7c",
+    "senderEndpoint": "0xa87c479d77040d1c5433b9cD3b88b2B562A7cb10",
+    "votingController": "0x0b24c845feF83f8403EEF3922F3B53a05182512A",
+    "gaugeController": "0xf0cFb8781F17d51523922Ace5eB69a4b42e35a15"
+}

package/deployments/43113-helper.json

@@ -0,0 +1,3 @@
+{
+    "implicitSwapfeeContract": "0x6d247b1c044fA1E22e6B04fA9F71Baf99EB29A9f"
+}

package/deployments/43113-markets/benqi-market-QI-USDC-FEB-2ND.json

@@ -0,0 +1,8 @@
+{
+    "symbol": "SY-qiUSDC",
+    "SY": "0x922FD937e7C59E58F2E425260fb21Ddc8486BcDE",
+    "expiry": 1675382400,
+    "PT": "0x3cBf269875C4eFf9374AF93e736f3c3487cEA993",
+    "YT": "0x8700D3bb93E21dEAcB84c006106B3b914Cca32e2",
+    "market": "0x20A564b60A21c107eAC5FbFea54D4Aad6db452A1"
+}

package/deployments/43113-markets/benqi-market-QI-WETH-DEC-1ST.json

@@ -0,0 +1,8 @@
+{
+    "symbol": "SY-qiWETH",
+    "SY": "0xF82E799c78B53c814dBf101431cC24F121Fa1098",
+    "expiry": 1669852800,
+    "PT": "0xEAa59b2532D7e49b6f8CAC1b4AdAb6a6F868C7eB",
+    "YT": "0xb899c25fF3c73127F0B96aDAb9997a703C3Fd88D",
+    "market": "0xA9905Bd9d4813a78c4F9Ed4Ba285b49DE50F7406"
+}

package/deployments/43113-testenv.json

@@ -0,0 +1,22 @@
+{
+    "tokens": {
+        "fundKeeper": "0x45e03eB183962884d50eC0Af39B03970333426cb",
+        "faucet": "0xf9d2A793b446D200deC9FBB6f29a9DadcD0521cC",
+        "WAVAX": "0xe43a7aD7C09d8fAE3ADe7361f0b847b23adD5094",
+        "DAI": "0xCd3748CE3Bf75A01D99Bf301668E0748558a592C",
+        "USDC": "0xc2A6b8d7d0FAB3749A6Bda84cEdb58D2d58f045e",
+        "USDT": "0x9BE875cdBB8409DbC1a553c8ddc1FC05cdDF80Ce",
+        "WBTC": "0x82c18D07253603D04d25C8B1F1E60134a59C39ce",
+        "WETH": "0x1e2e40697603CA5b5ffc102c9D7A3310EA3f2Aa3",
+        "qiUSDC": "0xEE3a174F1478198fBc669132B1e2cc13B5686F94",
+        "qiWETH": "0xE5710EC5e4CeB255fb14d2c2BFC93E64d0c30A2c",
+        "qiAVAX": "0xf9aEd3b927dce44C6d53B334Cb759f4D230D9b9c"
+    },
+    "benqi": {
+        "comptroller": "0x4Af3e9CA6f86E655C01f03C13519BcAF867286EE",
+        "QI": "0x63554C4d2038c9B7973190f3E41f5158939Fe972",
+        "interestRateModel": "0xd66C253151539b3bE0a0C11699fB024E054227d4",
+        "qiErc20Impl": "0x184622Dd7B63299F87CBf21f11FF25c9c302fd5d",
+        "oracle": "0x44b789cBC190b7888d438cEb58f1Eb8A3Ae2d897"
+    }
+}

package/deployments/80001-core.json

@@ -0,0 +1,15 @@
+{
+    "deployer": "0x1FcCC097db89A86Bfc474A1028F93958295b1Fb7",
+    "network": 80001,
+    "splitter": "0x07D39E2025Fd0B1F0065FE39172df246f063BB15",
+    "lzEndpoint": "0xf69186dfBa60DdB133E91E9A4B5673624293d8F8",
+    "treasury": "0x47F77E3fAC652E05FFEB7E8E1cEf69E775628B24",
+    "PENDLE": "0x5FDA5b3b05B2884F9f028550069B9D321E84814A",
+    "yieldContractFactory": "0x8B3C5BD39E6B82272eCf0d6828D458536dc44dea",
+    "marketFactory": "0xf963474FAe462B06B026DE500f605B3578B66c66",
+    "router": "0x7cD7cc0990A0F61532410fE11f884f2caD7e59D3",
+    "routerStatic": "0xc9132D222e681c86A522120B41585B87992D61b9",
+    "receiverEndpoint": "0x57D55237374b0D1AFdac5E25F16A4EE5C57A627c",
+    "vePendle": "0x89Cec94a14FAB1cb27C1A5cd32af05ef448d9829",
+    "gaugeController": "0x8a6c59A80aA3Bbf32E7b3F0C359Eb528Cf6f7288"
+}

package/deployments/80001-markets/benqi-market-QI-USDC-FEB-2ND.json

@@ -0,0 +1,8 @@
+{
+    "symbol": "SY-qiUSDC",
+    "SY": "0x95867d15D0a6F77E32c684022D97e882A71Bd630",
+    "expiry": 1675382400,
+    "PT": "0x9d9381D466e46525eDDac3a3dC71EC64C3c3d87c",
+    "YT": "0xa693a38f9261Ee45040EB2b8125D8B718b83f491",
+    "market": "0x90326785175652D74a0AA35Af8fb86819513D939"
+}

package/deployments/80001-markets/benqi-market-QI-WETH-DEC-1ST.json

@@ -0,0 +1,8 @@
+{
+    "symbol": "SY-qiWETH",
+    "SY": "0x501E089e6BD6b78e6E435C15118E52c665931850",
+    "expiry": 1669852800,
+    "PT": "0x5a6049e6dB4032Dfa7A27b4071DB6C4a5A9A4707",
+    "YT": "0x885AdC68FC7F5715A32eb03eA1c6F17F396c715A",
+    "market": "0xc86283109a074E8021a50717e3d86D3f78184b18"
+}

package/deployments/80001-testenv.json

@@ -0,0 +1,22 @@
+{
+    "tokens": {
+        "fundKeeper": "0x7D301Cc4F91A9eDd8EDE1801344bd6516b5FA3d2",
+        "faucet": "0x35AC4A286F1f1234f09Ff43f42B1f7767c6fAA91",
+        "WAVAX": "0xdF3601014686674e53d1Fa52F7602525483F9122",
+        "DAI": "0x829bF32457394D1f1fA8C1b151cE5017bb04C17D",
+        "USDC": "0x5Ea8c8e02c2D413165C1ADcBb6916B0851f6cd73",
+        "USDT": "0xAFC1ac698E9b54C240e6Ebc7d64200BB84f2E4cd",
+        "WBTC": "0x4d89990738A071B9E597Ea442f2ba58e6EA97184",
+        "WETH": "0x1A6fCc85557BC4fB7B534ed835a03EF056552D52",
+        "qiUSDC": "0x76818c92936662e9b24f74395f38634C35604720",
+        "qiWETH": "0x0b9d0756AeaD1cBc6bC4e9f30FeEa377a73d407F",
+        "qiAVAX": "0x98030D8f342aA21424B07059Cb1405A179A1F668"
+    },
+    "benqi": {
+        "comptroller": "0x0d18d7a0B27CB5C2F33cDc0a087B7182a72e0fAb",
+        "QI": "0x9F10C77EF63a5706e53D82B249D9195BeB5774fd",
+        "interestRateModel": "0xfF334644479e70ae5C9545218574B17e9aF7A5DD",
+        "qiErc20Impl": "0xA3972f97074552de27cF747A126b2c5F36935818",
+        "oracle": "0x324D838b26Eb73786bDBBc53bb0682F1EBB50603"
+    }
+}

package/package.json

@@ -2,7 +2,7 @@
   "name": "@pendle/core-v2",
   "description": "Core smart contracts of Pendle Protocol.",
   "license": "BUSL-1.1",
-  "version": "0.15.2-mainnet",
+  "version": "0.16.0-testnet",
   "homepage": "https://pendle.finance",
   "keywords": [
     "pendle",
@@ -44,7 +44,6 @@
   },
   "packageManager": "yarn@3.2.2",
   "dependencies": {
-    "@openzeppelin/contracts": "^4.7.3",
-    "@openzeppelin/contracts-upgradeable": "^4.7.3"
+    "@openzeppelin/contracts": "^4.7.3"
   }
 }