@pellux/goodvibes-tui 2.0.1 → 2.0.2

package/CHANGELOG.md

@@ -4,6 +4,17 @@ All notable changes to GoodVibes TUI.
 
 ---
 
+## [2.0.2] - 2026-08-01
+
+### Changes
+
+- Fixed: importing settings that include `display.themeMode` no longer prints
+  an "unknown key" warning. The key is now declared in the platform
+  configuration schema (SDK 2.0.1) — `auto` probes the terminal background
+  once at startup, `dark` and `light` force a fixed appearance — and the
+  settings screen's row for it comes from that schema like every other
+  `display.*` key, instead of a local stand-in descriptor.
+
 ## [2.0.1] - 2026-08-01
 
 ### Changes

package/README.md

@@ -2,7 +2,7 @@
 
 [![CI](https://github.com/mgd34msu/goodvibes-tui/actions/workflows/ci.yml/badge.svg)](https://github.com/mgd34msu/goodvibes-tui/actions/workflows/ci.yml)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
-[![Version](https://img.shields.io/badge/version-2.0.1-blue.svg)](https://github.com/mgd34msu/goodvibes-tui)
+[![Version](https://img.shields.io/badge/version-2.0.2-blue.svg)](https://github.com/mgd34msu/goodvibes-tui)
 
 GoodVibes is a terminal console for coding and operations work with an AI model. You run `goodvibes` in a project directory and get a full-screen terminal app where you talk to a model that can read and edit your files, run shell commands, search the web, and hand work off to background agents — asking your permission before anything that writes or executes. It talks to many model providers (OpenAI, Anthropic, Gemini, Bedrock, Copilot, OpenRouter and other OpenAI-compatible gateways, plus local servers like Ollama and LM Studio that it finds on startup), keeps its settings, sessions, and secrets on your own machine, and shows you the token count and running cost of every turn. Alongside the conversation, panels turn background work — running agents, git state, diffs, tokens, cost — into live control rooms.
 

package/docs/foundation-artifacts/operator-contract.json

@@ -3,7 +3,7 @@
   "product": {
     "id": "goodvibes",
     "surface": "operator",
-    "version": "2.0.0"
+    "version": "2.0.1"
   },
   "auth": {
     "modes": [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pellux/goodvibes-tui",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "description": "Terminal-native GoodVibes client for coding, operations, knowledge and channel workflows — a pure client of the GoodVibes daemon.",
   "type": "module",
   "main": "src/main.ts",
@@ -95,11 +95,11 @@
     "@anthropic-ai/bedrock-sdk": "^0.29.1",
     "@anthropic-ai/sdk": "^0.92.0",
     "@ast-grep/napi": "^0.42.0",
-    "@pellux/goodvibes-sdk": "2.0.0",
-    "@pellux/goodvibes-terminal-shell": "2.0.0",
+    "@pellux/goodvibes-sdk": "2.0.1",
+    "@pellux/goodvibes-terminal-shell": "2.0.1",
     "bash-language-server": "^5.6.0",
     "fuse.js": "^7.1.0",
-    "@pellux/goodvibes-daemon": "1.28.1",
+    "@pellux/goodvibes-daemon": "1.28.3",
     "graphql": "^16.13.2",
     "jszip": "^3.10.1",
     "node-edge-tts": "^1.2.10",
@@ -124,10 +124,10 @@
     "typescript": "^5.9.3"
   },
   "optionalDependencies": {
-    "@pellux/goodvibes-tui-linux-x64": "2.0.1",
-    "@pellux/goodvibes-tui-linux-arm64": "2.0.1",
-    "@pellux/goodvibes-tui-darwin-x64": "2.0.1",
-    "@pellux/goodvibes-tui-darwin-arm64": "2.0.1"
+    "@pellux/goodvibes-tui-linux-x64": "2.0.2",
+    "@pellux/goodvibes-tui-linux-arm64": "2.0.2",
+    "@pellux/goodvibes-tui-darwin-x64": "2.0.2",
+    "@pellux/goodvibes-tui-darwin-arm64": "2.0.2"
   },
   "trustedDependencies": [],
   "overrides": {

package/src/input/payments-config.ts

@@ -26,15 +26,15 @@
  * implicit card the way this app's `/payments card` flow models it, so these
  * four fields are synthetic sub-keys under the SDK's real `payments`
  * section — the same established pattern this codebase already uses for
- * `behavior.notifyAfterSeconds`, `display.themeMode`, etc.: a key one level
- * under an EXISTING section that CONFIG_SCHEMA has no scalar entry for.
+ * `behavior.notifyAfterSeconds`, `storage.codeIndexEnabled`, etc.: a key one
+ * level under an EXISTING section that CONFIG_SCHEMA has no scalar entry for.
  *
  * That one-level-under-an-existing-section shape matters mechanically: the
  * real ConfigManager's dotted-path resolver only throws "Invalid config path"
  * when an INTERMEDIATE segment is missing (e.g. `payments.card.number`, where
  * `card` is not itself a section) — it does not throw for a final leaf that
  * the schema has not declared (`payments.cardNumber`), the same tolerance
- * `display.themeMode` relies on under `display`. So these four keys are named
+ * `storage.codeIndexEnabled` relies on under `storage`. So these four keys are named
  * FLAT (`payments.cardNumber`, not `payments.card.number`) specifically so
  * `ConfigManager.get/setDynamic` accepts them — verified against the real
  * ConfigManager (not the fake store this module used before this round): a
@@ -79,7 +79,7 @@ export const PAYMENTS_CVV_HANDLING_CONFIG_KEY = 'payments.cvvHandling' as Config
 function readStringField(configManager: PaymentsConfigReader, key: ConfigKey): string {
   // Defensive try/catch, same rationale as worktree-setup-config.ts's
   // readWorktreeSetupList and this codebase's other one-level-under-a-real-
-  // section synthetic reads (behavior.notifyAfterSeconds, display.themeMode): the real
+  // section synthetic reads (behavior.notifyAfterSeconds, storage.codeIndexEnabled): the real
   // ConfigManager never throws for these particular keys (verified — see
   // header comment), but degrading to empty rather than crashing the whole
   // settings modal is the same posture every synthetic setting here takes

package/src/input/settings-modal-data.ts

@@ -36,13 +36,6 @@ import {
   isExecEnvScrubAllowlistConfigKey,
   readExecEnvScrubAllowlist,
 } from './exec-env-scrub-config.ts';
-import {
-  THEME_MODE_CONFIG_KEY,
-  THEME_MODE_VALUES,
-  THEME_MODE_DEFAULT,
-  THEME_MODE_DESCRIPTION,
-  coerceThemeModeSetting,
-} from '../renderer/theme-mode-config.ts';
 import {
   SETTINGS_CATEGORIES,
   type FlagEntry,
@@ -145,12 +138,6 @@ export function buildSettingGroups(
     if (rawCat === 'cluster' && groups.has('network')) groups.get('network')!.push(entry);
   }
 
-  // Synthetic display.themeMode enum (auto|dark|light) — TUI-local, see theme-mode-config.ts.
-  const displayEntries = groups.get('display');
-  if (displayEntries && !displayEntries.some((e) => e.setting.key === (THEME_MODE_CONFIG_KEY as ConfigKey))) {
-    displayEntries.push(buildThemeModeSyntheticEntry(configManager));
-  }
-
   const uiEntries = groups.get('ui');
   if (uiEntries) {
     const uiPriority: Record<string, number> = {
@@ -283,34 +270,6 @@ export function buildSettingGroups(
   return groups;
 }
 
-// ---------------------------------------------------------------------------
-// display.themeMode synthetic setting (light theme)
-// ---------------------------------------------------------------------------
-
-/**
- * The synthetic ConfigSetting descriptor for display.themeMode. TUI-local (not
- * in the SDK ConfigKey union); the key is cast to ConfigKey as the other
- * synthetic settings do. Stored under the existing `display` section so
- * ConfigManager.setDynamic/get round-trip it with no SDK change.
- */
-export const THEME_MODE_SYNTHETIC_SETTING: ConfigSetting = {
-  key: THEME_MODE_CONFIG_KEY as ConfigKey,
-  type: 'enum',
-  default: THEME_MODE_DEFAULT,
-  enumValues: [...THEME_MODE_VALUES],
-  description: THEME_MODE_DESCRIPTION,
-};
-
-/** Build the synthetic SettingEntry for display.themeMode. */
-export function buildThemeModeSyntheticEntry(configManager: Pick<ConfigManager, 'get'>): SettingEntry {
-  const currentValue = coerceThemeModeSetting(configManager.get(THEME_MODE_CONFIG_KEY as ConfigKey));
-  return {
-    setting: THEME_MODE_SYNTHETIC_SETTING,
-    currentValue,
-    isDefault: currentValue === THEME_MODE_DEFAULT,
-  };
-}
-
 // ---------------------------------------------------------------------------
 // behavior.notifyAfterSeconds synthetic setting
 // ---------------------------------------------------------------------------
@@ -623,11 +582,9 @@ export function refreshEntryValues(
       }
       const raw = configManager.get(entry.setting.key as ConfigKey);
       // Synthetic entries that have no SDK schema key return undefined from
-      // configManager. Normalize using the same logic used at construction
-      // time so isDefault stays accurate.
-      entry.currentValue = entry.setting.key === (THEME_MODE_CONFIG_KEY as ConfigKey)
-        ? coerceThemeModeSetting(raw)
-        : raw;
+      // configManager; the schema-driven entries above already normalize on
+      // their own read paths, so the raw value is used as-is here.
+      entry.currentValue = raw;
       entry.isDefault = deepEqual(entry.currentValue, entry.setting.default);
     }
   }
@@ -670,10 +627,7 @@ export function updateEntryForKey(
         continue;
       }
       const raw = configManager.get(key);
-      // Synthetic entries: normalize using the same fallback logic as construction.
-      entry.currentValue = key === (THEME_MODE_CONFIG_KEY as ConfigKey)
-        ? coerceThemeModeSetting(raw)
-        : raw;
+      entry.currentValue = raw;
       entry.isDefault = deepEqual(entry.currentValue, entry.setting.default);
     }
   }

package/src/input/worktree-setup-config.ts

@@ -9,7 +9,7 @@
  * settings modal even though they fully control what runs when a fresh
  * isolated worktree is provisioned (setup commands, then untracked-file
  * carry-over). Same rationale as the other synthetic settings in
- * settings-modal-data.ts (behavior.notifyAfterSeconds, display.themeMode, etc).
+ * settings-modal-data.ts (behavior.notifyAfterSeconds, storage.codeIndexEnabled, etc).
  *
  * Both keys hold a JSON array of strings on disk. The settings modal's
  * inline editor is a single-line text field, so — matching the SDK's own

package/src/renderer/theme-mode-config.ts

@@ -2,15 +2,17 @@
  * theme-mode-config — the appearance/theme-mode preference, TUI-side.
  *
  * The preference lives at the config key `display.themeMode` (auto | dark |
- * light, default auto). It is stored under the existing SDK `display` section
- * rather than a new `appearance` section on purpose: the SDK ConfigManager's
- * resolvePath() throws for any dot-path whose top-level section is absent from
- * DEFAULT_CONFIG, and adding an `appearance` section would require an SDK schema
- * change (out of scope for this TUI-only work order). Storing under `display`
- * reuses the same proven "TUI-local synthetic setting" pattern the codebase
- * already uses for behavior.notifyAfterSeconds / storage.codeIndexEnabled:
- * ConfigManager.setDynamic writes it to settings.json and get() reads it back,
- * with zero SDK changes.
+ * light, default auto), stored under the existing SDK `display` section
+ * alongside `display.theme` (the color palette — a separate, independent
+ * concept: theme picks the palette, themeMode picks light/dark appearance).
+ *
+ * `display.themeMode` is a real CONFIG_SCHEMA entry (SDK 2.0.0+); this module
+ * no longer carries a TUI-local synthetic descriptor for it. The settings
+ * modal renders the schema's own row like every other key, and this module
+ * keeps the read-side helpers (coerceThemeModeSetting,
+ * resolveConfiguredThemeMode) that the renderer's runtime paths (theme.ts,
+ * terminal-bg-probe.ts, ui-openers.ts) use to turn the resolved value into a
+ * ThemeMode ('dark' | 'light') for actual rendering.
  *
  * This module is deliberately free of any terminal/probe state so both the
  * settings-modal data layer (input) and the probe (renderer) can import it
@@ -21,27 +23,15 @@ import type { ThemeModeSetting } from './theme.ts';
 import type { ConfigKey, ConfigManager } from '@pellux/goodvibes-sdk/platform/config';
 
 /** Config key backing the appearance/theme-mode preference (see module doc). */
-export const THEME_MODE_CONFIG_KEY = 'display.themeMode';
-
-/** The three valid preference values, in settings-cycle order. */
-export const THEME_MODE_VALUES: readonly ThemeModeSetting[] = ['auto', 'dark', 'light'];
-
-/** Default when unset: probe the terminal background on startup. */
-export const THEME_MODE_DEFAULT: ThemeModeSetting = 'auto';
+export const THEME_MODE_CONFIG_KEY: ConfigKey = 'display.themeMode';
 
 /**
- * Human-facing description for the settings-modal entry. States the honest
- * timing contract: forced modes apply on next full paint immediately; `auto`
- * only re-probes at startup, so switching TO auto takes effect next launch.
+ * Default when unset: probe the terminal background on startup. Matches the
+ * CONFIG_SCHEMA default for display.themeMode (module-private: nothing
+ * outside this file needs the default value directly — callers read the
+ * resolved mode via coerceThemeModeSetting/resolveConfiguredThemeMode).
  */
-export const THEME_MODE_DESCRIPTION =
-  'Terminal background theme. auto probes the terminal background colour once at '
-  + 'startup (OSC 11) and picks light or dark; dark/light force a fixed theme. '
-  + 'Forced modes take effect immediately; auto is only evaluated at startup, so '
-  + 'selecting auto takes effect on the next launch. Unreadable/unsupported '
-  + 'terminals fall back to dark. Scope (honest): transcript markdown, modal '
-  + 'accents, and the header/footer/thinking chrome all flip with this setting; '
-  + 'only the background colour itself follows your terminal.';
+const THEME_MODE_DEFAULT: ThemeModeSetting = 'auto';
 
 /** Narrow an unknown config value to a valid ThemeModeSetting, else the default. */
 export function coerceThemeModeSetting(raw: unknown): ThemeModeSetting {
@@ -49,17 +39,15 @@ export function coerceThemeModeSetting(raw: unknown): ThemeModeSetting {
 }
 
 /**
- * Read the configured theme-mode preference. Reads the TUI-local key via a cast
- * (it is not in the SDK ConfigKey union). Safe: the `display` section exists in
- * DEFAULT_CONFIG, so get() returns undefined for the absent field rather than
- * throwing, and we coerce undefined → 'auto'.
+ * Read the configured theme-mode preference. Safe: the `display` section
+ * exists in DEFAULT_CONFIG, so get() returns undefined for an unset field
+ * rather than throwing, and we coerce undefined → 'auto'.
  */
 export function resolveConfiguredThemeMode(
   configManager: Pick<ConfigManager, 'get'>,
 ): ThemeModeSetting {
   try {
-    // Cast key: display.themeMode is TUI-local, not in the SDK ConfigKey union.
-    return coerceThemeModeSetting(configManager.get(THEME_MODE_CONFIG_KEY as ConfigKey));
+    return coerceThemeModeSetting(configManager.get(THEME_MODE_CONFIG_KEY));
   } catch {
     // Defensive: any unexpected resolvePath/section error → honest default.
     return THEME_MODE_DEFAULT;

package/src/version.ts

@@ -6,7 +6,7 @@ import { join } from 'node:path';
 // The prebuild script updates the fallback value before compilation.
 // Uses import.meta.dir (Bun) to locate package.json relative to this file,
 // which is correct regardless of the process working directory.
-let _version = '2.0.1';
+let _version = '2.0.2';
 try {
   const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8'));
   // Only trust a version read from OUR OWN package.json. A Bun single-file