@pellux/goodvibes-tui 1.9.1 → 1.10.0

package/src/runtime/workstream-services.ts

@@ -1,5 +1,5 @@
 // ---------------------------------------------------------------------------
-// workstream-services.ts — Wave 4 (wo703)
+// workstream-services.ts — phase/work-item orchestration engine
 //
 // Constructs the TUI's OrchestrationEngine instance (@pellux/goodvibes-sdk/
 // platform/orchestration, landed on SDK main as wo701/W4.1) and a thin

package/src/runtime/wrfc-persistence.ts

@@ -19,7 +19,7 @@
  *    additionally exposes the recovered set for inspection.
  *
  *    A chain that looked interrupted (non-terminal) in the old snapshot can be
- *    reaped to terminal IN PLACE by `WrfcController.importChain` (Wave 6, wo-F:
+ *    reaped to terminal IN PLACE by `WrfcController.importChain` (the zombie-reap pass:
  *    no member agent survived the restart — see wrfc-controller.ts). This
  *    module always re-checks `chain.state` AFTER the import call, never the
  *    pre-import classification, so a reaped chain is treated as history, not
@@ -209,7 +209,7 @@ class WrfcPersistenceImpl implements WrfcPersistence {
       // chain. The accessor is optional for read-only test doubles.
       //
       // NOTE: importChain may reap this chain to a terminal state IN PLACE
-      // (Wave 6, wo-F zombie-reap: no member agent survived the restart) —
+      // (zombie reap: no member agent survived the restart) —
       // always read chain.state AFTER this call below, never the pre-import
       // classification captured by candidateInterrupted.
       this.controller.importChain?.(chain);

package/src/shell/ui-openers.ts

@@ -231,7 +231,7 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
 
   commandContext.openModelPicker = () => {
     void (async () => {
-      // D5: getSelectableModels() is catalog-driven and can list models whose
+      // getSelectableModels() is catalog-driven and can list models whose
       // `provider` id (e.g. 'google', sourced from the pricing catalog) was never
       // handed to providerRegistry.register()/registerRuntimeProvider(). Selecting
       // such a model fails hard at turn time with ProviderNotFoundError
@@ -264,7 +264,7 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
 
   commandContext.openProviderPicker = () => {
     void (async () => {
-      // D5: listModels() surfaces every catalog provider id, not just the ones
+      // listModels() surfaces every catalog provider id, not just the ones
       // actually registered on this runtime (see openModelPicker above for the
       // same class of bug). Intersect against providerRegistry.has() so the
       // provider picker never offers a provider that will fail with

package/src/version.ts

@@ -6,7 +6,7 @@ import { join } from 'node:path';
 // The prebuild script updates the fallback value before compilation.
 // Uses import.meta.dir (Bun) to locate package.json relative to this file,
 // which is correct regardless of the process working directory.
-let _version = '1.9.1';
+let _version = '1.10.0';
 try {
   const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8'));
   _version = pkg.version ?? _version;

package/src/audio/spoken-turn-controller.ts

@@ -1,243 +0,0 @@
-import type { ConfigManager } from '@pellux/goodvibes-sdk/platform/config';
-import type { ConfigKey } from '@pellux/goodvibes-sdk/platform/config';
-import type { TurnEvent } from '@/runtime/index.ts';
-import type { VoiceService, VoiceSynthesisStreamResult } from '@pellux/goodvibes-sdk/platform/voice';
-import { summarizeError } from '@pellux/goodvibes-sdk/platform/utils';
-import { TtsTextChunker } from './text-chunker.ts';
-import type { StreamingAudioPlayer } from './player.ts';
-
-export interface SpokenTurnControllerOptions {
-  readonly voiceService: Pick<VoiceService, 'synthesizeStream'>;
-  readonly configManager: Pick<ConfigManager, 'get'>;
-  readonly player: StreamingAudioPlayer;
-  readonly notify?: (message: string) => void;
-  readonly now?: () => number;
-  readonly setInterval?: typeof setInterval;
-  readonly clearInterval?: typeof clearInterval;
-}
-
-export class SpokenTurnController {
-  private pendingPrompt: string | null = null;
-  private activeTurnId: string | null = null;
-  private chunker: TtsTextChunker | null = null;
-  private chunkSequence = 0;
-  private playbackChain: Promise<void> = Promise.resolve();
-  private readonly abortControllers = new Set<AbortController>();
-  private timer: ReturnType<typeof setInterval> | null = null;
-  private errorReportedForTurn = false;
-  private noPlayerNoticed = false;
-  private readonly voiceService: Pick<VoiceService, 'synthesizeStream'>;
-  private readonly configManager: Pick<ConfigManager, 'get'>;
-  private readonly player: StreamingAudioPlayer;
-  private readonly notify?: (message: string) => void;
-  private readonly now: () => number;
-  private readonly setIntervalImpl: typeof setInterval;
-  private readonly clearIntervalImpl: typeof clearInterval;
-
-  constructor(options: SpokenTurnControllerOptions) {
-    this.voiceService = options.voiceService;
-    this.configManager = options.configManager;
-    this.player = options.player;
-    this.notify = options.notify;
-    this.now = options.now ?? (() => Date.now());
-    this.setIntervalImpl = options.setInterval ?? setInterval;
-    this.clearIntervalImpl = options.clearInterval ?? clearInterval;
-  }
-
-  submitNextTurn(prompt: string): boolean {
-    const normalized = prompt.trim();
-    if (!normalized) return false;
-    this.stop();
-    if (!this.player.available) {
-      if (!this.noPlayerNoticed) {
-        this.noPlayerNoticed = true;
-        this.notify?.('[TTS] Text response will continue, but live audio is unavailable. Install mpv or ffplay.');
-      }
-      return false;
-    }
-    // Reset the no-player notice if player becomes available again.
-    this.noPlayerNoticed = false;
-    this.pendingPrompt = normalized;
-    return true;
-  }
-
-  /**
-   * Returns whether speech was actually ACTIVE when stopped. The notice only
-   * prints in that case — stop() on an idle controller used to notify anyway,
-   * spamming "[TTS] Spoken output stopped." on every Ctrl+C (batch replay
-   * D5/N-noise); callers use the return to decide whether the press "did a
-   * job" (see handleCtrlC's consume-on-speech-stop).
-   */
-  stop(message?: string): boolean {
-    const wasActive = this.pendingPrompt !== null || this.activeTurnId !== null
-      || this.chunker !== null || this.abortControllers.size > 0;
-    this.pendingPrompt = null;
-    this.activeTurnId = null;
-    this.chunker?.reset();
-    this.chunker = null;
-    this.stopTimer();
-    for (const controller of this.abortControllers) controller.abort();
-    this.abortControllers.clear();
-    this.player.stop();
-    this.playbackChain = Promise.resolve();
-    this.errorReportedForTurn = false;
-    if (message && wasActive) this.notify?.(`[TTS] ${message}`);
-    return wasActive;
-  }
-
-  handleTurnEvent(event: TurnEvent): void {
-    if (event.type === 'TURN_SUBMITTED') {
-      this.maybeStartTurn(event.turnId, event.prompt);
-      return;
-    }
-    if (!this.activeTurnId || event.turnId !== this.activeTurnId) return;
-
-    if (event.type === 'STREAM_DELTA') {
-      this.enqueueChunks(this.chunker?.push(event.content) ?? []);
-      return;
-    }
-    if (event.type === 'STREAM_END') {
-      return;
-    }
-    if (event.type === 'TURN_COMPLETED') {
-      this.finishTurn(event.turnId);
-      return;
-    }
-    if (event.type === 'TURN_CANCEL' || event.type === 'TURN_ERROR' || event.type === 'PREFLIGHT_FAIL') {
-      this.stop(event.type === 'TURN_CANCEL' ? 'Spoken output stopped.' : 'Spoken output stopped because the turn did not complete.');
-    }
-  }
-
-  private maybeStartTurn(turnId: string, prompt: string): void {
-    if (!this.pendingPrompt) return;
-    if (prompt.trim() !== this.pendingPrompt) return;
-    this.pendingPrompt = null;
-    this.activeTurnId = turnId;
-    this.chunkSequence = 0;
-    this.errorReportedForTurn = false;
-    this.chunker = new TtsTextChunker({ now: this.now });
-    this.playbackChain = Promise.resolve();
-    this.startTimer();
-    this.notify?.(`[TTS] Live playback queued through ${this.player.label}.`);
-  }
-
-  private finishTurn(turnId: string): void {
-    if (turnId !== this.activeTurnId) return;
-    this.enqueueChunks(this.chunker?.flushAll() ?? []);
-    this.stopTimer();
-    const chain = this.playbackChain;
-    chain.finally(() => {
-      if (this.activeTurnId !== turnId) return;
-      this.activeTurnId = null;
-      this.chunker = null;
-      this.abortControllers.clear();
-    }).catch(() => {
-      // Errors are already reported in the queued task.
-    });
-  }
-
-  private startTimer(): void {
-    this.stopTimer();
-    this.timer = this.setIntervalImpl(() => {
-      if (!this.activeTurnId || !this.chunker) return;
-      this.enqueueChunks(this.chunker.flushDue());
-    }, 250);
-  }
-
-  private stopTimer(): void {
-    if (!this.timer) return;
-    this.clearIntervalImpl(this.timer);
-    this.timer = null;
-  }
-
-  private enqueueChunks(chunks: readonly string[]): void {
-    for (const chunk of chunks) {
-      this.enqueueChunk(chunk);
-    }
-  }
-
-  private enqueueChunk(text: string): void {
-    const turnId = this.activeTurnId;
-    if (!turnId || !text.trim()) return;
-    const sequence = ++this.chunkSequence;
-    const abortController = new AbortController();
-    this.abortControllers.add(abortController);
-    const resultPromise = this.synthesize(text, turnId, sequence, abortController.signal)
-      .then((result) => ({ ok: true as const, result }))
-      .catch((error: unknown) => ({ ok: false as const, error }));
-
-    this.playbackChain = this.playbackChain.then(async () => {
-      if (abortController.signal.aborted) return;
-      const result = await resultPromise;
-      this.abortControllers.delete(abortController);
-      if (!result.ok) {
-        this.reportError(result.error);
-        return;
-      }
-      await this.player.play(result.result.chunks, {
-        format: String(result.result.format ?? 'mp3'),
-        signal: abortController.signal,
-      });
-    }).catch((error: unknown) => {
-      this.abortControllers.delete(abortController);
-      this.reportError(error);
-    });
-  }
-
-  private synthesize(text: string, turnId: string, sequence: number, signal: AbortSignal): Promise<VoiceSynthesisStreamResult> {
-    // tts.speed: VoiceSynthesisRequest accepts speed (number | undefined).
-    // No ConfigKey for tts.speed exists in the current SDK schema — pending
-    // SDK schema addition. Speed is not threaded from config until that key
-    // is added. See docs/voice-and-live-tts.md § Speed.
-    return this.voiceService.synthesizeStream(readOptionalConfigString(this.configManager, 'tts.provider'), {
-      text,
-      voiceId: readOptionalConfigString(this.configManager, 'tts.voice'),
-      format: 'mp3',
-      speed: readOptionalConfigNumber(this.configManager, 'tts.speed'),
-      signal,
-      metadata: {
-        source: 'goodvibes-tui',
-        feature: 'live-tts',
-        turnId,
-        sequence,
-      },
-    });
-  }
-
-  private reportError(error: unknown): void {
-    if (this.errorReportedForTurn) return;
-    this.errorReportedForTurn = true;
-    this.activeTurnId = null;
-    this.chunker = null;
-    this.stopTimer();
-    for (const controller of this.abortControllers) controller.abort();
-    this.abortControllers.clear();
-    this.player.stop();
-    this.playbackChain = Promise.resolve();
-    this.notify?.(`[TTS] Live playback stopped: ${summarizeError(error)}`);
-  }
-}
-
-function readOptionalConfigString(configManager: Pick<ConfigManager, 'get'>, key: ConfigKey): string | undefined {
-  const value = String(configManager.get(key) ?? '').trim();
-  return value || undefined;
-}
-
-/**
- * readOptionalConfigNumber — reads a numeric config value by key.
- *
- * `tts.speed` is not yet a ConfigKey in the SDK schema. This helper accepts
- * a string key and casts it, returning undefined when the value is absent,
- * zero, or not a finite positive number. Once `tts.speed` is added to the
- * SDK schema the cast can be removed and the key typed statically.
- *
- * SDK handoff note: add { key: 'tts.speed', type: 'number', default: 1,
- * description: '...' } to schema-domain-core.js and `tts: { ..., speed: 1 }`
- * to DEFAULT_CONFIG.tts to complete this feature.
- */
-function readOptionalConfigNumber(configManager: Pick<ConfigManager, 'get'>, key: string): number | undefined {
-  // Cast required: key is not yet a valid ConfigKey in the SDK schema.
-  const raw = configManager.get(key as ConfigKey);
-  const value = typeof raw === 'number' ? raw : parseFloat(String(raw ?? ''));
-  return isFinite(value) && value > 0 ? value : undefined;
-}

package/src/audio/text-chunker.ts

@@ -1,110 +0,0 @@
-export interface TtsTextChunkerOptions {
-  readonly minBoundaryChars?: number;
-  readonly maxChunkChars?: number;
-  readonly maxLatencyMs?: number;
-  readonly now?: () => number;
-}
-
-export class TtsTextChunker {
-  private buffer = '';
-  private firstBufferedAt: number | null = null;
-  private readonly minBoundaryChars: number;
-  private readonly maxChunkChars: number;
-  private readonly maxLatencyMs: number;
-  private readonly now: () => number;
-
-  constructor(options: TtsTextChunkerOptions = {}) {
-    this.minBoundaryChars = options.minBoundaryChars ?? 24;
-    this.maxChunkChars = options.maxChunkChars ?? 320;
-    this.maxLatencyMs = options.maxLatencyMs ?? 1_000;
-    this.now = options.now ?? (() => Date.now());
-  }
-
-  push(delta: string): string[] {
-    if (!delta) return [];
-    if (this.firstBufferedAt === null) this.firstBufferedAt = this.now();
-    this.buffer += delta;
-    return this.drainReady(false);
-  }
-
-  flushDue(): string[] {
-    if (!this.buffer.trim() || this.firstBufferedAt === null) return [];
-    if (this.now() - this.firstBufferedAt < this.maxLatencyMs) return [];
-    return this.drainReady(true);
-  }
-
-  flushAll(): string[] {
-    if (!this.buffer.trim()) {
-      this.buffer = '';
-      this.firstBufferedAt = null;
-      return [];
-    }
-    return [this.takeChunk(this.buffer.length)].filter(Boolean);
-  }
-
-  reset(): void {
-    this.buffer = '';
-    this.firstBufferedAt = null;
-  }
-
-  private drainReady(forceLatencyFlush: boolean): string[] {
-    const chunks: string[] = [];
-    while (this.buffer.trim()) {
-      const boundary = this.findBoundary(forceLatencyFlush);
-      if (boundary <= 0) break;
-      const chunk = this.takeChunk(boundary);
-      if (chunk) chunks.push(chunk);
-      forceLatencyFlush = false;
-    }
-    return chunks;
-  }
-
-  private findBoundary(forceLatencyFlush: boolean): number {
-    const latestSentence = this.findLatestSentenceBoundary();
-    if (latestSentence >= this.minBoundaryChars) return latestSentence;
-
-    if (this.buffer.length >= this.maxChunkChars) {
-      return this.findWordBoundaryBefore(this.maxChunkChars) || this.maxChunkChars;
-    }
-
-    if (forceLatencyFlush) {
-      return this.buffer.length;
-    }
-
-    return -1;
-  }
-
-  private findLatestSentenceBoundary(): number {
-    let best = -1;
-    for (let i = 0; i < this.buffer.length; i++) {
-      const char = this.buffer[i];
-      if (char !== '.' && char !== '!' && char !== '?' && char !== ';' && char !== ':' && char !== '\n') {
-        continue;
-      }
-      const next = this.buffer[i + 1];
-      if (i === this.buffer.length - 1 || next === undefined || /\s/.test(next)) {
-        best = i + 1;
-      }
-    }
-    return best;
-  }
-
-  private findWordBoundaryBefore(index: number): number {
-    const max = Math.min(index, this.buffer.length);
-    for (let i = max; i > 0; i--) {
-      if (/\s/.test(this.buffer[i - 1] ?? '')) return i;
-    }
-    return -1;
-  }
-
-  private takeChunk(end: number): string {
-    const raw = this.buffer.slice(0, end);
-    this.buffer = this.buffer.slice(end);
-    this.firstBufferedAt = this.buffer.trim() ? this.now() : null;
-    return normalizeSpeechText(raw);
-  }
-}
-
-export function normalizeSpeechText(text: string): string {
-  return text.replace(/\s+/g, ' ').trim();
-}