@pellux/goodvibes-tui 1.27.0 → 2.0.1

package/src/cli/parser.ts

@@ -1,395 +0,0 @@
-import type {
-  GoodVibesCliCommand,
-  GoodVibesCliFlags,
-  GoodVibesCliOutputFormat,
-  GoodVibesCliParseResult,
-} from './types.ts';
-
-const COMMAND_ALIASES: Readonly<Record<string, GoodVibesCliCommand>> = {
-  tui: 'tui',
-  app: 'tui',
-  run: 'run',
-  exec: 'run',
-  e: 'run',
-  serve: 'serve',
-  daemon: 'serve',
-  server: 'serve',
-  web: 'web',
-  service: 'service',
-  services: 'service',
-  status: 'status',
-  doctor: 'doctor',
-  onboarding: 'onboarding',
-  setup: 'onboarding',
-  models: 'models',
-  model: 'models',
-  providers: 'providers',
-  provider: 'providers',
-  auth: 'auth',
-  subscription: 'subscription',
-  subscriptions: 'subscription',
-  secrets: 'secrets',
-  secret: 'secrets',
-  sessions: 'sessions',
-  session: 'sessions',
-  tasks: 'tasks',
-  task: 'tasks',
-  pair: 'pair',
-  qrcode: 'pair',
-  qr: 'pair',
-  surfaces: 'surfaces',
-  surface: 'surfaces',
-  listener: 'listener',
-  'http-listener': 'listener',
-  webhook: 'listener',
-  'control-plane': 'control-plane',
-  controlplane: 'control-plane',
-  cp: 'control-plane',
-  'support-bundle': 'support-bundle',
-  // `bundle`/`bundles` are retained as backward-compat aliases for the shipped
-  // command word; the primary, unambiguous name is `support-bundle` (distinct
-  // from the `plugin bundles` capability-bundle surface).
-  bundle: 'support-bundle',
-  bundles: 'support-bundle',
-  remote: 'remote',
-  bridge: 'bridge',
-  hooks: 'hooks',
-  hook: 'hooks',
-  plugin: 'plugin',
-  plugins: 'plugin',
-  completion: 'completion',
-  completions: 'completion',
-  help: 'help',
-  version: 'version',
-};
-
-function createDefaultFlags(): GoodVibesCliFlags {
-  return {
-    provider: undefined,
-    model: undefined,
-    daemonHome: undefined,
-    workingDir: undefined,
-    help: false,
-    version: false,
-    prompt: undefined,
-    print: false,
-    outputFormat: 'text',
-    configOverrides: [],
-    enableFeatures: [],
-    disableFeatures: [],
-    noAltScreen: false,
-    port: undefined,
-    hostname: undefined,
-    open: false,
-    continueLast: false,
-    resume: undefined,
-    session: undefined,
-    fork: undefined,
-    yes: false,
-    nonInteractive: false,
-    strict: false,
-  };
-}
-
-function splitOption(token: string): { readonly name: string; readonly value: string | undefined } {
-  const index = token.indexOf('=');
-  if (index < 0) return { name: token, value: undefined };
-  return {
-    name: token.slice(0, index),
-    value: token.slice(index + 1),
-  };
-}
-
-function getValue(
-  argv: readonly string[],
-  index: number,
-  inlineValue: string | undefined,
-  optionName: string,
-  errors: string[],
-): { readonly value: string | undefined; readonly nextIndex: number } {
-  if (inlineValue !== undefined) return { value: inlineValue, nextIndex: index };
-  const next = argv[index + 1];
-  if (next === undefined || (next.startsWith('-') && next !== '-')) {
-    errors.push(`${optionName} requires a value.`);
-    return { value: undefined, nextIndex: index };
-  }
-  return { value: next, nextIndex: index + 1 };
-}
-
-function getOptionalValue(
-  argv: readonly string[],
-  index: number,
-  inlineValue: string | undefined,
-): { readonly value: string | undefined; readonly nextIndex: number } {
-  if (inlineValue !== undefined) return { value: inlineValue, nextIndex: index };
-  const next = argv[index + 1];
-  if (next === undefined || next.startsWith('-')) return { value: undefined, nextIndex: index };
-  return { value: next, nextIndex: index + 1 };
-}
-
-function parsePort(value: string | undefined, optionName: string, errors: string[]): number | undefined {
-  if (value === undefined) return undefined;
-  if (!/^\d+$/.test(value)) {
-    errors.push(`${optionName} must be a port number from 1 to 65535.`);
-    return undefined;
-  }
-  const port = Number.parseInt(value, 10);
-  if (port < 1 || port > 65535) {
-    errors.push(`${optionName} must be a port number from 1 to 65535.`);
-    return undefined;
-  }
-  return port;
-}
-
-function normalizeOutputFormat(value: string | undefined, flagName: string, errors: string[]): GoodVibesCliOutputFormat {
-  if (value === 'text' || value === 'json' || value === 'stream-json') return value;
-  errors.push(`${flagName} must be one of: text, json, stream-json.`);
-  return 'text';
-}
-
-function inferProviderFromModel(model: string, currentProvider: string | undefined): string | undefined {
-  if (currentProvider !== undefined) return currentProvider;
-  if (model.includes(':')) return model.split(':')[0];
-  if (model.includes('/')) return model.split('/')[0];
-  return undefined;
-}
-
-function withFlag<K extends keyof GoodVibesCliFlags>(
-  flags: GoodVibesCliFlags,
-  key: K,
-  value: GoodVibesCliFlags[K],
-): GoodVibesCliFlags {
-  return { ...flags, [key]: value };
-}
-
-function appendFlagArray<K extends 'configOverrides' | 'enableFeatures' | 'disableFeatures'>(
-  flags: GoodVibesCliFlags,
-  key: K,
-  value: string,
-): GoodVibesCliFlags {
-  return {
-    ...flags,
-    [key]: [...flags[key], value],
-  };
-}
-
-export function parseGoodVibesCli(
-  argv: readonly string[],
-  binary = 'goodvibes',
-): GoodVibesCliParseResult {
-  let flags = createDefaultFlags();
-  let command: GoodVibesCliCommand = 'tui';
-  let rawCommand: string | undefined;
-  const commandArgs: string[] = [];
-  const positionals: string[] = [];
-  const errors: string[] = [];
-  const warnings: string[] = [];
-  let sawCommand = false;
-  let passthrough = false;
-
-  for (let index = 0; index < argv.length; index += 1) {
-    const token = argv[index]!;
-
-    if (passthrough) {
-      if (sawCommand) commandArgs.push(token);
-      else positionals.push(token);
-      continue;
-    }
-
-    if (token === '--') {
-      passthrough = true;
-      continue;
-    }
-
-    if (!token.startsWith('-') || token === '-') {
-      if (!sawCommand) {
-        const normalized = COMMAND_ALIASES[token.toLowerCase()];
-        if (normalized) {
-          command = normalized;
-          rawCommand = token;
-          sawCommand = true;
-          continue;
-        }
-      }
-      positionals.push(token);
-      if (sawCommand) commandArgs.push(token);
-      continue;
-    }
-
-    const { name, value: inlineValue } = splitOption(token);
-
-    if (name === '--help' || name === '-h') {
-      flags = withFlag(flags, 'help', true);
-      continue;
-    }
-    if (name === '--version' || name === '-v') {
-      flags = withFlag(flags, 'version', true);
-      continue;
-    }
-    if (name === '--print') {
-      flags = withFlag(flags, 'print', true);
-      if (!sawCommand) command = 'run';
-      continue;
-    }
-    if (name === '--json') {
-      flags = withFlag(flags, 'outputFormat', 'json');
-      continue;
-    }
-    if (name === '--no-alt-screen') {
-      flags = withFlag(flags, 'noAltScreen', true);
-      continue;
-    }
-    if (name === '--open') {
-      flags = withFlag(flags, 'open', true);
-      continue;
-    }
-    if (name === '--continue') {
-      flags = withFlag(flags, 'continueLast', true);
-      continue;
-    }
-    if (name === '--fork') {
-      const consumed = getOptionalValue(argv, index, inlineValue);
-      index = consumed.nextIndex;
-      flags = withFlag(flags, 'fork', consumed.value ?? true);
-      continue;
-    }
-    if (name === '--yes' || name === '-y') {
-      flags = withFlag(flags, 'yes', true);
-      continue;
-    }
-    if (name === '--non-interactive') {
-      flags = withFlag(withFlag(flags, 'nonInteractive', true), 'yes', true);
-      continue;
-    }
-    if (name === '--strict') {
-      flags = withFlag(flags, 'strict', true);
-      continue;
-    }
-
-    if (name === '--provider') {
-      const consumed = getValue(argv, index, inlineValue, name, errors);
-      index = consumed.nextIndex;
-      if (consumed.value !== undefined) flags = withFlag(flags, 'provider', consumed.value);
-      continue;
-    }
-    if (name === '--model' || name === '-m') {
-      const consumed = getValue(argv, index, inlineValue, name, errors);
-      index = consumed.nextIndex;
-      if (consumed.value !== undefined) {
-        flags = withFlag(flags, 'model', consumed.value);
-        flags = withFlag(flags, 'provider', inferProviderFromModel(consumed.value, flags.provider));
-      }
-      continue;
-    }
-    if (name === '--daemon-home') {
-      const consumed = getValue(argv, index, inlineValue, name, errors);
-      index = consumed.nextIndex;
-      if (consumed.value !== undefined) flags = withFlag(flags, 'daemonHome', consumed.value);
-      continue;
-    }
-    if (name === '--working-dir' || name === '--cd' || name === '-C') {
-      const consumed = getValue(argv, index, inlineValue, name, errors);
-      index = consumed.nextIndex;
-      if (consumed.value !== undefined) flags = withFlag(flags, 'workingDir', consumed.value);
-      continue;
-    }
-    if (name === '--prompt' || name === '-p') {
-      const consumed = getValue(argv, index, inlineValue, name, errors);
-      index = consumed.nextIndex;
-      if (consumed.value !== undefined) {
-        flags = withFlag(flags, 'prompt', consumed.value);
-        if (!sawCommand) command = 'run';
-      }
-      continue;
-    }
-    if (name === '--output-format' || name === '--output' || name === '-o') {
-      const consumed = getValue(argv, index, inlineValue, name, errors);
-      index = consumed.nextIndex;
-      flags = withFlag(flags, 'outputFormat', normalizeOutputFormat(consumed.value, name, errors));
-      if (name === '--output-format') {
-        warnings.push('--output-format is deprecated; use --output (or -o) instead.');
-      }
-      continue;
-    }
-    if (name === '--config' || name === '-c') {
-      const consumed = getValue(argv, index, inlineValue, name, errors);
-      index = consumed.nextIndex;
-      if (consumed.value !== undefined) flags = appendFlagArray(flags, 'configOverrides', consumed.value);
-      continue;
-    }
-    if (name === '--enable') {
-      const consumed = getValue(argv, index, inlineValue, name, errors);
-      index = consumed.nextIndex;
-      if (consumed.value !== undefined) flags = appendFlagArray(flags, 'enableFeatures', consumed.value);
-      continue;
-    }
-    if (name === '--disable') {
-      const consumed = getValue(argv, index, inlineValue, name, errors);
-      index = consumed.nextIndex;
-      if (consumed.value !== undefined) flags = appendFlagArray(flags, 'disableFeatures', consumed.value);
-      continue;
-    }
-    if (name === '--port') {
-      const consumed = getValue(argv, index, inlineValue, name, errors);
-      index = consumed.nextIndex;
-      flags = withFlag(flags, 'port', parsePort(consumed.value, name, errors));
-      continue;
-    }
-    if (name === '--hostname' || name === '--host') {
-      const consumed = getValue(argv, index, inlineValue, name, errors);
-      index = consumed.nextIndex;
-      if (consumed.value !== undefined) flags = withFlag(flags, 'hostname', consumed.value);
-      continue;
-    }
-    if (name === '--resume' || name === '-r') {
-      const consumed = getOptionalValue(argv, index, inlineValue);
-      index = consumed.nextIndex;
-      flags = withFlag(flags, 'resume', consumed.value ?? 'latest');
-      continue;
-    }
-    if (name === '--session' || name === '-s') {
-      const consumed = getValue(argv, index, inlineValue, name, errors);
-      index = consumed.nextIndex;
-      if (consumed.value !== undefined) flags = withFlag(flags, 'session', consumed.value);
-      continue;
-    }
-
-    if (sawCommand) {
-      commandArgs.push(token);
-      continue;
-    }
-
-    errors.push(`Unknown option: ${name}`);
-  }
-
-  if (flags.prompt === undefined && (command === 'run' || flags.print) && positionals.length > 0) {
-    flags = withFlag(flags, 'prompt', positionals.join(' '));
-  }
-
-  if (rawCommand !== undefined && command === 'unknown') {
-    errors.push(`Unknown command: ${rawCommand}`);
-  }
-
-  // Session lifecycle conflict detection — only one of --continue / --resume / --fork may be used.
-  const sessionLifecycleFlags = [
-    flags.continueLast ? '--continue' : undefined,
-    flags.resume !== undefined ? '--resume' : undefined,
-    flags.fork !== undefined ? '--fork' : undefined,
-  ].filter((f): f is string => f !== undefined);
-  if (sessionLifecycleFlags.length > 1) {
-    errors.push(
-      `Conflicting session lifecycle flags: ${sessionLifecycleFlags.join(' and ')}. Use only one of --continue, --resume, or --fork.`,
-    );
-  }
-
-  return {
-    binary,
-    command,
-    rawCommand,
-    commandArgs,
-    positionals,
-    flags,
-    errors,
-    warnings,
-  };
-}

package/src/cli/redaction.ts

@@ -1,170 +0,0 @@
-export const REDACTED_VALUE = '<redacted>';
-
-// Matches a config path whose LAST SEGMENT is exactly one of these words. That
-// is the whole reach of this pattern, and it is why the declared list below
-// exists: `surfaces.calendar.caldavPassword` does not end in a `.password`
-// segment, it ends in a `caldavPassword` segment, so this pattern answers false
-// for it — as it does for `imapPassword`, `appPassword` and `authToken`.
-const SENSITIVE_PATH_PATTERN = /(^|\.)(apiKey|accessToken|botToken|appToken|signingSecret|webhookSecret|verifyToken|verificationToken|secret|password|token|keyFile)$/i;
-
-// Credential-bearing config keys that are sensitive by NAME rather than by the
-// generic trailing-word list above. Every one of these was carried in the clear
-// by a support bundle before it was listed here, because the pattern matches a
-// trailing WORD and these names carry the credential word in the middle or
-// prefixed by a protocol ("caldavPassword", "imapPassword", "appPassword",
-// "authToken").
-//
-// The `*Ref` Cloudflare keys normally hold a `goodvibes://secrets/...`
-// reference, which shouldRedactValue already lets through as safe. They are
-// listed as a BACKSTOP, for the same reason the mail keys are worth listing
-// twice over: it costs nothing, and it is what stands between a future code
-// path that writes a literal token there and that token reaching a file the
-// owner emails to someone for support.
-const SENSITIVE_CONFIG_KEYS: ReadonlySet<string> = new Set([
-  // Mailbox / CalDAV — the credentials the daemon polls mail and calendar with.
-  'surfaces.email.password',
-  'surfaces.email.imapPassword',
-  'surfaces.email.imap.password',
-  'surfaces.email.smtp.password',
-  'surfaces.calendar.caldavPassword',
-  // Telephony.
-  'surfaces.telephony.authToken',
-  'surfaces.msteams.appPassword',
-  // Cloudflare token references.
-  'cloudflare.apiTokenRef',
-  'cloudflare.tunnelTokenRef',
-  'cloudflare.accessServiceTokenRef',
-  'cloudflare.workerTokenRef',
-  'cloudflare.workerClientTokenRef',
-  // Cluster shared phrase.
-  'cluster.secret',
-  // Payment card material. ADDED to this set, never substituted for it: this
-  // set is a hardcoded list with no delegation, so replacing it wholesale with
-  // another product's would silently stop redacting whatever that one omits.
-  // The four names below end in no word the suffix pattern knows —
-  // "cardNumber", "cardExpiry" and "cardholderName" match none of them — which
-  // is the whole reason a declared list exists rather than a naming habit.
-  // (The `.map` below lowercases every entry; the lookup lowercases too.)
-  'payments.cardNumber',
-  'payments.cardExpiry',
-  'payments.cardCvv',
-  'payments.cardholderName',
-].map((key) => key.toLowerCase()));
-
-const SECRET_LIKE_TEXT_PATTERNS: readonly RegExp[] = [
-  /\bsk-[A-Za-z0-9_-]{16,}\b/g,
-  /\bghp_[A-Za-z0-9_]{16,}\b/g,
-  /\bgho_[A-Za-z0-9_]{16,}\b/g,
-  /\bghu_[A-Za-z0-9_]{16,}\b/g,
-  /\bghs_[A-Za-z0-9_]{16,}\b/g,
-  /\bgithub_pat_[A-Za-z0-9_]{24,}\b/g,
-  /\b(?:xoxb|xapp|xoxp|xoxa)-[A-Za-z0-9-]{16,}\b/g,
-  /\b[A-Za-z0-9._%+-]+:[A-Za-z0-9._%+-]{8,}@/g,
-];
-
-export function isSensitiveConfigPath(path: string): boolean {
-  return SENSITIVE_PATH_PATTERN.test(path) || SENSITIVE_CONFIG_KEYS.has(path.toLowerCase());
-}
-
-export function isRedactedValue(value: unknown): boolean {
-  return value === REDACTED_VALUE;
-}
-
-export interface RedactedConfigResult<T> {
-  readonly value: T;
-  readonly redactedPaths: readonly string[];
-}
-
-// Redaction rule for sensitive config paths:
-// - Non-string values: redact if truthy (i.e. non-null, non-undefined, non-zero, non-false).
-//   Rationale: zero and false are never meaningful secrets; null/undefined mean absent.
-// - String values: redact non-empty strings that are not goodvibes:// secret refs.
-//   Rationale: empty string means unset; secret refs are safe placeholders, not raw values.
-function shouldRedactValue(path: string, value: unknown): boolean {
-  if (!isSensitiveConfigPath(path)) return false;
-  if (typeof value !== 'string') return value !== null && value !== undefined && Boolean(value);
-  if (value.trim().length === 0) return false;
-  if (value.startsWith('goodvibes://secrets/')) return false;
-  return true;
-}
-
-function redactUnknown(value: unknown, path: string, redactedPaths: string[]): unknown {
-  if (shouldRedactValue(path, value)) {
-    redactedPaths.push(path);
-    return REDACTED_VALUE;
-  }
-
-  if (Array.isArray(value)) {
-    return value.map((item, index) => redactUnknown(item, `${path}.${index}`, redactedPaths));
-  }
-
-  if (value && typeof value === 'object') {
-    const result: Record<string, unknown> = {};
-    for (const [key, nested] of Object.entries(value)) {
-      const nestedPath = path ? `${path}.${key}` : key;
-      result[key] = redactUnknown(nested, nestedPath, redactedPaths);
-    }
-    return result;
-  }
-
-  return value;
-}
-
-export function redactConfig<T>(config: T): RedactedConfigResult<T> {
-  const redactedPaths: string[] = [];
-  return {
-    value: redactUnknown(config, '', redactedPaths) as T,
-    redactedPaths,
-  };
-}
-
-export function redactText(input: string): string {
-  // Assignment form: keyword=value — anchored so 'monkey=' and 'donkey=' do NOT match.
-  // Matches: token=, access_token=, api_key=, api-key=, secret=, password= and colon form token: value
-  let output = input
-    .replace(
-      /(?<![A-Za-z])(?:access_token|api[_-]?key|secret|password|token)\s*=\s*([^ \t\r\n"'`]+)/gi,
-      (m, val) => m.slice(0, m.length - val.length) + REDACTED_VALUE,
-    )
-    .replace(
-      /(?<![A-Za-z])(?:access_token|api[_-]?key|secret|password|token)\s*:\s*([^ \t\r\n"'`]+)/gi,
-      (m, val) => m.slice(0, m.length - val.length) + REDACTED_VALUE,
-    );
-  for (const pattern of SECRET_LIKE_TEXT_PATTERNS) {
-    output = output.replace(pattern, REDACTED_VALUE);
-  }
-  return output;
-}
-
-function collectSensitiveValues(value: unknown, path: string, values: string[]): void {
-  if (shouldRedactValue(path, value) && typeof value === 'string') {
-    values.push(value);
-    return;
-  }
-  if (Array.isArray(value)) {
-    value.forEach((item, index) => collectSensitiveValues(item, `${path}.${index}`, values));
-    return;
-  }
-  if (value && typeof value === 'object') {
-    for (const [key, nested] of Object.entries(value)) {
-      collectSensitiveValues(nested, path ? `${path}.${key}` : key, values);
-    }
-  }
-}
-
-export function collectSensitiveConfigValues(config: unknown): readonly string[] {
-  const values: string[] = [];
-  collectSensitiveValues(config, '', values);
-  return [...new Set(values)].sort((left, right) => right.length - left.length);
-}
-
-export function redactSerializedSecrets(serialized: string, secretValues: readonly string[]): string {
-  let output = redactText(serialized);
-  for (const secret of secretValues) {
-    if (!secret) continue;
-    const encoded = JSON.stringify(secret).slice(1, -1);
-    output = output.split(encoded).join(REDACTED_VALUE);
-    output = output.split(secret).join(REDACTED_VALUE);
-  }
-  return output;
-}

package/src/cli/types.ts

@@ -1,84 +0,0 @@
-import type { ConfigManager } from '../config/index.ts';
-
-export type GoodVibesCliCommand =
-  | 'tui'
-  | 'run'
-  | 'serve'
-  | 'web'
-  | 'service'
-  | 'status'
-  | 'doctor'
-  | 'onboarding'
-  | 'models'
-  | 'providers'
-  | 'auth'
-  | 'subscription'
-  | 'secrets'
-  | 'sessions'
-  | 'tasks'
-  | 'pair'
-  | 'surfaces'
-  | 'listener'
-  | 'control-plane'
-  | 'support-bundle'
-  | 'remote'
-  | 'bridge'
-  | 'hooks'
-  | 'plugin'
-  | 'completion'
-  | 'help'
-  | 'version'
-  | 'unknown';
-
-export type GoodVibesCliOutputFormat = 'text' | 'json' | 'stream-json';
-
-export interface CliCommandOutput {
-  readonly output: string;
-  readonly exitCode: number;
-}
-
-export interface GoodVibesCliFlags {
-  readonly provider: string | undefined;
-  readonly model: string | undefined;
-  readonly daemonHome: string | undefined;
-  readonly workingDir: string | undefined;
-  readonly help: boolean;
-  readonly version: boolean;
-  readonly prompt: string | undefined;
-  readonly print: boolean;
-  readonly outputFormat: GoodVibesCliOutputFormat;
-  readonly configOverrides: readonly string[];
-  readonly enableFeatures: readonly string[];
-  readonly disableFeatures: readonly string[];
-  readonly noAltScreen: boolean;
-  readonly port: number | undefined;
-  readonly hostname: string | undefined;
-  readonly open: boolean;
-  readonly continueLast: boolean;
-  readonly resume: string | undefined;
-  readonly session: string | undefined;
-  readonly fork: string | true | undefined;
-  readonly yes: boolean;
-  readonly nonInteractive: boolean;
-  /** `doctor --strict`: advisory findings also fail (exit 1), for CI. Ignored by every other command. */
-  readonly strict: boolean;
-}
-
-export interface GoodVibesCliParseResult {
-  readonly binary: string;
-  readonly command: GoodVibesCliCommand;
-  readonly rawCommand: string | undefined;
-  readonly commandArgs: readonly string[];
-  readonly positionals: readonly string[];
-  readonly flags: GoodVibesCliFlags;
-  readonly errors: readonly string[];
-  /** Deprecation and soft-warning messages (non-fatal). Callers should surface these to users. */
-  readonly warnings: readonly string[];
-}
-
-export interface CliCommandRuntime {
-  readonly cli: GoodVibesCliParseResult;
-  readonly configManager: ConfigManager;
-  readonly workingDirectory: string;
-  readonly homeDirectory: string;
-}