@pellux/goodvibes-tui 1.16.0 → 1.16.1

package/CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to GoodVibes TUI.
 
 ---
 
+## [1.16.1] — 2026-07-12
+
+### Changes
+- 4f54b6e0 fix(renderer): never clip a modal's descriptive text to fit a fixed column or row
+- 64ceb78a fix(install): never restart or skip-setup a systemd unit or bare process that can't actually run
+
 ## [1.16.0] — 2026-07-11
 
 ### Changes

package/README.md

@@ -2,7 +2,7 @@
 
 [![CI](https://github.com/mgd34msu/goodvibes-tui/actions/workflows/ci.yml/badge.svg)](https://github.com/mgd34msu/goodvibes-tui/actions/workflows/ci.yml)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
-[![Version](https://img.shields.io/badge/version-1.16.0-blue.svg)](https://github.com/mgd34msu/goodvibes-tui)
+[![Version](https://img.shields.io/badge/version-1.16.1-blue.svg)](https://github.com/mgd34msu/goodvibes-tui)
 
 A terminal-native AI coding, operations, automation, knowledge, and integration console with a typed runtime, omnichannel surfaces, structured memory/knowledge, and a raw ANSI renderer.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pellux/goodvibes-tui",
-  "version": "1.16.0",
+  "version": "1.16.1",
   "description": "Terminal-native GoodVibes product for coding, operations, automation, knowledge, channels, and daemon-backed control-plane workflows.",
   "type": "module",
   "main": "src/main.ts",
@@ -131,10 +131,10 @@
     "typescript": "^5.9.3"
   },
   "optionalDependencies": {
-    "@pellux/goodvibes-tui-linux-x64": "1.16.0",
-    "@pellux/goodvibes-tui-linux-arm64": "1.16.0",
-    "@pellux/goodvibes-tui-darwin-x64": "1.16.0",
-    "@pellux/goodvibes-tui-darwin-arm64": "1.16.0"
+    "@pellux/goodvibes-tui-linux-x64": "1.16.1",
+    "@pellux/goodvibes-tui-linux-arm64": "1.16.1",
+    "@pellux/goodvibes-tui-darwin-x64": "1.16.1",
+    "@pellux/goodvibes-tui-darwin-arm64": "1.16.1"
   },
   "trustedDependencies": [],
   "overrides": {

package/src/renderer/onboarding/onboarding-wizard.ts

@@ -295,15 +295,25 @@ function renderWideLayout(
   const centerStart = leftSeparatorX + 1;
   const rightSeparatorX = centerStart + centerWidth;
   const rightStart = rightSeparatorX + 1;
-  const descriptionLines = wrapText(currentStep.description, Math.max(18, centerWidth - 2)).slice(0, 2);
   const summaryLines = [
     currentStep.summaryTitle,
     ...currentStep.summaryLines.slice(0, 2),
     `Fields ${wizard.getCompletedFieldCount(wizard.stepIndex)}/${wizard.getStepFieldCount(wizard.stepIndex)} complete`,
     changedScreensLabel(wizard),
   ];
-  const fieldStartRow = 6;
+  const centerTextWidth = Math.max(18, centerWidth - 2);
+  const descriptionLines = wrapText(currentStep.description, centerTextWidth).slice(0, 2);
   const selectedText = selectedFieldText(wizard);
+  // The selected field's own hint is the direct analog of the reported
+  // defect (descriptive text explaining what the currently-focused option
+  // does) — some hints run past 400 characters, e.g. security-caveat text.
+  // It is never clipped to a single row: it wraps onto as many lines as it
+  // needs, and the field list below starts after it, growing/shrinking the
+  // field-list area rather than losing hint text. Title/description/controls
+  // stay fixed-row (short chrome strings, not the field-specific
+  // explanation), matching prior layout exactly when the hint fits on one line.
+  const hintLines = wrapText(selectedText.hint, centerTextWidth);
+  const fieldStartRow = 5 + hintLines.length;
   const fieldRows = buildFieldRows(wizard, visibleFields, Math.max(0, bodyRows - fieldStartRow));
 
   const topLine = createOverlayFilledBorderLine(
@@ -397,9 +407,9 @@ function renderWideLayout(
         bg: DEFAULT_OVERLAY_PALETTE.selectedBg,
         bold: true,
       });
-    } else if (row === 5) {
+    } else if (row < fieldStartRow) {
       fillWidth(line, centerStart, centerWidth, DEFAULT_OVERLAY_PALETTE.selectedBg);
-      putOverlayText(line, centerStart + 1, centerWidth - 2, truncateDisplay(selectedText.hint, centerWidth - 2), {
+      putOverlayText(line, centerStart + 1, centerWidth - 2, hintLines[row - 5] ?? '', {
         fg: UI_TONES.fg.secondary,
         bg: DEFAULT_OVERLAY_PALETTE.selectedBg,
       });
@@ -481,9 +491,13 @@ function renderCollapsedLayout(
   const bodyBg = UI_TONES.bg.base;
   const innerStart = layout.margin + 1;
   const innerWidth = layout.innerWidth;
-  const descriptionLines = wrapText(currentStep.description, Math.max(14, innerWidth - 2)).slice(0, 2);
-  const fieldStartRow = 6;
+  const innerTextWidth = Math.max(14, innerWidth - 2);
+  const descriptionLines = wrapText(currentStep.description, innerTextWidth).slice(0, 2);
   const selectedText = selectedFieldText(wizard);
+  // Same rule as the wide layout: the selected field's hint wraps onto as
+  // many lines as it needs rather than being clipped to a single row.
+  const hintLines = wrapText(selectedText.hint, innerTextWidth);
+  const fieldStartRow = 5 + hintLines.length;
   const fieldRows = buildFieldRows(wizard, visibleFields, Math.max(0, bodyRows - fieldStartRow));
 
   const topLine = createOverlayFilledBorderLine(
@@ -559,9 +573,9 @@ function renderCollapsedLayout(
         bg: DEFAULT_OVERLAY_PALETTE.selectedBg,
         bold: true,
       });
-    } else if (row === 5) {
+    } else if (row < fieldStartRow) {
       fillWidth(line, innerStart, innerWidth, DEFAULT_OVERLAY_PALETTE.selectedBg);
-      putOverlayText(line, innerStart + 1, innerWidth - 2, truncateDisplay(selectedText.hint, innerWidth - 2), {
+      putOverlayText(line, innerStart + 1, innerWidth - 2, hintLines[row - 5] ?? '', {
         fg: UI_TONES.fg.secondary,
         bg: DEFAULT_OVERLAY_PALETTE.selectedBg,
       });

package/src/renderer/selection-modal-overlay.ts

@@ -1,6 +1,6 @@
 import { type Line } from '../types/grid.ts';
 import { fitDisplay, getDisplayWidth, truncateDisplay } from '../utils/terminal-width.ts';
-import type { SelectionModal } from '../input/selection-modal.ts';
+import type { SelectionItem, SelectionModal } from '../input/selection-modal.ts';
 import {
   createOverlayBoxLayout,
   createOverlayContentLine,
@@ -30,6 +30,45 @@ function putText(line: Line, startX: number, maxWidth: number, text: string, sty
   putOverlayText(line, startX, maxWidth, text, style);
 }
 
+/**
+ * How an item's `detail` text fits on screen. Descriptive text is never
+ * clipped: if it doesn't fit beside the label at a readable width, the full
+ * text wraps onto its own line(s) below the label instead of being
+ * truncated. `wrappedDetail` is null when the detail fits inline (no data
+ * lost either way); otherwise it holds every wrapped line the FULL detail
+ * needs (no line-count cap).
+ */
+interface DetailLayout {
+  readonly labelWidth: number;
+  readonly detailWidth: number;
+  readonly wrappedDetail: readonly string[] | null;
+}
+
+function computeDetailLayout(item: SelectionItem, remaining: number): DetailLayout {
+  if (!item.detail) {
+    return { labelWidth: remaining, detailWidth: 0, wrappedDetail: null };
+  }
+  const cols = fitLabelDetailColumns(item.label, item.detail, remaining);
+  const fitsInline = cols.detailWidth >= 12 && getDisplayWidth(item.detail) <= cols.detailWidth;
+  if (fitsInline) {
+    return { labelWidth: cols.labelWidth, detailWidth: cols.detailWidth, wrappedDetail: null };
+  }
+  // Nothing shares this row with the label once the detail moves below it,
+  // so the label itself gets the full row width too.
+  return {
+    labelWidth: remaining,
+    detailWidth: cols.detailWidth,
+    wrappedDetail: wrapWithHangingIndent(item.detail, Math.max(8, remaining), ''),
+  };
+}
+
+/** Physical rows an item occupies: 1 for the label/inline-detail row, plus
+ * one more per wrapped detail line when the detail didn't fit inline. */
+function rowCostFor(item: SelectionItem, remaining: number): number {
+  if (!item.detail) return 1;
+  return 1 + (computeDetailLayout(item, remaining).wrappedDetail?.length ?? 0);
+}
+
 /**
  * Render the selection modal as Line[] for overlay in the viewport.
  */
@@ -39,12 +78,17 @@ export function renderSelectionModalOverlay(
   viewportHeight = 24,
 ): Line[] {
   const lines: Line[] = [];
+  const chromeRows = modal.allowSearch ? 5 : 4;
   const metrics = getOverlaySurfaceMetrics(width, viewportHeight, {
     margin: 4,
     maxWidth: 72,
-    chromeRows: modal.allowSearch ? 5 : 4,
+    chromeRows,
     minContentRows: 6,
-    maxContentRows: 10,
+    // Modals size to content: items whose detail wraps onto extra lines can
+    // need more physical rows than a plain one-row-per-item modal, so this
+    // ceiling grows with the viewport rather than staying pinned at a small
+    // constant (still bounded — never larger than the terminal can show).
+    maxContentRows: Math.max(10, viewportHeight - chromeRows - 4),
   });
   const layout = createOverlayBoxLayout(width, metrics.margin, metrics.boxWidth);
 
@@ -99,15 +143,51 @@ export function renderSelectionModalOverlay(
     putText(line, layout.margin + 2, layout.innerWidth, fitDisplay(message, layout.innerWidth), { fg: MUTED_FG, dim: true });
     lines.push(line);
   } else {
-    const maxVisible = metrics.contentRows;
-    let startIdx = 0;
-    if (items.length > maxVisible) {
-      startIdx = Math.max(0, Math.min(
-        modal.selectedIndex - Math.floor(maxVisible / 2),
-        items.length - maxVisible,
-      ));
+    const indicatorWidth = 2;
+    const remaining = layout.innerWidth - indicatorWidth;
+    const rowBudget = Math.max(1, metrics.contentRows);
+
+    // Row-budget-aware windowing: rather than assuming one physical row per
+    // item, account for items whose detail wraps onto extra lines, so the
+    // visible window never silently shows fewer full items than the budget
+    // allows just because a fixed item-count cap ran out. Always shows the
+    // selected item (even alone, if its wrapped detail is taller than the
+    // whole budget — descriptive text is never clipped to make it fit),
+    // then grows outward, roughly centered, until the budget is spent.
+    const selected = Math.max(0, Math.min(modal.selectedIndex, items.length - 1));
+    let startIdx = selected;
+    let endIdx = selected + 1;
+    let usedRows = rowCostFor(items[selected], remaining);
+    let growBefore = true;
+    while (startIdx > 0 || endIdx < items.length) {
+      const canGrowBefore = growBefore && startIdx > 0;
+      const canGrowAfter = !growBefore && endIdx < items.length;
+      if (canGrowBefore) {
+        const cost = rowCostFor(items[startIdx - 1], remaining);
+        if (usedRows + cost > rowBudget) break;
+        startIdx -= 1;
+        usedRows += cost;
+      } else if (canGrowAfter) {
+        const cost = rowCostFor(items[endIdx], remaining);
+        if (usedRows + cost > rowBudget) break;
+        endIdx += 1;
+        usedRows += cost;
+      } else if (startIdx > 0) {
+        const cost = rowCostFor(items[startIdx - 1], remaining);
+        if (usedRows + cost > rowBudget) break;
+        startIdx -= 1;
+        usedRows += cost;
+      } else if (endIdx < items.length) {
+        const cost = rowCostFor(items[endIdx], remaining);
+        if (usedRows + cost > rowBudget) break;
+        endIdx += 1;
+        usedRows += cost;
+      } else {
+        break;
+      }
+      growBefore = !growBefore;
     }
-    const endIdx = Math.min(startIdx + maxVisible, items.length);
+
     let lastCategory: string | undefined;
 
     for (let i = startIdx; i < endIdx; i++) {
@@ -125,13 +205,10 @@ export function renderSelectionModalOverlay(
       }
 
       const indicator = isSelected ? `${OVERLAY_GLYPHS.selected} ` : '  ';
-      const indicatorWidth = 2;
-      const remaining = layout.innerWidth - indicatorWidth;
       const labelColor = isSelected ? TITLE_FG : (item.fg ?? BODY_FG);
       const detailColor = isSelected ? BODY_FG : MUTED_FG;
-      const labelWidth = item.detail
-        ? fitLabelDetailColumns(item.label, item.detail, remaining).labelWidth
-        : remaining;
+      const detailLayout = computeDetailLayout(item, remaining);
+      const labelWidth = detailLayout.labelWidth;
       const labelLine = createOverlayContentLine(width, layout, BORDER_FG, isSelected ? SELECTED_BG : DEFAULT_OVERLAY_PALETTE.bodyBg);
         putText(labelLine, layout.margin + 2, indicatorWidth, indicator, {
           fg: isSelected ? TITLE_FG : MUTED_FG,
@@ -144,23 +221,24 @@ export function renderSelectionModalOverlay(
         bold: isSelected,
       });
       if (item.detail) {
-          const detailWidth = fitLabelDetailColumns(item.label, item.detail, remaining).detailWidth;
-        if (detailWidth >= 12) {
+        if (detailLayout.wrappedDetail === null) {
+          // Fits beside the label at a readable width — no truncation needed.
           putText(labelLine, layout.margin + 2 + indicatorWidth + labelWidth, 2, '  ', {
             fg: BODY_FG,
             bg: isSelected ? SELECTED_BG : DEFAULT_OVERLAY_PALETTE.bodyBg,
           });
-          putText(labelLine, layout.margin + 2 + indicatorWidth + labelWidth + 2, detailWidth, fitDisplay(truncateDisplay(item.detail, detailWidth), detailWidth), {
+          putText(labelLine, layout.margin + 2 + indicatorWidth + labelWidth + 2, detailLayout.detailWidth, fitDisplay(item.detail, detailLayout.detailWidth), {
             fg: detailColor,
             bg: isSelected ? SELECTED_BG : DEFAULT_OVERLAY_PALETTE.bodyBg,
           });
           lines.push(labelLine);
         } else {
+          // Doesn't fit beside the label — wrap the FULL detail text onto as
+          // many lines as it needs below the label, rather than clipping it.
           lines.push(labelLine);
-          const wrappedDetails = wrapWithHangingIndent(item.detail, Math.max(8, remaining), '', 2);
-          for (const detailLineText of wrappedDetails) {
+          for (const detailLineText of detailLayout.wrappedDetail) {
             const detailLine = createOverlayContentLine(width, layout, BORDER_FG, isSelected ? SELECTED_BG : DEFAULT_OVERLAY_PALETTE.bodyBg);
-            putText(detailLine, layout.margin + 2 + indicatorWidth, remaining, fitDisplay(truncateDisplay(detailLineText, remaining), remaining), {
+            putText(detailLine, layout.margin + 2 + indicatorWidth, remaining, fitDisplay(detailLineText, remaining), {
               fg: detailColor,
               bg: isSelected ? SELECTED_BG : DEFAULT_OVERLAY_PALETTE.bodyBg,
               dim: !isSelected,
@@ -173,7 +251,7 @@ export function renderSelectionModalOverlay(
       }
     }
 
-    if (items.length > maxVisible) {
+    if (startIdx > 0 || endIdx < items.length) {
       const above = startIdx;
       const below = items.length - endIdx;
       const scrollHint = above > 0 && below > 0

package/src/version.ts

@@ -6,7 +6,7 @@ import { join } from 'node:path';
 // The prebuild script updates the fallback value before compilation.
 // Uses import.meta.dir (Bun) to locate package.json relative to this file,
 // which is correct regardless of the process working directory.
-let _version = '1.16.0';
+let _version = '1.16.1';
 try {
   const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8'));
   _version = pkg.version ?? _version;