@pellux/goodvibes-tui 1.0.0 → 1.7.0

package/src/panels/agent-inspector-shared.ts

@@ -1,5 +1,5 @@
 import { formatDuration } from '../utils/format-duration.ts';
-import { calcSessionCost } from '../export/cost-utils.ts';
+import { calcSessionCost, isModelPriced } from '../export/cost-utils.ts';
 import type { AgentEvent } from '@/runtime/index.ts';
 import type { UiEventFeed } from '../runtime/ui-events.ts';
 
@@ -7,7 +7,8 @@ export type AgentInspectorEntryKind = 'user' | 'assistant' | 'tool_call' | 'tool
 
 // ---------------------------------------------------------------------------
 // Shared agent status / stall constants
-// Used by AgentInspectorPanel, AgentDetailModal, and cockpit read-model consumers.
+// Used by the Fleet panel's agent views and read-model consumers (formerly also
+// AgentDetailModal, which was retired in W6.1).
 // ---------------------------------------------------------------------------
 
 /** Terminal statuses — cancel not offered; stall check skipped. */
@@ -171,6 +172,8 @@ export function formatAgentCost(usd: number): string {
 export interface AgentUsageSummary {
   readonly tokens: number;
   readonly cost: number;
+  /** False when the model never resolved to a real price — `cost` is a zero placeholder, not a real reading. */
+  readonly priced: boolean;
 }
 
 interface AgentUsageLike {
@@ -183,22 +186,43 @@ interface AgentUsageLike {
   readonly model?: string | null;
 }
 
+/**
+ * True when a usage object carries actual reported token data rather than
+ * being present-but-empty. W0.9: the SDK's AgentRecord.usage is initialised
+ * to an all-zero object at agent spawn (platform/tools/agent/manager.ts) and
+ * — in the currently pinned SDK version — is never updated past that, so a
+ * plain truthiness check on `rec.usage` treats every agent, including ones
+ * that did real work, as "has data" and renders a fabricated $0.00/0-token
+ * reading. Guarding on real (nonzero) counts instead keeps today's "n/a"
+ * honest and lights up automatically once a future SDK actually populates
+ * usage — no further TUI change needed.
+ */
+export function hasReportedUsage(
+  usage: AgentUsageLike['usage'],
+): usage is NonNullable<AgentUsageLike['usage']> {
+  if (!usage) return false;
+  return usage.inputTokens > 0 || usage.outputTokens > 0
+    || (usage.cacheReadTokens ?? 0) > 0 || (usage.cacheWriteTokens ?? 0) > 0;
+}
+
 /**
  * Total token count + cost for an agent record's usage, or null when no usage
  * data has landed yet (honest-UX: never fabricate a $0.00/0-token reading for
  * an agent that simply hasn't reported usage).
  */
 export function summarizeAgentUsage(rec: AgentUsageLike): AgentUsageSummary | null {
-  if (!rec.usage) return null;
-  const inputTokens = rec.usage.inputTokens + (rec.usage.cacheReadTokens ?? 0) + (rec.usage.cacheWriteTokens ?? 0);
+  if (!hasReportedUsage(rec.usage)) return null;
+  const usage = rec.usage;
+  const model = rec.model ?? 'unknown';
+  const inputTokens = usage.inputTokens + (usage.cacheReadTokens ?? 0) + (usage.cacheWriteTokens ?? 0);
   const cost = calcSessionCost(
-    rec.usage.inputTokens,
-    rec.usage.outputTokens,
-    rec.usage.cacheReadTokens ?? 0,
-    rec.usage.cacheWriteTokens ?? 0,
-    rec.model ?? 'unknown',
+    usage.inputTokens,
+    usage.outputTokens,
+    usage.cacheReadTokens ?? 0,
+    usage.cacheWriteTokens ?? 0,
+    model,
   );
-  return { tokens: inputTokens + rec.usage.outputTokens, cost };
+  return { tokens: inputTokens + usage.outputTokens, cost, priced: isModelPriced(model) };
 }
 
 // ---------------------------------------------------------------------------
@@ -226,7 +250,7 @@ export function buildWrfcCostSegments(
     segments.push([segments.length > 0 ? '   Tokens ' : ' Tokens ', palette.label]);
     segments.push([formatTokens(usage.tokens), palette.info]);
     segments.push(['   Cost ', palette.label]);
-    segments.push([formatAgentCost(usage.cost), palette.info]);
+    segments.push([usage.priced ? formatAgentCost(usage.cost) : 'unpriced', palette.info]);
   }
   return segments.length > 0 ? segments : null;
 }

package/src/panels/base-panel.ts

@@ -9,6 +9,20 @@ import { fitDisplay } from '../utils/terminal-width.ts';
 /** Canonical error-surface foreground (bad/red), kept out of the render body. */
 const ERROR_FG = '#ef4444';
 
+/**
+ * Frame requester wired by main.ts to the render scheduler. Without it,
+ * markDirty() only sets a flag the compositor reads when a frame is ALREADY
+ * being composed for another reason (input, streaming) — so a live panel
+ * (fleet ticks, registry subscriptions) sat visibly stale while the app was
+ * idle until the next keypress (Wave-6 replay finding). The scheduler
+ * coalesces same-tick requests, so this stays cheap.
+ */
+let panelFrameRequester: (() => void) | null = null;
+
+export function setPanelFrameRequester(requester: (() => void) | null): void {
+  panelFrameRequester = requester;
+}
+
 export abstract class BasePanel implements Panel {
   public needsRender = true;
   public isTransient = false;
@@ -219,7 +233,14 @@ export abstract class BasePanel implements Panel {
   /** R2: Called by the compositor after a successful render to clear the dirty flag. */
   public markRendered(): void { this.needsRender = false; }
 
-  protected markDirty(): void { this.needsRender = true; }
+  protected markDirty(): void {
+    // Request only on the false→true transition: a pending frame already
+    // covers repeat marks, and a panel that dirties itself mid-render must
+    // not schedule frames forever.
+    const wasDirty = this.needsRender;
+    this.needsRender = true;
+    if (!wasDirty) panelFrameRequester?.();
+  }
 
   /**
    * Check whether the panel is currently permitted to render.

package/src/panels/builtin/agent.ts

@@ -1,113 +1,27 @@
 import type { PanelManager } from '../panel-manager.ts';
-import { AgentInspectorPanel } from '../agent-inspector-panel.ts';
-import { ThinkingPanel } from '../thinking-panel.ts';
-import { ToolInspectorPanel } from '../tool-inspector-panel.ts';
-import { WrfcPanel } from '../wrfc-panel.ts';
-import { ProjectPlanningPanel } from '../project-planning-panel.ts';
-import { WorkPlanPanel } from '../work-plan-panel.ts';
 import type { ResolvedBuiltinPanelDeps } from './shared.ts';
-import { requireUiServices } from './shared.ts';
 
+// W6.1 (the purge): thinking, tools, inspector, and wrfc were registered here
+// before the purge. thinking/tools were DELETE-disposition (no surviving
+// human surface — thinking already renders inline in the transcript, tool
+// results render inline plus per-node in Fleet); inspector/wrfc were
+// RETIRE-INTO-FLEET (their live console is subsumed by the Fleet panel,
+// operations.ts:84). See registerOperationsPanels for the fleet
+// registration and .goodvibes/audit/2026-07-04-wave6-briefs.json (W6.1) for
+// the full disposition map.
 export function registerAgentPanels(manager: PanelManager, deps: ResolvedBuiltinPanelDeps): void {
-  manager.registerType({
-    id: 'thinking',
-    name: 'Thinking',
-    icon: 'T',
-    category: 'ai',
-    description: 'Stream model reasoning tokens in real-time with collapsible blocks per turn',
-    preload: true,
-    retainOnClose: true,
-    factory: () => new ThinkingPanel(requireUiServices(deps).events.turns),
-  });
+  // Compat: '/panel open agent-logs' and 'inspector' (and any saved
+  // layout/muscle memory) still resolve — redirected straight to fleet.
+  // Repointed from agent-logs->inspector (WO-110) now that inspector itself
+  // is retired; alias resolution is a single hop (PanelManager._resolveId),
+  // so this must point at the real surviving id, not at another alias.
+  manager.registerAlias('agent-logs', 'fleet');
+  manager.registerAlias('inspector', 'fleet');
+  manager.registerAlias('wrfc', 'fleet');
 
-  manager.registerType({
-    id: 'tools',
-    name: 'Tools',
-    icon: 'X',
-    category: 'ai',
-    description: 'Chronological tool call inspector with expandable args/results and filtering',
-    preload: true,
-    retainOnClose: true,
-    factory: () => {
-      const ui = requireUiServices(deps);
-      return new ToolInspectorPanel(ui.events.tools, ui.events.turns);
-    },
-  });
-
-  // WO-110: agent-logs merged into inspector — one deep agent console with
-  // the correct JSONL parser + cancel, plus agent-logs' follow/pause/filter
-  // ergonomics. Registration moved here (category 'agent') from
-  // builtin/development.ts. (WO-113 retired the 'context' registration that
-  // previously lived here: ContextVisualizerPanel merged into TokenBudgetPanel,
-  // aliased in builtin/session.ts.)
-  manager.registerType({
-    id: 'inspector',
-    name: 'Inspector',
-    icon: 'I',
-    category: 'agent',
-    description: 'Live per-agent console: timeline, tool calls, WRFC/cost badges, pause/filter/follow, and cancel',
-    preload: true,
-    retainOnClose: true,
-    factory: () => {
-      const ui = requireUiServices(deps);
-      return new AgentInspectorPanel({
-        agentManager: ui.agents.agentManager,
-        agentMessageBus: ui.agents.agentMessageBus,
-        agentEvents: ui.events.agents,
-        workingDirectory: ui.environment.workingDirectory,
-        cancelAgent: (agentId: string) => ui.agents.agentManager.cancel(agentId),
-        requestRender: deps.requestRender,
-      });
-    },
-  });
-
-  // Compat: '/panel open agent-logs' (and any saved layout/muscle memory)
-  // still resolves — redirected to the merged inspector console.
-  manager.registerAlias('agent-logs', 'inspector');
-
-  manager.registerType({
-    id: 'wrfc',
-    name: 'WRFC',
-    icon: 'W',
-    category: 'agent',
-    description: 'WRFC chain view: write, review, fix, and confirm cycle status',
-    preload: true,
-    retainOnClose: true,
-    factory: () => {
-      const ui = requireUiServices(deps);
-      return new WrfcPanel(ui.events.workflows, {
-        controller: ui.agents.wrfcController,
-        cancelChain: (agentId: string) => ui.agents.agentManager.cancel(agentId),
-      });
-    },
-  });
-
-  manager.registerType({
-    id: 'work-plan',
-    name: 'Work Plan',
-    // WO-152: was 'L' (collided with panel-list).
-    icon: '◧',
-    category: 'agent',
-    description: 'Persistent workspace checklist for multi-step work and cross-session task tracking',
-    preload: true,
-    retainOnClose: true,
-    factory: () => new WorkPlanPanel(deps.workPlanStore),
-  });
-
-  manager.registerType({
-    id: 'project-planning',
-    name: 'Planning',
-    icon: 'P',
-    category: 'agent',
-    description: 'Passive project planning artifacts: readiness, questions, decisions, language, task graph, and agent handoff metadata',
-    preload: true,
-    retainOnClose: true,
-    factory: () => new ProjectPlanningPanel({
-      service: deps.projectPlanningService,
-      projectId: deps.projectPlanningProjectId,
-      requestRender: deps.requestRender,
-      submitAnswer: deps.submitPlanningAnswer,
-      dismissPlanning: deps.dismissPlanning,
-    }),
-  });
+  // W6.1 (the purge) — group B (WO-P): 'work-plan' and 'project-planning'
+  // migrated to the 'work-plan-modal' / 'planning-modal' config-modal surfaces.
+  // Their surfaces AND panel→modal redirects are registered centrally in
+  // registerBuiltinModals (builtin-modals.ts). Panel registrations retired here.
+  void deps;
 }

package/src/panels/builtin/development.ts

@@ -1,15 +1,18 @@
 import type { PanelManager } from '../panel-manager.ts';
 import { GitPanel } from '../git-panel.ts';
 import { DiffPanel } from '../diff-panel.ts';
-import { PlanDashboardPanel } from '../plan-dashboard-panel.ts';
 import { CostTrackerPanel } from '../cost-tracker-panel.ts';
-import { IntelligencePanel } from '../intelligence-panel.ts';
-import { FileExplorerPanel } from '../file-explorer-panel.ts';
-import { FilePreviewPanel } from '../file-preview-panel.ts';
-import { SymbolOutlinePanel } from '../symbol-outline-panel.ts';
 import type { ResolvedBuiltinPanelDeps } from './shared.ts';
 import { requireUiServices, withUnconfiguredFallback } from './shared.ts';
 
+// W6.1 (the purge): plan, intelligence, explorer, preview, and symbols were
+// registered here before the purge. plan was RETIRE-INTO-FLEET (its
+// execution-plan view is subsumed by Fleet — operations.ts:84); the other
+// four were DELETE-disposition (no surviving human surface — intelligence's
+// read-model still backs the surviving `/intelligence` CLI subcommands, see
+// intelligence-runtime.ts; explorer/preview/symbols had no dedicated
+// read-model to preserve). See .goodvibes/audit/2026-07-04-wave6-briefs.json
+// (W6.1) for the full disposition map.
 export function registerDevelopmentPanels(manager: PanelManager, deps: ResolvedBuiltinPanelDeps): void {
   manager.registerType({
     id: 'git',
@@ -26,19 +29,9 @@ export function registerDevelopmentPanels(manager: PanelManager, deps: ResolvedB
     ),
   });
 
-  manager.registerType({
-    id: 'plan',
-    name: 'Plan',
-    // Distinct from Planning's 'P' (builtin/agent.ts) — interim glyph per
-    // WO-128; WO-152 owns the registry-wide icon-uniqueness assertion.
-    icon: '▤',
-    category: 'agent',
-    description: 'Active execution plan with phase progress and item status',
-    factory: () => {
-      const ui = requireUiServices(deps);
-      return new PlanDashboardPanel(ui.events.workflows, { planManager: deps.planManager });
-    },
-  });
+  // Compat: '/panel open plan' (and any saved layout/muscle memory) still
+  // resolves — redirected to fleet, which absorbs the execution-plan view.
+  manager.registerAlias('plan', 'fleet');
 
   manager.registerType({
     id: 'diff',
@@ -46,7 +39,7 @@ export function registerDevelopmentPanels(manager: PanelManager, deps: ResolvedB
     icon: 'D',
     category: 'development',
     description: 'Unified diff view of agent file changes',
-    factory: () => new DiffPanel(requireUiServices(deps).environment.workingDirectory),
+    factory: () => new DiffPanel(requireUiServices(deps).environment.workingDirectory, deps.requestRender),
   });
 
   // WO-110: 'inspector' registration moved to builtin/agent.ts (category
@@ -73,52 +66,13 @@ export function registerDevelopmentPanels(manager: PanelManager, deps: ResolvedB
           return new CostTrackerPanel(ui.events.turns, ui.events.agents, getOrchestratorUsage!, {
             budgetThreshold,
             getAgentStatus: (id) => ui.agents.agentManager.getStatus(id),
+            configAccess: {
+              get: (key) => deps.configManager.get(key as Parameters<typeof deps.configManager.get>[0]),
+              set: (key, value) => deps.configManager.set(key as Parameters<typeof deps.configManager.set>[0], value as never),
+            },
           });
         },
       ),
     });
   }
-
-  manager.registerType({
-    id: 'intelligence',
-    name: 'Intelligence',
-    icon: 'J',
-    category: 'development',
-    description: 'Workspace diagnostics, symbol search, hover, and completion readiness with recovery guidance',
-    factory: () => new IntelligencePanel(requireUiServices(deps).readModels.intelligence),
-  });
-
-  manager.registerType({
-    id: 'explorer',
-    name: 'Explorer',
-    icon: 'E',
-    category: 'development',
-    description: 'File system browser with keyboard navigation',
-    factory: () => {
-        const ui = requireUiServices(deps);
-        return new FileExplorerPanel(ui.environment.workingDirectory, ui.environment.workingDirectory);
-      },
-    });
-
-  manager.registerType({
-    id: 'preview',
-    name: 'Preview',
-    // WO-152: was 'V' in the registry vs the live panel's own 'P' (base-panel
-    // super() call) — a pre-existing registry/instance icon mismatch as well
-    // as a collision (project-planning and plugins both also used 'P').
-    // Unified to a single unique glyph in both places.
-    icon: '◑',
-    category: 'development',
-    description: 'Syntax-highlighted file preview',
-    factory: () => new FilePreviewPanel(),
-  });
-
-  manager.registerType({
-    id: 'symbols',
-    name: 'Symbols',
-    icon: 'S',
-    category: 'development',
-    description: 'Symbol outline for the active file: functions, classes, and exports',
-    factory: () => new SymbolOutlinePanel(),
-  });
 }

package/src/panels/builtin/knowledge.ts

@@ -1,36 +1,12 @@
 import type { PanelManager } from '../panel-manager.ts';
-import { MemoryPanel } from '../memory-panel.ts';
-import { KnowledgeGraphPanel } from '../knowledge-graph-panel.ts';
-import { requireKnowledgeApi, withUnconfiguredFallback, type ResolvedBuiltinPanelDeps } from './shared.ts';
+import type { ResolvedBuiltinPanelDeps } from './shared.ts';
 
+// W6.1 (the purge) — group B: 'knowledge' and 'memory' migrated to the
+// 'knowledge-modal' / 'memory-modal' config-modal surfaces. Both surfaces and
+// their panel→modal redirects are registered centrally in registerBuiltinModals
+// (src/panels/builtin-modals.ts). This registrar is intentionally empty
+// post-migration, kept as a stable call site invoked from registerBuiltinPanels.
 export function registerKnowledgePanels(manager: PanelManager, deps: ResolvedBuiltinPanelDeps): void {
-  manager.registerType({
-    id: 'knowledge',
-    name: 'Knowledge',
-    icon: 'K',
-    category: 'agent',
-    description: 'Live SDK knowledge graph: nodes, sources, issue review queue, and search',
-    factory: () => new KnowledgeGraphPanel(requireKnowledgeApi(deps), () => manager.open('memory')),
-  });
-  // WO-152: always registered (was gated behind `if (deps.memoryRegistry)`,
-  // so `/panel open memory` reported "Unknown panel" on builds without a
-  // memory registry wired). Falls back to a "dependency not configured"
-  // empty state.
-  {
-    const { memoryRegistry } = deps;
-    manager.registerType({
-      id: 'memory',
-      name: 'Memory',
-      icon: 'M',
-      category: 'agent',
-      description: 'Project memory: decisions, constraints, incidents, and patterns with provenance links',
-      factory: withUnconfiguredFallback(
-        memoryRegistry !== undefined,
-        'memory', 'Memory', 'M', 'agent',
-        ' Memory registry not configured for this session.',
-        'This runtime was not wired with a project memory registry at bootstrap, so no memory data is available.',
-        () => new MemoryPanel(memoryRegistry!),
-      ),
-    });
-  }
+  void manager;
+  void deps;
 }