@pellux/goodvibes-tui 0.28.0 → 0.29.0

package/src/panels/builtin/agent.ts

@@ -1,14 +1,12 @@
 import type { PanelManager } from '../panel-manager.ts';
-import { AgentLogsPanel } from '../agent-logs-panel.ts';
-import { ContextVisualizerPanel } from '../context-visualizer-panel.ts';
+import { AgentInspectorPanel } from '../agent-inspector-panel.ts';
 import { ThinkingPanel } from '../thinking-panel.ts';
 import { ToolInspectorPanel } from '../tool-inspector-panel.ts';
 import { WrfcPanel } from '../wrfc-panel.ts';
-import { SchedulePanel } from '../schedule-panel.ts';
 import { ProjectPlanningPanel } from '../project-planning-panel.ts';
 import { WorkPlanPanel } from '../work-plan-panel.ts';
 import type { ResolvedBuiltinPanelDeps } from './shared.ts';
-import { requireAutomationManager, requireUiServices } from './shared.ts';
+import { requireUiServices } from './shared.ts';
 
 export function registerAgentPanels(manager: PanelManager, deps: ResolvedBuiltinPanelDeps): void {
   manager.registerType({
@@ -18,6 +16,7 @@ export function registerAgentPanels(manager: PanelManager, deps: ResolvedBuiltin
     category: 'ai',
     description: 'Stream model reasoning tokens in real-time with collapsible blocks per turn',
     preload: true,
+    retainOnClose: true,
     factory: () => new ThinkingPanel(requireUiServices(deps).events.turns),
   });
 
@@ -28,47 +27,44 @@ export function registerAgentPanels(manager: PanelManager, deps: ResolvedBuiltin
     category: 'ai',
     description: 'Chronological tool call inspector with expandable args/results and filtering',
     preload: true,
+    retainOnClose: true,
     factory: () => {
       const ui = requireUiServices(deps);
       return new ToolInspectorPanel(ui.events.tools, ui.events.turns);
     },
   });
 
+  // WO-110: agent-logs merged into inspector — one deep agent console with
+  // the correct JSONL parser + cancel, plus agent-logs' follow/pause/filter
+  // ergonomics. Registration moved here (category 'agent') from
+  // builtin/development.ts. (WO-113 retired the 'context' registration that
+  // previously lived here: ContextVisualizerPanel merged into TokenBudgetPanel,
+  // aliased in builtin/session.ts.)
   manager.registerType({
-    id: 'context',
-    name: 'Context',
-    icon: 'C',
-    category: 'ai',
-    description: 'Context window visualizer: stacked bar showing token usage per section',
-    preload: true,
-    factory: () => new ContextVisualizerPanel(
-      requireUiServices(deps).events.turns,
-      deps.sessionMemoryStore,
-      deps.configManager,
-      deps.getOrchestratorUsage,
-      deps.getCtxWindow ?? deps.contextWindow,
-      requireUiServices(deps).readModels.session,
-      () => deps.orchestrator?.lastInputTokens ?? 0,
-    ),
-  });
-
-  manager.registerType({
-    id: 'agent-logs',
-    name: 'Agents',
-    icon: 'A',
+    id: 'inspector',
+    name: 'Inspector',
+    icon: 'I',
     category: 'agent',
-    description: 'View-only live session stream from running agents with per-agent switching',
+    description: 'Live per-agent console: timeline, tool calls, WRFC/cost badges, pause/filter/follow, and cancel',
     preload: true,
+    retainOnClose: true,
     factory: () => {
       const ui = requireUiServices(deps);
-      return new AgentLogsPanel(ui.events.agents, {
+      return new AgentInspectorPanel({
         agentManager: ui.agents.agentManager,
+        agentMessageBus: ui.agents.agentMessageBus,
+        agentEvents: ui.events.agents,
         workingDirectory: ui.environment.workingDirectory,
+        cancelAgent: (agentId: string) => ui.agents.agentManager.cancel(agentId),
         requestRender: deps.requestRender,
       });
     },
   });
 
+  // Compat: '/panel open agent-logs' (and any saved layout/muscle memory)
+  // still resolves — redirected to the merged inspector console.
+  manager.registerAlias('agent-logs', 'inspector');
+
   manager.registerType({
     id: 'wrfc',
     name: 'WRFC',
@@ -76,6 +72,7 @@ export function registerAgentPanels(manager: PanelManager, deps: ResolvedBuiltin
     category: 'agent',
     description: 'WRFC chain view: write, review, fix, and confirm cycle status',
     preload: true,
+    retainOnClose: true,
     factory: () => {
       const ui = requireUiServices(deps);
       return new WrfcPanel(ui.events.workflows, {
@@ -88,10 +85,12 @@ export function registerAgentPanels(manager: PanelManager, deps: ResolvedBuiltin
   manager.registerType({
     id: 'work-plan',
     name: 'Work Plan',
-    icon: 'L',
+    // WO-152: was 'L' (collided with panel-list).
+    icon: '◧',
     category: 'agent',
     description: 'Persistent workspace checklist for multi-step work and cross-session task tracking',
     preload: true,
+    retainOnClose: true,
     factory: () => new WorkPlanPanel(deps.workPlanStore),
   });
 
@@ -102,6 +101,7 @@ export function registerAgentPanels(manager: PanelManager, deps: ResolvedBuiltin
     category: 'agent',
     description: 'Passive project planning artifacts: readiness, questions, decisions, language, task graph, and agent handoff metadata',
     preload: true,
+    retainOnClose: true,
     factory: () => new ProjectPlanningPanel({
       service: deps.projectPlanningService,
       projectId: deps.projectPlanningProjectId,
@@ -110,13 +110,4 @@ export function registerAgentPanels(manager: PanelManager, deps: ResolvedBuiltin
       dismissPlanning: deps.dismissPlanning,
     }),
   });
-
-  manager.registerType({
-    id: 'schedule',
-    name: 'Schedule',
-    icon: 'Z',
-    category: 'agent',
-    description: 'Scheduled agent tasks: cron expressions, next run time, enable/disable, run history',
-    factory: () => new SchedulePanel(requireAutomationManager(deps)),
-  });
 }

package/src/panels/builtin/development.ts

@@ -2,14 +2,13 @@ import type { PanelManager } from '../panel-manager.ts';
 import { GitPanel } from '../git-panel.ts';
 import { DiffPanel } from '../diff-panel.ts';
 import { PlanDashboardPanel } from '../plan-dashboard-panel.ts';
-import { AgentInspectorPanel } from '../agent-inspector-panel.ts';
 import { CostTrackerPanel } from '../cost-tracker-panel.ts';
 import { IntelligencePanel } from '../intelligence-panel.ts';
 import { FileExplorerPanel } from '../file-explorer-panel.ts';
 import { FilePreviewPanel } from '../file-preview-panel.ts';
 import { SymbolOutlinePanel } from '../symbol-outline-panel.ts';
 import type { ResolvedBuiltinPanelDeps } from './shared.ts';
-import { requireUiServices } from './shared.ts';
+import { requireUiServices, withUnconfiguredFallback } from './shared.ts';
 
 export function registerDevelopmentPanels(manager: PanelManager, deps: ResolvedBuiltinPanelDeps): void {
   manager.registerType({
@@ -18,16 +17,27 @@ export function registerDevelopmentPanels(manager: PanelManager, deps: ResolvedB
     icon: 'G',
     category: 'development',
     description: 'Git status, staged/unstaged changes, and recent commits',
-    factory: () => new GitPanel(requireUiServices(deps).environment.workingDirectory, deps.requestRender),
+    // sessionChangeTracker is optional: when a caller wires it into
+    // BuiltinPanelDeps, the Git panel highlights files touched this session.
+    factory: () => new GitPanel(
+      requireUiServices(deps).environment.workingDirectory,
+      deps.requestRender,
+      deps.sessionChangeTracker ? () => deps.sessionChangeTracker!.getChangedFiles() : undefined,
+    ),
   });
 
   manager.registerType({
     id: 'plan',
     name: 'Plan',
-    icon: 'P',
+    // Distinct from Planning's 'P' (builtin/agent.ts) — interim glyph per
+    // WO-128; WO-152 owns the registry-wide icon-uniqueness assertion.
+    icon: '▤',
     category: 'agent',
     description: 'Active execution plan with phase progress and item status',
-    factory: () => new PlanDashboardPanel(deps.planManager),
+    factory: () => {
+      const ui = requireUiServices(deps);
+      return new PlanDashboardPanel(ui.events.workflows, { planManager: deps.planManager });
+    },
   });
 
   manager.registerType({
@@ -39,39 +49,33 @@ export function registerDevelopmentPanels(manager: PanelManager, deps: ResolvedB
     factory: () => new DiffPanel(requireUiServices(deps).environment.workingDirectory),
   });
 
-  manager.registerType({
-    id: 'inspector',
-    name: 'Inspector',
-    icon: 'I',
-    category: 'agent',
-    description: "Detailed timeline view of a specific agent's messages and tool calls",
-    factory: () => {
-      const ui = requireUiServices(deps);
-      return new AgentInspectorPanel({
-        agentManager: ui.agents.agentManager,
-        agentMessageBus: ui.agents.agentMessageBus,
-        workingDirectory: ui.environment.workingDirectory,
-        cancelAgent: (agentId: string) => ui.agents.agentManager.cancel(agentId),
-        requestRender: deps.requestRender,
-      });
-    },
-  });
+  // WO-110: 'inspector' registration moved to builtin/agent.ts (category
+  // 'agent') — it now absorbs the merged agent-logs capabilities.
 
-  if (deps.getOrchestratorUsage) {
+  // WO-152: always registered (was gated behind `if (deps.getOrchestratorUsage)`,
+  // so `/panel open cost` reported "Unknown panel" on builds without usage
+  // tracking wired). Falls back to a "dependency not configured" empty state.
+  {
     const { getOrchestratorUsage, budgetThreshold } = deps;
     manager.registerType({
       id: 'cost',
       name: 'Cost',
       icon: '$',
-      category: 'monitoring',
+      category: 'providers',
       description: 'Estimated costs per session, agent, and plan with budget alerts',
-      factory: () => {
-        const ui = requireUiServices(deps);
-        return new CostTrackerPanel(ui.events.turns, ui.events.agents, getOrchestratorUsage, {
-          budgetThreshold,
-          getAgentStatus: (id) => ui.agents.agentManager.getStatus(id),
-        });
-      },
+      factory: withUnconfiguredFallback(
+        getOrchestratorUsage !== undefined,
+        'cost', 'Cost', '$', 'providers',
+        ' Cost tracking not configured for this session.',
+        'This runtime was not wired with orchestrator usage tracking at bootstrap, so no cost data is available.',
+        () => {
+          const ui = requireUiServices(deps);
+          return new CostTrackerPanel(ui.events.turns, ui.events.agents, getOrchestratorUsage!, {
+            budgetThreshold,
+            getAgentStatus: (id) => ui.agents.agentManager.getStatus(id),
+          });
+        },
+      ),
     });
   }
 
@@ -99,7 +103,11 @@ export function registerDevelopmentPanels(manager: PanelManager, deps: ResolvedB
   manager.registerType({
     id: 'preview',
     name: 'Preview',
-    icon: 'V',
+    // WO-152: was 'V' in the registry vs the live panel's own 'P' (base-panel
+    // super() call) — a pre-existing registry/instance icon mismatch as well
+    // as a collision (project-planning and plugins both also used 'P').
+    // Unified to a single unique glyph in both places.
+    icon: '◑',
     category: 'development',
     description: 'Syntax-highlighted file preview',
     factory: () => new FilePreviewPanel(),

package/src/panels/builtin/knowledge.ts

@@ -1,19 +1,22 @@
 import type { PanelManager } from '../panel-manager.ts';
 import { MemoryPanel } from '../memory-panel.ts';
 import { KnowledgeGraphPanel } from '../knowledge-graph-panel.ts';
-import type { ResolvedBuiltinPanelDeps } from './shared.ts';
+import { requireKnowledgeApi, withUnconfiguredFallback, type ResolvedBuiltinPanelDeps } from './shared.ts';
 
 export function registerKnowledgePanels(manager: PanelManager, deps: ResolvedBuiltinPanelDeps): void {
-  // KnowledgeGraphPanel is a no-arg panel — always register it regardless of memoryRegistry.
   manager.registerType({
     id: 'knowledge',
     name: 'Knowledge',
     icon: 'K',
     category: 'agent',
-    description: 'Structured project knowledge: risks, runbooks, architecture notes, incidents, and durable facts',
-    factory: () => new KnowledgeGraphPanel(),
+    description: 'Live SDK knowledge graph: nodes, sources, issue review queue, and search',
+    factory: () => new KnowledgeGraphPanel(requireKnowledgeApi(deps), () => manager.open('memory')),
   });
-  if (deps.memoryRegistry) {
+  // WO-152: always registered (was gated behind `if (deps.memoryRegistry)`,
+  // so `/panel open memory` reported "Unknown panel" on builds without a
+  // memory registry wired). Falls back to a "dependency not configured"
+  // empty state.
+  {
     const { memoryRegistry } = deps;
     manager.registerType({
       id: 'memory',
@@ -21,7 +24,13 @@ export function registerKnowledgePanels(manager: PanelManager, deps: ResolvedBui
       icon: 'M',
       category: 'agent',
       description: 'Project memory: decisions, constraints, incidents, and patterns with provenance links',
-      factory: () => new MemoryPanel(memoryRegistry),
+      factory: withUnconfiguredFallback(
+        memoryRegistry !== undefined,
+        'memory', 'Memory', 'M', 'agent',
+        ' Memory registry not configured for this session.',
+        'This runtime was not wired with a project memory registry at bootstrap, so no memory data is available.',
+        () => new MemoryPanel(memoryRegistry!),
+      ),
     });
   }
 }