@pellux/goodvibes-tui 0.26.0 → 0.28.0

package/src/panels/plugins-panel.ts

@@ -1,9 +1,13 @@
 import type { Line } from '../types/grid.ts';
 import { createEmptyLine } from '../types/grid.ts';
+import { truncateDisplay } from '../utils/terminal-width.ts';
 import { ScrollableListPanel } from './scrollable-list-panel.ts';
 import type { PluginManagerObserver, PluginStatus } from '@pellux/goodvibes-sdk/platform/plugins';
 import {
+  buildDetailBlock,
   buildEmptyState,
+  buildKeyValueLine,
+  buildKeyboardHints,
   buildPanelLine,
   buildPanelWorkspace,
   DEFAULT_PANEL_PALETTE,
@@ -53,10 +57,18 @@ export class PluginsPanel extends ScrollableListPanel<PluginStatus> {
   public constructor(manager: PluginManagerObserver) {
     super('plugins', 'Plugins', 'P', 'monitoring');
     this.showSelectionGutter = true; // I5: non-color selection affordance
+    this.filterEnabled = true;
+    this.filterLabel = 'Filter plugins';
     this.manager = manager;
     this.unsub = manager.subscribe(() => this.markDirty());
   }
 
+  protected override filterMatches(plugin: PluginStatus, q: string): boolean {
+    return plugin.name.toLowerCase().includes(q)
+      || plugin.trustTier.toLowerCase().includes(q)
+      || plugin.version.toLowerCase().includes(q);
+  }
+
   public override onActivate(): void {
     super.onActivate();
     this.selectedIndex = 0;
@@ -122,15 +134,30 @@ export class PluginsPanel extends ScrollableListPanel<PluginStatus> {
       return workspace;
     }
 
+    // Provenance/error posture header — surface trust + quarantine pressure first.
+    const quarantined = plugins.filter((p) => p.quarantined).length;
+    const untrusted = plugins.filter((p) => p.trustTier === 'untrusted').length;
+    const active = plugins.filter((p) => p.active).length;
+    const headerLines: Line[] = [
+      buildKeyValueLine(width, [
+        { label: 'plugins', value: String(plugins.length), valueColor: C.info },
+        { label: 'active', value: String(active), valueColor: active > 0 ? C.ok : C.dim },
+        { label: 'untrusted', value: String(untrusted), valueColor: untrusted > 0 ? C.warn : C.dim },
+        { label: 'quarantined', value: String(quarantined), valueColor: quarantined > 0 ? C.error : C.dim },
+      ], C),
+    ];
+
     this.clampSelection();
     const selected = plugins[this.selectedIndex]!;
     const selectedCaps = this.manager.capabilities(selected.name);
     const trustRecord = this.manager.getTrustRecord(selected.name);
     const quarantineRecord = this.manager.getQuarantineRecord(selected.name);
-    const detailLines: Line[] = [
+    const detailRows: Line[] = [
       buildPanelLine(width, [
         ['  Plugin: ', C.label],
         [selected.name, C.value],
+        ['  v', C.label],
+        [selected.version, C.dim],
         ['  State: ', C.label],
         [statusLabel(selected), statusColor(selected)],
         ['  Trust: ', C.label],
@@ -138,12 +165,12 @@ export class PluginsPanel extends ScrollableListPanel<PluginStatus> {
       ]),
       buildPanelLine(width, [
         ['  Description: ', C.label],
-        [selected.description.slice(0, Math.max(0, width - 15)), C.dim],
+        [truncateDisplay(selected.description, Math.max(0, width - 15)), C.dim],
       ]),
     ];
 
     if (selectedCaps) {
-      detailLines.push(buildPanelLine(width, [
+      detailRows.push(buildPanelLine(width, [
         ['  Capabilities: ', C.label],
         [String(selectedCaps.requested.length), C.value],
         ['  High-risk: ', C.label],
@@ -154,25 +181,36 @@ export class PluginsPanel extends ScrollableListPanel<PluginStatus> {
     }
 
     if (trustRecord?.signatureFingerprint) {
-      detailLines.push(buildPanelLine(width, [
+      detailRows.push(buildPanelLine(width, [
         ['  Signature: ', C.label],
-        [trustRecord.signatureFingerprint, C.info],
+        [truncateDisplay(trustRecord.signatureFingerprint, Math.max(0, width - 14)), C.info],
       ]));
+    } else {
+      detailRows.push(buildPanelLine(width, [['  Signature: unsigned (no provenance fingerprint on record)', C.warn]]));
     }
 
     if (quarantineRecord) {
-      detailLines.push(buildPanelLine(width, [
+      detailRows.push(buildPanelLine(width, [
         ['  Quarantine: ', C.label],
-        [quarantineRecord.reason.slice(0, Math.max(0, width - 14)), C.error],
+        [truncateDisplay(quarantineRecord.reason, Math.max(0, width - 14)), C.error],
       ]));
     }
 
-    detailLines.push(buildPanelLine(width, [['  Inspect trust and capability state here, then use /plugin to take action.', C.dim]]));
-    detailLines.push(buildPanelLine(width, [['  Up/Down move through discovered plugins', C.dim]]));
+    const hints = this.filterActive
+      ? [{ keys: 'type', label: 'filter' }, { keys: 'Enter', label: 'apply' }, { keys: 'Esc', label: 'clear' }]
+      : [
+          { keys: 'Up/Down', label: 'move' },
+          { keys: '/plugin', label: 'act' },
+          { keys: '/', label: 'filter' },
+        ];
 
     return this.renderList(width, height, {
       title: 'Plugin Control Room',
-      footer: detailLines,
+      header: headerLines,
+      footer: [
+        ...buildDetailBlock(width, `Plugin · ${selected.name}`, detailRows, C),
+        buildKeyboardHints(width, hints, C),
+      ],
     });
   }
 }

package/src/panels/policy-panel.ts

@@ -1,9 +1,13 @@
 import type { Line } from '../types/grid.ts';
 import { createEmptyLine } from '../types/grid.ts';
+import { truncateDisplay } from '../utils/terminal-width.ts';
 import { BasePanel } from './base-panel.ts';
 import type { PolicyRuntimeState } from '@/runtime/index.ts';
 import type { PolicyPanelSnapshot } from '../runtime/diagnostics/panels/policy.ts';
 import {
+  buildEmptyState,
+  buildKeyboardHints,
+  buildKeyValueLine,
   buildPanelLine,
   buildPanelWorkspace,
   resolveScrollablePanelSection,
@@ -89,22 +93,30 @@ export class PolicyPanel extends BasePanel {
   public render(width: number, height: number): Line[] {
     this.needsRender = false;
     const snapshot = this._state.getSnapshot();
+    const summaryLine = this._buildSummary(width, snapshot);
     const content = this._buildContent(width, snapshot);
+    const hintsLine = buildKeyboardHints(width, [
+      { keys: '↑/↓', label: 'scroll' },
+      { keys: 'r', label: 'record divergence snapshot' },
+    ], C);
+    const summarySection = { lines: [summaryLine] };
     const governanceSection = resolveScrollablePanelSection(width, height, {
-      footerLines: [buildPanelLine(width, [['  Up/Down scroll  r record divergence trend snapshot', C.dim]])],
+      footerLines: [hintsLine],
       palette: C,
+      beforeSections: [summarySection],
       section: {
         title: 'Governance',
         scrollableLines: content,
         scrollOffset: this._scrollOffset,
         minRows: 4,
+        appendWindowSummary: content.length > 0 ? { dimColor: C.dim } : undefined,
       },
     });
     this._scrollOffset = governanceSection.scrollOffset;
     const lines = buildPanelWorkspace(width, height, {
       title: 'Policy And Governance',
-      sections: [governanceSection.section],
-      footerLines: [buildPanelLine(width, [['  Up/Down scroll  r record divergence trend snapshot', C.dim]])],
+      sections: [summarySection, governanceSection.section],
+      footerLines: [hintsLine],
       palette: C,
     });
     while (lines.length < height) {
@@ -113,6 +125,28 @@ export class PolicyPanel extends BasePanel {
     return lines.slice(0, height);
   }
 
+  /** Top-of-panel posture summary: the highest-signal governance state at a glance. */
+  private _buildSummary(width: number, snapshot: PolicyPanelSnapshot): Line {
+    const preflight = snapshot.lastPreflightReview;
+    const divergence = snapshot.divergence;
+    const lintCount = snapshot.lintFindings.length;
+    const preflightStatus = preflight ? preflight.status : 'none';
+    const preflightColor = !preflight
+      ? C.dim
+      : preflight.status === 'pass'
+        ? C.ok
+        : preflight.status === 'warn'
+          ? C.warn
+          : C.error;
+    const gateStatus = divergence?.gate.status ?? 'n/a';
+    return buildKeyValueLine(width, [
+      { label: 'bundles', value: `${snapshot.current ? 1 : 0}+${snapshot.candidate ? 1 : 0}c`, valueColor: snapshot.current || snapshot.candidate ? C.value : C.dim },
+      { label: 'preflight', value: preflightStatus.toUpperCase(), valueColor: preflightColor },
+      { label: 'gate', value: gateStatus, valueColor: gateColor(gateStatus) },
+      { label: 'lint', value: String(lintCount), valueColor: lintCount > 0 ? C.warn : C.dim },
+    ], C);
+  }
+
   private _buildContent(width: number, snapshot: PolicyPanelSnapshot): Line[] {
     const lines: Line[] = [];
     const current = snapshot.current;
@@ -123,8 +157,22 @@ export class PolicyPanel extends BasePanel {
     const simulationSummary = snapshot.lastSimulationSummary;
     const preflightReview = snapshot.lastPreflightReview;
 
-    if (!current && !candidate) {
-      lines.push(buildPanelLine(width, [[' No policy bundles loaded. Use /policy load to begin.', C.empty]]));
+    const nothingRecorded = !current && !candidate && !divergence
+      && snapshot.history.length === 0 && permissionAudit.length === 0
+      && lintFindings.length === 0 && !simulationSummary && !preflightReview;
+    if (nothingRecorded) {
+      lines.push(...buildEmptyState(
+        width,
+        ' No policy bundles loaded.',
+        'Load a policy bundle to inspect governance gates, divergence trends, permission audit, lint findings, and preflight posture.',
+        [
+          { command: '/policy load', summary: 'load a policy bundle to begin governance review' },
+          { command: '/policy preflight', summary: 'run a proactive preflight posture review' },
+          { command: '/policy simulate', summary: 'compare authoritative vs candidate decisions' },
+        ],
+        C,
+      ));
+      return lines;
     }
 
     if (current) {
@@ -220,7 +268,7 @@ export class PolicyPanel extends BasePanel {
         ]));
         lines.push(buildPanelLine(width, [
           ['    ', C.label],
-          [entry.summary.slice(0, Math.max(0, width - 6)), C.dim],
+          [truncateDisplay(entry.summary, Math.max(0, width - 6)), C.dim],
         ]));
       }
     }
@@ -233,17 +281,12 @@ export class PolicyPanel extends BasePanel {
           ['  ', C.label],
           [finding.severity.toUpperCase(), color],
           ['  ', C.label],
-          [finding.message.slice(0, Math.max(0, width - 14)), color],
+          [truncateDisplay(finding.message, Math.max(0, width - 14)), color],
         ]));
       }
     }
 
-    if (!preflightReview) {
-      if (!current && !candidate && !divergence && snapshot.history.length === 0 && permissionAudit.length === 0 && lintFindings.length === 0 && !simulationSummary) {
-        lines.push(buildPanelLine(width, [[' Preflight Review', C.label]]));
-        lines.push(buildPanelLine(width, [['  No proactive preflight review recorded yet.', C.empty]]));
-      }
-    } else {
+    if (preflightReview) {
       lines.push(buildPanelLine(width, [[' Preflight Review', C.label]]));
       const statusColor =
         preflightReview.status === 'pass'
@@ -261,7 +304,7 @@ export class PolicyPanel extends BasePanel {
       ]));
       lines.push(buildPanelLine(width, [
         ['  ', C.label],
-        [preflightReview.summary.slice(0, Math.max(0, width - 2)), C.dim],
+        [truncateDisplay(preflightReview.summary, Math.max(0, width - 2)), C.dim],
       ]));
       for (const issue of preflightReview.issues.slice(0, 4)) {
         const issueColor = issue.severity === 'error' ? C.error : issue.severity === 'warn' ? C.warn : C.info;
@@ -269,17 +312,12 @@ export class PolicyPanel extends BasePanel {
           ['  ', C.label],
           [issue.severity.toUpperCase(), issueColor],
           ['  ', C.label],
-          [issue.message.slice(0, Math.max(0, width - 14)), issueColor],
+          [truncateDisplay(issue.message, Math.max(0, width - 14)), issueColor],
         ]));
       }
     }
 
-    if (!simulationSummary) {
-      if (!current && !candidate && !divergence && snapshot.history.length === 0 && permissionAudit.length === 0 && lintFindings.length === 0 && !preflightReview) {
-        lines.push(buildPanelLine(width, [[' Simulation Samples', C.label]]));
-        lines.push(buildPanelLine(width, [['  No concrete simulation samples recorded yet.', C.empty]]));
-      }
-    } else {
+    if (simulationSummary) {
       lines.push(buildPanelLine(width, [[' Simulation Samples', C.label]]));
       lines.push(buildPanelLine(width, [
         ['  Mode: ', C.label],
@@ -293,7 +331,7 @@ export class PolicyPanel extends BasePanel {
         const color = result.diverged ? C.warn : (result.authoritativeDecision.allowed ? C.ok : C.error);
         lines.push(buildPanelLine(width, [
           ['  ', C.label],
-          [result.scenario.label.slice(0, Math.max(0, width - 40)), C.value],
+          [truncateDisplay(result.scenario.label, Math.max(0, width - 40)), C.value],
           ['  ', C.label],
           [(result.authoritativeDecision.allowed ? 'allow' : 'deny').toUpperCase(), color],
           ['  ', C.label],
@@ -302,7 +340,6 @@ export class PolicyPanel extends BasePanel {
       }
     }
 
-    lines.push(buildPanelLine(width, [['  /policy opens this panel. Press r to record a divergence trend snapshot.', C.dim]]));
     return lines;
   }
 }

package/src/panels/polish-core.ts

@@ -0,0 +1,157 @@
+import type { Line } from '../types/grid.ts';
+import { createEmptyLine, createStyledCell } from '../types/grid.ts';
+import { getDisplayWidth } from '../utils/terminal-width.ts';
+import { UI_TONES } from '../renderer/ui-primitives.ts';
+
+// ---------------------------------------------------------------------------
+// Panel palette + core line primitives.
+//
+// The leaf foundation of the panel formatting toolkit: both `polish.ts` and
+// `polish-tables.ts` build on these. Kept dependency-free (only grid /
+// terminal-width / ui-primitives) so it never participates in an import cycle.
+// All symbols are re-exported from `polish.ts` — panels import from there.
+// ---------------------------------------------------------------------------
+
+export interface PanelPalette {
+  readonly label: string;
+  readonly value: string;
+  readonly dim: string;
+  readonly info: string;
+  readonly good?: string;
+  readonly warn?: string;
+  readonly bad?: string;
+  readonly empty: string;
+  readonly header?: string;
+  readonly headerBg?: string;
+  readonly surfaceBg?: string;
+  readonly sectionBg?: string;
+  readonly summaryBg?: string;
+  readonly inputBg?: string;
+  readonly accent?: string;
+  readonly selectBg?: string;
+}
+
+export const DEFAULT_PANEL_PALETTE: Readonly<Required<PanelPalette>> = {
+  header: UI_TONES.fg.primary,
+  headerBg: UI_TONES.bg.title,
+  label: UI_TONES.fg.muted,
+  value: UI_TONES.fg.primary,
+  dim: UI_TONES.fg.dim,
+  info: UI_TONES.state.info,
+  good: UI_TONES.state.good,
+  warn: UI_TONES.state.warn,
+  bad: UI_TONES.state.bad,
+  empty: '#334155',
+  surfaceBg: UI_TONES.bg.surface,
+  sectionBg: UI_TONES.bg.section,
+  summaryBg: UI_TONES.bg.summary,
+  inputBg: UI_TONES.bg.input,
+  accent: UI_TONES.fg.secondary,
+  selectBg: UI_TONES.bg.selected,
+} as const;
+
+/**
+ * Extend the base panel palette with domain-specific colors.
+ *
+ * Convention: raw hex colors may only live inside a palette constant declared
+ * at the top of a panel file, not inline in render calls.
+ *
+ * @example
+ * ```ts
+ * const C = extendPalette(DEFAULT_PANEL_PALETTE, {
+ *   decision: '#38bdf8',
+ *   incident: '#ef4444',
+ * });
+ * ```
+ */
+export function extendPalette<T extends Record<string, string>>(
+  base: typeof DEFAULT_PANEL_PALETTE,
+  extras: T,
+): typeof DEFAULT_PANEL_PALETTE & T {
+  return { ...base, ...extras };
+}
+
+export function buildPanelLine(
+  width: number,
+  segments: Array<StyledPanelSegment | [string, string, string?]>,
+): Line {
+  return buildStyledPanelLine(
+    width,
+    segments.map((seg) =>
+      Array.isArray(seg) ? { text: seg[0], fg: seg[1], bg: seg[2] } : seg,
+    ),
+  );
+}
+
+export interface StyledPanelSegment {
+  readonly text: string;
+  readonly fg: string;
+  readonly bg?: string;
+  readonly bold?: boolean;
+  readonly dim?: boolean;
+}
+
+export function buildSelectablePanelLine(
+  width: number,
+  segments: ReadonlyArray<StyledPanelSegment>,
+  options: { selected?: boolean; selectedBg?: string; fillFg?: string; fillBg?: string; leadingMarker?: string } = {},
+): Line {
+  const selected = options.selected ?? false;
+  const selectedBg = selected ? (options.selectedBg ?? DEFAULT_PANEL_PALETTE.selectBg) : '';
+  const fillBg = selectedBg || options.fillBg || '';
+  const fillFg = options.fillFg ?? '';
+  const cells = createEmptyLine(width);
+  if (fillBg) {
+    for (let col = 0; col < width; col++) {
+      cells[col] = createStyledCell(' ', { bg: fillBg, fg: fillFg });
+    }
+  }
+
+  let col = 0;
+  if (selected && options.leadingMarker) {
+    for (const ch of options.leadingMarker) {
+      const charWidth = getDisplayWidth(ch);
+      if (charWidth <= 0 || col + charWidth > width) break;
+      cells[col] = createStyledCell(ch, { fg: DEFAULT_PANEL_PALETTE.info, bg: selectedBg, bold: true });
+      if (charWidth > 1 && col + 1 < width) cells[col + 1] = createStyledCell(' ', { fg: DEFAULT_PANEL_PALETTE.info, bg: selectedBg, bold: true });
+      col += charWidth;
+    }
+  }
+  for (const segment of segments) {
+    const fg = segment.fg;
+    const bg = segment.bg ?? fillBg;
+    for (const ch of segment.text) {
+      const charWidth = getDisplayWidth(ch);
+      if (charWidth <= 0) continue;
+      if (col + charWidth > width) return cells;
+      cells[col] = createStyledCell(ch, {
+        fg,
+        bg,
+        bold: segment.bold ?? false,
+        dim: segment.dim ?? false,
+      });
+      if (charWidth > 1 && col + 1 < width) {
+        cells[col + 1] = createStyledCell(' ', {
+          fg,
+          bg,
+          bold: segment.bold ?? false,
+          dim: segment.dim ?? false,
+        });
+      }
+      col += charWidth;
+    }
+  }
+
+  while (col < width) {
+    cells[col++] = createStyledCell(' ', { bg: fillBg, fg: fillFg });
+  }
+  return cells;
+}
+
+export function buildStyledPanelLine(
+  width: number,
+  segments: ReadonlyArray<StyledPanelSegment>,
+  options: { fillBg?: string; fillFg?: string } = {},
+): Line {
+  return buildSelectablePanelLine(width, segments, options);
+}