@pellux/goodvibes-tui 0.21.0 → 0.23.0

package/src/runtime/bootstrap-shell.ts

@@ -40,6 +40,11 @@ export interface BootstrapShellState {
   readonly lastGitInfoRef: { value: GitHeaderInfo | undefined };
   readonly inputHistory: InputHistory;
   readonly systemMessageRouter: SystemMessageRouter;
+  /**
+   * Wire the agent detail modal opener after InputHandler is constructed.
+   * Call with `(id) => input.agentDetailModal.open(id)` from main.ts.
+   */
+  readonly setOpenAgentDetail: (fn: (agentId: string) => void) => void;
 }
 
 export interface BootstrapShellOptions {
@@ -103,6 +108,8 @@ export function createBootstrapShell(options: BootstrapShellOptions): BootstrapS
     providerRegistry: services.providerRegistry,
   });
 
+  const openAgentDetailRef: { fn: (agentId: string) => void } = { fn: (_agentId: string) => {} };
+
   let commandContextRef: CommandContext | null = null;
   registerBuiltinPanels(services.panelManager, {
     configManager,
@@ -143,6 +150,7 @@ export function createBootstrapShell(options: BootstrapShellOptions): BootstrapS
     hookActivityTracker: services.hookActivityTracker,
     hookWorkbench: services.hookWorkbench,
     mcpRegistry: services.mcpRegistry,
+    openAgentDetail: (agentId: string) => openAgentDetailRef.fn(agentId),
     daemonHomeDir: join(services.homeDirectory, '.goodvibes', 'daemon'),
   });
   services.panelManager.prewarmRegistered();
@@ -278,5 +286,8 @@ export function createBootstrapShell(options: BootstrapShellOptions): BootstrapS
     lastGitInfoRef,
     inputHistory,
     systemMessageRouter,
+    setOpenAgentDetail: (fn: (agentId: string) => void) => {
+      openAgentDetailRef.fn = fn;
+    },
   };
 }

package/src/runtime/bootstrap.ts

@@ -118,6 +118,11 @@ export type BootstrapContext = RuntimeContext & {
    * stay out of the main conversation and go to the SystemMessagesPanel instead.
    */
   systemMessageRouter: SystemMessageRouter;
+  /**
+   * Wire the agent detail modal opener after InputHandler is constructed in main.ts.
+   * Call with `(id) => input.agentDetailModal.open(id)` once the InputHandler is ready.
+   */
+  setOpenAgentDetail: (fn: (agentId: string) => void) => void;
 };
 
 // ── Bootstrap function ────────────────────────────────────────────────────
@@ -292,6 +297,7 @@ export async function bootstrapRuntime(
   const gitStatusProvider = shell.gitStatusProvider;
   const inputHistory = shell.inputHistory;
   const lastGitInfoRef = shell.lastGitInfoRef;
+  const setOpenAgentDetail = shell.setOpenAgentDetail;
   const pluginCommandRegistry = {
     register(command: {
       readonly name: string;
@@ -622,6 +628,7 @@ export async function bootstrapRuntime(
     _getConfiguredProviderIds: () => services.providerRegistry.getConfiguredProviderIds(),
     commandRegistry,
     systemMessageRouter,
+    setOpenAgentDetail,
     shutdown: async (sessionData) => {
       // Clear bootstrap-owned subscriptions
       bootstrapUnsubs.forEach(fn => fn());

package/src/runtime/services.ts

@@ -78,6 +78,7 @@ import { ComponentHealthMonitor } from '@/runtime/index.ts';
 import { WorktreeRegistry } from '@/runtime/index.ts';
 import { SandboxSessionRegistry } from '@/runtime/index.ts';
 import { createShellPathService, type ShellPathService } from '@/runtime/index.ts';
+import { isFeatureFlagEnabled } from './surface-feature-flags.ts';
 import type { FeatureFlagManager } from '@/runtime/index.ts';
 import { createFeatureFlagManager } from '@/runtime/index.ts';
 import { PolicyRuntimeState } from '@/runtime/index.ts';
@@ -530,7 +531,11 @@ export function createRuntimeServices(options: RuntimeServicesOptions): RuntimeS
   const worktreeRegistry = new WorktreeRegistry(workingDirectory);
   const webhookNotifier = new WebhookNotifier();
   const replayEngine = new DeterministicReplayEngine(workingDirectory);
-  const providerOptimizer = new ProviderOptimizer(providerRegistry, providerCapabilityRegistry, false);
+  const providerOptimizer = new ProviderOptimizer(
+    providerRegistry,
+    providerCapabilityRegistry,
+    isFeatureFlagEnabled(configManager, 'provider-optimizer'),
+  );
   const sessionMemoryStore = new SessionMemoryStore();
   const sessionLineageTracker = new SessionLineageTracker();
   const sessionChangeTracker = new SessionChangeTracker();

package/src/utils/browser.ts

@@ -0,0 +1,29 @@
+/**
+ * browser.ts — cross-platform browser launcher utility.
+ *
+ * Extracted from cli/management.ts so it can be used by input-layer commands
+ * without creating an upward cli→input dependency. Lives in utils (Layer 0)
+ * and has no imports from shell-UI or entrypoint layers.
+ */
+
+import { spawn } from 'node:child_process';
+import { summarizeError } from '@pellux/goodvibes-sdk/platform/utils';
+
+/**
+ * Open the given URL in the user's default browser.
+ * Returns a status string (success or error description).
+ * Does not throw — errors are returned as a descriptive string.
+ */
+export function openBrowser(url: string): string {
+  const platform = process.platform;
+  const command = platform === 'darwin' ? 'open' : platform === 'win32' ? 'cmd' : 'xdg-open';
+  const args = platform === 'win32' ? ['/c', 'start', '', url] : [url];
+  try {
+    const child = spawn(command, args, { detached: true, stdio: 'ignore' });
+    child.once('error', () => {});
+    child.unref();
+    return 'browser open requested';
+  } catch (error) {
+    return `browser open failed: ${summarizeError(error)}`;
+  }
+}

package/src/version.ts

@@ -6,7 +6,7 @@ import { join } from 'node:path';
 // The prebuild script updates the fallback value before compilation.
 // Uses import.meta.dir (Bun) to locate package.json relative to this file,
 // which is correct regardless of the process working directory.
-let _version = '0.21.0';
+let _version = '0.23.0';
 try {
   const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8'));
   _version = pkg.version ?? _version;

package/src/panels/knowledge-panel.ts

@@ -1,343 +0,0 @@
-import type { Line } from '../types/grid.ts';
-import { ScrollableListPanel } from './scrollable-list-panel.ts';
-import type { KeyName } from './types.ts';
-import { type ConfirmState, handleConfirmInput, renderConfirmLines } from './confirm-state.ts';
-import type { MemoryClass, MemoryRecord, MemoryRegistry, MemoryReviewState } from '@pellux/goodvibes-sdk/platform/state';
-import {
-  buildBodyText,
-  buildEmptyState,
-  buildGuidanceLine,
-  buildKeyValueLine,
-  buildPanelLine,
-  buildPanelWorkspace,
-  DEFAULT_PANEL_PALETTE,
-} from './polish.ts';
-
-function summarize(records: MemoryRecord[], cls: MemoryClass): MemoryRecord[] {
-  return records.filter((record) => record.cls === cls).slice(0, 3);
-}
-
-const C = {
-  ...DEFAULT_PANEL_PALETTE,
-  header: '#94a3b8',
-  headerBg: '#1e293b',
-} as const;
-
-function reviewStateColor(state: MemoryReviewState): string {
-  switch (state) {
-    case 'reviewed':
-      return C.good;
-    case 'stale':
-      return C.warn;
-    case 'contradicted':
-      return C.bad;
-    case 'fresh':
-    default:
-      return C.info;
-  }
-}
-
-function formatConfidence(confidence: number): string {
-  return `${confidence.toString().padStart(3, ' ')}%`;
-}
-
-export class KnowledgePanel extends ScrollableListPanel<MemoryRecord> {
-  private readonly registry: MemoryRegistry;
-  private unsubscribe?: () => void;
-  private records: MemoryRecord[] = [];
-  // I1: confirm for destructive review-state mutations
-  private confirm: ConfirmState<{ id: string; action: 'stale' | 'contradicted' }> | null = null;
-
-  public constructor(registry: MemoryRegistry) {
-    super('knowledge', 'Knowledge', 'K', 'agent');
-    this.registry = registry;
-  }
-
-  public override onActivate(): void {
-    super.onActivate();
-    this.refresh();
-    this.unsubscribe = this.registry.subscribe(() => {
-      this.refresh();
-      this.markDirty();
-    });
-  }
-
-  public override onDeactivate(): void {
-    super.onDeactivate();
-  }
-
-  public override onDestroy(): void {
-    this.unsubscribe?.();
-    this.unsubscribe = undefined;
-  }
-
-  // ---------------------------------------------------------------------------
-  // ScrollableListPanel implementation
-  // ---------------------------------------------------------------------------
-
-  protected getItems(): readonly MemoryRecord[] {
-    return this.records;
-  }
-
-  protected renderItem(record: MemoryRecord, index: number, selected: boolean, width: number): Line {
-    const bg = selected ? C.selectBg : undefined;
-    return buildPanelLine(width, [
-      ['  ', C.label, bg],
-      [record.reviewState.padEnd(13), reviewStateColor(record.reviewState), bg],
-      [` ${formatConfidence(record.confidence)} `, C.value, bg],
-      [record.summary.slice(0, Math.max(0, width - 26)), C.value, bg],
-    ]);
-  }
-
-  protected override getPalette() { return C; }
-  protected override getEmptyStateMessage() { return 'No durable project knowledge'; }
-  protected override getEmptyStateActions() {
-    return [
-      { command: '/recall add fact <summary>', summary: 'capture a durable fact directly' },
-      { command: '/recall capture incident latest', summary: 'promote the latest incident into project memory' },
-      { command: '/recall capture policy', summary: 'store the current policy posture as durable evidence' },
-    ];
-  }
-
-  // ---------------------------------------------------------------------------
-  // Input
-  // ---------------------------------------------------------------------------
-
-  public handleInput(key: KeyName): boolean {
-    // I1: y/n confirm for stale/contradict
-    if (this.confirm) {
-      const result = handleConfirmInput(this.confirm, key);
-      if (result === 'confirmed') {
-        const { id, action } = this.confirm.subject;
-        this.confirm = null;
-        const selected = this.records.find((r) => r.id === id);
-        if (selected) {
-          try {
-            if (action === 'stale') {
-              this.registry.review(id, {
-                state: 'stale',
-                confidence: Math.min(selected.confidence, 40),
-                reviewedBy: 'operator',
-                staleReason: 'marked stale from the knowledge panel',
-              });
-            } else {
-              this.registry.review(id, {
-                state: 'contradicted',
-                confidence: 0,
-                reviewedBy: 'operator',
-                staleReason: 'marked contradicted from the knowledge panel',
-              });
-            }
-          } catch (e) {
-            // I2: surface async failure
-            this.setError(`Review update failed: ${e instanceof Error ? e.message : String(e)}`);
-          }
-        }
-        this.refresh();
-        this.markDirty();
-        return true;
-      }
-      if (result === 'cancelled') {
-        this.confirm = null;
-        this.markDirty();
-        return true;
-      }
-      if (result === 'absorbed') return true;
-    }
-
-    // I2: auto-clear error on next keypress (inherited via super.handleInput)
-    if (this.records.length === 0) return super.handleInput(key);
-
-    const selected = this.records[this.selectedIndex];
-
-    if (key === 'enter' || key === 'return' || key === 'r') {
-      if (!selected) return false;
-      this.registry.review(selected.id, {
-        state: 'reviewed',
-        confidence: Math.max(selected.confidence, 85),
-        reviewedBy: 'operator',
-      });
-      this.refresh();
-      this.markDirty();
-      return true;
-    }
-    if (key === 's') {
-      if (!selected) return false;
-      // I1: prompt confirm before marking stale
-      this.confirm = { subject: { id: selected.id, action: 'stale' }, label: selected.summary.slice(0, 40) };
-      this.markDirty();
-      return true;
-    }
-    if (key === 'c') {
-      if (!selected) return false;
-      // I1: prompt confirm before marking contradicted
-      this.confirm = { subject: { id: selected.id, action: 'contradicted' }, label: selected.summary.slice(0, 40) };
-      this.markDirty();
-      return true;
-    }
-    if (key === 'f') {
-      if (!selected) return false;
-      this.registry.review(selected.id, {
-        state: 'fresh',
-        confidence: Math.max(selected.confidence, 60),
-        reviewedBy: 'operator',
-      });
-      this.refresh();
-      this.markDirty();
-      return true;
-    }
-
-    return super.handleInput(key);
-  }
-
-  private refresh(): void {
-    const queue = this.registry.reviewQueue(24);
-    this.records = queue.length > 0 ? queue : this.registry.search({ limit: 24 });
-    this.clampSelection();
-  }
-
-  public render(width: number, height: number): Line[] {
-    this.clampSelection();
-
-    // I1: show confirm dialog in place of normal content
-    if (this.confirm) {
-      return buildPanelWorkspace(width, height, {
-        title: 'Knowledge Control Room',
-        intro: '',
-        sections: [{ title: 'Confirmation', lines: renderConfirmLines(width, this.confirm) }],
-        footerLines: [buildPanelLine(width, [['  y confirm  n / Esc cancel', C.dim]])],
-        palette: C,
-      });
-    }
-
-    if (this.records.length === 0) this.refresh();
-
-    const intro = 'Typed project knowledge, reviewed evidence, and operator-governed memory across session, project, and team scopes.';
-    const records = this.registry.search({ limit: 200 });
-
-    if (records.length === 0) {
-      return this.renderList(width, height, {
-        title: 'Knowledge Control Room',
-        footer: [buildPanelLine(width, [[' Review keys: Up/Down move  r/Enter review  s stale  c contradicted  f fresh', C.dim]])],
-      });
-    }
-
-    const queue = this.registry.reviewQueue(24);
-    const byClass = new Map<MemoryClass, number>();
-    const byReview = new Map<MemoryReviewState, number>();
-    const byScope = new Map<string, number>();
-    for (const record of records) {
-      byClass.set(record.cls, (byClass.get(record.cls) ?? 0) + 1);
-      byReview.set(record.reviewState, (byReview.get(record.reviewState) ?? 0) + 1);
-      byScope.set(record.scope, (byScope.get(record.scope) ?? 0) + 1);
-    }
-
-    const classLines: Line[] = [
-      buildPanelLine(width, [
-        [' facts ', C.label], [String(byClass.get('fact') ?? 0), C.good],
-        ['  risks ', C.label], [String(byClass.get('risk') ?? 0), (byClass.get('risk') ?? 0) > 0 ? C.warn : C.good],
-        ['  runbooks ', C.label], [String(byClass.get('runbook') ?? 0), C.info],
-        ['  architecture ', C.label], [String(byClass.get('architecture') ?? 0), C.info],
-        ['  incidents ', C.label], [String(byClass.get('incident') ?? 0), (byClass.get('incident') ?? 0) > 0 ? C.bad : C.good],
-      ]),
-      buildPanelLine(width, [
-        [' decisions ', C.label], [String(byClass.get('decision') ?? 0), C.value],
-        ['  constraints ', C.label], [String(byClass.get('constraint') ?? 0), C.value],
-        ['  ownership ', C.label], [String(byClass.get('ownership') ?? 0), C.value],
-        ['  patterns ', C.label], [String(byClass.get('pattern') ?? 0), C.value],
-        ['  total ', C.label], [String(records.length), C.value],
-      ]),
-    ];
-
-    const reviewLines: Line[] = [
-      buildPanelLine(width, [
-        [' reviewed ', C.label], [String(byReview.get('reviewed') ?? 0), C.good],
-        ['  fresh ', C.label], [String(byReview.get('fresh') ?? 0), C.info],
-        ['  stale ', C.label], [String(byReview.get('stale') ?? 0), C.warn],
-        ['  contradicted ', C.label], [String(byReview.get('contradicted') ?? 0), C.bad],
-        ['  Review Queue ', C.label], [String(queue.length), queue.length > 0 ? C.warn : C.good],
-      ]),
-      buildPanelLine(width, [
-        [' session ', C.label], [String(byScope.get('session') ?? 0), C.info],
-        ['  project ', C.label], [String(byScope.get('project') ?? 0), C.value],
-        ['  team ', C.label], [String(byScope.get('team') ?? 0), C.good],
-      ]),
-      buildGuidanceLine(width, '/recall review', 'work the stale and contradicted queue from the command surface', C),
-    ];
-
-    const recentSummaryLines: Line[] = [];
-    for (const [title, items, color] of [
-      ['Recent Risks', summarize(records, 'risk'), C.warn],
-      ['Runbooks', summarize(records, 'runbook'), C.info],
-      ['Architecture Notes', summarize(records, 'architecture'), C.info],
-      ['Recent Incidents', summarize(records, 'incident'), C.bad],
-    ] as const) {
-      if (recentSummaryLines.length > 0) {
-        recentSummaryLines.push(buildPanelLine(width, [['', C.dim]]));
-      }
-      recentSummaryLines.push(buildPanelLine(width, [[` ${title}`, C.label]]));
-      if (items.length === 0) {
-        recentSummaryLines.push(buildPanelLine(width, [['  none recorded', C.dim]]));
-        continue;
-      }
-      for (const item of items) {
-        recentSummaryLines.push(buildPanelLine(width, [
-          ['  ', C.label],
-          [item.summary.slice(0, Math.max(0, width - 2)), color],
-        ]));
-      }
-    }
-
-    const selectedRecord = this.records[this.selectedIndex];
-    const selectedLines: Line[] = [];
-    if (selectedRecord) {
-      selectedLines.push(buildPanelLine(width, [['  Selected', C.label]]));
-      selectedLines.push(buildKeyValueLine(width, [
-        { label: 'Class', value: selectedRecord.cls, valueColor: C.value },
-        { label: 'Scope', value: selectedRecord.scope, valueColor: C.info },
-        { label: 'Review', value: selectedRecord.reviewState, valueColor: reviewStateColor(selectedRecord.reviewState) },
-        { label: 'Confidence', value: formatConfidence(selectedRecord.confidence), valueColor: C.value },
-      ], C));
-      selectedLines.push(...buildBodyText(width, `Summary: ${selectedRecord.summary}`, C, C.value));
-      if (selectedRecord.detail) selectedLines.push(...buildBodyText(width, `Detail: ${selectedRecord.detail}`, C, C.dim));
-      if (selectedRecord.provenance.length) {
-        selectedLines.push(...buildBodyText(
-          width,
-          `Provenance: ${selectedRecord.provenance.map((p) => `${p.kind}:${p.ref}`).join(', ')}`,
-          C,
-          C.dim,
-        ));
-      }
-      if (selectedRecord.staleReason) {
-        selectedLines.push(...buildBodyText(
-          width,
-          `Stale reason: ${selectedRecord.staleReason}`,
-          C,
-          selectedRecord.reviewState === 'contradicted' ? C.bad : C.warn,
-        ));
-      }
-      if (selectedRecord.reviewedAt) {
-        selectedLines.push(buildPanelLine(width, [
-          ['  Reviewed: ', C.label],
-          [new Date(selectedRecord.reviewedAt).toLocaleString(), C.dim],
-        ]));
-        if (selectedRecord.reviewedBy) {
-          selectedLines.push(buildPanelLine(width, [
-            ['  Reviewer: ', C.label],
-            [selectedRecord.reviewedBy, C.dim],
-          ]));
-        }
-      }
-    }
-
-    return this.renderList(width, height, {
-      title: 'Knowledge Control Room',
-      header: [...classLines, ...reviewLines],
-      footer: [
-        ...(selectedLines.length > 0 ? selectedLines : []),
-        ...recentSummaryLines,
-        buildPanelLine(width, [['  Up/Down move  r/Enter reviewed  s stale  c contradicted  f fresh', C.dim]]),
-      ],
-    });
-  }
-}