@pellux/goodvibes-tui 0.21.0 → 0.22.0

package/src/renderer/agent-detail-modal.ts

@@ -8,18 +8,25 @@ import { formatDuration } from './modal-utils.ts';
 import { logger } from '@pellux/goodvibes-sdk/platform/utils';
 import { getOverlaySurfaceMetrics, getStableOverlayContentRows } from './overlay-viewport.ts';
 import { summarizeError } from '@pellux/goodvibes-sdk/platform/utils';
+import { handleConfirmInput, type ConfirmState } from '../panels/confirm-state.ts';
+import { AGENT_TERMINAL_STATUSES as MODAL_TERMINAL_STATUSES, AGENT_STALL_THRESHOLD_MS as MODAL_STALL_THRESHOLD_MS } from '../panels/agent-inspector-shared.ts';
 
 // ─── Constants ────────────────────────────────────────────────────────────────
 
 const MAX_LOG_ENTRIES = 10;
 const AGENT_ID_DISPLAY_LENGTH = 16;
 
+// MODAL_TERMINAL_STATUSES and MODAL_STALL_THRESHOLD_MS are re-exported aliases
+// from agent-inspector-shared.ts (imported above alongside ConfirmState).
+
 export interface AgentDetailModalDeps {
-  readonly agentManager: Pick<AgentManager, 'getStatus'>;
+  readonly agentManager: Pick<AgentManager, 'getStatus' | 'list'>;
   readonly agentMessageBus: Pick<AgentMessageBus, 'getMessages'>;
   readonly sessionLogPathResolver: (agentId: string) => string;
   /** Optional — when supplied, constraint data from the agent's WRFC chain is shown (SDK 0.23.0). */
   readonly wrfcController?: Pick<WrfcController, 'getChain'>;
+  /** Cancel the agent by id using the same orphan-free path as WRFC. Returns true if cancelled. */
+  readonly cancelAgent: (agentId: string) => boolean;
 }
 
 // ─── AgentDetailModal ─────────────────────────────────────────────────────────
@@ -39,6 +46,9 @@ export class AgentDetailModal {
   public logEntries: Record<string, unknown>[] = [];
   public logTotal = 0;
 
+  /** Pending cancel confirmation. Subject is the agent id to cancel. */
+  public confirmCancel: ConfirmState<string> | null = null;
+
   private refreshTimer: ReturnType<typeof setInterval> | null = null;
   private onRefresh: (() => void) | null = null;
 
@@ -67,12 +77,88 @@ export class AgentDetailModal {
     this.agentId = null;
     this.logEntries = [];
     this.logTotal = 0;
+    this.confirmCancel = null;
     if (this.refreshTimer) {
       clearInterval(this.refreshTimer);
       this.refreshTimer = null;
     }
   }
 
+  /**
+   * Handle a key press while the modal is active.
+   * Must be called BEFORE the Esc handler closes the modal.
+   *
+   * Routes:
+   *   - 'c' initiates cancel confirm (if agent is non-terminal)
+   *   - confirm keys (Enter/y/n/Esc) are forwarded to handleConfirmInput
+   *
+   * Returns true when the key was consumed (caller should NOT propagate).
+   */
+  handleKey(key: string): boolean {
+    if (!this.active) return false;
+
+    if (this.confirmCancel) {
+      const result = handleConfirmInput(this.confirmCancel, key);
+      if (result === 'confirmed') {
+        if (this.agentId) {
+          const rec = this.deps.agentManager.getStatus(this.agentId);
+          if (rec && !MODAL_TERMINAL_STATUSES.has(rec.status)) {
+            this.deps.cancelAgent(rec.id);
+          }
+        }
+        this.confirmCancel = null;
+        this.onRefresh?.();
+        return true;
+      }
+      if (result === 'cancelled') {
+        this.confirmCancel = null;
+        this.onRefresh?.();
+        return true;
+      }
+      // absorbed — key swallowed while confirm is pending
+      return true;
+    }
+
+    if (key === 'c') {
+      if (this.agentId) {
+        const rec = this.deps.agentManager.getStatus(this.agentId);
+        if (rec && !MODAL_TERMINAL_STATUSES.has(rec.status)) {
+          const label = rec.task.split('\n')[0]?.slice(0, 40) ?? rec.id.slice(-8);
+          this.confirmCancel = { subject: rec.id, label };
+          this.onRefresh?.();
+          return true;
+        }
+      }
+      // Non-cancellable — absorb key silently
+      return true;
+    }
+
+    return false;
+  }
+
+  /**
+   * Returns whether the current agent is considered stalled.
+   * Non-terminal agent with elapsed time exceeding MODAL_STALL_THRESHOLD_MS.
+   */
+  isCurrentAgentStalled(): boolean {
+    if (!this.agentId) return false;
+    const rec = this.deps.agentManager.getStatus(this.agentId);
+    if (!rec || MODAL_TERMINAL_STATUSES.has(rec.status)) return false;
+    return (Date.now() - rec.startedAt) >= MODAL_STALL_THRESHOLD_MS;
+  }
+
+  /**
+   * Count of all stalled agents across the agentManager list.
+   * Non-terminal agents with elapsed time >= MODAL_STALL_THRESHOLD_MS.
+   */
+  getStalledAgentCount(): number {
+    const now = Date.now();
+    return this.deps.agentManager.list().filter(rec => {
+      if (MODAL_TERMINAL_STATUSES.has(rec.status)) return false;
+      return (now - rec.startedAt) >= MODAL_STALL_THRESHOLD_MS;
+    }).length;
+  }
+
   async loadLog(): Promise<void> {
     if (!this.agentId) { this.logEntries = []; this.logTotal = 0; return; }
     try {
@@ -161,7 +247,8 @@ export function renderAgentDetailModal(
   const modelStr = rec.model ? `${rec.provider ?? ''}/${rec.model}` : (rec.provider ?? '(default)');
   sections.push({ type: 'text', content: `Template : ${rec.template}` });
   sections.push({ type: 'text', content: `Model    : ${modelStr}` });
-  sections.push({ type: 'text', content: `Status   : ${rec.status}` });
+  const isStalled = !MODAL_TERMINAL_STATUSES.has(rec.status) && (now - rec.startedAt) >= MODAL_STALL_THRESHOLD_MS;
+  sections.push({ type: 'text', content: `Status   : ${rec.status}${isStalled ? '  [STALLED — 5+ min no activity]' : ''}` });
   sections.push({ type: 'text', content: `Duration : ${formatDuration(elapsedMs)}` });
   sections.push({ type: 'separator' });
 
@@ -321,12 +408,29 @@ export function renderAgentDetailModal(
     }
   }
 
+  // Cancel confirm overlay (when pending)
+  const cancellable = !MODAL_TERMINAL_STATUSES.has(rec.status);
+  if (modal.confirmCancel) {
+    sections.push({ type: 'separator' });
+    sections.push({
+      type: 'text',
+      content: `Cancel agent "${modal.confirmCancel.label}"?`,
+      style: { fg: '#f59e0b' },
+    });
+    sections.push({
+      type: 'text',
+      content: 'y / Enter  confirm     n / Esc  cancel',
+      style: { dim: true },
+    });
+  }
+
+  const cancelHint = cancellable ? '[c] Cancel  ' : '';
   return ModalFactory.createModal({
     title: `Agent: ${rec.id.slice(0, AGENT_ID_DISPLAY_LENGTH)}`,
     width: metrics.boxWidth,
     margin: metrics.margin,
     targetContentRows,
     sections,
-    hints: ['[Esc] Close'],
+    hints: [cancelHint + '[Esc] Close'],
   }, width);
 }

package/src/renderer/context-status-hint.ts

@@ -0,0 +1,54 @@
+/**
+ * Context status hint — TASK-056.
+ *
+ * Produces a short, dismissible status-line hint when the session maintenance
+ * level indicates compaction is recommended or repair is needed.  The hint is
+ * passive and non-blocking: it appears in the footer status row and disappears
+ * once the pressure signal clears.
+ *
+ * Honest wording policy:
+ *  - suggest-compact → describes the situation and offers /compact
+ *  - needs-repair    → names the failure state honestly without alarming
+ *  - compacting      → shows in-progress text so the user knows something is running
+ *  - watch           → no hint (not yet actionable)
+ *  - stable/unknown  → no hint
+ */
+
+import type { PanelSessionMaintenanceLevel } from '../panels/session-maintenance.ts';
+
+export interface ContextStatusHintOptions {
+  /** Maintenance level from evaluateSessionMaintenance. */
+  readonly level: PanelSessionMaintenanceLevel;
+  /** Whether auto-compaction is active (threshold > 0 in config). */
+  readonly autoCompactEnabled: boolean;
+  /** Current usage percent 0–100. */
+  readonly usagePct: number;
+}
+
+/**
+ * Build the passive status-line hint text for context pressure.
+ *
+ * Returns null when no hint is warranted (stable / watch / unknown).
+ * The caller renders this as a dim informational line — no prompts, no
+ * blocking, no confirmation required.
+ */
+export function buildContextStatusHint(options: ContextStatusHintOptions): string | null {
+  const { level, autoCompactEnabled, usagePct } = options;
+
+  switch (level) {
+    case 'needs-repair':
+      return `  Context pressure critical (${usagePct}% used) — compaction needs attention. Run /compact or /health review.`;
+
+    case 'suggest-compact':
+      if (autoCompactEnabled) {
+        return `  Context high (${usagePct}% used) — auto-compact will run before the next turn.`;
+      }
+      return `  Context high (${usagePct}% used) — run /compact to recover headroom.`;
+
+    case 'compacting':
+      return `  Compacting context — freeing headroom...`;
+
+    default:
+      return null;
+  }
+}

package/src/renderer/settings-modal.ts

@@ -539,14 +539,25 @@ function rowColorForSetting(modal: SettingsModal, rowText: string): string {
   return valueColor(selected);
 }
 
-function footerText(modal: SettingsModal): string {
+function footerText(modal: SettingsModal, width: number): string {
+  // Armed reset gate takes priority over all other footer states.
+  if (modal.resetCategoryConfirm !== null || modal.resetAllConfirm !== null)
+    return 'Reset armed · Enter/y confirm · Esc/n cancel';
   if (modal.searchFocused) return 'Search · type to filter · Up/Down navigate results · Enter select · Esc exit search';
   if (modal.editingMode) return 'Enter Confirm edit · Esc Cancel edit · text keys edit the selected field';
   if (modal.focusPane === 'categories') return 'Focus categories · Up/Down choose · Right/Enter settings · Tab pane · / search · Esc close';
   if (modal.currentCategory === 'subscriptions') return 'Focus settings · Up/Down provider · Left categories · Tab pane · / search · Enter review/sign out · Esc close';
   if (modal.currentCategory === 'mcp') return 'Focus settings · Up/Down server · Left categories · Tab pane · / search · Enter edit trust · Esc close';
   if (modal.currentCategory === 'flags') return 'Focus feature flags · Up/Down flag · Left categories · Tab pane · / search · Enter/Space toggle · Esc close';
-  return 'Focus settings · Up/Down setting · Left categories · Tab pane · / search · Enter/Space edit/toggle · R reset · Esc close';
+  // Default settings pane: tier the reset affordances by available width.
+  // W<80:  minimal — only the most critical action survives.
+  // W<160: compact but still shows both reset affordances.
+  // W≥160: standard with all navigation tokens.
+  if (width < 80)
+    return 'R reset · Esc';
+  if (width < 160)
+    return 'Up/Down · Enter/Space edit · ⇧R reset cat · ^⇧R reset all · Esc';
+  return 'Focus settings · Up/Down setting · Left · Enter/Space edit/toggle · ⇧R reset cat · ^⇧R reset all · Esc close';
 }
 
 export function renderSettingsModal(
@@ -601,6 +612,6 @@ export function renderSettingsModal(
     })),
     contextRows,
     controlRows,
-    footer: footerText(modal),
+    footer: footerText(modal, width),
   });
 }

package/src/renderer/shell-surface.ts

@@ -29,6 +29,11 @@ export interface ShellFooterBuildOptions {
   readonly composerStatus?: string;
   readonly composerFlags?: readonly string[];
   readonly composerPendingRisk?: 'none' | 'approval-wait' | 'shell' | 'command' | 'remote';
+  /**
+   * Passive context pressure hint from buildContextStatusHint.
+   * Rendered as a dim informational line above the prompt when non-null.
+   */
+  readonly contextStatusHint?: string | null;
 }
 
 export interface ShellFooterBuildResult {
@@ -84,5 +89,10 @@ export function buildShellFooter(
   );
   const inputBoxRows = Math.max(1, options.promptLineCount) + 2;
   lines.splice(inputBoxRows, 0, ...processIndicator);
+  // Passive context status hint — rendered as a dim informational line before the prompt.
+  if (options.contextStatusHint) {
+    const hintLine = UIFactory.stringToLine(options.contextStatusHint, options.width, { fg: '#64748b' });
+    lines.unshift(hintLine);
+  }
   return { lines, height: lines.length };
 }

package/src/runtime/bootstrap-command-parts.ts

@@ -160,6 +160,7 @@ export function createBootstrapCommandActions(
   | 'openMcpWorkspace'
   | 'openSecurityPanel'
   | 'openKnowledgePanel'
+  | 'openMemoryPanel'
   | 'openRemotePanel'
   | 'openSubscriptionPanel'
   | 'openLocalAuthMaskedEntry'
@@ -273,6 +274,9 @@ export function createBootstrapCommandActions(
     openKnowledgePanel: () => {
       showPanel('knowledge');
     },
+    openMemoryPanel: () => {
+      showPanel('memory');
+    },
     openRemotePanel: () => {
       showPanel('remote');
     },

package/src/runtime/bootstrap-core.ts

@@ -426,6 +426,30 @@ export async function initializeBootstrapCore(
     }
   };
 
+  // Startup TLS banner — emitted via wrfcBuffer.push() because the
+  // SystemMessageRouter is not attached yet at this point in bootstrap. The
+  // smart-ref setter on systemMessageRouterRef auto-flushes the buffer when
+  // the router attaches, so the message will appear in the WRFC panel on startup.
+  {
+    const cpEnabled = Boolean(configManager.get('controlPlane.enabled'));
+    const cpHostMode = String(configManager.get('controlPlane.hostMode') ?? 'local');
+    const cpTlsMode = String(configManager.get('controlPlane.tls.mode') ?? 'off');
+    const hlEnabled = Boolean(configManager.get('danger.httpListener'));
+    const hlHostMode = String(configManager.get('httpListener.hostMode') ?? 'local');
+    const hlTlsMode = String(configManager.get('httpListener.tls.mode') ?? 'off');
+    const cpNetworkPlaintext = cpEnabled && cpHostMode !== 'local' && cpTlsMode === 'off';
+    const hlNetworkPlaintext = hlEnabled && hlHostMode !== 'local' && hlTlsMode === 'off';
+    if (cpNetworkPlaintext || hlNetworkPlaintext) {
+      const affected: string[] = [];
+      if (cpNetworkPlaintext) affected.push('control plane');
+      if (hlNetworkPlaintext) affected.push('HTTP listener');
+      wrfcBuffer.push(
+        `[SECURITY] TLS is off for the ${affected.join(' and ')} but it is network-reachable. All traffic (credentials, tokens, conversation content) travels in plaintext. Enable TLS (controlPlane.tls.mode / httpListener.tls.mode) or restrict to loopback before exposing to untrusted networks.`,
+        'high',
+      );
+    }
+  }
+
   runtimeUnsubs.push(
     runtimeBus.on<Extract<import('@/runtime/index.ts').WorkflowEvent, { type: 'WORKFLOW_CONSTRAINTS_ENUMERATED' }>>(
       'WORKFLOW_CONSTRAINTS_ENUMERATED',

package/src/runtime/bootstrap-shell.ts

@@ -40,6 +40,11 @@ export interface BootstrapShellState {
   readonly lastGitInfoRef: { value: GitHeaderInfo | undefined };
   readonly inputHistory: InputHistory;
   readonly systemMessageRouter: SystemMessageRouter;
+  /**
+   * Wire the agent detail modal opener after InputHandler is constructed.
+   * Call with `(id) => input.agentDetailModal.open(id)` from main.ts.
+   */
+  readonly setOpenAgentDetail: (fn: (agentId: string) => void) => void;
 }
 
 export interface BootstrapShellOptions {
@@ -103,6 +108,8 @@ export function createBootstrapShell(options: BootstrapShellOptions): BootstrapS
     providerRegistry: services.providerRegistry,
   });
 
+  const openAgentDetailRef: { fn: (agentId: string) => void } = { fn: (_agentId: string) => {} };
+
   let commandContextRef: CommandContext | null = null;
   registerBuiltinPanels(services.panelManager, {
     configManager,
@@ -143,6 +150,7 @@ export function createBootstrapShell(options: BootstrapShellOptions): BootstrapS
     hookActivityTracker: services.hookActivityTracker,
     hookWorkbench: services.hookWorkbench,
     mcpRegistry: services.mcpRegistry,
+    openAgentDetail: (agentId: string) => openAgentDetailRef.fn(agentId),
     daemonHomeDir: join(services.homeDirectory, '.goodvibes', 'daemon'),
   });
   services.panelManager.prewarmRegistered();
@@ -278,5 +286,8 @@ export function createBootstrapShell(options: BootstrapShellOptions): BootstrapS
     lastGitInfoRef,
     inputHistory,
     systemMessageRouter,
+    setOpenAgentDetail: (fn: (agentId: string) => void) => {
+      openAgentDetailRef.fn = fn;
+    },
   };
 }

package/src/runtime/bootstrap.ts

@@ -118,6 +118,11 @@ export type BootstrapContext = RuntimeContext & {
    * stay out of the main conversation and go to the SystemMessagesPanel instead.
    */
   systemMessageRouter: SystemMessageRouter;
+  /**
+   * Wire the agent detail modal opener after InputHandler is constructed in main.ts.
+   * Call with `(id) => input.agentDetailModal.open(id)` once the InputHandler is ready.
+   */
+  setOpenAgentDetail: (fn: (agentId: string) => void) => void;
 };
 
 // ── Bootstrap function ────────────────────────────────────────────────────
@@ -292,6 +297,7 @@ export async function bootstrapRuntime(
   const gitStatusProvider = shell.gitStatusProvider;
   const inputHistory = shell.inputHistory;
   const lastGitInfoRef = shell.lastGitInfoRef;
+  const setOpenAgentDetail = shell.setOpenAgentDetail;
   const pluginCommandRegistry = {
     register(command: {
       readonly name: string;
@@ -622,6 +628,7 @@ export async function bootstrapRuntime(
     _getConfiguredProviderIds: () => services.providerRegistry.getConfiguredProviderIds(),
     commandRegistry,
     systemMessageRouter,
+    setOpenAgentDetail,
     shutdown: async (sessionData) => {
       // Clear bootstrap-owned subscriptions
       bootstrapUnsubs.forEach(fn => fn());

package/src/runtime/services.ts

@@ -78,6 +78,7 @@ import { ComponentHealthMonitor } from '@/runtime/index.ts';
 import { WorktreeRegistry } from '@/runtime/index.ts';
 import { SandboxSessionRegistry } from '@/runtime/index.ts';
 import { createShellPathService, type ShellPathService } from '@/runtime/index.ts';
+import { isFeatureFlagEnabled } from './surface-feature-flags.ts';
 import type { FeatureFlagManager } from '@/runtime/index.ts';
 import { createFeatureFlagManager } from '@/runtime/index.ts';
 import { PolicyRuntimeState } from '@/runtime/index.ts';
@@ -530,7 +531,11 @@ export function createRuntimeServices(options: RuntimeServicesOptions): RuntimeS
   const worktreeRegistry = new WorktreeRegistry(workingDirectory);
   const webhookNotifier = new WebhookNotifier();
   const replayEngine = new DeterministicReplayEngine(workingDirectory);
-  const providerOptimizer = new ProviderOptimizer(providerRegistry, providerCapabilityRegistry, false);
+  const providerOptimizer = new ProviderOptimizer(
+    providerRegistry,
+    providerCapabilityRegistry,
+    isFeatureFlagEnabled(configManager, 'provider-optimizer'),
+  );
   const sessionMemoryStore = new SessionMemoryStore();
   const sessionLineageTracker = new SessionLineageTracker();
   const sessionChangeTracker = new SessionChangeTracker();

package/src/version.ts

@@ -6,7 +6,7 @@ import { join } from 'node:path';
 // The prebuild script updates the fallback value before compilation.
 // Uses import.meta.dir (Bun) to locate package.json relative to this file,
 // which is correct regardless of the process working directory.
-let _version = '0.21.0';
+let _version = '0.22.0';
 try {
   const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8'));
   _version = pkg.version ?? _version;