@pellux/goodvibes-tui 0.20.3 → 0.21.0

package/src/input/onboarding/onboarding-wizard-cloudflare.ts

@@ -8,7 +8,7 @@ import {
   type CloudflareProvisionRequest,
 } from '../../runtime/cloudflare-control-plane.ts';
 import { buildGoodVibesSecretRef, normalizeText } from './onboarding-wizard-helpers.ts';
-import type { OnboardingWizardController } from './onboarding-wizard.ts';
+import type { OnboardingWizardControllerLike } from './onboarding-wizard-types.ts';
 import type { OnboardingWizardRadioOption } from './onboarding-wizard-types.ts';
 
 export const CLOUDFLARE_SETUP_SOURCE_OPTIONS: readonly OnboardingWizardRadioOption[] = [
@@ -90,7 +90,7 @@ export function cloudflareComponentLabel(component: CloudflareComponent): string
   return CLOUDFLARE_COMPONENT_LABELS[component];
 }
 
-export function isCloudflareConfigured(controller: OnboardingWizardController): boolean {
+export function isCloudflareConfigured(controller: OnboardingWizardControllerLike): boolean {
   const config = controller.runtimeSnapshot?.config.cloudflare;
   if (!config) return false;
   return config.enabled
@@ -100,11 +100,11 @@ export function isCloudflareConfigured(controller: OnboardingWizardController):
     || normalizeText(config.workerName).length > 0;
 }
 
-export function shouldShowCloudflareStep(controller: OnboardingWizardController): boolean {
+export function shouldShowCloudflareStep(controller: OnboardingWizardControllerLike): boolean {
   return controller.isCapabilitySelected('cloudflare-batch') || isCloudflareConfigured(controller);
 }
 
-export function getCloudflareSetupSource(controller: OnboardingWizardController): CloudflareSetupSource {
+export function getCloudflareSetupSource(controller: OnboardingWizardControllerLike): CloudflareSetupSource {
   const configuredTokenRef = controller.runtimeSnapshot?.config.cloudflare.apiTokenRef ?? '';
   const defaultValue = configuredTokenRef.startsWith('goodvibes://secrets/env/') ? 'operational-env' : 'save-only';
   const value = controller.getStringFieldValue('cloudflare.setup-source', defaultValue);
@@ -120,7 +120,7 @@ export function getCloudflareSetupSource(controller: OnboardingWizardController)
   return 'save-only';
 }
 
-export function getCloudflareComponentSelection(controller: OnboardingWizardController): Record<CloudflareComponent, boolean> {
+export function getCloudflareComponentSelection(controller: OnboardingWizardControllerLike): Record<CloudflareComponent, boolean> {
   const selected: Record<CloudflareComponent, boolean> = { ...DEFAULT_CLOUDFLARE_COMPONENT_SELECTION };
   const configured = controller.runtimeSnapshot?.config.cloudflare;
   for (const component of CLOUDFLARE_COMPONENT_IDS) {
@@ -132,11 +132,11 @@ export function getCloudflareComponentSelection(controller: OnboardingWizardCont
   return selected;
 }
 
-export function getSelectedCloudflareComponents(controller: OnboardingWizardController): CloudflareComponentSelection {
+export function getSelectedCloudflareComponents(controller: OnboardingWizardControllerLike): CloudflareComponentSelection {
   return getCloudflareComponentSelection(controller);
 }
 
-export function getCloudflareBatchMode(controller: OnboardingWizardController): CloudflareBatchMode {
+export function getCloudflareBatchMode(controller: OnboardingWizardControllerLike): CloudflareBatchMode {
   const value = controller.getStringFieldValue('cloudflare.batch-mode', controller.runtimeSnapshot?.config.batch.mode ?? 'off');
   return value === 'explicit' || value === 'eligible-by-default' ? value : 'off';
 }
@@ -146,7 +146,7 @@ export function buildCloudflareApiTokenRef(envName: string): string {
   return `goodvibes://secrets/env/${encodeURIComponent(normalized)}`;
 }
 
-export function buildCloudflareProvisionRequest(controller: OnboardingWizardController, options: {
+export function buildCloudflareProvisionRequest(controller: OnboardingWizardControllerLike, options: {
   readonly includeTransientSecrets?: boolean;
 } = {}): CloudflareProvisionRequest {
   const components = getCloudflareComponentSelection(controller);

package/src/input/onboarding/onboarding-wizard-external-surface-extra-specs.ts

@@ -1,4 +1,4 @@
-import type { ExternalSurfaceSpec } from './onboarding-wizard-external-surfaces.ts';
+import type { ExternalSurfaceSpec } from './onboarding-wizard-types.ts';
 
 export const WEBHOOK_SURFACE_SPEC: ExternalSurfaceSpec = {
   id: 'webhook',

package/src/input/onboarding/onboarding-wizard-external-surfaces.ts

@@ -8,36 +8,9 @@ import { DEFAULT_CONFIG, type ConfigKey } from '../../config/index.ts';
 import type { OnboardingSnapshotState } from '../../runtime/onboarding/index.ts';
 import { TELEGRAM_MODE_OPTIONS, WHATSAPP_PROVIDER_OPTIONS } from './onboarding-wizard-constants.ts';
 import { HOME_ASSISTANT_SURFACE_SPEC, WEBHOOK_SURFACE_SPEC } from './onboarding-wizard-external-surface-extra-specs.ts';
-import type { OnboardingWizardRadioOption } from './onboarding-wizard-types.ts';
+import type { ExternalSurfaceSetupFieldSpec, ExternalSurfaceSpec, OnboardingWizardRadioOption } from './onboarding-wizard-types.ts';
 
-export interface ExternalSurfaceSetupFieldSpec {
-  readonly id: string;
-  readonly configKey: ConfigKey;
-  readonly kind: 'text' | 'masked' | 'radio';
-  readonly valueType?: 'string' | 'number';
-  readonly label: string;
-  readonly hint: string;
-  readonly placeholder: string;
-  readonly options?: readonly OnboardingWizardRadioOption[];
-  readonly defaultNumber?: number;
-  readonly min?: number;
-  readonly max?: number;
-  readonly defaultValue: (snapshot: OnboardingSnapshotState | null) => string;
-}
-
-export interface ExternalSurfaceSpec {
-  readonly id: string;
-  readonly enabledFieldId: string;
-  readonly enabledConfigKey: ConfigKey;
-  readonly label: string;
-  readonly hint: string;
-  /**
-   * Existing SDK config key. In onboarding this maps to the per-surface
-   * auto-start choice, not to whether setup fields are shown.
-   */
-  readonly defaultEnabled: (snapshot: OnboardingSnapshotState | null) => boolean;
-  readonly fields: readonly ExternalSurfaceSetupFieldSpec[];
-}
+export type { ExternalSurfaceSetupFieldSpec, ExternalSurfaceSpec };
 
 function normalizeConfigValue(value: unknown): string {
   if (value === null || value === undefined) return '';

package/src/input/onboarding/onboarding-wizard-rules.ts

@@ -7,10 +7,10 @@ import {
   isExternalSurfaceSelectedByDefault,
 } from './onboarding-wizard-external-surfaces.ts';
 import { getExternalSurfaceSpecByFieldId, normalizeText, uniqueNonEmpty } from './onboarding-wizard-helpers.ts';
-import type { OnboardingWizardController } from './onboarding-wizard.ts';
+import type { OnboardingWizardControllerLike } from './onboarding-wizard-types.ts';
 
 export function getSharedIpDefault(
-  controller: OnboardingWizardController,
+  controller: OnboardingWizardControllerLike,
     enabled: { readonly controlPlane: boolean; readonly httpListener: boolean; readonly web: boolean },
   ): boolean {
     if (!controller.runtimeSnapshot) return true;
@@ -23,7 +23,7 @@ export function getSharedIpDefault(
   }
 
 export function getSharedIpHostDefault(
-  controller: OnboardingWizardController,
+  controller: OnboardingWizardControllerLike,
     enabled: { readonly controlPlane: boolean; readonly httpListener: boolean; readonly web: boolean },
   ): string {
     if (!controller.runtimeSnapshot) return '0.0.0.0';
@@ -35,7 +35,7 @@ export function getSharedIpHostDefault(
     return hosts[0] ?? '0.0.0.0';
   }
 
-export function toggleCapability(controller: OnboardingWizardController, capabilityId: OnboardingStep1CapabilityId): void {
+export function toggleCapability(controller: OnboardingWizardControllerLike, capabilityId: OnboardingStep1CapabilityId): void {
     if (capabilityId === 'local-tui-only') {
       for (const capability of controller.getCurrentCapabilities()) {
         controller.toggleState.set(`capabilities.${capability.id}`, capability.id === 'local-tui-only');
@@ -58,31 +58,31 @@ export function toggleCapability(controller: OnboardingWizardController, capabil
     if (!anyServerCapability) controller.toggleState.set('capabilities.local-tui-only', true);
   }
 
-export function selectAllServerCapabilities(controller: OnboardingWizardController): void {
+export function selectAllServerCapabilities(controller: OnboardingWizardControllerLike): void {
     for (const capability of controller.getCurrentCapabilities()) {
       controller.toggleState.set(`capabilities.${capability.id}`, capability.id !== 'local-tui-only');
     }
   }
 
-export function selectLocalTuiOnly(controller: OnboardingWizardController): void {
+export function selectLocalTuiOnly(controller: OnboardingWizardControllerLike): void {
     for (const capability of controller.getCurrentCapabilities()) {
       controller.toggleState.set(`capabilities.${capability.id}`, capability.id === 'local-tui-only');
     }
   }
 
-export function selectAllExternalSurfaces(controller: OnboardingWizardController): void {
+export function selectAllExternalSurfaces(controller: OnboardingWizardControllerLike): void {
     for (const surface of EXTERNAL_SURFACE_SPECS) {
       controller.toggleState.set(surface.enabledFieldId, true);
     }
   }
 
-export function clearExternalSurfaces(controller: OnboardingWizardController): void {
+export function clearExternalSurfaces(controller: OnboardingWizardControllerLike): void {
     for (const surface of EXTERNAL_SURFACE_SPECS) {
       controller.toggleState.set(surface.enabledFieldId, false);
     }
   }
 
-export function setCapabilityValue(controller: OnboardingWizardController, capabilityId: OnboardingStep1CapabilityId, selected: boolean): void {
+export function setCapabilityValue(controller: OnboardingWizardControllerLike, capabilityId: OnboardingStep1CapabilityId, selected: boolean): void {
     if (capabilityId === 'local-tui-only') {
       if (selected) {
         for (const capability of controller.getCurrentCapabilities()) {
@@ -112,20 +112,20 @@ export function setCapabilityValue(controller: OnboardingWizardController, capab
     if (!anyServerCapability) controller.toggleState.set('capabilities.local-tui-only', true);
   }
 
-export function isCapabilitySelected(controller: OnboardingWizardController, capabilityId: OnboardingStep1CapabilityId): boolean {
+export function isCapabilitySelected(controller: OnboardingWizardControllerLike, capabilityId: OnboardingStep1CapabilityId): boolean {
     return controller.getCapabilitySelectionState().some((capability) => capability.id === capabilityId && capability.selected);
   }
 
-export function hasServerCapabilitiesSelected(controller: OnboardingWizardController): boolean {
+export function hasServerCapabilitiesSelected(controller: OnboardingWizardControllerLike): boolean {
     return controller.getCapabilitySelectionState().some((capability) => capability.id !== 'local-tui-only' && capability.selected);
   }
 
-export function shouldEnableBrowserSurface(controller: OnboardingWizardController): boolean {
+export function shouldEnableBrowserSurface(controller: OnboardingWizardControllerLike): boolean {
     return controller.hasServerCapabilitiesSelected()
       && (controller.isCapabilitySelected('browser-access') || controller.isCapabilitySelected('network-access'));
   }
 
-export function hasSelectedInboundExternalSurface(controller: OnboardingWizardController): boolean {
+export function hasSelectedInboundExternalSurface(controller: OnboardingWizardControllerLike): boolean {
     if (!controller.isCapabilitySelected('external-integrations')) return false;
     return EXTERNAL_SURFACE_SPECS.some((surface) => (
       INBOUND_EXTERNAL_SURFACE_IDS.has(surface.id)
@@ -140,7 +140,7 @@ export function hasSelectedInboundExternalSurface(controller: OnboardingWizardCo
     ));
   }
 
-export function isRequiredExternalSetupField(controller: OnboardingWizardController, fieldId: string): boolean {
+export function isRequiredExternalSetupField(controller: OnboardingWizardControllerLike, fieldId: string): boolean {
     if (!REQUIRED_EXTERNAL_SETUP_FIELD_IDS.has(fieldId)) return false;
     const surface = getExternalSurfaceSpecByFieldId(fieldId);
     if (!surface) return false;
@@ -163,7 +163,7 @@ export function isRequiredExternalSetupField(controller: OnboardingWizardControl
     return true;
   }
 
-export function getSelectedSecretMedium(controller: OnboardingWizardController): 'secure' | 'plaintext' {
+export function getSelectedSecretMedium(controller: OnboardingWizardControllerLike): 'secure' | 'plaintext' {
     const policy = controller.getStringFieldValue(
       'external-services.secret-policy',
       controller.runtimeSnapshot?.runtimeDefaults.secretStoragePolicy ?? 'preferred_secure',
@@ -174,12 +174,12 @@ export function getSelectedSecretMedium(controller: OnboardingWizardController):
     return 'plaintext';
   }
 
-export function shouldEnableHttpListener(controller: OnboardingWizardController): boolean {
+export function shouldEnableHttpListener(controller: OnboardingWizardControllerLike): boolean {
     return controller.hasServerCapabilitiesSelected()
       && (controller.isCapabilitySelected('webhook-events') || controller.hasSelectedInboundExternalSurface());
   }
 
-export function shouldExposeHttpListenerNetworkFields(controller: OnboardingWizardController): boolean {
+export function shouldExposeHttpListenerNetworkFields(controller: OnboardingWizardControllerLike): boolean {
     return controller.hasServerCapabilitiesSelected()
       && (
         controller.isCapabilitySelected('webhook-events')
@@ -188,31 +188,31 @@ export function shouldExposeHttpListenerNetworkFields(controller: OnboardingWiza
       );
   }
 
-export function shouldExposeControlPlaneNetwork(controller: OnboardingWizardController): boolean {
+export function shouldExposeControlPlaneNetwork(controller: OnboardingWizardControllerLike): boolean {
     return controller.hasServerCapabilitiesSelected()
       && (controller.isCapabilitySelected('browser-access') || controller.isCapabilitySelected('network-access'));
   }
 
-export function requiresAuthBootstrap(controller: OnboardingWizardController): boolean {
+export function requiresAuthBootstrap(controller: OnboardingWizardControllerLike): boolean {
     return controller.hasServerCapabilitiesSelected()
       && (!controller.hasLocalAuthUser() || controller.hasBootstrapCredentialPresent());
   }
 
-export function hasAdminAuthUser(controller: OnboardingWizardController): boolean {
+export function hasAdminAuthUser(controller: OnboardingWizardControllerLike): boolean {
     return (controller.runtimeSnapshot?.auth.snapshot.users ?? [])
       .some((user) => user.roles.includes('admin'));
   }
 
-export function hasLocalAuthUser(controller: OnboardingWizardController): boolean {
+export function hasLocalAuthUser(controller: OnboardingWizardControllerLike): boolean {
     return (controller.runtimeSnapshot?.auth.snapshot.userCount ?? 0) > 0
       || (controller.runtimeSnapshot?.auth.snapshot.users ?? []).length > 0;
   }
 
-export function hasBootstrapCredentialPresent(controller: OnboardingWizardController): boolean {
+export function hasBootstrapCredentialPresent(controller: OnboardingWizardControllerLike): boolean {
     return controller.runtimeSnapshot?.auth.snapshot.bootstrapCredentialPresent === true;
   }
 
-export function getDefaultAdminUsername(controller: OnboardingWizardController): string {
+export function getDefaultAdminUsername(controller: OnboardingWizardControllerLike): string {
     const users = controller.runtimeSnapshot?.auth.snapshot.users ?? [];
     if (controller.hasBootstrapCredentialPresent()) {
       const existingAdmin = users.find((user) => user.roles.includes('admin'));
@@ -225,29 +225,29 @@ export function getDefaultAdminUsername(controller: OnboardingWizardController):
     return candidate ?? `goodvibes-admin-${users.length + 1}`;
   }
 
-export function getBooleanFieldValue(controller: OnboardingWizardController, fieldId: string, fallback: boolean): boolean {
+export function getBooleanFieldValue(controller: OnboardingWizardControllerLike, fieldId: string, fallback: boolean): boolean {
     return controller.toggleState.get(fieldId) ?? fallback;
   }
 
-export function getStringFieldValue(controller: OnboardingWizardController, fieldId: string, fallback: string): string {
+export function getStringFieldValue(controller: OnboardingWizardControllerLike, fieldId: string, fallback: string): string {
     const value = controller.textState.get(fieldId) ?? controller.radioState.get(fieldId);
     return normalizeText(value ?? fallback);
   }
 
-export function parseIntegerFieldValue(controller: OnboardingWizardController, fieldId: string, fallback: number): number | null {
+export function parseIntegerFieldValue(controller: OnboardingWizardControllerLike, fieldId: string, fallback: number): number | null {
     const raw = controller.getStringFieldValue(fieldId, String(fallback));
     if (!/^-?\d+$/.test(raw)) return null;
     const parsed = Number.parseInt(raw, 10);
     return Number.isInteger(parsed) ? parsed : null;
   }
 
-export function getPortFieldValue(controller: OnboardingWizardController, fieldId: string, fallback: number): number {
+export function getPortFieldValue(controller: OnboardingWizardControllerLike, fieldId: string, fallback: number): number {
     const parsed = controller.parseIntegerFieldValue(fieldId, fallback);
     if (parsed === null || parsed < 1 || parsed > 65535) return fallback;
     return parsed;
   }
 
-export function getNumberFieldValue(controller: OnboardingWizardController, fieldId: string, fallback: number, min?: number, max?: number): number {
+export function getNumberFieldValue(controller: OnboardingWizardControllerLike, fieldId: string, fallback: number, min?: number, max?: number): number {
     const parsed = controller.parseIntegerFieldValue(fieldId, fallback);
     if (parsed === null) return fallback;
     if (min !== undefined && parsed < min) return fallback;

package/src/input/onboarding/onboarding-wizard-state.ts

@@ -2,16 +2,16 @@ import type { ModelPickerTarget } from '../model-picker.ts';
 import type { OnboardingStep1CapabilityItem } from '../../runtime/onboarding/index.ts';
 import { DEFAULT_CAPABILITIES, NETWORK_HOST_FIELD_IDS } from './onboarding-wizard-constants.ts';
 import { areSelectionsEqual, clamp, cloneSelection, getExternalSurfaceSetupFieldSpec, isMalformedGoodVibesSecretReferenceValue, isValidHostValue, normalizeText } from './onboarding-wizard-helpers.ts';
-import type { OnboardingWizardController } from './onboarding-wizard.ts';
+import type { OnboardingWizardControllerLike } from './onboarding-wizard-types.ts';
 import type { OnboardingWizardFieldDefinition, OnboardingWizardModelSelection, OnboardingWizardStepDefinition } from './onboarding-wizard-types.ts';
 
-export function getToggleFieldCount(controller: OnboardingWizardController, stepIndex: number): number {
+export function getToggleFieldCount(controller: OnboardingWizardControllerLike, stepIndex: number): number {
     const step = controller.steps[stepIndex];
     if (!step) return 0;
     return step.fields.filter((field) => field.kind === 'checklist' || field.kind === 'acknowledgement').length;
   }
 
-export function getCompletedToggleCount(controller: OnboardingWizardController, stepIndex: number): number {
+export function getCompletedToggleCount(controller: OnboardingWizardControllerLike, stepIndex: number): number {
     const step = controller.steps[stepIndex];
     if (!step) return 0;
 
@@ -21,27 +21,27 @@ export function getCompletedToggleCount(controller: OnboardingWizardController,
     )).length;
   }
 
-export function getStepFieldCount(controller: OnboardingWizardController, stepIndex: number): number {
+export function getStepFieldCount(controller: OnboardingWizardControllerLike, stepIndex: number): number {
     return controller.steps[stepIndex]?.fields.length ?? 0;
   }
 
-export function getCompletedFieldCount(controller: OnboardingWizardController, stepIndex: number): number {
+export function getCompletedFieldCount(controller: OnboardingWizardControllerLike, stepIndex: number): number {
     const step = controller.steps[stepIndex];
     if (!step) return 0;
     return step.fields.filter((field) => controller.isFieldSatisfied(field)).length;
   }
 
-export function isStepDirty(controller: OnboardingWizardController, stepIndex: number): boolean {
+export function isStepDirty(controller: OnboardingWizardControllerLike, stepIndex: number): boolean {
     const stepId = controller.steps[stepIndex]?.id;
     return stepId ? controller.dirtyStepIds.has(stepId) : false;
   }
 
-export function isFieldDirty(controller: OnboardingWizardController, fieldId: string): boolean {
+export function isFieldDirty(controller: OnboardingWizardControllerLike, fieldId: string): boolean {
     const field = controller.getFieldById(fieldId);
     return field ? controller.isFieldDirtyByDefinition(field) : false;
   }
 
-export function getBlockingFieldLabels(controller: OnboardingWizardController): readonly string[] {
+export function getBlockingFieldLabels(controller: OnboardingWizardControllerLike): readonly string[] {
     const labels: string[] = [];
     if (controller.hydrationPending) {
       labels.push('Loading: Current runtime settings are still being collected.');
@@ -65,7 +65,7 @@ export function getBlockingFieldLabels(controller: OnboardingWizardController):
   }
 
 export function getFieldValidationError(
-  controller: OnboardingWizardController,
+  controller: OnboardingWizardControllerLike,
     step: OnboardingWizardStepDefinition,
     field: OnboardingWizardFieldDefinition,
   ): string | null {
@@ -127,7 +127,7 @@ export function getFieldValidationError(
     return null;
   }
 
-export function getFieldById(controller: OnboardingWizardController, fieldId: string): OnboardingWizardFieldDefinition | null {
+export function getFieldById(controller: OnboardingWizardControllerLike, fieldId: string): OnboardingWizardFieldDefinition | null {
     for (const step of controller.steps) {
       const field = step.fields.find((entry) => entry.id === fieldId);
       if (field) return field;
@@ -135,7 +135,7 @@ export function getFieldById(controller: OnboardingWizardController, fieldId: st
     return null;
   }
 
-export function ensureSelectionVisible(controller: OnboardingWizardController, visibleFields: number): void {
+export function ensureSelectionVisible(controller: OnboardingWizardControllerLike, visibleFields: number): void {
     const total = controller.currentStep.fields.length;
     if (total === 0) {
       controller.scrollOffsets[controller.stepIndex] = 0;
@@ -154,7 +154,7 @@ export function ensureSelectionVisible(controller: OnboardingWizardController, v
     controller.scrollOffsets[controller.stepIndex] = clamp(nextOffset, 0, maxStart);
   }
 
-export function reconcileStepCursor(controller: OnboardingWizardController, stepIndex: number): void {
+export function reconcileStepCursor(controller: OnboardingWizardControllerLike, stepIndex: number): void {
     const total = controller.steps[stepIndex]?.fields.length ?? 0;
     if (total === 0) {
       controller.scrollOffsets[stepIndex] = 0;
@@ -166,7 +166,7 @@ export function reconcileStepCursor(controller: OnboardingWizardController, step
     controller.scrollOffsets[stepIndex] = clamp(controller.scrollOffsets[stepIndex] ?? 0, 0, total - 1);
   }
 
-export function resetValuesFromCurrentDefinitions(controller: OnboardingWizardController): void {
+export function resetValuesFromCurrentDefinitions(controller: OnboardingWizardControllerLike): void {
     controller.toggleState.clear();
     controller.baselineToggleState.clear();
     controller.radioState.clear();
@@ -213,7 +213,7 @@ export function resetValuesFromCurrentDefinitions(controller: OnboardingWizardCo
     }
   }
 
-export function reconcileStateWithCurrentDefinitions(controller: OnboardingWizardController): void {
+export function reconcileStateWithCurrentDefinitions(controller: OnboardingWizardControllerLike): void {
     const nextToggleKeys = new Set<string>();
     const nextRadioKeys = new Set<string>();
     const nextTextKeys = new Set<string>();
@@ -282,7 +282,7 @@ export function reconcileStateWithCurrentDefinitions(controller: OnboardingWizar
     }
   }
 
-export function recalculateDirtyState(controller: OnboardingWizardController): void {
+export function recalculateDirtyState(controller: OnboardingWizardControllerLike): void {
     controller.reconcileStateWithCurrentDefinitions();
     controller.dirtyStepIds.clear();
 
@@ -293,7 +293,7 @@ export function recalculateDirtyState(controller: OnboardingWizardController): v
     }
   }
 
-export function isFieldDirtyByDefinition(controller: OnboardingWizardController, field: OnboardingWizardFieldDefinition): boolean {
+export function isFieldDirtyByDefinition(controller: OnboardingWizardControllerLike, field: OnboardingWizardFieldDefinition): boolean {
     if (field.kind === 'checklist' || field.kind === 'acknowledgement') {
       return (controller.toggleState.get(field.id) ?? field.defaultValue)
         !== (controller.baselineToggleState.get(field.id) ?? field.defaultValue);
@@ -317,7 +317,7 @@ export function isFieldDirtyByDefinition(controller: OnboardingWizardController,
     );
   }
 
-export function isFieldSatisfied(controller: OnboardingWizardController, field: OnboardingWizardFieldDefinition): boolean {
+export function isFieldSatisfied(controller: OnboardingWizardControllerLike, field: OnboardingWizardFieldDefinition): boolean {
     if (field.kind === 'checklist') {
       return true;
     }
@@ -341,20 +341,20 @@ export function isFieldSatisfied(controller: OnboardingWizardController, field:
     return selection.providerId.length > 0 || selection.modelId.length > 0;
   }
 
-export function getCurrentCapabilities(controller: OnboardingWizardController): readonly OnboardingStep1CapabilityItem[] {
+export function getCurrentCapabilities(controller: OnboardingWizardControllerLike): readonly OnboardingStep1CapabilityItem[] {
     return controller.runtimeDerived.step1Capabilities.length > 0
       ? controller.runtimeDerived.step1Capabilities
       : DEFAULT_CAPABILITIES;
   }
 
-export function getCapabilitySelectionState(controller: OnboardingWizardController): readonly OnboardingStep1CapabilityItem[] {
+export function getCapabilitySelectionState(controller: OnboardingWizardControllerLike): readonly OnboardingStep1CapabilityItem[] {
     return controller.getCurrentCapabilities().map((capability) => ({
       ...capability,
       selected: controller.toggleState.get(`capabilities.${capability.id}`) ?? capability.selected,
     }));
   }
 
-export function hasExistingAccessState(controller: OnboardingWizardController): boolean {
+export function hasExistingAccessState(controller: OnboardingWizardControllerLike): boolean {
     const auth = controller.runtimeSnapshot?.auth.snapshot;
     return controller.mode !== 'new'
       || (controller.runtimeSnapshot?.subscriptions.active.length ?? 0) > 0

package/src/input/onboarding/onboarding-wizard-steps.ts

@@ -9,10 +9,10 @@ import {
   type ExternalSurfaceSpec,
 } from './onboarding-wizard-external-surfaces.ts';
 import { countSelected, modelSelectionLabel, normalizeText } from './onboarding-wizard-helpers.ts';
-import type { OnboardingWizardController } from './onboarding-wizard.ts';
+import type { OnboardingWizardControllerLike } from './onboarding-wizard-types.ts';
 import type { OnboardingWizardAcknowledgementFieldDefinition, OnboardingWizardActionFieldDefinition, OnboardingWizardChecklistFieldDefinition, OnboardingWizardExternalSurfaceStepId, OnboardingWizardFieldDefinition, OnboardingWizardModelPickerFieldDefinition, OnboardingWizardRadioFieldDefinition, OnboardingWizardRadioOption, OnboardingWizardStepDefinition } from './onboarding-wizard-types.ts';
 
-export function buildOnboardingWizardSteps(controller: OnboardingWizardController): readonly OnboardingWizardStepDefinition[] {
+export function buildOnboardingWizardSteps(controller: OnboardingWizardControllerLike): readonly OnboardingWizardStepDefinition[] {
   if (controller.hydrationPending || controller.hydrationError !== null) return [buildLoadingStep(controller)];
 
   const capabilities = controller.getCapabilitySelectionState();
@@ -48,8 +48,8 @@ function buildApplyAndContinueAction(step: OnboardingWizardStepDefinition): Onbo
       kind: 'action',
       id: `${step.id}.apply-and-continue`,
       action: 'apply-and-continue',
-      label: 'Apply & Continue To Next Section',
-      hint: 'Save the current wizard selections in this onboarding session and move to the next section. Settings are persisted on the final Review apply.',
+      label: 'Next section',
+      hint: 'Selections are kept in this wizard session and persisted on the final Review apply.',
       defaultValue: 'Apply & next',
       spacerBeforeRows: 2,
     };
@@ -66,7 +66,7 @@ function addApplyAndContinueAction(step: OnboardingWizardStepDefinition): Onboar
     };
   }
 
-export function buildLoadingStep(controller: OnboardingWizardController): OnboardingWizardStepDefinition {
+export function buildLoadingStep(controller: OnboardingWizardControllerLike): OnboardingWizardStepDefinition {
     const failed = controller.hydrationError !== null;
     return {
       id: 'loading',
@@ -98,7 +98,7 @@ export function buildLoadingStep(controller: OnboardingWizardController): Onboar
     };
   }
 
-export function buildCapabilitiesStep(controller: OnboardingWizardController): OnboardingWizardStepDefinition {
+export function buildCapabilitiesStep(controller: OnboardingWizardControllerLike): OnboardingWizardStepDefinition {
     const capabilities = controller.getCapabilitySelectionState();
     const selectedCount = countSelected(capabilities);
     const fields: OnboardingWizardFieldDefinition[] = [
@@ -145,7 +145,7 @@ export function buildCapabilitiesStep(controller: OnboardingWizardController): O
     };
   }
 
-export function buildProvidersStep(controller: OnboardingWizardController): OnboardingWizardStepDefinition {
+export function buildProvidersStep(controller: OnboardingWizardControllerLike): OnboardingWizardStepDefinition {
     const providerAck = controller.runtimeDerived.reopenEditAcknowledgements.providers;
     const activeSubscriptions = controller.runtimeSnapshot?.subscriptions.active ?? [];
     const pendingSubscriptions = controller.runtimeSnapshot?.subscriptions.pending ?? [];
@@ -250,11 +250,11 @@ export function buildProvidersStep(controller: OnboardingWizardController): Onbo
     };
   }
 
-export function buildProviderAccessStep(controller: OnboardingWizardController): OnboardingWizardStepDefinition {
+export function buildProviderAccessStep(controller: OnboardingWizardControllerLike): OnboardingWizardStepDefinition {
     return buildProvidersStep(controller);
   }
 
-export function buildDefaultModelStep(controller: OnboardingWizardController): OnboardingWizardStepDefinition {
+export function buildDefaultModelStep(controller: OnboardingWizardControllerLike): OnboardingWizardStepDefinition {
     const routing = controller.runtimeSnapshot?.providerRouting;
     const primarySelectionField: OnboardingWizardModelPickerFieldDefinition = {
       kind: 'modelPicker',
@@ -294,7 +294,7 @@ export function buildDefaultModelStep(controller: OnboardingWizardController): O
     };
   }
 
-export function buildExternalServicesStep(controller: OnboardingWizardController): OnboardingWizardStepDefinition {
+export function buildExternalServicesStep(controller: OnboardingWizardControllerLike): OnboardingWizardStepDefinition {
     const selectedCount = EXTERNAL_SURFACE_SPECS
       .filter((surface) => controller.getBooleanFieldValue(
         surface.enabledFieldId,
@@ -355,7 +355,7 @@ export function buildExternalServicesStep(controller: OnboardingWizardController
     };
   }
 
-function getSelectedExternalSurfaceSpecs(controller: OnboardingWizardController): readonly ExternalSurfaceSpec[] {
+function getSelectedExternalSurfaceSpecs(controller: OnboardingWizardControllerLike): readonly ExternalSurfaceSpec[] {
     return EXTERNAL_SURFACE_SPECS.filter((surface) => (
       controller.getBooleanFieldValue(
         surface.enabledFieldId,
@@ -378,7 +378,7 @@ const SURFACE_AUTO_START_OPTIONS: readonly OnboardingWizardRadioOption[] = [
 ];
 
 function buildExternalSurfaceStep(
-  controller: OnboardingWizardController,
+  controller: OnboardingWizardControllerLike,
   surface: ExternalSurfaceSpec,
 ): OnboardingWizardStepDefinition {
     let setupCount = 0;
@@ -461,7 +461,7 @@ function buildExternalSurfaceStep(
     };
   }
 
-export function buildAccessStep(controller: OnboardingWizardController): OnboardingWizardStepDefinition {
+export function buildAccessStep(controller: OnboardingWizardControllerLike): OnboardingWizardStepDefinition {
     const step = buildAccountsStep(controller);
     return {
       ...step,
@@ -471,7 +471,7 @@ export function buildAccessStep(controller: OnboardingWizardController): Onboard
     };
   }
 
-export function buildExperienceStep(controller: OnboardingWizardController): OnboardingWizardStepDefinition {
+export function buildExperienceStep(controller: OnboardingWizardControllerLike): OnboardingWizardStepDefinition {
     return {
       id: 'experience',
       title: 'Shell experience',
@@ -512,7 +512,7 @@ export function buildExperienceStep(controller: OnboardingWizardController): Onb
     };
   }
 
-export function buildNetworkStep(controller: OnboardingWizardController): OnboardingWizardStepDefinition {
+export function buildNetworkStep(controller: OnboardingWizardControllerLike): OnboardingWizardStepDefinition {
     const bindSettings = controller.runtimeSnapshot?.bindSettings;
     const browserEnabled = controller.shouldEnableBrowserSurface();
     const listenerEnabled = controller.shouldExposeHttpListenerNetworkFields();
@@ -636,7 +636,7 @@ export function buildNetworkStep(controller: OnboardingWizardController): Onboar
     };
   }
 
-export function buildAccountsStep(controller: OnboardingWizardController): OnboardingWizardStepDefinition {
+export function buildAccountsStep(controller: OnboardingWizardControllerLike): OnboardingWizardStepDefinition {
     const subscriptionsAck = controller.runtimeDerived.reopenEditAcknowledgements.subscriptions;
     const authAck = controller.runtimeDerived.reopenEditAcknowledgements.auth;
     const auth = controller.runtimeSnapshot?.auth.snapshot;
@@ -740,7 +740,7 @@ export function buildAccountsStep(controller: OnboardingWizardController): Onboa
     };
   }
 
-export function buildReviewStep(controller: OnboardingWizardController): OnboardingWizardStepDefinition {
+export function buildReviewStep(controller: OnboardingWizardControllerLike): OnboardingWizardStepDefinition {
     const feedback = controller.applyFeedback;
     const feedbackFields: OnboardingWizardFieldDefinition[] = feedback
       ? [
@@ -778,19 +778,12 @@ export function buildReviewStep(controller: OnboardingWizardController): Onboard
       ],
       fields: [
         ...feedbackFields,
-        {
-          kind: 'status',
-          id: 'review.global-marker',
-          label: 'Global onboarding check',
-          hint: 'Opening this wizard marks onboarding as shown for this user account, so new projects do not reopen it automatically.',
-          defaultValue: 'Already marked as shown',
-        },
         {
           kind: 'action',
           id: 'review.apply',
           action: 'apply',
           label: 'Apply settings and verify',
-          hint: 'Persist the wizard settings and verify the resulting runtime state. The global onboarding check was already recorded when the wizard opened.',
+          hint: 'Persist the wizard settings and verify the resulting runtime state. The global onboarding check marker is recorded when apply succeeds.',
           defaultValue: 'Ready',
         },
       ],