@pellux/goodvibes-tui 0.19.85 → 0.19.87

package/src/tools/wrfc-agent-guard.ts

@@ -19,19 +19,6 @@ type AgentTaskArgs = {
   readonly [key: string]: unknown;
 };
 
-const OWNER_BLOCKED_TEMPLATES = new Set(['reviewer', 'review', 'verifier', 'tester', 'test']);
-const OWNER_BLOCKED_TASK_PREFIXES = [
-  'review ',
-  'review:',
-  'review the ',
-  'verify ',
-  'verify:',
-  'verify the ',
-  'test ',
-  'test:',
-  'test the ',
-];
-
 export function installWrfcAgentToolGuard(registry: ToolRegistry): void {
   const agentTool = registry.list().find((tool) => tool.definition.name === 'agent');
   if (!agentTool) throw new Error('WRFC agent guard could not find the agent tool.');
@@ -48,17 +35,9 @@ export function wrapWrfcAgentTool(tool: Tool): void {
 }
 
 export function validateWrfcAgentToolInvocation(args: AgentToolArgs): string | null {
-  if (args.mode === 'spawn') {
-    if (isExplicitWrfcTask(args, args) && isBlockedRootTask(args, args)) {
-      return [
-        'WRFC spawn blocked: a WRFC root task must be an owner/engineer task, not a reviewer/verifier/tester task.',
-        'Spawn one engineer/general owner with reviewMode:"wrfc"; WRFC creates reviewer and fixer agents only after owner output exists.',
-      ].join(' ');
-    }
-    return null;
-  }
-
-  if (args.mode !== 'batch-spawn') return null;
+  if (args.mode !== 'spawn' && args.mode !== 'batch-spawn') return null;
+  // SDK owns WRFC topology enforcement. TUI must not block reviewer/tester/
+  // verifier root requests because the SDK normalizes those into owner chains.
   return null;
 }
 
@@ -81,23 +60,17 @@ export function normalizeWrfcAgentToolInvocation(args: AgentToolArgs): AgentTool
         : { ...task, reviewMode: 'none', dangerously_disable_wrfc: true }),
     };
   }
-  if (tasks.length === 1 && wrfcTasks.length === 1 && !isBlockedRootTask(tasks[0], args)) {
+  if (wrfcTasks.length > 0) {
     return {
       ...args,
       reviewMode: 'wrfc',
       dangerously_disable_wrfc: false,
-      tasks: [{ ...tasks[0], reviewMode: 'wrfc', dangerously_disable_wrfc: false }],
+      tasks: tasks.map((task) => isExplicitWrfcTask(task, args)
+        ? { ...task, reviewMode: 'wrfc', dangerously_disable_wrfc: false }
+        : task),
     };
   }
-
-  const ownerTask = buildCollapsedWrfcOwnerTask(args, tasks);
-  return {
-    ...args,
-    template: normalizeOwnerTemplate(args.template),
-    reviewMode: 'wrfc',
-    dangerously_disable_wrfc: false,
-    tasks: [ownerTask],
-  };
+  return args;
 }
 
 function isRecord(value: unknown): value is AgentTaskArgs {
@@ -113,53 +86,6 @@ function isExplicitWrfcTask(task: AgentTaskArgs, root: AgentToolArgs): boolean {
     || containsWrfcSignal(root.task);
 }
 
-function isBlockedOwnerTemplate(value: unknown): boolean {
-  if (typeof value !== 'string') return false;
-  return OWNER_BLOCKED_TEMPLATES.has(value.trim().toLowerCase());
-}
-
-function isBlockedRootTask(task: AgentTaskArgs, root: AgentToolArgs): boolean {
-  if (isBlockedOwnerTemplate(task.template ?? root.template)) return true;
-  if (typeof task.task !== 'string') return false;
-  const normalized = task.task.trim().toLowerCase();
-  return OWNER_BLOCKED_TASK_PREFIXES.some((prefix) => normalized.startsWith(prefix));
-}
-
-function normalizeOwnerTemplate(value: unknown): string {
-  if (isBlockedOwnerTemplate(value)) return 'engineer';
-  return typeof value === 'string' && value.trim().length > 0 ? value : 'engineer';
-}
-
-function buildCollapsedWrfcOwnerTask(root: AgentToolArgs, taskList: AgentTaskArgs[]): AgentTaskArgs {
-  const firstOwner = taskList.find((task) => isExplicitWrfcTask(task, root) && !isBlockedRootTask(task, root))
-    ?? taskList.find((task) => !isBlockedRootTask(task, root))
-    ?? taskList[0]
-    ?? {};
-  const taskLines = taskList.map((task, index) => {
-    const body = typeof task.task === 'string' && task.task.trim().length > 0 ? task.task.trim() : '(missing task text)';
-    const template = typeof task.template === 'string' && task.template.trim().length > 0 ? task.template.trim() : 'default';
-    return `${index + 1}. [${template}] ${body}`;
-  });
-  const rootTask = typeof root.task === 'string' && root.task.trim().length > 0
-    ? `\n\nRoot task:\n${root.task.trim()}`
-    : '';
-  return {
-    ...firstOwner,
-    task: [
-      'Complete the requested work as a single WRFC owner chain.',
-      'Do not spawn reviewer, verifier, tester, or parallel root WRFC agents yourself.',
-      'Use the attempted batch items below as context for one coherent owner deliverable; the WRFC controller will create review/fix agents after owner output exists.',
-      rootTask,
-      '',
-      'Attempted batch items:',
-      ...taskLines,
-    ].join('\n'),
-    template: normalizeOwnerTemplate(firstOwner.template ?? root.template),
-    reviewMode: 'wrfc',
-    dangerously_disable_wrfc: false,
-  };
-}
-
 function containsWrfcSignal(value: unknown): boolean {
   if (typeof value !== 'string') return false;
   return /\bwrfc\b|work[-\s]*review[-\s]*fix/i.test(value);

package/src/version.ts

@@ -6,7 +6,7 @@ import { join } from 'node:path';
 // The prebuild script updates the fallback value before compilation.
 // Uses import.meta.dir (Bun) to locate package.json relative to this file,
 // which is correct regardless of the process working directory.
-let _version = '0.19.85';
+let _version = '0.19.87';
 try {
   const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8'));
   _version = pkg.version ?? _version;