@pellux/goodvibes-tui 0.19.64 → 0.19.65

package/CHANGELOG.md

@@ -8,6 +8,26 @@ All notable changes to GoodVibes TUI.
 
 ---
 
+## [0.19.65] — 2026-05-05
+
+### Fixed
+- Made `/config service` changes apply to the OS service layer instead of only writing `~/.goodvibes/tui/settings.json`.
+- Enabling `service.autostart` now enables service mode if needed, writes the platform service definition, reloads systemd user units when applicable, and starts/enables the service.
+- Disabling `service.autostart` or `service.enabled` now disables/removes the platform service definition instead of leaving stale OS autostart state behind.
+- Service definition changes such as restart-on-failure, platform, service name, or log path now rewrite and restart the OS service when service mode and autostart are active.
+- Added a visible `/config` status notice for service install/start/disable/update results after a setting change.
+
+### Verified
+- `bun test src/test/shell/service-settings-sync.test.ts src/test/input/settings-modal-network.test.ts`
+- `bun run test`
+- `bunx tsc --noEmit`
+- `bun run build:prod`
+- `bun run smoke:tui`
+- `bun run smoke:daemon`
+- `git diff --check`
+
+---
+
 ## [0.19.64] — 2026-05-05
 
 ### Fixed

package/README.md

@@ -2,7 +2,7 @@
 
 [![CI](https://github.com/mgd34msu/goodvibes-tui/actions/workflows/ci.yml/badge.svg)](https://github.com/mgd34msu/goodvibes-tui/actions/workflows/ci.yml)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
-[![Version](https://img.shields.io/badge/version-0.19.64-blue.svg)](https://github.com/mgd34msu/goodvibes-tui)
+[![Version](https://img.shields.io/badge/version-0.19.65-blue.svg)](https://github.com/mgd34msu/goodvibes-tui)
 
 A terminal-native AI coding, operations, automation, knowledge, and integration console with a typed runtime, omnichannel surfaces, structured memory/knowledge, and a raw ANSI renderer.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pellux/goodvibes-tui",
-  "version": "0.19.64",
+  "version": "0.19.65",
   "description": "Terminal-native GoodVibes product for coding, operations, automation, knowledge, channels, and daemon-backed control-plane workflows.",
   "type": "module",
   "main": "src/main.ts",

package/src/input/settings-modal.ts

@@ -42,6 +42,22 @@ import {
   type SubscriptionEntry,
 } from './settings-modal-types.ts';
 
+export interface SettingsModalChange {
+  readonly key: ConfigKey;
+  readonly previousValue: unknown;
+  readonly value: unknown;
+}
+
+export interface SettingsModalChangeResult {
+  readonly message?: string;
+}
+
+export type SettingsModalChangeHandler = (change: SettingsModalChange) => SettingsModalChangeResult | void;
+
+export interface SettingsModalOpenOptions {
+  readonly onSettingApplied?: SettingsModalChangeHandler;
+}
+
 export {
   SETTINGS_CATEGORIES,
   type FlagEntry,
@@ -104,6 +120,7 @@ export class SettingsModal {
    * Cleared on next open() or close().
    */
   public lastSaveTriggeredRestart: 'control-plane' | 'http-listener' | 'web' | null = null;
+  public lastSettingEffectMessage: string | null = null;
 
   private configManager: ConfigManager | null = null;
   private secretsManager: SettingsSecretsManager | null = null;
@@ -111,6 +128,7 @@ export class SettingsModal {
   private mcpRegistry: McpRegistry | null = null;
   private subscriptionManager: SubscriptionManager | null = null;
   private serviceRegistry: Pick<ServiceInspectionQuery, 'getAll'> | null = null;
+  private onSettingApplied: SettingsModalChangeHandler | null = null;
 
   /**
    * Open the modal, loading current config values from configManager.
@@ -125,6 +143,7 @@ export class SettingsModal {
     serviceRegistry: Pick<ServiceInspectionQuery, 'getAll'>,
     mcpRegistry?: McpRegistry,
     secretsManager?: SettingsSecretsManager,
+    options?: SettingsModalOpenOptions,
   ): void {
     this.configManager = configManager;
     this.secretsManager = secretsManager ?? null;
@@ -132,6 +151,7 @@ export class SettingsModal {
     this.subscriptionManager = subscriptionManager;
     this.serviceRegistry = serviceRegistry;
     this.mcpRegistry = mcpRegistry ?? null;
+    this.onSettingApplied = options?.onSettingApplied ?? null;
     this._loadGroups(configManager);
     this._loadFlagEntries();
     this._loadMcpEntries();
@@ -147,6 +167,7 @@ export class SettingsModal {
     this.mcpAllowAllConfirmationTarget = null;
     this.subscriptionLogoutConfirmationTarget = null;
     this.lastSaveTriggeredRestart = null;
+    this.lastSettingEffectMessage = null;
     this.active = true;
   }
 
@@ -160,8 +181,10 @@ export class SettingsModal {
     this.mcpAllowAllConfirmationTarget = null;
     this.subscriptionLogoutConfirmationTarget = null;
     this.lastSaveTriggeredRestart = null;
+    this.lastSettingEffectMessage = null;
     this.serviceRegistry = null;
     this.secretsManager = null;
+    this.onSettingApplied = null;
     this.focusPane = 'settings';
   }
 
@@ -715,6 +738,16 @@ export class SettingsModal {
     return items;
   }
 
+  private _refreshAllEntries(): void {
+    if (!this.configManager) return;
+    for (const entries of this.groups.values()) {
+      for (const entry of entries) {
+        entry.currentValue = this.configManager.get(entry.setting.key as ConfigKey);
+        entry.isDefault = entry.currentValue === entry.setting.default;
+      }
+    }
+  }
+
   private _setValue(key: ConfigKey, value: unknown): void {
     if (!this.configManager) return;
     // Diff previous value before writing — avoids false restart notices on no-op saves
@@ -744,8 +777,14 @@ export class SettingsModal {
           entry.isDefault = entry.currentValue === entry.setting.default;
         }
       }
+      if (previousValue !== value && this.onSettingApplied) {
+        const result = this.onSettingApplied({ key, previousValue, value });
+        this.lastSettingEffectMessage = result?.message ?? null;
+        this._refreshAllEntries();
+      }
     } catch (e) {
       logger.error('SettingsModal: failed to set config value', { key, error: summarizeError(e) });
+      this.lastSettingEffectMessage = `Save failed: ${summarizeError(e)}`;
     }
   }
 

package/src/main.ts

@@ -678,6 +678,8 @@ async function main() {
     subscriptionManager,
     secretsManager,
     serviceRegistry: ctx.services.serviceRegistry,
+    workingDirectory: workingDir,
+    homeDirectory,
     getConfiguredProviderIds: ctx._getConfiguredProviderIds,
     getPinned: ctx._getPinned,
     render,

package/src/renderer/settings-modal.ts

@@ -590,7 +590,11 @@ export function renderSettingsModal(
   const header = contentLine(safeWidth, PALETTE.footerBg);
   drawVertical(header, dividerX, PALETTE.footerBg);
   writeText(header, leftStart + 1, leftWidth - 2, 'Categories', { fg: PALETTE.subtitle, bold: true, bg: PALETTE.footerBg });
-  const headerText = `${CATEGORY_LABELS[modal.currentCategory]} (${categoryItemCount(modal, modal.currentCategory)})${modal.lastSaveTriggeredRestart ? ` · Restarting ${modal.lastSaveTriggeredRestart}` : ''}`;
+  const notices = [
+    ...(modal.lastSaveTriggeredRestart ? [`Restarting ${modal.lastSaveTriggeredRestart}`] : []),
+    ...(modal.lastSettingEffectMessage ? [modal.lastSettingEffectMessage] : []),
+  ];
+  const headerText = `${CATEGORY_LABELS[modal.currentCategory]} (${categoryItemCount(modal, modal.currentCategory)})${notices.length > 0 ? ` · ${notices.join(' · ')}` : ''}`;
   writeText(header, centerStart + 1, centerWidth - 2, headerText, { fg: PALETTE.subtitle, bold: true, bg: PALETTE.footerBg });
   lines.push(header);
 

package/src/shell/service-settings-sync.ts

@@ -0,0 +1,273 @@
+import { mkdirSync } from 'node:fs';
+import { spawnSync } from 'node:child_process';
+import type { ConfigKey } from '@pellux/goodvibes-sdk/platform/config';
+import type { ManagedServiceStatus } from '@pellux/goodvibes-sdk/platform/daemon';
+import { logger, summarizeError } from '@pellux/goodvibes-sdk/platform/utils';
+import {
+  createPlatformServiceManager,
+  getServiceStateRoot,
+  type CliServiceRuntime,
+} from '../cli/service-posture.ts';
+
+type ManagedServiceAction = 'install' | 'uninstall' | 'start' | 'stop' | 'restart' | 'status';
+
+export interface ServiceManagerLike {
+  status(): ManagedServiceStatus;
+  install(): ManagedServiceStatus;
+  uninstall(): ManagedServiceStatus;
+  start(): ManagedServiceStatus;
+  stop(): ManagedServiceStatus;
+  restart(): ManagedServiceStatus;
+}
+
+export interface CommandResult {
+  readonly status: number | null;
+  readonly stdout?: string;
+  readonly stderr?: string;
+}
+
+export interface ServiceSettingsSyncChange {
+  readonly key: ConfigKey;
+  readonly previousValue: unknown;
+  readonly value: unknown;
+}
+
+export interface ServiceSettingsSyncResult {
+  readonly handled: boolean;
+  readonly action?: ManagedServiceAction | 'install-start' | 'disable';
+  readonly status?: ManagedServiceStatus;
+  readonly message?: string;
+  readonly error?: string;
+}
+
+export interface ServiceSettingsSyncOptions {
+  readonly createManager?: (runtime: CliServiceRuntime) => ServiceManagerLike;
+  readonly runCommand?: (command: string, args: readonly string[]) => CommandResult;
+  readonly mkdir?: typeof mkdirSync;
+}
+
+const SERVICE_DEFINITION_KEYS = new Set<ConfigKey>([
+  'service.restartOnFailure',
+  'service.platform',
+  'service.serviceName',
+  'service.logPath',
+] as ConfigKey[]);
+
+function runCommand(command: string, args: readonly string[], options: ServiceSettingsSyncOptions): CommandResult {
+  if (options.runCommand) return options.runCommand(command, args);
+  return spawnSync(command, [...args], { stdio: 'pipe', encoding: 'utf-8' });
+}
+
+function commandError(result: CommandResult): string | null {
+  if ((result.status ?? 1) === 0) return null;
+  return ((result.stderr ?? '') || (result.stdout ?? '') || `command exited with ${result.status}`).trim();
+}
+
+function serviceName(runtime: CliServiceRuntime, fallback = 'goodvibes'): string {
+  return String(runtime.configManager.get('service.serviceName') ?? fallback).trim() || fallback;
+}
+
+function runSystemd(runtime: CliServiceRuntime, args: readonly string[], options: ServiceSettingsSyncOptions): string | null {
+  const result = runCommand('systemctl', ['--user', ...args], options);
+  return commandError(result);
+}
+
+function reloadSystemdIfNeeded(
+  runtime: CliServiceRuntime,
+  status: ManagedServiceStatus,
+  options: ServiceSettingsSyncOptions,
+): string | null {
+  if (status.platform !== 'systemd') return null;
+  return runSystemd(runtime, ['daemon-reload'], options);
+}
+
+function disableSystemService(
+  runtime: CliServiceRuntime,
+  manager: ServiceManagerLike,
+  options: ServiceSettingsSyncOptions,
+): ServiceSettingsSyncResult {
+  const before = manager.status();
+  let disableError: string | null = null;
+  if (before.platform === 'systemd') {
+    disableError = before.installed || before.running
+      ? runSystemd(runtime, ['disable', '--now', `${serviceName(runtime)}.service`], options)
+      : null;
+    if (disableError) {
+      logger.warn('Settings service sync: systemd disable failed', { error: disableError });
+    }
+  } else if (before.running || before.installed) {
+    const stopped = manager.stop();
+    if (stopped.actionError) {
+      return {
+        handled: true,
+        action: 'stop',
+        status: stopped,
+        message: `Service disable failed: ${stopped.actionError}`,
+        error: stopped.actionError,
+      };
+    }
+  }
+
+  const uninstalled = manager.uninstall();
+  const reloadError = reloadSystemdIfNeeded(runtime, uninstalled, options);
+  const error = uninstalled.actionError ?? reloadError ?? disableError ?? undefined;
+  return {
+    handled: true,
+    action: 'disable',
+    status: uninstalled,
+    message: error ? `Service disable failed: ${error}` : 'OS service disabled',
+    ...(error ? { error } : {}),
+  };
+}
+
+function installAndStartSystemService(
+  runtime: CliServiceRuntime,
+  manager: ServiceManagerLike,
+  options: ServiceSettingsSyncOptions,
+): ServiceSettingsSyncResult {
+  (options.mkdir ?? mkdirSync)(getServiceStateRoot(runtime), { recursive: true });
+  const installed = manager.install();
+  if (installed.actionError) {
+    return {
+      handled: true,
+      action: 'install',
+      status: installed,
+      message: `Service install failed: ${installed.actionError}`,
+      error: installed.actionError,
+    };
+  }
+
+  const reloadError = reloadSystemdIfNeeded(runtime, installed, options);
+  if (reloadError) {
+    return {
+      handled: true,
+      action: 'install',
+      status: installed,
+      message: `Service install failed: ${reloadError}`,
+      error: reloadError,
+    };
+  }
+
+  const started = manager.start();
+  const error = started.actionError ?? undefined;
+  return {
+    handled: true,
+    action: 'install-start',
+    status: started,
+    message: error ? `Service start failed: ${error}` : 'OS service installed and started',
+    ...(error ? { error } : {}),
+  };
+}
+
+function refreshInstalledSystemService(
+  runtime: CliServiceRuntime,
+  manager: ServiceManagerLike,
+  options: ServiceSettingsSyncOptions,
+): ServiceSettingsSyncResult {
+  const before = manager.status();
+  if (!before.installed && runtime.configManager.get('service.autostart') !== true) {
+    return {
+      handled: true,
+      action: 'status',
+      status: before,
+      message: 'Service setting saved',
+    };
+  }
+
+  const installed = manager.install();
+  if (installed.actionError) {
+    return {
+      handled: true,
+      action: 'install',
+      status: installed,
+      message: `Service update failed: ${installed.actionError}`,
+      error: installed.actionError,
+    };
+  }
+
+  const reloadError = reloadSystemdIfNeeded(runtime, installed, options);
+  if (reloadError) {
+    return {
+      handled: true,
+      action: 'install',
+      status: installed,
+      message: `Service update failed: ${reloadError}`,
+      error: reloadError,
+    };
+  }
+
+  const next = before.running ? manager.restart() : manager.start();
+  const error = next.actionError ?? undefined;
+  return {
+    handled: true,
+    action: before.running ? 'restart' : 'start',
+    status: next,
+    message: error ? `Service update failed: ${error}` : 'OS service updated',
+    ...(error ? { error } : {}),
+  };
+}
+
+export function syncServiceSettingToPlatform(
+  runtime: CliServiceRuntime,
+  change: ServiceSettingsSyncChange,
+  options: ServiceSettingsSyncOptions = {},
+): ServiceSettingsSyncResult {
+  if (!String(change.key).startsWith('service.')) return { handled: false };
+  if (change.previousValue === change.value) return { handled: true, message: 'Service setting unchanged' };
+
+  const manager = options.createManager?.(runtime) ?? createPlatformServiceManager(runtime);
+
+  try {
+    if (change.key === 'service.autostart') {
+      if (change.value === true) {
+        if (runtime.configManager.get('service.enabled') !== true) {
+          runtime.configManager.setDynamic('service.enabled', true);
+        }
+        return installAndStartSystemService(runtime, manager, options);
+      }
+      return disableSystemService(runtime, manager, options);
+    }
+
+    if (change.key === 'service.enabled') {
+      if (change.value === false) {
+        if (runtime.configManager.get('service.autostart') === true) {
+          runtime.configManager.setDynamic('service.autostart', false);
+        }
+        return disableSystemService(runtime, manager, options);
+      }
+      if (runtime.configManager.get('service.autostart') === true) {
+        return installAndStartSystemService(runtime, manager, options);
+      }
+      return {
+        handled: true,
+        action: 'status',
+        status: manager.status(),
+        message: 'Service mode saved; enable autostart to install the OS service',
+      };
+    }
+
+    if (SERVICE_DEFINITION_KEYS.has(change.key)) {
+      if (runtime.configManager.get('service.enabled') === true && runtime.configManager.get('service.autostart') === true) {
+        return refreshInstalledSystemService(runtime, manager, options);
+      }
+      return {
+        handled: true,
+        action: 'status',
+        status: manager.status(),
+        message: 'Service setting saved; enable autostart to install the OS service',
+      };
+    }
+  } catch (error) {
+    const summarized = summarizeError(error);
+    logger.error('Settings service sync failed', { key: change.key, error: summarized });
+    return {
+      handled: true,
+      action: 'status',
+      status: manager.status(),
+      message: `Service sync failed: ${summarized}`,
+      error: summarized,
+    };
+  }
+
+  return { handled: false };
+}

package/src/shell/ui-openers.ts

@@ -12,6 +12,7 @@ import type { SubscriptionManager } from '@pellux/goodvibes-sdk/platform/config'
 import type { SecretsManager } from '@pellux/goodvibes-sdk/platform/config';
 import type { ServiceInspectionQuery } from '../runtime/ui-service-queries.ts';
 import type { ModelPickerTargetInfo } from '../input/model-picker.ts';
+import { syncServiceSettingToPlatform } from './service-settings-sync.ts';
 
 type WireShellUiOpenersOptions = {
   commandContext: CommandContext;
@@ -26,6 +27,8 @@ type WireShellUiOpenersOptions = {
   subscriptionManager: SubscriptionManager;
   secretsManager?: Pick<SecretsManager, 'delete' | 'get' | 'set'>;
   serviceRegistry: Pick<ServiceInspectionQuery, 'getAll'>;
+  workingDirectory: string;
+  homeDirectory: string;
   getConfiguredProviderIds: () => string[];
   getPinned: () => Promise<string[]>;
   render: () => void;
@@ -89,6 +92,8 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
     subscriptionManager,
     secretsManager,
     serviceRegistry,
+    workingDirectory,
+    homeDirectory,
     getConfiguredProviderIds,
     getPinned,
     render,
@@ -264,7 +269,12 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
 
   commandContext.openSettingsModal = (target?: string) => {
     input.modalOpened('settings');
-    input.settingsModal.open(configManager, featureFlags, subscriptionManager, serviceRegistry, mcpRegistry, secretsManager);
+    input.settingsModal.open(configManager, featureFlags, subscriptionManager, serviceRegistry, mcpRegistry, secretsManager, {
+      onSettingApplied: (change) => syncServiceSettingToPlatform(
+        { configManager, workingDirectory, homeDirectory },
+        change,
+      ),
+    });
     input.settingsModal.selectTarget(target);
     render();
   };

package/src/version.ts

@@ -6,7 +6,7 @@ import { join } from 'node:path';
 // The prebuild script updates the fallback value before compilation.
 // Uses import.meta.dir (Bun) to locate package.json relative to this file,
 // which is correct regardless of the process working directory.
-let _version = '0.19.64';
+let _version = '0.19.65';
 try {
   const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8'));
   _version = pkg.version ?? _version;