@pellux/goodvibes-tui 0.19.26 → 0.19.28

package/src/runtime/onboarding/types.ts

@@ -26,9 +26,9 @@ export type OnboardingAcknowledgementReason =
 
 export type OnboardingVerificationStatus = 'pass' | 'warn' | 'fail';
 
-export type OnboardingCompletionMarkerScope = 'user' | 'project';
+export type OnboardingStateScope = 'user' | 'project';
 
-export type OnboardingCompletionMarkerSource = 'wizard' | 'command' | 'import' | 'unknown';
+export type OnboardingCheckMarkerSource = 'wizard' | 'command' | 'import' | 'unknown';
 
 export interface OnboardingConfigSnapshot {
   readonly display: GoodVibesConfig['display'];
@@ -147,7 +147,7 @@ export interface OnboardingRuntimeDefaultsSnapshot {
 }
 
 export interface OnboardingAcknowledgementSnapshot {
-  readonly scope: OnboardingCompletionMarkerScope;
+  readonly scope: OnboardingStateScope;
   readonly exists: boolean;
   readonly updatedAt: number | null;
   readonly source: string | null;
@@ -258,12 +258,6 @@ export type OnboardingApplyOperation =
       readonly kind: 'acknowledge';
       readonly target: OnboardingAcknowledgementTarget;
       readonly acknowledged: boolean;
-    }
-  | {
-      readonly kind: 'set-completion-marker';
-      readonly scope: OnboardingCompletionMarkerScope;
-      readonly completed: boolean;
-      readonly payload?: Partial<OnboardingCompletionMarkerPayload>;
     };
 
 export interface OnboardingApplyRequest {
@@ -316,34 +310,34 @@ export interface OnboardingAcknowledgementRuntimeState {
   readonly acknowledgements: Partial<Record<OnboardingAcknowledgementTarget, boolean>>;
 }
 
-export interface OnboardingCompletionMarkerPayload {
+export interface OnboardingCheckMarkerPayload {
   readonly version: 1;
-  readonly completedAt: number;
+  readonly checkedAt: number;
   readonly updatedAt: number;
-  readonly source: OnboardingCompletionMarkerSource;
+  readonly source: OnboardingCheckMarkerSource;
   readonly mode?: OnboardingMode;
   readonly workspaceRoot?: string;
 }
 
-export interface OnboardingCompletionMarkerState {
-  readonly scope: OnboardingCompletionMarkerScope;
+export interface OnboardingCheckMarkerState {
+  readonly scope: OnboardingStateScope;
   readonly path: string;
   readonly exists: boolean;
-  readonly payload: OnboardingCompletionMarkerPayload | null;
+  readonly payload: OnboardingCheckMarkerPayload | null;
   readonly parseError?: string;
 }
 
-export interface OnboardingCompletionMarkersState {
-  readonly user: OnboardingCompletionMarkerState;
-  readonly project: OnboardingCompletionMarkerState;
-  readonly effective: OnboardingCompletionMarkerState | null;
+export interface OnboardingCheckMarkersState {
+  readonly user: OnboardingCheckMarkerState;
+  readonly project: OnboardingCheckMarkerState;
+  readonly effective: OnboardingCheckMarkerState | null;
 }
 
-export interface WriteOnboardingCompletionMarkerOptions {
-  readonly scope?: OnboardingCompletionMarkerScope;
-  readonly completedAt?: number;
+export interface WriteOnboardingCheckMarkerOptions {
+  readonly scope?: OnboardingStateScope;
+  readonly checkedAt?: number;
   readonly updatedAt?: number;
-  readonly source?: OnboardingCompletionMarkerSource;
+  readonly source?: OnboardingCheckMarkerSource;
   readonly mode?: OnboardingMode;
   readonly workspaceRoot?: string;
 }
@@ -371,7 +365,7 @@ export interface OnboardingSnapshotDependencies {
   readonly surfaces?: OnboardingSurfaceReadHelper;
   readonly providerAccounts?: OnboardingProviderAccountReadHelper;
   readonly shellPaths?: OnboardingShellPaths;
-  readonly acknowledgementScope?: OnboardingCompletionMarkerScope;
+  readonly acknowledgementScope?: OnboardingStateScope;
 }
 
 export interface OnboardingApplyDependencies {
@@ -389,7 +383,7 @@ export interface OnboardingApplyDependencies {
     | 'revokeSession'
   >;
   readonly shellPaths: OnboardingShellPaths;
-  readonly acknowledgementScope?: OnboardingCompletionMarkerScope;
+  readonly acknowledgementScope?: OnboardingStateScope;
 }
 
 export interface OnboardingVerificationDependencies {
@@ -398,5 +392,5 @@ export interface OnboardingVerificationDependencies {
   readonly secrets?: Pick<SecretsManager, 'get'>;
   readonly auth?: Pick<UserAuthManager, 'inspect'>;
   readonly shellPaths: OnboardingShellPaths;
-  readonly acknowledgementScope?: OnboardingCompletionMarkerScope;
+  readonly acknowledgementScope?: OnboardingStateScope;
 }

package/src/runtime/onboarding/verify.ts

@@ -1,5 +1,4 @@
 import { isSecretRefInput } from '@pellux/goodvibes-sdk/platform/config/secret-refs';
-import { readOnboardingCompletionMarker } from './markers.ts';
 import { readOnboardingRuntimeState } from './state.ts';
 import type {
   OnboardingApplyOperation,
@@ -13,11 +12,6 @@ function getNow(deps: Pick<OnboardingVerificationDependencies, 'clock'>): number
   return deps.clock?.() ?? Date.now();
 }
 
-function normalizeCompletionSource(source: string): 'wizard' | 'command' | 'import' | 'unknown' {
-  if (source === 'wizard' || source === 'command' || source === 'import') return source;
-  return 'unknown';
-}
-
 function isDeepEqual(left: unknown, right: unknown): boolean {
   if (Object.is(left, right)) return true;
   if (Array.isArray(left) && Array.isArray(right)) {
@@ -89,60 +83,6 @@ function verifyAcknowledgementOperation(
   };
 }
 
-function verifyCompletionMarkerOperation(
-  deps: OnboardingVerificationDependencies,
-  request: OnboardingApplyRequest,
-  operation: Extract<OnboardingApplyOperation, { kind: 'set-completion-marker' }>,
-): OnboardingVerificationItem {
-  const marker = readOnboardingCompletionMarker(deps.shellPaths, operation.scope);
-  if (marker.parseError) {
-    return {
-      id: `marker:${operation.scope}`,
-      status: 'fail',
-      message: `Onboarding completion marker could not be parsed: ${marker.parseError}`,
-      target: operation.scope,
-    };
-  }
-
-  if (!operation.completed) {
-    return {
-      id: `marker:${operation.scope}`,
-      status: marker.exists ? 'fail' : 'pass',
-      message: marker.exists
-        ? `${operation.scope} onboarding completion marker still exists.`
-        : `${operation.scope} onboarding completion marker is cleared.`,
-      target: operation.scope,
-    };
-  }
-
-  if (!marker.payload) {
-    return {
-      id: `marker:${operation.scope}`,
-      status: 'fail',
-      message: `${operation.scope} onboarding completion marker is missing.`,
-      target: operation.scope,
-    };
-  }
-
-  const expectedSource = operation.payload?.source ?? normalizeCompletionSource(request.source);
-  const expectedMode = operation.payload?.mode ?? request.mode;
-  const expectedWorkspaceRoot = operation.payload?.workspaceRoot ?? deps.shellPaths.workingDirectory;
-  const payloadMatches = marker.payload.source === expectedSource
-    && (expectedMode === undefined || marker.payload.mode === expectedMode)
-    && (expectedWorkspaceRoot === undefined || marker.payload.workspaceRoot === expectedWorkspaceRoot)
-    && (operation.payload?.completedAt === undefined || marker.payload.completedAt === operation.payload.completedAt)
-    && (operation.payload?.updatedAt === undefined || marker.payload.updatedAt === operation.payload.updatedAt);
-
-  return {
-    id: `marker:${operation.scope}`,
-    status: payloadMatches ? 'pass' : 'fail',
-    message: payloadMatches
-      ? `${operation.scope} onboarding completion marker matches the requested state.`
-      : `${operation.scope} onboarding completion marker does not match the requested state.`,
-    target: operation.scope,
-  };
-}
-
 async function verifySecretOperation(
   deps: OnboardingVerificationDependencies,
   operation: Extract<OnboardingApplyOperation, { kind: 'set-secret' }>,
@@ -209,21 +149,19 @@ function verifyAuthOperation(
 
 async function verifyOperation(
   deps: OnboardingVerificationDependencies,
-  request: OnboardingApplyRequest,
   operation: OnboardingApplyOperation,
 ): Promise<OnboardingVerificationItem> {
   if (operation.kind === 'set-config') return verifyConfigOperation(deps, operation);
   if (operation.kind === 'set-secret') return verifySecretOperation(deps, operation);
   if (operation.kind === 'ensure-auth-user') return verifyAuthOperation(deps, operation);
-  if (operation.kind === 'acknowledge') return verifyAcknowledgementOperation(deps, operation);
-  return verifyCompletionMarkerOperation(deps, request, operation);
+  return verifyAcknowledgementOperation(deps, operation);
 }
 
 export async function verifyOnboardingRequest(
   deps: OnboardingVerificationDependencies,
   request: OnboardingApplyRequest,
 ): Promise<OnboardingVerificationResult> {
-  const items = await Promise.all(request.operations.map((operation) => verifyOperation(deps, request, operation)));
+  const items = await Promise.all(request.operations.map((operation) => verifyOperation(deps, operation)));
 
   return {
     verifiedAt: getNow(deps),

package/src/version.ts

@@ -6,7 +6,7 @@ import { join } from 'node:path';
 // The prebuild script updates the fallback value before compilation.
 // Uses import.meta.dir (Bun) to locate package.json relative to this file,
 // which is correct regardless of the process working directory.
-let _version = '0.19.26';
+let _version = '0.19.28';
 try {
   const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8'));
   _version = pkg.version ?? _version;