@pellux/goodvibes-tui 0.19.10 → 0.19.13

package/CHANGELOG.md

@@ -4,6 +4,85 @@ All notable changes to GoodVibes TUI.
 
 ---
 
+## [0.19.13] - 2026-04-20
+
+### Changed
+- Upgraded `@pellux/goodvibes-sdk` to 0.21.25 (0.21.24 was CI-orphaned; 0.21.25 is the actual release). Picks up: (1) F16b — `resolveDefaultProviderModel` callback hook added to companion-chat-routes session-create handler (router plumbing pending, see below); (2) F17 — `POST /inputs/:iid/cancel` on non-queued state now returns `409 CANCEL_NOT_ALLOWED`; (3) F19 — `PATCH /api/channels/policies/:surface` handler restored; (4) F-PROV-009 — `secretsResolutionSkipped:true` on provider response when secrets store unavailable; (5) `GET /api/runtime/scheduler` capacity observability endpoint added.
+- TUI version bumped to 0.19.13.
+
+### Fixed
+- **F18** — `docs/uat/UAT-PLAN.md` UAT-WATCH-001 corrected: watcher creation body uses `label` field (not `name`). Steps now show `{"label":"<name>","kind":"poll","intervalMs":60000}` and note that the watcher `id` is derived from the `label` value. F18 note added to the test case.
+- **Failure tracker** — `.goodvibes/memory/failures.json` updated: F17, F19, F-PROV-009 marked resolved in SDK 0.21.25; F18 marked resolved in TUI 0.19.13; F16b marked partially-resolved (SDK hook merged, router plumbing incomplete — TUI wiring blocked pending SDK 0.21.26+); F5 already resolved in TUI 0.19.12.
+- **Foundation artifacts** — `docs/foundation-artifacts/operator-contract.json` regenerated to reflect SDK 0.21.25 (version field updated from 0.21.23 to 0.21.25).
+
+### Notes
+- **F16b wiring status**: SDK 0.21.25 added `resolveDefaultProviderModel` only to the companion-chat-routes handler. `DaemonHttpRouter` (router.js) does not yet thread this field from `DaemonHttpRouterContext` to `dispatchCompanionChatRoutes`. TUI cannot wire this without SDK completing the router context plumbing. No TUI code change is required until SDK exposes the hook in a public API surface (expected in a future SDK release).
+- **F5 build fix**: Already implemented in TUI 0.19.12 (`scripts/build.ts` + `scripts/post-build-smoke.ts`). The sqlite-vec native addon is copied to `dist/lib/sqlite-vec-linux-x64/vec0.so` at build time and the smoke test hard-fails if the file is absent.
+
+---
+
+## [0.19.12] - 2026-04-19
+
+### Fixed
+- **Architecture gate** — `src/panels/builtin/session.ts`: removed ambient `homedir()` calls in the `qr-code` panel factory. `daemonHomeDir` is now injected via `BuiltinPanelDeps` and resolved at the composition root (`src/runtime/bootstrap-shell.ts`) as `join(services.homeDirectory, '.goodvibes', 'daemon')`. Satisfies the `no-ambient-root-discovery-in-reusable-code` architecture rule.
+- **Architecture gate** — `src/cli-flags.ts`: `--help` text contained the literal string `process.cwd()` which matched the architecture rule pattern `/\bprocess\.cwd\(\)/`. Changed to `<cwd>` — functionally equivalent documentation, no match.
+- **CI orphan** — TUI 0.19.11 (tag `v0.19.11`, commit `26becbb`) was pushed but both CI workflows failed at `architecture:check`. No npm artifact was published. Per project pattern, retag is avoided; bumping to 0.19.12 instead.
+
+---
+
+## [0.19.11] - 2026-04-19
+
+### Changed
+- Upgraded `@pellux/goodvibes-sdk` to 0.21.23. Picks up: (1) runtime default config includes `runtime.companionChatLimiter.perSessionLimit: 10`, closing the "section 'runtime' does not exist" regression that caused 29 assertions across 9 test files to fail; (2) `buildOperatorContract` now consumes catalog via `toMethodContract`/`toEventContract` projectors, populating `methods`, `events`, and `coverage` from the live catalog rather than a static baked contract; (3) `RuntimeEventDomain` includes `'workspace'` domain (27 total) sourced from generated file; (4) browser tests guard with `skipIf(typeof window === 'undefined')`.
+
+### Fixed
+- `method-catalog.test.ts` `buildOperatorContract` assertion restored to strict form: `contract.operator.events` now asserts `toHaveLength(catalog.listEvents().length)` (was loosened to `toBeGreaterThan(0)` during SDK 0.21.20–0.21.21 regression). Failure tracker entry `sdk-buildoperatorcontract-regression-0-21-20` closed (`resolved_in: @pellux/goodvibes-sdk@0.21.22`, `resolved_by_sdk_version: 0.21.23`).
+- All 29 previously-failing assertions across 9 test files caused by missing `runtime` section in SDK default config are now green (fixed by SDK 0.21.23 runtime default config inclusion).
+- Regenerated foundation artifacts to reflect SDK 0.21.23 operator contract (30 events, 27 domains, includes `workspace` domain). Full test suite: 7490 pass / 0 fail.
+
+### Changed (SDK 0.21.21)
+- Upgraded `@pellux/goodvibes-sdk` to 0.21.21. Picks up `rerootStores(newWorkingDir: string): Promise<void>` on `RuntimeServices` (workspace swap support), `WorkspaceEvent` domain in `AnyRuntimeEvent` and `DomainEventMap`, F3 companion token `daemonHomeDir` option for global (non-workspace-scoped) token storage at `~/.goodvibes/daemon/operator-tokens.json`, and state tool well-known keys `runtime.workingDir` / `daemon.homeDir`.
+- F3: `getOrCreateCompanionToken` / `regenerateCompanionToken` calls in `src/daemon/cli.ts` and `src/panels/builtin/session.ts` now pass `daemonHomeDir: join(homeDirectory, '.goodvibes', 'daemon')` to use the new global token path (was workspace-scoped).
+- Implemented `rerootStores` in `src/runtime/services.ts`: delegates to `memoryStore.reroot(newMemoryDbPath)` and `projectIndex.reroot(newWorkingDir)` so `WorkspaceSwapManager` can migrate path-bound stores on workspace swap without a process restart.
+
+### Fixed
+- `EventEnvelope` cast in `policy-and-budget-evidence-gate.test.ts`, `runtime-certification-gate.test.ts`, and `forensics.test.ts`: SDK 0.21.21 added `WorkspaceEvent` to `AnyRuntimeEvent`, widening `Parameters<RuntimeEventBus['emit']>[1]` beyond what the domain-specific `emit('turn', ...)` overload accepts. Fixed by casting through `createEventEnvelope(payload['type'] as TurnEvent['type'], payload as TurnEvent, ...)` (and `TaskEvent` for `emitTask`), which produces a precisely-typed envelope without `as unknown as`.
+- `method-catalog.test.ts`: comment updated — `buildOperatorContract` regression (`void catalog;` at operator-contract.js:119) is still present in 0.21.21; loosened assertion remains.
+- Foundation artifacts: `docs/foundation-artifacts/operator-contract.json` regenerated via `bun run foundation:artifacts` to reflect SDK 0.21.21 operator contract.
+
+### Changed
+- Upgraded `@pellux/goodvibes-sdk` to 0.21.20. Picks up `swapManager: WorkspaceSwapManagerLike | null` field in `DaemonSystemRouteContext`; test mocks updated accordingly.
+- `build:daemon:*` convenience scripts in `package.json` now delegate to `scripts/build.ts` (with `--target daemon-<platform>` aliases) so daemon-only builds include `--external sqlite-vec` flags and native addon copy. Previously these scripts bypassed the build script and omitted externalization.
+- Added `--daemon-home=<path>` and `--working-dir=<path>` CLI flags to `src/cli-flags.ts` and `src/daemon/cli.ts`. Flags set `GOODVIBES_DAEMON_HOME` and `GOODVIBES_WORKING_DIR` env vars before directory resolution, enabling per-launch home and workspace overrides without env var pre-flight.
+- Added `smoke:daemon` script (`scripts/post-build-smoke.ts`) that spawns the linux-x64 daemon binary, polls `/api/health`, curls `/api/memory/vector`, and asserts no sqlite-vec error in the response or stderr. Exits 0/1. Wired into `.github/workflows/release.yml` after the linux-x64 binary build step.
+
+### Fixed
+- **smoke** — `scripts/post-build-smoke.ts` port contract corrected: ConfigManager reads port from `homeDir/.goodvibes/tui/settings.json` (not `GOODVIBES_CONTROL_PLANE_PORT` env var). Smoke test now writes a tmp settings.json with port 47921 and passes `GOODVIBES_DAEMON_HOME` to the daemon process. Health check readiness tightened to `status === 200 || status === 401` (drops loose `< 500`).
+- **M-3** — `src/cli-flags.ts` `--help` text now documents flag precedence explicitly: `flag > env var > system default`.
+- **M-4** — `.github/workflows/release.yml` inline build step replaced with `bun run scripts/build.ts --target ${{ matrix.target }}` to eliminate ~35-line duplication with `scripts/build.ts`. Redundant darwin case block in the shell `case` statement removed.
+- **M-5 (scope)** — `README.md` version badge updated to 0.19.10 to match `package.json`. `docs/foundation-artifacts/operator-contract.json` regenerated as a side-effect of SDK 0.21.20 bump (no TUI logic change).
+- **M-5 (qr)** — `src/renderer/qr-renderer.ts`: top quiet band changed from a full-height space row to a half-height lower-block row (`▄` with fg = QR background, no bg override). Saves one terminal row of vertical space without disturbing finder-pattern alignment.
+- **C-3** — Added `src/test/cli-flags.test.ts` with 9 tests covering `--daemon-home`, `--working-dir`, precedence semantics, combined parsing, help text content, and existing flag regression.
+- **W-x (test)** — `standalone-routes.test.ts`: corrected 4 test assertions that used wrong API shapes (`GET /api/companion/chat/sessions` list route does not exist; `POST` returns `{sessionId, createdAt}` not `{id}`; `GET /api/providers/current` returns `{model, configured}` not `{currentModel, provider}`; replaced non-existent `GET /api/sessions/:id/events` with verified `GET /api/sessions`). Replaced WebSocket control-plane test with correct HTTP `GET /api/control-plane` (the route is HTTP, not WS).
+- **W-x (types)** — `daemon-route-seams.test.ts`: added `swapManager: null` to `DaemonSystemRouteContext` mock to satisfy SDK 0.21.20 type addition.
+- **Foundation artifacts gate** — regenerated `docs/foundation-artifacts/operator-contract.json` after SDK bump (was pinned to 0.21.16).
+
+---
+
+<!-- Prior [UNRELEASED] content from SDK 0.21.18 cycle merged below -->
+
+### Changed (SDK 0.21.18)
+- Upgraded `@pellux/goodvibes-sdk` to 0.21.18. Picks up `DaemonApiRouteExtension` type on `dispatchDaemonApiRoutes`; `providers` and `turn` are confirmed in `DEFAULT_DOMAINS` for all daemon postures.
+
+### Fixed
+- **F2** — Standalone daemon (`goodvibes-daemon-*`) now loads persisted providers from disk at startup via `loadPersistedProviders()` and registers them with `ProviderRegistry`. A background LAN scan runs on startup and merges discovered servers into the registry. Provider count on a fresh standalone daemon is now non-zero when providers have been previously discovered.
+- **F5** — Both TUI and daemon binaries are now compiled with `--external sqlite-vec --external sqlite-vec-<platform>` so the native addon is not embedded (Bun compile cannot embed `.so`/`.dylib`). The native addon is copied to `dist/lib/<platform-package>/` alongside the binary. GitHub release workflow updated to include `dist/lib/` in uploaded artifacts.
+- **F11** — Documented that `.goodvibes/memory/` is workspace-scoped and only created when `runtime_state` tool is invoked in `mode: memory` during an orchestrator session. Not a bug for TUI-only workspaces.
+- **F12** — Documented that `DELETE /api/companion/chat/sessions/:id` is an audit-friendly soft-close returning `{status:"closed"}`; session record remains readable. This is intentional SDK behavior, not a bug.
+- **F13** — Documented that companion-chat messages use `{content}` (not `{body}`) because `CompanionChatMessage` is a pure-text interface distinct from `SharedSessionMessage`. Both field names are intentional and reflect different message schemas.
+- **F14** — Confirmed `providers` and `turn` are in `DEFAULT_DOMAINS` at SDK level for both daemon postures. UAT Run 2 discrepancy traced to explicit `?domains=` query param in test client, not a bug in the daemon.
+- **F15** — Documented that `CompanionChatRateLimiter` is wired correctly (10/min per session, 30/min per client by default). Rate limit is not reachable via sequential HTTP due to test RTT. Concurrent `Promise.all` approach documented in UAT-VALIDATION.md. SDK gap for env-based threshold override tracked in decisions.md.
+
 ## [0.19.10] - 2026-04-19
 
 ### Changed

package/README.md

@@ -2,7 +2,7 @@
 
 [![CI](https://github.com/mgd34msu/goodvibes-tui/actions/workflows/ci.yml/badge.svg)](https://github.com/mgd34msu/goodvibes-tui/actions/workflows/ci.yml)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
-[![Version](https://img.shields.io/badge/version-0.19.10-blue.svg)](https://github.com/mgd34msu/goodvibes-tui)
+[![Version](https://img.shields.io/badge/version-0.19.13-blue.svg)](https://github.com/mgd34msu/goodvibes-tui)
 
 A terminal-native AI coding, operations, automation, knowledge, and integration console with a typed runtime, omnichannel surfaces, structured memory/knowledge, and a raw ANSI renderer.