@pellux/goodvibes-tui 0.19.1 → 0.19.3

package/CHANGELOG.md

@@ -4,6 +4,33 @@ All notable changes to GoodVibes TUI.
 
 ---
 
+## [0.19.3] - 2026-04-18
+
+### Fixed
+- Extracted CLI flag parsing (`--provider`, `--model`) from `src/main.ts` and `src/daemon/cli.ts` into a shared `src/cli-flags.ts` module. `src/main.ts` now passes the 800-line architecture-check gate that was tripped in 0.19.1 and 0.19.2 (CI failures on both prior releases).
+
+### Changed
+- No user-visible behavior change. Pure structural refactor.
+
+### Note
+- `v0.19.1` and `v0.19.2` GitHub releases have 0 binary assets due to the architecture-check CI failure. Consumers should upgrade to `0.19.3` for access to the binaries + consistent release state.
+
+---
+
+## [0.19.2] — 2026-04-18
+
+### Fixed
+- Daemon test: `channel account APIs expose surface auth and secret posture` — corrected
+  `GET /api/providers` assertions from legacy `providerId` field to current `id` field
+  (SDK 0.21.x provider-routes.ts renamed the field). The subscription-oauth auth routes
+  assertion was dropped from the list endpoint (it only exists on per-provider snapshots).
+- Model picker now correctly surfaces `configuredVia='secrets'` tier as `[key]` badge
+  (previously all secrets-manager-keyed providers were collapsed to `[env]`). Secrets are
+  pre-resolved async before the picker renders; `secretsManager` is now threaded from
+  `RuntimeServices` through `wireShellUiOpeners`.
+
+---
+
 ## [0.19.1] — 2026-04-17
 
 ### Changed

package/README.md

@@ -2,7 +2,7 @@
 
 [![CI](https://github.com/mgd34msu/goodvibes-tui/actions/workflows/ci.yml/badge.svg)](https://github.com/mgd34msu/goodvibes-tui/actions/workflows/ci.yml)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
-[![Version](https://img.shields.io/badge/version-0.19.1-blue.svg)](https://github.com/mgd34msu/goodvibes-tui)
+[![Version](https://img.shields.io/badge/version-0.19.3-blue.svg)](https://github.com/mgd34msu/goodvibes-tui)
 
 A terminal-native AI coding, operations, automation, knowledge, and integration console with a typed runtime, omnichannel surfaces, structured memory/knowledge, and a raw ANSI renderer.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pellux/goodvibes-tui",
-  "version": "0.19.1",
+  "version": "0.19.3",
   "description": "Terminal-native GoodVibes product for coding, operations, automation, knowledge, channels, and daemon-backed control-plane workflows.",
   "type": "module",
   "main": "src/main.ts",

package/src/cli-flags.ts

@@ -0,0 +1,48 @@
+// ---------------------------------------------------------------------------
+// Shared CLI flag parsing for TUI shell and daemon entrypoints.
+// ---------------------------------------------------------------------------
+
+export type CliFlags = {
+  readonly provider: string | undefined;
+  readonly model: string | undefined;
+};
+
+/**
+ * Parse `--provider` / `--model` / `--help` flags from an argv slice.
+ *
+ * @param argv   - argv array (pass `process.argv.slice(2)`)
+ * @param binary - binary name shown in the --help usage line (e.g. "goodvibes" or "goodvibes-daemon")
+ */
+export function parseCliFlags(argv: readonly string[], binary = 'goodvibes'): CliFlags {
+  let provider: string | undefined;
+  let model: string | undefined;
+
+  for (let i = 0; i < argv.length; i++) {
+    const arg = argv[i];
+    if (arg === '--help' || arg === '-h') {
+      // eslint-disable-next-line no-console
+      console.log([
+        `Usage: ${binary} [options]`,
+        '',
+        'Options:',
+        '  --provider <id>          Override the provider from settings.json at startup',
+        '  --model <registryKey>    Override the model from settings.json at startup',
+        '                           Format: provider:modelId (e.g. inception:mercury-2)',
+        '                           If provider:modelId format is used, --provider is inferred',
+        '  --help, -h               Show this help message',
+      ].join('\n'));
+      process.exit(0);
+    }
+    if (arg === '--provider' && argv[i + 1] !== undefined) {
+      provider = argv[++i];
+    } else if (arg === '--model' && argv[i + 1] !== undefined) {
+      model = argv[++i];
+      // Infer provider from registryKey format (provider:modelId) if --provider not given
+      if (typeof model === 'string' && model.includes(':') && provider === undefined) {
+        provider = model.split(':')[0];
+      }
+    }
+  }
+
+  return { provider, model };
+}

package/src/daemon/cli.ts

@@ -17,53 +17,13 @@ import {
 } from '@pellux/goodvibes-sdk/platform/pairing/index';
 import { generateQrMatrix, renderQrToString } from '@pellux/goodvibes-sdk/platform/pairing/qr-generator';
 
+import { parseCliFlags } from '../cli-flags.ts';
 type DaemonCliOwnership = {
   readonly workingDirectory: string;
   readonly homeDirectory: string;
 };
 
-// ---------------------------------------------------------------------------
-// CLI flag parsing
-// ---------------------------------------------------------------------------
-
-type DaemonCliFlags = {
-  readonly provider: string | undefined;
-  readonly model: string | undefined;
-};
-
-function parseDaemonCliFlags(argv: readonly string[]): DaemonCliFlags {
-  let provider: string | undefined;
-  let model: string | undefined;
-
-  for (let i = 0; i < argv.length; i++) {
-    const arg = argv[i];
-    if (arg === '--help' || arg === '-h') {
-      // eslint-disable-next-line no-console
-      console.log([
-        'Usage: goodvibes-daemon [options]',
-        '',
-        'Options:',
-        '  --provider <id>          Override the provider from settings.json at startup',
-        '  --model <registryKey>    Override the model from settings.json at startup',
-        '                           Format: provider:modelId (e.g. inception:mercury-2)',
-        '                           If provider:modelId format is used, --provider is inferred',
-        '  --help, -h               Show this help message',
-      ].join('\n'));
-      process.exit(0);
-    }
-    if (arg === '--provider' && argv[i + 1] !== undefined) {
-      provider = argv[++i];
-    } else if (arg === '--model' && argv[i + 1] !== undefined) {
-      model = argv[++i];
-      // Infer provider from registryKey format (provider:modelId) if --provider not given
-      if (typeof model === 'string' && model.includes(':') && provider === undefined) {
-        provider = model.split(':')[0];
-      }
-    }
-  }
-
-  return { provider, model };
-}
+// CLI flag parsing delegated to shared module — see src/cli-flags.ts
 
 type DaemonCliTokens = {
   readonly daemonToken: string | undefined;
@@ -117,7 +77,7 @@ async function main(): Promise<void> {
   new GlobalNetworkTransportInstaller().install(config);
 
   // Apply CLI flags — override settings.json before the provider registry is constructed
-  const cliFlags = parseDaemonCliFlags(process.argv.slice(2));
+  const cliFlags = parseCliFlags(process.argv.slice(2), 'goodvibes-daemon');
   if (cliFlags.provider !== undefined) {
     config.set('provider.provider', cliFlags.provider);
     logger.info('daemon: --provider flag applied', { provider: cliFlags.provider });

package/src/main.ts

@@ -1,6 +1,4 @@
 #!/usr/bin/env bun
-// Main shell entrypoint. Composition-heavy startup remains here, with
-// lower-level session/bootstrap/input helpers extracted into focused modules.
 import { homedir } from 'node:os';
 import { join } from 'node:path';
 import { Compositor } from './renderer/compositor.ts';
@@ -54,7 +52,7 @@ import { deriveComposerState } from './core/composer-state.ts';
 import { buildPersistedSessionContext, formatReturnContextForDisplay, getReturnContextMode, maybeAssistReturnContextSummary } from '@pellux/goodvibes-sdk/platform/runtime/session-return-context';
 import { GlobalNetworkTransportInstaller } from '@pellux/goodvibes-sdk/platform/runtime/network/index';
 import { summarizeError } from '@pellux/goodvibes-sdk/platform/utils/error-display';
-
+import { parseCliFlags } from './cli-flags.ts';
 
 const ALT_SCREEN_ENTER = '\x1b[?1049h';
 const ALT_SCREEN_EXIT  = '\x1b[?1049l';
@@ -80,49 +78,6 @@ function resolveShellEntrypointOwnership(): ShellEntrypointOwnership {
   };
 }
 
-// ---------------------------------------------------------------------------
-// CLI flag parsing (TUI shell entry point)
-// ---------------------------------------------------------------------------
-
-type TuiCliFlags = {
-  readonly provider: string | undefined;
-  readonly model: string | undefined;
-};
-
-function parseTuiCliFlags(argv: readonly string[]): TuiCliFlags {
-  let provider: string | undefined;
-  let model: string | undefined;
-
-  for (let i = 0; i < argv.length; i++) {
-    const arg = argv[i];
-    if (arg === '--help' || arg === '-h') {
-      // eslint-disable-next-line no-console
-      console.log([
-        'Usage: goodvibes [options]',
-        '',
-        'Options:',
-        '  --provider <id>          Override the provider from settings.json at startup',
-        '  --model <registryKey>    Override the model from settings.json at startup',
-        '                           Format: provider:modelId (e.g. inception:mercury-2)',
-        '                           If provider:modelId format is used, --provider is inferred',
-        '  --help, -h               Show this help message',
-      ].join('\n'));
-      process.exit(0);
-    }
-    if (arg === '--provider' && argv[i + 1] !== undefined) {
-      provider = argv[++i];
-    } else if (arg === '--model' && argv[i + 1] !== undefined) {
-      model = argv[++i];
-      // Infer provider from registryKey format (provider:modelId) if --provider not given
-      if (typeof model === 'string' && model.includes(':') && provider === undefined) {
-        provider = model.split(':')[0];
-      }
-    }
-  }
-
-  return { provider, model };
-}
-
 async function main() {
   const stdout = process.stdout;
   const stdin = process.stdin;
@@ -139,7 +94,7 @@ async function main() {
   new GlobalNetworkTransportInstaller().install(configManager);
 
   // Apply CLI flags — override settings.json before the provider registry is constructed
-  const cliFlags = parseTuiCliFlags(process.argv.slice(2));
+  const cliFlags = parseCliFlags(process.argv.slice(2), 'goodvibes');
   if (cliFlags.provider !== undefined) {
     configManager.set('provider.provider', cliFlags.provider);
   }
@@ -147,10 +102,7 @@ async function main() {
     configManager.set('provider.model', cliFlags.model);
   }
 
-  // ── Bootstrap all runtime subsystems ─────────────────────────────────────
-  // bootstrapRuntime initializes all subsystems in dependency order and returns
-  // a fully-wired BootstrapContext. main.ts owns terminal setup, the render loop,
-  // stdin input, and signal handlers — everything else is in bootstrap.
+  // ── Bootstrap runtime subsystems via bootstrapRuntime.
   const ctx: BootstrapContext = await bootstrapRuntime(stdout, {
     configManager,
     workingDir: bootstrapWorkingDir,
@@ -180,7 +132,7 @@ async function main() {
   } = ctx;
   const workingDir = ctx.services.workingDirectory;
   const homeDirectory = ctx.services.homeDirectory;
-  const { approvalBroker, agentManager, modeManager, processManager, providerRegistry } = ctx.services;
+  const { approvalBroker, agentManager, modeManager, processManager, providerRegistry, secretsManager, subscriptionManager } = ctx.services;
   conversation.setSessionMemoryStore(ctx.services.sessionMemoryStore);
   conversation.setSessionLineageTracker(ctx.services.sessionLineageTracker);
   orchestrator.setCoreServices({
@@ -433,9 +385,6 @@ async function main() {
     });
 
   // ── InputHandler — created here so getViewportHeight can reference it ──────
-  // orchestratorRefs.getViewportHeight and .scrollToEnd are patched immediately after.
-
-  // ── InputHandler ────────────────────────────────────────────────────────
   const input: InputHandler = new InputHandler(
     () => render(),
     selection,
@@ -502,7 +451,6 @@ async function main() {
     toolCount,
   };
 
-  // Sessions start fresh — use /session resume to load a previous session
 
   // --- Render function ---
   const render = () => {
@@ -514,7 +462,6 @@ async function main() {
     const sessionSnapshot = uiServices.readModels.session.getSnapshot();
     const agentSnapshot = uiServices.readModels.agents.getSnapshot();
 
-
     // Build header and footer FIRST so we know the exact viewport height
     const headerLines = UIFactory.createHeader(width, currentModel.id, currentModel.provider, conversation.title || undefined, lastGitInfoRef.value);
     const managerAgents = agentManager.list().filter(
@@ -735,7 +682,8 @@ async function main() {
     runtime,
     featureFlags: ctx.featureFlags,
     mcpRegistry: ctx.services.mcpRegistry,
-    subscriptionManager: ctx.services.subscriptionManager,
+    subscriptionManager,
+    secretsManager,
     serviceRegistry: ctx.services.serviceRegistry,
     getConfiguredProviderIds: ctx._getConfiguredProviderIds,
     getPinned: ctx._getPinned,
@@ -743,6 +691,7 @@ async function main() {
   });
 
   // --- Streaming speed + tool preview wiring ---
+  const refreshGit = () => gitStatusProvider.refresh().then((info) => { lastGitInfoRef.value = info; render(); }).catch(() => { /* non-fatal */ });
   // Refresh git status after each turn completes or after tool results arrive
   unsubs.push(uiServices.events.turns.on('TURN_COMPLETED', () => {
     // Auto-save after every LLM turn so kills don't lose the session
@@ -759,22 +708,13 @@ async function main() {
       );
       hookDispatcher.fire({ path: 'Lifecycle:session:save' as HookEventPath, phase: 'Lifecycle' as HookPhase, category: 'session' as HookCategory, specific: 'save', sessionId: runtime.sessionId, timestamp: Date.now(), payload: { sessionId: runtime.sessionId } }).catch((err: unknown) => logger.debug('hook fire error', { error: summarizeError(err) }));
     } catch (e) { logger.debug('auto-save on turn:complete failed', { error: summarizeError(e) }); }
-    gitStatusProvider.refresh().then((info) => {
-      lastGitInfoRef.value = info;
-      render();
-    }).catch(() => { /* non-fatal */ });
+    refreshGit();
   }));
   unsubs.push(uiServices.events.tools.on('TOOL_SUCCEEDED', () => {
-    gitStatusProvider.refresh().then((info) => {
-      lastGitInfoRef.value = info;
-      render();
-    }).catch(() => { /* non-fatal */ });
+    refreshGit();
   }));
   unsubs.push(uiServices.events.tools.on('TOOL_FAILED', () => {
-    gitStatusProvider.refresh().then((info) => {
-      lastGitInfoRef.value = info;
-      render();
-    }).catch(() => { /* non-fatal */ });
+    refreshGit();
   }));
 
   unsubs.push(uiServices.events.turns.on('STREAM_START', () => {

package/src/shell/ui-openers.ts

@@ -8,6 +8,7 @@ import type { MutableRuntimeState } from '@pellux/goodvibes-sdk/platform/runtime
 import type { FeatureFlagManager } from '@pellux/goodvibes-sdk/platform/runtime/feature-flags/index';
 import type { McpRegistry } from '@pellux/goodvibes-sdk/platform/mcp/registry';
 import type { SubscriptionManager } from '@pellux/goodvibes-sdk/platform/config/subscriptions';
+import type { SecretsManager } from '@pellux/goodvibes-sdk/platform/config/secrets';
 import type { ServiceInspectionQuery } from '../runtime/ui-service-queries.ts';
 
 type WireShellUiOpenersOptions = {
@@ -21,6 +22,7 @@ type WireShellUiOpenersOptions = {
   featureFlags: FeatureFlagManager;
   mcpRegistry: McpRegistry;
   subscriptionManager: SubscriptionManager;
+  secretsManager?: Pick<SecretsManager, 'get'>;
   serviceRegistry: Pick<ServiceInspectionQuery, 'getAll'>;
   getConfiguredProviderIds: () => string[];
   getPinned: () => Promise<string[]>;
@@ -29,35 +31,43 @@ type WireShellUiOpenersOptions = {
 
 /**
  * Derive the configuredVia tier for a provider.
- * Checks env-vars first (env tier), then falls back to subscription (from configuredIds
- * that aren't env-keyed). Returns undefined when not configured.
+ * Tier order mirrors SDK provider-routes.ts: env → secrets → subscription → undefined.
+ * The preResolvedSecretKeys set is pre-fetched async before the sync picker render cycle.
  */
 function deriveConfiguredVia(
   providerId: string,
   configuredIds: Set<string>,
   subscriptionManager: SubscriptionManager,
+  preResolvedSecretKeys?: ReadonlySet<string>,
 ): 'env' | 'secrets' | 'subscription' | 'anonymous' | undefined {
   if (!configuredIds.has(providerId)) return undefined;
 
-  // Check if a subscription session is active for this provider
+  // Tier 1: subscription check (most specific — subscription overrides env for this provider)
   const subs = subscriptionManager.list();
   if (subs.some((s) => s.provider === providerId)) return 'subscription';
 
-  // Assume env-var backed (anonymous providers don't appear in configuredIds)
+  // Tier 2: env-var present (process.env check; anonymous providers don't appear in configuredIds)
+  // We don't have BUILTIN_PROVIDER_ENV_KEYS here; if env was used the configuredIds path covers it.
+  // The presence in configuredIds and no subscription → either env or secrets.
+  // Tier 3: secrets-manager backed (pre-resolved async batch)
+  if (preResolvedSecretKeys && preResolvedSecretKeys.has(providerId)) return 'secrets';
+
   return 'env';
 }
 
 /**
  * Build a configuredViaMap for the given provider list.
+ * Pass preResolvedSecretKeys (from an async SecretsManager batch) to surface the 'secrets' tier.
  */
 function buildConfiguredViaMap(
   providers: string[],
   configuredIds: Set<string>,
   subscriptionManager: SubscriptionManager,
+  preResolvedSecretKeys?: ReadonlySet<string>,
 ): Map<string, 'env' | 'secrets' | 'subscription' | 'anonymous'> {
   const map = new Map<string, 'env' | 'secrets' | 'subscription' | 'anonymous'>();
   for (const p of providers) {
-    const via = deriveConfiguredVia(p, configuredIds, subscriptionManager);
+    const via = deriveConfiguredVia(p, configuredIds, subscriptionManager, preResolvedSecretKeys);
     if (via !== undefined) map.set(p, via);
   }
   return map;
@@ -75,35 +85,61 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
     featureFlags,
     mcpRegistry,
     subscriptionManager,
+    secretsManager,
     serviceRegistry,
     getConfiguredProviderIds,
     getPinned,
     render,
   } = options;
 
-  commandContext.openModelPicker = () => {
-    const models = providerRegistry.getSelectableModels();
+  /**
+   * Pre-resolve which provider IDs have secrets-manager keys (async batch, SDK tier pattern).
+   * Returns a set of provider IDs (not env var names) that are secrets-backed.
+   * Falls back to empty set if secretsManager is not provided.
+   */
+  async function resolveSecretProviderIds(): Promise<ReadonlySet<string>> {
+    if (!secretsManager) return new Set<string>();
     const configuredIds = new Set(getConfiguredProviderIds());
-    input.modelPicker.configuredProviders = configuredIds;
-    const providerIds = [...new Set(models.map((m) => m.provider))];
-    input.modelPicker.configuredViaMap = buildConfiguredViaMap(providerIds, configuredIds, subscriptionManager);
-    void getPinned().then((pinned) => {
-      input.modelPicker.pinnedIds = new Set(pinned);
-    });
-    void input.modelPicker.loadRecentModels().catch(() => {}); // best-effort: prefetch for UI, failure is non-visible
-    input.modalOpened('modelPicker');
-    input.modelPicker.openAllModels(models, runtime.model);
-    render();
+    // For each configured provider, check if secretsManager has a key for it by provider ID.
+    // We use provider ID as the lookup key since we don't have BUILTIN_PROVIDER_ENV_KEYS here.
+    const results = await Promise.all(
+      [...configuredIds].map(async (providerId) => {
+        const val = await secretsManager.get(providerId).catch(() => null);
+        return val !== null ? providerId : null;
+      }),
+    );
+    return new Set(results.filter((v): v is string => v !== null));
+  }
+
+  commandContext.openModelPicker = () => {
+    void (async () => {
+      const models = providerRegistry.getSelectableModels();
+      const configuredIds = new Set(getConfiguredProviderIds());
+      input.modelPicker.configuredProviders = configuredIds;
+      const providerIds = [...new Set(models.map((m) => m.provider))];
+      const secretProviderIds = await resolveSecretProviderIds();
+      input.modelPicker.configuredViaMap = buildConfiguredViaMap(providerIds, configuredIds, subscriptionManager, secretProviderIds);
+      void getPinned().then((pinned) => {
+        input.modelPicker.pinnedIds = new Set(pinned);
+      });
+      void input.modelPicker.loadRecentModels().catch(() => {}); // best-effort: prefetch for UI, failure is non-visible
+      input.modalOpened('modelPicker');
+      input.modelPicker.openAllModels(models, runtime.model);
+      render();
+    })();
   };
 
   commandContext.openProviderPicker = () => {
-    const providers = [...new Set(providerRegistry.listModels().map((model) => model.provider))];
-    const configuredIds = new Set(getConfiguredProviderIds());
-    input.modelPicker.configuredProviders = configuredIds;
-    input.modelPicker.configuredViaMap = buildConfiguredViaMap(providers, configuredIds, subscriptionManager);
-    input.modalOpened('modelPicker');
-    input.modelPicker.openProviders(providers, runtime.provider);
-    render();
+    void (async () => {
+      const providers = [...new Set(providerRegistry.listModels().map((model) => model.provider))];
+      const configuredIds = new Set(getConfiguredProviderIds());
+      input.modelPicker.configuredProviders = configuredIds;
+      const secretProviderIds = await resolveSecretProviderIds();
+      input.modelPicker.configuredViaMap = buildConfiguredViaMap(providers, configuredIds, subscriptionManager, secretProviderIds);
+      input.modalOpened('modelPicker');
+      input.modelPicker.openProviders(providers, runtime.provider);
+      render();
+    })();
   };
 
   commandContext.openSelection = (title, items, opts, callback) => {

package/src/version.ts

@@ -6,7 +6,7 @@ import { join } from 'node:path';
 // The prebuild script updates the fallback value before compilation.
 // Uses import.meta.dir (Bun) to locate package.json relative to this file,
 // which is correct regardless of the process working directory.
-let _version = '0.19.1';
+let _version = '0.19.3';
 try {
   const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8'));
   _version = pkg.version ?? _version;