@pellux/goodvibes-tui 0.18.23 → 0.19.1

package/src/renderer/status-glyphs.ts

@@ -0,0 +1,21 @@
+// ---------------------------------------------------------------------------
+// status-glyphs.ts — canonical glyph map for status states.
+//
+// Extracted as a neutral module so both status-token.ts and polish.ts can
+// import from here without creating a circular ESM dependency.
+//
+// Glyphs:
+//   good  ✓  (CHECK MARK U+2713)
+//   warn  ⚠  (WARNING SIGN U+26A0)
+//   bad   ✕  (MULTIPLICATION X U+2715)
+//   info  ○  (WHITE CIRCLE U+25CB)
+// ---------------------------------------------------------------------------
+
+export type StatusState = 'good' | 'warn' | 'bad' | 'info';
+
+export const STATE_GLYPHS: Record<StatusState, string> = {
+  good: '\u2713', // ✓
+  warn: '\u26a0', // ⚠
+  bad:  '\u2715', // ✕
+  info: '\u25cb', // ○
+};

package/src/renderer/status-token.ts

@@ -13,15 +13,11 @@
 
 import type { Cell } from '../types/grid.ts';
 import { DEFAULT_PANEL_PALETTE } from '../panels/polish.ts';
+import { type StatusState, STATE_GLYPHS } from './status-glyphs.ts';
 
-export type StatusState = 'good' | 'warn' | 'bad' | 'info';
-
-const STATE_GLYPHS: Record<StatusState, string> = {
-  good: '\u2713', // ✓
-  warn: '\u26a0', // ⚠
-  bad:  '\u2715', // ✕
-  info: '\u25cb', // ○
-};
+// Re-export for downstream consumers that import from this module.
+export type { StatusState } from './status-glyphs.ts';
+export { STATE_GLYPHS } from './status-glyphs.ts';
 
 const STATE_COLORS: Record<StatusState, string> = {
   good: DEFAULT_PANEL_PALETTE.good,

package/src/renderer/tool-call.ts

@@ -2,6 +2,7 @@ import { type Line, createStyledCell, createEmptyLine } from '../types/grid.ts';
 import { LAYOUT, TOOL_STATUS } from './layout.ts';
 import { getDisplayWidth, truncateDisplay } from '../utils/terminal-width.ts';
 import type { ToolCall } from '@pellux/goodvibes-sdk/platform/types/tools';
+import { stripDangerousAnsi } from './ansi-sanitize.ts';
 
 const TOOL_NAME_MIN_WIDTH = 8;
 const TOOL_NAME_MAX_WIDTH = 20;
@@ -194,11 +195,11 @@ export function renderToolCallBlock(
   const rawName = toolCall.name.includes('__')
     ? toolCall.name.split('__').pop()!
     : toolCall.name;
-  const keyArg = extractKeyArg(toolCall);
+  const keyArg = stripDangerousAnsi(extractKeyArg(toolCall));
   const suffixText = status === 'error' && errorMsg
-    ? `- ${errorMsg.slice(0, 40)}`
+    ? `- ${stripDangerousAnsi(errorMsg).slice(0, 40)}`
     : status === 'done' && resultSummary
-      ? `(${resultSummary})`
+      ? `(${stripDangerousAnsi(resultSummary)})`
       : '';
   const leftBudget = Math.max(0, leftEndExclusive - col);
   const leftSegments = buildLeftSegments(rawName, keyArg, suffixText, leftBudget);

package/src/runtime/bootstrap-core.ts

@@ -362,7 +362,7 @@ export async function initializeBootstrapCore(
       displayName: 'Terminal UI',
       lastSeenAt: Date.now(),
     },
-  }).catch(() => {});
+  }).catch((err) => { logger.debug('session broker create session failed at bootstrap', { err }); });
 
   domainDispatch.syncSessionState({
     id: userSessionId,

package/src/runtime/bootstrap-hook-bridge.ts

@@ -51,7 +51,7 @@ export function createResumeSessionHandler(options: ResumeSessionOptions): (sess
       if (meta?.model) options.runtime.model = meta.model;
       if (meta?.provider) options.runtime.provider = meta.provider;
       options.writeLastSessionPointer(sessionId);
-      void options.sharedSessionBroker.reopenSession(sessionId).catch(() => {});
+      void options.sharedSessionBroker.reopenSession(sessionId).catch((err) => { logger.debug('session broker reopen session failed', { err }); });
       options.conversation.log(`Resumed session: ${sessionId}`, { fg: '135' });
       const reopenedPanels: string[] = [];
       if (meta.returnContext?.openPanels?.length) {

package/src/runtime/bootstrap.ts

@@ -177,13 +177,13 @@ export async function bootstrapRuntime(
     requestRender: (): void => { requestRender(); },
   };
 
-  const orchestrator = new Orchestrator(
+  const orchestrator = new Orchestrator({
     conversation,
-    () => orchestratorRefs.getViewportHeight(),
-    (vHeight: number) => orchestratorRefs.scrollToEnd(vHeight),
+    getViewportHeight: () => orchestratorRefs.getViewportHeight(),
+    scrollToEnd: (vHeight: number) => orchestratorRefs.scrollToEnd(vHeight),
     toolRegistry,
     permissionManager,
-    () => {
+    getSystemPrompt: () => {
       const currentModel = providerRegistry.getCurrentModel();
       const contextWindow = providerRegistry.getContextWindowForModel(currentModel);
       const tier = getTierForContextWindow(contextWindow);
@@ -191,14 +191,13 @@ export async function bootstrapRuntime(
       return supplement ? runtime.systemPrompt + '\n\n' + supplement : runtime.systemPrompt;
     },
     hookDispatcher,
-    null,
-    () => orchestratorRefs.requestRender(),
+    requestRender: () => orchestratorRefs.requestRender(),
     runtimeBus,
-    {
+    services: {
       agentManager: services.agentManager,
       wrfcController: services.wrfcController,
     },
-  );
+  });
   conversationFollowUpRef.value = (item) => orchestrator.enqueueConversationFollowUp(item);
   orchestrator.setCoreServices({
     configManager,

package/src/runtime/diagnostics/panels/policy.ts

@@ -19,6 +19,7 @@ import type { PermissionAuditEntry } from '@pellux/goodvibes-sdk/platform/runtim
 import type { PolicyLintFinding } from '@pellux/goodvibes-sdk/platform/runtime/permissions/lint';
 import type { PolicySimulationSummary } from '@pellux/goodvibes-sdk/platform/runtime/permissions/simulation-scenarios';
 import type { PolicyPreflightReview } from '@pellux/goodvibes-sdk/platform/runtime/permissions/preflight';
+import { logger } from '@pellux/goodvibes-sdk/platform/utils/logger';
 
 /**
  * A point-in-time snapshot of policy state for diagnostics rendering.
@@ -169,7 +170,7 @@ export class PolicyPanel {
       try {
         cb();
       } catch (err) {
-        console.debug('[PolicyPanel] subscriber error:', err);
+        logger.warn(`[PolicyPanel] subscriber error: ${err}`);
       }
     }
   }

package/src/shell/ui-openers.ts

@@ -27,6 +27,42 @@ type WireShellUiOpenersOptions = {
   render: () => void;
 };
 
+/**
+ * Derive the configuredVia tier for a provider.
+ * Checks env-vars first (env tier), then falls back to subscription (from configuredIds
+ * that aren't env-keyed). Returns undefined when not configured.
+ */
+function deriveConfiguredVia(
+  providerId: string,
+  configuredIds: Set<string>,
+  subscriptionManager: SubscriptionManager,
+): 'env' | 'secrets' | 'subscription' | 'anonymous' | undefined {
+  if (!configuredIds.has(providerId)) return undefined;
+
+  // Check if a subscription session is active for this provider
+  const subs = subscriptionManager.list();
+  if (subs.some((s) => s.provider === providerId)) return 'subscription';
+
+  // Assume env-var backed (anonymous providers don't appear in configuredIds)
+  return 'env';
+}
+
+/**
+ * Build a configuredViaMap for the given provider list.
+ */
+function buildConfiguredViaMap(
+  providers: string[],
+  configuredIds: Set<string>,
+  subscriptionManager: SubscriptionManager,
+): Map<string, 'env' | 'secrets' | 'subscription' | 'anonymous'> {
+  const map = new Map<string, 'env' | 'secrets' | 'subscription' | 'anonymous'>();
+  for (const p of providers) {
+    const via = deriveConfiguredVia(p, configuredIds, subscriptionManager);
+    if (via !== undefined) map.set(p, via);
+  }
+  return map;
+}
+
 export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
   const {
     commandContext,
@@ -47,11 +83,14 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
 
   commandContext.openModelPicker = () => {
     const models = providerRegistry.getSelectableModels();
-    input.modelPicker.configuredProviders = new Set(getConfiguredProviderIds());
+    const configuredIds = new Set(getConfiguredProviderIds());
+    input.modelPicker.configuredProviders = configuredIds;
+    const providerIds = [...new Set(models.map((m) => m.provider))];
+    input.modelPicker.configuredViaMap = buildConfiguredViaMap(providerIds, configuredIds, subscriptionManager);
     void getPinned().then((pinned) => {
       input.modelPicker.pinnedIds = new Set(pinned);
     });
-    void input.modelPicker.loadRecentModels().catch(() => {});
+    void input.modelPicker.loadRecentModels().catch(() => {}); // best-effort: prefetch for UI, failure is non-visible
     input.modalOpened('modelPicker');
     input.modelPicker.openAllModels(models, runtime.model);
     render();
@@ -59,7 +98,9 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
 
   commandContext.openProviderPicker = () => {
     const providers = [...new Set(providerRegistry.listModels().map((model) => model.provider))];
-    input.modelPicker.configuredProviders = new Set(getConfiguredProviderIds());
+    const configuredIds = new Set(getConfiguredProviderIds());
+    input.modelPicker.configuredProviders = configuredIds;
+    input.modelPicker.configuredViaMap = buildConfiguredViaMap(providers, configuredIds, subscriptionManager);
     input.modalOpened('modelPicker');
     input.modelPicker.openProviders(providers, runtime.provider);
     render();

package/src/version.ts

@@ -6,7 +6,7 @@ import { join } from 'node:path';
 // The prebuild script updates the fallback value before compilation.
 // Uses import.meta.dir (Bun) to locate package.json relative to this file,
 // which is correct regardless of the process working directory.
-let _version = '0.18.23';
+let _version = '0.19.1';
 try {
   const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8'));
   _version = pkg.version ?? _version;