@pellux/goodvibes-tui 0.18.19 → 0.18.23

package/src/panels/knowledge-panel.ts

@@ -1,5 +1,6 @@
 import type { Line } from '../types/grid.ts';
 import { BasePanel } from './base-panel.ts';
+import { type ConfirmState, handleConfirmInput, renderConfirmLines } from './confirm-state.ts';
 import type { MemoryClass, MemoryRecord, MemoryRegistry, MemoryReviewState } from '@pellux/goodvibes-sdk/platform/state/memory-store';
 import {
   buildBodyText,
@@ -47,6 +48,8 @@ export class KnowledgePanel extends BasePanel {
   private selectedIndex = 0;
   private scrollOffset = 0;
   private records: MemoryRecord[] = [];
+  // I1: confirm for destructive review-state mutations
+  private confirm: ConfirmState<{ id: string; action: 'stale' | 'contradicted' }> | null = null;
 
   public constructor(registry: MemoryRegistry) {
     super('knowledge', 'Knowledge', 'K', 'agent');
@@ -72,6 +75,50 @@ export class KnowledgePanel extends BasePanel {
   }
 
   public handleInput(key: string): boolean {
+    // I1: y/n confirm for stale/contradict
+    if (this.confirm) {
+      const result = handleConfirmInput(this.confirm, key);
+      if (result === 'confirmed') {
+        const { id, action } = this.confirm.subject;
+        this.confirm = null;
+        const selected = this.records.find((r) => r.id === id);
+        if (selected) {
+          try {
+            if (action === 'stale') {
+              this.registry.review(id, {
+                state: 'stale',
+                confidence: Math.min(selected.confidence, 40),
+                reviewedBy: 'operator',
+                staleReason: 'marked stale from the knowledge panel',
+              });
+            } else {
+              this.registry.review(id, {
+                state: 'contradicted',
+                confidence: 0,
+                reviewedBy: 'operator',
+                staleReason: 'marked contradicted from the knowledge panel',
+              });
+            }
+          } catch (e) {
+            // I2: surface async failure
+            this.setError(`Review update failed: ${e instanceof Error ? e.message : String(e)}`);
+          }
+        }
+        this.refresh();
+        this.markDirty();
+        return true;
+      }
+      if (result === 'cancelled') {
+        this.confirm = null;
+        this.markDirty();
+        return true;
+      }
+      if (result === 'absorbed') return true;
+    }
+
+    // I2: auto-clear error on next keypress
+    if (this.lastError) this.clearError();
+
     if (this.records.length === 0) return false;
     if (key === 'ArrowUp' || key === 'k') {
       this.selectedIndex = Math.max(0, this.selectedIndex - 1);
@@ -98,24 +145,14 @@ export class KnowledgePanel extends BasePanel {
       return true;
     }
     if (key === 's') {
-      this.registry.review(selected.id, {
-        state: 'stale',
-        confidence: Math.min(selected.confidence, 40),
-        reviewedBy: 'operator',
-        staleReason: 'marked stale from the knowledge panel',
-      });
-      this.refresh();
+      // I1: prompt confirm before marking stale
+      this.confirm = { subject: { id: selected.id, action: 'stale' }, label: selected.summary.slice(0, 40) };
       this.markDirty();
       return true;
     }
     if (key === 'c') {
-      this.registry.review(selected.id, {
-        state: 'contradicted',
-        confidence: 0,
-        reviewedBy: 'operator',
-        staleReason: 'marked contradicted from the knowledge panel',
-      });
-      this.refresh();
+      // I1: prompt confirm before marking contradicted
+      this.confirm = { subject: { id: selected.id, action: 'contradicted' }, label: selected.summary.slice(0, 40) };
       this.markDirty();
       return true;
     }
@@ -141,6 +178,18 @@ export class KnowledgePanel extends BasePanel {
 
   public render(width: number, height: number): Line[] {
     this.needsRender = false;
+
+    // I1: show confirm dialog in place of normal content
+    if (this.confirm) {
+      return buildPanelWorkspace(width, height, {
+        title: 'Knowledge Control Room',
+        intro: '',
+        sections: [{ title: 'Confirmation', lines: renderConfirmLines(width, this.confirm) }],
+        footerLines: [buildPanelLine(width, [['  y confirm  n / Esc cancel', C.dim]])],
+        palette: C,
+      });
+    }
+
     if (this.records.length === 0) this.refresh();
 
     const intro = 'Typed project knowledge, reviewed evidence, and operator-governed memory across session, project, and team scopes.';

package/src/panels/local-auth-panel.ts

@@ -1,6 +1,6 @@
 import type { Line } from '../types/grid.ts';
 import { createEmptyLine } from '../types/grid.ts';
-import { BasePanel } from './base-panel.ts';
+import { ScrollableListPanel } from './scrollable-list-panel.ts';
 import {
   buildDetailBlock,
   buildGuidanceLine,
@@ -9,8 +9,7 @@ import {
   buildSummaryBlock,
   buildPanelWorkspace,
   DEFAULT_PANEL_PALETTE,
-  resolvePrimaryScrollableSection,
-  type PanelWorkspaceSection,
+  type PanelPalette,
 } from './polish.ts';
 import type { LocalAuthSnapshot } from '@pellux/goodvibes-sdk/platform/security/user-auth';
 import type { LocalAuthInspectionQuery } from '../runtime/ui-service-queries.ts';
@@ -27,9 +26,9 @@ function formatRoles(roles: readonly string[]): string {
   return roles.length > 0 ? roles.join(', ') : '(none)';
 }
 
-export class LocalAuthPanel extends BasePanel {
-  private selectedIndex = 0;
-  private scrollOffset = 0;
+type LocalAuthUser = LocalAuthSnapshot['users'][number];
+
+export class LocalAuthPanel extends ScrollableListPanel<LocalAuthUser> {
   private readonly authManager: LocalAuthInspectionQuery;
 
   public constructor(authManager: LocalAuthInspectionQuery) {
@@ -37,110 +36,94 @@ export class LocalAuthPanel extends BasePanel {
     this.authManager = authManager;
   }
 
-  public handleInput(key: string): boolean {
-    const users = this.authManager.inspect().users;
-    if (users.length === 0) return false;
-    if (key === 'up' || key === 'k') {
-      this.selectedIndex = Math.max(0, this.selectedIndex - 1);
-      this.markDirty();
-      return true;
-    }
-    if (key === 'down' || key === 'j') {
-      this.selectedIndex = Math.min(users.length - 1, this.selectedIndex + 1);
-      this.markDirty();
-      return true;
-    }
-    return false;
+  protected override getPalette(): PanelPalette {
+    return C;
+  }
+
+  protected getItems(): readonly LocalAuthUser[] {
+    return this.authManager.inspect().users;
+  }
+
+  protected renderItem(user: LocalAuthUser, _index: number, selected: boolean, width: number): Line {
+    return buildPanelListRow(width, [
+      { text: user.username.padEnd(20), fg: C.value },
+      { text: ` roles=${formatRoles(user.roles)}`.slice(0, Math.max(0, width - 24)), fg: C.info },
+    ], C, { selected });
+  }
+
+  protected override getEmptyStateMessage(): string {
+    return ' No local auth users configured.';
   }
 
   public render(width: number, height: number): Line[] {
-    this.needsRender = false;
     const intro = 'Manage local daemon and HTTP-listener auth users, bootstrap state, and active sessions.';
-    const footerLines = [buildPanelLine(width, [[' /auth local review  /auth local add-user  /auth local rotate-password  /auth local revoke-session ', C.dim]])];
     const snapshot = this.authManager.inspect();
-    this.selectedIndex = Math.min(this.selectedIndex, Math.max(0, snapshot.users.length - 1));
-    const selected = snapshot.users[this.selectedIndex];
+    const users = this.getItems();
+
     const issueMessages: string[] = [];
     if (snapshot.bootstrapCredentialPresent) issueMessages.push('Bootstrap credential file still exists and should be cleared after password rotation.');
     if (snapshot.userCount <= 1) issueMessages.push('Only one local auth user is configured.');
     if (snapshot.sessionCount === 0) issueMessages.push('No active local auth sessions are currently tracked.');
-    const sections: PanelWorkspaceSection[] = [
-      {
-        lines: buildSummaryBlock(width, 'Local auth posture', [
-          buildPanelLine(width, [
-            [' users ', C.label],
-            [String(snapshot.userCount), C.value],
-            ['  sessions ', C.label],
-            [String(snapshot.sessionCount), snapshot.sessionCount > 0 ? C.info : C.dim],
-            ['  bootstrap ', C.label],
-            [snapshot.bootstrapCredentialPresent ? 'present' : 'cleared', snapshot.bootstrapCredentialPresent ? C.warn : C.good],
-          ]),
-          buildPanelLine(width, [[' user store ', C.label], [snapshot.userStorePath.slice(0, Math.max(0, width - 13)), C.dim]]),
-          buildPanelLine(width, [[' bootstrap file ', C.label], [snapshot.bootstrapCredentialPath.slice(0, Math.max(0, width - 18)), C.dim]]),
-          ...(issueMessages.length > 0
-            ? issueMessages.map((issue) => buildPanelLine(width, [[` issue: ${issue}`.slice(0, Math.max(0, width)), C.warn]]))
-            : [buildPanelLine(width, [[' local auth posture looks healthy.', C.good]])]),
-          buildGuidanceLine(width, '/auth local rotate-password <user> <password>', 'rotate bootstrap/default credentials and revoke older sessions as needed', C),
-        ], C),
-      },
+
+    const headerLines: Line[] = [
+      ...buildSummaryBlock(width, 'Local auth posture', [
+        buildPanelLine(width, [
+          [' users ', C.label],
+          [String(snapshot.userCount), C.value],
+          ['  sessions ', C.label],
+          [String(snapshot.sessionCount), snapshot.sessionCount > 0 ? C.info : C.dim],
+          ['  bootstrap ', C.label],
+          [snapshot.bootstrapCredentialPresent ? 'present' : 'cleared', snapshot.bootstrapCredentialPresent ? C.warn : C.good],
+        ]),
+        buildPanelLine(width, [[' user store ', C.label], [snapshot.userStorePath.slice(0, Math.max(0, width - 13)), C.dim]]),
+        buildPanelLine(width, [[' bootstrap file ', C.label], [snapshot.bootstrapCredentialPath.slice(0, Math.max(0, width - 18)), C.dim]]),
+        ...(issueMessages.length > 0
+          ? issueMessages.map((issue) => buildPanelLine(width, [[` issue: ${issue}`.slice(0, Math.max(0, width)), C.warn]]))
+          : [buildPanelLine(width, [[' local auth posture looks healthy.', C.good]])]),
+        buildGuidanceLine(width, '/auth local rotate-password <user> <password>', 'rotate bootstrap/default credentials and revoke older sessions as needed', C),
+      ], C),
     ];
 
-    if (snapshot.users.length > 0) {
-      const selectedUserSection: PanelWorkspaceSection | null = selected
-        ? {
-            lines: buildDetailBlock(width, 'Selected user', [
-              buildPanelLine(width, [[' username ', C.label], [selected.username, C.value], ['  roles ', C.label], [formatRoles(selected.roles).slice(0, Math.max(0, width - 23)), C.info]]),
-              buildPanelLine(width, [[` next: /auth local rotate-password ${selected.username} <password>`.slice(0, Math.max(0, width)), C.dim]]),
-              buildPanelLine(width, [[` next: /auth local delete-user ${selected.username}`.slice(0, Math.max(0, width)), C.dim]]),
-            ], C),
-          }
-        : null;
-      const activeSessionsSection: PanelWorkspaceSection | null = snapshot.sessions.length > 0
-        ? {
-            title: 'Active Sessions',
-            lines: snapshot.sessions.slice(0, 8).map((session) => buildPanelLine(width, [
-              [' ', C.label],
-              [session.username.padEnd(18), C.value],
-              [` expires ${new Date(session.expiresAt).toLocaleString()}`.slice(0, Math.max(0, width - 20)), C.dim],
-            ])),
-          }
-        : null;
-      const rawUserLines: Line[] = snapshot.users.map((user, absolute) => {
-        return buildPanelListRow(width, [
-          { text: user.username.padEnd(20), fg: C.value },
-          { text: ` roles=${formatRoles(user.roles)}`.slice(0, Math.max(0, width - 24)), fg: C.info },
-        ], C, { selected: absolute === this.selectedIndex });
-      });
-      const resolvedUsersSection = resolvePrimaryScrollableSection(width, height, {
+    if (users.length === 0) {
+      const workspace = buildPanelWorkspace(width, height, {
+        title: 'Local Auth Control Room',
         intro,
-        footerLines,
+        sections: [{ lines: headerLines }],
         palette: C,
-        beforeSections: sections,
-        section: {
-          title: 'Users',
-          scrollableLines: rawUserLines,
-          selectedIndex: this.selectedIndex,
-          scrollOffset: this.scrollOffset,
-          guardRows: 1,
-          minRows: 4,
-          appendWindowSummary: { dimColor: C.dim },
-        },
-        afterSections: [selectedUserSection, activeSessionsSection].filter(Boolean) as PanelWorkspaceSection[],
       });
-      this.scrollOffset = resolvedUsersSection.scrollOffset;
-      sections.push(resolvedUsersSection.section);
-      if (selectedUserSection) sections.push(selectedUserSection);
-      if (activeSessionsSection) sections.push(activeSessionsSection);
+      while (workspace.length < height) workspace.push(createEmptyLine(width));
+      return workspace;
+    }
+
+    this.clampSelection();
+    const selected = users[this.selectedIndex];
+
+    const footerLines: Line[] = [];
+    if (selected) {
+      footerLines.push(
+        ...buildDetailBlock(width, 'Selected user', [
+          buildPanelLine(width, [[' username ', C.label], [selected.username, C.value], ['  roles ', C.label], [formatRoles(selected.roles).slice(0, Math.max(0, width - 23)), C.info]]),
+          buildPanelLine(width, [[` next: /auth local rotate-password ${selected.username} <password>`.slice(0, Math.max(0, width)), C.dim]]),
+          buildPanelLine(width, [[` next: /auth local delete-user ${selected.username}`.slice(0, Math.max(0, width)), C.dim]]),
+        ], C),
+      );
+    }
+
+    if (snapshot.sessions.length > 0) {
+      footerLines.push(
+        ...snapshot.sessions.slice(0, 8).map((session) => buildPanelLine(width, [
+          [' ', C.label],
+          [session.username.padEnd(18), C.value],
+          [` expires ${new Date(session.expiresAt).toLocaleString()}`.slice(0, Math.max(0, width - 20)), C.dim],
+        ])),
+      );
     }
+    footerLines.push(buildPanelLine(width, [[' /auth local review  /auth local add-user  /auth local rotate-password  /auth local revoke-session ', C.dim]]));
 
-    const lines = buildPanelWorkspace(width, height, {
+    return this.renderList(width, height, {
       title: 'Local Auth Control Room',
-      intro,
-      sections,
-      footerLines,
-      palette: C,
+      header: headerLines,
+      footer: footerLines,
     });
-    while (lines.length < height) lines.push(createEmptyLine(width));
-    return lines.slice(0, height);
   }
 }

package/src/panels/marketplace-panel.ts

@@ -81,18 +81,25 @@ export class MarketplacePanel extends BasePanel {
       this.scrollOffset = 0;
       return;
     }
-    const installedPlugins = new Set(listInstalledEcosystemEntries('plugin', this.ecosystemPaths).map((receipt) => receipt.entry.id));
-    const installedSkills = new Set(listInstalledEcosystemEntries('skill', this.ecosystemPaths).map((receipt) => receipt.entry.id));
-    const installedHookPacks = new Set(listInstalledEcosystemEntries('hook-pack', this.ecosystemPaths).map((receipt) => receipt.entry.id));
-    const installedPolicyPacks = new Set(listInstalledEcosystemEntries('policy-pack', this.ecosystemPaths).map((receipt) => receipt.entry.id));
-    const rows: MarketplaceRow[] = [
-      ...loadEcosystemCatalog('plugin', this.ecosystemPaths).map((entry) => ({ kind: 'plugin' as const, entry, installed: installedPlugins.has(entry.id) })),
-      ...loadEcosystemCatalog('skill', this.ecosystemPaths).map((entry) => ({ kind: 'skill' as const, entry, installed: installedSkills.has(entry.id) })),
-      ...loadEcosystemCatalog('hook-pack', this.ecosystemPaths).map((entry) => ({ kind: 'hook-pack' as const, entry, installed: installedHookPacks.has(entry.id) })),
-      ...loadEcosystemCatalog('policy-pack', this.ecosystemPaths).map((entry) => ({ kind: 'policy-pack' as const, entry, installed: installedPolicyPacks.has(entry.id) })),
-    ];
-    this.rows = rows.sort((a, b) => a.entry.name.localeCompare(b.entry.name));
-    this.selectedIndex = Math.min(this.selectedIndex, Math.max(0, this.rows.length - 1));
+    try {
+      const installedPlugins = new Set(listInstalledEcosystemEntries('plugin', this.ecosystemPaths).map((receipt) => receipt.entry.id));
+      const installedSkills = new Set(listInstalledEcosystemEntries('skill', this.ecosystemPaths).map((receipt) => receipt.entry.id));
+      const installedHookPacks = new Set(listInstalledEcosystemEntries('hook-pack', this.ecosystemPaths).map((receipt) => receipt.entry.id));
+      const installedPolicyPacks = new Set(listInstalledEcosystemEntries('policy-pack', this.ecosystemPaths).map((receipt) => receipt.entry.id));
+      const rows: MarketplaceRow[] = [
+        ...loadEcosystemCatalog('plugin', this.ecosystemPaths).map((entry) => ({ kind: 'plugin' as const, entry, installed: installedPlugins.has(entry.id) })),
+        ...loadEcosystemCatalog('skill', this.ecosystemPaths).map((entry) => ({ kind: 'skill' as const, entry, installed: installedSkills.has(entry.id) })),
+        ...loadEcosystemCatalog('hook-pack', this.ecosystemPaths).map((entry) => ({ kind: 'hook-pack' as const, entry, installed: installedHookPacks.has(entry.id) })),
+        ...loadEcosystemCatalog('policy-pack', this.ecosystemPaths).map((entry) => ({ kind: 'policy-pack' as const, entry, installed: installedPolicyPacks.has(entry.id) })),
+      ];
+      this.rows = rows.sort((a, b) => a.entry.name.localeCompare(b.entry.name));
+      this.selectedIndex = Math.min(this.selectedIndex, Math.max(0, this.rows.length - 1));
+      // I2: clear any previous catalog load error on successful refresh
+      this.clearError();
+    } catch (e) {
+      // I2: surface catalog load failure
+      this.setError(`Catalog load failed: ${e instanceof Error ? e.message : String(e)}`);
+    }
   }
 
   public render(width: number, height: number): Line[] {