@pellux/goodvibes-tui 0.18.12 → 0.18.17

package/CHANGELOG.md

@@ -4,6 +4,178 @@ All notable changes to GoodVibes TUI.
 
 ---
 
+## [0.18.17] — 2026-04-16
+
+### Bug Fixes
+
+- **Companion pairing token registered with embedded daemon**: `src/runtime/bootstrap.ts` now loads the persistent companion-pairing token via `getOrCreateCompanionToken('tui')` and passes it as `sharedDaemonToken` to `startExternalServices`. The TUI's QR panel advertises this token as the bearer for phone pairing; before this fix, the embedded daemon was started with no shared token and rejected every scanned token with `authenticated: false, authMode: "invalid"`
+- **QR code visual alignment**: `src/renderer/qr-renderer.ts` now uses `leftPad = 1` (down from 2) and prepends a single top quiet-band row. The QR's finder patterns now register symmetrically on both axes; previous rendering was mis-aligned by one cell horizontally and had no top quiet band
+
+### Dependencies
+
+- Bumped `@pellux/goodvibes-sdk` 0.18.36 → 0.18.37, picking up: `sharedDaemonToken`/`sharedHttpListenerToken` factory options on `startHostServices`, bootstrap credential drift detection that warns when `auth-bootstrap.txt` falls out of sync with `auth-users.json`
+- Regenerated `docs/foundation-artifacts/*` against SDK 0.18.37
+
+### Tests
+
+- Updated `src/test/runtime/bootstrap-services.test.ts` `daemonEnable`/`listenerEnable` expectations to include the new second argument (`undefined` when no shared token is supplied)
+- Test suite: 437/437 passing, typecheck clean, architecture check green
+
+---
+
+## [0.18.16] — 2026-04-16
+
+### Bug Fixes
+
+- **resolveToolLLM tests**: enabled `tools.llmEnabled` by default in `createTestManagers()` (`src/test/helpers/test-managers.ts`) so tool LLM resolution tests exercise the resolution logic directly; previously every test hit the gate and resolved to `null`
+- **Domain boundary contract test (GC-ARCH-001)**: removed `'conversation'` and `'permissions'` from the `DOMAINS` array in `src/runtime/store/domains/domain-read-matrix.ts` — the files they referenced were deleted in 0.18.15 and the filesystem↔array consistency check was failing
+
+### Architecture
+
+- **settings-modal decomposition**: extracted 10 pure helpers (`formatValue`, `valueColor`, `flagStateColor`, `mcpTrustColor`, `subscriptionStateColor`, `inferSubscriptionRouteReason`, `CATEGORY_LABELS`, `SETTING_LABELS`, `getSettingLabel`, `describeUiRouting`) into `src/renderer/settings-modal-helpers.ts`. `settings-modal.ts` drops from 844 → 737 lines, back under the 800-line architecture cap
+
+### Dependencies
+
+- Bumped `@pellux/goodvibes-sdk` 0.18.33 → 0.18.36, picking up: daemon shutdown symmetry, event bus iteration fix, atomic session writes, rate limiter TTL + LRU + sweep, `fetchWithTimeout` helper, restored port honoring in `resolveHostBinding` for `local`/`network` hostModes, and restored constructor-injected port/host in `resolveDaemonFacadeRuntime`
+- Regenerated `docs/foundation-artifacts/*` against the new SDK
+
+### Tests & Checks
+
+- Test suite: 437/437 passing (was 431/437 after 0.18.15)
+- Architecture check: passing (was failing with `settings-modal.ts` 844 > 800-line cap)
+- Typecheck: clean
+
+---
+
+## [0.18.15] — 2026-04-16
+
+### Correctness Fix
+
+- **daemon SIGINT/SIGTERM drain**: `src/daemon/cli.ts` — added AbortController signaling for in-flight requests, 15-second `Promise.race` shutdown deadline, hard `process.exit(1)` if deadline exceeded, debounced double-signal guard (`shutdownInFlight` flag)
+
+### Dead Code Removal (Tier 3 items 15-17)
+
+- Deleted 15 TUI mirror files with zero external importers:
+  - `src/runtime/diagnostics/index.ts`, `provider.ts`, `actions.ts`
+  - `src/runtime/diagnostics/panels/agents.ts`, `events.ts`, `health.ts`, `tasks.ts`, `tool-calls.ts`
+  - `src/runtime/store/helpers/reducers.ts` (barrel) and 4 sub-reducers
+  - `src/runtime/store/domains/permissions.ts`, `conversation.ts`
+- Updated `src/runtime/diagnostics/panels/index.ts` to re-export deleted panels from SDK
+
+### Config Re-export Shim Inlining (Tier 3 item 18)
+
+- Deleted `src/config/service-registry.ts` and `src/config/subscription-providers.ts` (1-line SDK re-exports)
+- Updated 29 call sites to import directly from `@pellux/goodvibes-sdk/platform/config/*`
+
+### SDK Consolidation — UI Read Models (Tier 3 items 19-20)
+
+- Converted 9 TUI mirror files to 1-line SDK re-exports (preserving all call-site import paths):
+  - `ui-events.ts`, `ui-service-queries.ts`, `ui-read-model-helpers.ts`
+  - `ui-read-models-observability.ts` and 4 observability sub-files (maintenance, options, remote, security, system)
+- Skipped (TUI-specific divergence): `ui-services.ts` (uses TUI `SecretsManager` subclass), `ui-read-models.ts` (depends on TUI `RuntimeServices`)
+- panel-resources drift: TUI version (119 lines) uses `panel-health-monitor.ts`; SDK version (152 lines) uses `component-health-monitor.js` — different monitor interfaces, TUI-specific binding kept
+
+---
+
+## [0.18.14] — 2026-04-16
+
+### Panel Navigation Overhaul
+
+- Created `ScrollableListPanel<T>` and `SearchableListPanel<T>` base classes in `src/panels/scrollable-list-panel.ts`
+- Migrated 30 panels from hand-coded scroll/cursor management to the shared base classes
+- All list panels now have consistent navigation: up/down/j/k, pageup/pagedown, home/end/g/G, enter to select
+- Selection is always visible within the viewport — guaranteed by `getVisibleWindow()` from `surface-layout.ts`
+- Removed ~150 lines of duplicated scroll boilerplate across panels
+
+### Modal Viewport Fixes
+
+- Fixed modal sizing: height is exactly 45% of viewport (both min and max — all modals same size), width is 50% with 25% minimum
+- Fixed modal scroll/selection: 6 modal/overlay files updated to use shared `getVisibleWindow()` instead of inline scroll math
+- Autocomplete overlay, file picker, bookmark modal, session picker, profile picker, and live tail modal all use the same viewport function
+
+### Settings Modal: Tools Tab
+
+- Added proper tools tab UI with "Tool LLM" and "Helper Model" section headers
+- Helper config keys (`helper.enabled`, `helper.globalProvider`, `helper.globalModel`) now routed into the tools tab
+- Boolean settings display as [on]/[off] toggles
+- Selecting a provider/model setting opens the full model picker instead of a text field
+- Model picker now supports 3 target modes: main, helper, and tool
+- Selecting a helper/tool model auto-enables the feature (`helper.enabled: true` / `tools.llmEnabled: true`)
+
+### QR Code Pairing for Companion Apps
+
+- Added `/qrcode` command (aliases `/qr`, `/pair`) that opens a QR code panel
+- QR panel displays connection info (daemon URL, token, username) + scannable QR code
+- QR rendered using Unicode half-block characters (▀/▄/█) for compact terminal display
+- Supports `r` to regenerate token (invalidates old one) and `c` to copy token to clipboard
+- Daemon standalone mode (`goodvibes-daemon`) now prints QR + connection info to stdout on startup
+- Companion tokens persist to `.goodvibes/tui/companion-token.json` with `gv_` prefix
+- Built on SDK 0.18.30 pairing module
+
+### Health Monitoring Rename
+
+- Renamed `panelHealthMonitor` to `componentHealthMonitor` across 20 files to align with SDK 0.18.29's generic naming
+- Deprecated `Panel*` type aliases preserved for backward compatibility
+
+### SDK 0.18.30 Update
+
+- Updated to `@pellux/goodvibes-sdk@0.18.30`
+- Consumes new pairing module, `tools.llmEnabled` config, and all 0.18.29 boundary cleanup
+
+### Verification
+
+- Full typecheck passes: `bun x tsc --noEmit` — 0 errors
+
+## [0.18.13] — 2026-04-16
+
+### SDK/TUI Boundary Separation
+
+Major cleanup of the SDK/TUI boundary. The TUI is now a thin rendering/input/wiring layer built on `@pellux/goodvibes-sdk@0.18.29`. Thousands of lines of duplicated, forked, and dead code have been removed and replaced with SDK imports.
+
+#### Dead Code Removed
+
+- Deleted 4 dead daemon files that nothing imported (`facade.ts`, `facade-composition.ts`, `surface-policy.ts`, `types.ts`) — 1,291 lines removed
+- Deleted 2 dead UI read-model files (`ui-read-models-core.ts`, `ui-read-models-operations.ts`) — the barrel already delegates to SDK
+
+#### Forks Replaced with SDK Imports
+
+- Replaced `src/core/orchestrator.ts` (736 lines) with a 3-line re-export from SDK — the SDK's Orchestrator already includes `getSpinner()`
+- Replaced `src/plugins/loader.ts` (305 lines) with re-exports from SDK — the SDK now supports `additionalDirectories` and `entryDefault` options
+- Replaced `src/tools/index.ts` (187 lines) with re-export of SDK's `registerAllTools`
+- Replaced `src/config/subscription-providers.ts` (128 lines) with `export *` from SDK
+- Replaced `src/config/index.ts` API key functions with re-exports from SDK's new `config/api-keys.ts`
+- Replaced `src/permissions/prompt.ts` type definitions with imports from SDK — kept `PermissionPromptUI` class (TUI-specific rendering)
+- Replaced 4 store/runtime duplicate files with SDK re-exports (conversation domain, permissions domain, conversation reducers, lifecycle reducers)
+
+#### ConversationManager Refactored
+
+- Refactored `src/core/conversation.ts` from a 776-line standalone class to a ~450-line subclass extending SDK's `ConversationManager`
+- Removed all duplicated message management methods (CRUD, branching, persistence, compaction, undo/redo) — now inherited from SDK
+- Defined `TuiBlockMeta extends BlockMeta` with rendering fields (`blockIndex`, `startLine`, `lineCount`, `collapseKey`)
+- Kept all TUI-specific rendering methods (history buffer, block registry, collapse state, display navigation)
+
+#### Health Monitoring Renamed
+
+- Renamed `panelHealthMonitor` to `componentHealthMonitor` throughout the TUI to align with SDK 0.18.29's generic naming
+- Updated 20 files across runtime, panels, diagnostics, bootstrap, and tests
+- Added deprecated `Panel*` type aliases for backward compatibility
+
+#### RuntimeState Aligned with SDK
+
+- Updated `store/state.ts` to use SDK's `surfacePerf: SurfacePerfDomainState` instead of `uiPerf: UiPerfDomainState`
+- Updated `store/selectors/index.ts` to match SDK's selector shape
+- Health monitoring perf files rewritten as SDK re-export shims
+
+#### Clipboard Split
+
+- Created `src/utils/clipboard.ts` with TUI-specific OSC 52 `copyToClipboard` function
+- Platform clipboard paste functions remain in SDK
+
+### Verification
+
+- Full typecheck passes: `bun x tsc --noEmit` — 0 errors
+- Updated to `@pellux/goodvibes-sdk@0.18.29`
+
 ## [0.18.12] — 2026-04-15
 
 ### SDK `0.18.28` Session-Persistence Boundary Fix

package/README.md

@@ -2,7 +2,7 @@
 
 [![CI](https://github.com/mgd34msu/goodvibes-tui/actions/workflows/ci.yml/badge.svg)](https://github.com/mgd34msu/goodvibes-tui/actions/workflows/ci.yml)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
-[![Version](https://img.shields.io/badge/version-0.18.12-blue.svg)](https://github.com/mgd34msu/goodvibes-tui)
+[![Version](https://img.shields.io/badge/version-0.18.17-blue.svg)](https://github.com/mgd34msu/goodvibes-tui)
 
 A terminal-native AI coding, operations, automation, knowledge, and integration console with a typed runtime, omnichannel surfaces, structured memory/knowledge, and a raw ANSI renderer.
 

package/docs/foundation-artifacts/operator-contract.json

@@ -3,7 +3,7 @@
   "product": {
     "id": "goodvibes",
     "surface": "operator",
-    "version": "0.18.28"
+    "version": "0.18.37"
   },
   "auth": {
     "modes": [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pellux/goodvibes-tui",
-  "version": "0.18.12",
+  "version": "0.18.17",
   "description": "Terminal-native GoodVibes product for coding, operations, automation, knowledge, channels, and daemon-backed control-plane workflows.",
   "type": "module",
   "main": "src/main.ts",
@@ -16,6 +16,7 @@
     "src",
     "!src/test",
     "!src/**/*.test.ts",
+    "!src/**/__tests__",
     "scripts/postinstall.js",
     "README.md",
     "CHANGELOG.md",
@@ -88,7 +89,7 @@
     "@anthropic-ai/vertex-sdk": "^0.16.0",
     "@ast-grep/napi": "^0.42.0",
     "@aws/bedrock-token-generator": "^1.1.0",
-    "@pellux/goodvibes-sdk": "0.18.28",
+    "@pellux/goodvibes-sdk": "0.18.37",
     "bash-language-server": "^5.6.0",
     "fuse.js": "^7.1.0",
     "graphql": "^16.13.2",

package/src/config/index.ts

@@ -15,7 +15,6 @@ export { ConfigError } from '@pellux/goodvibes-sdk/platform/types/errors';
 import { readFileSync } from 'fs';
 import { ConfigManager } from '@pellux/goodvibes-sdk/platform/config/manager';
 import type { GoodVibesConfig } from '@pellux/goodvibes-sdk/platform/config/schema';
-import { SecretsManager } from './secrets.ts';
 import { logger } from '@pellux/goodvibes-sdk/platform/utils/logger';
 import { summarizeError } from '@pellux/goodvibes-sdk/platform/utils/error-display';
 
@@ -54,140 +53,4 @@ export function getConfiguredSystemPrompt(configManager: Pick<ConfigManager, 'ge
   }
 }
 
-export function getConfiguredApiKeys(): Record<string, string> {
-  return loadEnvApiKeys();
-}
-
-function loadEnvApiKeys(): Record<string, string> {
-  const keys: Record<string, string> = {};
-  const mapping: Record<string, string> = {
-    openai: 'OPENAI_API_KEY',
-    anthropic: 'ANTHROPIC_API_KEY',
-    gemini: 'GEMINI_API_KEY',
-    inceptionlabs: 'INCEPTION_API_KEY',
-    openrouter: 'OPENROUTER_API_KEY',
-    aihubmix: 'AIHUBMIX_API_KEY',
-    groq: 'GROQ_API_KEY',
-    cerebras: 'CEREBRAS_API_KEY',
-    mistral: 'MISTRAL_API_KEY',
-    'ollama-cloud': 'OLLAMA_CLOUD_API_KEY',
-    // Note: also checked as OLLAMA_API_KEY below
-    huggingface: 'HF_API_KEY',
-    nvidia: 'NVIDIA_API_KEY',
-    llm7: 'LLM7_API_KEY',
-    deepseek: 'DEEPSEEK_API_KEY',
-    fireworks: 'FIREWORKS_API_KEY',
-    'github-copilot': 'COPILOT_GITHUB_TOKEN',
-    'microsoft-foundry': 'AZURE_OPENAI_API_KEY',
-    minimax: 'MINIMAX_API_KEY',
-    moonshot: 'MOONSHOT_API_KEY',
-    qianfan: 'QIANFAN_API_KEY',
-    qwen: 'QWEN_API_KEY',
-    sglang: 'SGLANG_API_KEY',
-    stepfun: 'STEPFUN_API_KEY',
-    together: 'TOGETHER_API_KEY',
-    venice: 'VENICE_API_KEY',
-    volcengine: 'VOLCANO_ENGINE_API_KEY',
-    xai: 'XAI_API_KEY',
-    xiaomi: 'XIAOMI_API_KEY',
-    zai: 'ZAI_API_KEY',
-    'cloudflare-ai-gateway': 'CLOUDFLARE_AI_GATEWAY_API_KEY',
-    'vercel-ai-gateway': 'AI_GATEWAY_API_KEY',
-    litellm: 'LITELLM_API_KEY',
-    'copilot-proxy': 'COPILOT_PROXY_API_KEY',
-  };
-  for (const [prov, envVar] of Object.entries(mapping)) {
-    let value = process.env[envVar];
-    // Fallback env var names
-    if (!value && prov === 'gemini') value = process.env['GOOGLE_API_KEY'] ?? process.env['GOOGLE_GEMINI_API_KEY'];
-    if (!value && prov === 'openai') value = process.env['OPENAI_KEY'];
-    if (!value && prov === 'anthropic') value = process.env['CLAUDE_API_KEY'];
-    if (!value && prov === 'ollama-cloud') value = process.env['OLLAMA_API_KEY'];
-    if (!value && prov === 'huggingface') value = process.env['HUGGINGFACE_API_KEY'] ?? process.env['HF_TOKEN'];
-    if (!value && prov === 'github-copilot') value = process.env['GH_TOKEN'] ?? process.env['GITHUB_TOKEN'];
-    if (!value && prov === 'qwen') value = process.env['DASHSCOPE_API_KEY'] ?? process.env['MODELSTUDIO_API_KEY'];
-    if (!value && prov === 'zai') value = process.env['Z_AI_API_KEY'];
-    if (value) keys[prov] = value;
-  }
-  return keys;
-}
-
-/**
- * resolveApiKeys — three-tier async resolution for all provider API keys.
- *
- * Resolution order per key:
- *   1. Environment variable (process.env)
- *   2. SecretsManager hierarchy-aware stores (secure preferred, plaintext policy-aware)
- *   3. Omitted from result (null → skip)
- *
- * Returns a map of provider → apiKey for all providers where a key is found.
- */
-export async function resolveApiKeys(
-  secrets: Pick<SecretsManager, 'get'>,
-): Promise<Record<string, string>> {
-  const mapping: Array<{ prov: string; envVars: string[] }> = [
-    { prov: 'openai',       envVars: ['OPENAI_API_KEY', 'OPENAI_KEY'] },
-    { prov: 'anthropic',    envVars: ['ANTHROPIC_API_KEY', 'CLAUDE_API_KEY'] },
-    { prov: 'gemini',       envVars: ['GEMINI_API_KEY', 'GOOGLE_API_KEY', 'GOOGLE_GEMINI_API_KEY'] },
-    { prov: 'inceptionlabs', envVars: ['INCEPTION_API_KEY'] },
-    { prov: 'openrouter',    envVars: ['OPENROUTER_API_KEY'] },
-    { prov: 'aihubmix',     envVars: ['AIHUBMIX_API_KEY'] },
-    { prov: 'groq',          envVars: ['GROQ_API_KEY'] },
-    { prov: 'cerebras',      envVars: ['CEREBRAS_API_KEY'] },
-    { prov: 'mistral',       envVars: ['MISTRAL_API_KEY'] },
-    { prov: 'ollama-cloud',  envVars: ['OLLAMA_CLOUD_API_KEY', 'OLLAMA_API_KEY'] },
-    { prov: 'huggingface',   envVars: ['HF_API_KEY', 'HUGGINGFACE_API_KEY', 'HF_TOKEN'] },
-    { prov: 'nvidia',        envVars: ['NVIDIA_API_KEY'] },
-    { prov: 'llm7',          envVars: ['LLM7_API_KEY'] },
-    { prov: 'deepseek',      envVars: ['DEEPSEEK_API_KEY'] },
-    { prov: 'fireworks',     envVars: ['FIREWORKS_API_KEY'] },
-    { prov: 'github-copilot', envVars: ['COPILOT_GITHUB_TOKEN', 'GH_TOKEN', 'GITHUB_TOKEN'] },
-    { prov: 'microsoft-foundry', envVars: ['AZURE_OPENAI_API_KEY'] },
-    { prov: 'minimax',       envVars: ['MINIMAX_API_KEY'] },
-    { prov: 'moonshot',      envVars: ['MOONSHOT_API_KEY'] },
-    { prov: 'qianfan',       envVars: ['QIANFAN_API_KEY'] },
-    { prov: 'qwen',          envVars: ['QWEN_API_KEY', 'DASHSCOPE_API_KEY', 'MODELSTUDIO_API_KEY'] },
-    { prov: 'sglang',        envVars: ['SGLANG_API_KEY'] },
-    { prov: 'stepfun',       envVars: ['STEPFUN_API_KEY'] },
-    { prov: 'together',      envVars: ['TOGETHER_API_KEY'] },
-    { prov: 'venice',        envVars: ['VENICE_API_KEY'] },
-    { prov: 'volcengine',    envVars: ['VOLCANO_ENGINE_API_KEY'] },
-    { prov: 'xai',           envVars: ['XAI_API_KEY'] },
-    { prov: 'xiaomi',        envVars: ['XIAOMI_API_KEY'] },
-    { prov: 'zai',           envVars: ['ZAI_API_KEY', 'Z_AI_API_KEY'] },
-    { prov: 'cloudflare-ai-gateway', envVars: ['CLOUDFLARE_AI_GATEWAY_API_KEY'] },
-    { prov: 'vercel-ai-gateway', envVars: ['AI_GATEWAY_API_KEY'] },
-    { prov: 'litellm',       envVars: ['LITELLM_API_KEY'] },
-    { prov: 'copilot-proxy', envVars: ['COPILOT_PROXY_API_KEY'] },
-  ];
-
-  const result: Record<string, string> = {};
-
-  for (const { prov, envVars } of mapping) {
-    // Tier 1: environment variables
-    let value: string | null = null;
-    for (const envVar of envVars) {
-      if (process.env[envVar]) {
-        value = process.env[envVar]!;
-        break;
-      }
-    }
-
-    // Tier 2: SecretsManager hierarchy-aware secure/plaintext stores
-    if (value === null) {
-      for (const envVar of envVars) {
-        const stored = await secrets.get(envVar);
-        if (stored !== null) {
-          value = stored;
-          break;
-        }
-      }
-    }
-
-    if (value !== null) {
-      result[prov] = value;
-    }
-  }
-
-  return result;
-}
+export { getConfiguredApiKeys, resolveApiKeys } from '@pellux/goodvibes-sdk/platform/config/api-keys';

package/src/core/conversation-rendering.ts

@@ -3,9 +3,9 @@ import { renderMarkdown, renderMarkdownTracked } from '../renderer/markdown.ts';
 import { renderToolCallBlock } from '../renderer/tool-call.ts';
 import { renderThinkingBlock } from '../renderer/thinking.ts';
 import { renderSystemMessage } from '../renderer/system-message.ts';
-import { createEmptyLine, type Line, type Cell } from '@pellux/goodvibes-sdk/platform/types/grid';
-import { getSplashLines, type SplashOptions } from '@pellux/goodvibes-sdk/platform/utils/splash-lines';
-import { interpolateColor, getDisplayWidth, wrapText } from '@pellux/goodvibes-sdk/platform/utils/terminal-width';
+import { createEmptyLine, type Line, type Cell } from '../types/grid.ts';
+import { getSplashLines, type SplashOptions } from '../utils/splash-lines.ts';
+import { interpolateColor, getDisplayWidth, wrapText } from '../utils/terminal-width.ts';
 import { LAYOUT } from '../renderer/layout.ts';
 import type { ConfigManager } from '@pellux/goodvibes-sdk/platform/config/manager';
 import { renderConversationCollapsedFragment, renderConversationEventLine } from '../renderer/conversation-surface.ts';