@pellux/goodvibes-sdk 1.3.0 → 1.3.1

package/dist/contracts/artifacts/operator-contract.json

@@ -3,7 +3,7 @@
   "product": {
     "id": "goodvibes",
     "surface": "operator",
-    "version": "1.3.0"
+    "version": "1.3.1"
   },
   "auth": {
     "modes": [

package/dist/platform/utils/notify.d.ts

@@ -20,9 +20,14 @@ export interface NotifyOptions {
     force?: boolean;
 }
 /**
- * True when this call must be a no-op: real desktop notifications (and the
- * terminal bell) must never fire from an automated test run and spam
- * whoever's desktop the tests happen to execute on.
+ * True when this call must not reach an external side effect: real desktop
+ * notifications (notify-send/osascript) and real webhook HTTP deliveries must
+ * never fire from an automated test run and spam whoever's desktop or endpoint
+ * the tests happen to execute on.
+ *
+ * Note this governs only the external shell-out/HTTP layer. The in-process
+ * terminal bell (a single \x07 byte written to this process's own stdout) has
+ * no external side effect and is NOT gated by this — see {@link notifyCompletion}.
  *
  * Suppressed when either:
  *   - `NODE_ENV === 'test'` (set automatically by `bun test`), or

package/dist/platform/utils/notify.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"notify.d.ts","sourceRoot":"","sources":["../../../src/platform/utils/notify.ts"],"names":[],"mappings":"AAAA,qFAAqF;AAKrF;;;;;;;;GAQG;AACH,iFAAiF;AACjF,wBAAgB,iBAAiB,CAAC,CAAC,EAAE,MAAM,GAAG,MAAM,CAEnD;AAED,MAAM,WAAW,aAAa;IAC5B;;;;;OAKG;IACH,KAAK,CAAC,EAAE,OAAO,CAAC;CACjB;AAED;;;;;;;;;;;;GAYG;AACH,wBAAgB,kBAAkB,CAAC,KAAK,CAAC,EAAE,OAAO,GAAG,OAAO,CAM3D;AAiCD,wBAAgB,gBAAgB,CAAC,KAAK,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,EAAE,UAAU,EAAE,MAAM,EAAE,OAAO,CAAC,EAAE,aAAa,GAAG,IAAI,CAwBlH"}
+{"version":3,"file":"notify.d.ts","sourceRoot":"","sources":["../../../src/platform/utils/notify.ts"],"names":[],"mappings":"AAAA,qFAAqF;AAKrF;;;;;;;;GAQG;AACH,iFAAiF;AACjF,wBAAgB,iBAAiB,CAAC,CAAC,EAAE,MAAM,GAAG,MAAM,CAEnD;AAED,MAAM,WAAW,aAAa;IAC5B;;;;;OAKG;IACH,KAAK,CAAC,EAAE,OAAO,CAAC;CACjB;AAED;;;;;;;;;;;;;;;;;GAiBG;AACH,wBAAgB,kBAAkB,CAAC,KAAK,CAAC,EAAE,OAAO,GAAG,OAAO,CAM3D;AAiCD,wBAAgB,gBAAgB,CAAC,KAAK,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,EAAE,UAAU,EAAE,MAAM,EAAE,OAAO,CAAC,EAAE,aAAa,GAAG,IAAI,CAgClH"}

package/dist/platform/utils/notify.js

@@ -15,9 +15,14 @@ export function escapeAppleScript(s) {
     return s.replace(/\\/g, '\\\\').replace(/"/g, '\\"');
 }
 /**
- * True when this call must be a no-op: real desktop notifications (and the
- * terminal bell) must never fire from an automated test run and spam
- * whoever's desktop the tests happen to execute on.
+ * True when this call must not reach an external side effect: real desktop
+ * notifications (notify-send/osascript) and real webhook HTTP deliveries must
+ * never fire from an automated test run and spam whoever's desktop or endpoint
+ * the tests happen to execute on.
+ *
+ * Note this governs only the external shell-out/HTTP layer. The in-process
+ * terminal bell (a single \x07 byte written to this process's own stdout) has
+ * no external side effect and is NOT gated by this — see {@link notifyCompletion}.
  *
  * Suppressed when either:
  *   - `NODE_ENV === 'test'` (set automatically by `bun test`), or
@@ -68,19 +73,28 @@ function spawnNotification(command) {
     }
 }
 export function notifyCompletion(title, message, durationMs, options) {
-    if (isNotifySuppressed(options?.force)) {
-        logger.debug('Completion notification suppressed under test', { title, durationMs });
-        return;
-    }
     // Terminal bell for responses > 5s.
     // Surface-specific: this writes directly to stdout and is only meaningful
     // in a terminal context. Host surfaces that manage their own output stream
     // should inject this behaviour via a callback rather than calling it here.
+    //
+    // The bell is an in-process byte write with no external side effect, so it
+    // is emitted even under test suppression — only the real desktop-notification
+    // spawn below is suppressed. (This is the notify-guard scope fix: silencing a
+    // test run must not silence the terminal bell, which several host surfaces
+    // assert as product behaviour.)
     if (durationMs > 5000) {
         process.stdout.write('\x07');
     }
-    // Desktop notification for responses > 30s
+    // Desktop notification for responses > 30s. Real notify-send/osascript
+    // spawns must never fire from an automated test run — suppressed under
+    // NODE_ENV=test / GOODVIBES_SUPPRESS_NOTIFY, with `force` as the opt-back-in
+    // for tests that exercise this shell-out layer itself.
     if (durationMs > 30000) {
+        if (isNotifySuppressed(options?.force)) {
+            logger.debug('Completion desktop notification suppressed under test', { title, durationMs });
+            return;
+        }
         if (process.platform === 'linux') {
             spawnNotification(['notify-send', title, message]);
         }

package/dist/platform/version.js

@@ -1,6 +1,6 @@
 import { readFileSync } from 'node:fs';
 import { join } from 'node:path';
-let version = '1.3.0';
+let version = '1.3.1';
 try {
     const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', '..', 'package.json'), 'utf-8'));
     version = pkg.version ?? version;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pellux/goodvibes-sdk",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "description": "TypeScript SDK for building GoodVibes operator, peer, web, mobile, and daemon-connected apps with typed contracts, auth, realtime events, and transport layers.",
   "keywords": [
     "goodvibes",
@@ -477,14 +477,14 @@
   "sideEffects": false,
   "type": "module",
   "dependencies": {
-    "@pellux/goodvibes-contracts": "1.3.0",
-    "@pellux/goodvibes-daemon-sdk": "1.3.0",
-    "@pellux/goodvibes-errors": "1.3.0",
-    "@pellux/goodvibes-operator-sdk": "1.3.0",
-    "@pellux/goodvibes-peer-sdk": "1.3.0",
-    "@pellux/goodvibes-transport-core": "1.3.0",
-    "@pellux/goodvibes-transport-http": "1.3.0",
-    "@pellux/goodvibes-transport-realtime": "1.3.0"
+    "@pellux/goodvibes-contracts": "1.3.1",
+    "@pellux/goodvibes-daemon-sdk": "1.3.1",
+    "@pellux/goodvibes-errors": "1.3.1",
+    "@pellux/goodvibes-operator-sdk": "1.3.1",
+    "@pellux/goodvibes-peer-sdk": "1.3.1",
+    "@pellux/goodvibes-transport-core": "1.3.1",
+    "@pellux/goodvibes-transport-http": "1.3.1",
+    "@pellux/goodvibes-transport-realtime": "1.3.1"
   },
   "optionalDependencies": {
     "@agentclientprotocol/sdk": "^0.21.0",