@pellux/goodvibes-sdk 0.37.2 → 0.38.0

package/dist/platform/orchestration/persistence.d.ts

@@ -0,0 +1,24 @@
+/** SDK-owned platform module. This implementation is maintained in goodvibes-sdk. */
+import { type OrchestrationEvent, type PhaseResult, type SerializedWorkstream, type Workstream, type WorkstreamSnapshot } from './types.js';
+export declare function serializeWorkstream(workstream: Workstream): SerializedWorkstream;
+export declare function deserializeWorkstream(serialized: SerializedWorkstream): Workstream;
+/** Mirrors WrfcController.serializeChain: JSON.stringify a schema-versioned envelope. Returns null on serialization failure rather than throwing. */
+export declare function serializeWorkstreamSnapshot(workstream: Workstream, completedResults: readonly PhaseResult[]): string | null;
+/**
+ * Mirrors WrfcController.deserializeChain's future-schemaVersion-reject
+ * guard: a snapshot written by a newer runtime is rejected (fail closed)
+ * rather than partially trusted.
+ */
+export declare function deserializeWorkstreamSnapshot(json: string): WorkstreamSnapshot | null;
+/** Read + quarantine-on-corrupt (never throws, never crashes the caller on a bad file). */
+export declare function loadWorkstreamSnapshot(projectRoot: string, workstreamId: string): WorkstreamSnapshot | null;
+/** List the workstream ids with a snapshot on disk (recognized or not — callers decide via loadWorkstreamSnapshot). */
+export declare function listSnapshotWorkstreamIds(projectRoot: string): string[];
+export declare function writeWorkstreamSnapshot(projectRoot: string, workstream: Workstream, completedResults: readonly PhaseResult[]): void;
+/**
+ * Debounced trailing writer (250ms, exactly like wrfc-persistence.ts
+ * DEBOUNCE_MS), subscribing to engine lifecycle events. Returns an
+ * unsubscribe function that also flushes any pending timers.
+ */
+export declare function attachDebouncedWriter(projectRoot: string, getWorkstream: (workstreamId: string) => Workstream | null, getCompletedResults: (workstreamId: string) => readonly PhaseResult[], subscribe: (listener: (event: OrchestrationEvent) => void) => () => void): () => void;
+//# sourceMappingURL=persistence.d.ts.map

package/dist/platform/orchestration/persistence.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"persistence.d.ts","sourceRoot":"","sources":["../../../src/platform/orchestration/persistence.ts"],"names":[],"mappings":"AAAA,qFAAqF;AAerF,OAAO,EAEL,KAAK,kBAAkB,EACvB,KAAK,WAAW,EAEhB,KAAK,oBAAoB,EAEzB,KAAK,UAAU,EACf,KAAK,kBAAkB,EACxB,MAAM,YAAY,CAAC;AAYpB,wBAAgB,mBAAmB,CAAC,UAAU,EAAE,UAAU,GAAG,oBAAoB,CAEhF;AAED,wBAAgB,qBAAqB,CAAC,UAAU,EAAE,oBAAoB,GAAG,UAAU,CAElF;AAED,qJAAqJ;AACrJ,wBAAgB,2BAA2B,CAAC,UAAU,EAAE,UAAU,EAAE,gBAAgB,EAAE,SAAS,WAAW,EAAE,GAAG,MAAM,GAAG,IAAI,CAa3H;AAED;;;;GAIG;AACH,wBAAgB,6BAA6B,CAAC,IAAI,EAAE,MAAM,GAAG,kBAAkB,GAAG,IAAI,CA6BrF;AAUD,2FAA2F;AAC3F,wBAAgB,sBAAsB,CAAC,WAAW,EAAE,MAAM,EAAE,YAAY,EAAE,MAAM,GAAG,kBAAkB,GAAG,IAAI,CAsB3G;AAED,uHAAuH;AACvH,wBAAgB,yBAAyB,CAAC,WAAW,EAAE,MAAM,GAAG,MAAM,EAAE,CAWvE;AAED,wBAAgB,uBAAuB,CAAC,WAAW,EAAE,MAAM,EAAE,UAAU,EAAE,UAAU,EAAE,gBAAgB,EAAE,SAAS,WAAW,EAAE,GAAG,IAAI,CAUnI;AAED;;;;GAIG;AACH,wBAAgB,qBAAqB,CACnC,WAAW,EAAE,MAAM,EACnB,aAAa,EAAE,CAAC,YAAY,EAAE,MAAM,KAAK,UAAU,GAAG,IAAI,EAC1D,mBAAmB,EAAE,CAAC,YAAY,EAAE,MAAM,KAAK,SAAS,WAAW,EAAE,EACrE,SAAS,EAAE,CAAC,QAAQ,EAAE,CAAC,KAAK,EAAE,kBAAkB,KAAK,IAAI,KAAK,MAAM,IAAI,GACvE,MAAM,IAAI,CA4BZ"}

package/dist/platform/orchestration/persistence.js

@@ -0,0 +1,176 @@
+/** SDK-owned platform module. This implementation is maintained in goodvibes-sdk. */
+/**
+ * Persistence (Wave 4, wo701) — mirrors the WrfcController chain seams
+ * exactly: serializeChain:323 / deserializeChain:345 (including the
+ * future-schemaVersion-reject guard at :364) / importChain:402. Writes to
+ * `.goodvibes/orchestration/<workstreamId>.json` — SEPARATE from the TUI's
+ * `.goodvibes/tui/wrfc-chains.json` (src/runtime/wrfc-persistence.ts), no
+ * path collision. Debounce (250ms) and corrupt-snapshot quarantine
+ * (`<path>.unrecognized`) mirror that same TUI module's conventions.
+ */
+import { existsSync, mkdirSync, readFileSync, readdirSync, renameSync, writeFileSync } from 'node:fs';
+import { join } from 'node:path';
+import { logger } from '../utils/logger.js';
+import { summarizeError } from '../utils/error-display.js';
+import { CURRENT_WORKSTREAM_SCHEMA_VERSION, } from './types.js';
+const DEBOUNCE_MS = 250;
+function serializeWorkItem(item) {
+    return { ...item, visits: Object.fromEntries(item.visits) };
+}
+function deserializeWorkItem(raw) {
+    return { ...raw, visits: new Map(Object.entries(raw.visits)) };
+}
+export function serializeWorkstream(workstream) {
+    return { ...workstream, items: workstream.items.map(serializeWorkItem) };
+}
+export function deserializeWorkstream(serialized) {
+    return { ...serialized, items: serialized.items.map(deserializeWorkItem) };
+}
+/** Mirrors WrfcController.serializeChain: JSON.stringify a schema-versioned envelope. Returns null on serialization failure rather than throwing. */
+export function serializeWorkstreamSnapshot(workstream, completedResults) {
+    const snapshot = {
+        schemaVersion: CURRENT_WORKSTREAM_SCHEMA_VERSION,
+        writtenAt: Date.now(),
+        workstream: serializeWorkstream(workstream),
+        completedResults,
+    };
+    try {
+        return JSON.stringify(snapshot);
+    }
+    catch (error) {
+        logger.error('orchestration persistence: JSON serialization failed', { workstreamId: workstream.id, error: summarizeError(error) });
+        return null;
+    }
+}
+/**
+ * Mirrors WrfcController.deserializeChain's future-schemaVersion-reject
+ * guard: a snapshot written by a newer runtime is rejected (fail closed)
+ * rather than partially trusted.
+ */
+export function deserializeWorkstreamSnapshot(json) {
+    let raw;
+    try {
+        raw = JSON.parse(json);
+    }
+    catch (error) {
+        logger.error('orchestration persistence: JSON parse failed', { error: summarizeError(error) });
+        return null;
+    }
+    if (raw === null || typeof raw !== 'object') {
+        logger.warn('orchestration persistence: invalid snapshot JSON — not an object');
+        return null;
+    }
+    const candidate = raw;
+    if (typeof candidate.schemaVersion !== 'number') {
+        logger.warn('orchestration persistence: invalid snapshot JSON — missing schemaVersion');
+        return null;
+    }
+    if (candidate.schemaVersion > CURRENT_WORKSTREAM_SCHEMA_VERSION) {
+        logger.error('orchestration persistence: future schemaVersion rejected — upgrade runtime to read this snapshot', {
+            schemaVersion: candidate.schemaVersion,
+            supportedVersion: CURRENT_WORKSTREAM_SCHEMA_VERSION,
+        });
+        return null;
+    }
+    if (!candidate.workstream || typeof candidate.workstream !== 'object' || !Array.isArray(candidate.completedResults)) {
+        logger.warn('orchestration persistence: invalid snapshot JSON — missing workstream/completedResults');
+        return null;
+    }
+    return candidate;
+}
+function orchestrationDir(projectRoot) {
+    return join(projectRoot, '.goodvibes', 'orchestration');
+}
+function snapshotPath(projectRoot, workstreamId) {
+    return join(orchestrationDir(projectRoot), `${workstreamId}.json`);
+}
+/** Read + quarantine-on-corrupt (never throws, never crashes the caller on a bad file). */
+export function loadWorkstreamSnapshot(projectRoot, workstreamId) {
+    const path = snapshotPath(projectRoot, workstreamId);
+    if (!existsSync(path))
+        return null;
+    let text;
+    try {
+        text = readFileSync(path, 'utf-8');
+    }
+    catch (error) {
+        logger.warn('orchestration persistence: snapshot read failed', { path, error: summarizeError(error) });
+        return null;
+    }
+    const snapshot = deserializeWorkstreamSnapshot(text);
+    if (snapshot === null) {
+        const quarantinePath = `${path}.unrecognized`;
+        try {
+            renameSync(path, quarantinePath);
+            logger.warn('orchestration persistence: quarantined unrecognized snapshot', { path, quarantinePath });
+        }
+        catch (error) {
+            logger.error('orchestration persistence: failed to quarantine unrecognized snapshot', { path, error: summarizeError(error) });
+        }
+        return null;
+    }
+    return snapshot;
+}
+/** List the workstream ids with a snapshot on disk (recognized or not — callers decide via loadWorkstreamSnapshot). */
+export function listSnapshotWorkstreamIds(projectRoot) {
+    const dir = orchestrationDir(projectRoot);
+    if (!existsSync(dir))
+        return [];
+    try {
+        return readdirSync(dir)
+            .filter((entry) => entry.endsWith('.json'))
+            .map((entry) => entry.slice(0, -'.json'.length));
+    }
+    catch (error) {
+        logger.warn('orchestration persistence: failed to list snapshot directory', { dir, error: summarizeError(error) });
+        return [];
+    }
+}
+export function writeWorkstreamSnapshot(projectRoot, workstream, completedResults) {
+    const json = serializeWorkstreamSnapshot(workstream, completedResults);
+    if (json === null)
+        return;
+    const path = snapshotPath(projectRoot, workstream.id);
+    try {
+        mkdirSync(orchestrationDir(projectRoot), { recursive: true });
+        writeFileSync(path, json, 'utf-8');
+    }
+    catch (error) {
+        logger.error('orchestration persistence: snapshot write failed', { path, error: summarizeError(error) });
+    }
+}
+/**
+ * Debounced trailing writer (250ms, exactly like wrfc-persistence.ts
+ * DEBOUNCE_MS), subscribing to engine lifecycle events. Returns an
+ * unsubscribe function that also flushes any pending timers.
+ */
+export function attachDebouncedWriter(projectRoot, getWorkstream, getCompletedResults, subscribe) {
+    const timers = new Map();
+    function scheduleWrite(workstreamId) {
+        const existing = timers.get(workstreamId);
+        if (existing)
+            clearTimeout(existing);
+        const timer = setTimeout(() => {
+            timers.delete(workstreamId);
+            const workstream = getWorkstream(workstreamId);
+            if (!workstream)
+                return;
+            writeWorkstreamSnapshot(projectRoot, workstream, getCompletedResults(workstreamId));
+        }, DEBOUNCE_MS);
+        timer.unref?.();
+        timers.set(workstreamId, timer);
+    }
+    const unsubscribe = subscribe((event) => {
+        // 'dirty-tree-at-launch' (Wave 6, wo-F item 4) is engine-wide, not
+        // workstream-scoped — it has no workstreamId to schedule a write for.
+        if (event.type === 'dirty-tree-at-launch')
+            return;
+        scheduleWrite(event.workstreamId);
+    });
+    return () => {
+        unsubscribe();
+        for (const timer of timers.values())
+            clearTimeout(timer);
+        timers.clear();
+    };
+}

package/dist/platform/orchestration/phase-runner.d.ts

@@ -0,0 +1,87 @@
+/** SDK-owned platform module. This implementation is maintained in goodvibes-sdk. */
+/**
+ * Phase-runner (Wave 4, wo701) — runs one WorkItem through one Phase: spawn
+ * agent, await completion, verify claims, run gates, commit, cleanup.
+ *
+ * REUSES the hardened WRFC primitives verbatim (same functions WrfcController
+ * itself calls, so behavior can't fork): verifyEngineerClaims
+ * (wrfc-reporting.ts) for the phantom-work guard, runWrfcGateChecks
+ * (wrfc-gate-runtime.ts) for quality gates, AgentWorktree.commitWorkingTree
+ * for scoped commits, and the transport-retry / WrfcChainFailureKind pattern
+ * (isTransportFailureMessage + getWrfcTransportRetryLimit/DelayMs) for
+ * bounded respawn-on-transport-blip.
+ *
+ * REALITY-WINS DIVERGENCE from the brief's design (c): WrfcController itself
+ * (wrfc-controller.ts, verified) never calls AgentWorktree.create() for its
+ * role agents — engineer/reviewer/fixer/integrator all run in the SAME
+ * shared `projectRoot` working directory; AgentWorktree is used ONLY for its
+ * commitWorkingTree/merge/cleanup surface (merge/cleanup are safe no-ops
+ * when no isolated worktree dir exists, which is always, today). There is no
+ * per-agent `workingDirectory` override anywhere in AgentInput /
+ * AgentOrchestratorRunContext.createRunContext() (verified: the latter is
+ * fixed per AgentOrchestrator instance, not per-spawn), so a spawned agent
+ * cannot actually be pointed at an isolated worktree directory without new
+ * cross-cutting plumbing through AgentManager/AgentOrchestrator construction
+ * — well beyond this module's boundary, and not something WrfcController
+ * itself has either. This module therefore mirrors WrfcController's ACTUAL
+ * (shared-directory) behavior rather than the brief's aspirational
+ * per-item-isolated-worktree fan-out; true fan-out isolation is a valuable,
+ * separately-scoped follow-up (see the work-order report).
+ *
+ * SECOND REALITY-WINS DIVERGENCE: AgentManager.spawn()'s root-spawn
+ * normalization (tools/agent/wrfc-batch-policy.ts isRootReviewRoleTask) force
+ * -rewrites any PARENTLESS spawn whose template is literally
+ * reviewer/tester/verifier/qa/review/test, OR whose task text matches
+ * ROLE_ACTION_RE/ROLE_PREFIX_RE (e.g. "review the diff"), into an
+ * 'engineer'-templated WRFC-owner chain with `dangerously_disable_wrfc`
+ * forced back to `false` — REGARDLESS of what this module passes in.
+ * Phase-runner spawns are always parentless (a workstream has no owning
+ * AgentRecord), so it must dodge that heuristic by construction: never
+ * literally template review/test-flavored phases as one of those role
+ * strings (use 'general' instead — see templateForPhase), and phrase
+ * review-phase prompts with "assess/evaluate" rather than "review/test/
+ * verify" (see buildPhaseTask). This is load-bearing: changing this wording
+ * without checking wrfc-batch-policy.ts's regexes again risks silently
+ * re-activating the WRFC hijack for review-kind phases.
+ */
+import type { AgentManager } from '../tools/agent/manager.js';
+import type { ConfigManager } from '../config/manager.js';
+import type { RuntimeEventBus } from '../runtime/events/index.js';
+import type { CancellationRegistry } from './cancellation.js';
+import { type DirtyLaunchSnapshot } from './dirty-guard.js';
+import type { Phase, PhaseResult, WorkItem, WorkItemUsage, Workstream } from './types.js';
+/** Narrow structural pick — testable with stubs, mirrors AgentManagerLike (wrfc-config.ts). */
+export type PhaseRunnerAgentManagerLike = Pick<AgentManager, 'spawn' | 'getStatus' | 'cancel' | 'registerCancellationSignal' | 'releaseCancellationSignal'>;
+/** Structural pick of AgentWorktree's surface — matches WrfcController's WrfcWorktreeOps injection seam exactly, so the same test doubles work for both. */
+export interface WrfcWorktreeOps {
+    merge(agentId: string): Promise<boolean>;
+    cleanup(agentId: string): Promise<void>;
+    commitWorkingTree(message: string, paths?: string[]): Promise<string | null>;
+    currentHead(): Promise<string | null>;
+}
+export interface PhaseRunnerDeps {
+    readonly agentManager: PhaseRunnerAgentManagerLike;
+    readonly configManager: Pick<ConfigManager, 'get' | 'getCategory'>;
+    readonly runtimeBus: RuntimeEventBus;
+    readonly projectRoot: string;
+    readonly sessionId: string;
+    readonly createWorktree?: (() => WrfcWorktreeOps) | undefined;
+    readonly cancellation: CancellationRegistry;
+    readonly priceUsage?: ((model: string | undefined, usage: WorkItemUsage) => number | null) | undefined;
+    readonly skipClaimVerification?: boolean | undefined;
+    /**
+     * The dirty-tree snapshot taken synchronously at engine launch (Wave 6,
+     * wo-F item 4 — see dirty-guard.ts). Absent (undefined) degrades to
+     * today's behavior: no exclusion, every candidate path is committed.
+     */
+    readonly launchDirtySnapshot?: DirtyLaunchSnapshot | undefined;
+}
+export interface PhaseRunOutcome {
+    readonly result: PhaseResult;
+    readonly agentStatus: 'completed' | 'failed' | 'cancelled';
+}
+/** Combines a new phase's usage into a work item's running total. Single-source cost (never independently re-priced here). */
+export declare function mergeUsage(a: WorkItemUsage, b: WorkItemUsage): WorkItemUsage;
+/** Runs one WorkItem through one Phase to completion (or cancellation/failure). Recurses (bounded by transportRetryLimit) on a transport-classified spawn failure. */
+export declare function runPhase(workstream: Workstream, item: WorkItem, phase: Phase, priorReports: readonly PhaseResult[], deps: PhaseRunnerDeps): Promise<PhaseRunOutcome>;
+//# sourceMappingURL=phase-runner.d.ts.map

package/dist/platform/orchestration/phase-runner.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"phase-runner.d.ts","sourceRoot":"","sources":["../../../src/platform/orchestration/phase-runner.ts"],"names":[],"mappings":"AAAA,qFAAqF;AAErF;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA4CG;AACH,OAAO,KAAK,EAAE,YAAY,EAAe,MAAM,2BAA2B,CAAC;AAC3E,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,sBAAsB,CAAC;AAC1D,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,4BAA4B,CAAC;AAelE,OAAO,KAAK,EAAE,oBAAoB,EAAE,MAAM,mBAAmB,CAAC;AAC9D,OAAO,EAAiC,KAAK,mBAAmB,EAAE,MAAM,kBAAkB,CAAC;AAC3F,OAAO,KAAK,EAAgC,KAAK,EAAE,WAAW,EAAE,QAAQ,EAAE,aAAa,EAAE,UAAU,EAAE,MAAM,YAAY,CAAC;AAExH,+FAA+F;AAC/F,MAAM,MAAM,2BAA2B,GAAG,IAAI,CAC5C,YAAY,EACZ,OAAO,GAAG,WAAW,GAAG,QAAQ,GAAG,4BAA4B,GAAG,2BAA2B,CAC9F,CAAC;AAEF,4JAA4J;AAC5J,MAAM,WAAW,eAAe;IAC9B,KAAK,CAAC,OAAO,EAAE,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC,CAAC;IACzC,OAAO,CAAC,OAAO,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAAC;IACxC,iBAAiB,CAAC,OAAO,EAAE,MAAM,EAAE,KAAK,CAAC,EAAE,MAAM,EAAE,GAAG,OAAO,CAAC,MAAM,GAAG,IAAI,CAAC,CAAC;IAC7E,WAAW,IAAI,OAAO,CAAC,MAAM,GAAG,IAAI,CAAC,CAAC;CACvC;AAED,MAAM,WAAW,eAAe;IAC9B,QAAQ,CAAC,YAAY,EAAE,2BAA2B,CAAC;IACnD,QAAQ,CAAC,aAAa,EAAE,IAAI,CAAC,aAAa,EAAE,KAAK,GAAG,aAAa,CAAC,CAAC;IACnE,QAAQ,CAAC,UAAU,EAAE,eAAe,CAAC;IACrC,QAAQ,CAAC,WAAW,EAAE,MAAM,CAAC;IAC7B,QAAQ,CAAC,SAAS,EAAE,MAAM,CAAC;IAC3B,QAAQ,CAAC,cAAc,CAAC,EAAE,CAAC,MAAM,eAAe,CAAC,GAAG,SAAS,CAAC;IAC9D,QAAQ,CAAC,YAAY,EAAE,oBAAoB,CAAC;IAC5C,QAAQ,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC,KAAK,EAAE,MAAM,GAAG,SAAS,EAAE,KAAK,EAAE,aAAa,KAAK,MAAM,GAAG,IAAI,CAAC,GAAG,SAAS,CAAC;IACvG,QAAQ,CAAC,qBAAqB,CAAC,EAAE,OAAO,GAAG,SAAS,CAAC;IACrD;;;;OAIG;IACH,QAAQ,CAAC,mBAAmB,CAAC,EAAE,mBAAmB,GAAG,SAAS,CAAC;CAChE;AAED,MAAM,WAAW,eAAe;IAC9B,QAAQ,CAAC,MAAM,EAAE,WAAW,CAAC;IAC7B,QAAQ,CAAC,WAAW,EAAE,WAAW,GAAG,QAAQ,GAAG,WAAW,CAAC;CAC5D;AA8ED,8HAA8H;AAC9H,wBAAgB,UAAU,CAAC,CAAC,EAAE,aAAa,EAAE,CAAC,EAAE,aAAa,GAAG,aAAa,CAgB5E;AAyGD,sKAAsK;AACtK,wBAAsB,QAAQ,CAC5B,UAAU,EAAE,UAAU,EACtB,IAAI,EAAE,QAAQ,EACd,KAAK,EAAE,KAAK,EACZ,YAAY,EAAE,SAAS,WAAW,EAAE,EACpC,IAAI,EAAE,eAAe,GACpB,OAAO,CAAC,eAAe,CAAC,CAuG1B"}

package/dist/platform/orchestration/phase-runner.js

@@ -0,0 +1,274 @@
+/** SDK-owned platform module. This implementation is maintained in goodvibes-sdk. */
+import { AgentWorktree } from '../agents/worktree.js';
+import { parseCompletionReport, } from '../agents/completion-report.js';
+import { verifyEngineerClaims } from '../agents/wrfc-reporting.js';
+import { runWrfcGateChecks } from '../agents/wrfc-gate-runtime.js';
+import { getWrfcTransportRetryDelayMs, getWrfcTransportRetryLimit } from '../agents/wrfc-config.js';
+import { isTransportFailureMessage } from '../types/errors.js';
+import { logger } from '../utils/logger.js';
+import { summarizeError } from '../utils/error-display.js';
+import { excludeUntouchedLaunchResidue } from './dirty-guard.js';
+function templateForPhase(phase) {
+    return phase.kind === 'review' || phase.kind === 'gate' ? 'general' : 'engineer';
+}
+function buildPhaseTask(item, phase, priorReports) {
+    const priorContext = priorReports.length > 0
+        ? `\n\nPrior phase reports for this work item:\n${priorReports.map((r) => `- ${r.phaseId}: ${r.report.summary}`).join('\n')}`
+        : '';
+    if (phase.kind === 'review' || phase.kind === 'gate') {
+        return `Assess the following work item's changes against its constraints and report findings. Do not modify files.\n\nWork item: ${item.title}\n${item.task}${priorContext}`;
+    }
+    if (phase.kind === 'fix') {
+        return `Address the following findings for this work item.\n\nWork item: ${item.title}\n${item.task}${priorContext}`;
+    }
+    return `${item.task}${priorContext}`;
+}
+function genericReport(summary) {
+    return { version: 1, archetype: 'generic', summary, result: summary };
+}
+function sleep(ms) {
+    return new Promise((resolve) => {
+        const timer = setTimeout(resolve, ms);
+        timer.unref?.();
+    });
+}
+function awaitAgentTermination(runtimeBus, agentManager, agentId) {
+    return new Promise((resolve) => {
+        const unsubscribe = runtimeBus.onDomain('agents', (envelope) => {
+            const event = envelope.payload;
+            if (event.agentId !== agentId)
+                return;
+            if (event.type !== 'AGENT_COMPLETED' && event.type !== 'AGENT_FAILED' && event.type !== 'AGENT_CANCELLED')
+                return;
+            unsubscribe();
+            const status = event.type === 'AGENT_COMPLETED' ? 'completed' : event.type === 'AGENT_CANCELLED' ? 'cancelled' : 'failed';
+            resolve({ status, record: agentManager.getStatus(agentId) });
+        });
+    });
+}
+function usageFromRecord(record, priceUsage) {
+    const u = record?.usage;
+    const base = {
+        inputTokens: u?.inputTokens ?? 0,
+        outputTokens: u?.outputTokens ?? 0,
+        cacheReadTokens: u?.cacheReadTokens ?? 0,
+        cacheWriteTokens: u?.cacheWriteTokens ?? 0,
+        reasoningTokens: u?.reasoningTokens,
+        llmCallCount: u?.llmCallCount ?? 0,
+        turnCount: u?.turnCount ?? 0,
+        toolCallCount: record?.toolCallCount ?? 0,
+    };
+    let costUsd = null;
+    let costState = 'unpriced';
+    if (u && priceUsage) {
+        try {
+            const priced = priceUsage(record?.model, { ...base, costUsd: null, costState: 'unpriced' });
+            if (priced !== null) {
+                costUsd = priced;
+                costState = 'priced';
+            }
+        }
+        catch {
+            // stays unpriced — never fabricate a cost from a throwing pricer.
+        }
+    }
+    return { ...base, costUsd, costState };
+}
+/** Combines a new phase's usage into a work item's running total. Single-source cost (never independently re-priced here). */
+export function mergeUsage(a, b) {
+    const sawReasoning = a.reasoningTokens !== undefined || b.reasoningTokens !== undefined;
+    const bothPriced = a.costState === 'priced' && b.costState === 'priced';
+    const neitherPriced = a.costUsd === null && b.costUsd === null;
+    return {
+        inputTokens: a.inputTokens + b.inputTokens,
+        outputTokens: a.outputTokens + b.outputTokens,
+        cacheReadTokens: a.cacheReadTokens + b.cacheReadTokens,
+        cacheWriteTokens: a.cacheWriteTokens + b.cacheWriteTokens,
+        reasoningTokens: sawReasoning ? (a.reasoningTokens ?? 0) + (b.reasoningTokens ?? 0) : undefined,
+        llmCallCount: a.llmCallCount + b.llmCallCount,
+        turnCount: a.turnCount + b.turnCount,
+        toolCallCount: a.toolCallCount + b.toolCallCount,
+        costUsd: a.costUsd !== null && b.costUsd !== null ? a.costUsd + b.costUsd : (a.costUsd ?? b.costUsd),
+        costState: bothPriced ? 'priced' : neitherPriced ? 'unpriced' : 'estimated',
+    };
+}
+/** Quality gates (global-config-driven, reused VERBATIM) + phase-required-gate assertion + phantom guard + reviewer constraint findings. */
+async function evaluateGate(workstream, phase, report, deps) {
+    const results = [...await runWrfcGateChecks({
+            configManager: deps.configManager,
+            projectRoot: deps.projectRoot,
+            runtimeBus: deps.runtimeBus,
+            sessionId: deps.sessionId,
+            chainId: workstream.id,
+        })];
+    const ranNames = new Set(results.map((r) => r.gate));
+    const missingRequired = phase.gate.gates.filter((name) => !ranNames.has(name));
+    for (const name of missingRequired) {
+        results.push({ gate: name, passed: false, output: 'required gate is not configured/enabled', durationMs: 0 });
+    }
+    if (report.archetype === 'engineer' && !deps.skipClaimVerification) {
+        const verification = verifyEngineerClaims(report, deps.projectRoot);
+        if (verification.kind === 'unverified' || verification.kind === 'unverifiable_no_claims') {
+            results.push({ gate: 'phantom-work-guard', passed: false, output: verification.summary, durationMs: 0 });
+        }
+    }
+    let constraintFindings;
+    let unsatisfiedConstraintIds;
+    if (report.archetype === 'reviewer') {
+        const reviewer = report;
+        constraintFindings = reviewer.constraintFindings ?? [];
+        const unsatisfied = constraintFindings.filter((f) => !f.satisfied);
+        unsatisfiedConstraintIds = unsatisfied.map((f) => f.constraintId);
+        if (!reviewer.passed || unsatisfied.length > 0) {
+            results.push({
+                gate: 'reviewer-verdict',
+                passed: false,
+                output: unsatisfied.length > 0
+                    ? `${unsatisfied.length} unsatisfied constraint(s): ${unsatisfied.map((f) => f.constraintId).join(', ')}`
+                    : 'reviewer did not pass',
+                durationMs: 0,
+            });
+        }
+    }
+    return {
+        passed: results.every((r) => r.passed),
+        results,
+        constraintFindings,
+        unsatisfiedConstraintIds,
+    };
+}
+async function commitPhaseWork(item, phase, agentId, worktree, deps) {
+    if (phase.gate.scope === 'off')
+        return undefined;
+    let paths = phase.gate.scope === 'scoped' ? item.touchedPaths : undefined;
+    let exclusion;
+    if (paths && paths.length > 0 && deps.launchDirtySnapshot) {
+        const launchSnapshot = deps.launchDirtySnapshot;
+        if (launchSnapshot.size > 0) {
+            const { included, excluded } = excludeUntouchedLaunchResidue(deps.projectRoot, paths, launchSnapshot);
+            if (excluded.length > 0) {
+                exclusion = { excludedPaths: excluded, skipped: included.length === 0 };
+                if (included.length === 0) {
+                    // Every candidate path is untouched launch-dirty residue — an
+                    // honest "nothing this phase did needs committing", not a silent
+                    // no-op AND not a fallback to sweeping the whole working tree.
+                    logger.info('orchestration phase-runner: scoped commit skipped — every candidate path is untouched launch-dirty residue', {
+                        itemId: item.id,
+                        phaseId: phase.id,
+                        excludedPaths: excluded,
+                    });
+                    return exclusion;
+                }
+                logger.info('orchestration phase-runner: excluded untouched launch-dirty residue from scoped commit', {
+                    itemId: item.id,
+                    phaseId: phase.id,
+                    excludedPaths: excluded,
+                });
+                paths = [...included];
+            }
+        }
+    }
+    try {
+        await worktree.commitWorkingTree(`orchestration: ${item.title} — ${phase.kind} phase`, paths);
+        await worktree.merge(agentId);
+    }
+    catch (error) {
+        logger.warn('orchestration phase-runner: commit/merge failed', { itemId: item.id, phaseId: phase.id, error: summarizeError(error) });
+    }
+    return exclusion;
+}
+/** Runs one WorkItem through one Phase to completion (or cancellation/failure). Recurses (bounded by transportRetryLimit) on a transport-classified spawn failure. */
+export async function runPhase(workstream, item, phase, priorReports, deps) {
+    const startedAt = Date.now();
+    const createWorktree = deps.createWorktree ?? (() => new AgentWorktree(deps.projectRoot));
+    const worktree = createWorktree();
+    const record = deps.agentManager.spawn({
+        mode: 'spawn',
+        task: buildPhaseTask(item, phase, priorReports),
+        template: templateForPhase(phase),
+        dangerously_disable_wrfc: true,
+    });
+    record.workItemId = item.id;
+    item.agentId = record.id;
+    item.allAgentIds.push(record.id);
+    item.branch ??= `agent/${item.id}`;
+    const signal = deps.cancellation.start(item.id);
+    deps.agentManager.registerCancellationSignal(record.id, signal);
+    let outcome;
+    try {
+        outcome = await awaitAgentTermination(deps.runtimeBus, deps.agentManager, record.id);
+    }
+    finally {
+        deps.agentManager.releaseCancellationSignal(record.id);
+        deps.cancellation.release(item.id);
+    }
+    const usage = usageFromRecord(outcome.record, deps.priceUsage);
+    if (outcome.status === 'cancelled') {
+        await worktree.cleanup(record.id).catch(() => undefined);
+        return {
+            agentStatus: 'cancelled',
+            result: {
+                itemId: item.id,
+                phaseId: phase.id,
+                agentId: record.id,
+                report: genericReport('cancelled by operator'),
+                gate: { passed: false, results: [] },
+                startedAt,
+                completedAt: Date.now(),
+                usage,
+            },
+        };
+    }
+    if (outcome.status === 'failed') {
+        const transportFailure = isTransportFailureMessage(outcome.record?.error ?? '');
+        const retryLimit = getWrfcTransportRetryLimit(deps.configManager);
+        if (transportFailure && item.transportRetryCount < retryLimit) {
+            item.transportRetryCount += 1;
+            await worktree.cleanup(record.id).catch(() => undefined);
+            await sleep(getWrfcTransportRetryDelayMs(deps.configManager));
+            return runPhase(workstream, item, phase, priorReports, deps);
+        }
+        await worktree.cleanup(record.id).catch(() => undefined);
+        return {
+            agentStatus: 'failed',
+            result: {
+                itemId: item.id,
+                phaseId: phase.id,
+                agentId: record.id,
+                report: genericReport(outcome.record?.error ?? 'agent failed'),
+                gate: { passed: false, results: [] },
+                startedAt,
+                completedAt: Date.now(),
+                usage,
+            },
+        };
+    }
+    const report = parseCompletionReport(outcome.record?.fullOutput ?? '') ?? genericReport(outcome.record?.fullOutput ?? '');
+    if (report.archetype === 'engineer') {
+        const engineerReport = report;
+        for (const path of [...engineerReport.filesCreated, ...engineerReport.filesModified, ...engineerReport.filesDeleted]) {
+            if (!item.touchedPaths.includes(path))
+                item.touchedPaths.push(path);
+        }
+    }
+    const gate = await evaluateGate(workstream, phase, report, deps);
+    let commitExclusion;
+    if (gate.passed) {
+        commitExclusion = await commitPhaseWork(item, phase, record.id, worktree, deps);
+    }
+    await worktree.cleanup(record.id).catch(() => undefined);
+    return {
+        agentStatus: 'completed',
+        result: {
+            itemId: item.id,
+            phaseId: phase.id,
+            agentId: record.id,
+            report,
+            gate,
+            startedAt,
+            completedAt: Date.now(),
+            usage,
+            ...(commitExclusion ? { commitExclusion } : {}),
+        },
+    };
+}

package/dist/platform/orchestration/scheduler.d.ts

@@ -0,0 +1,45 @@
+/** SDK-owned platform module. This implementation is maintained in goodvibes-sdk. */
+/**
+ * Scheduler (Wave 4, wo701) — pure capacity-matching helpers, no side
+ * effects. The hard departure from WrfcController's pairwise
+ * engineer<->reviewer binding (startReview:883/startFix:1042): each tick,
+ * for every phase in ordinal order, free capacity slots (capacity minus
+ * in-flight) are filled from whichever waiting items are queued for that
+ * phase — an item advances the instant ITS gate passes, claimed by
+ * whatever slot happens to be free, never bound to a specific sibling item.
+ */
+import type { Phase, WorkItem, Workstream } from './types.js';
+export declare function sortedPhases(workstream: Workstream): Phase[];
+export declare function firstPhase(workstream: Workstream): Phase | undefined;
+/**
+ * The next phase in ORDINARY forward progression. Deliberately skips
+ * 'fix'-kind phases: a dynamically-inserted fix phase sits at an ordinal
+ * after its review (see engine.ts findOrInsertFixPhase) but is reachable
+ * ONLY via the explicit review-failure re-route, never as "what comes next"
+ * for an item whose review already passed — otherwise a later item that
+ * never needed fixing would wrongly detour through it.
+ */
+export declare function nextPhaseAfter(workstream: Workstream, ordinal: number): Phase | undefined;
+export declare function phaseById(workstream: Workstream, phaseId: string): Phase | undefined;
+/** The nearest preceding review-kind phase — the return target after a dynamically-inserted fix phase's gate passes. Purely structural (survives serialization with zero extra bookkeeping). */
+export declare function reviewPhaseBefore(workstream: Workstream, phase: Phase): Phase | undefined;
+export interface PhaseClaim {
+    readonly item: WorkItem;
+    readonly phase: Phase;
+}
+/**
+ * Which (item, phase) pairs have free capacity to claim RIGHT NOW. Pure —
+ * no side effects, no budget check (the caller applies budget.checkBudget
+ * before actually claiming, since budget is a *decision*, not a capacity
+ * fact this function should own).
+ *
+ * 'blocked-budget' items are deliberately included in the waiting set, not
+ * just 'pending'/'awaiting-capacity': a budget block is a recoverable
+ * decision (see BudgetCeiling/WorkItemState docs, types.ts), never a
+ * capacity fact, so a previously-blocked item must be reconsidered on every
+ * tick the instant a slot is free — the caller's budget.checkBudget call
+ * re-decides it fresh each time, honestly re-blocking it if the ceiling
+ * still refuses.
+ */
+export declare function computeClaims(workstream: Workstream): PhaseClaim[];
+//# sourceMappingURL=scheduler.d.ts.map

package/dist/platform/orchestration/scheduler.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"scheduler.d.ts","sourceRoot":"","sources":["../../../src/platform/orchestration/scheduler.ts"],"names":[],"mappings":"AAAA,qFAAqF;AAErF;;;;;;;;GAQG;AACH,OAAO,KAAK,EAAE,KAAK,EAAE,QAAQ,EAAE,UAAU,EAAE,MAAM,YAAY,CAAC;AAE9D,wBAAgB,YAAY,CAAC,UAAU,EAAE,UAAU,GAAG,KAAK,EAAE,CAE5D;AAED,wBAAgB,UAAU,CAAC,UAAU,EAAE,UAAU,GAAG,KAAK,GAAG,SAAS,CAEpE;AAED;;;;;;;GAOG;AACH,wBAAgB,cAAc,CAAC,UAAU,EAAE,UAAU,EAAE,OAAO,EAAE,MAAM,GAAG,KAAK,GAAG,SAAS,CAEzF;AAED,wBAAgB,SAAS,CAAC,UAAU,EAAE,UAAU,EAAE,OAAO,EAAE,MAAM,GAAG,KAAK,GAAG,SAAS,CAEpF;AAED,gMAAgM;AAChM,wBAAgB,iBAAiB,CAAC,UAAU,EAAE,UAAU,EAAE,KAAK,EAAE,KAAK,GAAG,KAAK,GAAG,SAAS,CAEzF;AAED,MAAM,WAAW,UAAU;IACzB,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC;IACxB,QAAQ,CAAC,KAAK,EAAE,KAAK,CAAC;CACvB;AAED;;;;;;;;;;;;;GAaG;AACH,wBAAgB,aAAa,CAAC,UAAU,EAAE,UAAU,GAAG,UAAU,EAAE,CAiBlE"}