@pellux/goodvibes-sdk 0.30.3 → 0.33.1

package/dist/platform/intelligence/facade.js

@@ -60,7 +60,7 @@ export class CodeIntelligence {
                 await this.treeSitter.initialize();
             }
             catch (err) {
-                logger.debug('CodeIntelligence: TreeSitterService init error', { error: summarizeError(err) });
+                logger.warn('CodeIntelligence: TreeSitterService init error', { error: summarizeError(err) });
             }
             return;
         }
@@ -85,14 +85,14 @@ export class CodeIntelligence {
             }
         }
         catch (err) {
-            logger.debug('CodeIntelligence: failed to load language configs', { error: summarizeError(err) });
+            logger.warn('CodeIntelligence: failed to load language configs', { error: summarizeError(err) });
         }
         // Initialize tree-sitter WASM loader.
         try {
             await this.treeSitter.initialize();
         }
         catch (err) {
-            logger.debug('CodeIntelligence: TreeSitterService init error', { error: summarizeError(err) });
+            logger.warn('CodeIntelligence: TreeSitterService init error', { error: summarizeError(err) });
         }
         // LspService has no async init; LSP servers are started on demand.
     }
@@ -102,13 +102,13 @@ export class CodeIntelligence {
             await this.lsp?.shutdown();
         }
         catch (err) {
-            logger.debug('LSP shutdown error', { error: summarizeError(err) });
+            logger.warn('LSP shutdown error', { error: summarizeError(err) });
         }
         try {
             this.treeSitter.dispose();
         }
         catch (err) {
-            logger.debug('TreeSitter dispose error', { error: summarizeError(err) });
+            logger.warn('TreeSitter dispose error', { error: summarizeError(err) });
         }
     }
     // -------------------------------------------------------------------------
@@ -156,7 +156,7 @@ export class CodeIntelligence {
             return extractSymbols(parsed.tree, parsed.language, parsed.lang);
         }
         catch (err) {
-            logger.debug('CodeIntelligence.getSymbols error', { filePath, error: summarizeError(err) });
+            logger.warn('CodeIntelligence.getSymbols error', { filePath, error: summarizeError(err) });
             return [];
         }
     }
@@ -172,7 +172,7 @@ export class CodeIntelligence {
             return extractOutline(parsed.tree, parsed.language, parsed.lang);
         }
         catch (err) {
-            logger.debug('CodeIntelligence.getOutline error', { filePath, error: summarizeError(err) });
+            logger.warn('CodeIntelligence.getOutline error', { filePath, error: summarizeError(err) });
             return [];
         }
     }
@@ -188,7 +188,7 @@ export class CodeIntelligence {
             return findEnclosingScope(parsed.tree, parsed.language, parsed.lang, line);
         }
         catch (err) {
-            logger.debug('CodeIntelligence.getEnclosingScope error', { filePath, error: summarizeError(err) });
+            logger.warn('CodeIntelligence.getEnclosingScope error', { filePath, error: summarizeError(err) });
             return null;
         }
     }
@@ -206,7 +206,7 @@ export class CodeIntelligence {
             return await this.lsp.isAvailable(lang);
         }
         catch (err) {
-            logger.debug('hasLsp error', { error: summarizeError(err) });
+            logger.warn('hasLsp error', { error: summarizeError(err) });
             return false;
         }
     }
@@ -234,7 +234,7 @@ export class CodeIntelligence {
             return result;
         }
         catch (err) {
-            logger.debug('CodeIntelligence.getDefinition error', { filePath, error: summarizeError(err) });
+            logger.warn('CodeIntelligence.getDefinition error', { filePath, error: summarizeError(err) });
             return null;
         }
     }
@@ -259,7 +259,7 @@ export class CodeIntelligence {
             return result ?? [];
         }
         catch (err) {
-            logger.debug('CodeIntelligence.getReferences error', { filePath, error: summarizeError(err) });
+            logger.warn('CodeIntelligence.getReferences error', { filePath, error: summarizeError(err) });
             return [];
         }
     }
@@ -281,7 +281,7 @@ export class CodeIntelligence {
                 }
             }
             catch (err) {
-                logger.debug('CodeIntelligence.getDocumentSymbols LSP error', { filePath, error: summarizeError(err) });
+                logger.warn('CodeIntelligence.getDocumentSymbols LSP error; falling back to tree-sitter', { filePath, error: summarizeError(err) });
             }
         }
         // Fall back to tree-sitter
@@ -306,15 +306,15 @@ export class CodeIntelligence {
             }) ?? null;
         }
         catch (err) {
-            logger.debug('CodeIntelligence.getHover error', { filePath, error: summarizeError(err) });
+            logger.warn('CodeIntelligence.getHover error', { filePath, error: summarizeError(err) });
             return null;
         }
     }
     /**
      * Get diagnostics for a file.
      * Returns empty array if LSP not available.
-     * Note: LSP pushes diagnostics via textDocument/publishDiagnostics notifications;
-     * this method is a best-effort pull (not all servers support textDocument/diagnostic).
+     * Checks queued textDocument/publishDiagnostics notifications first, then asks
+     * servers that implement textDocument/diagnostic.
      */
     async getDiagnostics(filePath) {
         const lang = detectLanguage(filePath);
@@ -325,11 +325,28 @@ export class CodeIntelligence {
             if (!client)
                 return [];
             const uri = pathToUri(filePath);
+            const diagnosticNotifications = client.takeNotifications((notification) => {
+                if (notification.method !== 'textDocument/publishDiagnostics')
+                    return false;
+                const params = notification.params;
+                return (typeof params === 'object'
+                    && params !== null
+                    && params.uri === uri);
+            });
+            for (const notification of diagnosticNotifications) {
+                const params = notification.params;
+                if (typeof params === 'object'
+                    && params !== null
+                    && params.uri === uri
+                    && Array.isArray(params.diagnostics)) {
+                    return params.diagnostics;
+                }
+            }
             const result = await client.request('textDocument/diagnostic', { textDocument: { uri } });
             return result?.items ?? [];
         }
         catch (err) {
-            logger.debug('CodeIntelligence.getDiagnostics error', { filePath, error: summarizeError(err) });
+            logger.warn('CodeIntelligence.getDiagnostics error', { filePath, error: summarizeError(err) });
             return [];
         }
     }

package/dist/platform/intelligence/import-graph.d.ts

@@ -30,6 +30,8 @@ export declare class ImportGraph {
     private scannedRoot;
     /** Whether graph is stale and needs a rebuild */
     private dirty;
+    /** Warnings from the most recent graph build. */
+    private warnings;
     constructor();
     /**
      * Mark the graph as stale. Call this whenever a file has been modified
@@ -44,7 +46,6 @@ export declare class ImportGraph {
     /**
      * Build the graph from an in-memory file map for deterministic tests.
      * Keys must be absolute file paths.
-     * @internal
      */
     buildFromFilesForTest(files: Record<string, string>): void;
     /**
@@ -59,12 +60,10 @@ export declare class ImportGraph {
     findTransitiveDependents(filePath: string): string[];
     /**
      * Return the set of files `filePath` directly imports.
-     * @internal
      */
     findImports(filePath: string): string[];
     /**
      * Return graph statistics.
-     * @internal
      */
     stats(): {
         files: number;
@@ -72,10 +71,13 @@ export declare class ImportGraph {
         scannedRoot: string | null;
         dirty: boolean;
     };
+    /**
+     * Return warnings from the most recent graph build.
+     */
+    getWarnings(): string[];
     /**
      * Export as a plain object keyed by relative paths (relative to `projectRoot`).
      * Useful for serialization and the analyze tool's `dependencies` mode.
-     * @internal
      */
     toRelativeGraph(projectRoot: string): Record<string, string[]>;
 }

package/dist/platform/intelligence/import-graph.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"import-graph.d.ts","sourceRoot":"","sources":["../../../src/platform/intelligence/import-graph.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;GAWG;AAWH,2DAA2D;AAC3D,MAAM,MAAM,aAAa,GAAG,GAAG,CAAC,MAAM,EAAE,GAAG,CAAC,MAAM,CAAC,CAAC,CAAC;AAErD,uDAAuD;AACvD,MAAM,MAAM,UAAU,GAAG,GAAG,CAAC,MAAM,EAAE,GAAG,CAAC,MAAM,CAAC,CAAC,CAAC;AAalD;;;GAGG;AACH,iBAAS,yBAAyB,CAAC,OAAO,EAAE,MAAM,GAAG,MAAM,EAAE,CAS5D;AAED,eAAO,MAAM,gCAAgC,kCAA4B,CAAC;AAuC1E,wBAAgB,uBAAuB,CACrC,QAAQ,EAAE,MAAM,EAChB,IAAI,EAAE,MAAM,EACZ,UAAU,EAAE,QAAQ,CAAC,MAAM,CAAC,GAC3B,MAAM,GAAG,IAAI,CAGf;AAoCD,qBAAa,WAAW;IACtB,2CAA2C;IAC3C,OAAO,CAAC,OAAO,CAAyB;IAExC,+CAA+C;IAC/C,OAAO,CAAC,UAAU,CAA4B;IAE9C,iCAAiC;IACjC,OAAO,CAAC,WAAW,CAAuB;IAE1C,iDAAiD;IACjD,OAAO,CAAC,KAAK,CAAQ;;IAIrB;;;OAGG;IACH,SAAS,IAAI,IAAI;IAIjB;;;OAGG;IACG,KAAK,CAAC,WAAW,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC;IAmD/C;;;;OAIG;IACH,qBAAqB,CAAC,KAAK,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,GAAG,IAAI;IA2B1D;;;OAGG;IACH,cAAc,CAAC,QAAQ,EAAE,MAAM,GAAG,MAAM,EAAE;IAI1C;;;OAGG;IACH,wBAAwB,CAAC,QAAQ,EAAE,MAAM,GAAG,MAAM,EAAE;IAiBpD;;;OAGG;IACH,WAAW,CAAC,QAAQ,EAAE,MAAM,GAAG,MAAM,EAAE;IAIvC;;;OAGG;IACH,KAAK,IAAI;QAAE,KAAK,EAAE,MAAM,CAAC;QAAC,KAAK,EAAE,MAAM,CAAC;QAAC,WAAW,EAAE,MAAM,GAAG,IAAI,CAAC;QAAC,KAAK,EAAE,OAAO,CAAA;KAAE;IAQrF;;;;OAIG;IACH,eAAe,CAAC,WAAW,EAAE,MAAM,GAAG,MAAM,CAAC,MAAM,EAAE,MAAM,EAAE,CAAC;CAQ/D"}
+{"version":3,"file":"import-graph.d.ts","sourceRoot":"","sources":["../../../src/platform/intelligence/import-graph.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;GAWG;AAWH,2DAA2D;AAC3D,MAAM,MAAM,aAAa,GAAG,GAAG,CAAC,MAAM,EAAE,GAAG,CAAC,MAAM,CAAC,CAAC,CAAC;AAErD,uDAAuD;AACvD,MAAM,MAAM,UAAU,GAAG,GAAG,CAAC,MAAM,EAAE,GAAG,CAAC,MAAM,CAAC,CAAC,CAAC;AA4BlD;;;GAGG;AACH,iBAAS,yBAAyB,CAAC,OAAO,EAAE,MAAM,GAAG,MAAM,EAAE,CAS5D;AAED,eAAO,MAAM,gCAAgC,kCAA4B,CAAC;AAiD1E,wBAAgB,uBAAuB,CACrC,QAAQ,EAAE,MAAM,EAChB,IAAI,EAAE,MAAM,EACZ,UAAU,EAAE,QAAQ,CAAC,MAAM,CAAC,GAC3B,MAAM,GAAG,IAAI,CAGf;AAqCD,qBAAa,WAAW;IACtB,2CAA2C;IAC3C,OAAO,CAAC,OAAO,CAAyB;IAExC,+CAA+C;IAC/C,OAAO,CAAC,UAAU,CAA4B;IAE9C,iCAAiC;IACjC,OAAO,CAAC,WAAW,CAAuB;IAE1C,iDAAiD;IACjD,OAAO,CAAC,KAAK,CAAQ;IAErB,iDAAiD;IACjD,OAAO,CAAC,QAAQ,CAAgB;;IAIhC;;;OAGG;IACH,SAAS,IAAI,IAAI;IAIjB;;;OAGG;IACG,KAAK,CAAC,WAAW,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC;IAyD/C;;;OAGG;IACH,qBAAqB,CAAC,KAAK,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,GAAG,IAAI;IA4B1D;;;OAGG;IACH,cAAc,CAAC,QAAQ,EAAE,MAAM,GAAG,MAAM,EAAE;IAI1C;;;OAGG;IACH,wBAAwB,CAAC,QAAQ,EAAE,MAAM,GAAG,MAAM,EAAE;IAiBpD;;OAEG;IACH,WAAW,CAAC,QAAQ,EAAE,MAAM,GAAG,MAAM,EAAE;IAIvC;;OAEG;IACH,KAAK,IAAI;QAAE,KAAK,EAAE,MAAM,CAAC;QAAC,KAAK,EAAE,MAAM,CAAC;QAAC,WAAW,EAAE,MAAM,GAAG,IAAI,CAAC;QAAC,KAAK,EAAE,OAAO,CAAA;KAAE;IAQrF;;OAEG;IACH,WAAW,IAAI,MAAM,EAAE;IAIvB;;;OAGG;IACH,eAAe,CAAC,WAAW,EAAE,MAAM,GAAG,MAAM,CAAC,MAAM,EAAE,MAAM,EAAE,CAAC;CAQ/D"}

package/dist/platform/intelligence/import-graph.js

@@ -17,6 +17,18 @@ import { summarizeError } from '../utils/error-display.js';
 const SUPPORTED_EXTENSIONS = new Set(['.ts', '.tsx', '.js', '.jsx', '.mjs', '.cjs']);
 const SKIP_DIRS = new Set(['.git', 'node_modules', 'dist', '.next', '.nuxt', '.cache', '__pycache__']);
 const MAX_FILES = 5_000;
+const MAX_WARNINGS = 20;
+function addImportGraphWarning(diagnostics, warning) {
+    if (diagnostics.warnings.includes(warning))
+        return;
+    if (diagnostics.warnings.length < MAX_WARNINGS) {
+        diagnostics.warnings.push(warning);
+        return;
+    }
+    const cappedWarning = `Additional import graph warnings suppressed after ${MAX_WARNINGS} entries.`;
+    if (!diagnostics.warnings.includes(cappedWarning))
+        diagnostics.warnings.push(cappedWarning);
+}
 // ---------------------------------------------------------------------------
 // Import extraction (line-by-line, no catastrophic backtracking)
 // ---------------------------------------------------------------------------
@@ -62,8 +74,16 @@ function resolveSpecifierFromKnownFiles(fromFile, spec, fileExists) {
     }
     return null;
 }
-function resolveSpecifier(fromFile, spec) {
-    return resolveSpecifierFromKnownFiles(fromFile, spec, (candidate) => existsSync(candidate) && statSync(candidate).isFile());
+function resolveSpecifier(fromFile, spec, diagnostics) {
+    return resolveSpecifierFromKnownFiles(fromFile, spec, (candidate) => {
+        try {
+            return existsSync(candidate) && statSync(candidate).isFile();
+        }
+        catch (err) {
+            addImportGraphWarning(diagnostics, `Could not stat import candidate '${candidate}' while resolving '${spec}' from '${fromFile}': ${summarizeError(err)}`);
+            return false;
+        }
+    });
 }
 export function resolveSpecifierForTest(fromFile, spec, knownFiles) {
     const fileSet = knownFiles instanceof Set ? knownFiles : new Set(knownFiles);
@@ -72,7 +92,7 @@ export function resolveSpecifierForTest(fromFile, spec, knownFiles) {
 // ---------------------------------------------------------------------------
 // File collection
 // ---------------------------------------------------------------------------
-function collectSourceFiles(dir, results = []) {
+function collectSourceFiles(dir, diagnostics, results = []) {
     if (results.length >= MAX_FILES)
         return results;
     let entries;
@@ -80,7 +100,8 @@ function collectSourceFiles(dir, results = []) {
         entries = readdirSync(dir, { withFileTypes: true });
     }
     catch (err) {
-        logger.debug('[import-graph] Skipping unreadable directory', { dir, error: summarizeError(err) });
+        logger.warn('[import-graph] Skipping unreadable directory', { dir, error: summarizeError(err) });
+        addImportGraphWarning(diagnostics, `Skipped unreadable directory '${dir}' while building import graph: ${summarizeError(err)}`);
         return results;
     }
     for (const entry of entries) {
@@ -90,7 +111,7 @@ function collectSourceFiles(dir, results = []) {
             continue;
         const full = join(dir, entry.name);
         if (entry.isDirectory()) {
-            collectSourceFiles(full, results);
+            collectSourceFiles(full, diagnostics, results);
         }
         else if (entry.isFile() && SUPPORTED_EXTENSIONS.has(extname(entry.name))) {
             results.push(full);
@@ -110,6 +131,8 @@ export class ImportGraph {
     scannedRoot = null;
     /** Whether graph is stale and needs a rebuild */
     dirty = true;
+    /** Warnings from the most recent graph build. */
+    warnings = [];
     constructor() { }
     /**
      * Mark the graph as stale. Call this whenever a file has been modified
@@ -125,7 +148,11 @@ export class ImportGraph {
     async build(projectRoot) {
         if (!this.dirty && this.scannedRoot === projectRoot)
             return;
-        const files = collectSourceFiles(projectRoot);
+        const diagnostics = { warnings: [] };
+        const files = collectSourceFiles(projectRoot, diagnostics);
+        if (files.length >= MAX_FILES) {
+            addImportGraphWarning(diagnostics, `Import graph scan stopped after ${MAX_FILES} source files; relationships may be incomplete.`);
+        }
         const imports = new Map();
         const dependents = new Map();
         // Ensure every file has an entry, even with no imports
@@ -141,12 +168,13 @@ export class ImportGraph {
                 content = readFileSync(filePath, 'utf-8');
             }
             catch (err) {
-                logger.debug('[import-graph] Skipping unreadable file', { file: filePath, error: summarizeError(err) });
+                logger.warn('[import-graph] Skipping unreadable file', { file: filePath, error: summarizeError(err) });
+                addImportGraphWarning(diagnostics, `Skipped unreadable file '${filePath}' while building import graph: ${summarizeError(err)}`);
                 continue;
             }
             const specs = extractRelativeSpecifiers(content);
             for (const spec of specs) {
-                const resolved = resolveSpecifier(filePath, spec);
+                const resolved = resolveSpecifier(filePath, spec, diagnostics);
                 if (!resolved)
                     continue;
                 // Forward
@@ -169,11 +197,11 @@ export class ImportGraph {
         this.dependents = dependents;
         this.scannedRoot = projectRoot;
         this.dirty = false;
+        this.warnings = diagnostics.warnings;
     }
     /**
      * Build the graph from an in-memory file map for deterministic tests.
      * Keys must be absolute file paths.
-     * @internal
      */
     buildFromFilesForTest(files) {
         const knownFiles = new Set(Object.keys(files));
@@ -189,14 +217,15 @@ export class ImportGraph {
                 const resolved = resolveSpecifierFromKnownFiles(filePath, spec, (candidate) => knownFiles.has(candidate));
                 if (!resolved)
                     continue;
-                imports.get(filePath).add(resolved);
-                dependents.get(resolved).add(filePath);
+                imports.get(filePath)?.add(resolved);
+                dependents.get(resolved)?.add(filePath);
             }
         }
         this.imports = imports;
         this.dependents = dependents;
         this.scannedRoot = null;
         this.dirty = false;
+        this.warnings = [];
     }
     /**
      * Return all files that directly import `filePath`.
@@ -225,14 +254,12 @@ export class ImportGraph {
     }
     /**
      * Return the set of files `filePath` directly imports.
-     * @internal
      */
     findImports(filePath) {
         return Array.from(this.imports.get(filePath) ?? []);
     }
     /**
      * Return graph statistics.
-     * @internal
      */
     stats() {
         let edges = 0;
@@ -241,10 +268,15 @@ export class ImportGraph {
         }
         return { files: this.imports.size, edges, scannedRoot: this.scannedRoot, dirty: this.dirty };
     }
+    /**
+     * Return warnings from the most recent graph build.
+     */
+    getWarnings() {
+        return [...this.warnings];
+    }
     /**
      * Export as a plain object keyed by relative paths (relative to `projectRoot`).
      * Useful for serialization and the analyze tool's `dependencies` mode.
-     * @internal
      */
     toRelativeGraph(projectRoot) {
         const result = {};

package/dist/platform/intelligence/lsp/binary-downloader.js

@@ -65,17 +65,17 @@ function isBinaryCached(binaryDir, name) {
 async function downloadBinary(binaryDir, name) {
     const spec = BINARY_SPECS.find(s => s.name === name);
     if (!spec) {
-        logger.debug(`BinaryDownloader: unknown binary '${name}'`);
+        logger.warn(`BinaryDownloader: unknown binary '${name}'`);
         return null;
     }
     const platformKey = getPlatformKey();
     if (!platformKey) {
-        logger.debug(`BinaryDownloader: unsupported platform ${process.platform}/${process.arch}`);
+        logger.warn(`BinaryDownloader: unsupported platform ${process.platform}/${process.arch}`);
         return null;
     }
     const assetName = spec.assets[platformKey];
     if (!assetName) {
-        logger.debug(`BinaryDownloader: no asset for ${name} on ${platformKey}`);
+        logger.warn(`BinaryDownloader: no asset for ${name} on ${platformKey}`);
         return null;
     }
     const destPath = getBinaryPath(binaryDir, name);
@@ -96,18 +96,18 @@ async function downloadBinary(binaryDir, name) {
                 logger.info('BinaryDownloader: GitHub API rate limited (60 req/hr unauthenticated). Set GITHUB_TOKEN env var for higher limits.', { name });
             }
             else {
-                logger.debug(`BinaryDownloader: GitHub API returned ${releaseRes.status} for ${name}`);
+                logger.warn(`BinaryDownloader: GitHub API returned ${releaseRes.status} for ${name}`);
             }
             return null;
         }
         const release = await releaseRes.json();
         if (!release || !Array.isArray(release.assets)) {
-            logger.debug('BinaryDownloader: unexpected GitHub API response shape', { name });
+            logger.warn('BinaryDownloader: unexpected GitHub API response shape', { name });
             return null;
         }
         const asset = release.assets.find(a => a.name === assetName);
         if (!asset) {
-            logger.debug(`BinaryDownloader: asset '${assetName}' not found in latest release of ${spec.repo}`);
+            logger.warn(`BinaryDownloader: asset '${assetName}' not found in latest release of ${spec.repo}`);
             return null;
         }
         // Download the asset
@@ -116,7 +116,7 @@ async function downloadBinary(binaryDir, name) {
             headers: { 'User-Agent': 'goodvibes-sdk' },
         });
         if (!downloadRes.ok) {
-            logger.debug(`BinaryDownloader: download failed with ${downloadRes.status}`);
+            logger.warn(`BinaryDownloader: download failed with ${downloadRes.status}`);
             return null;
         }
         // Fetch the raw bytes first so we can verify SHA256 before decompression
@@ -129,7 +129,7 @@ async function downloadBinary(binaryDir, name) {
                 headers: { 'User-Agent': 'goodvibes-sdk' },
             });
             if (sha256Res.ok) {
-                const expectedHash = (await sha256Res.text()).trim().split(/\s+/)[0]; // format: "hash  filename"
+                const expectedHash = ((await sha256Res.text()).trim().split(/\s+/)[0]) ?? ''; // format: "hash  filename"
                 if (!/^[a-f0-9]{64}$/.test(expectedHash)) {
                     logger.info('BinaryDownloader: SHA256 sidecar has malformed hash, skipping verification', { name, raw: expectedHash?.slice(0, 80) });
                 }
@@ -175,7 +175,7 @@ async function downloadBinary(binaryDir, name) {
         return destPath;
     }
     catch (err) {
-        logger.debug(`BinaryDownloader: failed to download ${name}`, { error: summarizeError(err) });
+        logger.warn(`BinaryDownloader: failed to download ${name}`, { error: summarizeError(err) });
         // Clean up partial download
         const tmpPath = `${destPath}.tmp`;
         try {
@@ -205,7 +205,7 @@ async function ensureGopls(binaryDir) {
     // Check if go is available
     const goPath = Bun.which('go');
     if (!goPath) {
-        logger.debug('BinaryDownloader: go not found on PATH, cannot install gopls');
+        logger.warn('BinaryDownloader: go not found on PATH, cannot install gopls');
         return null;
     }
     logger.info('BinaryDownloader: installing gopls via go install...');
@@ -219,7 +219,7 @@ async function ensureGopls(binaryDir) {
         const exitCode = await proc.exited;
         if (exitCode !== 0) {
             const stderr = await new Response(proc.stderr).text();
-            logger.debug('BinaryDownloader: gopls install failed', { exitCode, stderr: stderr.slice(0, 500) });
+            logger.warn('BinaryDownloader: gopls install failed', { exitCode, stderr: stderr.slice(0, 500) });
             return null;
         }
         if (existsSync(destPath)) {
@@ -229,7 +229,7 @@ async function ensureGopls(binaryDir) {
         return null;
     }
     catch (err) {
-        logger.debug('BinaryDownloader: gopls install error', { error: summarizeError(err) });
+        logger.warn('BinaryDownloader: gopls install error', { error: summarizeError(err) });
         return null;
     }
 }

package/dist/platform/intelligence/lsp/client.d.ts

@@ -1,3 +1,8 @@
+export interface LspNotificationRecord {
+    readonly method: string;
+    readonly params?: unknown | undefined;
+    readonly receivedAt: number;
+}
 export declare class LspClient {
     private command;
     private args;
@@ -5,10 +10,11 @@ export declare class LspClient {
     private proc;
     private nextId;
     private pendingRequests;
+    private readonly notifications;
     private buffer;
     private readLoopRunning;
     constructor(command: string, args: string[], options?: {
-        cwd?: string;
+        cwd?: string | undefined;
         env?: Record<string, string>;
         timeout?: number;
     } | undefined);
@@ -18,6 +24,7 @@ export declare class LspClient {
     request<T = unknown>(method: string, params?: unknown): Promise<T>;
     /** Send a notification (no response expected). */
     notify(method: string, params?: unknown): void;
+    takeNotifications(predicate: (notification: LspNotificationRecord) => boolean): LspNotificationRecord[];
     /** Stop the server process. */
     stop(): Promise<void>;
     /** Is the server running? */

package/dist/platform/intelligence/lsp/client.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"client.d.ts","sourceRoot":"","sources":["../../../../src/platform/intelligence/lsp/client.ts"],"names":[],"mappings":"AAYA,qBAAa,SAAS;IAQlB,OAAO,CAAC,OAAO;IACf,OAAO,CAAC,IAAI;IACZ,OAAO,CAAC,OAAO,CAAC;IATlB,OAAO,CAAC,IAAI,CAA6C;IACzD,OAAO,CAAC,MAAM,CAAK;IACnB,OAAO,CAAC,eAAe,CAA0C;IACjE,OAAO,CAAC,MAAM,CAAM;IACpB,OAAO,CAAC,eAAe,CAAS;gBAGtB,OAAO,EAAE,MAAM,EACf,IAAI,EAAE,MAAM,EAAE,EACd,OAAO,CAAC,EAAE;QAAE,GAAG,CAAC,EAAE,MAAM,CAAC;QAAC,GAAG,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;QAAC,OAAO,CAAC,EAAE,MAAM,CAAA;KAAE,YAAA;IAGpF,oCAAoC;IAC9B,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC;IAkB5B,4CAA4C;IACtC,OAAO,CAAC,CAAC,GAAG,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC,EAAE,OAAO,GAAG,OAAO,CAAC,CAAC,CAAC;IAiCxE,kDAAkD;IAClD,MAAM,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC,EAAE,OAAO,GAAG,IAAI;IAY9C,+BAA+B;IACzB,IAAI,IAAI,OAAO,CAAC,IAAI,CAAC;IAqB3B,6BAA6B;IAC7B,IAAI,SAAS,IAAI,OAAO,CAQvB;IAMD,OAAO,CAAC,cAAc;IA8BtB,OAAO,CAAC,cAAc;IA4BtB,OAAO,CAAC,gBAAgB;IA2BxB,6EAA6E;IAC7E,MAAM,CAAC,WAAW,CAAC,IAAI,EAAE,MAAM,GAAG,MAAM;IAKxC,sGAAsG;IACtG,MAAM,CAAC,aAAa,CAAC,MAAM,EAAE,MAAM,GAAG,CAAC,OAAO,EAAE,EAAE,MAAM,CAAC;CAiC1D"}
+{"version":3,"file":"client.d.ts","sourceRoot":"","sources":["../../../../src/platform/intelligence/lsp/client.ts"],"names":[],"mappings":"AAUA,MAAM,WAAW,qBAAqB;IACpC,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAC;IACxB,QAAQ,CAAC,MAAM,CAAC,EAAE,OAAO,GAAG,SAAS,CAAC;IACtC,QAAQ,CAAC,UAAU,EAAE,MAAM,CAAC;CAC7B;AAKD,qBAAa,SAAS;IASlB,OAAO,CAAC,OAAO;IACf,OAAO,CAAC,IAAI;IACZ,OAAO,CAAC,OAAO,CAAC;IAVlB,OAAO,CAAC,IAAI,CAA6C;IACzD,OAAO,CAAC,MAAM,CAAK;IACnB,OAAO,CAAC,eAAe,CAA0C;IACjE,OAAO,CAAC,QAAQ,CAAC,aAAa,CAA+B;IAC7D,OAAO,CAAC,MAAM,CAAM;IACpB,OAAO,CAAC,eAAe,CAAS;gBAGtB,OAAO,EAAE,MAAM,EACf,IAAI,EAAE,MAAM,EAAE,EACd,OAAO,CAAC,EAAE;QAAE,GAAG,CAAC,EAAE,MAAM,GAAG,SAAS,CAAC;QAAC,GAAG,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;QAAC,OAAO,CAAC,EAAE,MAAM,CAAA;KAAE,YAAA;IAGhG,oCAAoC;IAC9B,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC;IAkB5B,4CAA4C;IACtC,OAAO,CAAC,CAAC,GAAG,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC,EAAE,OAAO,GAAG,OAAO,CAAC,CAAC,CAAC;IAiCxE,kDAAkD;IAClD,MAAM,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC,EAAE,OAAO,GAAG,IAAI;IAY9C,iBAAiB,CAAC,SAAS,EAAE,CAAC,YAAY,EAAE,qBAAqB,KAAK,OAAO,GAAG,qBAAqB,EAAE;IAevG,+BAA+B;IACzB,IAAI,IAAI,OAAO,CAAC,IAAI,CAAC;IAsB3B,6BAA6B;IAC7B,IAAI,SAAS,IAAI,OAAO,CAQvB;IAMD,OAAO,CAAC,cAAc;IA8BtB,OAAO,CAAC,cAAc;IA4BtB,OAAO,CAAC,gBAAgB;IAoDxB,6EAA6E;IAC7E,MAAM,CAAC,WAAW,CAAC,IAAI,EAAE,MAAM,GAAG,MAAM;IAKxC,sGAAsG;IACtG,MAAM,CAAC,aAAa,CAAC,MAAM,EAAE,MAAM,GAAG,CAAC,OAAO,EAAE,EAAE,MAAM,CAAC;CAiC1D"}

package/dist/platform/intelligence/lsp/client.js

@@ -1,6 +1,7 @@
 import { logger } from '../../utils/logger.js';
 import { summarizeError } from '../../utils/error-display.js';
 const DEFAULT_TIMEOUT_MS = 30_000;
+const MAX_QUEUED_NOTIFICATIONS = 500;
 export class LspClient {
     command;
     args;
@@ -8,6 +9,7 @@ export class LspClient {
     proc = null;
     nextId = 1;
     pendingRequests = new Map();
+    notifications = [];
     buffer = '';
     readLoopRunning = false;
     constructor(command, args, options) {
@@ -24,8 +26,8 @@ export class LspClient {
                 stdin: 'pipe',
                 stdout: 'pipe',
                 stderr: 'pipe',
-                cwd: this.options?.cwd,
-                env: this.options?.env ? { ...process.env, ...this.options.env } : undefined,
+                ...(this.options?.cwd !== undefined ? { cwd: this.options.cwd } : {}),
+                ...(this.options?.env !== undefined ? { env: { ...process.env, ...this.options.env } } : {}),
             });
             this._startReadLoop();
         }
@@ -57,7 +59,7 @@ export class LspClient {
                 timer,
             });
             try {
-                this.proc.stdin.write(frame);
+                this.proc?.stdin?.write(frame);
             }
             catch (err) {
                 clearTimeout(timer);
@@ -80,6 +82,21 @@ export class LspClient {
             logger.error('LspClient: failed to send notification', { method, err: summarizeError(err) });
         }
     }
+    takeNotifications(predicate) {
+        const taken = [];
+        const retained = [];
+        for (const notification of this.notifications) {
+            if (predicate(notification)) {
+                taken.push(notification);
+            }
+            else {
+                retained.push(notification);
+            }
+        }
+        this.notifications.length = 0;
+        this.notifications.push(...retained);
+        return taken;
+    }
     /** Stop the server process. */
     async stop() {
         if (!this.proc)
@@ -95,12 +112,13 @@ export class LspClient {
             this.proc.kill();
             await this.proc.exited;
         }
-        catch {
-            // Ignore errors during shutdown
+        catch (err) {
+            logger.warn('LspClient: shutdown cleanup failed', { err: summarizeError(err) });
         }
         finally {
             this.proc = null;
             this.buffer = '';
+            this.notifications.length = 0;
             this.readLoopRunning = false;
         }
     }
@@ -137,7 +155,7 @@ export class LspClient {
                 }
             }
             catch (err) {
-                logger.debug('LspClient: stdout read loop ended', { err: summarizeError(err) });
+                logger.warn('LspClient: stdout read loop failed', { err: summarizeError(err) });
             }
             finally {
                 this.readLoopRunning = false;
@@ -183,8 +201,10 @@ export class LspClient {
             logger.error('LspClient: failed to parse JSON-RPC message', { err: summarizeError(err), body: body.slice(0, 200) });
             return;
         }
-        if (typeof msg !== 'object' || msg === null)
+        if (typeof msg !== 'object' || msg === null) {
+            logger.warn('LspClient: received malformed JSON-RPC payload', { payloadType: typeof msg });
             return;
+        }
         const response = msg;
         if ('id' in response && typeof response.id === 'number') {
             const pending = this.pendingRequests.get(response.id);
@@ -198,8 +218,29 @@ export class LspClient {
                     pending.resolve(response.result);
                 }
             }
+            else {
+                logger.warn('LspClient: received response for unknown request id', { id: response.id });
+            }
+            return;
+        }
+        const notification = msg;
+        if (notification.jsonrpc === '2.0' && typeof notification.method === 'string') {
+            if (this.notifications.length >= MAX_QUEUED_NOTIFICATIONS) {
+                const evicted = this.notifications.shift();
+                logger.warn('LspClient: evicted queued notification after capacity limit', {
+                    evictedMethod: evicted?.method,
+                    capacity: MAX_QUEUED_NOTIFICATIONS,
+                });
+            }
+            this.notifications.push({
+                method: notification.method,
+                ...(notification.params !== undefined ? { params: notification.params } : {}),
+                receivedAt: Date.now(),
+            });
+            logger.debug('LspClient: received notification', { method: notification.method });
+            return;
         }
-        // Notifications (no id) are silently ignored for now
+        logger.warn('LspClient: received unrecognized JSON-RPC message', { message: msg });
     }
     /** Encode a JSON-RPC frame (Content-Length framing). Exposed for testing. */
     static encodeFrame(json) {

package/dist/platform/intelligence/lsp/index.d.ts

@@ -1,6 +1,7 @@
 export type { JsonRpcRequest, JsonRpcResponse, JsonRpcNotification, Position, Range, Location, DocumentSymbol, Diagnostic, Hover, InitializeParams, TextDocumentIdentifier, TextDocumentPositionParams, } from './protocol.js';
 export { SymbolKind } from './protocol.js';
 export { LspClient } from './client.js';
+export type { LspNotificationRecord } from './client.js';
 export { LspService } from './service.js';
 export type { LspServerConfig } from './service.js';
 export { parseCapabilities, hasCapability } from './capabilities.js';

package/dist/platform/intelligence/lsp/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../../src/platform/intelligence/lsp/index.ts"],"names":[],"mappings":"AAAA,YAAY,EACV,cAAc,EACd,eAAe,EACf,mBAAmB,EACnB,QAAQ,EACR,KAAK,EACL,QAAQ,EACR,cAAc,EACd,UAAU,EACV,KAAK,EACL,gBAAgB,EAChB,sBAAsB,EACtB,0BAA0B,GAC3B,MAAM,eAAe,CAAC;AACvB,OAAO,EAAE,UAAU,EAAE,MAAM,eAAe,CAAC;AAC3C,OAAO,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AACxC,OAAO,EAAE,UAAU,EAAE,MAAM,cAAc,CAAC;AAC1C,YAAY,EAAE,eAAe,EAAE,MAAM,cAAc,CAAC;AACpD,OAAO,EAAE,iBAAiB,EAAE,aAAa,EAAE,MAAM,mBAAmB,CAAC;AACrE,YAAY,EAAE,eAAe,EAAE,MAAM,mBAAmB,CAAC"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../../src/platform/intelligence/lsp/index.ts"],"names":[],"mappings":"AAAA,YAAY,EACV,cAAc,EACd,eAAe,EACf,mBAAmB,EACnB,QAAQ,EACR,KAAK,EACL,QAAQ,EACR,cAAc,EACd,UAAU,EACV,KAAK,EACL,gBAAgB,EAChB,sBAAsB,EACtB,0BAA0B,GAC3B,MAAM,eAAe,CAAC;AACvB,OAAO,EAAE,UAAU,EAAE,MAAM,eAAe,CAAC;AAC3C,OAAO,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AACxC,YAAY,EAAE,qBAAqB,EAAE,MAAM,aAAa,CAAC;AACzD,OAAO,EAAE,UAAU,EAAE,MAAM,cAAc,CAAC;AAC1C,YAAY,EAAE,eAAe,EAAE,MAAM,cAAc,CAAC;AACpD,OAAO,EAAE,iBAAiB,EAAE,aAAa,EAAE,MAAM,mBAAmB,CAAC;AACrE,YAAY,EAAE,eAAe,EAAE,MAAM,mBAAmB,CAAC"}