@pellux/goodvibes-daemon 1.28.19 → 1.28.21

package/src/runtime/trust/checkpoint-eligibility.ts

@@ -23,7 +23,7 @@ import {
  *
  * This read is synchronous by design. The decision is made per lifecycle event,
  * inside a subscription callback that cannot await, and it has to reflect the
- * store as it is on disk RIGHT NOW — registering a workspace while the daemon is
+ * store as it is on disk RIGHT NOW, registering a workspace while the daemon is
  * running has to take effect on the next eligible event, not on the next
  * restart. The SDK's resolver is pure, so the only I/O is one small JSON read
  * plus a single git worktree probe amortized at construction.
@@ -32,13 +32,13 @@ import {
 export type StoreShellPaths = Pick<ShellPathService, 'resolveUserPath' | 'homeDirectory'>;
 
 /**
- * Path of the shared store's JSON document — the same path the SDK's gateway
+ * Path of the shared store's JSON document, the same path the SDK's gateway
  * verb group constructs its own store over.
  *
  * "The same path" is the whole contract, and it is why this goes through the
  * SDK's resolver rather than spelling any location out. goodvibes-agent reads
  * and writes this same file directly and the SDK's gateway writes it, so the
- * register is cross-product state rather than the daemon's own — it lives in
+ * register is cross-product state rather than the daemon's own, it lives in
  * the shared tier (~/.goodvibes/shared/), which takes no surface root, so all
  * three resolve one identical path. Until the boot fold has moved it, the
  * resolver falls back to the pre-split location read-only, so this reader never
@@ -92,7 +92,7 @@ interface SharedRegistrationSnapshot {
 /**
  * Synchronous read of the shared store's on-disk JSON, mirroring the store's own
  * validation exactly (version 1, workspaces[], declines[]). A missing or
- * unparsable file reads as empty — never throws.
+ * unparsable file reads as empty, never throws.
  */
 export function readSharedWorkspaceRegistrationSnapshotSync(shellPaths: StoreShellPaths): SharedRegistrationSnapshot {
   const path = sharedWorkspaceRegistrationStorePath(shellPaths);
@@ -116,7 +116,7 @@ export function readSharedWorkspaceRegistrationSnapshotSync(shellPaths: StoreShe
 }
 
 /**
- * Resolve `path` against ONLY the checkpoint-eligible registrations — the
+ * Resolve `path` against ONLY the checkpoint-eligible registrations, the
  * boundary the automatic and explicit checkpoint gates consume. Worktree-link
  * inheritance still applies: a linked worktree of a checkpoint-eligible main
  * repository resolves as covered.

package/src/runtime/trust/trust-gated-approvals.ts

@@ -1,11 +1,11 @@
 /**
- * trust-gated-approvals.ts — how a headless daemon asks the workspace trust
+ * trust-gated-approvals.ts, how a headless daemon asks the workspace trust
  * question, and how the answer reaches the runs it hosts.
  *
  * The terminal app composes the trust gate at the permission machinery's final
  * ask layer and raises the question as a modal on its own screen. The daemon
- * has the same gate — `trustGatedAsk` next door, reading the same
- * `<cwd>/.goodvibes/<surface>/trust.json` the terminal app writes — and no
+ * has the same gate, `trustGatedAsk` next door, reading the same
+ * `<cwd>/.goodvibes/<surface>/trust.json` the terminal app writes, and no
  * screen to raise anything on. Before this module it therefore
  * did neither: the gate was constructed, never loaded, never consulted, and no
  * hosted run passed through it.
@@ -16,7 +16,7 @@
  *     ordinary approval record. That is the whole point of the approval-raise
  *     path: a process with no screen states the question, publishes it on
  *     `approval-update`, and whichever surface is attached answers it. Approved
- *     means "trusted", denied means "restricted" — a real decision either way,
+ *     means "trusted", denied means "restricted", a real decision either way,
  *     persisted by the gate, and never asked again for this workspace.
  *
  *  2. `trustGatedApprovalRaiser` puts the gate in front of the raiser the
@@ -30,8 +30,8 @@
  *
  * What the daemon does NOT do here is decide by default. An untrusted
  * workspace's hosted run neither runs as if trusted nor fails as if refused: it
- * asks. If the ask cannot be answered — nothing attached, or the broker itself
- * failed — the workspace stays undecided and this run is refused, with the
+ * asks. If the ask cannot be answered, nothing attached, or the broker itself
+ * failed, the workspace stays undecided and this run is refused, with the
  * reason in the log rather than in a silence. A refusal that records nothing is
  * the failure mode this whole seam exists to remove.
  */
@@ -44,7 +44,7 @@ type WorkspaceTrustLevel = operations.WorkspaceTrustLevel;
 type WorkspaceTrustManager = operations.WorkspaceTrustManager;
 
 /**
- * The extra fields a raise carries beside the request itself — the attribution
+ * The extra fields a raise carries beside the request itself, the attribution
  * routing/metadata a background-agent ask is stamped with before it reaches the
  * broker. The gate only reads `request.category`, so these ride around it.
  */
@@ -73,7 +73,7 @@ export const WORKSPACE_TRUST_ASK_TIMEOUT_MS = 10 * 60 * 1000;
 
 export interface WorkspaceTrustDecisionAskDeps {
   readonly requestApproval: ApprovalRaise;
-  /** The workspace the question is about — it names the directory being trusted. */
+  /** The workspace the question is about, it names the directory being trusted. */
   readonly workingDirectory: string;
   readonly timeoutMs?: number | undefined;
 }
@@ -118,7 +118,7 @@ export function createWorkspaceTrustDecisionAsk(
       return decision.approved ? 'trusted' : 'restricted';
     } catch (error) {
       // Nothing attached, or the broker failed. Say so and leave the workspace
-      // undecided — the next run asks again rather than inheriting a decision
+      // undecided, the next run asks again rather than inheriting a decision
       // nobody made.
       logger.warn('Workspace trust question could not be answered; this run is refused and the workspace stays undecided', {
         workspace: deps.workingDirectory,

package/src/runtime/update-check.ts

@@ -4,7 +4,7 @@
  *
  * Version comparison and the release-tag lookup are re-exported from the
  * SDK's canonical update policy module (platform/runtime/self-update), which
- * was hoisted from this file's semantics — one mechanism everywhere.
+ * was hoisted from this file's semantics, one mechanism everywhere.
  * Install-kind detection stays local: it encodes how THIS package is
  * installed (compiled binary vs bun/npm package vs source run) and what
  * command replaces a swap for each kind.
@@ -27,14 +27,14 @@ export {
  * How this running process was installed, detected honestly from
  * process.execPath rather than assumed:
  *   - "binary": a standalone `bun build --compile` executable with no
- *     package-manager ancestry — the scripts/install.sh install path.
+ *     package-manager ancestry, the scripts/install.sh install path.
  *     Swappable in place.
  *   - "bun-global-package": running the vendored binary shipped inside an
  *     npm/bun-managed package install (execPath contains a "node_modules"
- *     path segment — true for both `bun add -g` and a local project
+ *     path segment, true for both `bun add -g` and a local project
  *     dependency). Managed by the package manager; swapping the vendored
  *     file in place would fight the next `bun add -g` upgrade, so this is
- *     never swapped — the user re-runs their package manager instead.
+ *     never swapped, the user re-runs their package manager instead.
  *   - "source": running directly via the `bun` interpreter (`bun run
  *     src/main.ts`), not a compiled binary at all.
  */

package/src/runtime/workspace-checkpointing.ts

@@ -17,19 +17,19 @@ import { createWorkspaceRegistrationLiveChecker, type StoreShellPaths } from './
  * runtime bus, so building it without one for an unregistered workspace would
  * mean registering that workspace mid-run had no effect until a restart. It is
  * always built WITH the bus and each individual automatic snapshot attempt is
- * refused instead — by overriding this one instance's own `create`, since the
+ * refused instead, by overriding this one instance's own `create`, since the
  * manager has no predicate hook and `create` is the single seam both the
  * automatic subscription and every explicit caller pass through.
  */
 
 export interface WorkspaceCheckpointing {
-  /** The manager itself — automatic snapshots gated, explicit creates unrestricted. */
+  /** The manager itself, automatic snapshots gated, explicit creates unrestricted. */
   readonly manager: WorkspaceCheckpointManager;
   /**
    * The narrower surface handed to the `checkpoints.*` gateway verbs: identical
    * except that an explicit create refuses, with an actionable message, when the
    * workspace is not checkpoint-eligible. Reads (list/diff/sessionChanges) and
-   * restore stay unrestricted — they operate over checkpoints that may already
+   * restore stay unrestricted, they operate over checkpoints that may already
    * exist, including from a since-unregistered workspace.
    */
   readonly gatewayManager: Pick<WorkspaceCheckpointManager, 'list' | 'create' | 'diff' | 'restore' | 'sessionChanges' | 'workspaceRoot'>;
@@ -69,7 +69,7 @@ export function createWorkspaceCheckpointing(opts: {
   });
 
   // Automatic snapshots ('turn' | 'agent-run', fired by the manager's own bus
-  // subscription) resolve to null quietly when the workspace is not eligible —
+  // subscription) resolve to null quietly when the workspace is not eligible,
   // there is no caller to throw to, and the manager already documents a null
   // return as the cheap no-op for an unchanged tree. Explicit ('manual') creates
   // are NOT re-gated here: they go through the gateway surface below, which
@@ -82,7 +82,7 @@ export function createWorkspaceCheckpointing(opts: {
 
   // Eagerly initialize so the automatic-snapshot subscription is live before the
   // first turn completes. If init() rejects, the manager caches that rejection
-  // forever and every later call re-throws it — the catch here only prevents an
+  // forever and every later call re-throws it, the catch here only prevents an
   // unhandled rejection at startup; the checkpoint verbs report the failure to
   // whoever calls them.
   void manager.init().catch((error: unknown) => {
@@ -104,7 +104,7 @@ export function createWorkspaceCheckpointing(opts: {
         );
       }
       // Default the session stamp from the live resolver when the caller omits
-      // it — the resolveSessionId hook only auto-stamps automatic snapshots, so
+      // it, the resolveSessionId hook only auto-stamps automatic snapshots, so
       // without this an explicit checkpoint made this launch would be written
       // unstamped and excluded by the session-scoped restore lookup.
       const sessionId = createOpts.sessionId ?? opts.resolveSessionId?.({});

package/src/testing/daemon-fixture.ts

@@ -1,5 +1,5 @@
 /**
- * daemon-fixture.ts — a real, running daemon, composed the way this product
+ * daemon-fixture.ts, a real, running daemon, composed the way this product
  * composes one, for a test to drive.
  *
  * ── Why this is a shipped module and not a test helper ────────────────────
@@ -8,7 +8,7 @@
  * and each of them hand-builds a composition to test against: a stub session
  * broker here, a fake approval broker there, a catalog with the handlers
  * somebody remembered to attach. They are large (several hundred lines each),
- * they duplicate each other, and — the part that matters — they are each a
+ * they duplicate each other, and, the part that matters, they are each a
  * SECOND idea of what a daemon is. A client contract test passing against a
  * hand-rolled stand-in tells you the stand-in agrees with the client, which is
  * the one agreement that was never in doubt.
@@ -43,19 +43,19 @@
  * can do for itself:
  *
  *   1. A NAMED ENTRY POINT. `goodvibes-daemon/testing` instead of the deep
- *      path. That means adding an `exports` map to package.json — and adding
+ *      path. That means adding an `exports` map to package.json, and adding
  *      one is not additive: an `exports` map REPLACES path-based resolution, so
  *      every existing deep import into this package (its own `bin` shim
  *      included) stops resolving unless the map enumerates them. That is a
  *      packaging change with a blast radius, made once, deliberately, by
- *      whoever owns distribution — not a side effect of adding a test helper.
+ *      whoever owns distribution, not a side effect of adding a test helper.
  *
  *   2. THE CONSUMER DEPENDENCY. A consumer repo has to depend on
  *      `goodvibes-daemon` to import this at all. Today the agent does (it is
  *      what makes its own install fail against an unpublished version); the
  *      terminal app and the webui do not. For the terminal app that is a
  *      devDependency and a version pin. For the webui, whose suites run in a
- *      browser context, the fixture cannot run in-process at all — it needs a
+ *      browser context, the fixture cannot run in-process at all, it needs a
  *      launcher script that starts the fixture in a node process and hands the
  *      Playwright suite `baseUrl` and `token`. That launcher does not exist and
  *      should be written on the webui side, where its runner lives.
@@ -65,12 +65,12 @@
  *      per test file pays about a second each and must `stop()` every one; the
  *      three hand-built stand-ins it replaces cost nothing and leak nothing.
  *      The honest guidance is one fixture per FILE (`beforeAll`/`afterAll`),
- *      which is how this repository's own suites use it — not one per test.
+ *      which is how this repository's own suites use it, not one per test.
  *
  *   4. WHAT IT DOES NOT REPLACE. A stand-in is still the right tool for
  *      driving a client through a daemon state that is hard to reach for real:
  *      a wedged session, a specific 500, a torn connection. This fixture
- *      replaces the stand-ins that exist only to answer normally — which is
+ *      replaces the stand-ins that exist only to answer normally, which is
  *      most of the several hundred lines in each consumer, and all of the part
  *      that silently drifts. The refusal shapes it cannot easily produce live
  *      are exported separately and pinned against the real engine; see
@@ -145,7 +145,7 @@ export interface DaemonFixtureOptions {
 }
 
 export interface DaemonFixture {
-  /** The composed runtime graph — the same object `DaemonServer` was handed. */
+  /** The composed runtime graph, the same object `DaemonServer` was handed. */
   readonly services: RuntimeServices;
   /** The running server. */
   readonly daemon: DaemonServer;
@@ -159,7 +159,7 @@ export interface DaemonFixture {
   fetch(path: string, init?: RequestInit): Promise<Response>;
   /**
    * Fetch a path with NO credential. A route that exists answers 401; a path
-   * nothing serves answers 404 — which is what makes this the side-effect-free
+   * nothing serves answers 404, which is what makes this the side-effect-free
    * way to ask whether a route exists, even for a write verb.
    */
   fetchAnonymous(path: string, init?: RequestInit): Promise<Response>;
@@ -170,7 +170,7 @@ export interface DaemonFixture {
 }
 
 /**
- * Compose and start a daemon. Always `await fixture.stop()` — the runtime graph
+ * Compose and start a daemon. Always `await fixture.stop()`, the runtime graph
  * starts pollers while it builds, and abandoning it leaves every one of them
  * firing for the rest of the process.
  */
@@ -234,7 +234,7 @@ export async function startDaemonFixture(options: DaemonFixtureOptions = {}): Pr
     // What the real entrypoint states, for the same reason it states it: the
     // hosted-session verbs are registered by this composition and by nothing
     // else, so a fixture that leaves it out is a daemon a client cannot start a
-    // session on — and every contract test written against it would agree.
+    // session on, and every contract test written against it would agree.
     ...(options.hostSessions === false ? {} : { hostedSessions: createHostedSessionOptions(services) }),
   });
 

package/src/testing/hosted-session-failures.ts

@@ -1,5 +1,5 @@
 /**
- * hosted-session-failures.ts — what `sessions.hosted.*` answers when it refuses.
+ * hosted-session-failures.ts, what `sessions.hosted.*` answers when it refuses.
  *
  * ── Why this is a shipped module ─────────────────────────────────────────
  *
@@ -19,7 +19,7 @@
  * These are the three refusals a client has to handle and could not previously
  * mock. They are declared here rather than hand-written in each consumer, and
  * `src/test/daemon/gateway-hosted-session-failures.test.ts` drives the REAL
- * engine to produce each one and asserts it still matches — so a fixture that
+ * engine to produce each one and asserts it still matches, so a fixture that
  * drifts from the daemon fails in this repository, not in a consumer's CI six
  * weeks later.
  */
@@ -28,7 +28,7 @@
 export interface HostedSessionFailureFixture {
   /** The verb whose refusal this is. */
   readonly methodId: string;
-  /** Machine-readable code — the field a client branches on. */
+  /** Machine-readable code, the field a client branches on. */
   readonly code: string;
   /** HTTP status the control plane maps this refusal to. */
   readonly status: number;
@@ -65,7 +65,7 @@ export const HOSTED_SESSION_UNAVAILABLE: HostedSessionFailureFixture = {
 
 /**
  * At the configured cap. 429: the request is well-formed and the daemon is not
- * broken — there is no room. Retrying after a kill succeeds.
+ * broken, there is no room. Retrying after a kill succeeds.
  */
 export const HOSTED_SESSION_LIMIT_REACHED: HostedSessionFailureFixture = {
   methodId: 'sessions.hosted.create',

package/src/version.ts

@@ -13,14 +13,14 @@ try {
   // compiled binary resolves import.meta.dir to a virtual root where the
   // `../package.json` path can land on a DIFFERENT package.json (a bundled
   // dependency's, or the embedded runtime's) that reports a placeholder like
-  // "0.0.0" — exactly the wrong-version banner a bare daemon launch showed in
+  // "0.0.0", exactly the wrong-version banner a bare daemon launch showed in
   // the field. Guarding on the package name means the prebuild-baked fallback
   // above wins in that case instead of a stray version.
   if (pkg?.name === 'goodvibes-daemon' && typeof pkg.version === 'string' && pkg.version.length > 0) {
     _version = pkg.version;
   }
 } catch {
-  // Compiled binary or missing package.json — use fallback
+  // Compiled binary or missing package.json, use fallback
 }
 
 export const VERSION = _version;