@pellux/goodvibes-agent 1.5.7 → 1.5.9

package/src/renderer/thinking.ts

@@ -10,7 +10,7 @@ export function renderThinkingBlock(text: string, width: number): Line[] {
   // light terminal. In dark mode the accent adopts the shared reasoning purple
   // (state.reasoning) and the body adopts chrome.faint (== fg.dim) — a small,
   // deliberate convergence to the reference tokens from the agent's prior local
-  // BORDERS.THINKING.color / COLORS.DIM_TEXT (see the W4-R4 visible-changes note).
+  // BORDERS.THINKING.color / COLORS.DIM_TEXT (see the visible-changes note).
   const t = activeUiTones();
   return renderConversationNotice(
     text,

package/src/renderer/ui-factory.ts

@@ -259,7 +259,7 @@ export class UIFactory {
     if (inp > 0 || out > 0) {
       statusTokens.push({ text: `↑${fmtNum(inp)} ↓${fmtNum(out)}`, fg: '240' });
     }
-    // W4-R4: the disconnected footer 'waiting for your approval' token is retired
+    // The disconnected footer 'waiting for your approval' token is retired
     // here — the approval-wait truth now lives in the unified waiting state of the
     // thinking indicator (createThinkingFragment's approvalPending path) and in the
     // permission prompt itself, so the footer no longer carries a separate,

package/src/renderer/ui-primitives.ts

@@ -1,9 +1,9 @@
 // ---------------------------------------------------------------------------
 // ui-primitives.ts — glyph registry + tone-token table.
 //
-// W4-R4: these four tables (GLYPHS, UI_TONES, DIFF_TONES, SPINNER_FRAMES) are
+// These four tables (GLYPHS, UI_TONES, DIFF_TONES, SPINNER_FRAMES) are
 // no longer minted locally. They are the SDK presentation contract
-// (@pellux/goodvibes-sdk/platform/presentation, landed by W4-S1), consumed here
+// (@pellux/goodvibes-sdk/platform/presentation), consumed here
 // so the agent and the TUI share ONE source (Mike's move-to-SDK ruling —
 // machinery needed by 2+ surfaces => SDK). See
 // docs/decisions/2026-07-05-presentation-contract-sdk-extraction.md in the SDK.

package/src/runtime/bootstrap-core.ts

@@ -348,7 +348,7 @@ export async function initializeBootstrapCore(
     memoryStore.close();
   });
 
-  // W6-C2 (E6): fold the agent's legacy per-surface memory into the canonical
+  // Fold the agent's legacy per-surface memory into the canonical
   // cross-surface store (id-keyed, idempotent, never deletes the legacy file) and
   // SURFACE the fold report — migration honesty requires that what moved is visible,
   // not silently swallowed. Non-fatal: a fold failure must never block startup.
@@ -363,7 +363,7 @@ export async function initializeBootstrapCore(
     logger.warn('agent legacy memory fold failed (non-fatal)', { error: summarizeError(err) });
   }
 
-  // W6-C2 (E6): ONE-TIME migration of discovered VIBE.md files into persona/constraint
+  // ONE-TIME migration of discovered VIBE.md files into persona/constraint
   // records, guarded by a persisted path→hash marker so it never re-imports the same
   // file (which would create near-duplicate persona records). After this, the VIBE
   // prompt is a PROJECTION of those records (buildVibeProjectionPrompt).

package/src/runtime/bootstrap.ts

@@ -203,10 +203,10 @@ export async function bootstrapRuntime(
     services.shellPaths.resolveUserPath(GOODVIBES_AGENT_SURFACE_ROOT, 'prompt-context-receipts.jsonl'),
   );
   let activePromptTurnId: string | null = null;
-  // The current turn's raw text (Wave-4 W4-A1B): the injection seam
+  // The current turn's raw text: the injection seam
   // (composeRuntimePromptWithReceipt, invoked from getSystemPrompt below) needs the
   // active turn's intent to rank the already-eligible memory set by relevance. This is
-  // the real seam W4-A1 left unthreaded — TURN_SUBMITTED already carries `prompt`, it
+  // the real seam that was left unthreaded — TURN_SUBMITTED already carries `prompt`, it
   // was just never captured. Mirrors activePromptTurnId's lifecycle exactly: set on
   // TURN_SUBMITTED, cleared on every terminal event for that turn.
   let activePromptTurnText: string | null = null;
@@ -551,7 +551,7 @@ export async function bootstrapRuntime(
     shellPaths: services.shellPaths,
     surfaceRoot: GOODVIBES_AGENT_SURFACE_ROOT,
   });
-  // W4-A9: refresh explicitly-subscribed external calendar feeds that are DUE
+  // Refresh explicitly-subscribed external calendar feeds that are DUE
   // per their own bounded interval (conditional 304 requests keep it cheap).
   // Consent was given at subscribe time ("now and on each refresh"); with no
   // subscriptions this touches nothing. Non-blocking — boot never waits on it;

package/src/runtime/calendar-boot-refresh.ts

@@ -1,5 +1,5 @@
 /**
- * Calendar subscription boot refresh (W4-A9 completion).
+ * Calendar subscription boot refresh.
  *
  * Fires once from bootstrap's Phase-8 area (after first render, like the gated
  * LAN scan and MCP discovery), fully async and non-blocking: boot never waits on

package/src/runtime/lan-scan-consent.ts

@@ -1,5 +1,5 @@
 /**
- * LAN-scan consent gate (Wave-4 A7).
+ * LAN-scan consent gate.
  *
  * The SDK's background provider-discovery pass (`startBackgroundProviderDiscovery`
  * in `@pellux/goodvibes-sdk/platform/runtime`) probes every host on this

package/src/runtime/services.ts

@@ -50,7 +50,7 @@ import { ModeManager } from '@pellux/goodvibes-sdk/platform/state';
 import { FileUndoManager } from '@pellux/goodvibes-sdk/platform/state';
 import { MemoryRegistry } from '@pellux/goodvibes-sdk/platform/state';
 import { MemoryStore } from '@pellux/goodvibes-sdk/platform/state';
-// W6-C2 (E6): one canonical cross-surface memory store + no-loss legacy fold.
+// One canonical cross-surface memory store + no-loss legacy fold.
 import { resolveCanonicalMemoryDbPath, foldMemoryStores } from '@pellux/goodvibes-sdk/platform/state';
 import type { LegacyMemorySource, MemoryFoldReport } from '@pellux/goodvibes-sdk/platform/state';
 import type { RuntimeEventBus } from '@/runtime/index.ts';
@@ -456,7 +456,7 @@ export interface RuntimeServices extends SdkRuntimeServices {
   readonly worktreeRegistry: WorktreeRegistry;
   readonly sandboxSessionRegistry: SandboxSessionRegistry;
   readonly webhookNotifier: WebhookNotifier;
-  /** W4-R3 — OS-level terminal focus tracker, ported from goodvibes-tui's W2.3 (core/focus-tracker.ts). */
+  /** OS-level terminal focus tracker, ported from goodvibes-tui's W2.3 (core/focus-tracker.ts). */
   readonly focusTracker: FocusTracker;
   readonly replayEngine: DeterministicReplayEngine;
   readonly providerOptimizer: ProviderOptimizer;
@@ -613,7 +613,7 @@ export function createRuntimeServices(options: RuntimeServicesOptions): RuntimeS
     agentStatusProvider: agentManager,
     messageSender: agentMessageBus,
   });
-  // W3-A1: the SDK's extracted session-spine core, consumed via this surface's
+  // The SDK's extracted session-spine core, consumed via this surface's
   // own REST transport adapter (session-spine-rest-transport.ts) — version-
   // tolerant, since the agent may compile against a pinned SDK predating the
   // typed sessions.register client. Live-immediately mode: passing `transport`
@@ -639,7 +639,7 @@ export function createRuntimeServices(options: RuntimeServicesOptions): RuntimeS
   });
   const artifactStore = new ArtifactStore({ configManager });
   const memoryEmbeddingRegistry = new MemoryEmbeddingProviderRegistry({ configManager });
-  // W6-C2 (E6): the agent no longer owns a private per-surface memory.sqlite. It opens
+  // The agent no longer owns a private per-surface memory.sqlite. It opens
   // the ONE canonical cross-surface store so a fact learned here recalls in the TUI (and
   // vice-versa). The old agent-global path is folded in at boot with no loss (see
   // foldAgentLegacyMemory), then left in place — migration never deletes.
@@ -779,7 +779,7 @@ export function createRuntimeServices(options: RuntimeServicesOptions): RuntimeS
   const worktreeRegistry = createDisabledAgentWorktreeRegistry(workingDirectory);
   // Configured and attached to the runtime bus during bootstrap when webhook URLs are present.
   const webhookNotifier = new WebhookNotifier();
-  // W4-R3 — one shared instance for the process lifetime (mirrors goodvibes-tui's
+  // One shared instance for the process lifetime (mirrors goodvibes-tui's
   // runtime/services.ts); fed from 'focus' tokens in handler-feed.ts and read by
   // the approval-alert wiring in main.ts.
   const focusTracker = new FocusTracker();
@@ -866,7 +866,7 @@ export function createRuntimeServices(options: RuntimeServicesOptions): RuntimeS
     workflowServices: workflow,
   });
 
-  // ── One-Platform Wave 0: RuntimeServices members required by SDK 0.38 ──────
+  // ── One-Platform: RuntimeServices members required by SDK 0.38 ──────
   // The Agent is delegation-only: it does not own local build/worktree work.
   // These are constructed as real-but-inert SDK services purely to satisfy the
   // RuntimeServices contract — none auto-start:
@@ -1020,7 +1020,7 @@ export function createRuntimeServices(options: RuntimeServicesOptions): RuntimeS
 }
 
 /**
- * W6-C2 (E6): fold the agent's legacy per-surface memory store into the canonical
+ * Fold the agent's legacy per-surface memory store into the canonical
  * cross-surface store. Called once at boot AFTER `memoryStore.init()` so any records
  * written before unification survive. Id-keyed and idempotent — a re-run imports
  * nothing new and never deletes the legacy file. Returns the report so boot can log

package/src/runtime/terminal-output-guard.ts

@@ -232,7 +232,7 @@ export function installTuiTerminalOutputGuard(options: TuiTerminalOutputGuardOpt
       const notice = `[Terminal] Captured ${count} direct ${event.source} write${plural} that would have corrupted the TUI: ${event.preview}`;
       // Keep the aggregate count reachable in the activity log even though the
       // noise gate (system-message-noise.ts) drops the notice from the Recent
-      // feed — drop-from-the-feed, not delete. (W4-R2 honest degraded state.)
+      // feed — drop-from-the-feed, not delete. (Honest degraded state.)
       logger.info(notice, { source: event.source, count });
       options.notify(notice);
     },

package/src/runtime/ui-services.ts

@@ -54,7 +54,7 @@ export interface UiPlatformServices {
   readonly tokenAuditor: RuntimeServices['tokenAuditor'];
   readonly replayEngine: RuntimeServices['replayEngine'];
   readonly webhookNotifier: RuntimeServices['webhookNotifier'];
-  /** W4-R3 — OS-level terminal focus tracker, ported from goodvibes-tui's W2.3. */
+  /** OS-level terminal focus tracker, ported from goodvibes-tui's W2.3. */
   readonly focusTracker: RuntimeServices['focusTracker'];
   readonly policyRuntimeState: RuntimeServices['policyRuntimeState'];
   readonly externalServices?: {

package/src/runtime/unhandled-rejection-guard.ts

@@ -0,0 +1,41 @@
+import { logger } from '@pellux/goodvibes-sdk/platform/utils';
+
+/**
+ * Builds the process-level unhandledRejection handler for the shell.
+ *
+ * Extracted from main() so the entrypoint stays under the architecture
+ * line-count cap. Behavior is unchanged: isolated rejections surface as a
+ * single "[Error]" line, while more than three within a rolling 10s window
+ * escalate to a "[Critical]" restart suggestion so a cascading failure is
+ * named instead of scrolling by as noise.
+ */
+export function createUnhandledRejectionHandler(deps: {
+  readonly notifyHigh: (message: string) => void;
+  readonly render: () => void;
+}): (reason: unknown) => void {
+  let rejectionCount = 0;
+  let windowStart = Date.now();
+  return (reason: unknown): void => {
+    const now = Date.now();
+    if (now - windowStart > 10000) {
+      rejectionCount = 0;
+      windowStart = now;
+    }
+    rejectionCount++;
+    const msg = reason instanceof Error ? reason.message : String(reason);
+    if (rejectionCount > 3) {
+      logger.error('CRITICAL: cascading unhandled rejections — consider restarting', {
+        count: rejectionCount,
+        windowMs: now - windowStart,
+        error: String(reason),
+      });
+      deps.notifyHigh(
+        `[Critical] Multiple errors detected (${rejectionCount} in 10s). If the issue persists, please restart. Latest: ${msg}`
+      );
+    } else {
+      deps.notifyHigh(`[Error] ${msg}`);
+      logger.error('unhandledRejection', { error: String(reason) });
+    }
+    deps.render();
+  };
+}

package/src/shell/agent-workspace-fullscreen.ts

@@ -36,7 +36,7 @@ export function createAgentWorkspaceFullscreenComposite(
   width: number,
   height: number,
 ): CompositeRequest {
-  // W4-A6: mirror disk state on every repaint of the workspace panel so the
+  // Mirror disk state on every repaint of the workspace panel so the
   // memory count and routine start counts never show a stale point-in-time
   // snapshot from the last workspace action (e.g. an external delete, or a
   // routine started from another shell/CLI invocation).

package/src/shell/terminal-focus-mode.ts

@@ -1,5 +1,5 @@
 /**
- * terminal-focus-mode.ts — W4-R3: DECSET ?1004h OS window-focus reporting +
+ * terminal-focus-mode.ts — DECSET ?1004h OS window-focus reporting +
  * the approval-alert wiring that consumes it.
  *
  * Extracted from main.ts (architecture line-count gate: MAX_SOURCE_LINES=800
@@ -7,13 +7,13 @@
  * extracting terminal-mode literals out of its entry file (see that repo's
  * src/renderer/terminal-escapes.ts docstring). Behavior is unchanged from an
  * inline version; this is purely a line-count extraction plus the one new
- * behavior (the approval alert) this work order adds.
+ * behavior added here (the approval alert).
  *
- * FOCUS_ENABLE/FOCUS_DISABLE: sourced from W4-R2's terminal-escapes.ts (the
- * shared home for the DECSET ?1004 literals — its own docstring names R3 as
- * the importer) and re-exported here so the focus-mode callers (main.ts and
- * the tests) keep one import site for the whole focus-mode surface. This is
- * the R2/R3 convergence the W4-R1 parity matrix pre-ruled: a relocation of
+ * FOCUS_ENABLE/FOCUS_DISABLE: sourced from terminal-escapes.ts (the
+ * shared home for the DECSET ?1004 literals — its own docstring names this
+ * module as the importer) and re-exported here so the focus-mode callers (main.ts and
+ * the tests) keep one import site for the whole focus-mode surface. This
+ * convergence was pre-ruled by the port's parity matrix: a relocation of
  * the literals, no behavior change.
  *
  * installFocusModeExitGuard(): a last-resort safety net. Node/Bun fire 'exit'
@@ -21,7 +21,7 @@
  * take — explicit process.exit() calls (normal /exit, double-Ctrl+C via
  * exitApp()) AND the default uncaughtException termination — even though
  * main.ts registers no explicit uncaughtException/SIGTERM handler of its own.
- * Named top-5 risk (W4-R1 matrix): ?1004h MUST be disabled on every exit path
+ * Named a top-5 risk in the port's parity matrix: ?1004h MUST be disabled on every exit path
  * or the user's shell inherits focus-reporting escape garbage. The write is
  * harmless even if exitApp() already disabled it moments earlier (?1004l is
  * idempotent). It is GATED on focus mode having actually been enabled
@@ -37,7 +37,7 @@
  * module's config-gated alert-class system (alert-gating.ts's
  * behavior.notifyOnApprovalPending / notifyOnlyWhenUnfocused settings, shared
  * with budget-breach/long-task/chain-failure notifiers) is TUI-specific
- * infrastructure the W4-R1 parity matrix does not list as a PORT item — only
+ * infrastructure the port's parity matrix does not list as a PORT item — only
  * core/focus-tracker.ts is. This is the minimal, self-contained wiring the
  * matrix's own text calls for ("route focus in/out events ... to drive
  * awaiting-approval alerts"). PRIVACY: message content is tool name + category

package/src/shell/ui-openers.ts

@@ -424,7 +424,7 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
     input.modalOpened('settings');
     input.settingsModal.open(configManager, featureFlags, subscriptionManager, serviceRegistry, mcpRegistry, secretsManager, {
       onSettingApplied: (change) => {
-        // W4-R4: forced dark/light applies immediately (mode flip + full
+        // Forced dark/light applies immediately (mode flip + full
         // repaint via clearScreen's resetDiff); auto only re-probes at startup,
         // so it takes effect next launch (stated honestly).
         if (String(change.key) === THEME_MODE_CONFIG_KEY) {

package/src/tools/agent-harness-operator-methods.ts

@@ -48,7 +48,7 @@ interface OperatorMethodDescriptor {
 }
 
 /**
- * W4-A3 (capability-advertisement honesty): the SDK operator contract marks
+ * Capability-advertisement honesty: the SDK operator contract marks
  * a method `invokable: false` when it is cataloged but not backed by a real
  * daemon route (see @pellux/goodvibes-sdk's method-catalog-route-reconcile —
  * email.inbox.list/read, email.draft.create, email.send are the dogfood

package/src/tools/agent-harness-personal-ops-discovery.ts

@@ -36,7 +36,7 @@ export function methodSearchText(method: OperatorContractMethod): string {
 }
 
 /**
- * W4-A3/W4-A5 capability honesty: a method whose contract entry carries
+ * Capability honesty: a method whose contract entry carries
  * invokable:false is cataloged but NOT dispatchable — no daemon route or
  * handler serves it. Counting it toward "workflow ready" would repeat the
  * dogfood finding (a lane card claiming readiness backed only by methods a
@@ -77,7 +77,7 @@ export function unavailableMethodIdsMatching(tokens: readonly string[]): readonl
 
 /**
  * One honest line naming advertised-but-undispatchable methods, matching the
- * W4-A3 degraded-ad pattern ("unavailable (route not served by this daemon)").
+ * degraded-ad pattern ("unavailable (route not served by this daemon)").
  * Returns null when nothing is degraded.
  */
 export function unavailableMethodsNote(unavailableMethodIds: readonly string[]): string | null {

package/src/tools/agent-harness-personal-ops-lanes.ts

@@ -15,7 +15,7 @@ export function buildLanes(
   } = {},
 ): readonly PersonalOpsLane[] {
   const snapshot = buildAgentWorkspaceRuntimeSnapshot(context);
-  // Readiness counts only DISPATCHABLE methods (W4-A3/W4-A5 honesty): a
+  // Readiness counts only DISPATCHABLE methods (capability-advertisement honesty): a
   // method the contract marks invokable:false has no serving route, so it
   // must not make a lane read "ready"/"partial". The unavailable lists feed
   // honest degraded wording instead.

package/src/tools/agent-harness-personal-ops-types.ts

@@ -29,7 +29,7 @@ export interface OperatorContractMethod {
   readonly description?: string;
   readonly category?: string;
   /**
-   * W4-A3 capability-advertisement honesty: false means the method is
+   * Capability-advertisement honesty: false means the method is
    * cataloged but NOT dispatchable (no route/handler serves it). Absent
    * means invokable (older contracts predate the flag).
    */

package/src/tools/agent-harness-prompt-context.ts

@@ -246,8 +246,8 @@ function memorySegment(memory: PromptMemoryApi | undefined, includeParameters: b
       inspectRoute: `agent_local_registry domain:"memory" action:"get" recordId:"${record.id}"`,
     })),
     suppressed: suppressed.slice(0, 12).map((record) => {
-      // Honest, per-record reason straight from describeMemoryPromptEligibility (Wave-4
-      // W4-A1B) — the same wording source prompt-context-receipts.ts uses, never a
+      // Honest, per-record reason straight from describeMemoryPromptEligibility —
+      // the same wording source prompt-context-receipts.ts uses, never a
       // locally invented "not reviewed"/"outside prompt limit" guess. A record here
       // either genuinely failed eligibility, or passed it but was cut by the top-10
       // prompt slice — those read differently.
@@ -399,7 +399,7 @@ function promptContextSegments(context: CommandContext, includeParameters: boole
   }
 
   const vibe = discoverVibeFiles(shellPaths);
-  // W6-C2 (E6): mirror the runtime — the VIBE prompt is a PROJECTION of persona records,
+  // Mirror the runtime — the VIBE prompt is a PROJECTION of persona records,
   // not a file re-read (discoverVibeFiles stays for the file-discovery receipt below).
   const vibeMemory = promptMemoryApi(context.clients?.agentKnowledgeApi?.memory);
   const vibePrompt = (vibeMemory ? buildVibeProjectionPrompt(vibeMemory) : null) ?? '';

package/src/tools/agent-local-registry-memory.ts

@@ -1,5 +1,5 @@
 /**
- * Agent-local memory domain handler (W4-A1: memory honesty).
+ * Agent-local memory domain handler (memory honesty).
  *
  * Split out of agent-local-registry-tool.ts to stay under the 800-line
  * architecture cap. Owns the `memory` domain of the agent_local_registry

package/src/tools/agent-operator-method-tool.ts

@@ -563,7 +563,7 @@ export function createAgentOperatorMethodTool(
           error: `Unknown GoodVibes operator method '${methodId}'. Inspect host action:"methods" first.`,
         };
       }
-      // W4-A3 (capability-advertisement honesty): the operator contract marks a
+      // Capability-advertisement honesty: the operator contract marks a
       // cataloged-but-not-route-backed method invokable:false (email.inbox.list,
       // email.send, etc. — see @pellux/goodvibes-sdk's method-catalog-route-reconcile).
       // Refuse here, before prepareOperatorRoute/fetch, rather than letting the

package/src/version.ts

@@ -6,7 +6,7 @@ import { join } from 'node:path';
 // The prebuild script updates the fallback value before compilation.
 // Uses import.meta.dir (Bun) to locate package.json relative to this file,
 // which is correct regardless of the process working directory.
-let _version = '1.5.7';
+let _version = '1.5.9';
 try {
   const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8')) as {
     readonly version?: unknown;