@pellux/goodvibes-agent 1.5.5 → 1.5.6

package/src/renderer/markdown.ts

@@ -3,6 +3,13 @@ import { UIFactory } from './ui-factory.ts';
 import { renderCodeBlock } from './code-block.ts';
 import { getDisplayWidth } from '../utils/terminal-width.ts';
 import { LAYOUT } from './layout.ts';
+import { activeTheme } from './theme.ts';
+
+// Transcript tokens are read live per render (const T = activeTheme() at the top
+// of each render function below) so a dark→light repaint re-resolves with no
+// module reload. Dark values are byte-identical to the agent's prior static
+// reads; the only dark change is inline code losing its dark background box (it
+// gains bold instead — the near-black box was unreadable on a light terminal).
 
 export interface MarkdownRenderOptions {
   codeBlockLineNumbers?: boolean;
@@ -56,6 +63,7 @@ export function renderMarkdownTracked(
   width: number,
   options: MarkdownRenderOptions = {},
 ): { lines: ReturnType<typeof renderMarkdown>; codeBlocks: CodeBlockSpan[] } {
+  const T = activeTheme();
   const lines: ReturnType<typeof renderMarkdown> = [];
   const codeBlocks: CodeBlockSpan[] = [];
   const rawLines = text.split('\n');
@@ -106,17 +114,17 @@ export function renderMarkdownTracked(
     const h2 = raw.match(/^## (.+)/);
     const h1 = raw.match(/^# (.+)/);
     if (h1) {
-      lines.push(UIFactory.stringToLine(' '.repeat(indent) + h1[1].toUpperCase(), width, { fg: '#00ffff', bold: true }));
+      lines.push(UIFactory.stringToLine(' '.repeat(indent) + h1[1].toUpperCase(), width, { fg: T.heading1, bold: true }));
       lines.push(UIFactory.stringToLine(' '.repeat(indent) + '━'.repeat(Math.min(getDisplayWidth(h1[1]), contentWidth)), width, { fg: '244' }));
       continue;
     }
     if (h2) {
-      lines.push(UIFactory.stringToLine(' '.repeat(indent) + h2[1], width, { fg: '#00ffff', bold: true }));
+      lines.push(UIFactory.stringToLine(' '.repeat(indent) + h2[1], width, { fg: T.heading2, bold: true }));
       lines.push(UIFactory.stringToLine(' '.repeat(indent) + '─'.repeat(Math.min(getDisplayWidth(h2[1]), contentWidth)), width, { fg: '240' }));
       continue;
     }
     if (h3) {
-      lines.push(UIFactory.stringToLine(' '.repeat(indent) + h3[1], width, { fg: '111', bold: true }));
+      lines.push(UIFactory.stringToLine(' '.repeat(indent) + h3[1], width, { fg: T.heading3, bold: true }));
       continue;
     }
 
@@ -130,7 +138,7 @@ export function renderMarkdownTracked(
       const rendered = renderInlineMarkdown(taskMatch[3]);
       const prefix = ' '.repeat(bulletX) + checkbox;
       const style = checked ? { fg: '244', strikethrough: true } : {};
-      lines.push(...compositeInlineLine(prefix, rendered, width, { fg: checked ? '#22c55e' : '252', ...style }, textStartX));
+      lines.push(...compositeInlineLine(prefix, rendered, width, { fg: checked ? T.checkboxChecked : '252', ...style }, textStartX));
       continue;
     }
 
@@ -220,6 +228,7 @@ function stripMarkdown(text: string): string {
  * truncates long content, and renders with proper styling.
  */
 function renderTable(rows: string[], width: number, indent: number): Line[] {
+  const T = activeTheme();
   const lines: Line[] = [];
 
   // Parse rows into cells, skip separator
@@ -300,14 +309,14 @@ function renderTable(rows: string[], width: number, indent: number): Line[] {
         }
         let style: Partial<Cell> = {};
         if (token.type === 'code') {
-          style = { fg: '#ffcc00', bg: '#1a1a1a' };
+          style = { fg: T.inlineCodeFg, bold: true };
         } else if (token.type === 'link') {
-          style = { fg: '#00aaff', underline: true };
+          style = { fg: T.link, underline: true };
         } else {
           style = { ...token.style };
         }
         if (isHdr) {
-          style.fg = style.fg || '#00ffff';
+          style.fg = style.fg || T.heading1;
           style.bold = true;
         } else {
           style.fg = style.fg || '252';
@@ -320,7 +329,7 @@ function renderTable(rows: string[], width: number, indent: number): Line[] {
 
     // Pad remaining space
     while (w < maxW) {
-      cells.push(createStyledCell(' ', isHdr ? { fg: '#00ffff' } : { fg: '252' }));
+      cells.push(createStyledCell(' ', isHdr ? { fg: T.heading1 } : { fg: '252' }));
       w++;
     }
     return cells;
@@ -518,6 +527,7 @@ function compositeInlineLine(
   prefixStyle: Partial<Cell>,
   textStartX: number
 ): Line[] {
+  const T = activeTheme();
   const lines: Line[] = [];
 
   // Flatten tokens to [char, style] pairs
@@ -528,14 +538,14 @@ function compositeInlineLine(
     if (token.type === 'text') {
       for (const ch of token.text) chars.push({ char: ch, style: token.style });
     } else if (token.type === 'code') {
-      for (const ch of token.text) chars.push({ char: ch, style: { fg: '#ffcc00', bg: '#1a1a1a' } });
+      for (const ch of token.text) chars.push({ char: ch, style: { fg: T.inlineCodeFg, bold: true } });
     } else if (token.type === 'link') {
       // Resolve URL: if url is empty or relative, treat as text; if it's a file path, use file:// protocol
       let resolvedUrl = token.url;
       if (resolvedUrl && !resolvedUrl.startsWith('http') && !resolvedUrl.startsWith('file://') && resolvedUrl.startsWith('/')) {
         resolvedUrl = `file://${resolvedUrl}`;
       }
-      for (const ch of token.text) chars.push({ char: ch, style: { fg: '#00aaff', underline: true, link: resolvedUrl || undefined } });
+      for (const ch of token.text) chars.push({ char: ch, style: { fg: T.link, underline: true, link: resolvedUrl || undefined } });
     }
   }
 

package/src/renderer/modal-factory.ts

@@ -8,7 +8,8 @@ import {
   putOverlayText,
 } from './overlay-box.ts';
 import { getOverlayMaxWidth } from './overlay-viewport.ts';
-import { GLYPHS, UI_TONES } from './ui-primitives.ts';
+import { GLYPHS } from './ui-primitives.ts';
+import { activeUiTones, registerThemeRefresh } from './theme.ts';
 
 // ── Helpers ──────────────────────────────────────────────────────────────────
 
@@ -90,20 +91,29 @@ export interface ModalConfig {
 
 // ── Defaults ─────────────────────────────────────────────────────────────────
 
-const DEFAULT_STYLE: Required<ModalStyle> = {
-  titleFg: UI_TONES.fg.primary,
-  borderFg: UI_TONES.fg.dim,
-  hintFg: UI_TONES.fg.muted,
-  selectedFg: UI_TONES.fg.primary,
-  selectedBg: UI_TONES.bg.selected,
-  textFg: UI_TONES.fg.primary,
-  accentFg: UI_TONES.state.info,
-  titleRowFg: UI_TONES.fg.secondary,
-  titleBg: UI_TONES.bg.title,
-  sectionBg: UI_TONES.bg.section,
-  inputBg: UI_TONES.bg.input,
-  surfaceBg: UI_TONES.bg.surface,
-};
+// Built from the mode-resolved chrome tones (activeUiTones) and rebuilt IN PLACE
+// on a mode flip via the registered refresher (read by reference across modal
+// call sites). These paint the OPAQUE dark modal surface, so in the SDK light
+// tones the fg/bg roles stay dark (only state.info flips) — dark is byte-identical.
+function buildModalStyle(): Required<ModalStyle> {
+  const t = activeUiTones();
+  return {
+    titleFg: t.fg.primary,
+    borderFg: t.fg.dim,
+    hintFg: t.fg.muted,
+    selectedFg: t.fg.primary,
+    selectedBg: t.bg.selected,
+    textFg: t.fg.primary,
+    accentFg: t.state.info,
+    titleRowFg: t.fg.secondary,
+    titleBg: t.bg.title,
+    sectionBg: t.bg.section,
+    inputBg: t.bg.input,
+    surfaceBg: t.bg.surface,
+  };
+}
+const DEFAULT_STYLE: Required<ModalStyle> = buildModalStyle();
+registerThemeRefresh(() => Object.assign(DEFAULT_STYLE, buildModalStyle()));
 
 // ── ModalFactory ─────────────────────────────────────────────────────────────
 

package/src/renderer/overlay-box.ts

@@ -1,6 +1,7 @@
 import { createStyledCell, type Line } from '../types/grid.ts';
 import { getOverlayMaxWidth } from './overlay-viewport.ts';
-import { GLYPHS, UI_TONES } from './ui-primitives.ts';
+import { GLYPHS } from './ui-primitives.ts';
+import { activeUiTones, registerThemeRefresh } from './theme.ts';
 import { fillWidth, makeLine, writeText } from './fullscreen-primitives.ts';
 
 export interface OverlayBoxPalette {
@@ -15,17 +16,27 @@ export interface OverlayBoxPalette {
   readonly bodyBg: string;
 }
 
-export const DEFAULT_OVERLAY_PALETTE: Readonly<OverlayBoxPalette> = {
-  borderFg: UI_TONES.fg.secondary,
-  titleFg: UI_TONES.fg.primary,
-  bodyFg: UI_TONES.fg.primary,
-  mutedFg: UI_TONES.fg.dim,
-  selectedBg: UI_TONES.bg.selected,
-  titleBg: UI_TONES.bg.title,
-  sectionBg: UI_TONES.bg.section,
-  inputBg: UI_TONES.bg.input,
-  bodyBg: UI_TONES.bg.surface,
-} as const;
+// Built from the mode-resolved chrome tones (activeUiTones) and rebuilt IN PLACE
+// on a mode flip via the registered refresher (read by reference across the
+// overlay call sites). Opaque dark overlay surface → fg/bg roles stay dark in
+// the SDK light tones; dark is byte-identical to the prior static reads.
+function buildOverlayPalette(): OverlayBoxPalette {
+  const t = activeUiTones();
+  return {
+    borderFg: t.fg.secondary,
+    titleFg: t.fg.primary,
+    bodyFg: t.fg.primary,
+    mutedFg: t.fg.dim,
+    selectedBg: t.bg.selected,
+    titleBg: t.bg.title,
+    sectionBg: t.bg.section,
+    inputBg: t.bg.input,
+    bodyBg: t.bg.surface,
+  };
+}
+
+export const DEFAULT_OVERLAY_PALETTE: Readonly<OverlayBoxPalette> = buildOverlayPalette();
+registerThemeRefresh(() => Object.assign(DEFAULT_OVERLAY_PALETTE as OverlayBoxPalette, buildOverlayPalette()));
 
 export interface OverlayBoxLayout {
   readonly margin: number;

package/src/renderer/process-indicator.ts

@@ -1,7 +1,8 @@
 import { type Line } from '../types/grid.ts';
 import { UIFactory } from './ui-factory.ts';
 import { getDisplayWidth } from '../utils/terminal-width.ts';
-import { GLYPHS } from './ui-primitives.ts';
+import { GLYPHS, UI_TONES } from './ui-primitives.ts';
+import { activeUiTones } from './theme.ts';
 
 /** Truncate a string to fit within maxWidth display columns. */
 function truncateToWidth(text: string, maxWidth: number): string {
@@ -39,7 +40,9 @@ export function renderProcessIndicator(
   const renderFocusedStatus = (text: string): Line[] => {
     const bg = '#31506f';
     const fg = '#eefaff';
-    const markerFg = '#7dd3fc';
+    // Opaque highlight bar (bg/fg fixed) — marker sourced from the shared
+    // browser accent token (dark == the prior browser-cyan marker).
+    const markerFg = UI_TONES.accent.browser;
     const line = UIFactory.stringToLine(' '.repeat(width), width, { fg: '238' });
     const prefix = `${GLYPHS.navigation.selected} `;
     const body = truncateToWidth(text, Math.max(0, width - 8));
@@ -93,5 +96,7 @@ export function renderProcessIndicator(
     : '';
   const label = `${parts.join(` ${GLYPHS.navigation.pipeSeparator} `)}${progressSuffix}`;
   const hint = `  ${GLYPHS.status.pending}  Enter to view`;
-  return renderPlainStatus(`${label}${hint}`, { fg: '#00ffff', bold: true });
+  // Active-status label paints on the transparent terminal bg → read the live
+  // brand accent so it flips to a legible value in light mode (dark == brand cyan).
+  return renderPlainStatus(`${label}${hint}`, { fg: activeUiTones().accent.brand, bold: true });
 }

package/src/renderer/prompt-content-width.ts

@@ -0,0 +1,16 @@
+/**
+ * computePromptContentWidth — content width available for prompt text inside
+ * the footer input box, after the box margin, inner padding, and the ' > '
+ * prefix are subtracted.
+ *
+ * Floors at 1: on a hostile-narrow terminal the raw subtraction
+ * (boxWidth - 4 - 3) can go zero or negative, and a non-positive content
+ * width breaks downstream text-wrapping and cursor-position math (which
+ * assume at least one column to place a character in).
+ */
+export function computePromptContentWidth(terminalColumns: number): number {
+  const w = terminalColumns || 80;
+  const boxMargin = 2;
+  const boxWidth = w - (boxMargin * 2);
+  return Math.max(1, boxWidth - 4 - 3); // minus padding (4) minus prefix width (3: ' > ')
+}

package/src/renderer/settings-modal-helpers.ts

@@ -92,6 +92,8 @@ export const CATEGORY_LABELS: Record<(typeof SETTINGS_CATEGORIES)[number], strin
   watchers: 'Watchers',
   network: 'Network',
   orchestration: 'Orchestration',
+  planner: 'Planner',
+  daemon: 'Daemon',
   runtime: 'Runtime',
   sandbox: 'Sandbox',
   batch: 'Batch',

package/src/renderer/settings-modal.ts

@@ -41,6 +41,8 @@ const CATEGORY_INFO: Record<SettingsCategory, string> = {
   watchers: 'Polling watcher and heartbeat behavior for runtime recovery and periodic checks.',
   network: 'Outbound TLS and remote fetch network policy.',
   orchestration: 'Visible agent orchestration limits such as recursion and active-agent caps.',
+  planner: 'Planning-decomposition agent limits: decomposition strategy, max turns, token ceiling, and wall-clock timeout before falling back to the deterministic heuristic path.',
+  daemon: 'Whether the local session daemon runs, and whether it is embedded in this surface process instead of spawned as a detached background service.',
   runtime: 'Runtime service limits and event bus settings.',
   sandbox: 'Isolation settings for REPL, MCP, and VM-backed sessions.',
   batch: 'Batch queue backend, limits, and provider batching behavior.',

package/src/renderer/startup-theme-probe.ts

@@ -0,0 +1,35 @@
+/**
+ * startup-theme-probe.ts (W4-R4) — install the OSC-11 background probe at
+ * startup and wire its resolved mode to the ported theme system.
+ *
+ * Thin composition seam extracted from main.ts: it binds R2's
+ * installBackgroundThemeProbe to theme.ts's setActiveThemeMode (applyThemeMode)
+ * so forced dark/light applies before first paint and auto (TTY only) probes and
+ * repaints once if light wins. The returned handle's filterInput() must gate the
+ * stdin data handler so the OSC-11 reply never reaches the tokenizer.
+ */
+
+import { installBackgroundThemeProbe, type ThemeProbeHandle } from './terminal-bg-probe.ts';
+import { setActiveThemeMode } from './theme.ts';
+import type { ConfigManager } from '@pellux/goodvibes-sdk/platform/config';
+
+export interface StartupThemeProbeDeps {
+  readonly configManager: Pick<ConfigManager, 'get'>;
+  readonly stdout: NodeJS.WriteStream;
+  /** The caller's terminal-output guard wrapper (allowTerminalWrite). */
+  readonly writeAllowed: (write: () => void) => void;
+  /** Reset the compositor diff so the repaint after a light reply is full. */
+  readonly resetDiff: () => void;
+  readonly render: () => void;
+}
+
+export function installStartupThemeProbe(deps: StartupThemeProbeDeps): ThemeProbeHandle {
+  return installBackgroundThemeProbe({
+    configManager: deps.configManager,
+    applyThemeMode: setActiveThemeMode,
+    isTTY: Boolean(deps.stdout.isTTY),
+    env: process.env,
+    writeQuery: (b) => deps.writeAllowed(() => deps.stdout.write(b)),
+    requestRepaint: () => { deps.resetDiff(); deps.render(); },
+  });
+}

package/src/renderer/status-glyphs.ts

@@ -1,21 +1,17 @@
 // ---------------------------------------------------------------------------
 // status-glyphs.ts — canonical glyph map for status states.
 //
-// Extracted as a neutral module so both status-token.ts and polish.ts can
-// import from here without creating a circular ESM dependency.
+// W4-R4: STATE_GLYPHS is no longer hardcoded here. It is the SDK presentation
+// contract (@pellux/goodvibes-sdk/platform/presentation, landed by W4-S1),
+// aliased to GLYPHS.status so the four semantic glyphs are spelled out in
+// exactly one place and can never drift from the registry again. Re-exported
+// under the historical names so status-token.ts and polish.ts import unchanged.
 //
-// Glyphs:
-//   good  ✓  (CHECK MARK U+2713)
-//   warn  ⚠  (WARNING SIGN U+26A0)
-//   bad   ✕  (MULTIPLICATION X U+2715)
-//   info  ○  (WHITE CIRCLE U+25CB)
+// Glyphs (the reconciled TUI-reference definitions):
+//   good  ✓  (CHECK MARK U+2713)     — GLYPHS.status.success
+//   warn  ⚠  (WARNING SIGN U+26A0)    — GLYPHS.status.warn
+//   bad   ✕  (MULTIPLICATION X U+2715) — GLYPHS.status.failure
+//   info  ○  (WHITE CIRCLE U+25CB)    — GLYPHS.status.info
 // ---------------------------------------------------------------------------
 
-export type StatusState = 'good' | 'warn' | 'bad' | 'info';
-
-export const STATE_GLYPHS: Record<StatusState, string> = {
-  good: '\u2713', // ✓
-  warn: '\u26a0', // ⚠
-  bad:  '\u2715', // ✕
-  info: '\u25cb', // ○
-};
+export { STATE_GLYPHS, type StatusState } from '@pellux/goodvibes-sdk/platform/presentation';

package/src/renderer/system-message.ts

@@ -1,6 +1,7 @@
 import { type Line } from '../types/grid.ts';
 import { BORDERS, COLORS } from './layout.ts';
 import { renderConversationNotice } from './conversation-surface.ts';
+import { activeUiTones, getActiveThemeMode } from './theme.ts';
 
 /** Exported for use by typeOverride callers and tests. */
 export type SystemMessageType = 'error' | 'warning' | 'info';
@@ -74,9 +75,23 @@ export function renderSystemMessage(
   const border = msgType === 'error' ? BORDERS.ERROR
     : msgType === 'warning' ? BORDERS.WARNING
     : BORDERS.INFO;
-  const textColor = msgType === 'info' ? COLORS.DIM_TEXT : border.color;
+  // System-message notices paint the ▌ marker and body on the TRANSPARENT
+  // terminal background, so the accent/body must resolve per render to stay
+  // legible on a light terminal. Dark is byte-identical to today: the agent's
+  // BORDERS.* accents (which include a yellow/cyan that are unreadable on light)
+  // are preserved in dark and only swapped for the legible chrome/state tones in
+  // light mode. (chrome.bad dark == BORDERS.ERROR.color; only warn/info/faint
+  // differ, and only in light.)
+  const t = activeUiTones();
+  const light = getActiveThemeMode() === 'light';
+  const accent = light
+    ? (msgType === 'error' ? t.chrome.bad : msgType === 'warning' ? t.chrome.warn : t.state.info)
+    : border.color;
+  const textColor = msgType === 'info'
+    ? (light ? t.chrome.faint : COLORS.DIM_TEXT)
+    : accent;
   return renderConversationNotice(content, width, {
-    accent: border.color,
+    accent,
     text: textColor,
     dim: msgType === 'info',
   }, border.char);