@pellux/goodvibes-agent 1.4.4 → 1.5.1

package/src/input/keybindings.ts

@@ -11,6 +11,16 @@
  * }
  *
  * Each value is a KeyCombo or an array of KeyCombos for multi-binding support.
+ *
+ * Action ID backward-compatibility aliases (accepted in keybindings.json):
+ *   "panel-picker"    → "workspace-picker"
+ *   "panel-close"     → "workspace-close"
+ *   "panel-close-all" → "workspace-close-all"
+ *   "panel-tab-next"  → "workspace-tab-next"
+ *   "panel-tab-prev"  → "workspace-tab-prev"
+ *
+ * These aliases are accepted when loading user-provided keybindings.json
+ * override files so existing user configs continue to work without changes.
  */
 
 import { readFileSync, existsSync } from 'node:fs';
@@ -34,11 +44,12 @@ export type KeyAction =
   | 'copy-selection'
   | 'clear-cancel'
   | 'screen-clear'
-  | 'panel-picker'
-  | 'panel-close'
-  | 'panel-close-all'
-  | 'panel-tab-next'
-  | 'panel-tab-prev'
+  | 'workspace-picker'
+  | 'workspace-close'
+  | 'workspace-close-all'
+  | 'workspace-tab-next'
+  | 'workspace-tab-prev'
+  | 'sidebar-toggle'
   | 'history-search'
   | 'search'
   | 'block-copy'
@@ -59,11 +70,12 @@ export const ACTION_DESCRIPTIONS: Record<KeyAction, string> = {
   'copy-selection':        'Copy selected text to clipboard',
   'clear-cancel':          'Clear input / cancel generation / exit (double)',
   'screen-clear':          'Repaint the screen',
-  'panel-picker':          'Open the Agent operator workspace',
-  'panel-close':            'Dismiss Agent workspace',
-  'panel-close-all':         'Dismiss Agent workspace focus',
-  'panel-tab-next':        'Cycle Agent workspace category forward',
-  'panel-tab-prev':        'Cycle Agent workspace category backward',
+  'workspace-picker':      'Open the Agent operator workspace',
+  'workspace-close':       'Close the Agent workspace',
+  'workspace-close-all':   'Close the Agent workspace (alias: also bound to Ctrl+Shift+X)',
+  'workspace-tab-next':    'Cycle Agent workspace category forward',
+  'workspace-tab-prev':    'Cycle Agent workspace category backward',
+  'sidebar-toggle':        'Show or hide the activity sidebar',
   'history-search':        'Reverse input history search',
   'search':                'Toggle conversation search',
   'block-copy':            'Copy nearest block to clipboard',
@@ -98,11 +110,12 @@ export const DEFAULT_KEYBINDINGS: Record<KeyAction, KeyCombo[]> = {
   'copy-selection':        [{ key: 'c', ctrl: true, shift: true }],
   'clear-cancel':          [{ key: 'c', ctrl: true }],
   'screen-clear':          [{ key: 'l', ctrl: true }],
-  'panel-picker':          [{ key: 'p', ctrl: true }],
-  'panel-close':            [{ key: 'x', ctrl: true }],
-  'panel-close-all':         [{ key: 'x', ctrl: true, shift: true }],
-  'panel-tab-next':        [{ key: ']', ctrl: true }],
-  'panel-tab-prev':        [{ key: '[', ctrl: true }],
+  'workspace-picker':      [{ key: 'p', ctrl: true }],
+  'workspace-close':       [{ key: 'x', ctrl: true }],
+  'workspace-close-all':   [{ key: 'x', ctrl: true, shift: true }],
+  'workspace-tab-next':    [{ key: ']', ctrl: true }],
+  'workspace-tab-prev':    [{ key: '[', ctrl: true }],
+  'sidebar-toggle':        [{ key: 'o', ctrl: true }],
   'history-search':        [{ key: 'r', ctrl: true }],
   'search':                [{ key: 'f', ctrl: true }],
   'block-copy':            [{ key: 'y', ctrl: true }],
@@ -116,7 +129,7 @@ export const DEFAULT_KEYBINDINGS: Record<KeyAction, KeyCombo[]> = {
   'undo':                  [{ key: 'z', ctrl: true }],
   'redo':                  [{ key: 'z', ctrl: true, shift: true }],
   'paste':                 [{ key: 'v', ctrl: true }],
-  'replay-panel':          [{ key: 'r', ctrl: true, shift: true }],
+  'replay-panel':          [],  // intentionally unbound until replay-panel is implemented
 };
 
 /** Resolved overrides type: each key can be a single combo or array. */
@@ -185,7 +198,17 @@ export class KeybindingsManager {
       // Reset to defaults before applying overrides
       this.bindings = this.cloneDefaults();
 
-      for (const [action, combo] of Object.entries(parsed)) {
+      // Backward-compatibility aliases: map old panel-* action ids to workspace-* equivalents.
+      const ALIASES: Readonly<Record<string, KeyAction>> = {
+        'panel-picker': 'workspace-picker',
+        'panel-close': 'workspace-close',
+        'panel-close-all': 'workspace-close-all',
+        'panel-tab-next': 'workspace-tab-next',
+        'panel-tab-prev': 'workspace-tab-prev',
+      };
+
+      for (const [rawAction, combo] of Object.entries(parsed)) {
+        const action: string = Object.hasOwn(ALIASES, rawAction) ? ALIASES[rawAction as keyof typeof ALIASES] : rawAction;
         if (!validActions.has(action as KeyAction)) {
           logger.debug('keybindings: unknown action, skipping', { action });
           continue;

package/src/input/model-picker-local-fit.ts

@@ -0,0 +1,130 @@
+/**
+ * Local-fit recommendation builder.
+ *
+ * When no provider credentials are configured, the model picker would show an
+ * empty list. This module builds a small set of synthetic model entries that
+ * represent common local model sizes so the picker opens with useful content.
+ *
+ * Rules:
+ *   - These entries are purely informational — they are NOT installed models.
+ *   - They must never appear when any real provider is configured.
+ *   - Selecting one routes through the local-provider install/confirm path,
+ *     never a silent model switch.
+ *   - The provider sentinel 'local' is distinct from 'ollama', 'lm-studio',
+ *     etc. so cloud-provider fit checks are never triggered.
+ */
+
+import type { ModelDefinition } from '@pellux/goodvibes-sdk/platform/providers';
+import {
+  estimateModelBytes,
+  fitAssessment,
+  fitVerdictLabel,
+  readHardwareProfileSync,
+} from '../core/hardware-profile.ts';
+import type { HardwareProfile } from '../core/hardware-profile.ts';
+
+/**
+ * Sentinel provider ID used on synthetic local recommendation entries.
+ * Must not collide with any real provider (ollama, lm-studio, etc.).
+ */
+export const LOCAL_REC_PROVIDER = 'local';
+
+/**
+ * Representative local model sizes to recommend.
+ * Each entry: { id, displayName, params, sizeLabel }
+ */
+const LOCAL_REC_SIZES = [
+  { id: 'local:3b', displayName: '3B model (small, fast)', params: 3_000_000_000, sizeLabel: '3B' },
+  { id: 'local:7b', displayName: '7B model (balanced)', params: 7_000_000_000, sizeLabel: '7B' },
+  { id: 'local:13b', displayName: '13B model (more capable)', params: 13_000_000_000, sizeLabel: '13B' },
+] as const;
+
+/**
+ * Sentinel id used on the synthetic "Sign in to a provider" row that is
+ * appended to the local-only list when no credentials are configured.
+ */
+export const SIGN_IN_ROW_ID = 'local:sign-in';
+
+/**
+ * Return true when a model entry is the synthetic sign-in affordance row.
+ * This row must never be committed as an active model.
+ */
+export function isProviderSignInRow(model: ModelDefinition): boolean {
+  return model.id === SIGN_IN_ROW_ID && model.provider === LOCAL_REC_PROVIDER;
+}
+
+/**
+ * Return true when a model entry is a synthetic local fit recommendation
+ * (i.e. not a real installed model).
+ */
+export function isLocalFitRecommendation(model: ModelDefinition): boolean {
+  return (
+    model.provider === LOCAL_REC_PROVIDER &&
+    (model.description ?? '').includes('not yet installed')
+  );
+}
+
+/**
+ * Build the synthetic "Sign in to a provider" row for the local-only list.
+ * Selecting this row routes to the provider picker; it must never be committed
+ * as an active model.
+ */
+export function buildSignInRow(): ModelDefinition {
+  return {
+    id: SIGN_IN_ROW_ID,
+    provider: LOCAL_REC_PROVIDER,
+    registryKey: SIGN_IN_ROW_ID,
+    displayName: 'Sign in to a provider →',
+    description: 'Open the provider sign-in flow to connect a cloud or local provider.',
+    capabilities: {
+      toolCalling: false,
+      codeEditing: false,
+      reasoning: false,
+      multimodal: false,
+    },
+    contextWindow: 0,
+    selectable: true,
+    tier: 'free',
+  };
+}
+
+/**
+ * Build synthetic local recommendation entries annotated with hardware fit
+ * labels for the current machine.
+ *
+ * Pass a `profile` override for deterministic tests; omit to use the
+ * process-level hardware probe (`readHardwareProfileSync`).
+ */
+export function buildLocalFitRecommendations(
+  profileOverride?: HardwareProfile,
+): ModelDefinition[] {
+  const profile = profileOverride ?? readHardwareProfileSync();
+
+  return LOCAL_REC_SIZES.map((spec) => {
+    const sizeBytes = estimateModelBytes(spec.params);
+    const verdict = fitAssessment(sizeBytes, profile);
+    const fitHint = fitVerdictLabel(verdict, spec.sizeLabel);
+    // Plain-language detail: never imply the model is ready to use.
+    const detail = fitHint
+      ? `recommended for your hardware — not yet installed (${fitHint})`
+      : 'recommended for your hardware — not yet installed';
+
+    const model: ModelDefinition = {
+      id: spec.id,
+      provider: LOCAL_REC_PROVIDER,
+      registryKey: spec.id,
+      displayName: spec.displayName,
+      description: detail,
+      capabilities: {
+        toolCalling: true,
+        codeEditing: false,
+        reasoning: false,
+        multimodal: false,
+      },
+      contextWindow: 8192,
+      selectable: true,
+      tier: 'free',
+    };
+    return model;
+  });
+}

package/src/input/shell-passthrough.ts

@@ -0,0 +1,58 @@
+/**
+ * ShellPassthrough — runs user-typed `!<command>` shell escapes.
+ *
+ * The composer routes a leading `!` to "shell" mode; this runs the command
+ * directly (a user-initiated terminal escape, not an agent tool call), shows
+ * its output, and buffers a context block that is prepended to the user's next
+ * real message — making the result visible to the model on the next turn
+ * without triggering a turn of its own.
+ *
+ * A buffer is used rather than appending a conversation message because the
+ * SDK drops `system` messages from the LLM view and does not merge consecutive
+ * `user` messages (which would trip a consecutive-user-message API error).
+ */
+
+const MAX_SHELL_OUTPUT = 16_000;
+
+export const SHELL_USAGE_HINT =
+  '[Shell] Usage: !<command> — runs a shell command; its output is shown and added as context for your next message.';
+
+export interface ShellRunResult {
+  /** Formatted output for the conversation/activity feed. */
+  readonly display: string;
+  /** Context block buffered for the user's next turn. */
+  readonly context: string;
+}
+
+export class ShellPassthrough {
+  private pending: string[] = [];
+
+  /** Run `command` in `cwd`, returning display + model-context renderings. */
+  async run(command: string, cwd: string): Promise<ShellRunResult> {
+    const proc = Bun.spawn(['bash', '-c', command], { cwd, stdout: 'pipe', stderr: 'pipe' });
+    const [out, err] = await Promise.all([
+      new Response(proc.stdout).text(),
+      new Response(proc.stderr).text(),
+    ]);
+    const exitCode = await proc.exited;
+    const combined = [out, err].filter((s) => s.trim().length > 0).join('\n').trimEnd();
+    const truncated = combined.length > MAX_SHELL_OUTPUT
+      ? `${combined.slice(0, MAX_SHELL_OUTPUT)}\n… [truncated ${combined.length - MAX_SHELL_OUTPUT} chars]`
+      : combined;
+    const body = truncated.length > 0 ? truncated : '(no output)';
+    const result: ShellRunResult = {
+      display: `[Shell] ${body}\n(exit ${exitCode})`,
+      context: `The user ran a shell command via the \`!\` prefix:\n$ ${command}\n--- output (exit ${exitCode}) ---\n${body}`,
+    };
+    this.pending.push(result.context);
+    return result;
+  }
+
+  /** Prepend (and clear) any buffered shell context onto an outgoing message. */
+  consumeContext(text: string): string {
+    if (this.pending.length === 0) return text;
+    const context = this.pending.join('\n\n');
+    this.pending = [];
+    return text ? `${context}\n\n${text}` : context;
+  }
+}

package/src/input/submission-router.ts

@@ -3,13 +3,11 @@ import type { SubmissionIntent } from './submission-intent.ts';
 export interface SubmissionRouterInput {
   readonly text: string;
   readonly commandMode?: boolean;
-  readonly panelFocused?: boolean;
   readonly hasAttachments?: boolean;
 }
 
 const PLAN_COMMANDS = new Set(['plan']);
 const DELEGATION_COMMANDS = new Set(['delegate', 'build', 'review', 'wrfc', 'agents', 'remote']);
-const PANEL_COMMANDS = new Set(['panel']);
 const ORCHESTRATION_COMMANDS = new Set([
   'orchestration',
   'tasks',
@@ -45,9 +43,6 @@ export function routeSubmissionIntent(input: SubmissionRouterInput): SubmissionI
     if (DELEGATION_COMMANDS.has(commandName)) {
       return { kind: 'delegation', label: 'delegation', commandName, hasAttachments };
     }
-    if (PANEL_COMMANDS.has(commandName)) {
-      return { kind: 'slash-command', label: 'Agent workspace', commandName, hasAttachments };
-    }
     if (ORCHESTRATION_COMMANDS.has(commandName)) {
       return { kind: 'orchestration', label: 'orchestration', commandName, hasAttachments };
     }