@pellux/goodvibes-agent 1.1.1 → 1.1.3

package/docs/channels-remote-and-api.md

@@ -47,7 +47,7 @@ Use public connected-host/operator routes only. For Agent Knowledge, the only va
 /api/goodvibes-agent/knowledge/*
 ```
 
-If an Agent-specific route is missing, fail closed or show guidance. Do not substitute the default knowledge, another product segment, or private connected-host files. If an Agent-specific route returns default scope metadata, treat that as contamination and fail the call.
+If an Agent-specific route is missing, fail closed or show guidance. Do not substitute the default knowledge, another product segment, or private connected-host files. Normalize parseable public Agent-route scope aliases before rendering, and fail the call when the response carries known non-Agent contamination.
 
 Harness and settings operations use the Agent-owned `agent_harness` tool. Generic settings/context mutators are not the model-facing Agent contract.
 

package/docs/connected-host.md

@@ -79,6 +79,6 @@ The model can inspect live connected-host readiness with `agent_harness` mode `c
 
 The model can inspect companion pairing posture with `agent_harness` mode `pairing_posture`, and inspect one pairing/mobile route with `pairing_route`. Those modes report the control-plane endpoint binding, pairing surface id, token presence/fingerprint, and route catalog without returning raw tokens or QR payloads. Pairing display, manual token display, companion connection, channel delivery, task, approval, provider/model, and attachment actions remain visible user flows.
 
-Agent Knowledge is its own product segment. Agent uses `/api/goodvibes-agent/knowledge/*` only and must not fall back to default knowledge or other product-specific knowledge routes. Agent also rejects successful-looking responses that expose default scope metadata or known non-Agent payload markers.
+Agent Knowledge is its own product segment. Agent uses `/api/goodvibes-agent/knowledge/*` only and must not fall back to default knowledge or other product-specific knowledge routes. Agent normalizes public Agent-route scope aliases and rejects successful-looking responses that carry known non-Agent payload markers.
 
 Normal assistant chat uses companion chat. Build/fix/review work is delegated explicitly to GoodVibes TUI through public runtime/session contracts, and delegated review is requested only when explicitly asked for build/fix/review work.

package/docs/getting-started.md

@@ -130,7 +130,7 @@ Use Agent Workspace -> Knowledge for source-backed Agent Knowledge. The valid co
 /api/goodvibes-agent/knowledge/*
 ```
 
-Agent commands fail closed if the route is unavailable or a successful-looking response exposes default-scope metadata.
+Agent commands fail closed if the route is unavailable or a successful-looking response carries non-Agent contamination. Parseable public Agent-route scope aliases are normalized before rendering.
 
 The Knowledge workspace also exposes route-backed and command-backed workflows for issue review, prompt packet previews, context-selection explain output, consolidation, and reindex. Read-only ask/search/list/get/map/connector/packet/explain paths do not require mutation confirmation. Ingest, review-issue, consolidation, and reindex paths require explicit confirmation.
 

package/docs/knowledge-artifacts-and-multimodal.md

@@ -43,7 +43,7 @@ If those routes are unavailable, Agent commands fail closed with a structured er
 
 The CLI and slash-command layers reject route-selection flags such as `--space`, `--knowledge-space`, `--knowledge-space-id`, and `--include-all-spaces` because those would violate the Agent product boundary.
 
-Successful route responses are validated before rendering. If a connected host response exposes default-scope metadata or carries known non-Agent payload markers, Agent returns a `scope_contamination` error instead of treating that payload as isolated Agent Knowledge.
+Successful route responses are validated before rendering. Parseable public Agent-route scope aliases are normalized. If a connected host response carries known non-Agent payload markers or unparseable default-scope text, Agent returns a `scope_contamination` error instead of treating that payload as isolated Agent Knowledge.
 
 Agent Knowledge writes are explicit-user-action paths. Slash commands that ingest, import, review issues, reindex, or run consolidation require `--yes`; ask/search/status/list/get/map/connector paths remain read-only.
 

package/docs/tools-and-commands.md

@@ -163,7 +163,7 @@ goodvibes-agent knowledge reindex --yes
 /knowledge consolidate light --yes
 ```
 
-Agent rejects route-selection flags that would target another knowledge space, including `--space`, `--knowledge-space`, `--knowledge-space-id`, and `--include-all-spaces`. Contaminated connected-host responses return `scope_contamination`.
+Agent rejects route-selection flags that would target another knowledge space, including `--space`, `--knowledge-space`, `--knowledge-space-id`, and `--include-all-spaces`. Parseable public Agent-route scope aliases are normalized; contaminated connected-host responses return `scope_contamination`.
 
 ## Approvals, Automation, And Schedules
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pellux/goodvibes-agent",
-  "version": "1.1.1",
+  "version": "1.1.3",
   "private": false,
   "description": "GoodVibes personal operator assistant TUI with a proactive Agent product brain, isolated Agent Knowledge, local profiles, routines, skills, personas, and explicit build delegation.",
   "type": "module",
@@ -87,7 +87,7 @@
   },
   "dependencies": {},
   "devDependencies": {
-    "@pellux/goodvibes-sdk": "0.33.36",
+    "@pellux/goodvibes-sdk": "0.33.37",
     "sql.js": "^1.14.1",
     "sqlite-vec": "^0.1.9",
     "zustand": "^5.0.12",

package/release/release-notes.md

@@ -13,7 +13,7 @@
 - Completed resilient shortcut/keybinding discovery: `agent_harness` returns fixed shortcuts and default-fallback keybinding descriptors when the live keybinding manager is absent, while keybinding execution and mutation still fail closed until the runtime manager is available.
 - Completed the model-visible operator method catalog: `agent_harness` can now list and inspect allowlisted public operator and Agent Knowledge methods with their owning first-class model tools, confirmation policy, and boundaries, without exposing arbitrary route invocation.
 - Expanded first-class Agent Knowledge reads: `agent_knowledge` now covers status, ask, search, source/node/issue lists, item lookup, map summary, connector list/detail, and connector doctor while staying inside `/api/goodvibes-agent/knowledge/*`.
-- Added fail-closed Agent Knowledge response-scope validation: CLI, model tools, and live verification reject successful-looking payloads that expose default scope metadata or known non-Agent payload markers.
+- Added Agent-owned Knowledge response-scope validation: CLI, model tools, and live verification normalize public Agent-route scope aliases and reject successful-looking payloads with known non-Agent payload markers.
 - Expanded release-route enforcement for Agent Knowledge: architecture/package policy now guards the full route catalog, and live verification definitions include source, node, issue, map, and connector read routes in addition to status, ask, and search.
 - Verified the release line against connected-host public Agent routes for Agent Knowledge alias scope normalization and telephony channel surface support.
 - Renamed active release evidence artifacts to current-release paths under `release/`, including release notes, readiness inventory, performance snapshot, and live-verification reports, so current release metadata no longer depends on stale historical filenames.

package/release/release-readiness.json

@@ -123,8 +123,8 @@
         "capabilityCoverage": "Covers isolated Agent Knowledge ask, search, source review, connectors, ingest, reindex, consolidation, graph operations, and status without default knowledge fallback.",
         "userAccess": "The user can operate Agent Knowledge from the workspace, /knowledge, and goodvibes-agent knowledge CLI mirrors.",
         "modelAccess": "agent_knowledge and agent_knowledge_ingest expose status, ask/search, source/node/issue lists, item lookup, map summary, connector inspection, and ingest; agent_harness mode:\"workspace_actions\", mode:\"workspace_action\", mode:\"run_workspace_action\", mode:\"commands\", mode:\"command\", mode:\"run_command\", mode:\"operator_methods\", mode:\"operator_method\", mode:\"tools\", and mode:\"tool\" expose review, packet/explain, consolidation, reindex, tool schemas, and route metadata to the model.",
-        "safetyBoundary": "Connected-host Knowledge traffic targets only /api/goodvibes-agent/knowledge/*, rejects non-Agent space-selection flags, and fails closed when successful responses expose default scope metadata or known non-Agent payload markers; local Knowledge service review/consolidation routes remain isolated to Agent Knowledge.",
-        "releaseEvidence": "Package-facing required text, architecture policy, readiness evidence, and live verification checks require isolated Knowledge status, ask, search, library, item, map, connector outcomes, and response-scope contamination detection."
+        "safetyBoundary": "Connected-host Knowledge traffic targets only /api/goodvibes-agent/knowledge/*, rejects non-Agent space-selection flags, normalizes parseable public Agent-route scope aliases, and fails closed on known non-Agent payload markers; local Knowledge service review/consolidation routes remain isolated to Agent Knowledge.",
+        "releaseEvidence": "Package-facing required text, architecture policy, readiness evidence, and live verification checks require isolated Knowledge status, ask, search, library, item, map, connector outcomes, Agent-route scope alias normalization, and response contamination detection."
       }
     },
     {
@@ -453,8 +453,8 @@
         "capabilityCoverage": "Covers Agent Knowledge handlers, ingestion, connectors, graph operations, refinement, jobs, schedules, ask, search, and status through isolated connected-host routes.",
         "userAccess": "The user can operate isolated Agent Knowledge from TUI and CLI without selecting or leaking into non-Agent knowledge spaces.",
         "modelAccess": "agent_knowledge, agent_knowledge_ingest, agent_harness mode:\"operator_methods\" and mode:\"operator_method\", and connected-host capability reports expose isolated Knowledge operation to the model.",
-        "safetyBoundary": "Only /api/goodvibes-agent/knowledge/* routes are allowed, and Agent rejects default or alternate knowledge space routing plus successful responses that carry default scope metadata.",
-        "releaseEvidence": "Readiness evidence cites connected-host evidence alias and Knowledge docs, with live verification requiring isolated status, ask, search, library, item, map, connector checks, and response-scope contamination detection."
+        "safetyBoundary": "Only /api/goodvibes-agent/knowledge/* routes are allowed. Agent rejects alternate knowledge space routing, normalizes parseable public Agent-route scope aliases, and fails closed on known non-Agent payload markers.",
+        "releaseEvidence": "Readiness evidence cites connected-host evidence alias and Knowledge docs, with live verification requiring isolated status, ask, search, library, item, map, connector checks, Agent-route scope alias normalization, and response contamination detection."
       }
     },
     {

package/src/agent/knowledge-scope-alias.ts

@@ -0,0 +1,56 @@
+import {
+  DEFAULT_KNOWLEDGE_SPACE_ID,
+  goodVibesAgentKnowledgeSpaceId,
+} from '@pellux/goodvibes-sdk/platform/knowledge';
+
+type JsonRecord = Record<string, unknown>;
+
+const AGENT_KNOWLEDGE_PUBLIC_SPACE_ID = goodVibesAgentKnowledgeSpaceId();
+const AGENT_KNOWLEDGE_SCOPE_FIELDS = new Set(['spaceId', 'knowledgeSpaceId', 'namespace']);
+
+function isRecord(value: unknown): value is JsonRecord {
+  return Boolean(value) && typeof value === 'object' && !Array.isArray(value);
+}
+
+function isDefaultScopeValue(value: unknown): boolean {
+  return typeof value === 'string' && value.trim().toLowerCase() === DEFAULT_KNOWLEDGE_SPACE_ID;
+}
+
+export function normalizeAgentKnowledgeScopeAliases<TValue>(value: TValue): TValue {
+  if (Array.isArray(value)) {
+    let changed = false;
+    const normalized = value.map((item) => {
+      const next = normalizeAgentKnowledgeScopeAliases(item);
+      if (next !== item) changed = true;
+      return next;
+    });
+    return (changed ? normalized : value) as TValue;
+  }
+
+  if (!isRecord(value)) return value;
+
+  let changed = false;
+  const output: JsonRecord = {};
+  for (const [key, nested] of Object.entries(value)) {
+    if (AGENT_KNOWLEDGE_SCOPE_FIELDS.has(key) && isDefaultScopeValue(nested)) {
+      output[key] = AGENT_KNOWLEDGE_PUBLIC_SPACE_ID;
+      changed = true;
+      continue;
+    }
+    const normalized = normalizeAgentKnowledgeScopeAliases(nested);
+    output[key] = normalized;
+    if (normalized !== nested) changed = true;
+  }
+
+  return (changed ? output : value) as TValue;
+}
+
+export function normalizeAgentKnowledgeJsonText(body: string): string {
+  try {
+    const parsed = JSON.parse(body) as unknown;
+    const normalized = normalizeAgentKnowledgeScopeAliases(parsed);
+    return normalized === parsed ? body : JSON.stringify(normalized);
+  } catch {
+    return body;
+  }
+}

package/src/cli/agent-knowledge-runtime.ts

@@ -1,6 +1,7 @@
-import { createBrowserAgentSdk } from '@pellux/goodvibes-sdk/browser/agent';
+import { createBrowserAgentSdk, type BrowserAgentSdk } from '@pellux/goodvibes-sdk/browser/agent';
 import { summarizeError } from '@pellux/goodvibes-sdk/platform/utils';
 import { VERSION } from '../version.ts';
+import { normalizeAgentKnowledgeScopeAliases } from '../agent/knowledge-scope-alias.ts';
 import { readConnectedHostOperatorToken } from '../runtime/connected-host-auth.ts';
 import type { ConnectedHostCallMethod } from './agent-knowledge-methods.ts';
 
@@ -106,18 +107,32 @@ export async function classifyKnowledgeError(error: unknown, connection: AgentKn
   return { ok: false, kind: 'connected_host_error', error: message, baseUrl: connection.baseUrl, route };
 }
 
-export function createAgentSdk(connection: AgentKnowledgeConnection) {
-  return createBrowserAgentSdk({
+export function normalizeAgentKnowledgeData<TData>(data: TData): TData {
+  return normalizeAgentKnowledgeScopeAliases(data);
+}
+
+export function createAgentSdk(connection: AgentKnowledgeConnection): BrowserAgentSdk {
+  const sdk = createBrowserAgentSdk({
     baseUrl: connection.baseUrl,
     authToken: connection.token,
   });
+  return {
+    ...sdk,
+    knowledge: {
+      ...sdk.knowledge,
+      ask: async (input) => normalizeAgentKnowledgeData(await sdk.knowledge.ask(input)),
+      search: async (input) => normalizeAgentKnowledgeData(await sdk.knowledge.search(input)),
+      status: async (input) => normalizeAgentKnowledgeData(await sdk.knowledge.status(input)),
+      map: async (input) => normalizeAgentKnowledgeData(await sdk.knowledge.map(input)),
+    },
+  };
 }
 
-const AGENT_KNOWLEDGE_SCOPE_KEYS = new Set(['spaceid', 'knowledgespaceid']);
+const AGENT_KNOWLEDGE_SCOPE_KEYS = new Set(['spaceid', 'knowledgespaceid', 'namespace']);
 const AGENT_KNOWLEDGE_SCOPE_TEXT_PATTERNS: readonly { readonly label: string; readonly pattern: RegExp }[] = [
   {
     label: 'default knowledge scope id',
-    pattern: /["']?(?:knowledge[-_\s]*space[-_\s]*id|knowledgespaceid|space[-_\s]*id|spaceid)["']?\s*[:=]\s*["']?default["']?/i,
+    pattern: /["']?(?:knowledge[-_\s]*space[-_\s]*id|knowledgespaceid|space[-_\s]*id|spaceid|namespace)["']?\s*[:=]\s*["']?default["']?/i,
   },
   { label: 'host assistant payload marker', pattern: /home\s*assistant/i },
   { label: 'host graph payload marker', pattern: /home\s*graph|homegraph/i },
@@ -189,9 +204,10 @@ export function validateAgentKnowledgeData<TData>(
   connection: AgentKnowledgeConnection,
   method: ConnectedHostCallMethod,
 ): AgentKnowledgeResult<TData> {
-  const contamination = findAgentKnowledgeScopeContamination(data);
+  const normalized = normalizeAgentKnowledgeData(data);
+  const contamination = findAgentKnowledgeScopeContamination(normalized);
   if (contamination) return agentKnowledgeScopeContaminationFailure(connection, method.route, contamination);
-  return { ok: true, kind: method.kind, route: method.route, data };
+  return { ok: true, kind: method.kind, route: method.route, data: normalized };
 }
 
 export async function postAgentKnowledgeJson<TData>(
@@ -220,7 +236,7 @@ export async function postAgentKnowledgeJson<TData>(
     const detail = isRecord(parsed) && typeof parsed.error === 'string' ? parsed.error : text;
     throw new Error(`HTTP ${response.status} ${response.statusText}${detail ? `: ${detail}` : ''}`);
   }
-  return parsed as TData;
+  return normalizeAgentKnowledgeData(parsed as TData);
 }
 
 function queryRoute(route: string, query: JsonRecord): string {
@@ -264,7 +280,7 @@ export async function getAgentKnowledgeJson<TData>(
     const detail = isRecord(parsed) && typeof parsed.error === 'string' ? parsed.error : text;
     throw new Error(`HTTP ${response.status} ${response.statusText}${detail ? `: ${detail}` : ''}`);
   }
-  return parsed as TData;
+  return normalizeAgentKnowledgeData(parsed as TData);
 }
 
 export function findDisallowedKnowledgeScopeFlag(args: readonly string[]): string | null {

package/src/input/agent-workspace-categories.ts

@@ -617,7 +617,6 @@ export const AGENT_WORKSPACE_CATEGORIES: readonly AgentWorkspaceCategory[] = [
     detail: 'Use this final step after reviewing setup. Apply & close writes the user onboarding completion marker so normal future launches start in the main conversation.',
     actions: [
       { id: 'onboarding-apply-close', label: 'Apply & close', detail: 'Acknowledge onboarding as finished, persist the user completion marker, and close the fullscreen Agent workspace.', kind: 'onboarding-complete', safety: 'safe' },
-      { id: 'finish-review-setup', label: 'Review setup first', detail: 'Jump back to setup before acknowledging onboarding as finished.', targetCategoryId: 'setup', kind: 'workspace', safety: 'safe' },
     ],
   },
 ];

package/src/version.ts

@@ -6,7 +6,7 @@ import { join } from 'node:path';
 // The prebuild script updates the fallback value before compilation.
 // Uses import.meta.dir (Bun) to locate package.json relative to this file,
 // which is correct regardless of the process working directory.
-let _version = '1.1.1';
+let _version = '1.1.3';
 try {
   const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8')) as {
     readonly version?: unknown;