@pellux/goodvibes-agent 0.1.9 → 0.1.11

package/src/verification/live-verifier.ts

@@ -213,6 +213,54 @@ async function fetchCheck(
   }
 }
 
+async function fetchJsonCheck(
+  id: string,
+  title: string,
+  url: string,
+  token: string | undefined,
+  options: {
+    readonly method?: 'GET' | 'POST';
+    readonly body?: unknown;
+    readonly validate: (status: number, body: string) => { status: LiveVerificationStatus; summary: string; detail?: string };
+  },
+): Promise<LiveVerificationCheck> {
+  if (!token) {
+    return {
+      id,
+      title,
+      status: 'skip',
+      summary: 'No daemon bearer token was available.',
+    };
+  }
+  try {
+    const response = await fetch(url, {
+      method: options.method ?? 'GET',
+      headers: {
+        Authorization: `Bearer ${token}`,
+        'Content-Type': 'application/json',
+      },
+      body: options.body === undefined ? undefined : JSON.stringify(options.body),
+      signal: AbortSignal.timeout(5000),
+    });
+    const body = await response.text();
+    const validated = options.validate(response.status, body);
+    return {
+      id,
+      title,
+      ...validated,
+      detail: validated.detail ?? compact(body),
+    };
+  } catch (error) {
+    return {
+      id,
+      title,
+      status: 'fail',
+      summary: 'Request failed.',
+      detail: error instanceof Error ? error.message : String(error),
+    };
+  }
+}
+
 function countStatuses(checks: readonly LiveVerificationCheck[]): Record<LiveVerificationStatus, number> {
   return checks.reduce<Record<LiveVerificationStatus, number>>(
     (counts, check) => {
@@ -256,7 +304,7 @@ export async function buildLiveVerificationReport(options: LiveVerificationOptio
 
   checks.push({
     id: 'compiled-cli-present',
-    title: 'Compiled GoodVibes CLI binary',
+    title: 'Compiled GoodVibes Agent CLI binary',
     status: existsSync(binaryPath) ? 'pass' : 'fail',
     summary: existsSync(binaryPath) ? `Found ${binaryPath}.` : `Missing ${binaryPath}.`,
   });
@@ -264,47 +312,61 @@ export async function buildLiveVerificationReport(options: LiveVerificationOptio
   if (existsSync(binaryPath)) {
     checks.push(commandCheck(
       'cli-version',
-      'CLI version command',
-      await runCommand(binaryPath, ['version'], projectRoot),
-      'CLI version returned successfully.',
+      'Agent CLI version command',
+      await runCommand(binaryPath, ['--version'], projectRoot),
+      'Agent CLI version returned successfully.',
     ));
     checks.push(commandCheck(
       'cli-status-json',
-      'CLI status JSON command',
-      await runCommand(binaryPath, ['status', '--output', 'json'], projectRoot),
-      'CLI status returned parseable JSON.',
+      'Agent CLI status JSON command',
+      await runCommand(binaryPath, ['status', '--json'], projectRoot),
+      'Agent CLI status returned parseable JSON.',
+      { parseJson: true },
+    ));
+    checks.push(commandCheck(
+      'cli-compat-json',
+      'Agent CLI compatibility JSON command',
+      await runCommand(binaryPath, ['compat', '--json'], projectRoot),
+      'Agent CLI compatibility returned parseable JSON.',
       { parseJson: true },
     ));
+    checks.push(commandCheck(
+      'cli-agent-knowledge-status',
+      'Agent Knowledge CLI status command',
+      await runCommand(binaryPath, ['knowledge', 'status', '--json'], projectRoot),
+      'Agent Knowledge status returned parseable JSON.',
+      { parseJson: true, warnOnNonZero: true },
+    ));
     checks.push(commandCheck(
       'cli-providers',
-      'CLI providers command',
+      'Agent CLI providers command',
       await runCommand(binaryPath, ['providers'], projectRoot),
       'Provider inventory rendered successfully.',
     ));
     checks.push(commandCheck(
       'cli-control-plane-status',
-      'CLI control-plane status command',
+      'Read-only control-plane status command',
       await runCommand(binaryPath, ['control-plane', 'status'], projectRoot),
       'Control-plane status rendered successfully.',
       { warnOnNonZero: true },
     ));
     checks.push(commandCheck(
       'cli-listener-test',
-      'CLI listener readiness command',
+      'Read-only listener readiness command',
       await runCommand(binaryPath, ['listener', 'test'], projectRoot),
       'HTTP listener readiness rendered successfully.',
       { warnOnNonZero: true },
     ));
     checks.push(commandCheck(
       'cli-surfaces-check',
-      'CLI surfaces readiness command',
+      'Read-only surfaces readiness command',
       await runCommand(binaryPath, ['surfaces', 'check'], projectRoot),
       'Surface readiness rendered successfully.',
       { warnOnNonZero: true },
     ));
     checks.push(commandCheck(
       'cli-service-check',
-      'CLI service posture command',
+      'Read-only service posture command',
       await runCommand(binaryPath, ['service', 'check'], projectRoot),
       'Service posture rendered successfully.',
       { warnOnNonZero: true },
@@ -376,6 +438,79 @@ export async function buildLiveVerificationReport(options: LiveVerificationOptio
     },
   ));
 
+  checks.push(await fetchJsonCheck(
+    'agent-knowledge-status',
+    'Agent Knowledge isolated /status',
+    `${daemonBaseUrl}/api/goodvibes-agent/knowledge/status`,
+    token,
+    {
+      validate: (status, body) => {
+        if (status !== 200) return { status: 'fail', summary: `/api/goodvibes-agent/knowledge/status returned ${status}.` };
+        try {
+          JSON.parse(body);
+          return { status: 'pass', summary: 'Agent Knowledge status route returned parseable JSON.' };
+        } catch {
+          return { status: 'fail', summary: 'Agent Knowledge status was not parseable JSON.' };
+        }
+      },
+    },
+  ));
+
+  checks.push(await fetchJsonCheck(
+    'agent-knowledge-ask-isolated',
+    'Agent Knowledge isolated ask',
+    `${daemonBaseUrl}/api/goodvibes-agent/knowledge/ask`,
+    token,
+    {
+      method: 'POST',
+      body: {
+        query: 'What is GoodVibes Agent?',
+        limit: 5,
+        mode: 'concise',
+        includeSources: true,
+        includeConfidence: true,
+        includeLinkedObjects: true,
+      },
+      validate: (status, body) => {
+        if (status !== 200) return { status: 'fail', summary: `/api/goodvibes-agent/knowledge/ask returned ${status}.` };
+        try {
+          JSON.parse(body);
+        } catch {
+          return { status: 'fail', summary: 'Agent Knowledge ask was not parseable JSON.' };
+        }
+        const lower = body.toLowerCase();
+        if (lower.includes('home assistant') || lower.includes('homegraph') || lower.includes('home graph')) {
+          return { status: 'fail', summary: 'Agent Knowledge ask returned HomeGraph/Home Assistant contamination.' };
+        }
+        return { status: 'pass', summary: 'Agent Knowledge ask stayed on the isolated Agent route.' };
+      },
+    },
+  ));
+
+  checks.push(await fetchJsonCheck(
+    'agent-knowledge-search-isolated',
+    'Agent Knowledge isolated search',
+    `${daemonBaseUrl}/api/goodvibes-agent/knowledge/search`,
+    token,
+    {
+      method: 'POST',
+      body: { query: 'What is GoodVibes Agent?', limit: 5 },
+      validate: (status, body) => {
+        if (status !== 200) return { status: 'fail', summary: `/api/goodvibes-agent/knowledge/search returned ${status}.` };
+        try {
+          JSON.parse(body);
+        } catch {
+          return { status: 'fail', summary: 'Agent Knowledge search was not parseable JSON.' };
+        }
+        const lower = body.toLowerCase();
+        if (lower.includes('home assistant') || lower.includes('homegraph') || lower.includes('home graph')) {
+          return { status: 'fail', summary: 'Agent Knowledge search returned HomeGraph/Home Assistant contamination.' };
+        }
+        return { status: 'pass', summary: 'Agent Knowledge search stayed on the isolated Agent route.' };
+      },
+    },
+  ));
+
   const counts = countStatuses(checks);
   const ok = counts.fail === 0 && (!options.strict || counts.warn === 0);
   return {
@@ -392,7 +527,7 @@ export async function buildLiveVerificationReport(options: LiveVerificationOptio
 
 export function renderLiveVerificationReportMarkdown(report: LiveVerificationReport): string {
   const lines: string[] = [
-    '# GoodVibes Live Verification',
+    '# GoodVibes Agent Live Verification',
     '',
     `Generated: ${report.generatedAt}`,
     `Home: \`${report.homeDir}\``,

package/src/version.ts

@@ -6,12 +6,19 @@ import { join } from 'node:path';
 // The prebuild script updates the fallback value before compilation.
 // Uses import.meta.dir (Bun) to locate package.json relative to this file,
 // which is correct regardless of the process working directory.
-let _version = '0.1.9';
+let _version = '0.1.11';
+let _sdkVersion = '0.33.35';
 try {
-  const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8'));
-  _version = pkg.version ?? _version;
+  const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8')) as {
+    readonly version?: unknown;
+    readonly dependencies?: Record<string, unknown>;
+  };
+  _version = typeof pkg.version === 'string' ? pkg.version : _version;
+  const packageSdkVersion = pkg.dependencies?.['@pellux/goodvibes-sdk'];
+  _sdkVersion = typeof packageSdkVersion === 'string' ? packageSdkVersion : _sdkVersion;
 } catch {
   // Compiled binary or missing package.json — use fallback
 }
 
 export const VERSION = _version;
+export const SDK_VERSION = _sdkVersion;

package/src/input/commands/quit-shared.ts

@@ -1,162 +0,0 @@
-import type { StatusResult } from 'simple-git';
-import { basename } from 'path';
-import type { CommandContext } from '../command-registry.ts';
-import { GitService } from '@pellux/goodvibes-sdk/platform/git';
-import { summarizeError } from '@pellux/goodvibes-sdk/platform/utils';
-
-type GitLike = Pick<GitService, 'addAll' | 'status' | 'commit'>;
-
-export type GitChange = {
-  action: 'add' | 'update' | 'delete' | 'rename';
-  path: string;
-  from?: string;
-  to?: string;
-};
-
-type GitStatusLike = Pick<StatusResult, 'staged' | 'modified' | 'not_added' | 'deleted' | 'created' | 'renamed'> & {
-  isClean?: () => boolean;
-};
-
-export function collectGitChanges(status: GitStatusLike): GitChange[] {
-  const changes = new Map<string, GitChange>();
-
-  for (const rename of status.renamed ?? []) {
-    const to = rename.to || rename.from;
-    if (!to) continue;
-    changes.set(to, { action: 'rename', path: to, from: rename.from, to: rename.to });
-  }
-
-  for (const path of status.created ?? []) {
-    if (!changes.has(path)) changes.set(path, { action: 'add', path });
-  }
-
-  for (const path of status.not_added ?? []) {
-    if (!changes.has(path)) changes.set(path, { action: 'add', path });
-  }
-
-  for (const path of status.deleted ?? []) {
-    if (!changes.has(path)) changes.set(path, { action: 'delete', path });
-  }
-
-  for (const path of status.modified ?? []) {
-    if (!changes.has(path)) changes.set(path, { action: 'update', path });
-  }
-
-  for (const path of status.staged ?? []) {
-    if (!changes.has(path)) changes.set(path, { action: 'update', path });
-  }
-
-  return Array.from(changes.values()).sort((a, b) => a.path.localeCompare(b.path));
-}
-
-function formatList(items: string[]): string {
-  if (items.length === 0) return '';
-  if (items.length === 1) return items[0]!;
-  if (items.length === 2) return `${items[0]} and ${items[1]}`;
-  return `${items.slice(0, -1).join(', ')}, and ${items[items.length - 1]}`;
-}
-
-function topLevelScope(path: string): string {
-  const normalized = path.replace(/\\/g, '/').replace(/^\.\/+/, '');
-  if (!normalized) return 'root';
-  const [first] = normalized.split('/');
-  return first && first.length > 0 ? first : 'root';
-}
-
-function summarizeScopes(changes: GitChange[]): string | null {
-  const scopes = Array.from(new Set(changes.map((change) => topLevelScope(change.path)).filter(Boolean)));
-  if (scopes.length === 0) return null;
-  if (scopes.length <= 3) {
-    return scopes.length === 1 ? `${scopes[0]} files` : `${formatList(scopes)} files`;
-  }
-  return `${changes.length} files`;
-}
-
-function shortPath(path: string): string {
-  return path.length > 42 ? basename(path) : path;
-}
-
-export function buildWriteQuitCommitMessage(changes: GitChange[]): string {
-  if (changes.length === 0) return 'Update working tree';
-
-  if (changes.length === 1) {
-    const [change] = changes;
-    if (!change) return 'Update working tree';
-    if (change.action === 'rename') {
-      return `Rename ${shortPath(change.from ?? change.path)} to ${shortPath(change.to ?? change.path)}`;
-    }
-    const verb = change.action === 'add'
-      ? 'Add'
-      : change.action === 'delete'
-        ? 'Delete'
-        : 'Update';
-    return `${verb} ${shortPath(change.path)}`;
-  }
-
-  const uniqueActions = Array.from(new Set(changes.map((change) => change.action)));
-  if (uniqueActions.length === 1) {
-    const [action] = uniqueActions;
-    const verb = action === 'add'
-      ? 'Add'
-      : action === 'delete'
-        ? 'Delete'
-        : action === 'rename'
-          ? 'Rename'
-          : 'Update';
-    const scopeLabel = summarizeScopes(changes);
-    if (scopeLabel) return `${verb} ${scopeLabel}`;
-    return `${verb} ${changes.length} files`;
-  }
-
-  const scopeLabel = summarizeScopes(changes);
-  if (scopeLabel) return `Update ${scopeLabel}`;
-  return `Update ${changes.length} files`;
-}
-
-export type ExecuteWriteQuitOptions = {
-  cwd?: string;
-  isGitRepo?: (cwd: string) => boolean;
-  getRepoRoot?: (cwd: string) => string | null;
-  gitFactory?: (cwd: string) => GitLike;
-};
-
-export async function executeWriteQuit(
-  ctx: Pick<CommandContext, 'print' | 'exit'> & {
-    workspace?: CommandContext['workspace'];
-  },
-  options: ExecuteWriteQuitOptions = {},
-): Promise<void> {
-  const cwd = options.cwd ?? ctx.workspace?.shellPaths?.workingDirectory;
-  if (!cwd) {
-    throw new Error('commandContext.workspace.shellPaths is required when executeWriteQuit() is called without an explicit cwd');
-  }
-  const isGitRepo = options.isGitRepo ?? ((dir: string) => GitService.isGitRepo(dir));
-  if (!isGitRepo(cwd)) {
-    ctx.exit();
-    return;
-  }
-
-  const repoRoot = options.getRepoRoot?.(cwd) ?? GitService.getRepoRoot(cwd) ?? cwd;
-  const git = options.gitFactory?.(repoRoot) ?? new GitService(repoRoot);
-
-  try {
-    ctx.print(`[wq] Staging changes in ${repoRoot}...`);
-    await git.addAll();
-    const status = await git.status();
-    if (status.isClean()) {
-      ctx.print('[wq] Working tree clean. Exiting without creating a commit.');
-      ctx.exit();
-      return;
-    }
-
-    const changes = collectGitChanges(status);
-    const message = buildWriteQuitCommitMessage(changes);
-    ctx.print(`[wq] Committing ${changes.length} change${changes.length === 1 ? '' : 's'}: ${message}`);
-    const result = await git.commit(message);
-    const shortHash = result.hash ? result.hash.slice(0, 7) : 'unknown';
-    ctx.print(`[wq] Commit complete: ${shortHash} ${message}`);
-    ctx.exit();
-  } catch (error) {
-    ctx.print(`[wq] Commit failed: ${summarizeError(error)}`);
-  }
-}

package/src/renderer/git-status.ts

@@ -1,89 +0,0 @@
-import { GitService } from '@pellux/goodvibes-sdk/platform/git';
-import { logger } from '@pellux/goodvibes-sdk/platform/utils';
-import { summarizeError } from '@pellux/goodvibes-sdk/platform/utils';
-
-/** Git state shown in the header bar. */
-export interface GitHeaderInfo {
-  branch: string;
-  dirty: boolean;
-  ahead: number;
-  behind: number;
-}
-
-const FALLBACK: GitHeaderInfo = { branch: '?', dirty: false, ahead: 0, behind: 0 };
-
-/**
- * GitStatusProvider — Fetches git state for the header bar.
- *
- * Results are cached for 2 seconds (TTL). The next call after expiry triggers
- * a fresh fetch and returns the cached value immediately (stale-while-revalidate).
- * Never throws — returns FALLBACK on any error.
- */
-export class GitStatusProvider {
-  private cache: GitHeaderInfo = { ...FALLBACK };
-  private lastFetch = 0;
-  private readonly ttlMs = 2000;
-  private fetching = false;
-
-  constructor(private readonly workingDirectory: string) {}
-
-  /** Returns cached info immediately; refreshes in background if TTL expired. */
-  async getStatus(): Promise<GitHeaderInfo> {
-    const now = Date.now();
-    if (now - this.lastFetch < this.ttlMs) {
-      return this.cache;
-    }
-    // Fetch synchronously on first call (no cache yet), otherwise return stale
-    if (this.lastFetch === 0) {
-      await this._fetch().catch(() => {
-        // Ensure fallback is set if _fetch failed before setting lastFetch
-        if (this.lastFetch === 0) {
-          this.lastFetch = Date.now();
-        }
-      });
-    } else if (!this.fetching) {
-      this._fetch().catch(err => { logger.debug('GitStatusProvider: background refresh failed', { error: summarizeError(err) }); });
-    }
-    return this.cache;
-  }
-
-  /** Force a fresh fetch and update the cache. Returns updated info. */
-  async refresh(): Promise<GitHeaderInfo> {
-    await this._fetch();
-    return this.cache;
-  }
-
-  private async _fetch(): Promise<void> {
-    if (this.fetching) return;
-    this.fetching = true;
-    try {
-      const git = new GitService(this.workingDirectory);
-      const [statusResult, branchResult] = await Promise.all([
-        git.status(),
-        git.branch(),
-      ]);
-      const dirty =
-        statusResult.modified.length > 0 ||
-        statusResult.created.length > 0 ||
-        statusResult.deleted.length > 0 ||
-        statusResult.renamed.length > 0 ||
-        statusResult.conflicted.length > 0 ||
-        statusResult.not_added.length > 0;
-      this.cache = {
-        branch: branchResult.current || '?',
-        dirty,
-        ahead: statusResult.ahead ?? 0,
-        behind: statusResult.behind ?? 0,
-      };
-      this.lastFetch = Date.now();
-    } catch {
-      // Never throw — return fallback
-      if (this.lastFetch === 0) {
-        this.cache = { ...FALLBACK };
-        this.lastFetch = Date.now();
-      }
-    } finally {
-      this.fetching = false;
-    }
-  }
-}