@pellux/goodvibes-agent 0.1.56 → 0.1.58

package/src/agent/routine-schedule-promotion.ts

@@ -1,12 +1,9 @@
-import { existsSync, mkdirSync, readFileSync, renameSync, writeFileSync } from 'node:fs';
-import { dirname, join } from 'node:path';
+import { existsSync, readFileSync } from 'node:fs';
+import { join } from 'node:path';
 import { createBrowserGoodVibesSdk } from '@pellux/goodvibes-sdk/browser';
 import type { OperatorMethodInput, OperatorMethodOutput } from '@pellux/goodvibes-sdk/contracts';
-import { formatEveryInterval } from '@pellux/goodvibes-sdk/platform/automation';
 import { summarizeError } from '@pellux/goodvibes-sdk/platform/utils';
-import type { ShellPathService } from '@/runtime/index.ts';
 import { getModelIdFromProviderModel, getProviderIdFromModel } from '../config/provider-model.ts';
-import { GOODVIBES_AGENT_SURFACE_ROOT } from '../config/surface.ts';
 import { SDK_VERSION } from '../version.ts';
 import type { AgentRoutineRecord } from './routine-registry.ts';
 
@@ -16,7 +13,6 @@ export const ROUTINE_SCHEDULE_LIST_METHOD = 'schedules.list';
 
 type ScheduleCreateInput = OperatorMethodInput<'schedules.create'>;
 type ScheduleCreateOutput = OperatorMethodOutput<'schedules.create'>;
-type ScheduleListOutput = OperatorMethodOutput<'schedules.list'>;
 type ScheduleDeliveryInput = NonNullable<ScheduleCreateInput['delivery']>;
 type ScheduleDeliveryTargetInput = ScheduleDeliveryInput['targets'] extends readonly (infer T)[] ? T : never;
 
@@ -210,30 +206,6 @@ export type RoutineScheduleCorrelationResult =
   | RoutineScheduleCorrelationSuccess
   | RoutineScheduleCorrelationFailure;
 
-interface RoutineScheduleReceiptStoreFile {
-  readonly version: 1;
-  readonly receipts: readonly RoutineScheduleReceipt[];
-}
-
-const RECEIPT_STORE_VERSION = 1;
-const DELIVERY_SURFACE_KINDS: readonly RoutineScheduleDeliverySurfaceKind[] = [
-  'tui',
-  'web',
-  'slack',
-  'discord',
-  'ntfy',
-  'webhook',
-  'telegram',
-  'google-chat',
-  'signal',
-  'whatsapp',
-  'imessage',
-  'msteams',
-  'bluebubbles',
-  'mattermost',
-  'matrix',
-  'service',
-];
 
 function isRecord(value: unknown): value is Record<string, unknown> {
   return Boolean(value) && typeof value === 'object' && !Array.isArray(value);
@@ -244,30 +216,6 @@ function readString(record: Record<string, unknown>, key: string): string | null
   return typeof value === 'string' ? value : null;
 }
 
-function readBoolean(record: Record<string, unknown>, key: string): boolean | undefined {
-  const value = record[key];
-  return typeof value === 'boolean' ? value : undefined;
-}
-
-function readNumber(record: Record<string, unknown>, key: string): number | undefined {
-  const value = record[key];
-  return typeof value === 'number' && Number.isFinite(value) ? value : undefined;
-}
-
-function nowIso(): string {
-  return new Date().toISOString();
-}
-
-function optionValue(args: readonly string[], index: number, inlineValue: string | undefined): {
-  readonly value: string | undefined;
-  readonly nextIndex: number;
-} {
-  if (inlineValue !== undefined) return { value: inlineValue, nextIndex: index };
-  const next = args[index + 1];
-  if (next === undefined || next.startsWith('--')) return { value: undefined, nextIndex: index };
-  return { value: next, nextIndex: index + 1 };
-}
-
 function normalizeProviderModel(provider: string | undefined, model: string | undefined): {
   readonly provider?: string;
   readonly model?: string;
@@ -280,63 +228,6 @@ function normalizeProviderModel(provider: string | undefined, model: string | un
   };
 }
 
-function isDeliverySurfaceKind(value: string): value is RoutineScheduleDeliverySurfaceKind {
-  return DELIVERY_SURFACE_KINDS.includes(value as RoutineScheduleDeliverySurfaceKind);
-}
-
-function parseSurfaceDeliveryTarget(raw: string): RoutineScheduleDeliveryTargetSpec | string {
-  const [surfaceKind = '', routeId, label] = raw.split(':');
-  if (!isDeliverySurfaceKind(surfaceKind)) {
-    return `Unsupported delivery surface "${surfaceKind}".`;
-  }
-  return {
-    kind: 'surface',
-    surfaceKind,
-    routeId: routeId?.trim() || undefined,
-    label: label?.trim() || undefined,
-  };
-}
-
-function parseRouteDeliveryTarget(raw: string): RoutineScheduleDeliveryTargetSpec | string {
-  const [routeId = '', label] = raw.split(':');
-  const normalizedRouteId = routeId.trim();
-  if (!normalizedRouteId) return '--delivery-route requires a route id.';
-  return {
-    kind: 'surface',
-    routeId: normalizedRouteId,
-    label: label?.trim() || undefined,
-  };
-}
-
-function parseWebhookDeliveryTarget(raw: string): RoutineScheduleDeliveryTargetSpec | string {
-  const normalized = raw.trim();
-  if (!normalized) return '--delivery-webhook requires a URL.';
-  try {
-    const url = new URL(normalized);
-    if (url.protocol !== 'https:' && url.protocol !== 'http:') return '--delivery-webhook must be an http(s) URL.';
-  } catch {
-    return '--delivery-webhook must be a valid URL.';
-  }
-  return {
-    kind: 'webhook',
-    address: normalized,
-  };
-}
-
-function parseLinkDeliveryTarget(raw: string): RoutineScheduleDeliveryTargetSpec | string {
-  const normalized = raw.trim();
-  if (!normalized) return '--delivery-link requires a URL or label.';
-  return {
-    kind: 'link',
-    address: normalized,
-  };
-}
-
-function validateDeliveryTargets(targets: readonly RoutineScheduleDeliveryTargetSpec[]): string | null {
-  const kinds = new Set(targets.map((target) => target.kind));
-  return kinds.size > 1 ? 'Use one delivery target kind per routine promotion command.' : null;
-}
-
 function deliveryModeFromTargets(targets: readonly RoutineScheduleDeliveryTargetSpec[]): ScheduleDeliveryInput['mode'] {
   const first = targets[0];
   return first ? first.kind : 'none';
@@ -352,488 +243,6 @@ function toDeliveryTargetInput(target: RoutineScheduleDeliveryTargetSpec): Sched
   };
 }
 
-function redactedDeliveryAddress(address: string | undefined): string | undefined {
-  if (!address) return undefined;
-  try {
-    const url = new URL(address);
-    return `${url.protocol}//${url.host}/...`;
-  } catch {
-    return '[redacted]';
-  }
-}
-
-function redactedDeliveryTargets(delivery: ScheduleDeliveryInput | undefined): readonly RoutineScheduleReceiptDeliveryTarget[] | undefined {
-  if (!delivery) return undefined;
-  return delivery.targets.map((target) => ({
-    kind: target.kind as RoutineScheduleDeliveryKind,
-    surfaceKind: typeof target.surfaceKind === 'string' && isDeliverySurfaceKind(target.surfaceKind) ? target.surfaceKind : undefined,
-    address: redactedDeliveryAddress(typeof target.address === 'string' ? target.address : undefined),
-    routeId: typeof target.routeId === 'string' ? target.routeId : undefined,
-    label: typeof target.label === 'string' ? target.label : undefined,
-  }));
-}
-
-function readReceipt(value: unknown): RoutineScheduleReceipt | null {
-  if (!isRecord(value)) return null;
-  const id = readString(value, 'id')?.trim();
-  const createdAt = readString(value, 'createdAt')?.trim();
-  const routineId = readString(value, 'routineId')?.trim();
-  const routineName = readString(value, 'routineName')?.trim();
-  const status = value.status === 'created' || value.status === 'failed' ? value.status : null;
-  const scheduleKind = value.scheduleKind === 'cron' || value.scheduleKind === 'every' || value.scheduleKind === 'at'
-    ? value.scheduleKind
-    : null;
-  const scheduleValue = readString(value, 'scheduleValue')?.trim();
-  const target = isRecord(value.target) ? value.target : {};
-  const deliveryTargets = Array.isArray(value.deliveryTargets)
-    ? value.deliveryTargets.map((target): RoutineScheduleReceiptDeliveryTarget | null => {
-      if (!isRecord(target)) return null;
-      const kind = target.kind === 'webhook' || target.kind === 'surface' || target.kind === 'integration' || target.kind === 'link'
-        ? target.kind
-        : null;
-      if (!kind) return null;
-      const surfaceKind = readString(target, 'surfaceKind') ?? undefined;
-      return {
-        kind,
-        surfaceKind: surfaceKind && isDeliverySurfaceKind(surfaceKind) ? surfaceKind : undefined,
-        address: readString(target, 'address') ?? undefined,
-        routeId: readString(target, 'routeId') ?? undefined,
-        label: readString(target, 'label') ?? undefined,
-      };
-    }).filter((target): target is RoutineScheduleReceiptDeliveryTarget => target !== null)
-    : undefined;
-  if (!id || !createdAt || !routineId || !routineName || !status || !scheduleKind || !scheduleValue) return null;
-  return {
-    id,
-    createdAt,
-    routineId,
-    routineName,
-    route: ROUTINE_SCHEDULE_ROUTE,
-    method: ROUTINE_SCHEDULE_METHOD,
-    status,
-    daemonBaseUrl: readString(value, 'daemonBaseUrl') ?? '',
-    scheduleId: readString(value, 'scheduleId') ?? undefined,
-    scheduleStatus: readString(value, 'scheduleStatus') ?? undefined,
-    scheduleName: readString(value, 'scheduleName') ?? routineName,
-    scheduleKind,
-    scheduleValue,
-    timezone: readString(value, 'timezone') ?? undefined,
-    provider: readString(value, 'provider') ?? undefined,
-    model: readString(value, 'model') ?? undefined,
-    enabled: value.enabled !== false,
-    target: {
-      kind: readString(target, 'kind') ?? undefined,
-      surfaceKind: readString(target, 'surfaceKind') ?? undefined,
-      preserveThread: readBoolean(target, 'preserveThread'),
-      createIfMissing: readBoolean(target, 'createIfMissing'),
-    },
-    deliveryMode: readString(value, 'deliveryMode') ?? undefined,
-    deliveryTargets,
-    failureKind: value.failureKind === 'confirmation_required'
-      || value.failureKind === 'auth_required'
-      || value.failureKind === 'daemon_unavailable'
-      || value.failureKind === 'version_mismatch'
-      || value.failureKind === 'daemon_route_unavailable'
-      || value.failureKind === 'daemon_error'
-      ? value.failureKind
-      : undefined,
-    failureError: readString(value, 'failureError') ?? undefined,
-  };
-}
-
-function parseReceiptStore(raw: string): RoutineScheduleReceiptStoreFile {
-  const parsed: unknown = JSON.parse(raw);
-  if (!isRecord(parsed)) return { version: RECEIPT_STORE_VERSION, receipts: [] };
-  return {
-    version: RECEIPT_STORE_VERSION,
-    receipts: Array.isArray(parsed.receipts)
-      ? parsed.receipts.map(readReceipt).filter((receipt): receipt is RoutineScheduleReceipt => receipt !== null)
-      : [],
-  };
-}
-
-function formatReceiptStore(store: RoutineScheduleReceiptStoreFile): string {
-  return `${JSON.stringify(store, null, 2)}\n`;
-}
-
-function receiptId(createdAt: string, routineId: string, existing: readonly RoutineScheduleReceipt[]): string {
-  const dayStamp = createdAt.slice(0, 10).replace(/-/g, '');
-  const base = `routine-schedule-${routineId}-${dayStamp}`.toLowerCase().replace(/[^a-z0-9]+/g, '-').replace(/^-+|-+$/g, '');
-  const ids = new Set(existing.map((receipt) => receipt.id));
-  if (!ids.has(base)) return base;
-  for (let index = 2; index < 1000; index += 1) {
-    const candidate = `${base}-${index}`;
-    if (!ids.has(candidate)) return candidate;
-  }
-  return `${base}-${existing.length + 1}`;
-}
-
-function scheduleValue(payload: ScheduleCreateInput): string {
-  if (payload.kind === 'cron') return String(payload.cron ?? '');
-  if (payload.kind === 'every') return String(payload.every ?? '');
-  return String(payload.at ?? '');
-}
-
-function scheduleKind(payload: ScheduleCreateInput): RoutineScheduleKind {
-  if (payload.kind === 'cron' || payload.kind === 'every' || payload.kind === 'at') return payload.kind;
-  throw new Error('Routine schedule payload is missing a schedule kind.');
-}
-
-function targetSummary(payload: ScheduleCreateInput): RoutineScheduleReceipt['target'] {
-  return isRecord(payload.target)
-    ? {
-      kind: typeof payload.target.kind === 'string' ? payload.target.kind : undefined,
-      surfaceKind: typeof payload.target.surfaceKind === 'string' ? payload.target.surfaceKind : undefined,
-      preserveThread: typeof payload.target.preserveThread === 'boolean' ? payload.target.preserveThread : undefined,
-      createIfMissing: typeof payload.target.createIfMissing === 'boolean' ? payload.target.createIfMissing : undefined,
-    }
-    : {};
-}
-
-function deliveryMode(payload: ScheduleCreateInput): string | undefined {
-  return isRecord(payload.delivery) && typeof payload.delivery.mode === 'string' ? payload.delivery.mode : undefined;
-}
-
-function resultScheduleRecord(result: RoutineSchedulePromotionResult): Record<string, unknown> {
-  return result.ok && isRecord(result.schedule) ? result.schedule : {};
-}
-
-function normalizeForMatch(value: string | undefined): string {
-  return (value ?? '').trim().toLowerCase();
-}
-
-function isoTime(value: string): string | null {
-  const time = new Date(value).getTime();
-  return Number.isFinite(time) ? new Date(time).toISOString() : null;
-}
-
-function readLiveScheduleDefinition(value: unknown): {
-  readonly kind?: RoutineScheduleKind;
-  readonly value?: string;
-  readonly timezone?: string;
-} {
-  if (!isRecord(value)) return {};
-  if (value.kind === 'cron') {
-    return {
-      kind: 'cron',
-      value: readString(value, 'expression') ?? undefined,
-      timezone: readString(value, 'timezone') ?? undefined,
-    };
-  }
-  if (value.kind === 'every') {
-    const intervalMs = readNumber(value, 'intervalMs');
-    return {
-      kind: 'every',
-      value: intervalMs === undefined ? undefined : formatEveryInterval(intervalMs),
-    };
-  }
-  if (value.kind === 'at') {
-    const at = readNumber(value, 'at');
-    return {
-      kind: 'at',
-      value: at === undefined ? undefined : new Date(at).toISOString(),
-    };
-  }
-  return {};
-}
-
-function readLiveScheduleRecord(value: unknown): RoutineScheduleLiveRecord | null {
-  if (!isRecord(value)) return null;
-  const id = readString(value, 'id')?.trim();
-  const name = readString(value, 'name')?.trim();
-  if (!id || !name) return null;
-  const schedule = readLiveScheduleDefinition(value.schedule);
-  return {
-    id,
-    name,
-    status: readString(value, 'status') ?? undefined,
-    enabled: readBoolean(value, 'enabled'),
-    scheduleKind: schedule.kind,
-    scheduleValue: schedule.value,
-    timezone: schedule.timezone,
-    nextRunAt: readNumber(value, 'nextRunAt'),
-    lastRunAt: readNumber(value, 'lastRunAt'),
-    runCount: readNumber(value, 'runCount'),
-    successCount: readNumber(value, 'successCount'),
-    failureCount: readNumber(value, 'failureCount'),
-  };
-}
-
-function readLiveSchedules(output: ScheduleListOutput): readonly RoutineScheduleLiveRecord[] {
-  const record: Record<string, unknown> = isRecord(output) ? output : {};
-  const jobs: readonly unknown[] = Array.isArray(record.jobs) ? record.jobs : [];
-  return jobs.map(readLiveScheduleRecord).filter((schedule): schedule is RoutineScheduleLiveRecord => schedule !== null);
-}
-
-function cadenceMatches(receipt: RoutineScheduleReceipt, schedule: RoutineScheduleLiveRecord): boolean {
-  if (receipt.scheduleKind !== schedule.scheduleKind) return false;
-  if (receipt.scheduleKind === 'at') {
-    const left = isoTime(receipt.scheduleValue);
-    const right = schedule.scheduleValue ? isoTime(schedule.scheduleValue) : null;
-    return Boolean(left && right && left === right);
-  }
-  return normalizeForMatch(receipt.scheduleValue) === normalizeForMatch(schedule.scheduleValue);
-}
-
-function findScheduleForReceipt(
-  receipt: RoutineScheduleReceipt,
-  schedules: readonly RoutineScheduleLiveRecord[],
-): { readonly reason: RoutineScheduleCorrelation['matchReason']; readonly schedule?: RoutineScheduleLiveRecord } {
-  if (receipt.scheduleId) {
-    const byId = schedules.find((schedule) => schedule.id === receipt.scheduleId);
-    if (byId) return { reason: 'schedule-id', schedule: byId };
-  }
-  const byNameAndCadence = schedules.find((schedule) => (
-    normalizeForMatch(schedule.name) === normalizeForMatch(receipt.scheduleName)
-    && cadenceMatches(receipt, schedule)
-  ));
-  return byNameAndCadence
-    ? { reason: 'name-and-cadence', schedule: byNameAndCadence }
-    : { reason: 'not-found' };
-}
-
-function correlateReceipts(
-  receipts: readonly RoutineScheduleReceipt[],
-  schedules: readonly RoutineScheduleLiveRecord[],
-): readonly RoutineScheduleCorrelation[] {
-  return receipts.map((receipt) => {
-    if (receipt.status === 'failed') {
-      return {
-        receipt,
-        liveStatus: 'failed-receipt',
-        matchReason: 'failed-receipt',
-      };
-    }
-    const match = findScheduleForReceipt(receipt, schedules);
-    return match.schedule
-      ? {
-        receipt,
-        liveStatus: 'matched',
-        matchReason: match.reason,
-        schedule: match.schedule,
-      }
-      : {
-        receipt,
-        liveStatus: 'missing',
-        matchReason: 'not-found',
-      };
-  });
-}
-
-function buildReceipt(
-  existing: readonly RoutineScheduleReceipt[],
-  connection: AgentDaemonConnection,
-  preview: RoutineSchedulePromotionPreview,
-  result: RoutineSchedulePromotionResult,
-): RoutineScheduleReceipt {
-  const createdAt = nowIso();
-  const kind = scheduleKind(preview.payload);
-  const schedule = resultScheduleRecord(result);
-  const scheduleId = readString(schedule, 'id') ?? undefined;
-  const scheduleStatus = readString(schedule, 'status') ?? (schedule.enabled === false ? 'paused' : schedule.enabled === true ? 'enabled' : undefined);
-  return {
-    id: receiptId(createdAt, preview.routineId, existing),
-    createdAt,
-    routineId: preview.routineId,
-    routineName: preview.routineName,
-    route: ROUTINE_SCHEDULE_ROUTE,
-    method: ROUTINE_SCHEDULE_METHOD,
-    status: result.ok ? 'created' : 'failed',
-    daemonBaseUrl: connection.baseUrl,
-    scheduleId,
-    scheduleStatus,
-    scheduleName: String(preview.payload.name ?? `Agent routine: ${preview.routineName}`),
-    scheduleKind: kind,
-    scheduleValue: scheduleValue(preview.payload),
-    timezone: kind === 'cron' ? preview.payload.timezone : undefined,
-    provider: preview.payload.provider,
-    model: preview.payload.model,
-    enabled: preview.payload.enabled !== false,
-    target: targetSummary(preview.payload),
-    deliveryMode: deliveryMode(preview.payload),
-    deliveryTargets: redactedDeliveryTargets(preview.payload.delivery),
-    failureKind: result.ok ? undefined : result.kind,
-    failureError: result.ok ? undefined : result.error,
-  };
-}
-
-export function routineScheduleReceiptStorePath(shellPaths: ShellPathService): string {
-  return shellPaths.resolveUserPath(GOODVIBES_AGENT_SURFACE_ROOT, 'routines', 'schedule-receipts.json');
-}
-
-export class RoutineScheduleReceiptStore {
-  public constructor(private readonly storePath: string) {}
-
-  public static fromShellPaths(shellPaths: ShellPathService): RoutineScheduleReceiptStore {
-    return new RoutineScheduleReceiptStore(routineScheduleReceiptStorePath(shellPaths));
-  }
-
-  public snapshot(): RoutineScheduleReceiptSnapshot {
-    const store = this.readStore();
-    return {
-      path: this.storePath,
-      receipts: [...store.receipts].sort((left, right) => right.createdAt.localeCompare(left.createdAt)),
-    };
-  }
-
-  public get(id: string): RoutineScheduleReceipt | null {
-    const normalized = id.trim().toLowerCase();
-    if (!normalized) return null;
-    return this.snapshot().receipts.find((receipt) => receipt.id.toLowerCase() === normalized) ?? null;
-  }
-
-  public append(connection: AgentDaemonConnection, preview: RoutineSchedulePromotionPreview, result: RoutineSchedulePromotionResult): RoutineScheduleReceipt {
-    const store = this.readStore();
-    const receipt = buildReceipt(store.receipts, connection, preview, result);
-    this.writeStore({ ...store, receipts: [...store.receipts, receipt] });
-    return receipt;
-  }
-
-  private readStore(): RoutineScheduleReceiptStoreFile {
-    if (!existsSync(this.storePath)) return { version: RECEIPT_STORE_VERSION, receipts: [] };
-    try {
-      return parseReceiptStore(readFileSync(this.storePath, 'utf-8'));
-    } catch (error) {
-      throw new Error(`Could not read Agent routine schedule receipt store: ${summarizeError(error)}`);
-    }
-  }
-
-  private writeStore(store: RoutineScheduleReceiptStoreFile): void {
-    mkdirSync(dirname(this.storePath), { recursive: true });
-    const tmpPath = `${this.storePath}.tmp`;
-    writeFileSync(tmpPath, formatReceiptStore(store), 'utf-8');
-    renameSync(tmpPath, this.storePath);
-  }
-}
-
-export function parseRoutineSchedulePromotionArgs(args: readonly string[]): ParsedRoutineSchedulePromotionArgs {
-  let routineId: string | null = null;
-  let schedule: RoutineScheduleSpec | null = null;
-  const deliveryTargets: RoutineScheduleDeliveryTargetSpec[] = [];
-  let name: string | undefined;
-  let timezone: string | undefined;
-  let provider: string | undefined;
-  let model: string | undefined;
-  let enabled = true;
-  let yes = false;
-  const errors: string[] = [];
-
-  for (let index = 0; index < args.length; index += 1) {
-    const raw = args[index] ?? '';
-    const equals = raw.indexOf('=');
-    const optionName = equals >= 0 ? raw.slice(0, equals) : raw;
-    const inlineValue = equals >= 0 ? raw.slice(equals + 1) : undefined;
-
-    if (raw === '--yes') {
-      yes = true;
-      continue;
-    }
-    if (raw === '--disabled') {
-      enabled = false;
-      continue;
-    }
-    if (optionName === '--name' || optionName === '--timezone' || optionName === '--provider' || optionName === '--model') {
-      const consumed = optionValue(args, index, inlineValue);
-      index = consumed.nextIndex;
-      const value = consumed.value?.trim();
-      if (!value) {
-        errors.push(`${optionName} requires a value.`);
-        continue;
-      }
-      if (optionName === '--name') name = value;
-      if (optionName === '--timezone') timezone = value;
-      if (optionName === '--provider') provider = value;
-      if (optionName === '--model') model = value;
-      continue;
-    }
-    if (optionName === '--cron' || optionName === '--every' || optionName === '--at') {
-      const consumed = optionValue(args, index, inlineValue);
-      index = consumed.nextIndex;
-      const value = consumed.value?.trim();
-      if (!value) {
-        errors.push(`${optionName} requires a value.`);
-        continue;
-      }
-      if (schedule) {
-        errors.push('Choose exactly one schedule selector: --cron, --every, or --at.');
-        continue;
-      }
-      schedule = {
-        kind: optionName === '--cron' ? 'cron' : optionName === '--every' ? 'every' : 'at',
-        value,
-      };
-      continue;
-    }
-    if (optionName === '--delivery-surface' || optionName === '--deliver-surface') {
-      const consumed = optionValue(args, index, inlineValue);
-      index = consumed.nextIndex;
-      const value = consumed.value?.trim();
-      if (!value) {
-        errors.push(`${optionName} requires a value.`);
-        continue;
-      }
-      const target = parseSurfaceDeliveryTarget(value);
-      if (typeof target === 'string') errors.push(target);
-      else deliveryTargets.push(target);
-      continue;
-    }
-    if (optionName === '--delivery-route' || optionName === '--deliver-route') {
-      const consumed = optionValue(args, index, inlineValue);
-      index = consumed.nextIndex;
-      const value = consumed.value?.trim();
-      if (!value) {
-        errors.push(`${optionName} requires a value.`);
-        continue;
-      }
-      const target = parseRouteDeliveryTarget(value);
-      if (typeof target === 'string') errors.push(target);
-      else deliveryTargets.push(target);
-      continue;
-    }
-    if (optionName === '--delivery-webhook' || optionName === '--deliver-webhook') {
-      const consumed = optionValue(args, index, inlineValue);
-      index = consumed.nextIndex;
-      const value = consumed.value?.trim();
-      if (!value) {
-        errors.push(`${optionName} requires a value.`);
-        continue;
-      }
-      const target = parseWebhookDeliveryTarget(value);
-      if (typeof target === 'string') errors.push(target);
-      else deliveryTargets.push(target);
-      continue;
-    }
-    if (optionName === '--delivery-link' || optionName === '--deliver-link') {
-      const consumed = optionValue(args, index, inlineValue);
-      index = consumed.nextIndex;
-      const value = consumed.value?.trim();
-      if (!value) {
-        errors.push(`${optionName} requires a value.`);
-        continue;
-      }
-      const target = parseLinkDeliveryTarget(value);
-      if (typeof target === 'string') errors.push(target);
-      else deliveryTargets.push(target);
-      continue;
-    }
-    if (raw.startsWith('--')) {
-      errors.push(`Unknown option: ${raw}`);
-      continue;
-    }
-    if (!routineId) {
-      routineId = raw;
-      continue;
-    }
-    errors.push(`Unexpected argument: ${raw}`);
-  }
-
-  if (!routineId) errors.push('Routine id or name is required.');
-  if (!schedule) errors.push('Schedule is required: use --cron <expr>, --every <interval>, or --at <iso-time>.');
-  const deliveryError = validateDeliveryTargets(deliveryTargets);
-  if (deliveryError) errors.push(deliveryError);
-  return { routineId, schedule, deliveryTargets, name, timezone, provider, model, enabled, yes, errors };
-}
-
 export function resolveAgentDaemonConnection(
   configManager: AgentDaemonConfigReader,
   homeDirectory: string,
@@ -863,7 +272,7 @@ export function buildRoutineSchedulePrompt(routine: AgentRoutineRecord): string
     '',
     'Operator policy:',
     '- Run this as a serial GoodVibes Agent operator routine.',
-    '- Use isolated Agent Knowledge routes only; never use default Knowledge/Wiki or HomeGraph as fallback.',
+    '- Use isolated Agent Knowledge routes only; never use default Knowledge/Wiki or non-Agent knowledge spaces as fallback.',
     '- Do not perform destructive, costly, externally visible, or secret-handling actions without explicit approval.',
     '- Do not request WRFC unless this scheduled routine explicitly delegates build/fix/review work to GoodVibes TUI.',
     '- Summarize what was checked, what changed, and what still needs user review.',
@@ -999,38 +408,6 @@ async function classifyScheduleError(
   return { ok: false, kind: 'daemon_error', error: message, route: ROUTINE_SCHEDULE_ROUTE, baseUrl: connection.baseUrl };
 }
 
-async function classifyScheduleListError(
-  error: unknown,
-  connection: AgentDaemonConnection,
-): Promise<RoutineScheduleCorrelationFailure> {
-  const message = summarizeError(error);
-  const lower = message.toLowerCase();
-  if (lower.includes('401') || lower.includes('unauthorized') || lower.includes('auth')) {
-    return { ok: false, kind: 'auth_required', error: message, route: ROUTINE_SCHEDULE_ROUTE, baseUrl: connection.baseUrl };
-  }
-  if (lower.includes('404') || lower.includes('not found')) {
-    const daemon = await fetchDaemonStatus(connection);
-    const record = isRecord(daemon.body) ? daemon.body : {};
-    const daemonVersion = readString(record, 'version') ?? 'unknown';
-    if (daemon.ok && daemonVersion !== SDK_VERSION) {
-      return {
-        ok: false,
-        kind: 'version_mismatch',
-        error: `External daemon SDK version ${daemonVersion} does not match Agent SDK pin ${SDK_VERSION}; schedules.list is unavailable.`,
-        route: ROUTINE_SCHEDULE_ROUTE,
-        baseUrl: connection.baseUrl,
-        daemonVersion,
-        expectedSdkVersion: SDK_VERSION,
-      };
-    }
-    return { ok: false, kind: 'daemon_route_unavailable', error: message, route: ROUTINE_SCHEDULE_ROUTE, baseUrl: connection.baseUrl };
-  }
-  if (lower.includes('fetch') || lower.includes('connect') || lower.includes('econnrefused')) {
-    return { ok: false, kind: 'daemon_unavailable', error: message, route: ROUTINE_SCHEDULE_ROUTE, baseUrl: connection.baseUrl };
-  }
-  return { ok: false, kind: 'daemon_error', error: message, route: ROUTINE_SCHEDULE_ROUTE, baseUrl: connection.baseUrl };
-}
-
 export async function promoteRoutineToDaemonSchedule(
   connection: AgentDaemonConnection,
   preview: RoutineSchedulePromotionPreview,
@@ -1060,188 +437,3 @@ export async function promoteRoutineToDaemonSchedule(
     return classifyScheduleError(error, connection);
   }
 }
-
-export async function reconcileRoutineScheduleReceipts(
-  connection: AgentDaemonConnection,
-  snapshot: RoutineScheduleReceiptSnapshot,
-): Promise<RoutineScheduleCorrelationResult> {
-  if (!connection.token) {
-    return {
-      ok: false,
-      kind: 'auth_required',
-      error: `No daemon operator token found at ${connection.tokenPath}`,
-      route: ROUTINE_SCHEDULE_ROUTE,
-      baseUrl: connection.baseUrl,
-    };
-  }
-  try {
-    const sdk = createBrowserGoodVibesSdk({ baseUrl: connection.baseUrl, authToken: connection.token });
-    const output = await sdk.operator.invoke(ROUTINE_SCHEDULE_LIST_METHOD, {});
-    const schedules = readLiveSchedules(output);
-    return {
-      ok: true,
-      kind: ROUTINE_SCHEDULE_LIST_METHOD,
-      route: ROUTINE_SCHEDULE_ROUTE,
-      baseUrl: connection.baseUrl,
-      scheduleCount: schedules.length,
-      receiptCount: snapshot.receipts.length,
-      correlations: correlateReceipts(snapshot.receipts, schedules),
-    };
-  } catch (error) {
-    return classifyScheduleListError(error, connection);
-  }
-}
-
-export function formatRoutineSchedulePreview(preview: RoutineSchedulePromotionPreview): string {
-  const schedule = preview.payload.kind === 'cron'
-    ? `${preview.payload.cron}${preview.payload.timezone ? ` [${preview.payload.timezone}]` : ''}`
-    : preview.payload.kind === 'every'
-      ? String(preview.payload.every)
-      : String(preview.payload.at);
-  const delivery = preview.payload.delivery;
-  const deliveryTargetCount = delivery?.targets.length ?? 0;
-  return [
-    'Daemon schedule preview for Agent routine',
-    `  routine: ${preview.routineName} (${preview.routineId})`,
-    `  route: ${preview.method} ${preview.route}`,
-    `  name: ${String(preview.payload.name ?? '(daemon default)')}`,
-    `  schedule: ${preview.payload.kind} ${schedule}`,
-    `  enabled: ${preview.payload.enabled === false ? 'no' : 'yes'}`,
-    `  delivery: ${delivery?.mode ?? 'none'}${deliveryTargetCount > 0 ? ` (${deliveryTargetCount} target${deliveryTargetCount === 1 ? '' : 's'})` : ''}`,
-    '  target: external daemon service/main conversation route',
-    '  policy: isolated Agent Knowledge only; no default wiki/HomeGraph fallback; no WRFC unless explicitly delegated',
-    '  next: rerun with --yes to create this daemon schedule',
-  ].join('\n');
-}
-
-export function formatRoutineScheduleSuccess(result: RoutineSchedulePromotionSuccess): string {
-  const record: Record<string, unknown> = isRecord(result.schedule) ? result.schedule : {};
-  const id = readString(record, 'id') ?? '(unknown)';
-  const status = readString(record, 'status') ?? (record.enabled === false ? 'paused' : 'enabled');
-  return [
-    'Created daemon schedule for Agent routine',
-    `  routine: ${result.routineName} (${result.routineId})`,
-    `  schedule: ${id}`,
-    `  status: ${status}`,
-    `  route: ${result.kind} ${result.route}`,
-    '  next: inspect with /schedule list or daemon schedule observability',
-  ].join('\n');
-}
-
-export function formatRoutineScheduleReceipts(snapshot: RoutineScheduleReceiptSnapshot, limit = 10): string {
-  const receipts = snapshot.receipts.slice(0, Math.max(1, limit));
-  if (snapshot.receipts.length === 0) {
-    return [
-      'Agent routine schedule receipts',
-      `  store: ${snapshot.path}`,
-      '  No routine schedule promotions have been recorded yet.',
-      '  Create one with /schedule promote-routine <routine-id> --cron <expr> --yes.',
-    ].join('\n');
-  }
-  return [
-    `Agent routine schedule receipts (${snapshot.receipts.length})`,
-    `  store: ${snapshot.path}`,
-    ...receipts.map((receipt) => {
-      const schedule = receipt.scheduleId ? ` schedule=${receipt.scheduleId}` : '';
-      const failure = receipt.status === 'failed' && receipt.failureKind ? ` failure=${receipt.failureKind}` : '';
-      return `  ${receipt.id}  ${receipt.status}  ${receipt.scheduleKind} ${receipt.scheduleValue}  routine=${receipt.routineId}${schedule}${failure}`;
-    }),
-    snapshot.receipts.length > receipts.length ? `  ...${snapshot.receipts.length - receipts.length} more` : '',
-  ].filter((line): line is string => Boolean(line)).join('\n');
-}
-
-export function formatRoutineScheduleReceipt(receipt: RoutineScheduleReceipt): string {
-  return [
-    `Agent routine schedule receipt ${receipt.id}`,
-    `  created: ${receipt.createdAt}`,
-    `  status: ${receipt.status}`,
-    `  routine: ${receipt.routineName} (${receipt.routineId})`,
-    `  route: ${receipt.method} ${receipt.route}`,
-    `  daemon: ${receipt.daemonBaseUrl}`,
-    `  schedule: ${receipt.scheduleName}${receipt.scheduleId ? ` (${receipt.scheduleId})` : ''}`,
-    receipt.scheduleStatus ? `  schedule status: ${receipt.scheduleStatus}` : '',
-    `  cadence: ${receipt.scheduleKind} ${receipt.scheduleValue}${receipt.timezone ? ` [${receipt.timezone}]` : ''}`,
-    `  enabled: ${receipt.enabled ? 'yes' : 'no'}`,
-    receipt.provider ? `  provider: ${receipt.provider}` : '',
-    receipt.model ? `  model: ${receipt.model}` : '',
-    `  target: ${receipt.target.kind ?? 'unknown'}${receipt.target.surfaceKind ? `/${receipt.target.surfaceKind}` : ''}`,
-    receipt.deliveryMode ? `  delivery: ${receipt.deliveryMode}` : '',
-    ...(receipt.deliveryTargets ?? []).map((target) => `  delivery target: ${target.kind}${target.surfaceKind ? `/${target.surfaceKind}` : ''}${target.routeId ? ` route=${target.routeId}` : ''}${target.address ? ` address=${target.address}` : ''}${target.label ? ` label=${target.label}` : ''}`),
-    receipt.failureKind ? `  failure: ${receipt.failureKind}` : '',
-    receipt.failureError ? `  error: ${receipt.failureError}` : '',
-  ].filter((line): line is string => Boolean(line)).join('\n');
-}
-
-export function formatRoutineScheduleCorrelation(result: RoutineScheduleCorrelationResult, limit = 10): string {
-  if (!result.ok) {
-    return [
-      `Daemon schedule reconciliation error: ${result.kind}`,
-      `  ${result.error}`,
-      result.baseUrl ? `  daemon: ${result.baseUrl}` : null,
-      `  route: ${ROUTINE_SCHEDULE_LIST_METHOD} ${result.route}`,
-      result.kind === 'auth_required'
-        ? '  next: pair/authenticate with the externally managed GoodVibes daemon, then retry.'
-        : null,
-      result.kind === 'daemon_unavailable'
-        ? '  next: start/restart the external GoodVibes daemon from TUI or daemon host tooling; Agent does not own daemon lifecycle.'
-        : null,
-      result.kind === 'version_mismatch' || result.kind === 'daemon_route_unavailable'
-        ? '  next: update/restart the external GoodVibes daemon so public schedules.list is available.'
-        : null,
-    ].filter((line): line is string => Boolean(line)).join('\n');
-  }
-  const correlations = result.correlations.slice(0, Math.max(1, limit));
-  if (result.receiptCount === 0) {
-    return [
-      'Agent routine schedule reconciliation',
-      `  daemon: ${result.baseUrl}`,
-      `  route: ${result.kind} ${result.route}`,
-      `  live schedules: ${result.scheduleCount}`,
-      '  No local routine promotion receipts exist yet.',
-      '  Create one with /schedule promote-routine <routine-id> --cron <expr> --yes.',
-    ].join('\n');
-  }
-  const matched = result.correlations.filter((entry) => entry.liveStatus === 'matched').length;
-  const missing = result.correlations.filter((entry) => entry.liveStatus === 'missing').length;
-  const failed = result.correlations.filter((entry) => entry.liveStatus === 'failed-receipt').length;
-  return [
-    'Agent routine schedule reconciliation',
-    `  daemon: ${result.baseUrl}`,
-    `  route: ${result.kind} ${result.route}`,
-    `  receipts: ${result.receiptCount}; live schedules: ${result.scheduleCount}; matched: ${matched}; missing: ${missing}; failed receipts: ${failed}`,
-    ...correlations.map((entry) => {
-      const receipt = entry.receipt;
-      const schedule = entry.schedule;
-      const live = schedule
-        ? ` live=${schedule.id} status=${schedule.status ?? (schedule.enabled === false ? 'paused' : 'enabled')}`
-        : '';
-      const runs = schedule && schedule.runCount !== undefined
-        ? ` runs=${schedule.runCount}/${schedule.successCount ?? 0}/${schedule.failureCount ?? 0}`
-        : '';
-      const next = schedule?.nextRunAt ? ` next=${new Date(schedule.nextRunAt).toISOString()}` : '';
-      return `  ${receipt.id}  ${entry.liveStatus}  reason=${entry.matchReason}  routine=${receipt.routineId}  receiptSchedule=${receipt.scheduleId ?? '(none)'}${live}${runs}${next}`;
-    }),
-    result.correlations.length > correlations.length ? `  ...${result.correlations.length - correlations.length} more` : '',
-  ].filter((line): line is string => Boolean(line)).join('\n');
-}
-
-export function formatRoutineScheduleFailure(failure: RoutineSchedulePromotionFailure): string {
-  return [
-    `Daemon schedule error: ${failure.kind}`,
-    `  ${failure.error}`,
-    failure.baseUrl ? `  daemon: ${failure.baseUrl}` : null,
-    `  route: ${ROUTINE_SCHEDULE_METHOD} ${failure.route}`,
-    failure.kind === 'version_mismatch' && failure.daemonVersion && failure.expectedSdkVersion
-      ? `  versions: daemon=${failure.daemonVersion} expected=${failure.expectedSdkVersion}`
-      : null,
-    failure.kind === 'auth_required'
-      ? '  next: pair/authenticate with the externally managed GoodVibes daemon, then retry with --yes.'
-      : null,
-    failure.kind === 'daemon_unavailable'
-      ? '  next: start/restart the external GoodVibes daemon from TUI or daemon host tooling; Agent does not own daemon lifecycle.'
-      : null,
-    failure.kind === 'version_mismatch' || failure.kind === 'daemon_route_unavailable'
-      ? '  next: update/restart the external GoodVibes daemon so public schedules.create is available.'
-      : null,
-  ].filter((line): line is string => Boolean(line)).join('\n');
-}