@pellux/goodvibes-agent 0.1.56 → 0.1.57

package/src/input/handler-onboarding.ts

@@ -4,30 +4,15 @@ import { openExternalUrl } from '@pellux/goodvibes-sdk/platform/utils';
 import { getProviderIdFromModel } from '../config/provider-model.ts';
 import { buildProviderAccountSnapshot } from '@/runtime/index.ts';
 import { OnboardingWizardController, type OnboardingWizardAction, type OnboardingWizardApplyFeedback } from './onboarding/onboarding-wizard.ts';
-import { handleCloudflareOnboardingActionForHandler, maybeProvisionCloudflareOnFinalApplyForHandler } from './handler-onboarding-cloudflare.ts';
 import { applyOnboardingRequest, collectOnboardingSnapshot, verifyOnboardingRequest } from '../runtime/onboarding/index.ts';
 import type { OnboardingApplyRequest, OnboardingVerificationItem } from '../runtime/onboarding/index.ts';
 import type { ModelPickerTarget } from './model-picker.ts';
 import { captureOnboardingWizardSnapshot, restoreOnboardingWizardSnapshot } from './handler-ui-state.ts';
 import type { InputHandler } from './handler.ts';
-import {
-  formatRuntimeActiveSuccessMessage,
-  getRuntimeEndpointStatus,
-  isRuntimeEndpointActive,
-  isRuntimeEndpointOccupyingConfiguredPort,
-  runtimePortDiagnostic,
-  type OnboardingExternalServiceState,
-  type OnboardingRuntimeEndpoint,
-} from './onboarding/onboarding-runtime-status.ts';
 
 export interface OnboardingRuntimePosture {
-  readonly serviceEnabled: boolean;
-  readonly serviceAutostart: boolean;
-  readonly restartOnFailure: boolean;
-  readonly expectedDaemon: boolean;
-  readonly expectedHttpListener: boolean;
-  readonly serverBacked: boolean;
-  readonly remoteExposure: boolean;
+  readonly externalServiceManaged: true;
+  readonly mutationAllowed: false;
 }
 
 function extractAuthorizationCode(input: string): string | null {
@@ -42,16 +27,6 @@ function extractAuthorizationCode(input: string): string | null {
   }
 }
 
-function isLoopbackHostValue(value: string | null | undefined): boolean {
-  const normalized = (value ?? '').trim().toLowerCase();
-  if (normalized.length === 0) return false;
-  return normalized === 'localhost'
-    || normalized === '::1'
-    || normalized === '[::1]'
-    || normalized === '0:0:0:0:0:0:0:1'
-    || /^127(?:\.\d{1,3}){3}$/.test(normalized);
-}
-
 function onboardingVerificationStatusRank(item: OnboardingVerificationItem): number {
   if (item.status === 'fail') return 3;
   if (item.status === 'warn') return 2;
@@ -87,53 +62,6 @@ function formatOnboardingApplyCompletionMessage(items: readonly OnboardingVerifi
   ].join('\n');
 }
 
-function getRuntimeEndpointBinding(
-  handler: InputHandler,
-  request: OnboardingApplyRequest,
-  endpoint: OnboardingRuntimeEndpoint,
-): { readonly label: string; readonly host: string; readonly port: number } {
-  const hostKey = endpoint === 'daemon' ? 'controlPlane.host' : 'httpListener.host';
-  const portKey = endpoint === 'daemon' ? 'controlPlane.port' : 'httpListener.port';
-  const fallbackHost = '127.0.0.1';
-  const fallbackPort = endpoint === 'daemon' ? 3421 : 3422;
-  const rawHost = handler.getOnboardingConfigValue(request, hostKey);
-  const rawPort = handler.getOnboardingConfigValue(request, portKey);
-  const parsedPort = typeof rawPort === 'number' ? rawPort : Number(rawPort);
-  return {
-    label: endpoint === 'daemon' ? 'GoodVibes daemon' : 'HTTP listener',
-    host: String(rawHost ?? fallbackHost),
-    port: Number.isFinite(parsedPort) ? parsedPort : fallbackPort,
-  };
-}
-
-function formatRuntimeActiveFailureMessage(
-  handler: InputHandler,
-  request: OnboardingApplyRequest,
-  endpoint: OnboardingRuntimeEndpoint,
-  state: OnboardingExternalServiceState | undefined,
-): string {
-  const binding = getRuntimeEndpointBinding(handler, request, endpoint);
-  const portInUse = endpoint === 'daemon' ? state?.daemonPortInUse : state?.httpListenerPortInUse;
-  const status = getRuntimeEndpointStatus(state, endpoint);
-  const impact = endpoint === 'daemon'
-    ? 'browser, LAN, and service-backed GoodVibes surfaces may be unavailable until the daemon is running there.'
-    : 'incoming webhooks and event surfaces will not receive traffic until the listener is running there.';
-  return `${binding.label} is enabled for ${binding.host}:${binding.port}, but onboarding could not confirm an embedded or verified external service after restart. ${runtimePortDiagnostic(binding, portInUse, status)} Settings were saved; ${impact}`;
-}
-
-function formatRuntimeStoppedFailureMessage(
-  handler: InputHandler,
-  request: OnboardingApplyRequest,
-  endpoint: OnboardingRuntimeEndpoint,
-  state?: OnboardingExternalServiceState,
-): string {
-  const binding = getRuntimeEndpointBinding(handler, request, endpoint);
-  const status = getRuntimeEndpointStatus(state, endpoint);
-  const disabledSurface = endpoint === 'daemon' ? 'server-backed surfaces' : 'incoming event surfaces';
-  const statusDetail = status ? ` ${runtimePortDiagnostic(binding, undefined, status)}` : '';
-  return `${binding.label} was disabled for ${disabledSurface}, but ${binding.host}:${binding.port} is still occupied. Settings were saved; another GoodVibes process or external service may still be running on that port.${statusDetail}`;
-}
-
 function showOnboardingApplyFeedbackForHandler(handler: InputHandler, feedback: OnboardingWizardApplyFeedback): void {
     handler.onboardingWizard.setApplyFeedback(feedback);
     const reviewIndex = handler.onboardingWizard.steps.findIndex((step) => step.id === 'review');
@@ -241,18 +169,6 @@ export async function handleOnboardingActionForHandler(handler: InputHandler, ac
       continueOnboardingSection(handler);
       return;
     }
-    if (action.startsWith('cloudflare-')) {
-      await handleCloudflareOnboardingActionForHandler(handler, action as Extract<OnboardingWizardAction,
-        | 'cloudflare-token-requirements'
-        | 'cloudflare-create-operational-token'
-        | 'cloudflare-discover'
-        | 'cloudflare-validate'
-        | 'cloudflare-provision'
-        | 'cloudflare-verify'
-        | 'cloudflare-disable'
-      >);
-      return;
-    }
     if (action !== 'apply') return;
     if (handler.onboardingApplyPending) return;
     const blockers = handler.onboardingWizard.getBlockingFieldLabels();
@@ -298,8 +214,6 @@ export async function handleOnboardingActionForHandler(handler: InputHandler, ac
             ? { ...item, status: 'warn' }
             : item));
         verificationItems = dedupeOnboardingVerificationItems([...verificationItems, ...runtimeWarnings]);
-        const cloudflareItems = await maybeProvisionCloudflareOnFinalApplyForHandler(handler);
-        verificationItems = dedupeOnboardingVerificationItems([...verificationItems, ...cloudflareItems]);
       }
     } catch (error) {
       showOnboardingApplyFeedbackForHandler(handler, {
@@ -564,44 +478,20 @@ export function getOnboardingConfigValueForHandler(handler: InputHandler, reques
   }
 
 export function getOnboardingRuntimePostureForHandler(handler: InputHandler, request: OnboardingApplyRequest): OnboardingRuntimePosture {
-    const getConfigValue = (key: string): unknown => handler.getOnboardingConfigValue(request, key);
-    const serviceEnabled = getConfigValue('service.enabled') === true;
-    const serviceAutostart = getConfigValue('service.autostart') === true;
-    const restartOnFailure = getConfigValue('service.restartOnFailure') === true;
-    const daemonEnabled = getConfigValue('danger.daemon') === true || getConfigValue('controlPlane.enabled') === true;
-    const listenerEnabled = getConfigValue('danger.httpListener') === true;
-    const webEnabled = getConfigValue('web.enabled') === true;
-    const controlPlaneRemote = getConfigValue('controlPlane.hostMode') === 'network'
-      || (getConfigValue('controlPlane.hostMode') === 'custom'
-        && !isLoopbackHostValue(String(getConfigValue('controlPlane.host') ?? '')))
-      || getConfigValue('controlPlane.allowRemote') === true;
-    const listenerRemote = getConfigValue('httpListener.hostMode') === 'network'
-      || (getConfigValue('httpListener.hostMode') === 'custom'
-        && !isLoopbackHostValue(String(getConfigValue('httpListener.host') ?? '')));
-    const webRemote = getConfigValue('web.hostMode') === 'network'
-      || (getConfigValue('web.hostMode') === 'custom'
-        && !isLoopbackHostValue(String(getConfigValue('web.host') ?? '')));
-    const remoteExposure = controlPlaneRemote || listenerRemote || webRemote;
-
     return {
-      serviceEnabled,
-      serviceAutostart,
-      restartOnFailure,
-      expectedDaemon: daemonEnabled || webEnabled,
-      expectedHttpListener: listenerEnabled,
-      serverBacked: serviceEnabled || daemonEnabled || listenerEnabled || webEnabled,
-      remoteExposure,
+      externalServiceManaged: true,
+      mutationAllowed: false,
     };
   }
 
 export async function restartOnboardingExternalServicesIfNeededForHandler(handler: InputHandler, request: OnboardingApplyRequest): Promise<OnboardingVerificationItem[]> {
     const externalServices = handler.uiServices.platform.externalServices;
     const state = externalServices?.inspect();
-    const daemonStatus = state?.daemonStatus?.reason ?? (state?.daemonRunning ? 'external daemon appears active' : 'external daemon is not verified from this shell');
+    const serviceStatus = state?.daemonStatus?.reason ?? (state?.daemonRunning ? 'external GoodVibes service appears active' : 'external GoodVibes service is not verified from this shell');
     return [{
-      id: 'runtime:external-daemon-owned',
+      id: 'runtime:external-service-owned',
       status: 'pass',
-      message: `GoodVibes Agent did not start, stop, or restart daemon/listener services; daemon lifecycle is external. ${daemonStatus}`,
+      message: `GoodVibes Agent did not start, stop, restart, or reconfigure service lifecycle. ${serviceStatus}`,
       target: 'service',
     }];
   }
@@ -610,11 +500,11 @@ export function verifyOnboardingRuntimePostureForHandler(handler: InputHandler,
     const externalServices = handler.uiServices.platform.externalServices;
     const externalState = externalServices?.inspect();
     return [{
-      id: 'runtime:external-daemon-owned',
+      id: 'runtime:external-service-owned',
       status: 'pass',
       message: externalState
-        ? 'Daemon/listener lifecycle is externally managed; Agent onboarding did not request service shutdown, startup, restart, or bind changes.'
-        : 'Daemon/listener lifecycle is externally managed; no local service controller is required for Agent onboarding.',
+        ? 'GoodVibes service lifecycle is externally managed; Agent onboarding did not request shutdown, startup, restart, bind, or surface changes.'
+        : 'GoodVibes service lifecycle is externally managed; no local service controller is required for Agent onboarding.',
       target: 'service',
     }];
   }

package/src/input/onboarding/onboarding-wizard-apply.ts

@@ -1,21 +1,5 @@
-import type { OnboardingAcknowledgementTarget, OnboardingApplyOperation, OnboardingApplyRequest } from '../../runtime/onboarding/index.ts';
+import type { OnboardingApplyOperation, OnboardingApplyRequest } from '../../runtime/onboarding/index.ts';
 import { formatProviderModel } from '../../config/provider-model.ts';
-import { getServerSurfaceFeatureFlags } from '../../runtime/surface-feature-flags.ts';
-import {
-  buildCloudflareApiTokenRef,
-  buildCloudflareOperationalTokenRef,
-  getCloudflareBatchMode,
-  getCloudflareComponentSelection,
-  getCloudflareSetupSource,
-  shouldShowCloudflareStep,
-} from './onboarding-wizard-cloudflare.ts';
-import {
-  EXTERNAL_SURFACE_SPECS,
-  getExternalSurfaceAutoStartDefaultValue,
-  getExternalSurfaceAutoStartFieldId,
-  isExternalSurfaceSelectedByDefault,
-} from './onboarding-wizard-external-surfaces.ts';
-import { buildGoodVibesSecretKey, buildGoodVibesSecretRef, isSecretReferenceValue } from './onboarding-wizard-helpers.ts';
 import type { OnboardingWizardController } from './onboarding-wizard.ts';
 
 export function buildOnboardingApplyRequest(controller: OnboardingWizardController): OnboardingApplyRequest {
@@ -26,16 +10,6 @@ export function buildOnboardingApplyRequest(controller: OnboardingWizardControll
     ): void => {
       operations.push({ kind: 'set-config', key, value });
     };
-    const enableFeatureFlags = (flagIds: readonly string[]): void => {
-      for (const flagId of flagIds) setConfig(`featureFlags.${flagId}`, 'enabled');
-    };
-    const acknowledge = (target: OnboardingAcknowledgementTarget, fieldId: string): void => {
-      operations.push({
-        kind: 'acknowledge',
-        target,
-        acknowledged: controller.getBooleanFieldValue(fieldId, false),
-      });
-    };
     const setSecret = (key: string, value: string): void => {
       if (value.length === 0) return;
       const medium = controller.getSelectedSecretMedium();
@@ -47,36 +21,10 @@ export function buildOnboardingApplyRequest(controller: OnboardingWizardControll
         medium,
       });
     };
-    const setMaskedConfig = (
-      key: Extract<OnboardingApplyOperation, { kind: 'set-config' }>['key'],
-      value: string,
-    ): void => {
-      if (value.length === 0 || isSecretReferenceValue(value)) {
-        setConfig(key, value);
-        return;
-      }
-
-      const secretKey = buildGoodVibesSecretKey(key);
-      setSecret(secretKey, value);
-      setConfig(key, buildGoodVibesSecretRef(secretKey));
-    };
-
-    const requestedAdminPassword = controller.getStringFieldValue('accounts.admin-password', '');
-    const shouldEnsureAuthUser = controller.requiresAuthBootstrap() || requestedAdminPassword.length > 0;
-    if (shouldEnsureAuthUser) {
-      operations.push({
-        kind: 'ensure-auth-user',
-        username: controller.getStringFieldValue('accounts.admin-username', controller.getDefaultAdminUsername()),
-        password: requestedAdminPassword,
-        roles: ['admin'],
-        createSession: true,
-        retireBootstrapCredential: controller.hasBootstrapCredentialPresent(),
-      });
-    }
 
-    // GoodVibes Agent consumes an externally managed daemon. Onboarding must not
-    // enable, disable, bind, expose, start, stop, or restart daemon/listener/web
-    // lifecycle settings; provider/auth/local Agent state is the owned surface.
+    // GoodVibes Agent onboarding owns only Agent-local setup and provider
+    // routing. Server lifecycle, non-Agent entrypoints, and non-Agent knowledge
+    // segments are managed elsewhere.
 
     const defaultModel = controller.modelSelectionState.get('main');
     if (defaultModel && defaultModel.enabled !== false && defaultModel.providerId.length > 0 && defaultModel.modelId.length > 0) {
@@ -86,152 +34,13 @@ export function buildOnboardingApplyRequest(controller: OnboardingWizardControll
     setConfig('behavior.hitlMode', controller.getStringFieldValue('experience.hitl', controller.runtimeSnapshot?.runtimeDefaults.behavior.hitlMode ?? 'balanced'));
     setConfig('behavior.guidanceMode', controller.getStringFieldValue('experience.guidance', controller.runtimeSnapshot?.runtimeDefaults.behavior.guidanceMode ?? 'minimal'));
     setConfig('permissions.mode', controller.getStringFieldValue('experience.permissions', controller.runtimeSnapshot?.runtimeDefaults.permissionsMode ?? 'prompt'));
-    setConfig('storage.secretPolicy', controller.getStringFieldValue('external-services.secret-policy', controller.runtimeSnapshot?.runtimeDefaults.secretStoragePolicy ?? 'preferred_secure'));
+    setConfig('storage.secretPolicy', controller.getStringFieldValue('agent-setup.secret-policy', controller.runtimeSnapshot?.runtimeDefaults.secretStoragePolicy ?? 'preferred_secure'));
 
     setSecret('OPENAI_API_KEY', controller.getStringFieldValue('providers.openai-api-key', ''));
 
-    if (shouldShowCloudflareStep(controller)) {
-      addCloudflareOperations(controller, operations, setSecret);
-    }
-
-    const externalIntegrations = controller.isCapabilitySelected('external-integrations');
-    const enabledExternalSurfaceIds: string[] = [];
-    for (const surface of EXTERNAL_SURFACE_SPECS) {
-      const selected = externalIntegrations
-        && controller.getBooleanFieldValue(
-          surface.enabledFieldId,
-          isExternalSurfaceSelectedByDefault(surface, controller.runtimeSnapshot),
-        );
-      const autoStart = selected
-        && controller.getStringFieldValue(
-          getExternalSurfaceAutoStartFieldId(surface),
-          getExternalSurfaceAutoStartDefaultValue(surface, controller.runtimeSnapshot),
-        ) === 'yes';
-      setConfig(surface.enabledConfigKey, autoStart);
-      if (!selected) continue;
-      enabledExternalSurfaceIds.push(surface.id);
-
-      for (const setupField of surface.fields) {
-        const fallback = setupField.defaultValue(controller.runtimeSnapshot);
-        if (setupField.valueType === 'number') {
-          setConfig(
-            setupField.configKey,
-            controller.getNumberFieldValue(
-              setupField.id,
-              setupField.defaultNumber ?? (Number.parseInt(fallback, 10) || 0),
-              setupField.min,
-              setupField.max,
-            ),
-          );
-          continue;
-        }
-
-        const value = controller.getStringFieldValue(setupField.id, fallback);
-        if (setupField.kind === 'masked') setMaskedConfig(setupField.configKey, value);
-        else setConfig(setupField.configKey, value);
-      }
-    }
-    enableFeatureFlags(getServerSurfaceFeatureFlags({
-      serverBacked: false,
-      web: false,
-      externalSurfaces: enabledExternalSurfaceIds,
-    }));
-
-    acknowledge('providers', 'providers.reviewed');
-    acknowledge('subscriptions', 'accounts.subscriptions');
-    acknowledge('auth', 'accounts.auth');
-
     return {
       mode: controller.mode,
       source: 'wizard',
       operations,
     };
   }
-
-function addCloudflareOperations(
-  controller: OnboardingWizardController,
-  operations: OnboardingApplyOperation[],
-  setSecret: (key: string, value: string) => void,
-): void {
-    const setConfig = (
-      key: Extract<OnboardingApplyOperation, { kind: 'set-config' }>['key'],
-      value: unknown,
-    ): void => {
-      operations.push({ kind: 'set-config', key, value });
-    };
-
-    const config = controller.runtimeSnapshot?.config.cloudflare;
-    const enabledDefault = controller.isCapabilitySelected('cloudflare-batch') || config?.enabled === true;
-    const enabled = controller.getBooleanFieldValue('cloudflare.enabled', enabledDefault);
-    const components = getCloudflareComponentSelection(controller);
-    const batchMode = enabled ? getCloudflareBatchMode(controller) : 'off';
-    const setupSource = getCloudflareSetupSource(controller);
-    const existingApiTokenRef = config?.apiTokenRef ?? '';
-    let apiTokenRef = existingApiTokenRef;
-
-    if (!enabled) {
-      setConfig('cloudflare.enabled', false);
-      setConfig('batch.mode', 'off');
-      setConfig('batch.queueBackend', 'local');
-      return;
-    }
-
-    if (setupSource === 'operational-env') {
-      apiTokenRef = buildCloudflareApiTokenRef(
-        controller.getStringFieldValue('cloudflare.operational-env-name', 'CLOUDFLARE_API_TOKEN'),
-      );
-    } else if (setupSource === 'operational-token') {
-      const token = controller.getStringFieldValue('cloudflare.operational-token', '');
-      if (token.length > 0) {
-        setSecret('CLOUDFLARE_API_TOKEN', token);
-        apiTokenRef = buildCloudflareOperationalTokenRef();
-      }
-    }
-
-    setConfig('cloudflare.enabled', true);
-    setConfig('cloudflare.freeTierMode', controller.getStringFieldValue('cloudflare.free-tier-mode', config?.freeTierMode === false ? 'no' : 'yes') === 'yes');
-    setConfig('cloudflare.accountId', controller.getStringFieldValue('cloudflare.account-id', config?.accountId ?? ''));
-    setConfig('cloudflare.apiTokenRef', apiTokenRef);
-    setConfig('cloudflare.zoneId', controller.getStringFieldValue('cloudflare.zone-id', config?.zoneId ?? ''));
-    setConfig('cloudflare.zoneName', controller.getStringFieldValue('cloudflare.zone-name', config?.zoneName ?? ''));
-    setConfig('cloudflare.workerName', controller.getStringFieldValue('cloudflare.worker-name', config?.workerName ?? 'goodvibes-batch-worker'));
-    setConfig('cloudflare.workerSubdomain', controller.getStringFieldValue('cloudflare.worker-subdomain', config?.workerSubdomain ?? ''));
-    setConfig('cloudflare.workerHostname', controller.getStringFieldValue('cloudflare.worker-hostname', config?.workerHostname ?? ''));
-    setConfig('cloudflare.workerBaseUrl', controller.getStringFieldValue('cloudflare.worker-base-url', config?.workerBaseUrl ?? ''));
-    setConfig('cloudflare.daemonBaseUrl', controller.getStringFieldValue('cloudflare.daemon-base-url', config?.daemonBaseUrl ?? ''));
-    setConfig('cloudflare.daemonHostname', controller.getStringFieldValue('cloudflare.daemon-hostname', config?.daemonHostname ?? ''));
-    setConfig('cloudflare.workerCron', controller.getStringFieldValue('cloudflare.worker-cron', config?.workerCron ?? '*/5 * * * *'));
-    setConfig('cloudflare.queueName', controller.getStringFieldValue('cloudflare.queue-name', config?.queueName ?? 'goodvibes-batch'));
-    setConfig('cloudflare.deadLetterQueueName', controller.getStringFieldValue('cloudflare.dead-letter-queue-name', config?.deadLetterQueueName ?? 'goodvibes-batch-dlq'));
-    setConfig('cloudflare.tunnelName', controller.getStringFieldValue('cloudflare.tunnel-name', config?.tunnelName ?? 'goodvibes-agent-daemon'));
-    setConfig('cloudflare.tunnelId', controller.getStringFieldValue('cloudflare.tunnel-id', config?.tunnelId ?? ''));
-    setConfig('cloudflare.tunnelTokenRef', controller.getStringFieldValue('cloudflare.tunnel-token-ref', config?.tunnelTokenRef ?? ''));
-    setConfig('cloudflare.accessAppId', controller.getStringFieldValue('cloudflare.access-app-id', config?.accessAppId ?? ''));
-    setConfig('cloudflare.accessServiceTokenId', controller.getStringFieldValue('cloudflare.access-service-token-id', config?.accessServiceTokenId ?? ''));
-    setConfig('cloudflare.accessServiceTokenRef', controller.getStringFieldValue('cloudflare.access-service-token-ref', config?.accessServiceTokenRef ?? ''));
-    setConfig('cloudflare.kvNamespaceName', controller.getStringFieldValue('cloudflare.kv-namespace-name', config?.kvNamespaceName ?? 'goodvibes-runtime'));
-    setConfig('cloudflare.kvNamespaceId', controller.getStringFieldValue('cloudflare.kv-namespace-id', config?.kvNamespaceId ?? ''));
-    setConfig('cloudflare.durableObjectNamespaceName', controller.getStringFieldValue('cloudflare.do-namespace-name', config?.durableObjectNamespaceName ?? 'GoodVibesCoordinator'));
-    setConfig('cloudflare.durableObjectNamespaceId', controller.getStringFieldValue('cloudflare.do-namespace-id', config?.durableObjectNamespaceId ?? ''));
-    setConfig('cloudflare.r2BucketName', controller.getStringFieldValue('cloudflare.r2-bucket-name', config?.r2BucketName ?? 'goodvibes-artifacts'));
-    setConfig('cloudflare.secretsStoreName', controller.getStringFieldValue('cloudflare.secrets-store-name', config?.secretsStoreName ?? 'goodvibes'));
-    setConfig('cloudflare.secretsStoreId', controller.getStringFieldValue('cloudflare.secrets-store-id', config?.secretsStoreId ?? ''));
-    setConfig('cloudflare.maxQueueOpsPerDay', controller.getNumberFieldValue('cloudflare.max-queue-ops-per-day', config?.maxQueueOpsPerDay ?? 10000, 1));
-    setConfig('batch.mode', batchMode);
-    setConfig('batch.queueBackend', batchMode !== 'off' && components.queues ? 'cloudflare' : 'local');
-  }
-
-export function addNetworkOperations(
-  _controller: OnboardingWizardController,
-  _operations: OnboardingApplyOperation[],
-  _customNetwork: boolean,
-  _enabled: {
-    readonly controlPlane: boolean;
-    readonly controlPlaneRemote: boolean;
-    readonly httpListener: boolean;
-    readonly web: boolean;
-  },
-  ): void {
-    // Agent onboarding intentionally never mutates daemon/listener/web bind posture.
-    // Network fields are advisory for the external daemon owner.
-  }

package/src/input/onboarding/onboarding-wizard-constants.ts

@@ -1,57 +1,20 @@
-import type { OnboardingStep1CapabilityItem } from '../../runtime/onboarding/index.ts';
 import type { OnboardingWizardRadioOption, OnboardingWizardStepId } from './onboarding-wizard-types.ts';
 
 export const STEP_ORDER: readonly OnboardingWizardStepId[] = [
-  'capabilities',
-  'network',
-  'access',
-  'external-services',
-  'cloudflare',
+  'agent-setup',
   'provider-access',
   'default-model',
+  'agent-communication',
+  'agent-tools',
+  'agent-knowledge',
+  'agent-local-state',
+  'agent-automation',
+  'agent-voice-media',
+  'agent-delegation',
   'experience',
   'review',
 ];
 
-export const DEFAULT_CAPABILITIES: readonly OnboardingStep1CapabilityItem[] = [
-  {
-    id: 'local-tui-only',
-    label: 'Agent Local Only (External Daemon)',
-    selected: true,
-    detail: 'Use GoodVibes Agent in this terminal and connect only to an externally managed daemon. Agent does not enable service mode, HTTP listeners, external app surfaces, or network setup.',
-  },
-  {
-    id: 'browser-access',
-    label: 'Open GoodVibes in a Browser',
-    selected: false,
-    detail: 'Review browser access requirements for the externally managed daemon. Agent records intent but does not start web services.',
-  },
-  {
-    id: 'network-access',
-    label: 'Let other devices use GoodVibes',
-    selected: false,
-    detail: 'Review external daemon surfaces that are reachable from other devices on your LAN. Local authentication is required.',
-  },
-  {
-    id: 'webhook-events',
-    label: 'Receive webhooks or events from other tools',
-    selected: false,
-    detail: 'Review the external HTTP listener required for incoming webhooks, callbacks, and automation events.',
-  },
-  {
-    id: 'external-integrations',
-    label: 'Connect GoodVibes to external apps and services',
-    selected: false,
-    detail: 'Enable setup screens for Slack, Discord, Telegram, Home Assistant, Teams, Matrix, and other app surfaces you choose.',
-  },
-  {
-    id: 'cloudflare-batch',
-    label: 'Use Cloudflare for batch or remote daemon work',
-    selected: false,
-    detail: 'Optionally configure Cloudflare Workers and Queues for explicit or eligible background batch jobs. The external daemon still owns execution.',
-  },
-];
-
 export const REASONING_OPTIONS: readonly OnboardingWizardRadioOption[] = [
   { id: 'instant', label: 'Instant', hint: 'Lowest-latency routing.' },
   { id: 'low', label: 'Low', hint: 'Compact reasoning for quick work.' },
@@ -59,11 +22,6 @@ export const REASONING_OPTIONS: readonly OnboardingWizardRadioOption[] = [
   { id: 'high', label: 'High', hint: 'Deeper reasoning for complex tasks.' },
 ];
 
-export const NETWORK_MODE_OPTIONS: readonly OnboardingWizardRadioOption[] = [
-  { id: 'local-network-default', label: 'Local Network (Default)', hint: 'Review the default LAN-facing external daemon setup for browser, control-plane, and event features.' },
-  { id: 'custom', label: 'Custom', hint: 'Review IP addresses and ports for each external daemon surface.' },
-];
-
 export const HITL_MODE_OPTIONS: readonly OnboardingWizardRadioOption[] = [
   { id: 'quiet', label: 'Quiet', hint: 'Only interrupt for important attention requests.' },
   { id: 'balanced', label: 'Balanced', hint: 'Show important activity without turning Agent into a log stream.' },
@@ -87,72 +45,3 @@ export const SECRET_POLICY_OPTIONS: readonly OnboardingWizardRadioOption[] = [
   { id: 'require_secure', label: 'Require secure storage', hint: 'Refuse plaintext secret persistence.' },
   { id: 'plaintext_allowed', label: 'Allow plaintext storage', hint: 'Permit local plaintext secret storage.' },
 ];
-
-export const TELEGRAM_MODE_OPTIONS: readonly OnboardingWizardRadioOption[] = [
-  { id: 'webhook', label: 'Webhook', hint: 'Receive Telegram updates through a webhook.' },
-  { id: 'polling', label: 'Polling', hint: 'The external daemon polls Telegram for updates.' },
-];
-
-export const WHATSAPP_PROVIDER_OPTIONS: readonly OnboardingWizardRadioOption[] = [
-  { id: 'meta-cloud', label: 'Meta Cloud', hint: 'Use the Meta Cloud API.' },
-  { id: 'bridge', label: 'Bridge', hint: 'Use a configured bridge service.' },
-];
-
-export const INBOUND_EXTERNAL_SURFACE_IDS = new Set<string>([
-  'bluebubbles',
-  'discord',
-  'googleChat',
-  'homeassistant',
-  'imessage',
-  'mattermost',
-  'matrix',
-  'msteams',
-  'ntfy',
-  'signal',
-  'slack',
-  'telegram',
-  'webhook',
-  'whatsapp',
-]);
-
-export const REQUIRED_EXTERNAL_SETUP_FIELD_IDS = new Set<string>([
-  'external-services.slack.bot-token',
-  'external-services.slack.signing-secret',
-  'external-services.discord.bot-token',
-  'external-services.discord.application-id',
-  'external-services.discord.public-key',
-  'external-services.telegram.bot-token',
-  'external-services.telegram.webhook-secret',
-  'external-services.webhook.default-target',
-  'external-services.homeassistant.instance-url',
-  'external-services.homeassistant.access-token',
-  'external-services.homeassistant.webhook-secret',
-  'external-services.google-chat.webhook-url',
-  'external-services.google-chat.verification-token',
-  'external-services.signal.bridge-url',
-  'external-services.signal.account',
-  'external-services.signal.token',
-  'external-services.whatsapp.access-token',
-  'external-services.whatsapp.verify-token',
-  'external-services.whatsapp.phone-number-id',
-  'external-services.imessage.bridge-url',
-  'external-services.imessage.account',
-  'external-services.imessage.token',
-  'external-services.msteams.app-id',
-  'external-services.msteams.app-password',
-  'external-services.msteams.tenant-id',
-  'external-services.bluebubbles.server-url',
-  'external-services.bluebubbles.password',
-  'external-services.mattermost.base-url',
-  'external-services.mattermost.bot-token',
-  'external-services.matrix.homeserver-url',
-  'external-services.matrix.access-token',
-  'external-services.matrix.user-id',
-]);
-
-export const NETWORK_HOST_FIELD_IDS = new Set<string>([
-  'network.shared-ip-address',
-  'network.service-ip',
-  'network.browser-ip',
-  'network.webhook-ip',
-]);

package/src/input/onboarding/onboarding-wizard-helpers.ts

@@ -1,7 +1,4 @@
-import { isIP } from 'node:net';
-import { deriveOnboardingStepState, type OnboardingStep1CapabilityItem, type OnboardingStepDerivationState } from '../../runtime/onboarding/index.ts';
-import { DEFAULT_CAPABILITIES } from './onboarding-wizard-constants.ts';
-import { EXTERNAL_SURFACE_SPECS, type ExternalSurfaceSetupFieldSpec, type ExternalSurfaceSpec } from './onboarding-wizard-external-surfaces.ts';
+import type { OnboardingStepDerivationState } from '../../runtime/onboarding/index.ts';
 import type { OnboardingWizardAcknowledgementFieldDefinition, OnboardingWizardModelSelection, OnboardingWizardRuntimeHydration } from './onboarding-wizard-types.ts';
 export {
   buildGoodVibesSecretKey,
@@ -15,42 +12,10 @@ export function clamp(value: number, min: number, max: number): number {
   return Math.max(min, Math.min(max, value));
 }
 
-export function countSelected(items: readonly OnboardingStep1CapabilityItem[]): number {
-  return items.filter((item) => item.selected).length;
-}
-
 export function normalizeText(value: string | null | undefined): string {
   return (value ?? '').trim();
 }
 
-export function isValidHostValue(value: string): boolean {
-  const normalized = value.trim();
-  if (normalized.length === 0) return false;
-  if (/\s/.test(normalized)) return false;
-  if (/^[a-z][a-z0-9+.-]*:\/\//i.test(normalized)) return false;
-  if (normalized.includes('/')) return false;
-  if (normalized.includes(':')) {
-    const unwrapped = normalized.startsWith('[') && normalized.endsWith(']')
-      ? normalized.slice(1, -1)
-      : normalized;
-    if (isIP(unwrapped) === 0) return false;
-  }
-  return true;
-}
-
-export function isLoopbackAddress(value: string): boolean {
-  const normalized = value.trim().toLowerCase();
-  return normalized === 'localhost'
-    || normalized === '::1'
-    || normalized === '[::1]'
-    || normalized === '0:0:0:0:0:0:0:1'
-    || /^127(?:\.\d{1,3}){3}$/.test(normalized);
-}
-
-export function uniqueNonEmpty(values: readonly string[]): readonly string[] {
-  return [...new Set(values.map((value) => normalizeText(value)).filter((value) => value.length > 0))];
-}
-
 export function makeNotNeededAcknowledgement(detail: string): OnboardingWizardAcknowledgementFieldDefinition {
   return {
     kind: 'acknowledgement',
@@ -65,7 +30,7 @@ export function makeNotNeededAcknowledgement(detail: string): OnboardingWizardAc
 
 export function buildDefaultDerivedState(): OnboardingStepDerivationState {
   return {
-    step1Capabilities: DEFAULT_CAPABILITIES,
+    step1Capabilities: [],
     step1_5NetworkMode: 'local-network-default',
     reopenEditAcknowledgements: {
       providers: {
@@ -125,21 +90,6 @@ export function modelSelectionLabel(selection: OnboardingWizardModelSelection |
   return `${provider}/${model}`;
 }
 
-export function getExternalSurfaceSetupFieldSpec(fieldId: string): ExternalSurfaceSetupFieldSpec | null {
-  for (const surface of EXTERNAL_SURFACE_SPECS) {
-    const field = surface.fields.find((entry) => entry.id === fieldId);
-    if (field) return field;
-  }
-  return null;
-}
-
-export function getExternalSurfaceSpecByFieldId(fieldId: string): ExternalSurfaceSpec | null {
-  for (const surface of EXTERNAL_SURFACE_SPECS) {
-    if (surface.fields.some((entry) => entry.id === fieldId)) return surface;
-  }
-  return null;
-}
-
 export function getRuntimeDerivedState(hydration: OnboardingWizardRuntimeHydration): OnboardingStepDerivationState {
   if (hydration.derived) {
     const fallback = buildDefaultDerivedState();
@@ -154,7 +104,6 @@ export function getRuntimeDerivedState(hydration: OnboardingWizardRuntimeHydrati
     };
   }
 
-  if (hydration.snapshot) return deriveOnboardingStepState(hydration.snapshot);
   return buildDefaultDerivedState();
 }